Re: [PATCH 2 of 4] Fix various resource leaks throughout sendlib.c

2009-04-06 Thread Erik Hovland
>> >> -  CONTEXT f; >> >> +  CONTEXT *f = NULL; >> > >> > Here I don't understand what the leak should be. It just changes from >> > stack to allocated memory causing more overhead I think. Can you explain >> > why you change this? > >> Heh, the problem here is that the function that clears CONTEXT

Re: [PATCH 2 of 4] Fix various resource leaks throughout sendlib.c

2009-04-06 Thread Rocco Rutte
Hi, * Erik Hovland wrote: > >> -  FREE (tcode);                /* __FREE_CHECKED__ */ > >> +  FREE (&tcode);               /* __FREE_CHECKED__ */ > > > > The same for the use of FREE(). This is probably wrong. > I'll have to look again. But if I recall tcode is allocated and since > FREE takes t

Re: [PATCH 2 of 4] Fix various resource leaks throughout sendlib.c

2009-04-05 Thread Erik Hovland
>> # HG changeset patch >> # User Erik Hovland >> # Date 1237420329 25200 >> # Branch HEAD >> # Node ID 1b97d4b561846e0d77e8216bde94f7c2637a0149 >> # Parent  9ccf56c08a039ffa448fbd3f34c659a19fcb6ae4 >> Fix various resource leaks throughout sendlib.c > >> diff --git a/sendlib.c b/sendlib.c >> --- a

Re: [PATCH 2 of 4] Fix various resource leaks throughout sendlib.c

2009-04-05 Thread Rocco Rutte
Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1237420329 25200 # Branch HEAD # Node ID 1b97d4b561846e0d77e8216bde94f7c2637a0149 # Parent 9ccf56c08a039ffa448fbd3f34c659a19fcb6ae4 Fix various resource leaks throughout sendlib.c diff --git a/sendlib.c b/sendlib.c -

[PATCH 2 of 4] Fix various resource leaks throughout sendlib.c

2009-04-02 Thread Erik Hovland
1 file changed, 14 insertions(+), 12 deletions(-) sendlib.c | 26 ++ # HG changeset patch # User Erik Hovland # Date 1237420329 25200 # Branch HEAD # Node ID 1b97d4b561846e0d77e8216bde94f7c2637a0149 # Parent 9ccf56c08a039ffa448fbd3f34c659a19fcb6ae4 Fix various resource