Hi, * Erik Hovland wrote:
# HG changeset patch # User Erik Hovland <e...@hovland.org> # Date 1237420329 25200 # Branch HEAD # Node ID 1b97d4b561846e0d77e8216bde94f7c2637a0149 # Parent 9ccf56c08a039ffa448fbd3f34c659a19fcb6ae4 Fix various resource leaks throughout sendlib.c
diff --git a/sendlib.c b/sendlib.c --- a/sendlib.c +++ b/sendlib.c @@ -828,7 +828,7 @@ for (i = 0; i < ncodes; i++) FREE (&tcode[i]); - FREE (tcode); /* __FREE_CHECKED__ */ + FREE (&tcode); /* __FREE_CHECKED__ */
The same for the use of FREE(). This is probably wrong.
int mutt_write_fcc (const char *path, HEADER *hdr, const char *msgid, int post, char *fcc) { - CONTEXT f; + CONTEXT *f = NULL;
Here I don't understand what the leak should be. It just changes from stack to allocated memory causing more overhead I think. Can you explain why you change this? Rocco