Re: Threading representation within Index

On Mon, Aug 17, 2009 at 12:08:58PM -0700, Mun Johl wrote: > > I'm trying to find out what else I need to modify in the header so that > mutt can function properly. I think you also want to look at least at References: or In-Reply-To: (and sometimes Message-Id:). These are the only headers related

Re: new mail handling status

Hi, * Antonio Radici wrote: > ok, so I probably come across a different issue and what is in hg is > fixing it, now I have to find the right commit to backport =) Just follow the daily logs sent to mutt-dev or subscribe to the rss feed or use whatever else you prefer. There're actually two issue

Re: new mail handling status

Hi, * Antonio Radici wrote: > So I was wondering what is the status of the mail handling in the hg > repository > and if I could start to backport it to 1.5.20; is it complete? How far is it > from being completed? What is left? http://dev.mutt.org/trac/wiki/NewMailHandling This page contains

Re: [Mutt] #3314: segfault when searching "~b something="

Hi, * Moritz Barsnick wrote: > So, this was not a valid search pattern? I should have used > "~b somestring\="? That seems to give me a lot of false positives (to > be confirmed). Yes you have to because = is a denotes a pattern just like ~ does, except that all ~ patterns works on regex and = o

Re: [PATCH] manual: fix wrong spell checker assumptions

Hi, * Christian Ebert wrote: > # HG changeset patch > # User Christian Ebert > # Date 1249822422 -7200 > # Branch HEAD > # Node ID 0153dbc12dc4b3118511317717a7e6f2b92355d4 > # Parent 59b4c73e7254c9b92db1ae5670a16392324bd134 > manual: fix wrong spell checker assumptions Uh, how embarrassing. I d

Re: mutt problem

On Tue, Aug 04, 2009 at 11:03:33PM -0500, Kyle Wheeler wrote: > I wonder if a new mutt option, such as $imap_autoreconnect (or > whatever you wanna call it) would be good, to make mutt recontact > the remote server if the connection is severed for whatever reason. This is on the radar (http://dev

Stripped subjects

Hi, with mails from Trac sent to over mutt-dev list, only the first line from a folded subject survive; all other stripped. The copies sent to me directly are fine. So I think it's somewhere close to the list server. Who should I contact? Rocco

Re: [PATCH] Support --docdir, complain if that conflicts with

Hi, * Brendan Cully wrote: [...] Just a note: doc/devel-notes.txt says we require 2.59. Rocco pgpEq9nyqZsmD.pgp Description: PGP signature

Re: [PATCH] If --with-docdir isn't given, fall back to --docdir.

Hi, * Matthias Andree wrote: > You wouldn't be telling this to users, but to developers. Only those > checking out from Mercurial will need to run autoconf. Hmm, right. > For developers, we can bump AC_PREREQ([2.54]) to AC_PREREQ([2.60]) so > that older autoconf versions refuse operation. That

Re: [PATCH] fix :reset to work with empty strings

Hi, * Aron Griffis wrote: > # HG changeset patch > # User Aron Griffis > # Date 1248406601 14400 > # Branch HEAD > # Node ID 1034d95a166a99316657b1ed83582a9be40b31fd > # Parent 1597c2074a5284c401a62ef52ed495d86bb09321 > fix :reset to work with empty strings Pushed, thanks. Rocco pgpTDkkZ2Vv

Re: [PATCH 0 of 2] Fix several compiler warnings.

Hi, * Matthias Andree wrote: > These are minor cleanups to fix a few compiler warnings. I've pushed both, thanks! Rocco pgphEf3egLP7u.pgp Description: PGP signature

Re: [PATCH] If --with-docdir isn't given, fall back to --docdir.

Hi, * Matthias Andree wrote: > # HG changeset patch > # User Matthias Andree > # Date 1247006816 -7200 > # Branch HEAD > # Node ID 6fb746b71758dfe7eda021a119d45b0d7e262f72 > # Parent a3c4b605cfada5be4c9234cbdaa4424206b06fa5 > If --with-docdir isn't given, fall back to --docdir. Else warn. With

Re: Quoting of parentheses in regular expressions

Hi, * Lars Hecking wrote: > The subject line starts with "RC(ci): [string]". Problem is, I cannot get > any combination of "'\ to recognise the parentheses and square brackets > as non-special. E.g. neither of I think you need to double-escape the brackets: save-hook '~s RC\\(ci\\):\ \\[st

Re: [Mutt] #3298: Mutt's way to get the FQDN is broken

Hi, * Derek Martin wrote: > I would be willing to hack up a patch for this, if someone can explain > the rammifications of IDN here. getaddrinfo() can handle IDN if you > use the AI_IDN flag. Also, I'd like to solicit comments about whether > the code should try to use getaddrinfo(), gethostbyad

Re: keymap.c: HAVE_GPGME -> CRYPT_BACKEND_GPGME?

Hi, * Fabian Groffen wrote: > so it looks as if HAVE_GPGME will never actually be defined, so the > HAVE_GPGME should just be replaced with CRYPT_BACKEND_GPGME in keymap.c? Yes, I've pushed that change. However, I'm not entirely sure why we have two different menu codes and muttrc-identifiers f

Re: [PATCH v2] make send-hooks work for batch mode

On Tue, Jul 14, 2009 at 08:25:46PM -0700, Brendan Cully wrote: > Sorry. It's applied now. I'm not really sure, but maybe this deserves an entry in UPDATING? Rocco

Re: [Mutt] #2995: Mutt is folding subject line folds using a tab,

Hi, * Derek Martin wrote: > Sure, but not easily... I don't have and don't use mercurial. I'm > pretty busy this weekend, so not sure I'll have time to get to it > soon. Just for the archives, you don't need mercurial for it. The web interface at dev.mutt.org/hg/mutt support styles, including a

Re: fixing mutt

Hi, * Kyle Wheeler wrote: > What I do is simply allow interrupts during socket reads. It's > clunky, because it aborts the connection, but it gets the job done > (see attachment). Well, this doesn't seem too unreasonable. In case errno=EINTR, why not make the socket functions return -1 in genera

Re: bce and clrtoeol()

Hi, * Kyle Wheeler wrote: > I read the man page on clrtoeol(), and on my system, it says that it > fills in the background with the color set by wbkgdset() (rather than > simply the color set by bkgdset(), as mutt uses). Are bkgdset and > wbkgdset supposed to be interchangeable? The latter works

Re: [PATCH 0 of 2] minor build and INSTALL fixes

On Tue, Jul 07, 2009 at 10:33:19PM +0200, Matthias Andree wrote: > Does any of the core maintainers NOT having GNU gettext 0.17 installed? Me. fink/unstable on OS X only has 0.14.5 as the latest. Rocco

Re: [PATCH 0 of 2] minor build and INSTALL fixes

Hi, * Matthias Andree wrote: > >* Matthias Andree wrote: > >>Patch 1 removes a file from the repo that is installed by autoreconf > >>as part of prepare. > >Not for me. Neither on OS X nor on Debian squeeze. On OSX I have > >autoconf 2.63 and automake 1.10.2, and on Debian 2.63/1.9.6. > then yo

Re: [PATCH 0 of 2] minor build and INSTALL fixes

Hi, * Matthias Andree wrote: > Patch 1 removes a file from the repo that is installed by autoreconf > as part of prepare. Not for me. Neither on OS X nor on Debian squeeze. On OSX I have autoconf 2.63 and automake 1.10.2, and on Debian 2.63/1.9.6. > Patch 2 updates the VPATH information in INSTA

Re: Unicode on macs

Hi, * Fabian Groffen wrote: > On 10.4 this gives me a file containing "ab" regardless which shell I > use, or if I'm logged into a Solaris or Linux system (using ssh). So is > it OSX, its Terminal.app, oor is it just that cat is dealing with bytes > only? Vim correctly removes two characters as

Unicode on macs (was: [Mutt] #1317: wish $edit_charset)

Hi, * Vincent Lefevre wrote: > $ cat > foo > > Then type "abé" (without the quotes), then [BackSpace] twice, then > [Return] and Ctrl-D, then "cat foo". This is not just a mere bug, > this can be seen as data corruption! Well, that gives me a file containing just "a". Just because the UI looks

$thorough_search ([Mutt] #1317: wish $edit_charset)

Hi, * Vincent Lefevre wrote: > I don't know what you mean here, but by default, Mutt does bad things > with charsets. The $thorough_search variable is broken by design and > should be removed. Can you explain that a bit, please? Rocco pgpM4Dmuz0ajG.pgp Description: PGP signature

Re: MAPI support

Hi, * Derek Martin wrote: > > http://www.openchange.org/index.php?option=com_content&task=view&id=15&Itemid=49 Looking around that site, using libmapi doesn't seem to be too complicated. But requiring samba and libmapi just to read mail?! Profile management could also be an issue to fit into

Re: [Mutt] #1317: wish $edit_charset

Hi, * Christian Ebert wrote: > set config_charset=iso-8859-1 > set reply_regexp=... > set config_charset=utf-8 Why don't you use iconv(1) to convert it? Mutt internally does the same in that case. Rocco pgpWwj5VAo2Wa.pgp Description: PGP signature

Re: [Mutt] #1317: wish $edit_charset

Hi, * Mutt wrote: > This is not a problem that needs fixing!!! The problem that needs > fixing is to make Unicode work properly where it doesn't. I think it isn't that long ago that OS X had partly broken wide character support since it's library was based on a too old FreeBSD one. In that ca

Re: [Mutt] #1317: wish $edit_charset

Hi, * Derek Martin wrote: > On Thu, Jul 02, 2009 at 12:39:10PM +0200, Rocco Rutte wrote: > > Mutt has $config_charset which, for the same reason, should be > > deprecated if I follow your argumentation because setting UTF-8 > > everywhere would make it'd be superflo

Re: mutt: 9 new changesets

Hi, * Aron Griffis wrote: > Rocco Rutte wrote: [Thu Jul 02 2009, 12:53:12PM EDT] > > http://dev.mutt.org/doc/manual.html#mailcap-search-order > Unless I'm missing something, the trio of rules I provided > already adhere to those instructions...? Yes, they do.

Re: mutt: 9 new changesets

Hi, * Kyle Wheeler wrote: > On Thursday, July 2 at 06:53 PM, quoth Rocco Rutte: > >http://dev.mutt.org/doc/manual.html#mailcap-search-order > I just noticed that in the third paragraph, the second wocka around > view-mailcap is backwards. It looks like . Fixed now,

Re: mutt: 9 new changesets

Hi, * Aron Griffis wrote: > Am I missing something? What Kyle wrote plus: http://dev.mutt.org/doc/manual.html#mailcap-search-order (last paragraph) Rocco pgpOJ63EPOjbT.pgp Description: PGP signature

Re: [Mutt] #1317: wish $edit_charset

Hi, * Derek Martin wrote: > On Wed, Jul 01, 2009 at 09:36:11AM +0200, Vincent Lefevre wrote: > > No, you did not understand the problem and what the user wants. The > > user wants to edit the message in UTF-8 even though his terminal uses > > another charset. > I understood perfectly well. I ju

Re: fcc and walking around mailboxes

Hi, * Pawel Dziekonski wrote: > can we keep this bug fix and not change folder history functionality? Basically: no, because the list of folders you get presented contains only folders with new mail. Either we revert the fix and it's in the list, or we leave it as it is and it's not in. Note tha

Re: atime/mtime

Hi, * Brendan Cully wrote: > I think we'll end up making a table of how new mail and unread old > mail should be handled by the buffy list, c' ', > c, mutt startup, etc. A long time ago Vladimir > Marek started on this, but I got busy and dropped it. I've started collecting ideas at: http://dev

Re: mutt: 5 new changesets

Hi, * Rocco Rutte wrote: [...] Since I like the idea quite a lot, I've put this in my queue with tiny documentation added: http://bitbucket.org/pdmef/muttpdmefmq/src/tip/patch-1.5.20hg.pdmef.attachparam.1 Rocco

Re: fadvise WILLNEED for tokyocabinet header cache

Hi, * Andrea Arcangeli wrote: > What if I can guarantee you that I don't modify the 'cur' directory > under 'mutt'. Ah, that reminds me of something. The hcache isn't updated when you append a message to a cached folder. That would need to be done first. Btw, I've made a patch more suitable for

Re: [PATCH] remove bogus FREE

Hi, * Aron Griffis wrote: > # HG changeset patch > # User Aron Griffis > # Date 1245455779 14400 > # Branch HEAD > # Node ID ee3d174297bb38fd461253f5f8d340c31a7db4c8 > # Parent 9ae13dedb5ede4d0bfbbd65e21a200bae23b4e3b > remove bogus FREE > > It's impossible for cur->personal to be non-NULL at t

Re: site updates

Hi, * Brendan Cully wrote: > On Thursday, 25 June 2009 at 14:03, William Yardley wrote: > > Does Jeremy still maintain the main mutt.org site? > > > > It hasn't been updated for 1.5.20 release. > > I pinged him Monday. His response: "ack" > > I think that probably means he's busy. I don't know

Re: mutt: 5 new changesets

Hi, * Kyle Wheeler wrote: > What about instituting something similar to the existing format > markers? Just as mutt indicates in the compose menu that the text > attachment will be encoded as quoted-printable, how about a similar > (toggle-able) marker to tell the user whether or not f=f will be

Re: mutt: 5 new changesets

Hi, * Kyle Wheeler wrote: > How hard would it be for mutt to re-wrap format=flowed messages > before sending, in order to guarantee that the lines are less than > the format=flowed limit (72/79 characters). That wouldn't be too hard. > More generally... RFC 2646 says: (2646 is obsoleted by 367

Re: 4b5326d8d2ee breaks viewing of text/html with needsterminal

Hi, * Christian Ebert wrote: > * Brendan Cully on Thursday, June 25, 2009 at 13:56:21 -0700 > > I'm now thinking the new behaviour may be better: > Me too ;-) ...unless you have a copiousoutput entry before a needsterminal one -- vice versa it works. I'll document that tomorrow. Rocco

Re: 4b5326d8d2ee breaks viewing of text/html with needsterminal

Hi, * Christian Ebert wrote: > > Am I overlooking something? No, the fix shouldn't affect the attachment menu. > imho, I (like the reporter I have $implicit_autoview set) solved > the problem described in #3246 with according text/* entries at > the end of my mailcap file -- with the advantage t

Re: [Mutt] #3271: mutt 1.5.20 regression: not updating time fields

Hi, * Mutt wrote: > I've traced the problem back to cset b080ae086a62, which introduced > reset_atime() in the first place, and was the first attempt to fix bug > 1362. Is there any support for the behavior prior to this cset, or is > this something I'm going to have to maintain in a private

Re: atime/mtime

Hi, * Patrick Shanahan wrote: > * Rocco Rutte [06-23-09 17:16]: > > * Patrick Shanahan wrote: > > > > > One think I find lacking is a flag in the > > > directory listing similar to the "N", new mail flag, showing folders > > > containing &

Re: fadvise WILLNEED for tokyocabinet header cache

Hi, * Kyle Wheeler wrote: > On Tuesday, June 23 at 08:21 PM, quoth Rocco Rutte: > >The cache is updateable for some time now (weeks I think). > > That got pushed? Hmmm. Maybe I'm confused then. I still have this in > my mh.c; is it out-of-date? > > #if USE_HC

Re: atime/mtime

Hi, * Derek Martin wrote: > For what it's worth, the way I would most prefer to process my mail > would be like this: > 1. start mutt > 2. enter first mailbox (in order listed in .muttrc) which contains > new mail. > 3. move to the next mailbox in listed order *in a ring* containing >

Re: atime/mtime

Hi, * Patrick Shanahan wrote: > One think I find lacking is a flag in the > directory listing similar to the "N", new mail flag, showing folders > containing "O", old mail. I want to know where *unread* mail is, not > *just* new mail. This is not as easy at it sounds. At least (unfortunately) n

Re: fadvise WILLNEED for tokyocabinet header cache

Hi, * Kyle Wheeler wrote: > What about using the mtime/ctime timestamp on the cur directory to > determine whether it's changed since the last time it was read? All > flag changes, message deliveries, etc. *should* update the > directory's inode atime/ctime. That way you don't need a > configurat

Re: mutt: 4 new changesets

Hi, * Kyle Wheeler wrote: > Wow, that is *crazy* annoying! Not every message should be treated > like an error! Sorry for that. Rocco

Re: atime/mtime

Hi, * Moritz Barsnick wrote: > I applied these two on top of 1.5.20. But I think changeset > 5922:9ae13dedb5ed doesn't make sense to me. By (mutt's) definition a mailbox has new mail if it has as least one message that is neither read, nor deleted, nor marked as old. That's the way it works for

Re: fadvise WILLNEED for tokyocabinet header cache

Hi, * Andrea Arcangeli wrote: > On Sun, Jun 21, 2009 at 11:05:28PM +0200, Rocco Rutte wrote: > > points that would have to be solved to get the patch ready for > > inclusion. For example test if posix_fadvise() is available, why only > > That requires a configure knob?

Re: changeset 5920 / manual.xml.head

Hi, * Vincent Lefevre wrote: > First, there's a small typo: mutt -> Mutt. Good catch. > Also, I'd say simply (if I understand correctly): > In case of parsing errors, Mutt will print error messages. Done, thanks. Rocco

Re: changeset 5920 / manual.xml.head

Hi, * Vincent Lefevre wrote: > No, the fact that it seems to work doesn't mean that it is allowed. > Never use undocumented features! Well, actually this is documented for years (4713:9f3afe005e3d). Rocco

Re: fadvise WILLNEED for tokyocabinet header cache

Hi, * Andrea Arcangeli wrote: > If there is interest I can do both > changes myself and repost a proper patch, this is a local hack for > myself so far. I think making it faster is always good. However, there're some more points that would have to be solved to get the patch ready for inclusion

Re: changeset 5920 / manual.xml.head

Hi, * Vincent Lefevre wrote: > On 2009-06-19 23:43:24 +0200, Rocco Rutte wrote: > Are these the only possibly assignments? Isn't it possible to do: > set my_foo=$my_bar > or > set status_format="-%r-Mutt: %f...%>-(%P)-$timeout--" I guess you

Re: changeset 5920 / manual.xml.head

Hi, * Vincent Lefevre wrote: > Whenever a user-defined variable is used in an assignment for a built-in > variable or vice versa, Mutt string representations to do the > assignment. As a result, a user-defined variable can be assigned to any > other variable under the restriction that its

Re: [PATCH] Mailbox Aliases

Hi, * Bertrand Janin wrote: > Here is the new patch adding the 'mbalias' command instead of updating > the 'mailboxes' syntax, it feels a lot cleaner and allows the following: > > mbalias somewhere imaps://user:passw...@imap.myhost.com/Somewhere/ > mbalias localstuff =projects/x/archive

Re: [PATCH] Mailbox Aliases

Hi, * Bertrand Janin wrote: > Yes, this would break. I'm not sure why someone would use '!!=foo' as a > parameter to 'mailboxes' though ;) You wrongly assume all config lines mutt gets are intentional the way they are. :) Typos for example can occur. With: mailboxes !=foo a user could actua

Re: [PATCH] Mailbox Aliases

Hi, * Kyle Wheeler wrote: > On Wednesday, June 17 at 05:28 PM, quoth Rocco Rutte: > >>This would appear to break situations like mine, where I use '=' to > >>refer to $folder: > >>mailboxes = =friends =mutt > >No, because mutt_expand_p

Re: [PATCH] Mailbox Aliases

Hi, * Kyle Wheeler wrote: > This would appear to break situations like mine, where I use '=' to > refer to $folder: > mailboxes = =friends =mutt No, because mutt_expand_path() is called in advance that would expand a leading '=' using $folder. However, ==foo is kind of broken. Rocco

Re: [PATCH] Mailbox Aliases

Hi, * Bertrand Janin wrote: [...] > diff -r d213f3acdb68 buffy.c > --- a/buffy.c Mon Jun 15 14:24:27 2009 -0700 > +++ b/buffy.c Tue Jun 16 23:04:04 2009 -0400 > +/* Strip out alias for later */ > +if ((p = strchr(buf, '=')) != NULL) > +{ > + len = p - buf; > + alias = mall

Re: Checking envelope-to header for reverse_name ?

Hi, * Kyle Wheeler wrote: > On Thursday, June 11 at 11:44 PM, quoth Heinrich Langos: > >When exactly are "References:" headers added? Sorry to digres but I > >am curious if my solution of deleting the "In-Reply-To:" header is > >sufficient. It is. References are generated if and only if you leav

Re: imap recent

Hi, * Kyle Wheeler wrote: > Ahhh, I assumed that you did use it. Yeah, you'd have to enable it. > Hmm. I don't know how mutt handles new/old tracking on IMAP without > the header cache, but with a mailbox that big, it's going to be well > worth your while to enable it. I think via message flags.

Re: 1.5.10 -> 1.5.19 issue

Hi, * Ken Weingold wrote: > I uploaded my mutt from 1.5.10 to 1.5.19 and find that 1.5.19 is not > notifying me of any new mail in anything but my spool folder. No > problems going back to 1.5.10. Any ideas why this would be? Is the sidebar patch with maildir-type folders involved? Rocco

Re: mutt: 9 new changesets

Hi, * Brendan Cully wrote: > http://dev.mutt.org/hg/mutt/rev/0024860ab03e > changeset: 5841:0024860ab03e > branch: HEAD > tag: tip > user:Brendan Cully > date:Sun May 31 19:19:21 2009 -0700 > summary: Allow chunked and unchunked manuals to build in parallel. T

Re: [Mutt] #2995: Mutt is folding subject line folds using a tab,

[ Sorry for the looong delay, I just overlooked this one. ] Hi, * Derek Martin wrote: > On Sat, Apr 25, 2009 at 11:20:10AM +0200, Rocco Rutte wrote: > > > I suspect the fundamental problem is that whoever wrote this wanted it > > > to be used both for writing the hea

[PATCH] Reset atime when leaving mbox/mmdf with new mail

Hi, the attached patch is supposed to set atime=mtime-1 for mbox and mmdf folders if they contain new mail upon sync as we do for other folder types. This only works if $check_mbox_size is unset. See also ticket #1362. I think the patch is okay. But I don't know why the old code does restore ati

Re: [Mutt] #2995: Mutt is folding subject line folds using a tab,

Hi, * Derek Martin wrote: > Actually, taking another look at this, I don't understand why this > function exists at all... As far as I can tell, there are no > circumstances under which a header should *ever* contain any > characters other than 7-bit ASCII. RFC (2)822 clearly states so, and > t

Re: service name in smtp_url

Hi, * Jukka Salmi wrote: [...] > If this is done deliberately I think it should be documented. Or is it > and I missed it? Yes, see http://dev.mutt.org/doc/manual.html#url-syntax. For some protocols, it uses getservbyname() to determine the port if none is given in the URL. For using the sub

Re: [Mutt] #2995: Mutt is folding subject line folds using a tab,

Hi, * Mutt wrote: > I don't see why this is so difficult. Granted the function is hairy > (which is a problem in and of itself), but it shouldn't be difficult > to simply insert a newline before some whitespace. However, that's > not what it does... it does this: > >/* Space paddin

Re: [PATCH 2 of 4] Fix various resource leaks throughout sendlib.c

Hi, * Erik Hovland wrote: > >> -  FREE (tcode);                /* __FREE_CHECKED__ */ > >> +  FREE (&tcode);               /* __FREE_CHECKED__ */ > > > > The same for the use of FREE(). This is probably wrong. > I'll have to look again. But if I recall tcode is allocated and since > FREE takes t

Re: [PATCH 3 of 4] q is never used

Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1237420844 25200 # Branch HEAD # Node ID d472c604b40dbef16dfa979713c24b4a6dc6c08f # Parent 1b97d4b561846e0d77e8216bde94f7c2637a0149 q is never used Pushed as af100710101e, thanks. Rocco

Re: [PATCH 4 of 4] Make sure childout string is valid before

Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1238019731 25200 # Branch HEAD # Node ID 106e9eab216a908e2fbb0be469648f608ad99f8c # Parent 0524ec5b903768d880d65e5b934473ee36144e01 Make sure childout string is valid before giving to unlink Pushed as a384511274e0, th

Re: [PATCH 2 of 4] Fix various resource leaks throughout sendlib.c

Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1237420329 25200 # Branch HEAD # Node ID 1b97d4b561846e0d77e8216bde94f7c2637a0149 # Parent 9ccf56c08a039ffa448fbd3f34c659a19fcb6ae4 Fix various resource leaks throughout sendlib.c diff --git a/sendlib.c b/sendlib.c -

Re: [PATCH 1 of 4] Try to correct usage of tempfile and *tempfile

Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1237316584 25200 # Branch HEAD # Node ID 022494f73fa54edbf039dc866fa069dcef51 # Parent 2285978866e2e9c788f62ddb7d0eee53afd2a36c Try to correct usage of tempfile and *tempfile Since tempfile is a double pointer chec

Re: [Mutt] #2960: Terminal resize problem after editor is called

Hi, * Thomas Dickey wrote: On Thu, 2 Apr 2009, Mutt wrote: Strange, I can no longer reproduce the problem on OS X 10.5.6 using Terminal.app. But I can reproduce it on Debian unstable using ncurses 5.7.20081213. zsh 4.2.6 from fink on OS X, bash 3.2.17 shipping with OS X in Terminal.app and

Re: [PATCH] Sort the 'Incoming' buffy list

Hi, * Jan Larres wrote: # HG changeset patch # User Jan Larres # Date 1238600385 -7200 # Branch buffysort # Node ID 102051634e013818d31d36f6d83542e0d4422619 # Parent 8205a12329d395b87eeb890cb86d28e761e83992 Sort the 'Incoming' buffy list Sort the 'Incoming' buffy list with regard to the so

Re: crash in realpath()

Hi, * Miroslav Lichvar wrote: https://bugzilla.redhat.com/show_bug.cgi?id=492861 Pushed as 8205a12329d3, thanks. Rocco

Re: [Mutt] #2938: mutt freezes some times when accessing imap

Hi, * Mutt wrote: configuration relative to imap : set mail_check=1 set imap_idle=yes set imap_keepalive=2 These settings are insane. You tell mutt to poll _all_ mailboxes for new mail _every_ _second_. I doubt the check can be completed in way less than 1 second. Second, keepalive is insane

Re: [PATCH 06 of 16] ctx might be null. Check it earlier

Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1236891080 25200 # Branch HEAD # Node ID 43c02f38d2127c88da18495a6c9c7c1bf5e007a7 # Parent d56f727afd7dcb5f95d4d82fa262699c707d8844 ctx might be null. Check it earlier. ctx cannot be NULL I think because mutt_set_flag

Re: [PATCH 13 of 16] The assigned value 't' is never used. Remove

Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1236899484 25200 # Branch HEAD # Node ID 9d7e16bed5696c5b1e9a71c703fb439df1e453e2 # Parent d600c2c8818d9b15a3fb707e58594d0005c1e05d The assigned value 't' is never used. Remove assignment. Pushed as a802b5127f09, than

Re: [PATCH 00 of 16] Minoi defects in mutt hg HEAD

Hi, * Erik Hovland wrote: [...] Summary: The following patches are pushed: 4, 15, 10, 9, 7, 11, 14, 16 I still need to look at 6 and 13 which should only leave the IMAP-related ones. Rocco

[PATCH] Colored progress bar

Hi, since I've asked several times for the patch, here we go. It adds a "progress" color item that draws a vertical progress bar in the last line. I find this easier to watch with just one eye for long operations than to scan percentages printed by mutt. Rocco comparing with ../pdmef/progress se

Re: [PATCH 16 of 16] free intermediates in error path

Hi, * Erik Hovland wrote: Static analyzers do shine. But only when humans use them right. Here is the corrected patch for the same thing after fixing my usage of the tool. Sorry for being so tenacious on this issue. I'm still not convinced this is right. The first free is okay. But in case o

Re: [PATCH 03 of 16] Since contex_sb might be uninitialized, it is

Hi, * Erik Hovland wrote: @@ -285,12 +288,6 @@ #ifdef USE_POP  if (!Context || Context->magic != M_POP) #endif -  /* check device ID and serial number instead of comparing paths */ -  if (!Context || !Context->path || stat (Context->path, &contex_sb) != 0) -  { -    contex_sb.st_dev=0; -    con

Re: compile errors on latest pull from dev.mutt.org/hg

Hi, * John J. Foster wrote: System: Mac w/10.5.6 [...] Undefined symbols: "_wcscasecmp", referenced from: In tip I've added a compatibility function so that it compiles if it's missing from the system. Sorry for the breakage. Rocco

Re: [PATCH 03 of 16] Since contex_sb might be uninitialized, it is

Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1236890095 25200 # Branch HEAD # Node ID b4cf86788470dceb7bc4f80edc7f9b7098839a43 # Parent abb26dfac5656d678607e215f36a1c52db460a19 Since contex_sb might be uninitialized, it is better to zero it and remove the conditio

Re: [PATCH 16 of 16] free intermediates in error path

Hi, * Erik Hovland wrote: # HG changeset patch # User Erik Hovland # Date 1236899608 25200 # Branch HEAD # Node ID b195a368657041f8ad2a537dfeccf7b876b299c2 # Parent dfcfb5a6d00dec73c1ffa91e46f7fe37fe2aea50 free intermediates in error path. Doesn't that function contain more error checks whe

Re: [PATCH 14 of 16] Use safe_fclose in pgpkey.c

Hi, * Erik Hovland wrote: # User Erik Hovland # Date 1236899523 25200 # Branch HEAD # Node ID cd6b3c9bd20e5bb9d6dfc55c1201afd7d4b6d6a3 # Parent 9d7e16bed5696c5b1e9a71c703fb439df1e453e2 Use safe_fclose in pgpkey.c I've pushed a change that changes all fclose() calls to safe_fclose() once we

Re: Parent match patch (ticket 3144)

Hi, * Jeremie Le Hen wrote: Two months ago, I sent a parent match patch to this list and I've been told that you were in code slush. Now I noticed that mutt patch number has been bumped from 1.5.18 to 1.5.19, so I guess it's now ok to commit such a change. Nope. We're trying to maintain feat

Re: IMAP timeout during SMTP transmission

Hi, * Kyle Wheeler wrote: I found a situation where mutt can sometimes forget about its connections: when using smtp to send email. Apparently during transmission, mutt forgets about $imap_timeout (or any of the other ones). Thus, if my IMAP server disconnects people who are idle for 10 m

Re: bug hunting party

Hi, * Derek Martin wrote: I have a thought about the approach to fix #2560: http://dev.mutt.org/trac/ticket/2560 The first time Mutt needs to call iconv, it should get (and cache) the list of available encodings (the equivalent of iconv -l from the command line). If the message's encoding i

Re: mutt: 6 new changesets

Hi, * Brendan Cully wrote: http://dev.mutt.org/hg/mutt/rev/37ed3cc8d40c changeset: 5625:37ed3cc8d40c branch: HEAD user:Brendan Cully date:Fri Jan 02 22:37:42 2009 -0800 summary: More tyops http://dev.mutt.org/hg/mutt/rev/492c53436274 changeset: 5624:492c53436274 b

Re: [Mutt] #3145: atoi() is not safe (undefined behavior if value

Hi, * Mutt wrote: #3145: atoi() is not safe (undefined behavior if value is not representable) I have a patch adding strtol wrappers. I'll polish it up and attach to the ticket. Rocco

Re: [Mutt] #3142: [SMTP] Invalid EHLO for some smtp sessions

Hi, * Mutt wrote: A patch is attached, the problem was an uninitialized variable and a wrong check of the DOMAIN string. It's not that easy I think. If Fqdn is "@" it means uname() didn't report a hostname and getdnsdomainname() returned -1 and mutt is compiled without a fixed domain name. I.

Re: [PATCH] Disable line wrapping for Message-ID header (try 2)

Hi, * Peter Collingbourne wrote: I am resending this patch as it seems to have been overlooked. Pushed as 2fefd56f440c, thanks. Rocco

Re: [PATCH] Disable line wrapping for Message-ID header (try 2)

Hi, * Peter Collingbourne wrote: It seems that during parsing any illegal characters within the message-id are stripped by mutt_extract_message_id. Therefore the message-id passed to mutt_write_rfc822_header should be valid and printable using fprintf. ACK. I'm going to commit this this if n

Re: mutt: 11 new changesets

Hi, * Brendan Cully wrote: http://dev.mutt.org/hg/mutt/rev/7b46e23ae476 changeset: 5607:7b46e23ae476 branch: HEAD user:Erik Hovland date:Tue Dec 16 12:53:19 2008 -0800 summary: Remove redundant int clamping I think this change is actually wrong. The sign of a%b in

Re: [PATCH] Parent and childs match pattern modifiers

Hi, * Jeremie Le Hen wrote: Now I know this is because the code is somewhat freezed for bug shooting. How can I ensure that it won't be forgotten? Should I submit it into Trac or should I come back later when the development branch will be re-opened to new features? I think the BTS is the be

  1   2   3   4   >