Re: [PATCH] Clarify CH_WEED debug message

2020-05-07 Thread Petr Pisar
On Fri, May 08, 2020 at 06:42:57AM +0200, Claus Assmann wrote: > On Thu, May 07, 2020, Remco Rijnders wrote: > > > - dprint (1, (debugfile, "WEED is %s\n", (flags & CH_WEED) ? "Set" : > > "Not")); > > + dprint (1, (debugfile, "WEED is %s\n", (flags & CH_WEED) ? "Set" : "Not > > Set")); > > Sa

Re: [PATCH] Clarify CH_WEED debug message

2020-05-07 Thread Claus Assmann
On Thu, May 07, 2020, Remco Rijnders wrote: > - dprint (1, (debugfile, "WEED is %s\n", (flags & CH_WEED) ? "Set" : "Not")); > + dprint (1, (debugfile, "WEED is %s\n", (flags & CH_WEED) ? "Set" : "Not > Set")); Save some bytes:-) dprint (1, (debugfile, "WEED is %sSet\n", (flags & CH_WEED) ? ""

Re: [PATCH] Remove commented out mutt_message_hook calls

2020-05-07 Thread Kevin J. McCarthy
On Thu, May 07, 2020 at 07:41:43PM -0400, Remco Rijnders wrote: --- recvcmd.c | 4 1 file changed, 4 deletions(-) Given that those were commented out 20 years ago, that seems reasonable. I've commmited this too. Thank you. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5

Re: [PATCH] Clarify CH_WEED debug message

2020-05-07 Thread Kevin J. McCarthy
On Thu, May 07, 2020 at 07:17:42PM -0400, Remco Rijnders wrote: --- copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Committed. Thank you. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA signature.asc Description: PGP signature

[PATCH] Remove commented out mutt_message_hook calls

2020-05-07 Thread Remco Rijnders
--- recvcmd.c | 4 1 file changed, 4 deletions(-) diff --git a/recvcmd.c b/recvcmd.c index e6fd0e67..d7e18319 100644 --- a/recvcmd.c +++ b/recvcmd.c @@ -648,7 +648,6 @@ static void attach_forward_msgs (FILE * fp, HEADER * hdr, if (cur) { - /* mutt_message_hook (cur->hdr, MUT

[PATCH] Clarify CH_WEED debug message

2020-05-07 Thread Remco Rijnders
--- copy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/copy.c b/copy.c index 5e84b717..b6c9d781 100644 --- a/copy.c +++ b/copy.c @@ -141,7 +141,7 @@ mutt_copy_hdr (FILE *in, FILE *out, LOFF_T off_start, LOFF_T off_end, int flags, } } - dprint (1, (debugfile, "WE

missing translations in exit_handler (signal caught)

2020-05-07 Thread Vincent Lefevre
When Mutt quits due to a signal, I get, e.g. Caught signal 3... Exiting. untranslated. The reason it is not translated is that _() can invoke malloc(), which may not be re-entrant. Note that this was fixed by Kevin on 2019-11-10. Translations were done in the past, and with ^\ (SIGQUIT), Mutt co

Re: Use curses' raw instead of cbreak mode to capture \C[cyz\]

2020-05-07 Thread Vincent Lefevre
On 2020-05-07 13:13:49 +0200, Gero Treuner wrote: > I don't think that raw mode per se changes the terminal configuration. It necessarily does at some point. I suppose that this is like "stty raw", which is described as: rawsame as -ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr

Re: Use curses' raw instead of cbreak mode to capture \C[cyz\]

2020-05-07 Thread Vincent Lefevre
On 2020-05-07 10:28:38 +0200, Christopher Zimmermann wrote: > On Thu, May 07, 2020 at 09:52:14AM +1000, Cameron Simpson wrote: > > > uses cbreak and therefore the terminal will still catch and > > > interpret \Cc (SIGINT), \034 (SIGQUIT), \Cy (SIGSTOP on next read), > > > \Cz (SIGSTOP). > > > > Th

Re: Use curses' raw instead of cbreak mode to capture \C[cyz\]

2020-05-07 Thread Gero Treuner
On Thu, May 07, 2020 at 01:13:49PM +0200, Gero Treuner wrote: > > > That's bad because it doesn't honor the way the user has configured > > > his terminal. Moreover, I fear that in case of crash, this may leave > > > the terminal settings in the altered state (zsh offers protection, > > > though).

Re: Use curses' raw instead of cbreak mode to capture \C[cyz\]

2020-05-07 Thread Gero Treuner
Hi Christopher, On Thu, May 07, 2020 at 10:28:38AM +0200, Christopher Zimmermann wrote: > On Thu, May 07, 2020 at 09:52:14AM +1000, Cameron Simpson wrote: > > On Thu, May 07, 2020 at 03:57:37AM +0200, Vincent Lefevre wrote: > > > On my Mutt pages https://www.vinc17.net/mutt/index.en.html > > I m

Re: Use curses' raw instead of cbreak mode to capture \C[cyz\]

2020-05-07 Thread Oswald Buddenhagen
On Thu, May 07, 2020 at 09:52:14AM +1000, Cameron Simpson wrote: On 06May2020 11:44, Christopher Zimmermann wrote: uses cbreak and therefore the terminal will still catch and interpret \Cc (SIGINT), \034 (SIGQUIT), \Cy (SIGSTOP on next read), \Cz (SIGSTOP). That is desirable, so that mutt ca

Re: Use curses' raw instead of cbreak mode to capture \C[cyz\]

2020-05-07 Thread Christopher Zimmermann
On Thu, May 07, 2020 at 09:52:14AM +1000, Cameron Simpson wrote: I will need to try this on an OpenBSD box, but on a Mac here (also a BSD descendant), this: stty dsusp undef; mutt -f /Users/cameron/mail/mutt lets mutt see ^Y as a keystroke. I would think you should be able to do the same on