[PATCH 2/2] libqcdm: remove useless checks on always true condition

result.c: In function ‘qcdm_result_add_u8_array’: result.c:338:36: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] qcdm_return_if_fail (array_len >= 0); result.c: In function ‘qcdm_result_add_u16_array’: result.c:418:36: error: comparison of unsigned expres

[PATCH 1/2] modem-helpers: remove useless checks on always true condition

mm-modem-helpers.c:3075:31: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] g_return_val_if_fail (idx >= 0, NULL); ^ --- src/mm-modem-helpers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mm-modem-helpers.c b/src/mm

[PATCH] build: ignore generated ChangeLog

--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 94023506..9846a32f 100644 --- a/.gitignore +++ b/.gitignore @@ -27,6 +27,7 @@ Makefile.in /libtool /TAGS /ABOUT-NLS +/ChangeLog /include/ModemManager-version.h /include/ModemManager-names.h --

Ipv6 w/openwrt

Is it possible to get ipv6 using modemmanager with openwrt? I created a dhcp ipv6 protocol interface and covered the wwan0. An ipv6 address shows up but still doesn't work. If I restart modemmanager or reboot while the ipv6 interface is active then nothing works. I have to delete/stop the ipv6 i

Re: [PATCH] ublox: fix username and password passed to +UAUTHREQ

On Fri, Oct 26, 2018 at 2:22 PM Dan Williams wrote: > > On Fri, 2018-10-26 at 10:59 -0700, Ben Chan wrote: > > --- > > plugins/ublox/mm-broadband-bearer-ublox.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > LGTM > Pushed to master. Thanks!

u-blox SARA R410M CAT M1 modem

Greetings, I'm working with a u-blox SARA R410M CAT M1 modem (https://www.u-blox.com/en/product/sara-r4n4-series) using Linux 4.15 and modem-manager-1.9.0 / libqmi-utils-1.21.4 from Aleksander's next PPA. My SIM is a Verizon 4G LTE Cat M1 SIM Card from Nibelink (https://nimbelink.com/Documentation

Re: [PATCH] ublox: fix username and password passed to +UAUTHREQ

On Fri, 2018-10-26 at 10:59 -0700, Ben Chan wrote: > --- > plugins/ublox/mm-broadband-bearer-ublox.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM > diff --git a/plugins/ublox/mm-broadband-bearer-ublox.c > b/plugins/ublox/mm-broadband-bearer-ublox.c > index 1adcaa26..76f307c8

Re: [BUG] TOBY-L210: Bearer's user and password are swapped in +UAUTHREQ command

Based on a few AT command reference found on u-blox website, it does seem like the username and password passed to +UAUTHREQ are swapped in ModemManager. I don't have any u-blox modem to verify, but you can try this patch: https://lists.freedesktop.org/archives/modemmanager-devel/2018-October/006

[PATCH] ublox: fix username and password passed to +UAUTHREQ

--- plugins/ublox/mm-broadband-bearer-ublox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/ublox/mm-broadband-bearer-ublox.c b/plugins/ublox/mm-broadband-bearer-ublox.c index 1adcaa26..76f307c8 100644 --- a/plugins/ublox/mm-broadband-bearer-ublox.c +++ b/plugins

[BUG] TOBY-L210: Bearer's user and password are swapped in +UAUTHREQ command

Hello everyone, I would like to report a small bug into bearer's connection on TOBY-L210. Here follows the information about my hardware (from mmcli): root@zynq7:~# ModemManager --version ModemManager 1.8.2 Copyright (C) 2008-2017 The ModemManager authors License GPLv2+: GNU GPL vers

Re: Infinite connection loop

Hi Aleksander, Great to hear your input on the issue, thank you! I have some preliminary positive results with the connection status check disabled. I would like to understand the consequences of this change though. Are there scenarios where pppd wouldn’t detect the disconnection? In other wor

Re: recipe for target 'mbim-enum-types.h' failed openwrt

On Wed, Oct 24, 2018 at 6:52 PM Russ Westrem wrote: > > Trying to compile modemmanager for openwrt and failing here. > > > make[8]: Entering directory > '/home/russ/openwrt/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/libmbim-1.16.2/src/libmbim-glib/generated' > GEN mbim-basic-conn

Re: Infinite connection loop

Hey, > After looking into this a lot more, I’m still not closer to a solution or a > root cause. For a while, I thought enabling debug logging for pppd (via the > NM_PPP_DEBUG environment variable for NetworkManager) resolved the issue. > However, it didn’t reliably. For the debug and non-debug

Re: Infinite connection loop

Hey, > It looks like I celebrated prematurely. As soon as I disabled the debug-level > logging for NetworkManager and ModemManager, the issue started to appear > again. This tells me that there is some sort of race condition. I’ll look > into this more but I’d appreciate if one of the maintaine

Re: Infinite connection loop

Hi,After looking into this a lot more, I’m still not closer to a solution or a root cause. For a while, I thought enabling debug logging for pppd (via the NM_PPP_DEBUG environment variable for NetworkManager) resolved the issue. However, it didn’t reliably. For the debug and non-debug case, I captu