Re: [PATCH 0/1] mbim modem: disable location interface

2017-04-02 Thread Thomas Voß
On Sun, Apr 2, 2017 at 9:18 AM, Aleksander Morgado wrote: > On Sat, Apr 1, 2017 at 10:11 PM, Thomas Voß > wrote: >> A simple patch to avoid MBIM modems reporting that they support the location >> interface. >> I haven't submitted patches to mailing list in quite a while, so please bear >> with

Re: [PATCH 1/1] mbim-modem: disable location interface

2017-04-02 Thread Thomas Voß
On Sun, Apr 2, 2017 at 10:37 AM, Aleksander Morgado wrote: > > On Sat, Apr 1, 2017 at 10:11 PM, Thomas Voß > wrote: > > MBIM does not support 3gpp location data right now. For that, > > we make sure that the location interface is not reported as > > supported by MBIM modems. > > --- > > Ideally,

Re: [PATCH 1/1] mbim-modem: disable location interface

2017-04-02 Thread Aleksander Morgado
On Sat, Apr 1, 2017 at 10:11 PM, Thomas Voß wrote: > MBIM does not support 3gpp location data right now. For that, > we make sure that the location interface is not reported as > supported by MBIM modems. > --- Ideally, we would be checking if the MBIM modem supports QMI over MBIM, and defaulting

Re: [PATCH 2/2] broadband-modem: normalize also operator code

2017-04-02 Thread Aleksander Morgado
On Sat, Apr 1, 2017 at 6:02 AM, Dan Williams wrote: > On Sat, 2017-03-25 at 21:39 +0100, Aleksander Morgado wrote: >> The operator code (MCCMNC) may also be given encoded in the current >> charset (e.g. UCS2). > > LGTM. > > Dan > Pushed to git master. >> Based on a patch from Colin Helliwell > >

Re: [PATCH 1/2] modem-helpers: if operator not in UCS2, see if already valid UTF-8

2017-04-02 Thread Aleksander Morgado
On 01/04/17 06:01, Dan Williams wrote: > On Sat, 2017-03-25 at 21:39 +0100, Aleksander Morgado wrote: >> The method doing the operator name normalization takes as input the >> current configured modem charset. If this is UCS2, we will now just >> assume this is a hint: the string may or may not com

Re: [PATCH] novatel: port custom init and IMSI loading to use GTask

2017-04-02 Thread Aleksander Morgado
Hey Ben, Looks like these 2 things could really be split into 2 different patches, could you do that? See other comments below inline. On Sat, Apr 1, 2017 at 8:05 PM, Ben Chan wrote: > --- > plugins/novatel/mm-common-novatel.c | 54 +++--- > plugins/novatel/mm-sim-novatel-lte.

Re: [PATCH 0/1] mbim modem: disable location interface

2017-04-02 Thread Aleksander Morgado
On Sat, Apr 1, 2017 at 10:11 PM, Thomas Voß wrote: > A simple patch to avoid MBIM modems reporting that they support the location > interface. > I haven't submitted patches to mailing list in quite a while, so please bear > with me > while I'm learning. No problem! What you did is perfectly fin