On Sun, Apr 2, 2017 at 9:18 AM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > On Sat, Apr 1, 2017 at 10:11 PM, Thomas Voß > <thomas.voss.boc...@gmail.com> wrote: >> A simple patch to avoid MBIM modems reporting that they support the location >> interface. >> I haven't submitted patches to mailing list in quite a while, so please bear >> with me >> while I'm learning. > > No problem! What you did is perfectly fine. One extra tip: > > When sending a single patch with git send-email, you don't really need > a cover letter (i.e. the PATCH 0/N email). Instead, you can abuse the > email formatting and embed the introduction email you would have in > the cover letter directly in the patch itself (e.g. with the > --annotate option in git send-email). Just make sure the format of the > introductory text goes inserted AFTER the commit message, like this: > > <snip> > MBIM does not support 3gpp location data right now. For that, > we make sure that the location interface is not reported as > supported by MBIM modems. > --- > > You add an extra line with "---" after the one you find in the patch, > and you add your introductory message in between. The content between > the two lines with "---" will not be included as part of the commit > message when it is "git am"-ed, but will still be visible in the patch > email. >
Great, thanks for the hint :) Cheers, Thomas > --- > src/mm-broadband-modem-mbim.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > <snip> > > > -- > Aleksander > https://aleksander.es _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
