Re: [Mingw-w64-public] [PATCH] crt: Avoid calling memset in crt_handler.c

2024-12-03 Thread Pali Rohár
On Wednesday 04 December 2024 00:02:11 Martin Storsjö wrote: > On Tue, 3 Dec 2024, Pali Rohár wrote: > > > It is not visible in the diff, but the functions starts with > > > > int > > __mingw_init_ehandler (void) > > { > >static int was_here = 0; > >size_t e = 0; > >PIMAGE_SECTION_

Re: [Mingw-w64-public] [PATCH] crt: Avoid calling memset in crt_handler.c

2024-12-03 Thread Martin Storsjö
On Tue, 3 Dec 2024, Pali Rohár wrote: It is not visible in the diff, but the functions starts with int __mingw_init_ehandler (void) { static int was_here = 0; size_t e = 0; PIMAGE_SECTION_HEADER pSec; PBYTE _ImageBase = _GetPEImageBase (); if (was_here || !_ImageBase) re

Re: [Mingw-w64-public] [PATCH] crt: Avoid calling memset in crt_handler.c

2024-12-03 Thread Pali Rohár
On Tuesday 03 December 2024 16:27:15 Martin Storsjö wrote: > On Tue, 3 Dec 2024, Martin Storsjö wrote: > > > On Wed, 27 Nov 2024, Pali Rohár wrote: > > > > > Explicitly initialize variable to zeros, which has same effect as > > > initialzing it via memset. > > > --- > > > mingw-w64-crt/crt/crt_ha

Re: [Mingw-w64-public] [PATCH] crt: Avoid calling memset in crt_handler.c

2024-12-03 Thread Martin Storsjö
On Tue, 3 Dec 2024, Martin Storsjö wrote: On Wed, 27 Nov 2024, Pali Rohár wrote: Explicitly initialize variable to zeros, which has same effect as initialzing it via memset. --- mingw-w64-crt/crt/crt_handler.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) LGTM, pushed. Thanks!

Re: [Mingw-w64-public] [PATCH] crt: Avoid calling memset in crt_handler.c

2024-12-03 Thread Martin Storsjö
On Wed, 27 Nov 2024, Pali Rohár wrote: Explicitly initialize variable to zeros, which has same effect as initialzing it via memset. --- mingw-w64-crt/crt/crt_handler.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) LGTM, pushed. Thanks! // Martin ___

[Mingw-w64-public] [PATCH] crt: Avoid calling memset in crt_handler.c

2024-11-27 Thread Pali Rohár
Explicitly initialize variable to zeros, which has same effect as initialzing it via memset. --- mingw-w64-crt/crt/crt_handler.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/mingw-w64-crt/crt/crt_handler.c b/mingw-w64-crt/crt/crt_handler.c index c49a2b3b573d..0a08880