On Tue, 3 Dec 2024, Martin Storsjö wrote:

On Wed, 27 Nov 2024, Pali Rohár wrote:

Explicitly initialize variable to zeros, which has same effect as
initialzing it via memset.
---
mingw-w64-crt/crt/crt_handler.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

LGTM, pushed. Thanks!

On second thought - technically, this doesn't have the exact same behaviour. If __mingw_init_ehandler would be called multiple times, there could be a reason for calling memset() explicitly. (And even without the {} added here, IIRC static variables are guaranteed to be zero initialized - they aren't uninitialized like local variables.)

But anyway, in practice __mingw_init_ehandler is only called once in each image, so this point is moot.

// Martin

_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to