Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

On 11/12/2015 08:51 PM, Samuel Pitoiset wrote: Hi Emil, On 11/10/2015 04:35 PM, Emil Velikov wrote: Hi Samuel, Sorry about this I thought I already replied :-\ On 29 October 2015 at 22:22, Samuel Pitoiset wrote: On 10/27/2015 02:01 PM, samuel.pitoiset wrote: On 27/10/2015 12:52, Emil

[Mesa-dev] [PATCH 4/5] nv50: expose two groups of compute-related MP perf counters

This turns on GL_AMD_performance_monitor which needs at least one group of GPU counters to be enabled. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_query.c | 55 ++ src/gallium/drivers/nouveau/nv50/nv50_query.h | 6 +++ .../drivers

[Mesa-dev] [PATCH 2/5] nv50: add compute-related MP perf counters on G84+

Fermi has 8. Only G84+ is supported because G80 is an old and weird card. Tested on G84, G96, G200, MCP79 and GT218 with glxgears, glxspheres64, xonotic-glx, heaven and valley. Signed-off-by: Samuel Pitoiset Tested-by: Pierre Moreau --- src/gallium/drivers/nouveau/Makefile.sources | 2

[Mesa-dev] [PATCH 3/5] nv50: add support for performance metrics on G84+

Currently only one metric is exposed but more will be added later. Signed-off-by: Samuel Pitoiset Tested-by: Pierre Moreau --- src/gallium/drivers/nouveau/Makefile.sources | 2 + src/gallium/drivers/nouveau/nv50/nv50_query_hw.c | 19 +- .../drivers/nouveau/nv50

[Mesa-dev] [PATCH 5/5] docs: mark GL_AMD_performance_monitor for nv50

Signed-off-by: Samuel Pitoiset --- docs/relnotes/11.1.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/11.1.0.html b/docs/relnotes/11.1.0.html index 82ee3c4..14dc5e4 100644 --- a/docs/relnotes/11.1.0.html +++ b/docs/relnotes/11.1.0.html @@ -63,6 +63,7 @@ Note: some of the

[Mesa-dev] [PATCH 0/5] nv50: compute support & some perf counters

tested by Pierre Moreau and myself on different chipsets. I didn't run a full piglit but I'll do it in the next few days before merging the series. :-) Feel free to review. Thanks! Samuel Pitoiset (5): nv50: implement a basic compute support nv50: add compute-related MP perf count

[Mesa-dev] [PATCH 1/5] nv50: implement a basic compute support

versa. Note that, textures, samplers and surfaces still need to be implemented. Signed-off-by: Samuel Pitoiset Tested-by: Pierre Moreau --- src/gallium/drivers/nouveau/Makefile.sources | 1 + .../drivers/nouveau/codegen/nv50_ir_driver.h | 1 + src/gallium/drivers/nouveau/nv50

Re: [Mesa-dev] [PATCH 1/5] nv50: implement a basic compute support

On 11/13/2015 01:15 AM, Ilia Mirkin wrote: On Thu, Nov 12, 2015 at 7:04 PM, Samuel Pitoiset wrote: +static bool +nv50_compute_validate_program(struct nv50_context *nv50) +{ + struct nv50_program *prog = nv50->compprog; + + if (prog->mem) + return true; + + if (!prog->t

Re: [Mesa-dev] [PATCH 4/9] st/mesa: store mapping from perfmon counter to query type

code one year ago for the nvc0 driver, this wasn't a real issue because it didn't expose lots of queries. Anyway, this looks like a good improvement. Thanks! Reviewed-by: Samuel Pitoiset --- src/mesa/state_tracker/st_cb_perfmon.c | 74 +++---

Re: [Mesa-dev] [PATCH 6/9] st/mesa: maintain active perfmon counters in an array

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: It is easy enough to pre-determine the required size, and arrays are generally better behaved especially when they get large. --- src/mesa/state_tracker/st_cb_perfmon.c | 78 -- src/mesa/state_tracker/st_cb_perfmon

Re: [Mesa-dev] [PATCH 9/9] st/mesa: add support for batch driver queries to perfmon

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/mesa/state_tracker/st_cb_perfmon.c | 75 ++ src/mesa/state_tracker/st_cb_perfmon.h | 6 +++ 2 files changed, 74 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_perfmon.c b/src/me

Re: [Mesa-dev] [PATCH 7/9] gallium: add the concept of batch queries

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: Some drivers (in particular radeon[si], but also freedreno judging from a quick grep) may want to expose performance counters that cannot be individually enabled or disabled. Allow such drivers to mark driver-specific queries as requiring a new typ

Re: [Mesa-dev] [PATCH 2/9] gallium/hud: remove unused field in query_info

Reviewed-by: Samuel Pitoiset On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/gallium/auxiliary/hud/hud_driver_query.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/hud/hud_driver_query.c b/src/gallium/auxiliary/hud/hud_driver_query.c index f14305e..3198ab3

Re: [Mesa-dev] [PATCH 3/9] st/mesa: map semantic driver query types to underlying type

*/ + /* PIPE_DRIVER_QUERY_TYPE_MICROSECONDS */ When you are at it, please also add /* PIPE_DRIVER_QUERY_TYPE_MICROSECONDS */ to pipe_query_result. With this minor change, this patch is: Reviewed-by: Samuel Pitoiset /* PIPE_DRIVER_QUERY_TYPE_HZ */ uint64_t u64; diff --git a/src

Re: [Mesa-dev] [PATCH 5/9] st/mesa: use BITSET_FOREACH_SET to loop through active perfmon counters

Reviewed-by: Samuel Pitoiset On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/mesa/state_tracker/st_cb_perfmon.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_perfmon.c b/src/mesa/state_tracker/st_cb_perfmon.c index 80ff170

Re: [Mesa-dev] [PATCH 0/9] gallium: batch query objects and related cleanups

Hi Nicolai, Did you run amd_performance_monitor piglit tests to make sure all of your changes didn't break anything? Did you test on nvc0 driver which is the only driver that currently exposes GL_AMD_performance_monitor? In case you didn't, I'll test it myself in the next few days. You might

Re: [Mesa-dev] [PATCH 1/9] gallium: remove pipe_driver_query_group_info field type

On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: This was only used to implement an unnecessarily restrictive interpretation of the spec of AMD_performance_monitor. The spec says A performance monitor consists of a number of hardware and software counters that can be sampled by the GPU and

Re: [Mesa-dev] [PATCH 8/9] gallium/hud: add support for batch queries

Some comments below. On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/gallium/auxiliary/hud/hud_context.c | 24 ++- src/gallium/auxiliary/hud/hud_driver_query.c | 248 +++ src/gallium/auxiliary/hud/hud_private.h | 13 +- 3 files changed, 240 insertio

Re: [Mesa-dev] llvm TGSI backend (WIP) questions

On 11/13/2015 02:46 PM, Hans de Goede wrote: Hi All, Hey Hans, So as discussed I've started working on a TGSI backend for llvm to use as a way to get compute going on nouveau (and other gpu-s). I'm still learning all the ins and outs of llvm so I do not have much to show yet. I've rebase

Re: [Mesa-dev] [PATCH 3/9] st/mesa: map semantic driver query types to underlying type

On 11/13/2015 07:22 PM, Nicolai Hähnle wrote: On 13.11.2015 18:34, Samuel Pitoiset wrote: On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: --- src/gallium/include/pipe/p_defines.h | 2 ++ src/mesa/state_tracker/st_cb_perfmon.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src

Re: [Mesa-dev] [PATCH 0/9] gallium: batch query objects and related cleanups

On 11/13/2015 07:29 PM, Nicolai Hähnle wrote: Hi Samuel, thanks for taking a look! On 13.11.2015 18:35, Samuel Pitoiset wrote: Did you run amd_performance_monitor piglit tests to make sure all of your changes didn't break anything? Yes, everything passes here. Looks good. T

Re: [Mesa-dev] [PATCH 1/9] gallium: remove pipe_driver_query_group_info field type

On 11/13/2015 07:23 PM, Nicolai Hähnle wrote: On 13.11.2015 18:35, Samuel Pitoiset wrote: On 11/13/2015 04:57 PM, Nicolai Hähnle wrote: This was only used to implement an unnecessarily restrictive interpretation of the spec of AMD_performance_monitor. The spec says A performance monitor

Re: [Mesa-dev] [PATCH 1/9] gallium: remove pipe_driver_query_group_info field type

On 11/13/2015 07:27 PM, Ilia Mirkin wrote: On Fri, Nov 13, 2015 at 1:23 PM, Nicolai Hähnle wrote: So really, this is a question for everybody who cares about nouveau, because nouveau is the only driver that (if a #define is enabled) advertises a CPU driver_query_group. Do you want that group

[Mesa-dev] [PATCH v2 3/3] nv50: add support for performance metrics on G84+

Currently only one metric is exposed but more will be added later. Signed-off-by: Samuel Pitoiset Tested-by: Pierre Moreau --- src/gallium/drivers/nouveau/Makefile.sources | 2 + src/gallium/drivers/nouveau/nv50/nv50_query_hw.c | 19 +- .../drivers/nouveau/nv50

[Mesa-dev] [PATCH v2 2/3] nv50: add compute-related MP perf counters on G84+

Fermi has 8. Only G84+ is supported because G80 is an old and weird card. Tested on G84, G96, G200, MCP79 and GT218 with glxgears, glxspheres64, xonotic-glx, heaven and valley. Signed-off-by: Samuel Pitoiset Tested-by: Pierre Moreau --- src/gallium/drivers/nouveau/Makefile.sources | 2

[Mesa-dev] [PATCH v2 0/3] nv50: compute support & some perf counters

Hi, Only patch 1/3 has been updated. Patches 4 and 5 of the first version have been dropped because those groups of GPU counters are going to be removed. Thanks. Samuel Pitoiset (3): nv50: implement a basic compute support nv50: add compute-related MP perf counters on G84+ nv50: add

[Mesa-dev] [PATCH v2 1/3] nv50: implement a basic compute support

versa. Note that, textures, samplers and surfaces still need to be implemented. Changes from v2: - use nv50->debug to get shader compiler reports - remove useless localOffset in nv50_program Signed-off-by: Samuel Pitoiset Tested-by: Pierre Moreau --- src/gallium/drivers/nouveau/Makefile.sour

[Mesa-dev] [PATCH] nv50: free interpolation parameters in nv50_program_destroy()

As for nvc0, we need to free memory allocated by interpolation parameters. This fixes a memory leak spotted by valgrind. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_program.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers

[Mesa-dev] [PATCH] docs: describe the NVC0_COMPUTE envvar

Signed-off-by: Samuel Pitoiset --- docs/envvars.html | 4 1 file changed, 4 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 31d14a4..cb3eba0 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -227,6 +227,10 @@ for details. See the driver code for other

Re: [Mesa-dev] [PATCH] docs: describe the NVC0_COMPUTE envvar

Sun, Mar 1, 2015 at 6:44 AM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- docs/envvars.html | 4 1 file changed, 4 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 31d14a4..cb3eba0 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -227,6 +227,10 @@

Re: [Mesa-dev] [PATCH] docs: describe the NVC0_COMPUTE envvar

On 03/01/2015 11:06 PM, Ilia Mirkin wrote: On Sun, Mar 1, 2015 at 4:55 PM, Samuel Pitoiset wrote: On 03/01/2015 07:21 PM, Ilia Mirkin wrote: Why wouldn't they always just be enabled :) Also, do you have to set it to get MP counters on kepler+? And why is it called "compute"

[Mesa-dev] [PATCH] nvc0: fix wrong max value for driver queries

caled. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index ec464b5..f21deea 100644 --- a/src/ga

Re: [Mesa-dev] [PATCH] nvc0: fix wrong max value for driver queries

On 03/08/2015 05:45 PM, Ilia Mirkin wrote: On Sun, Mar 8, 2015 at 12:18 PM, Samuel Pitoiset wrote: The maximum value of a Gallium HUD's panel is automatically adjusted when the current value is greater than the max. If we set the pipe_query_driver_info::max_value to UINT64_MAX, the ma

[Mesa-dev] [PATCH 02/15] gallium: add new fields to pipe_driver_query_info

According to the spec of GL_AMD_performance_monitor, valid type values returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. This also introduces the new field group_id in order to categorize queries into groups. Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe

[Mesa-dev] [PATCH 03/15] gallium: add new numeric types to pipe_query_result

This will be used by GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_defines.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h index cb42cef..c5721d4 100644 --- a

[Mesa-dev] [PATCH 09/15] freedreno: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for freedreno. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/freedreno/freedreno_query.c | 9 + src/gallium/drivers/freedreno/freedreno_query.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/gallium/drivers/freedreno

[Mesa-dev] [PATCH 15/15] nvc0: all queries use an unsigned 64-bits integer by default

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index be6be69..1898260 100644 --- a

[Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

This function can be used to get a generic group of driver-specific queries when a driver doesn't expose any groups. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_query.c | 50 ++ src/ga

[Mesa-dev] [PATCH 00/15] GL_AMD_performance_monitor

work with other drivers. All piglit tests, including API and measurement tests are okay. Feel free to make a review. Christoph Bumiller (1): st/mesa: implement GL_AMD_performance_monitor Samuel Pitoiset (14): gallium: add pipe_screen::get_driver_query_group_info gallium: add new fields to

[Mesa-dev] [PATCH 10/15] radeon: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for radeon. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_pipe_common.c | 9 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c

[Mesa-dev] [PATCH 04/15] gallium: replace pipe_driver_query_info::max_value by a union

This allows queries to return different numeric types. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_driver_query.c| 2 +- src/gallium/drivers/freedreno/freedreno_query.c | 12 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 8 src/gallium

[Mesa-dev] [PATCH 06/15] st/mesa: implement GL_AMD_performance_monitor

get_driver_query_group_info and get_driver_query_info in order to enable this extension. Signed-off-by: Samuel Pitoiset --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_cb_perfmon.c | 455 + src/mesa/state_tracker/st_cb_perfmon.h | 70

[Mesa-dev] [PATCH 01/15] gallium: add pipe_screen::get_driver_query_group_info

GL_AMD_performance monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/screen.rst | 10 ++ src/gallium/include/pipe/p_defines.h | 7 +++ src/gallium/include/pipe/p_screen.h | 11 +++ 3 files changed, 28 insertions(+) diff --git a/src/gallium/docs/source

[Mesa-dev] [PATCH 11/15] nvc0: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for nvc0. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 10 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 +++ 3 files changed, 14 insertions

[Mesa-dev] [PATCH 05/15] gallium: make pipe_context::begin_query return a boolean

GL_AMD_performance_monitor must return an error when a monitoring session cannot be started. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/freedreno/freedreno_query.c| 4 ++-- src/gallium/drivers/freedreno/freedreno_query.h| 2 +- src/gallium/drivers/freedreno

[Mesa-dev] [PATCH 08/15] svga: implement pipe_screen::get_driver_query_group_info

This enables GL_AMD_performance_monitor for svga. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/svga/svga_context.h | 1 + src/gallium/drivers/svga/svga_screen.c | 11 +++ 2 files changed, 12 insertions(+) diff --git a/src/gallium/drivers/svga/svga_context.h b/src/gallium

[Mesa-dev] [PATCH 14/15] nvc0: make begin_query return false when all MP counters are used

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query.c index 445110f..be6be69 100644 --- a

[Mesa-dev] [PATCH 13/15] nvc0: expose more driver-specific query groups

This patch exposes "Driver statistics" and "MP counters" groups. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 61 -- src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 11 + 2 files changed, 69 insertions(+),

[Mesa-dev] [PATCH 12/15] docs: mark GL_AMD_performance_monitor for the 10.6.0 release

GL_AMD_performance_monitor is supported by nvc0, svga, freedreno, r600 and radeonsi. Signed-off-by: Samuel Pitoiset --- docs/relnotes/10.6.0.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.6.0.html b/docs/relnotes/10.6.0.html index a396109..596a236 100644 --- a/docs

Re: [Mesa-dev] [PATCH 02/15] gallium: add new fields to pipe_driver_query_info

On 03/09/2015 10:36 PM, Marek Olšák wrote: On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset wrote: According to the spec of GL_AMD_performance_monitor, valid type values returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT. This also introduces the new field group_id in order

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

? Marek On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset wrote: This function can be used to get a generic group of driver-specific queries when a driver doesn't expose any groups. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary

Re: [Mesa-dev] [PATCH 07/15] gallium: add util_get_driver_query_group_info

On 03/09/2015 11:00 PM, Marek Olšák wrote: If you plan to add more functions, this file can stay. Yes, it's my plan. Marek On Mon, Mar 9, 2015 at 10:54 PM, Samuel Pitoiset wrote: On 03/09/2015 10:43 PM, Marek Olšák wrote: It would be better to add this function to u_helpers

Re: [Mesa-dev] [PATCH] hud: fix compilation warnings in hud_nic_graph_install()

On 01/30/2017 11:04 AM, Nicolai Hähnle wrote: On 27.01.2017 14:35, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_nic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_nic.c b/src/gallium

[Mesa-dev] [PATCH v2] hud: fix compilation warnings in hud_nic_graph_install()

v2: use PRId64 instead of PRIx64 Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/hud/hud_nic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_nic.c b/src/gallium/auxiliary/hud/hud_nic.c index f9935dea8b..634add162b 100644 --- a

[Mesa-dev] [PATCH v2 2/3] gallium/radeon: add new GPU-sdma-busy HUD query

For simplicity, GPU-sdma-busy will return 0 on previous gens. v2: only read SRBM_STATUS2 on Evergreen+ Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_gpu_load.c| 13 + src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ src/gallium/drivers/radeon

[Mesa-dev] [PATCH v2 3/3] gallium/radeon: add new HUD queries for monitoring the CP

There are even more counters in the CP_STAT register but I think these ones are enough for now. v2: only read (and expose) CP_STAT on VI+ Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_gpu_load.c| 36 +++ src/gallium/drivers/radeon

[Mesa-dev] [PATCH] r600: fix a compilation warning in r600_screen_create()

Should be r600_common_screen instead of r600_screen. Fixes: 80157a2c20 ("gallium/radeon: clean up r600_query_init_backend_mask") Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/dr

Re: [Mesa-dev] [PATCH] winsys/radeon: Allow visible VRAM size > 256MB with kernel driver >= 2.49

Thanks for fixing this Michel. Reviewed-by: Samuel Pitoiset On 01/31/2017 07:54 AM, Michel Dänzer wrote: From: Michel Dänzer The kernel driver reports correct values now. Signed-off-by: Michel Dänzer --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 7 ++- 1 file changed, 6

[Mesa-dev] [PATCH] winsys/amdgpu: avoid potential segfault in amdgpu_bo_map()

cs can be NULL when it comes from r600_buffer_map_sync_with_rings() to avoid doing the same checks. It was checked for write mappings but not for read mappings. Signed-off-by: Samuel Pitoiset --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 17 ++--- 1 file changed, 10 insertions

Re: [Mesa-dev] [PATCH] Revert "radeonsi: decrease the number of texture slots to 24"

Reviewed-by: Samuel Pitoiset This should also fix the glActiveTexture() errors with The Wither 3. On 02/02/2017 07:46 PM, Marek Olšák wrote: From: Marek Olšák This reverts commit bdd860e3076655519d45bd66936ef7be9b7dda63. Requested by a game developer. Cc: 17.0 --- src/gallium/drivers

[Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

might fail (eg. ARK games). No need to add both "ARK: Survival Evolved" and "ARK: Survival Of The Fittest" because the executable name is the same. Signed-off-by: Samuel Pitoiset --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/

[Mesa-dev] [RFC PATCH 0/1] New driconf option for ARK games

And "ARK: Survival Evolved" is one of the most played game... [3] I'm open to any suggestions if you don't really like this option. Comments are welcome! Thaknks. [1] https://bugs.freedesktop.org/show_bug.cgi?id=95374 [2] https://www.gamingonlinux.com/wiki/Games_broken_on

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

On 02/03/2017 06:29 PM, Ilia Mirkin wrote: On Fri, Feb 3, 2017 at 12:23 PM, Samuel Pitoiset wrote: This is similar to the MESA_GLSL_VERSION_OVERRIDE envvar (mainly for developers). But this one has the advantage to be configured for specific apps which require a context with an explicit

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

On 02/03/2017 07:24 PM, Jason Ekstrand wrote: On Fri, Feb 3, 2017 at 9:23 AM, Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: This is similar to the MESA_GLSL_VERSION_OVERRIDE envvar (mainly for developers). But this one has the advantage to be configured for sp

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

On 02/03/2017 07:48 PM, Bas Nieuwenhuizen wrote: On Fri, Feb 3, 2017, at 19:24, Jason Ekstrand wrote: On Fri, Feb 3, 2017 at 9:23 AM, Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: This is similar to the MESA_GLSL_VERSION_OVERRIDE envvar (mainly for developers). Bu

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

On 02/06/2017 04:04 PM, Eero Tamminen wrote: Hi, On 03.02.2017 19:23, Samuel Pitoiset wrote: This is similar to the MESA_GLSL_VERSION_OVERRIDE envvar (mainly for developers). But this one has the advantage to be configured for specific apps which require a context with an explicit version

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

On 02/06/2017 04:45 PM, Eero Tamminen wrote: Hi, On 05.02.2017 15:19, Samuel Pitoiset wrote: On 02/03/2017 07:48 PM, Bas Nieuwenhuizen wrote: As far as I can see[1], when the game detects GL 4.3+, the engine tries to load a different set of shaders from disk, but the game developers have

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

On 02/09/2017 01:40 PM, Ian Romanick wrote: On 02/05/2017 02:13 PM, Samuel Pitoiset wrote: On 02/03/2017 07:24 PM, Jason Ekstrand wrote: On Fri, Feb 3, 2017 at 9:23 AM, Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: This is similar to the MESA_GLSL_VERSION_OVERRIDE

Re: [Mesa-dev] [PATCH] nvc0/ir: fix ubo max clamp, reset file index

Nice catch. Reviewed-by: Samuel Pitoiset On 02/09/2017 09:37 PM, Ilia Mirkin wrote: We just increased the max UBO, so we should also increase the clamp that we do for robustness. Similarly, as we're including the fileIndex in the new indirect value, we should reset fileIndex to 0 so th

Re: [Mesa-dev] [PATCH] nv50/ir: convert an ATOM.EXCH without a destination into a store

Can you double check what the blob do in this scenario? On 02/10/2017 07:59 AM, Ilia Mirkin wrote: On SM35 there does not appear to be a way to emit a ATOM.EXCH with a null destination. This should be functionally equivalent to a plain store however, so just do that. Fixes GL45-CTS.compute_shad

Re: [Mesa-dev] [PATCH] nvc0: fix 64-bit integer query buffer writes

On 02/10/2017 02:29 AM, Ilia Mirkin wrote: The former logic just plain didn't work at all. We need to write the subsequent dword to the next buffer location. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/mme/com9097.mme | 22 - src/gallium/drivers/nouveau/

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

On 02/08/2017 02:23 PM, Eero Tamminen wrote: Hi, On 07.02.2017 15:29, Gustaw Smolarczyk wrote: 2017-02-07 14:11 GMT+01:00 Eero Tamminen : Thanks, setting breakpoint on SDL_ShowMessageBox() I can catch where it shows the dialog, but it appears to link SDL statically and not have debug symbols

[Mesa-dev] [RFC PATCH 3/4] drirc: add force_compat_profile for Crookz - The Big Heist

Signed-off-by: Samuel Pitoiset --- src/mesa/drivers/dri/common/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index d698435284..bfa4ff1dc3 100644 --- a/src/mesa/drivers/dri/common/drirc +++ b/src/mesa/drivers

[Mesa-dev] [RFC PATCH 4/4] drirc: add force_compat_profile for Tropico 5

Signed-off-by: Samuel Pitoiset --- src/mesa/drivers/dri/common/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index bfa4ff1dc3..be4cbc6078 100644 --- a/src/mesa/drivers/dri/common/drirc +++ b/src/mesa/drivers

[Mesa-dev] [RFC PATCH 2/4] drirc: add force_compat_profile for Worms WMD

Signed-off-by: Samuel Pitoiset --- src/mesa/drivers/dri/common/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index 20fd8123e4..d698435284 100644 --- a/src/mesa/drivers/dri/common/drirc +++ b/src/mesa/drivers

[Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

ompat. This option should help some games but it's not enough for all (eg. Dying Ligth). Signed-off-by: Samuel Pitoiset --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_screen.c | 3 +++ src/mesa/drivers/dri/common/xmlpool/t_options.h | 5

[Mesa-dev] [RFC PATCH 0/4] New drirc options for Worms WMD, Tropico 5 and Crookz

;m open to all other suggestions if you really dislike the idea. Comments are welcome! Thanks. Samuel Pitoiset (4): driconf: add new force_compat_profile option drirc: add force_compat_profile for Worms WMD drirc: add force_compat_profile for Crookz - The Big Heist drirc: add force_compat_p

Re: [Mesa-dev] [RFC PATCH 0/4] New drirc options for Worms WMD, Tropico 5 and Crookz

On 02/10/2017 02:45 PM, Ilia Mirkin wrote: On Fri, Feb 10, 2017 at 8:41 AM, Samuel Pitoiset wrote: Hi, Mesa currently doesn't allow to create 3.1+ compatibility profiles mainly because various features are unimplemented and bugs can happen. However, some buggy apps request a compat pr

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

On 02/10/2017 04:01 PM, Marek Olšák wrote: On Mon, Feb 6, 2017 at 9:26 PM, Samuel Pitoiset wrote: On 02/06/2017 04:45 PM, Eero Tamminen wrote: Hi, On 05.02.2017 15:19, Samuel Pitoiset wrote: On 02/03/2017 07:48 PM, Bas Nieuwenhuizen wrote: As far as I can see[1], when the game

Re: [Mesa-dev] [PATCH] gallium/radeon: include SDMA in the GPU load query

Looks good. Reviewed-by: Samuel Pitoiset On 02/11/2017 09:56 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_gpu_load.c| 10 +- src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a

Re: [Mesa-dev] [RFC PATCH 0/4] New drirc options for Worms WMD, Tropico 5 and Crookz

On 02/10/2017 09:46 PM, Kenneth Graunke wrote: On Friday, February 10, 2017 5:45:03 AM PST Ilia Mirkin wrote: On Fri, Feb 10, 2017 at 8:41 AM, Samuel Pitoiset wrote: Hi, Mesa currently doesn't allow to create 3.1+ compatibility profiles mainly because various features are unimplemente

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

On 02/10/2017 10:05 PM, Emil Velikov wrote: On 10 February 2017 at 21:04, Emil Velikov wrote: Hi Samuel, On 10 February 2017 at 13:41, Samuel Pitoiset wrote: Mesa currently doesn't allow to create 3.1+ compatibility profiles mainly because various features are unimplemented and bug

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

On 02/13/2017 04:51 PM, Marek Olšák wrote: On Mon, Feb 13, 2017 at 11:57 AM, Samuel Pitoiset wrote: On 02/10/2017 10:05 PM, Emil Velikov wrote: On 10 February 2017 at 21:04, Emil Velikov wrote: Hi Samuel, On 10 February 2017 at 13:41, Samuel Pitoiset wrote: Mesa currently doesn&#

Re: [Mesa-dev] [PATCH] nvc0: disable linked tsc mode in compute launch descriptor

Does this fix all dEQP compute sampler fails? On 02/13/2017 05:27 PM, Ilia Mirkin wrote: Empirically, this makes things work. Presumably this was originally copied from the blob, which does make use of linked tsc mode. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99532 Signed-off-by:

Re: [Mesa-dev] [PATCH] nvc0: disable linked tsc mode in compute launch descriptor

On 02/13/2017 05:41 PM, Ilia Mirkin wrote: It fixes a bunch, don't know about *all*. dEQP-GLES31.functional.shaders.opaque_type_indexing.sampler.*.compute.* gets 76/76 now. Very nice catch! It fixes all dEQP compute sampler fails. :-) Reviewed-by: Samuel Pitoiset On Mon, Feb 13, 20

[Mesa-dev] [PATCH 1/2] drm/amdgpu: implement read_sensor() for pre-powerplay chips

Currently, only the GPU temperature, the shader clock and eventually the memory clock are implemented. The main goal is to expose this info to the userspace like Radeon. Signed-off-by: Samuel Pitoiset --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 4 +++- drivers/gpu/drm/amd/amdgpu/ci_dpm.c

[Mesa-dev] [PATCH 0/2] drm/amdgpu: expose temp and shader/memory clocks

the read_sensor() interface for pre-powerplay chips. The rest of the series is quite simple. This has only been tested on Polaris (RX480). Please review! Thanks. Samuel Pitoiset (2): drm/amdgpu: implement read_sensor() for pre-powerplay chips drm/amdgpu: expose the current temperature and

[Mesa-dev] [PATCH 2/2] drm/amdgpu: expose the current temperature and shader/memory clocks

The clocks are returned in Mhz and the temperature in millidegrees. Signed-off-by: Samuel Pitoiset --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 27 +++ include/uapi/drm/amdgpu_drm.h | 8 +++- 3 files

Re: [Mesa-dev] [PATCH 0/2] drm/amdgpu: expose temp and shader/memory clocks

Sorry wrong list, please ignore. On 02/13/2017 11:00 PM, Samuel Pitoiset wrote: Hi, This series exposes the current GPU temperature and the current shader clock (and eventually the memory clock for non-APUs boards). This adds the same functionality as the Radeon driver. The main goal is to

[Mesa-dev] [PATCH] gallium/radeon: add HUD queries for GPU temperature and clocks

th is already a bit messy. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_query.c | 12 ++-- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 19 ++- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_qu

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

On 02/13/2017 11:43 PM, Marek Olšák wrote: On Mon, Feb 13, 2017 at 5:06 PM, Marek Olšák wrote: On Mon, Feb 13, 2017 at 5:04 PM, Samuel Pitoiset wrote: On 02/13/2017 04:51 PM, Marek Olšák wrote: On Mon, Feb 13, 2017 at 11:57 AM, Samuel Pitoiset wrote: On 02/10/2017 10:05 PM, Emil

Re: [Mesa-dev] [PATCH] gallium/radeon: add HUD queries for GPU temperature and clocks

On 02/14/2017 09:23 AM, Nicolai Hähnle wrote: On 13.02.2017 23:08, Samuel Pitoiset wrote: Only the Radeon kernel driver exposed the GPU temperature and the shader/memory clocks, this implements the same functionality for the AMDGPU kernel driver. These queries will return 0 if the DRM

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

On 02/14/2017 01:54 PM, Edmondo Tommasina wrote: On Feb 14, 2017 11:50 AM, "Marek Olšák" mailto:mar...@gmail.com>> wrote: On Feb 14, 2017 4:11 AM, "Michel Dänzer" mailto:mic...@daenzer.net>> wrote: On 14/02/17 09:28 AM, Samuel Pitoiset wrote:

[Mesa-dev] [PATCH v2 4/4] drirc: add allow_higher_compat_version for Tropico 5

v2: s/force_compat_profile/allow_higher_compat_version Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v1) --- src/mesa/drivers/dri/common/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index

[Mesa-dev] [PATCH v2 3/4] drirc: add allow_higher_compat_version for Crookz - The Big Heist

v2: s/force_compat_profile/allow_higher_compat_version Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v1) --- src/mesa/drivers/dri/common/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index

[Mesa-dev] [PATCH v2 2/4] drirc: add allow_higher_compat_version for Worms WMD

v2: s/force_compat_profile/allow_higher_compat_version Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v1) --- src/mesa/drivers/dri/common/drirc | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index

[Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

some games to run but it's not enough for all (eg. Dying Ligth). v2: - s/force_compat_profile/allow_higher_compat_version Signed-off-by: Samuel Pitoiset --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_screen.c | 3 +++ src/mesa/drivers/

Re: [Mesa-dev] [PATCH] gallium/radeon: add HUD queries for GPU temperature and clocks

On 02/15/2017 11:59 AM, Nicolai Hähnle wrote: On 14.02.2017 18:20, Marek Olšák wrote: On Tue, Feb 14, 2017 at 9:23 AM, Nicolai Hähnle wrote: On 13.02.2017 23:08, Samuel Pitoiset wrote: Only the Radeon kernel driver exposed the GPU temperature and the shader/memory clocks, this implements

Re: [Mesa-dev] [PATCH v2 1/4] driconf: add allow_higher_compat_version option

option should help some games to run but it's not enough for all (eg. Dying Ligth). v2: - s/force_compat_profile/allow_higher_compat_version Signed-off-by: Samuel Pitoiset --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_screen.c | 3 +++ sr

Re: [Mesa-dev] [PATCH] i965: define default allow_higher_compat_version value

Thanks. Reviewed-by: Samuel Pitoiset On 02/15/2017 05:59 PM, Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin Fixes: 9d16f3903e2 ("driconf: add allow_higher_compat_version option") --- src/mesa/drivers/dri/i965/intel_screen.c | 1 + 1 file changed, 1 insertion(+) diff -

<    1   2   3   4   5   6   7   8   9   10   >