[Mesa-dev] [PATCH] blit : only error when the stencil and depth bits do not match

2017-02-18 Thread Max Qian
From: Maxqia Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97921 --- src/mesa/main/blit.c | 85 +--- 1 file changed, 34 insertions(+), 51 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index e739130f98..2f7b076667 1

[Mesa-dev] [PATCH] blit : only error when the stencil and depth bits do not match (v2)

2017-02-18 Thread Max Qian
From: Maxqia Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97921 v2 : fix unintentional line removal --- src/mesa/main/blit.c | 84 +--- 1 file changed, 34 insertions(+), 50 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/b

Re: [Mesa-dev] [PATCH] blit : only error when the stencil and depth bits do not match (v2)

2017-02-19 Thread Max Qian
Yes, that's correct. Mesa was throwing errors for glBlitFramebuffer in the same situations other (e.g nvidia) drivers weren't, causing artifacting for some applications (e.g wine). The bugzilla link has a test apitrace for it. I'll work on the commit and post the revision when I'm done. __

[Mesa-dev] [PATCH] mesa/blit: only error when the stencil and depth bits do not match (v3)

2017-02-19 Thread Max Qian
This fixes some situations where glBlitFrameBuffer would error in Mesa, but wouldn't error in other drivers (e.g Nvidia) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97921 v2 : fix unintentional line removal v3 : author correction, add commit message, and change the error message --- sr

Re: [Mesa-dev] [PATCH] mesa/blit: only error when the stencil and depth bits do not match (v3)

2017-02-20 Thread Max Qian
NVM this patch, the error was caused by an issue in Wine. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] GlBlitFramebuffer Specification Fix

2016-10-09 Thread Max Qian
The specification says that if the depth AND stencil formats do not match, not or. This fixes bug #97921. --- src/mesa/main/blit.c | 46 +++--- 1 file changed, 19 insertions(+), 27 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index