LGTM Reviewed-by: Plamena Manolova
On Thu, Feb 2, 2017 at 2:32 AM, Emil Velikov
wrote:
> From: Emil Velikov
>
> They are versions of the respective libdrm package. They are _not_ the
> version of libdrm[.so] required for driver X.
>
> Doing the latter will lead to combinatoric explosion and in
LGTM :)
Reviewed-by: Plamena Manolova
On Thu, Feb 2, 2017 at 12:27 PM, Tapani Pälli
wrote:
> Earlier changes introduced is_ycrcb flag which checks the component
> order of u and v components. Condition for setting the flag was
> incorrect, with ycrcb we are supposed to have cr before cb.
>
> T
Reviewed-by: Plamena Manolova
On Sat, Feb 11, 2017 at 1:32 PM, Timothy Arceri
wrote:
> I forgot to error check stat() and also I wasn't using the subdir in
> is_two_character_sub_directory().
>
> Cc: Emil Velikov
> ---
> src/util/disk_cache.c | 8
> 1 file changed, 4 insertions(+), 4
Looks good to me :)
Reviewed-by: Plamena Manolova
On Fri, Feb 24, 2017 at 6:46 PM, Robert Bragg wrote:
> In queryid_valid() index is unsigned so checking if it is less
> than zero is useless. On queryid_to_index() is comment
> saying 0 is reserved to be invalid thus rule it out.
>
> This is a
Thank you for reviewing guys! I'll go ahead and make that change.
Pam
On Wed, Nov 30, 2016 at 3:33 PM, Ilia Mirkin wrote:
> On Nov 30, 2016 7:17 AM, "Lionel Landwerlin" <
> lionel.g.landwer...@intel.com> wrote:
> >
> > On 22/11/16 21:53, Plamena Manolova wrote:
> >>
> >> This extension allows t
On Wed, Nov 30, 2016 at 4:36 PM, Ilia Mirkin wrote:
> On Wed, Nov 30, 2016 at 9:19 AM, Lionel Landwerlin
> wrote:
> > Also forgot that (like Ilia suggested for NV_image_formats) you can
> update
> > docs/relnotes/ to list the new feature.
>
> That would be appropriate for the patch that actually
Thank you for the review. You're absolutely right, I'll go ahead fix this.
On Thu, Feb 11, 2016 at 6:39 PM, Ilia Mirkin wrote:
> On Thu, Feb 11, 2016 at 11:31 AM, Plamena Manolova
> wrote:
> > This patch moves the calculation of current uniforms to
> > link_uniforms, which makes use of UniformR
Thanks, this if-statement looks tidier the way you suggested. I'll update
the patch.
On Thu, Feb 11, 2016 at 7:13 PM, Ilia Mirkin wrote:
> On Thu, Feb 11, 2016 at 11:31 AM, Plamena Manolova
> wrote:
> > + struct empty_uniform_block *current_block = NULL;
> > + unsigned prev_location = -1;
>
Thanks for reviewing. I was actually hesitant about which list
implementation to use since the changes affect src/mesa/main/mtypes.h too.
Thank you for clearing this up.
On Thu, Feb 11, 2016 at 8:02 PM, Matt Turner wrote:
> On Thu, Feb 11, 2016 at 8:31 AM, Plamena Manolova
> wrote:
> > This pat
On Mon, Feb 15, 2016 at 10:50 PM, Ilia Mirkin wrote:
> In a few places your indentation is off -- please look at the 'git
> diff' output, it should be pretty obvious. You used 2 spaces instead
> of 3 (in just a handful of places).
>
Thanks for spotting this, it must've slipped by me.
>
> On Fr
On Wed, Feb 17, 2016 at 1:22 PM, Manolova, Plamena <
plamena.manol...@intel.com> wrote:
>
>
> On Mon, Feb 15, 2016 at 10:50 PM, Ilia Mirkin
> wrote:
>
>> In a few places your indentation is off -- please look at the 'git
>> diff' output, it should b
You're right, changing the if statement to a > b would be less confusing,
I'll go ahead and do that.
On Wed, Feb 17, 2016 at 2:35 PM, Ilia Mirkin wrote:
> On Wed, Feb 17, 2016 at 6:29 AM, Manolova, Plamena
> wrote:
> >>> > + if (entries_total >
Thank you for reviewing. The change has been run through both Piglit and
CTS. I'll ask Tapani to take another look just in case.
On Wed, Feb 17, 2016 at 4:20 PM, Ilia Mirkin wrote:
> On Wed, Feb 17, 2016 at 8:49 AM, Plamena Manolova
> wrote:
> > This patch moves the calculation of current unifo
Hi Kenneth,
You're absolutely right, just setting ctx->VertexProgram.PointSizeEnabled
would be much simpler and cleaner, I'll go ahead and update the patch.
Thank you for reviewing!
On Tue, Mar 1, 2016 at 10:07 PM, Kenneth Graunke
wrote:
> On Tuesday, March 1, 2016 6:39:49 PM PST Plamena Manolov
Looks good to me :)
This series is: Reviewed-by: Plamena Manolova
On Wed, May 24, 2017 at 8:56 AM, Kenneth Graunke
wrote:
> Ben and I haven't observed these to help anything, but they enable
> hardware optimizations for particular cases. It's probably best to
> enable them ahead of time, befor
Looks good to me :) The series is:
Reviewed-by: Plamena Manolova
On Wed, Jun 14, 2017 at 2:19 AM, Jason Ekstrand
wrote:
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 ++---
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipma
Thank you for reviewing Ken!
On Thu, Oct 26, 2017 at 5:14 AM, Kenneth Graunke
wrote:
> On Wednesday, October 25, 2017 9:54:46 AM PDT Plamena Manolova wrote:
> > This patch modifies the ARB_indirect_parameters logic in
> > brw_draw_prims, so that our implementation isn't affected if
> > another a
Thank you for helping me out with this Ken!
On Tue, Oct 31, 2017 at 3:50 AM, Kenneth Graunke
wrote:
> On Monday, October 30, 2017 2:14:24 PM PDT Plamena Manolova wrote:
> > This patch modifies the ARB_indirect_parameters logic in
> > brw_draw_prims, so that our implementation isn't affected if
>
Looks good to me :)
Reviewed-by: Plamena Manolova
On Fri, Apr 21, 2017 at 9:20 AM, Elie Tournier
wrote:
> Since commit ce562f9e3fa, two new files are generated.
> We don't want to track them.
>
> Signed-off-by: Elie Tournier
> ---
> src/egl/.gitignore | 2 ++
> 1 file changed, 2 insertions(+
Hi Curro,
This series looks good to me :)
Reviewed-by: Plamena Manolova
On Fri, Apr 21, 2017 at 11:49 AM, Francisco Jerez
wrote:
> Until now the spilling cost calculation was neglecting the amount of
> data read from the register during the spilling cost calculation.
> This caused it to make s
Looks good to me :)
This series is: Reviewed-by: Plamena Manolova
On Wed, Apr 26, 2017 at 3:15 PM, Kenneth Graunke
wrote:
> We set this unconditionally on every other platform. Zero (Manhattan)
> isn't even listed as an option in the Sandybridge docs - only "true".
>
> Cc: rafael.antogno...@i
Thank you Rafael :)
On Thu, Jun 15, 2017 at 8:57 PM, Rafael Antognolli <
rafael.antogno...@intel.com> wrote:
> Indeed the other two commits are related to the no_error path, but I
> think at least this one should be applied. So it is:
>
> Reviewed-by: Rafael Antognolli
>
> On Wed, Jun 14, 2017 a
Reviewed-by: Plamena Manolova
On Wed, Jun 28, 2017 at 3:24 PM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> It turns out Gen9LP has fewer threads per EU (6 vs 7).
>
> Signed-off-by: Lionel Landwerlin
> ---
> src/intel/vulkan/anv_device.c | 5 +++--
> 1 file changed, 3 insertions
Yes, it doesn't seem to be part of the registry yet, but it's one of the
requirements for GL 4.6 apparently.
On Wed, Jun 28, 2017 at 4:53 PM, Ilia Mirkin wrote:
> Google seems to have no mention of such an extension.
> https://khronos.org/registry/OpenGL/index_gl.php doesn't either.
>
> On Wed,
Hi Ken,
Thank you so much for reviewing and helping me out with this! I'll make the
changes you suggested
to both patches and resubmit.
Thanks,
Pam
On Tue, Sep 26, 2017 at 3:32 AM, Kenneth Graunke
wrote:
> On Tuesday, August 29, 2017 9:24:01 AM PDT Plamena Manolova wrote:
> > We can implement A
Thank you Ken!
On Tue, Oct 3, 2017 at 2:26 AM, Kenneth Graunke
wrote:
> On Monday, October 2, 2017 1:58:23 PM PDT Plamena Manolova wrote:
> > A series of patches introducing ARB_indirect_parameters
> > for i965. We can implement ARB_indirect_parameters for i965
> > by taking advantage of the con
Looks good to me :)
Reviewed-by: Plamena Manolova >
On Wed, Jan 18, 2017 at 11:23 AM, Elie Tournier
wrote:
> Add the following optimisations:
>
> min(x, -x) = -abs(x)
> min(x, -abs(x)) = -abs(x)
> min(x, abs(x)) = x
> max(x, -abs(x)) = x
> max(x, abs(x)) = abs(x)
> max(x, -x) = abs(x)
>
> shade
This looks good to me :)
Reviewed-by: Plamena Manolova
On Fri, Jan 20, 2017 at 9:38 AM, Boyan Ding wrote:
> When draw buffers are changed on a bound framebuffer, DrawBuffer(s) hook
> should be called. However, it is missing in update_framebuffer with
> window-system framebuffer, in which FB's d
Thank you for reviewing guys! AFAIK this extension is a driver-side feature
and can be enabled for all drivers that support ETC1. I'll go ahead and
update my patch.
On Fri, Jan 20, 2017 at 6:25 PM, Jason Ekstrand
wrote:
> On Fri, Jan 20, 2017 at 10:16 AM, Ilia Mirkin
> wrote:
>
>> What level of
Looks good to me :) Reviewed-by: Plamena Manolova <
plamena.manol...@intel.com>
On Wed, Jan 25, 2017 at 1:30 AM, Ian Romanick wrote:
> From: Ian Romanick
>
> This is C++, so we can mix code and declarations. Doing so allows
> constification.
>
> Signed-off-by: Ian Romanick
> ---
> src/mesa/m
Thank you for reviewing Timothy!
On Mon, Apr 17, 2017 at 7:10 PM, Timothy Arceri
wrote:
>
>
> On 18/04/17 11:25, Plamena Manolova wrote:
>
>> This extension provides new GLSL built-in functions
>> beginInvocationInterlockARB() and endInvocationInterlockARB()
>> that delimit a critical section of
Thank you for reviewing Nicolai!
On Tue, Apr 18, 2017 at 4:17 AM, Nicolai Hähnle wrote:
> On 18.04.2017 03:25, Plamena Manolova wrote:
>
>> This extension provides new GLSL built-in functions
>> beginInvocationInterlockARB() and endInvocationInterlockARB()
>> that delimit a critical section of f
Hi Francisco,
Thank you for reviewing!
On Wed, Apr 19, 2017 at 4:18 PM, Francisco Jerez
wrote:
> Hi Pam, looks good overall, a couple of comments below,
>
> Plamena Manolova writes:
>
> > Adds suppport for ARB_fragment_shader_interlock. We achieve
> > the interlock and fragment ordering by issu
Looks good to me :)
Reviewed-by: Plamena Manolova
On Thu, Apr 20, 2017 at 8:24 AM, Emil Velikov
wrote:
> From: Emil Velikov
>
> As mentioned in the manual - comparing pthread_t handles via the C
> comparison operator is incorrect and pthread_equal() should be used
> instead.
>
> Cc: Timothy A
Hi Karol,
Thank you for reviewing! I'll go ahead and push the changes you need from
nir_lower_system_values.c to master.
Thank you,
Pam
On Thu, Jun 28, 2018 at 5:50 AM, Karol Herbst wrote:
> Hi,
>
> if the changes inside "src/compiler/nir/nir_lower_system_values.c" are
> extracted into a sepera
Hi Kevin,
This looks good to me :)
Reviewed-by: Plamena Manolova
On Wed, Aug 15, 2018 at 2:29 PM, wrote:
> From: Kevin Rogovin
>
> The main purpose for having NV_fragment_shader_interlock
> extension is because that extension is also for GLES31 while
> the ARB extension is for GL only.
> ---
Sure thing!
-Pam
On Mon, Aug 20, 2018 at 3:25 PM, Kevin Rogovin
wrote:
> Hi Plamena,
>
> Thankyou for the fast review. Can you push it or have someone push it? (I
> do not have push rights)
>
> -Keviv
>
> On Mon, Aug 20, 2018 at 2:50 PM, Manolova, Plamena <
> pla
Hi Kevin,
Could you also mark the extension as done in docs/features.txt? Otherwise
the series looks good to me
and with that tiny change it's Reviewed-by: Plamena Manolova <
plamena.manol...@intel.com>
Thanks,
Pam
On Mon, Aug 27, 2018 at 9:56 AM wrote:
> From: Kevin Rogovin
>
> INTEL_fragment
Actually ignore my comment, I forgot that docs/features.txt is for
non-vendor specific
features only. I'll go ahead and push your patches. Sorry for the confusion.
Thanks,
Pam
On Tue, Aug 28, 2018 at 1:04 PM Manolova, Plamena <
plamena.manol...@intel.com> wrote:
> Hi Kevin,
&g
Hi Mark,
AFAIK there is no piglit test for this specific extension. However
underneath the hood it reuses the
functionality of ARB_fragment_shader_interlock, which has a test. I believe
the only major difference between
the two extensions is that unlike beginInvocationInterlockARB,
beginFragmentSha
The series is:
Reviewed-by: Plamena Manolova
On Wed, Feb 14, 2018 at 9:18 PM, Francisco Jerez
wrote:
> ---
> docs/relnotes/18.1.0.html| 2 ++
> src/mesa/main/extensions_table.h | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/docs/relnotes/18.1.0.html b/docs/
The whole series looks good to me.
Reviewed-by: Plamena Manolova
On Mon, Mar 6, 2017 at 2:58 AM, Timothy Arceri
wrote:
> ---
> src/gallium/auxiliary/util/u_queue.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/util/u_queue.c
> b/src/gallium/auxiliary/util/u_que
Reviewed-by: Plamena Manolova
On Sat, Mar 4, 2017 at 8:47 PM, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_blorp.c | 16 +++-
> src/intel/vulkan/anv_descriptor_set.c | 7 +++
> src/intel/vulkan/anv_image.c | 4 ++--
> src/intel/vulkan/anv_private.h
Looks good to me :)
Reviewed-by: Plamena Manolova
On Tue, Mar 7, 2017 at 11:17 AM, Tapani Pälli
wrote:
> This is what comment above definition says and change fixes issue with
> 32bit build where BLOCK_POOL_MEMFD_SIZE is used as ftruncate parameter
> and constant currently gets converted from
Looks good to me :)
Reviewed-by: Plamena Manolova
On Tue, Mar 14, 2017 at 4:34 AM, Jason Ekstrand
wrote:
> The original version was very convoluted and tried way too hard to not
> just have the nested switch statement that it needs. Let's just write
> the obvious code and then we know it's cor
Looks good to me.
Reviewed-by: Plamena Manolova
On Tue, Mar 14, 2017 at 2:00 AM, Mauro Rossi wrote:
> Fixes the following building error:
>
> out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_
> intel_compiler_intermediates/compiler/brw_nir_trig_workarounds.c:1:10:
> fatal error: 'brw_
Sorry Mauro seems like an identical patch has been approved and pushed a
couple of hours ago.
Thank you,
Plamena
On Tue, Mar 14, 2017 at 11:42 AM, Manolova, Plamena <
plamena.manol...@intel.com> wrote:
> Looks good to me.
> Reviewed-by: Plamena Manolova
>
> On Tue, Mar 1
lgtm.
Reviewed-by: Plamena Manolova
On Thu, Mar 16, 2017 at 12:02 PM, Eric Engestrom
wrote:
> The registries were migrated to git and are now hosted on GitHub.
> The old svn is now read-only, and will not be updated anymore.
>
> Signed-off-by: Eric Engestrom
> ---
> docs/specs/enums.txt | 8 +
Reviewed-by: Plamena Manolova
On Thu, Mar 16, 2017 at 11:24 AM, Tapani Pälli
wrote:
> Fixes: efd63e2 ("mesa: Connect the generated GL command marshalling code
> to the build.")
> Signed-off-by: Tapani Pälli
> ---
> src/mesa/Android.gen.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletio
Reviewed-by: Plamena Manolova
On Thu, Mar 16, 2017 at 8:10 AM, Tapani Pälli
wrote:
> According to dl_iterate_phdr man page first object visited is the
> main program where dlpi_name is an empty string. This fixes segfault
> on Android when using build-id as identifier.
>
> Signed-off-by: Tapani
Thank you for taking a look Jason!
Sorry my bad, I'll make sure to add some comments to v2 at least. Hopefully
it'll make editing this portion of
the i965 drawing logic a bit easier.
On Fri, Sep 8, 2017 at 4:48 AM, Jason Ekstrand wrote:
> Hey Pam!
>
> A quick skim through this looks fairly good
Hi Jason,
Thank you so much for reviewing! In my initial series for
ARB_compute_variable_group_size
(https://patchwork.freedesktop.org/patch/228130) from which this is
extracted, I moved
lowering these variables to brw_nir_lower_cs_intrinsics and did what you're
suggesting i.e.
I used the load_loca
Looks good to me :)
Reviewed-by: Plamena Manolova
On Fri, Nov 16, 2018 at 7:02 AM Jason Ekstrand wrote:
> It's not at all intel-specific; the formula is dictated by OpenGL and
> Vulkan. The only intel-specific thing is that we need the lowering. As
> a nice side-effect, the new version is va
Hi Daniel,
Thanks for reviewing!
On Fri, May 13, 2016 at 5:09 PM, Daniel Stone wrote:
> Hi,
>
> On 13 May 2016 at 17:03, Plamena Manolova
> wrote:
> > @@ -444,6 +444,8 @@ _eglCreateAPIsString(_EGLDisplay *dpy)
> >strcat(dpy->ClientAPIsString, "OpenVG ");
> >
> > assert(strlen(dpy->C
Hi Emil,
Thanks for reviewing!
On Wed, May 18, 2016 at 12:11 PM, Emil Velikov
wrote:
> Hi Plamena,
>
> On 17 May 2016 at 17:35, Plamena Manolova
> wrote:
> > According to the EGL specifications before binding an API
> > we must check whether it's supported first. If not eglBindAPI
> > should r
Hi Ian,
Thanks for reviewing!
On Wed, May 18, 2016 at 4:33 PM, Ian Romanick wrote:
> On 05/17/2016 09:35 AM, Plamena Manolova wrote:
> > According to the EGL specifications before binding an API
> > we must check whether it's supported first. If not eglBindAPI
> > should return EGL_FALSE and gen
On Wed, May 18, 2016 at 8:44 PM, Ian Romanick wrote:
> On 05/18/2016 11:45 AM, Manolova, Plamena wrote:
> > Hi Ian,
> > Thanks for reviewing!
> >
> > On Wed, May 18, 2016 at 4:33 PM, Ian Romanick > <mailto:i...@freedesktop.org>> wrote:
> >
> >
I just thought that it might be useful to note that due to the ES2/ES3
strings
being present in the APIs string some dEQP tests are currently failing.
Namely
dEQP-EGL.functional.negative_api* and
dEQP-EGL.functional.query_context.simple.query_api
On Wed, May 18, 2016 at 12:03 PM, Erik Faye-Lund
w
Hi Brian,
On Mon, May 23, 2016 at 9:51 PM, Brian Paul wrote:
> Hi Plamena,
>
> Some style nitpicks below. Feel free to take 'em or leave 'em.
> I'm not too involved in EGL.
>
>
>
> On 05/23/2016 10:27 AM, Plamena Manolova wrote:
>
>> According to the EGL specifications before binding an API
>>
That's so awesome, congrats! \O/
On Wed, Nov 20, 2019 at 6:37 PM Kenneth Graunke
wrote:
> Hi all,
>
> iris is now officially a conformant OpenGL 4.6 implementation!
>
>
> https://www.khronos.org/conformance/adopters/conformant-products/opengl#submission_253
>
> This is on Gen9. I've also submit
60 matches
Mail list logo
