[Mesa-dev] [PATCH] GL: Update glext.h to fix ARB_dsa function prototypes.

--- include/GL/glext.h | 48 ++-- 1 file changed, 26 insertions(+), 22 deletions(-) diff --git a/include/GL/glext.h b/include/GL/glext.h index d3cfbb5..0ca89ca 100644 --- a/include/GL/glext.h +++ b/include/GL/glext.h @@ -33,7 +33,7 @@ extern "C" { ** u

Re: [Mesa-dev] [PATCH] GL: Update glext.h to fix ARB_dsa function prototypes.

I checked, and all of the currently implemented DSA functions build with this file. Laura On Fri, Jan 23, 2015 at 2:20 PM, Laura Ekstrand wrote: > --- > include/GL/glext.h | 48 ++-- > 1 file changed, 26 insertions(+), 22 deletions(-) >

Re: [Mesa-dev] [PATCH 01/41] glapi: Added ARB_direct_state_access.xml file.

gmail.com <mailto:emil.l.veli...@gmail.com> > > > <mailto:emil.l.veli...@gmail.com > > <mailto:emil.l.veli...@gmail.com>>> wrote: > > > > > > On 05/01/15 17:45, Laura Ekstrand wrote: > > > > This comment is va

Re: [Mesa-dev] [PATCH] doc: break down ARB_direct_state_access in GL3.txt

Good idea. Reviewed-by: Laura Ekstrand On Thu, Jan 29, 2015 at 6:54 AM, Martin Peres wrote: > A student was wondering what was going on + I started working on it too. > > CC: Laura Ekstrand > Signed-off-by: Martin Peres > --- > docs/GL3.txt | 11 ++- > 1 file c

Re: [Mesa-dev] [PATCH 2/6] main: Added entry point for glTransformFeedbackBufferBase

On Thu, Jan 29, 2015 at 4:55 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - give more helpful error messages > - factor the lookup code for the xfb and objBuf > - replace some already-existing tabs with spaces > - add comments to explain the cases where xfb == 0

Re: [Mesa-dev] [PATCH 3/6] main: Added entry point for glTransformFeedbackBufferRange

On Thu, Jan 29, 2015 at 4:55 AM, Martin Peres wrote: > v2: review from Laura Ekstrand > - use the refactored code to lookup the objects > - improve some error messages > - factor out the gl method name computation > - better handle the spec differences between the DSA and non-DSA

[Mesa-dev] Fwd: [PATCH 06/21] main: Add entry point for NamedBufferData.

-- Forwarded message -- From: Laura Ekstrand Date: Fri, Jan 30, 2015 at 3:42 PM Subject: Re: [Mesa-dev] [PATCH 06/21] main: Add entry point for NamedBufferData. To: Ian Romanick On Wed, Jan 21, 2015 at 6:28 PM, Ian Romanick wrote: > On 01/21/2015 05:40 PM, Laura Ekstr

[Mesa-dev] [PATCH] DD: Refactor BlitFramebuffer.

In preparation for glBlitNamedFramebuffer, the DD table function BlitFramebuffer needs to accept two arbitrary framebuffer objects rather than assuming ctx->ReadBuffer and ctx->DrawBuffer. --- src/mesa/drivers/common/meta.c| 3 +- src/mesa/drivers/common/meta.h

Re: [Mesa-dev] [PATCH] GL: Update glext.h to fix ARB_dsa function prototypes.

It's updated to: GL: Update glext.h to Khronos Revision 29537. Khronos Revision 29537 fixes ARB_direct_state_access function prototypes that had GLsizei where they should have had GLsizeiptr. The mainly affects functions related to buffer objects. _

Re: [Mesa-dev] [PATCH 03/21] GL: Correct function arguments for NamedBufferStorage.

There's a patch to replace these now: GL: Update glext.h to Khronos Revision 29537. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 08/21] main: Add entry point for NamedBufferSubData.

On Wed, Jan 21, 2015 at 6:42 PM, Ian Romanick wrote: > On 01/21/2015 05:40 PM, Laura Ekstrand wrote: > > --- > > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 ++ > > src/mesa/main/bufferobj.c | 150 > - > &

Re: [Mesa-dev] [PATCH] DD: Refactor BlitFramebuffer.

s&id=fc85665eaa9aff824051333848540958dd07cbd0 Laura On Mon, Feb 2, 2015 at 7:52 AM, Brian Paul wrote: > I'd have put the swrast whitespace changes in a separate commit, but it's > not a big deal. > > Reviewed-by: Brian Paul > > > > On 01/30/2015 05:25 PM, Lau

Re: [Mesa-dev] [PATCH] DD: Refactor BlitFramebuffer.

After a very thorough search, I did find two lines in i965/intel_fbo.c that had ctx->DrawBuffer when they were supposed to have drawFb. Here's the new commit: http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-framebuffers&id=d9d7e65cd6a0fe2c864803a77e34d0f52e8609b6 . _

Re: [Mesa-dev] [PATCH 1/6] main: Added entry point for glCreateTransformFeedbacks

On Mon, Feb 2, 2015 at 2:58 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - generate the name of the gl method once > - shorten some lines to stay in the 78 chars limit > > v3: Review from Fredrik Höglund > - rename gl_mthd_name to func &g

Re: [Mesa-dev] [PATCH 2/6] main: Added entry point for glTransformFeedbackBufferBase

Oops, what I meant to say was "Make the bufferobj lookup function static." The lookup transform feedback function doesn't have to be static. On Mon, Feb 2, 2015 at 6:09 AM, Ilia Mirkin wrote: > On Mon, Feb 2, 2015 at 6:00 AM, Martin Peres > wrote: > > +static struct gl_transform_feedback_object

Re: [Mesa-dev] [PATCH 2/6] main: Added entry point for glTransformFeedbackBufferBase

On Mon, Feb 2, 2015 at 3:00 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - give more helpful error messages > - factor the lookup code for the xfb and objBuf > - replace some already-existing tabs with spaces > - add comments to explain the cases where xfb == 0

Re: [Mesa-dev] [PATCH 3/6] main: Added entry point for glTransformFeedbackBufferRange

On Mon, Feb 2, 2015 at 3:30 AM, Martin Peres wrote: > v2: review from Laura Ekstrand > - use the refactored code to lookup the objects > - improve some error messages > - factor out the gl method name computation > - better handle the spec differences between the DSA and non-DSA

Re: [Mesa-dev] [PATCH 08/21] main: Add entry point for NamedBufferSubData.

2015 02:21 AM, Laura Ekstrand wrote: > > > > > > On Wed, Jan 21, 2015 at 6:42 PM, Ian Romanick > <mailto:i...@freedesktop.org>> wrote: > > > > On 01/21/2015 05:40 PM, Laura Ekstrand wrote: > > > --- > > > src/mapi/glapi/gen/

[Mesa-dev] [PATCH] GL: Update glext.h to Revision 29735.

Khronos modified glext.h to get rid of GL_TEXTURE_BINDING, a special enum added for ARB_direct_state_access. This enum was ruled unimplementable. --- include/GL/glext.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/include/GL/glext.h b/include/GL/glext.h index

Re: [Mesa-dev] Naming conventions, DSA, and meta

I'm planning to release a v2 for buffer objects. Can we get the naming scheme decided upon? I suggest mesa buffer data fallback. On Feb 3, 2015 10:30 AM, "Kristian Høgsberg" wrote: > On Mon, Feb 2, 2015 at 11:59 AM, Thomas Helland > wrote: > > 2015-02-02 19:18 GMT+01:00 Jason Ekstrand : > >> H

[Mesa-dev] [PATCH 15/23] main: Add entry points for MapNamedBuffer[Range].

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 14 + src/mesa/main/bufferobj.c | 42 ++ src/mesa/main/bufferobj.h | 14 +++-- src/mesa/main/tests/dispatch_sanity.cpp| 2 ++ 4 files changed, 69 insertions(+

[Mesa-dev] [PATCH 09/23] main: Cosmetic changes to BufferSubData infrastructure.

--- src/mesa/main/bufferobj.c | 10 +++--- src/mesa/main/bufferobj.h | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 4f89748..fc01d02 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@

[Mesa-dev] [PATCH 12/23] main: Add entry points for ClearNamedBuffer[Sub]Data.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 18 + src/mesa/main/bufferobj.c | 35 ++ src/mesa/main/bufferobj.h | 11 src/mesa/main/tests/dispatch_sanity.cpp| 2 ++ 4 files changed, 66 insertion

[Mesa-dev] [PATCH 11/23] main: Refactor ClearBuffer[Sub]Data.

v2: review by Jason Ekstrand - Split refactor of clear buffer sub data from addition of DSA entry points. --- src/mesa/main/bufferobj.c| 125 --- src/mesa/main/bufferobj.h| 19 ++-- src/mesa/state_tracker/st_cb_bufferobjects.

[Mesa-dev] [PATCH 04/23] main: Tex[ture]Buffer[Range] functions now use _mesa_lookup_bufferobj_err.

--- src/mesa/main/teximage.c | 46 +- 1 file changed, 25 insertions(+), 21 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index ce6f446..d17f15e 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5091

[Mesa-dev] [PATCH 08/23] main: Add entry point for NamedBufferSubData.

v2: review by Ian Romanick - Remove "_mesa" from name of static software fallback buffer_sub_data. - Remove mappedRange from _mesa_buffer_sub_data. - Removed some cosmetic changes to a separate commit. --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 ++ src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH 18/23] main: Add entry point for FlushMappedNamedBufferRange.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/bufferobj.c | 16 src/mesa/main/bufferobj.h | 4 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 27 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 19/23] main: Refactor GetBufferParameteri[64]v.

v2: Split into a refactor commit and an entry point commit. --- src/mesa/main/bufferobj.c | 119 ++ 1 file changed, 45 insertions(+), 74 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9b3d2ea..dfeda21 100644 --- a/

[Mesa-dev] [PATCH 02/23] main: Add entry point for TextureBufferRange.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 +++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + src/mesa/main/teximage.c | 90 ++ src/mesa/main/teximage.h | 4 ++ 4 files changed, 103 insertions(+) diff --git

[Mesa-dev] [PATCH 23/23] main: Cosmetic changes to GetBufferSubData.

--- src/mesa/main/bufferobj.c | 2 +- src/mesa/main/bufferobj.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0272704..38d8b5a 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1668,7 +1

[Mesa-dev] [PATCH 14/23] main: Refactor MapBuffer[Range].

v2: review from Jason Ekstrand - Split refactor from addition of DSA entry points. review from Ian Romanick - Remove "_mesa" from static software fallback map_buffer_range - Restore VBO_DEBUG and BOUNDS_CHECK --- src/mesa/main/bufferobj.c | 286

[Mesa-dev] [PATCH 03/23] main: Add utility function _mesa_lookup_bufferobj_err.

--- src/mesa/main/bufferobj.c | 19 +++ src/mesa/main/bufferobj.h | 4 2 files changed, 23 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0c1ce98..b7dce0e 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1001,

[Mesa-dev] [PATCH 07/23] main: Add entry point for NamedBufferData.

v2: review from Ian Romanick - Fix space in ARB_direct_state_access.xml. - Remove "_mesa" from the name of buffer_data static fallback. - Restore VBO_DEBUG and BOUNDS_CHECK. - Fix beginning of comment to start on same line as /* --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +

[Mesa-dev] [PATCH 21/23] main: Add entry point for GetNamedBufferPointerv.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/bufferobj.c | 27 +++--- src/mesa/main/bufferobj.h | 4 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 35 insertions(+), 3 dele

[Mesa-dev] [PATCH 10/23] main: Add entry point for CopyNamedBufferSubData.

v2: remove _mesa in front of static software fallback. --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 +++ src/mesa/main/bufferobj.c | 99 +- src/mesa/main/bufferobj.h | 12 src/mesa/main/tests/dispatch_sanity.cpp

[Mesa-dev] [PATCH 13/23] main: Minor whitespace fixes in ClearNamedBuffer[Sub]Data.

--- src/mesa/main/bufferobj.c | 4 ++-- src/mesa/main/bufferobj.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index bd21c8a..88230d6 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1765,10

[Mesa-dev] [PATCH 00/23] ARB_direct_state_access buffer objects (v2)

tware fallback _mesa_alloc_texture_storage, the software fallback was renamed to _mesa_AllocTextureStorage_sw. Laura Ekstrand (23): main: Fix whitespace in teximage.c. main: Add entry point for TextureBufferRange. main: Add utility function _mesa_lookup_bufferobj_err. main: Tex[ture]Buffer[

[Mesa-dev] [PATCH 17/23] main: Refactor FlushMappedBufferRange.

v2:-Remove "_mesa" from in front of static software fallback. -Split out the refactor from the addition of the DSA entry points. --- src/mesa/main/bufferobj.c | 60 +++ src/mesa/main/bufferobj.h | 6 + 2 files changed, 40 insertions(+), 26 deleti

[Mesa-dev] [PATCH 20/23] main: Add entry points for GetBufferParameteri[64]v.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 12 src/mesa/main/bufferobj.c | 39 ++ src/mesa/main/bufferobj.h | 7 + src/mesa/main/tests/dispatch_sanity.cpp| 2 ++ 4 files changed, 60 insertions(+) di

[Mesa-dev] [PATCH 22/23] main: Add entry point for glGetNamedBufferSubData.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ src/mesa/main/bufferobj.c | 22 ++ src/mesa/main/bufferobj.h | 4 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 34 insertions(+) diff --gi

[Mesa-dev] [PATCH 16/23] main: Add entry point for UnmapNamedBuffer.

v2: review from Ian Romanick - Restore VBO_DEBUG and BOUNDS_CHECK - Remove _mesa from static software fallback unmap_buffer. --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 5 +++ src/mesa/main/bufferobj.c | 47 +++--- src/mesa/main/bufferobj.h

[Mesa-dev] [PATCH 06/23] main: Add entry point for NamedBufferStorage.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ src/mesa/main/bufferobj.c | 63 +++--- src/mesa/main/bufferobj.h | 9 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 64 insertions(+), 16 deleti

[Mesa-dev] [PATCH 01/23] main: Fix whitespace in teximage.c.

--- src/mesa/main/teximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 29c325b..336feff 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5031,7 +5031,7 @@ _mesa_validate_texbuffer_format(con

[Mesa-dev] [PATCH 05/23] main: Add entry point for CreateBuffers.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ src/mesa/main/bufferobj.c | 65 -- src/mesa/main/bufferobj.h | 5 +- src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 64 insertions(+), 14 deletion

Re: [Mesa-dev] [PATCH 00/23] ARB_direct_state_access buffer objects (v2)

changed them in the v2 to remove the "_mesa." On Thu, Feb 12, 2015 at 12:12 PM, Ilia Mirkin wrote: > On Thu, Feb 12, 2015 at 3:09 PM, Martin Peres > wrote: > > On 12/02/15 04:05, Laura Ekstrand wrote: > >> > >> This includes a v2 of all of the buffer object

Re: [Mesa-dev] [PATCH 02/16] main: replace tabs by 8 spaces in fbobject.c

LGTM. Reviewed-by: Laura Ekstrand On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > src/mesa/main/fbobject.c | 166 > +++ > 1 file changed, 83 insertions(+), 83 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 01/16] main: replace tabs by 8 spaces in bufferobj.c

LGTM. Reviewed-by: Laura Ekstrand On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > src/mesa/main/queryobj.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/main/queryobj.c b/src/me

[Mesa-dev] [PATCH] main: Fixed _mesa_GetCompressedTexImage_sw to copy slices correctly.

Previously array textures were not working with GetCompressedTextureImage, leading to failures in the test arb_direct_state_access/getcompressedtextureimage.c. Tested on Haswell. --- src/mesa/main/texgetimage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/

[Mesa-dev] [PATCH 1/2] i965: Minor fixes to PBO uploads and downloads.

Fixes all of the failures in arb_direct_state_access/gettextureimage-targets except for GL_TEXTURE_1D_ARRAY PBO. Previously, the miptree for meta pbo uploads and downloads was not getting initialized correctly. --- src/mesa/drivers/common/meta_tex_subimage.c | 8 ++-- src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 2/2] common: Fix PBOs for 1D_ARRAY.

Corrects the way that _mesa_meta_pbo_TexSubImage and _mesa_meta_pbo_GetTexSubImage handle 1D_ARRAY textures. Fixes a failure in the Piglit arb_direct_state_access/gettextureimage-targets test. --- src/mesa/drivers/common/meta_tex_subimage.c | 60 - 1 file changed, 34 i

Re: [Mesa-dev] [PATCH 07/23] main: Add entry point for NamedBufferData.

On Wed, Feb 18, 2015 at 7:40 AM, Martin Peres wrote: > > On 12/02/15 04:05, Laura Ekstrand wrote: > >> v2: review from Ian Romanick >> - Fix space in ARB_direct_state_access.xml. >> - Remove "_mesa" from the name of buffer_data static fallback. >&g

Re: [Mesa-dev] [PATCH 06/23] main: Add entry point for NamedBufferStorage.

This is NamedBufferStorage, not NamedBufferData. The storage function uses a bitfield instead of an enum. On Wed, Feb 18, 2015 at 7:04 AM, Martin Peres wrote: > On 12/02/15 04:05, Laura Ekstrand wrote: > >> --- >> src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++

Re: [Mesa-dev] [PATCH 23/23] main: Cosmetic changes to GetBufferSubData.

> > > On 12/02/2015 04:06, Laura Ekstrand wrote: > >> --- >> src/mesa/main/bufferobj.c | 2 +- >> src/mesa/main/bufferobj.h | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/

Re: [Mesa-dev] [PATCH 11/23] main: Refactor ClearBuffer[Sub]Data.

15 04:05, Laura Ekstrand wrote: > >> v2: review by Jason Ekstrand >> - Split refactor of clear buffer sub data from addition of DSA entry >> points. >> --- >> src/mesa/main/bufferobj.c| 125 >> --- >>

Re: [Mesa-dev] [PATCH 04/16] main: Added entry point for glCreateTransformFeedbacks

Looks good to me Reviewed-by: Laura Ekstrand On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - generate the name of the gl method once > - shorten some lines to stay in the 78 chars limit > > v3: Review from Fredrik Höglund > - rena

Re: [Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

Please provide a page number and a section title in your spec comment. Thanks. On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres wrote: > Maybe this should be the job of the dispatch layer. > > Signed-off-by: Martin Peres > --- > src/mesa/main/multisample.c | 9 + > 1 file changed, 9 inse

Re: [Mesa-dev] [PATCH 13/23] main: Minor whitespace fixes in ClearNamedBuffer[Sub]Data.

Again, Ian requested that this be a separate commit. On Fri, Feb 20, 2015 at 6:22 AM, Martin Peres wrote: > Please squash this in the previous commit (with git rebase -i). > > > On 12/02/2015 04:05, Laura Ekstrand wrote: > >> --- >> src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH 08/23] main: Add entry point for NamedBufferSubData.

te: > On 12/02/2015 04:05, Laura Ekstrand wrote: > >> v2: review by Ian Romanick >> - Remove "_mesa" from name of static software fallback >> buffer_sub_data. >> - Remove mappedRange from _mesa_buffer_sub_data. >> - Removed some cos

[Mesa-dev] [PATCH 4/4] i965: Force miptrees for BOs to have all slices in each lod.

Textures made expressly for internal buffer objects shouldn't have extra padding around them, but should be densely packed. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mes

[Mesa-dev] [PATCH 3/4] common: Fix PBOs for 1D_ARRAY.

Corrects the way that _mesa_meta_pbo_TexSubImage and _mesa_meta_pbo_GetTexSubImage handle 1D_ARRAY textures. Fixes a failure in the Piglit arb_direct_state_access/gettextureimage-targets test. --- src/mesa/drivers/common/meta_tex_subimage.c | 62 + 1 file changed, 36 i

[Mesa-dev] [PATCH 2/4] common: Correct PBO 2D_ARRAY handling.

Changes PBO uploads and downloads to use a tall (height * depth) 2D texture for blitting. This fixes the bug where 2D_ARRAY, 3D, and CUBE_MAP_ARRAY textures are not properly uploaded and downloaded. --- src/mesa/drivers/common/meta_tex_subimage.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[Mesa-dev] [PATCH 0/4] v2: Fix PBO uploads/downloads.

This is a more robust set of patches to fix Meta PBO texture uploads and downloads. This fixes bugs related to array PBOs that were found using the new set of getteximage-targets tests. Laura Ekstrand (4): common: Correct texture initialization in create_texture_for_pbo. common: Correct PBO

[Mesa-dev] [PATCH 1/4] common: Correct texture initialization in create_texture_for_pbo.

Solves bugs related to the driver not setting up the texture miptree correctly, leading to faulty PBO uploads and downloads. --- src/mesa/drivers/common/meta_tex_subimage.c | 13 + src/mesa/drivers/dri/i965/intel_tex.c | 3 ++- src/mesa/main/dd.h | 1 +

Re: [Mesa-dev] [PATCH 05/16] main: Added entry point for glTransformFeedbackBufferBase

e other hand, the names that you gave to lookup_transform_feedback_object_err and lookup_transform_feedback_bufferobj_err are just fine because these functions are static and never called outside transformfeedback.c. On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand >

Re: [Mesa-dev] [PATCH 06/16] main: Added entry point for glTransformFeedbackBufferRange

On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres wrote: > v2: review from Laura Ekstrand > - use the refactored code to lookup the objects > - improve some error messages > - factor out the gl method name computation > - better handle the spec differences between the DSA and non-DSA

Re: [Mesa-dev] [PATCH 2/4] common: Correct PBO 2D_ARRAY handling.

sa_get_image_stride familiy of > functions to see exactly how to handle this. > > On Fri, Feb 20, 2015 at 4:30 PM, Laura Ekstrand > wrote: > >> Changes PBO uploads and downloads to use a tall (height * depth) 2D >> texture >> for blitting. This fixes the bug where 2D_ARRA

Re: [Mesa-dev] [PATCH 4/4] i965: Force miptrees for BOs to have all slices in each lod.

weird because it won't really > be using the ALL_SLICES_AT_EACH_LOD layout and it will only be correct > if there are no mipmaps. Instead it might be better to handle it > directly when picking the qpitch value like the Skylake patch. > > Regards, > - Neil > > Laura Ekstrand w

[Mesa-dev] [PATCH 1/2] common: Correct texture init for meta pbo uploads and downloads.

This moves the line setting immutability for the texture to after _mesa_initialize_texture_object so that the initializer function will not cancel it out. Moreover, because of the ARB_texture_view extension, immutable textures must have NumLayers > 0, or depth will equal (0-1)=0x during SUR

[Mesa-dev] [PATCH 2/2] common: Correct PBO 2D_ARRAY handling.

Changes PBO uploads and downloads to use a tall (height * depth) 2D texture for blitting. This fixes the bug where 2D_ARRAY, 3D, and CUBE_MAP_ARRAY textures are not properly uploaded and downloaded. Removes the option to use a 2D ARRAY texture for the PBO during upload and download. This option d

Re: [Mesa-dev] [PATCH 05/16] main: Added entry point for glTransformFeedbackBufferBase

Looks good to me. Reviewed-by: Laura Ekstrand On Mon, Feb 23, 2015 at 6:47 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - give more helpful error messages > - factor the lookup code for the xfb and objBuf > - replace some already-existing tabs with spaces > -

[Mesa-dev] [PATCH] main: Fix target checking for CompressedTexSubImage*D.

This fixes a dEQP test failure. In the test, glCompressedTexSubImage2D was called with target = 0 and failed to throw INVALID ENUM. This failure was caused by _mesa_get_current_tex_object(ctx, target) being called before the target checking. To remedy this, target checking was made into its own f

Re: [Mesa-dev] [PATCH 3/4] common: Fix PBOs for 1D_ARRAY.

This was an unfortunate artifact of rebasing; I fixed the 1D array bug before figuring out a robust fix for the 2D array bug (7a49f2e). I think that you are right, although I'm confused what you are doing with the variable image_height that you added. It seems like you should be able to get rid o

Re: [Mesa-dev] [PATCH 3/4] common: Fix PBOs for 1D_ARRAY.

Ah, now that I looked at your other patch I see why you have image_height. On Wed, Feb 25, 2015 at 5:33 PM, Laura Ekstrand wrote: > This was an unfortunate artifact of rebasing; I fixed the 1D array bug > before figuring out a robust fix for the 2D array bug (7a49f2e). I think > tha

[Mesa-dev] [PATCH] main: Fix comment for SetTextureStorageForBufferObject.

It is really difficult to robustly create a 2D ARRAY texture for a buffer object because this poses some miptree problems (as I discovered while trying to fix Meta PBO uploads and downloads). Therefore, we should stop advertising 2D ARRAY as an acceptable target for this function. --- src/mesa/mai

[Mesa-dev] [PATCH] main: Fix target checking for CopyTexSubImage*D.

This fixes a dEQP test failure. In the test, glCopyTexSubImage2D was called with target = 0 and failed to throw INVALID ENUM. This failure was caused by _mesa_get_current_tex_object(ctx, target) being called before the target checking. To remedy this, target checking was separated from the main e

Re: [Mesa-dev] [PATCH 07/16] main: Added entry point for glGetTransformFeedbackiv

Looks good to me. Reviewed-by: Laura Ekstrand On Mon, Feb 16, 2015 at 6:13 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - use the transform feedback object lookup wrapper > > Signed-off-by: Martin Peres > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml

Re: [Mesa-dev] [PATCH 09/16] main: Added entry point for glGetTransformFeedbacki64_v

On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres wrote: > v2: Review from Laura Ekstrand > - use the transform feedback object lookup wrapper > > v3: > - use the new name of _mesa_lookup_transform_feedback_object_err > > Signed-off-by: Martin Peres > -

Re: [Mesa-dev] [PATCH 10/16] main: Added entry point for glCreateQueries

const GLuint *ids); > GLboolean GLAPIENTRY > _mesa_IsQuery(GLuint id); > diff --git a/src/mesa/main/tests/dispatch_sanity.cpp > b/src/mesa/main/tests/dispatch_sanity.cpp > index ad5da83..ee448f1 100644 > --- a/src/mesa/main/tests/dispatch_sanity.cpp > +++ b/src/mesa/main/tests/di

Re: [Mesa-dev] [PATCH 11/16] main: Added entry points for glGetQueryBufferObject*

LGTM. Reviewed-by: Laura Ekstrand On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres wrote: > These entry points will be fleshed out when the GL_ARB_query_buffer_object > extension gets implemented. In the meantime, return GL_INVALID_OPERATION as > suggested by Ian. > > Signed-off-b

Re: [Mesa-dev] [PATCH 13/16] main: Added entry point for glCreateSamplers

LGTM. Reviewed-by: Laura Ekstrand On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ > src/mesa/main/samplerobj.c | 26 > -- &

Re: [Mesa-dev] [PATCH 14/16] main: Added entry point for glCreateRenderbuffers

Reviewed-by: Laura Ekstrand On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 + > src/mesa/main/fbobject.c | 37 > +- > src/me

Re: [Mesa-dev] [PATCH 15/16] main: Added entry point for glGetNamedRenderbufferParameteriv

; @@ -962,6 +962,7 @@ const struct function gl_core_functions_possible[] = { > { "glGetTransformFeedbacki_v", 45, -1 }, > { "glGetTransformFeedbacki64_v", 45, -1 }, > { "glCreateRenderbuffers", 45, -1 }, > + { "glGetNamedRenderbufferParameteriv", 45, -1 }, > { "glCreateTextures", 45, -1 }, > { "glTextureStorage1D", 45, -1 }, > { "glTextureStorage2D", 45, -1 }, > -- > 2.3.0 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > With that one nit fixed, Reviewed-by: Laura Ekstrand ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 16/16] main: Added entry points for NamedRenderbufferStorage/Multisample

On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > src/mapi/glapi/gen/ARB_direct_state_access.xml | 15 +++ > src/mesa/main/fbobject.c | 147 > ++--- > src/mesa/main/fbobject.h | 9 ++ > s

[Mesa-dev] [PATCH 1/6] main: Check for NULL in texturesubimage.

--- src/mesa/main/teximage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 6e45cc9..dfad9ed 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3688,6 +3688,8 @@ texturesubimage(struct gl_context *ctx, GLuint di

[Mesa-dev] [PATCH 4/6] main: Add utility function _mesa_lookup_bufferobj_err.

--- src/mesa/main/bufferobj.c | 19 +++ src/mesa/main/bufferobj.h | 4 2 files changed, 23 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index f026fc3..617242b 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1006,

[Mesa-dev] [PATCH 5/6] main: Refactor Tex[ture]Buffer[Range].

Uses _mesa_lookup_bufferobj_err to clean up buffer object retrieval. Moves error checking statements into separate functions to allow code sharing between traditional and ARB_direct_state_access entry points. --- src/mesa/main/teximage.c | 201 ++- src/

[Mesa-dev] [PATCH 3/6] main: Checking for cube completeness in GetCompressedTextureImage.

--- src/mesa/main/texgetimage.c | 51 - 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index 24df5b6..327a397 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetimag

[Mesa-dev] [PATCH 6/6] main: Add entry point for TextureBufferRange.

v2: Review by Martin Peres - Get rid of difficult-to-follow code copied and pasted from the original TexBufferRange --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 + src/mesa/main/tests/dispatch_sanity.cpp| 1 + src/mesa/main/teximage.c | 46

[Mesa-dev] [PATCH 2/6] main: Add TEXTURE_CUBE_MAP support for glCompressedTextureSubImage3D.

--- src/mesa/main/teximage.c | 204 --- src/mesa/main/teximage.h | 3 +- 2 files changed, 179 insertions(+), 28 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index dfad9ed..d454dd9 100644 --- a/src/mesa/main/teximage.c

[Mesa-dev] [PATCH 10/38] main: Add entry points for glNamedFramebufferTexture[Layer].

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 15 +++ src/mesa/main/fbobject.c | 62 ++ src/mesa/main/fbobject.h | 8 src/mesa/main/tests/dispatch_sanity.cpp| 2 + 4 files changed, 87 insertions(+) diff

[Mesa-dev] [PATCH 17/38] main: Refactor _mesa_update_framebuffer.

_mesa_update_framebuffer now operates on arbitrary read and draw framebuffers. This allows BlitNamedFramebuffer to update the state of its arbitrary read and draw framebuffers. --- src/mesa/drivers/dri/i915/i830_vtbl.c | 2 +- src/mesa/drivers/dri/i915/i915_vtbl.c | 2 +- src/mesa/dr

[Mesa-dev] [PATCH 30/38] main: Fake entry point for glClearNamedFramebufferfi.

Mesa's ClearBuffer framework is very complicated and thoroughly married to the object binding model. Moreover, the OpenGL spec for ClearBuffer is also very complicated. At some point, we should implement buffer clearing for arbitrary framebuffer objects, but for now, we will just wrap ClearBuffer

[Mesa-dev] [PATCH 18/38] main: Refactor _mesa_[update|get]_clamp_vertex_color.

--- src/mesa/main/blend.c | 13 - src/mesa/main/blend.h | 7 +-- src/mesa/main/framebuffer.c | 2 +- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 774fc88..ee76b47 100644 --- a/src/mesa/main/blend.c

[Mesa-dev] [PATCH 12/38] main: Fix indents in former get_texture_for_framebuffer functions.

--- src/mesa/main/fbobject.c | 82 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 4df0b6b..1435576 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -24

[Mesa-dev] [PATCH 11/38] main: Major refactor of get_texture_for_framebuffer.

This splits off the (still) rather large chunk that is get_texture_for_framebuffer into lots of smaller functions specialized to service the wide variety of unique needs of *FramebufferTexture* entry points. The result is much cleaner because, rather than having a pile of branches and confusing con

[Mesa-dev] [PATCH 31/38] main: Add stubs for [Get]NamedFramebufferParameteri[v].

The ARB_direct_state_access specification says (as of 2015.02.05): "Interactions with OpenGL 4.3 or ARB_framebuffer_no_attachments If neither OpenGL 4.3 nor ARB_framebuffer_no_attachments are supported, ignore the support for NamedFramebufferParameteri and GetNamedFramebuff

[Mesa-dev] [PATCH 25/38] main: Complete error conditions for glInvalidate*Framebuffer.

--- src/mesa/main/fbobject.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 7a1684c..0b4cabe 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -3476,12 +3476,29 @@ invalidate_f

[Mesa-dev] [PATCH 09/38] main: Fix indentation in get_texture_for_framebuffer.

--- src/mesa/main/fbobject.c | 148 +++ 1 file changed, 74 insertions(+), 74 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index f86e1a0..2ac9903 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -24

[Mesa-dev] [PATCH 20/38] main: Refactor _mesa_get_clamp_read_color.

This wasn't neccessary for ARB_direct_state_access, but felt like a good idea for the sake of completeness. --- src/mesa/main/blend.c | 5 +++-- src/mesa/main/blend.h | 3 ++- src/mesa/main/readpix.c | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/blend.c

[Mesa-dev] [PATCH 16/38] main: Refactor glBlitFramebuffer.

--- src/mesa/main/blit.c | 119 --- src/mesa/main/blit.h | 7 +++ 2 files changed, 73 insertions(+), 53 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index 899dd45..b6d6d75 100644 --- a/src/mesa/main/blit.c +++ b/src/mesa/m

  1   2   3   4   >