Re: [Mesa-dev] [PATCH 1/2] tgsi: texture types

tions when the users don't even know about them. Marek On Tue, Jun 9, 2015 at 6:01 PM, Rob Clark wrote: On Tue, Jun 9, 2015 at 9:32 AM, Roland Scheidegger wrote: Am 09.06.2015 um 15:00 schrieb Rob Clark: On Tue, Jun 9, 2015 at 5:01 AM, Jose Fonseca wrote: On 09/06/15 04:03, Rob Cl

Re: [Mesa-dev] COMPSIZE function in OpenGL XML registry

I'm not sure what you are trying to accomplish. if you're doing some sort of serialization of OpenGL calls other than GLX, then it might be worthwhile to look at https://github.com/apitrace/apitrace/blob/master/specs/glapi.py https://github.com/apitrace/apitrace/blob/master/helpers/glsize.

Re: [Mesa-dev] [PATCH 2/3] mesa/main: avoid null access in format_array_table_init()

On 05/05/15 11:50, Juha-Pekka Heikkila wrote: If _mesa_hash_table_create failed we'd get null pointer. Report error and go away. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/formats.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/main/formats.c b/src/mesa/m

Re: [Mesa-dev] [PATCH] gallium: remove explicit values from PIPE_CAP_ enums

#define PIPE_QUIRK_TEXTURE_BORDER_COLOR_SWIZZLE_NV50 (1 << 0) Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/7] tgsi: update docs for SVIEW usage with TEX* instructions

. Reviewed-by: Jose Fonseca Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: Fail linkage when UBO exceeds GL_MAX_UNIFORM_BLOCK_SIZE.

It's not totally clear whether other Mesa drivers can safely cope with over-sized UBOs, but at least for llvmpipe receiving a UBO larger than its limit causes problems, as it won't fit into its internal display lists. This fixes piglit "arb_uniform_buffer_object-maxuniformblocksize fsexceed" witho

Re: [Mesa-dev] [PATCH] glsl: Fail linkage when UBO exceeds GL_MAX_UNIFORM_BLOCK_SIZE.

On 16/06/15 15:29, Ilia Mirkin wrote: On Tue, Jun 16, 2015 at 10:22 AM, Roland Scheidegger wrote: This looks like a good idea to me. That said, llvmpipe would still crash if the declared size in the shader wouldn't exceed the max uniform block size, but the bound buffer does IIRC (the test does

[Mesa-dev] [PATCH] llvmpipe: Truncate the binned constants to max const buffer size.

Tested with Ilia Mirkin's gzdoom.trace and "arb_uniform_buffer_object-maxuniformblocksize fsexceed" piglit test without my earlier fix to fail linkage when UBO exceeds GL_MAX_UNIFORM_BLOCK_SIZE. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 6 +- src/gallium/drivers/llvmpipe/lp_setup.c

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

On 19/06/15 04:46, Ian Romanick wrote: On 06/17/2015 10:53 PM, Julien Isorce wrote: From: Jon TURNEY On darwin, GLhandleARB is defined as a void *, not the unsigned int it is on linux. For the moment, apply a cast to supress the warning Possibly this is safe, as for the mesa software rendere

Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

I only did minor tweaks to these files, but the series LGTM. Reviewed-by: Jose Fonseca On 19/06/15 13:21, Emil Velikov wrote: Identical to the previous commit - unused by neither the Autotools, Android or SCons build. XXX: There are no more users of gl_api.filter_functions_by_api(). Should

[Mesa-dev] [PATCH 2/2] glsl: Fix counting of varyings.

When input and output varyings started to be counted separately (commit 42305fb5) the is_varying_var function wasn't updated to return true for output varyings or input varyings for stages other than the fragment shader), effectively making the varying limit to never be checked. With this change,

[Mesa-dev] [PATCH 1/2] glsl: Specify the shader stage in linker errors due to too many in/outputs.

--- src/glsl/link_varyings.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 7b2d4bd..278a778 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@ -1540,13 +1540,15 @@ check_agai

Re: [Mesa-dev] [PATCH 00/11] glapi fixes - build whole of mesa with

On 19/06/15 20:56, Emil Velikov wrote: Hi all, A lovely series inspired (more like 'was awaken to send these out') by Pal Rohár, who was having issues when building xlib-libgl (plus the now enabled gles*) So here, we teach the final two static glapi users about shared-glapi, plus some related f

Re: [Mesa-dev] [PATCH 00/11] glapi fixes - build whole of mesa with

On 19/06/15 23:09, Emil Velikov wrote: On 19 June 2015 at 21:26, Jose Fonseca wrote: On 19/06/15 20:56, Emil Velikov wrote: Hi all, A lovely series inspired (more like 'was awaken to send these out') by Pal Rohár, who was having issues when building xlib-libgl (plus the now en

Re: [Mesa-dev] Building Mesa/LLVMpipe on Windows

On 22/06/15 19:40, Florian Link wrote: Hi everyone, I spent some time building Mesa/llvmpipe on Windows and created a Python script that implements all the required steps (downloading/extracting all prerequisites and sources, configuring and building LLVM and Mesa). The script is available at:

Re: [Mesa-dev] [PATCH 00/11] glapi fixes - build whole of mesa with

On 22/06/15 19:51, Emil Velikov wrote: On 22 June 2015 at 15:01, Jose Fonseca wrote: On 19/06/15 23:09, Emil Velikov wrote: On 19 June 2015 at 21:26, Jose Fonseca wrote: On 19/06/15 20:56, Emil Velikov wrote: Hi all, A lovely series inspired (more like 'was awaken to send thes

Re: [Mesa-dev] [PATCH 2/2] glsl: Fix counting of varyings.

On 22/06/15 17:14, Ian Romanick wrote: On 06/19/2015 06:08 AM, Jose Fonseca wrote: When input and output varyings started to be counted separately (commit 42305fb5) the is_varying_var function wasn't updated to return true for output varyings or input varyings for stages other than the fra

Re: [Mesa-dev] [PATCH 2/2] glsl: Fix counting of varyings.

On 23/06/15 15:36, Jose Fonseca wrote: On 22/06/15 17:14, Ian Romanick wrote: On 06/19/2015 06:08 AM, Jose Fonseca wrote: When input and output varyings started to be counted separately (commit 42305fb5) the is_varying_var function wasn't updated to return true for output varyings or

Re: [Mesa-dev] [PATCH] st/mesa: remove unneeded pipe_surface_release() in st_render_texture()

(&strb->texture, pt); - pipe_surface_release(pipe, &strb->surface); - st_update_renderbuffer_surface(st, strb); strb->Base.Format = st_pipe_format_to_mesa_format(pt->format); Reviewed-by: Jose Fonseca ___ mesa

Re: [Mesa-dev] [PATCH] gallium/os: add os_wait_until_zero

On 26/06/15 12:05, Marek Olšák wrote: From: Marek Olšák This will be used by radeon and amdgpu winsyses. Copied from the amdgpu winsys. --- src/gallium/auxiliary/os/os_time.c | 36 +++- src/gallium/auxiliary/os/os_time.h | 10 ++ 2 files changed, 45 i

Re: [Mesa-dev] [PATCH] gallium/os: add os_wait_until_zero

As others pointed, volatile and atomic are slightly different things, but you have point: atomic operations should probably take volatile pointers as arguments. This is what C11 did http://en.cppreference.com/w/c/atomic/atomic_load so I do believe that it makes sense to update p_atomic help

Re: [Mesa-dev] [PATCH 1/5] darwin: Suppress type conversion warnings for GLhandleARB

On 25/06/15 23:18, Julien Isorce wrote: On 19 June 2015 at 10:24, Jose Fonseca mailto:jfons...@vmware.com>> wrote: On 19/06/15 04:46, Ian Romanick wrote: On 06/17/2015 10:53 PM, Julien Isorce wrote: From: Jon TURNEY mailto:jon.tur...@dronecode.

[Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

On 01/07/15 22:30, bugzilla-dae...@freedesktop.org wrote:> *Comment # 14 > on bug 91173 from > Ilia Mirkin * > > Erm... ok... > > MOV R0.zw, c[A0.x + 9]; > M

Re: [Mesa-dev] [PATCH] mesa/prog: relative offsets into constbufs are not constant

On 02/07/15 06:55, Matt Turner wrote: On Wed, Jul 1, 2015 at 3:22 PM, Ilia Mirkin wrote: The optimization logic relies on being able to read out constbuf values from program parameters. However that only works if there's no relative addressing involved. Bugzilla: https://bugs.freedesktop.org/s

Re: [Mesa-dev] [PATCH v2] darwin: Suppress type conversion warnings for GLhandleARB

On 02/07/15 13:16, Emil Velikov wrote: On 1 July 2015 at 00:33, Julien Isorce wrote: darwin: silence GLhandleARB convertions from and to GLuint This patch and its description are inspired from Jose Fonseca explanations and suggestions. With this patch the following logic applies and only if

Re: [Mesa-dev] [PATCH v2] darwin: Suppress type conversion warnings for GLhandleARB

On 01/07/15 00:33, Julien Isorce wrote: darwin: silence GLhandleARB convertions from and to GLuint This patch and its description are inspired from Jose Fonseca explanations and suggestions. With this patch the following logic applies and only if __APPLE__: When building mesa, GLhandleARB is

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

On 02/07/15 16:34, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 1:55 AM, Jose Fonseca wrote: On 01/07/15 22:30, bugzilla-dae...@freedesktop.org wrote:> *Comment # 14 <https://bugs.freedesktop.org/show_bug.cgi?id=91173#c14> on bug 91173 <https://bugs.freedesktop.org/show_bug.cgi?id

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

On 02/07/15 17:08, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca wrote: On 02/07/15 16:34, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 1:55 AM, Jose Fonseca wrote: On 01/07/15 22:30, bugzilla-dae...@freedesktop.org wrote:> *Comment # 14 <https://bugs.freedeskt

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

On 02/07/15 17:24, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca wrote: On 02/07/15 17:08, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca wrote: On 02/07/15 16:34, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 1:55 AM, Jose Fonseca wrote: On 01/07

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

On 02/07/15 17:39, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:24 PM, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca wrote: On 02/07/15 17:08, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 11:57 AM, Jose Fonseca wrote: On 02/07/15 16:34, Ilia Mirkin wrote: On Thu, Jul

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

On 02/07/15 17:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca wrote: On 02/07/15 17:24, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca wrote: Ah OK. So I guess tilers will have to disable their render queues for this one. Which seems like a

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

On 02/07/15 19:45, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 2:31 PM, Jose Fonseca wrote: On 02/07/15 17:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca wrote: On 02/07/15 17:24, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:17 PM, Jose Fonseca wrote: Ah OK. So

Re: [Mesa-dev] [PATCH] gallivm: fix lp_build_compare_ext

list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

I'm not experienced with the semantics around resources that can be read/written by shaders, so I can't really make educated comments. But overall this looks good to me FWIW. On 05/07/15 14:25, Marek Olšák wrote: From: Marek Olšák Other approaches are being considered: 1) Don't use resource

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

On 07/07/15 21:28, Ilia Mirkin wrote: On Tue, Jul 7, 2015 at 4:24 PM, Jose Fonseca wrote: I'm not experienced with the semantics around resources that can be read/written by shaders, so I can't really make educated comments. But overall this looks good to me FWIW. On 05/07/15 14

Re: [Mesa-dev] Extension to get Mesa IRs (Was: [Bug 91173])

On 12/07/15 01:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 4:54 PM, Jose Fonseca wrote: On 02/07/15 19:45, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 2:31 PM, Jose Fonseca wrote: On 02/07/15 17:49, Ilia Mirkin wrote: On Thu, Jul 2, 2015 at 12:40 PM, Jose Fonseca wrote: On 02/07/15

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

On 09/07/15 22:05, Marek Olšák wrote: I'd like to discuss one more thing that will affect whether image slots will be global (shared by all shaders) or not. Which image unit an image uniform uses is not a compile-time thing, but it's specified later using glUniform1i. That means we need a per-sh

Re: [Mesa-dev] [PATCH 01/14] egl: remove the non-haiku scons build

Reviewed-by: Jose Fonseca On 14/07/15 16:02, Emil Velikov wrote: It has been broken since 2011 with commit c98ea26e16b(egl: Make egl_dri2 and egl_glx built-in drivers.). When the backends got merged into the main library each entry point was guarded by a _EGL_BUILT_IN_DRIVER_* define. As the

[Mesa-dev] [PATCH] Match swrast modes more loosely.

From: Tom Hughes https://bugs.freedesktop.org/show_bug.cgi?id=90817 Signed-off-by: Jose Fonseca --- src/glx/dri_common.c | 59 +++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/src/glx/dri_common.c b/src/glx/dri_common.c index

Re: [Mesa-dev] [PATCH] c99_math: Implement exp2f for MSVC.

/include/c99_math.h @@ -140,6 +140,12 @@ llrintf(float f) return rounded; } +static inline float +exp2f(float f) +{ + return powf(2.0f, f); +} + #endif /* C99 */ Looks good. Thanks. Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov writes: On 14/07/15 19:45, Eric Anholt wrote: These are really useful hints to the compiler in the absence of link-time optimization, and I'm going to use them in VC4. I've made the const attribute be ATTRIBUTE_CONST unlike other function at

Re: [Mesa-dev] [PATCH 1/3] gallivm: Don't use raw_debug_ostream for dissasembling

ebug_printf("disassembly larger than %ull bytes, aborting\n", extent); break; } } - Out << "\n"; - Out.flush(); + _debug_printf("\n"); LLVMDisasmDispose(D); @@ -229,9 +229,8 @@ disassemble(const void* func, llvm::raw_ostream &

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

On 21/07/15 15:57, Emil Velikov wrote: On 18 July 2015 at 08:13, Jose Fonseca wrote: On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov writes: On 14/07/15 19:45, Eric Anholt wrote: These are really useful hints to the compiler in the absence of link-time optimization, and I'm goi

[Mesa-dev] [PATCH] gallium/util: Stop bundling our snprintf implementation.

Use MSVCRT functions instead. Their semantics are slightly different but they can be made to work as expected. Also, use the same code paths for both MSVCRT and MinGW. No testing yet. Just built. https://bugs.freedesktop.org/show_bug.cgi?id=91418 --- src/gallium/auxiliary/Makefile.sources |

Re: [Mesa-dev] [PATCH] targets/dri: scons: add missing link against libdrm

On 22/07/15 16:04, Emil Velikov wrote: Otherwise the final dri module will have (additional) unresolved symbols. Cc: Brian Paul Cc: Jose Fonseca Signed-off-by: Emil Velikov --- We can only fix the remaining unresolved symbols (_glapi_foo), as we remove the non-shared glapi when building

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

On 22/07/15 17:13, Jose Fonseca wrote: On 21/07/15 15:57, Emil Velikov wrote: On 18 July 2015 at 08:13, Jose Fonseca wrote: On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov writes: On 14/07/15 19:45, Eric Anholt wrote: These are really useful hints to the compiler in the absence of

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

On 22/07/15 21:01, Jose Fonseca wrote: On 22/07/15 17:13, Jose Fonseca wrote: On 21/07/15 15:57, Emil Velikov wrote: On 18 July 2015 at 08:13, Jose Fonseca wrote: On 18/07/15 01:38, Eric Anholt wrote: Emil Velikov writes: On 14/07/15 19:45, Eric Anholt wrote: These are really useful

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

On 22/07/15 23:32, Brian Paul wrote: Hi Marek, This is regarding your commit "st/mesa: use pipe_sampler_view_release for releasing sampler views" from last October. Basically, we have: void st_texture_release_all_sampler_views(struct st_context *st, struct

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

On 23/07/15 01:00, Brian Paul wrote: On 07/22/2015 05:31 PM, Jose Fonseca wrote: On 22/07/15 23:32, Brian Paul wrote: Hi Marek, This is regarding your commit "st/mesa: use pipe_sampler_view_release for releasing sampler views" from last October. Basically, we h

Re: [Mesa-dev] Using the right context in st_texture_release_all_sampler_views()

On 23/07/15 01:08, Jose Fonseca wrote: On 23/07/15 01:00, Brian Paul wrote: On 07/22/2015 05:31 PM, Jose Fonseca wrote: On 22/07/15 23:32, Brian Paul wrote: Hi Marek, This is regarding your commit "st/mesa: use pipe_sampler_view_release for releasing sampler views" from la

Re: [Mesa-dev] [PATCH 1/3] gallivm: Don't use raw_debug_ostream for dissasembling

On 20/07/15 21:39, Jose Fonseca wrote: On 20/07/15 18:35, Tom Stellard wrote: All LLVM API calls that require an ostream object have been removed from the disassemble() function, so we don't need to use this class to wrap _debug_printf() we can just call this function directly. ---

Re: [Mesa-dev] [PATCH] Match swrast modes more loosely.

X visuals will match -- the problem is SW rendering with X servers running something else.) Jose On 23/07/15 20:54, Marek Olšák wrote: Hi Jose, FYI, I had to revert this, because it broke glxgears on radeonsi. Marek On Wed, Jul 15, 2015 at 3:25 PM, Jose Fonseca wrote: From: Tom

Re: [Mesa-dev] [PATCH 02/10] gallivm: implement the correct version of LRP

Roland was on PTO. IMO, the change makes sense from a numeric accuracy POV. I fear this might cause some slowdown with llvmpipe (two muls intead of one), but hopefully it won't be significant. The accuracy issue could cause glitches to llvmpipe too. Jose On 15/10/15 15:44, Marek Olšák wrot

Re: [Mesa-dev] [PATCH 02/10] gallivm: implement the correct version of LRP

On 15/10/15 16:20, Roland Scheidegger wrote: Am 15.10.2015 um 16:44 schrieb Marek Olšák: Any comment or is this okay with people? Given, "(1-t)*a + t*b", the original code didn't return b for t=1 because it's "floating-point". Marek On Sun, Oct 11, 2015 at 3:29 AM, Marek Olšák wrote: From: M

Re: [Mesa-dev] [PATCH 2/2] mesa: fix incorrect opcode in save_BlendFunci()

, OPCODE_BLEND_FUNC_SEPARATE_I, 3); + n = alloc_instruction(ctx, OPCODE_BLEND_FUNC_I, 3); if (n) { n[1].ui = buf; n[2].e = sfactor; Series is Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/4] st/mesa: check of out-of-memory in st_DrawPixels()

On 15/10/15 20:01, Brian Paul wrote: Before, if make_texture() or st_create_texture_sampler_view() failed we silently no-op'd the glDrawPixels. Now, set GL_OUT_OF_MEMORY. This also allows us to un-nest a bunch of code. --- src/mesa/state_tracker/st_cb_drawpixels.c | 74 +---

Re: [Mesa-dev] [PATCH 4/4] st/mesa: optimize 4-component ubyte glDrawPixels

On 15/10/15 20:01, Brian Paul wrote: If we didn't find a gallium surface format that exactly matched the glDrawPixels format/type combination, we used some other 32-bit packed RGBA format and swizzled the whole image in the mesa texstore/format code. That slow path can be avoided in some common

Re: [Mesa-dev] [PATCH] st/mesa: check for out-of-memory in st_DrawPixels()

driver_fp, fpv, + color, GL_FALSE, write_depth, write_stencil); + pipe_sampler_view_reference(&sv[0], NULL); + if (num_sampler_view > 1) + pipe_sampler_view_reference(&sv[1], NULL); + + pipe_resource_reference(&pt, NULL); } Looks good. Patch 1-3 o

Re: [Mesa-dev] [PATCH] st/mesa: optimize 4-component ubyte glDrawPixels

h the array of 4 swizzle components for the named component and return + * its position. + */ +static int Return type and `i` should be unsigned to avoid sign conversion. Otherwise looks great. Reviewed by: Jose Fonseca +search_swizzle(const unsigned char swizzle[4], unsigned component) +{ +

Re: [Mesa-dev] [PATCH 10/10] vbo: convert display list GL_LINE_LOOP prims to GL_LINE_STRIP

;used > VBO_SAVE_PRIM_SIZE - 6) { save->prim_store->refcount--; Nice catch. I'm not very familiar with this code, but FWIW, other than the issues I mentioned separately, the series looks good to me. Reviewed-by: Jose Fonseca Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] scons: Build nir/glsl_types.cpp once.

Undoes early hacks, and ensures nir/glsl_types.cpp is built once, and only once. The root problem is that SCons doesn't know about NIR nor any source file in the NIR_FILES source list. Tested with libgl-gdi and libgl-xlib scons targets. --- src/gallium/targets/libgl-gdi/SConscript | 10

Re: [Mesa-dev] MSVC, MinGW build break

On 17/10/15 17:44, Rob Clark wrote: On Sat, Oct 17, 2015 at 12:36 PM, Brian Paul wrote: On 10/17/2015 10:07 AM, Brian Paul wrote: On 10/17/2015 07:04 AM, Rob Clark wrote: On Fri, Oct 16, 2015 at 11:11 PM, Brian Paul wrote: Hi Rob, Your recent commit "nir: remove dependency on glsl" brok

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

On 20/10/15 18:11, Rowley, Timothy O wrote: Hi. I'd like to introduce the Mesa3D community to a software project that we hope to upstream. We're a small team at Intel working on software defined visualization (http://sdvis.org/), and have opensource projects in both the raytracing (Embree, OSPR

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

On 20/10/15 23:16, Rowley, Timothy O wrote: On Oct 20, 2015, at 4:23 PM, Jose Fonseca wrote: I tried it on my i7-5500U, but I run into two issues: - OpenSWR seems to only use 2 threads (even though my system support 4 threads) - and even when I compensate llvmpipe to only use 2 rasterizer

[Mesa-dev] [PATCH] gallivm: Translate all util_cpu_caps bits to LLVM attributes.

This should prevent disparity between features Mesa and LLVM believe are supported by the CPU. http://lists.freedesktop.org/archives/mesa-dev/2015-October/thread.html#96990 Tested on a i7-3720QM w/ LLVM 3.3 and 3.6. --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 34 +

Re: [Mesa-dev] [PATCH] gallivm: Translate all util_cpu_caps bits to LLVM attributes.

On 21/10/15 17:35, Gustaw Smolarczyk wrote: I am just a bystander, but I have one suggestion to this patch. 2015-10-21 18:25 GMT+02:00 Jose Fonseca : This should prevent disparity between features Mesa and LLVM believe are supported by the CPU. http://lists.freedesktop.org/archives/mesa-dev

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

On 22/10/15 00:43, Rowley, Timothy O wrote: On Oct 20, 2015, at 5:58 PM, Jose Fonseca wrote: Thanks for the explanations. It's closer now, but still a bit of gap: $ KNOB_MAX_THREADS_PER_CORE=0 ./gloss SWR create screen! This processor supports AVX2. --> numThreads = 3 1102 frames

[Mesa-dev] [PATCH] gallivm: Explicitly disable unsupported CPU features.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92214 --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 69 --- 1 file changed, 31 insertions(+), 38 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_mis

Re: [Mesa-dev] [PATCH 4/4] gallivm: fix tex offsets with mirror repeat linear

Reviewed-by: Jose Fonseca ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallivm: disable f16c when not using AVX

= 0; util_cpu_caps.has_avx2 = 0; + util_cpu_caps.has_f16c = 0; } #ifdef PIPE_ARCH_PPC_64 Reviewed-by: Jose Fonseca Jose ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallivm: disable f16c when not using AVX

On 26/10/15 14:58, Roland Scheidegger wrote: Am 26.10.2015 um 10:02 schrieb Jose Fonseca: On 23/10/15 22:26, srol...@vmware.com wrote: From: Roland Scheidegger f16c intrinsic can only be emitted when AVX is used. So when we disable AVX due to forcing 128bit vectors we must not use this

Re: [Mesa-dev] MSVC (2015) builds

On 03/11/15 15:48, Brian Paul wrote: On 11/02/2015 08:42 PM, Janusz Ganczarski wrote: Hello, In attachment fixed Visual C++ 2015 (VC 14) builds for Mesa. Currently only gallium softpipe driver support. Gallium llvmpipe driver support work in progress. I'm not sure we're interested in MSVC proj

[Mesa-dev] [PATCH] st/mesa: Destroy buffer object's mutex.

Ideally we should have a _mesa_cleanup_buffer_object function in src/mesa/bufferobj.c so that the destruction logic resided in a single place. --- src/mesa/state_tracker/st_cb_bufferobjects.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c b/src/me

Re: [Mesa-dev] [PATCH] RFC: llvmpipe map scene buffers outside thread.

On 09/11/15 03:58, Dave Airlie wrote: From: Dave Airlie There might be a reason we do this inside the thread, but I'm not aware of it yet, move stuff around and see if this jogs anyone's memory. It might be a relic from the time where we had swizzled tiles. Jose Doing this outside the thr

Re: [Mesa-dev] [PATCH] egl: Pass the correct X visual depth to xcb_put_image().

It looks like nobody really cares, so I'll take it as consent. This only happens if X requires 24bit visuals. Maybe a minority of drivers do that. At least Intel X driver does. BTW, this should go to stable branches too. Jose On 19/01/15 23:09, Jose Fonseca wrote: From: José Fonseca

Re: [Mesa-dev] [PATCH] gallium/docs: fix docs wrt ARL/ARR/FLR

On 29/01/15 19:40, srol...@vmware.com wrote: From: Roland Scheidegger since the address reg holds integer values, ARL/ARR do an implicit float-to-int conversion, so clarify that. Thus it is also incorrect to say that FLR really does the same as ARL. --- src/gallium/docs/source/tgsi.rst | 18 +

Re: [Mesa-dev] [PATCH] mesa: fix display list 8-byte alignment issue

Looks good to me. Just one minor suggestion: if we replaced sizeof(void *) == 8 with sizeof(void *) > sizeof(GLuint) we would avoid the magic number 8 and make the code correct for any pointer size. Jose On 28/01/15 03:06, Brian Paul wrote: The _mesa_dlist_alloc() function is only

Re: [Mesa-dev] [PATCH] mesa: Add new fast mtx_t mutex type for basic use cases

On 29/01/15 17:14, Kristian Høgsberg wrote: On Thu, Jan 29, 2015 at 6:36 AM, Emil Velikov wrote: On 28/01/15 05:08, Kristian Høgsberg wrote: While modern pthread mutexes are very fast, they still incur a call to an external DSO and overhead of the generality and features of pthread mutexes. Mo

Re: [Mesa-dev] killing off the address reg in tgsi

On 29/01/15 21:20, Roland Scheidegger wrote: Hi, the address reg in tgsi is quite a nuisance. glsl-to-tgsi code assumes that indirections can only be done through the address reg and has quite some extra code to deal with this. Even though hardware and apis which worked like that are definitely

Re: [Mesa-dev] Fixes to build Mesa 10.4 against LLVM 3.5 on windows

On 16/12/14 20:08, Rob Conde wrote: I built Mesa 10.4 with LLVM 3.5 today and I had to make a couple of fixes to get it to work: 1. root\src\mesa\compiler.h After: #include "c99_compat.h" /* inline, __func__, etc. */ Add: #ifdef _MSC_VER #define __attribute__(a) #en

[Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

This change broke MinGW/MSVC builds because ffsll is not available there. There is a ffsll C fallback, but it's in src/mesa/main/imports.[ch]. So rather than duplicating it in src/gallium/auxiliary/util/u_math.h I'd prefer move it to src/util. And here lies the problem: what header name sh

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

On 04/02/15 20:18, Kenneth Graunke wrote: On Wednesday, February 04, 2015 02:04:38 PM Jose Fonseca wrote: This change broke MinGW/MSVC builds because ffsll is not available there. There is a ffsll C fallback, but it's in src/mesa/main/imports.[ch]. So rather than duplicating it i

[Mesa-dev] [PATCH] llvmpipe: Trivially advertise PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT.

Nothing special needs to be done. Even though llvmpipe copies constant (ie uniform) buffers internally, the application is suppose to flush and sync, so all should work. All bufferstorage piglit tests pass. --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH] llvmpipe: Trivially advertise PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT.

On 05/02/15 15:07, Roland Scheidegger wrote: Am 05.02.2015 um 15:33 schrieb Jose Fonseca: Nothing special needs to be done. Even though llvmpipe copies constant (ie uniform) buffers internally, the application is suppose to flush and sync, so all should work. All bufferstorage piglit tests

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

On 07/02/15 00:10, Matt Turner wrote: On Fri, Feb 6, 2015 at 3:58 PM, Emil Velikov wrote: "util" is meant to be for shared utility across the entire code base - both Mesa and Gallium. It's been growing slowly as people move things there. It might make sense to move a lot of src/gallium/auxili

Re: [Mesa-dev] mesa-10.4.4: BROKEN TLS support in GLX with llvm-toolchain v3.6.0rc2

I think we decided not to support unreleased LLVM builds on stable releases. This is because building without errors is not enough -- there are often other changes that need to go with this. Furthermore it's often a moving target. In short, if you want to use bleeding edge LLVM, you must use

Re: [Mesa-dev] Rename mesa/src/util (Was: gallium/util: add u_bit_scan64)

restrictied to more incremental solutions. That is, add a new header to src/util with an unique name, and cherry-pick bits and pieces from u_math.[ch] as deemed necessary/practical. Jose From: Marek Olšák Sent: 08 February 2015 11:27 To: Jose Fon

Re: [Mesa-dev] [PATCH] util/u_atomic: Add new macro p_atomic_add

On 06/02/15 22:39, Carl Worth wrote: On Fri, Feb 06 2015, Aaron Watry wrote: Ignore me if this is a stupid question, but should those both be sizeof(short)? I'd expect the first to be sizeof(char). Not a stupid question. That was a copy-and-paste (kill-and-yank ?) bug of mine. Thanks for you

Re: [Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

On 09/02/15 16:59, Jon TURNEY wrote: On 06/02/2015 19:58, Matt Turner wrote: On Fri, Feb 6, 2015 at 3:38 AM, Jonathan Gray wrote: OpenBSD has ffs in libc but does not have ffsll so use the compiler builtin. PIPE_OS_BSD isn't suitable here as FreeBSD has ffsll in libc. Signed-off-by: Jonathan

Re: [Mesa-dev] mesa-10.4.4: BROKEN TLS support in GLX with llvm-toolchain v3.6.0rc2

On 09/02/15 17:44, Emil Velikov wrote: Hi Sedat, On 07/02/15 22:42, Sedat Dilek wrote: [ Please CC me I am not subscribed to mesa-dev and llvmdev MLs ] Hi, I already reported this when playing 1st time with my llvm-toolchain v3.6.0rc2 and mesa v10.3.7 [1]. The issue still remains in mesa v10.

Re: [Mesa-dev] mesa-10.4.4: BROKEN TLS support in GLX with llvm-toolchain v3.6.0rc2

On 09/02/15 23:25, Sedat Dilek wrote: On Mon, Feb 9, 2015 at 9:51 PM, Jose Fonseca wrote: On 09/02/15 17:44, Emil Velikov wrote: Hi Sedat, On 07/02/15 22:42, Sedat Dilek wrote: [ Please CC me I am not subscribed to mesa-dev and llvmdev MLs ] Hi, I already reported this when playing 1st

[Mesa-dev] [PATCH 1/2] util/u_atomic: Test p_atomic_add() for 8bit integers.

--- src/util/u_atomic_test.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/src/util/u_atomic_test.c b/src/util/u_atomic_test.c index c506275..8bddf8d 100644 --- a/src/util/u_atomic_test.c +++ b/src/util/u_atomic_test.c @@ -37,8 +37,9 @@ #in

[Mesa-dev] [PATCH 2/2] util/u_atomic: Add _InterlockedExchangeAdd8/16 for older MSVC.

We need to build certain parts of Mesa (namely gallium, llvmpipe, and therefore util) with Windows SDK 7.0.7600, which includes MSVC 2008. --- src/util/u_atomic.h | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/src/util/u_atomic.h b/src/util/u_

Re: [Mesa-dev] [PATCH 2/2] util/u_atomic: Add _InterlockedExchangeAdd8/16 for older MSVC.

On 12/02/15 17:03, Brian Paul wrote: On 02/12/2015 09:27 AM, Jose Fonseca wrote: We need to build certain parts of Mesa (namely gallium, llvmpipe, and therefore util) with Windows SDK 7.0.7600, which includes MSVC 2008. --- src/util/u_atomic.h | 32 ++-- 1 file

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

Thanks for doing this. I appreciate it. I have no objection with the series. I'm happy to see more reuse. We can always move things around later, and it will be much easier when then are less entangled/duplicated. We'll need to update SCons include paths too. If you have a git repos with

Re: [Mesa-dev] [PATCH 1/2] gallium: include util/macros.h

LGTM. On 12/02/15 17:31, Tobias Klausmann wrote: The most common macros are defined there, no use to duplicate these Clean up the already redefinded macros Signed-off-by: Tobias Klausmann --- src/gallium/include/pipe/p_compiler.h | 57 ++- 1 file changed, 2 i

[Mesa-dev] [PATCH] uti/u_atomic: Don't test p_atomic_add with booleans.

Add another class of tests. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=89112 I failed to spot this in my previous change, because bool was a typedef for char on the system I tested. --- src/util/u_atomic_test.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions

[Mesa-dev] [PATCH] os, llvmpipe: Set rasterizer thread names on Linux.

To help identify llvmpipe rasterizer threads -- especially when there can be so many. We can eventually generalize this to other OSes, but for that we must restrict the function to be called from the current thread. See also http://stackoverflow.com/a/7989973 --- src/gallium/auxiliary/os/os_thre

Re: [Mesa-dev] [PATCH] os, llvmpipe: Set rasterizer thread names on Linux.

On 13/02/15 15:23, Roland Scheidegger wrote: Just one trivial issue, otherwise Reviewed-by: Roland Scheidegger Am 13.02.2015 um 15:05 schrieb Jose Fonseca: To help identify llvmpipe rasterizer threads -- especially when there can be so many. We can eventually generalize this to other OSes

Re: [Mesa-dev] make check failure in u_atomic_test

On 13/02/15 18:52, Ian Romanick wrote: Starting this morning I'm seeing 'make check' failures in u_atomic_test. It looks like José was the last person to touch that area. I haven't investigated any further. ../../bin/test-driver: line 107: 11024 Aborted (core dumped) "$@" > $l

  1   2   3   4   5   6   7   8   9   10   >