Re: [Mesa-dev] [PATCH 5/5] osx: fix asm support on darwin

2015-06-27 Thread Jon TURNEY
On 19/06/2015 00:36, Julien Isorce wrote: On 18 June 2015 at 19:46, Emil Velikov wrote: On 18 June 2015 at 06:53, Julien Isorce wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90908 I don't think it's necessary to create a bugzilla entry just to link to it in your patch. A

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-06-27 Thread Jon TURNEY
On 19/06/2015 12:51, Emil Velikov wrote: On 19 June 2015 at 00:05, Julien Isorce wrote: Sorry for removing the XXX line. Original message is here: https://bugs.freedesktop.org/attachment.cgi?id=115539 At the time src/glx/apple/apple_glapi.c has been developed this patch was not needed I guess

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-07-02 Thread Jon TURNEY
On 02/07/2015 13:42, Emil Velikov wrote: On 27 June 2015 at 12:21, Jon TURNEY wrote: This smells to me like there's something not quite right about the partitioning of stuff between libmesa and libglapi, but I don't have any insight into what exactly the problem is. Quite likely. A

Re: [Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

2015-02-09 Thread Jon TURNEY
case, HAVE___BUILTIN_FFSLL). Yes, please. This has just been 'fixed' for MinGW, now for OpenBSD, and also needs fixing for Cygwin. Attached is a patch which attempts to do this using autoconf checks. From 580eb16295a94012c488db7ac44d09cb3ca8ff55 Mon Sep 17 00:00:00 2001 From: Jon TURNEY Date: Sat, 7

Re: [Mesa-dev] [PATCH v2] auxiliary/vl: bring back the VL code for the dri targets

2015-02-14 Thread Jon TURNEY
s something like the attached is needed. [1] http://tinderbox.x.org/builds/2015-02-13-0007/logs/mesa-mesa/#build From 19c254ca57cad4b67466e6bbfb76a1460ea0821d Mon Sep 17 00:00:00 2001 From: Jon TURNEY Date: Sat, 14 Feb 2015 17:12:41 + Subject: [PATCH] auxiliary/vl: Only build vl_winsys_dri.c

Re: [Mesa-dev] [PATCH] auxiliary/vl: Build vl_winsys_dri.c only when needed.

2015-02-17 Thread Jon TURNEY
;10.5" Cc: Jon TURNEY Reported-by: Jon TURNEY Signed-off-by: Emil Velikov --- Hi Jon, Can you give this patch a try. I realise it's longer solution than the one you sent, but imho this makes sense (in a way) considering all the craziness that we have around. Works for me. Reviewed

Re: [Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

2015-02-26 Thread Jon TURNEY
llium/util: use ffs* builtins if available Required to build on OpenBSD which doesn't have ffsll in libc. Thanks. This works for me also. Reviewed-by: Jon TURNEY ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.o

Re: [Mesa-dev] [PATCH] c99_alloca.h: Include stdlib.h on all non-Windows.

2015-03-05 Thread Jon TURNEY
/* !defined(_MSC_VER) */ Solaris defines alloca() in , not Same on Cygwin. http://tinderbox.x.org/builds/2015-03-05-0008/logs/mesa-mesa/#build From 699e450a2f5b39a68bf239a41e99ecc8240ceed7 Mon Sep 17 00:00:00 2001 From: Jon TURNEY Date: Thu, 5 Mar 2015 15:29:32 + Subject: [PATCH] Also use for

Re: [Mesa-dev] [PATCH] glx/windows: Add wgl.h to the sources list

2016-11-02 Thread Jon Turney
On 02/11/2016 11:13, Andreas Boll wrote: Otherwise it won't be picked in the tarball and the build will fail. Thanks, my bad. Reviewed-by: Jon Turney Fixes: 533b3530c12 ("direct-to-native-GL for GLX clients on Cygwin ("Windows-DRI")") Cc: "13.0" Signed

Re: [Mesa-dev] [PATCH 2/6] ddebug: record and dump apitrace call numbers

2016-07-05 Thread Jon Turney
aration] s = alloca(len + 1); Perhaps the attached is needed? From 5f606bff8e5ed92a42956c10ee6b2b77360feaf5 Mon Sep 17 00:00:00 2001 From: Jon Turney Date: Tue, 5 Jul 2016 10:40:05 +0100 Subject: [PATCH] Add alloca.h include to fix compilation on Cygwin Fix compilation on Cygwin, si

Re: [Mesa-dev] [PATCH 2/6] ddebug: record and dump apitrace call numbers

2016-07-13 Thread Jon Turney
On 05/07/2016 11:17, Marek Olšák wrote: On Tue, Jul 5, 2016 at 12:13 PM, Jon Turney wrote: On 01/07/2016 00:21, Marek Olšák wrote: [...] This adds a use of alloca(), without a corresponding #include This fails to build, for me: In file included from dd_pipe.h:34:0, from

[Mesa-dev] [PATCH] direct-to-native-GL for GLX clients on Cygwin ("Windows-DRI")

2016-07-18 Thread Jon Turney
The server is queried for a native handle for the drawable (which is of a different type for windows, pixmaps and pbuffers), which is used to augment __GLXDRIdrawable. Various GLX extensions are enabled depending on if the equivalent WGL extension is available. Signed-off-by: Jon Turney --- configu

[Mesa-dev] [PATCH 0/3] translate, rtasm fixes for 64-bit Cygwin

2013-10-10 Thread Jon TURNEY
ws, and then commit f4dd0991719ef3e2606920c5100b372181c60899 disabled tranlate_sse.c on MinGW x86_64 because of crashes.) Jon TURNEY (3): rtasm: The heap is NX on 64-bit Cygwin, so use the rtasm_exec_malloc() implementation which uses mmap() rtasm: Cygwin uses the msabi calling convention on x86_64 traslate_sse

[Mesa-dev] [PATCH 1/3] rtasm: The heap is NX on 64-bit Cygwin, so use the rtasm_exec_malloc() implementation which uses mmap()

2013-10-10 Thread Jon TURNEY
The heap is NX on 64-bit Cygwin, so use the rtasm_exec_malloc() implementation which uses mmap() to allocate an anonymous page with execute permission, rather than the one which just uses malloc(). Signed-off-by: Jon TURNEY --- src/gallium/auxiliary/rtasm/rtasm_execmem.c | 2 +- 1 file changed

[Mesa-dev] [PATCH 2/3] rtasm: Cygwin uses the msabi calling convention on x86_64

2013-10-10 Thread Jon TURNEY
Cygwin also uses the msabi calling convention on x86_64, not the sysvabi calling convention Signed-off-by: Jon TURNEY --- src/gallium/auxiliary/rtasm/rtasm_x86sse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/rtasm/rtasm_x86sse.h b/src/gallium

[Mesa-dev] [PATCH 3/3] traslate_sse: Fix generated code argument handling for msabi on x86_64

2013-10-10 Thread Jon TURNEY
quantities to avoid truncation. Commit f4dd0991719ef3e2606920c5100b372181c60899 disabled tranlate_sse.c on MinGW x86_64, I don't know if was due to this issue, or a different one... Signed-off-by: Jon TURNEY --- src/gallium/auxiliary/translate/translate_sse.c | 14 +++--- 1 file ch

Re: [Mesa-dev] [PATCH] tests: Fix make check for out of tree builds.

2013-11-19 Thread Jon TURNEY
st > > Thanks! Reviewed-by and committed. It seems that 'make check' for unshared glapi needs a similar fix. Patch attached. >From 76130730ad77db1225190d1afa0ec2a07a055d58 Mon Sep 17 00:00:00 2001 From: Jon TURNEY Date: Fri, 8 Nov 2013 13:22:54 + Subject: [PATCH 2/4]

Re: [Mesa-dev] [PATCH] configure.ac: Do not use Pthreads with MinGW.

2014-06-04 Thread Jon TURNEY
On 04/06/2014 01:06, Vinson Lee wrote: Match the behavior of the SCons MinGW build. This patch also fixes these build errors. CC glapi_entrypoint.lo glapi_entrypoint.c: In function 'init_glapi_relocs_once': glapi_entrypoint.c:341:4: error: unknown type name 'pthread_once_t' static

Re: [Mesa-dev] [PATCH 0/2] Build a driswrast-using libGL on non-DRM targets

2014-06-04 Thread Jon TURNEY
On 03/06/2014 17:37, Emil Velikov wrote: On 03/06/14 14:14, Jon TURNEY wrote: As a follow-up to my "Fix Apple-DRI GLX" patchset, allow building of a libGL capable of using driswrast on targets without libdrm, and make that the default configuration. The --disable-driglx-direct o

[Mesa-dev] [PATCH] glx: Add an error message when a direct renderer's createScreen() routine fails because no matching fbConfigs or visuals could be found.

2014-06-10 Thread Jon TURNEY
which reports definite values for MAX_PBUFFFER_(WIDTH|HEIGHT|SIZE), because those attributes are checked for an exact match against 0.) Signed-off-by: Jon TURNEY --- src/glx/dri2_glx.c | 4 +++- src/glx/dri3_glx.c | 4 +++- src/glx/dri_glx.c | 4 +++- src/glx/drisw_glx.c | 4 +++- 4 files change

[Mesa-dev] [PATCH] configure: Don't special case Cygwin to use gnu99, define _XOPEN_SOURCE instead

2014-06-10 Thread Jon TURNEY
e strdup() when _XOPEN_SOURCE is defined appropriately, so this workaround is no longer needed. Signed-off-by: Jon TURNEY Cc: Vinson Lee --- configure.ac | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 1525b20..802b05a 100644 ---

[Mesa-dev] [PATCH] Avoid mesa_dri_drivers import lib being installed

2014-07-11 Thread Jon TURNEY
, which already does things this way) Signed-off-by: Jon TURNEY --- src/mesa/drivers/dri/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/Makefile.am b/src/mesa/drivers/dri/Makefile.am index 37136b9..1a93645 100644 --- a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 0/2] Teach some platform checks about Cygwin

2014-07-24 Thread Jon TURNEY
A couple of small fixes to teach platform checks about Cygwin's characteristics Ideally, these would be autoconf checks, and we wouldn't have to do anything here, but it seems that ship has long sailed. Yaakov Selkowitz (2): xmlconfig: Use program_invocation_short_name when building for cygwin

[Mesa-dev] [PATCH 1/2] xmlconfig: Use program_invocation_short_name when building for cygwin

2014-07-24 Thread Jon TURNEY
igned-off-by: Yaakov Selkowitz Reviewed-by: Jon TURNEY --- src/mesa/drivers/dri/common/xmlconfig.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/common/xmlconfig.c b/src/mesa/drivers/dri/common/xmlconfig.c index 58d0e06..ce37647 100644 --- a/src/mesa/drivers/dri/common/xmlc

[Mesa-dev] [PATCH 2/2] os_process.c: Add cygwin as an expected platform

2014-07-24 Thread Jon TURNEY
[-Wcpp] #warning unexpected platform in os_process.c Signed-off-by: Yaakov Selkowitz Reviewed-by: Jon TURNEY --- src/gallium/auxiliary/os/os_process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/os/os_process.c b/src/gallium/auxiliary/os

Re: [Mesa-dev] [PATCH 4/6] gallium: Add a dumb drm/kms winsys backed swrast provider

2014-07-31 Thread Jon TURNEY
rbox.x.org/builds/2014-07-31-0006/logs/mesa-mesa/#build From fd1aaf61a9e4c50db26fc89d608c8ec164cadbcc Mon Sep 17 00:00:00 2001 From: Jon TURNEY Date: Thu, 31 Jul 2014 16:30:37 +0100 Subject: [PATCH] Fix build since 3b176c441b7ddc5f7d2f891da3f76cf3c1814ce1 for dri_platform=none hosts Signed-off-by:

Re: [Mesa-dev] [PATCH] glx: Verify that drawable creation on the client side actually worked

2013-02-27 Thread Jon TURNEY
eight, config->rgbBits); > > - CreateDRIDrawable(dpy, config, pixmap, id, attrib_list, i); > + if (!CreateDRIDrawable(dpy, config, pixmap, id, attrib_list, i)) { > + CARD32 o = glx_1_3 ? X_GLXDestroyPbuffer : > X_GLXvop_DestroyGLXPbufferSGIX; > + XFreePixmap(dpy, pixmap); > +

[Mesa-dev] [PATCH 0/3] Fixes for glapi/test/check_table test

2013-02-27 Thread Jon TURNEY
tands, as it's checking for a #define which is never made. [1] http://tinderbox.freedesktop.org/builds/2013-02-27-0010/logs/libGL/#check Jon TURNEY (3): Fix out-of-tree build of 'make check' in src/mapi/glapi/tests/ Fix glapi/tests/check_table.cpp for standardized OpenGL function

[Mesa-dev] [PATCH 1/3] Fix out-of-tree build of 'make check' in src/mapi/glapi/tests/

2013-02-27 Thread Jon TURNEY
Signed-off-by: Jon TURNEY --- src/mapi/glapi/tests/Makefile.am |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mapi/glapi/tests/Makefile.am b/src/mapi/glapi/tests/Makefile.am index a23eef2..3553b99 100644 --- a/src/mapi/glapi/tests/Makefile.am +++ b/src/mapi

[Mesa-dev] [PATCH 2/3] Fix glapi/tests/check_table.cpp for standardized OpenGL function names

2013-02-27 Thread Jon TURNEY
It looks like this has been broken since commit 1a1db1746db82efc7f0643508886dfc78a15eb71 "Standardize names of OpenGL functions." Signed-off-by: Jon TURNEY --- src/mapi/glapi/tests/check_table.cpp | 528 +- 1 files changed, 264 insertions(+), 264

[Mesa-dev] [PATCH 3/3] Properly check GLX_INDIRECT_RENDERING in glapi/tests/check_table

2013-02-27 Thread Jon TURNEY
Actually use $DEFINES, so we can see if GLX_INDIRECT_RENDERING is defined If GLX_INDIRECT_RENDERING is defined, _GLAPI_SKIP_PROTO_ENTRY_POINTS will be defined, and libglapi won't contain the 'protocol entry points', so we should provide stubs in check_table.cpp Signed-off

[Mesa-dev] [PATCH] Fix out-of-tree build of 'make check' in src/mesa/main/tests

2013-03-01 Thread Jon TURNEY
Signed-off-by: Jon TURNEY --- src/mesa/main/tests/Makefile.am |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/tests/Makefile.am b/src/mesa/main/tests/Makefile.am index 012b353..4acc815 100644 --- a/src/mesa/main/tests/Makefile.am +++ b/src/mesa/main

Re: [Mesa-dev] Mesa (master): Don't bother making compatibilty symlinks

2013-03-12 Thread Jon TURNEY
On 12/03/2013 03:12, Stéphane Marchesin wrote: > It looks like this commit (and the other ones in the series) aren't > present in the mesa git tree. It also looks like the last commit was > pushed twice, and is present with the hash from the second time. Last week, I pushed a bunch of wrong commit

[Mesa-dev] [PATCH] Fix build when configured --with-gallium-drivers=swrast --disable-driglx-direct on platforms which don't have LIBDRM

2013-12-01 Thread Jon TURNEY
which can load just swrast, since there is no functional dependency, but work is needed to untangle the build dependency. Signed-off-by: Jon TURNEY --- src/glx/dri2_query_renderer.c| 5 + src/glx/tests/query_renderer_implementation_unittest.cpp | 4 2 files

Re: [Mesa-dev] [PATCH mesa/mesa] Hardcode the DRI driver extension as .so to match it's current uses.

2014-04-07 Thread Jon TURNEY
On 06/04/2014 17:45, Emil Velikov wrote: > Sorry about this breakage. I assumed that the library extensions are handled > consistently across mesa. Seems like I was wrong. > > Guessing that you meant to send this to the mesa-dev ? Yes, sorry about that. > On 06/04/14 15:59, J

Re: [Mesa-dev] [PATCH mesa/mesa] Check for dladdr(), rather than assuming we have it if we have RTLD_DEFAULT

2014-04-17 Thread Jon TURNEY
On 09/04/2014 14:53, Jonathan Gray wrote: > On Sun, Apr 06, 2014 at 03:30:43PM +0100, Jon TURNEY wrote: >> Unfortunately, Cygwin defines RTLD_DEFAULT (for glibc compatibility), but >> can't >> provide dladdr(), so add a check for dladdr()

[Mesa-dev] [PATCH 1/3] Fix build for darwin

2014-05-13 Thread Jon TURNEY
default to -with-dri-drivers=swrast Signed-off-by: Jon TURNEY --- configure.ac | 36 src/egl/main/Makefile.am | 2 +- src/gallium/Automake.inc | 8 src/glx/Makefile.am | 2 +- src/mesa/drivers/dri/M

[Mesa-dev] [PATCH 0/3] Fix Apple-DRI GLX

2014-05-13 Thread Jon TURNEY
clature in [2/3] isn't very satisfactory, but I couldn't come up with anything better. Jon TURNEY (3): Fix build for darwin Make DRI dependencies and build depend on the target Fix build of appleglx configure.ac | 96 +

[Mesa-dev] [PATCH 2/3] Make DRI dependencies and build depend on the target

2014-05-13 Thread Jon TURNEY
e cases where a more detailled decision is made at a lower level. HAVE_APPLEDRI enables building of an Apple-specific direct rendering interface, still which requires additional fixing up to build properly. Signed-off-by: Jon TURNEY --- configure.ac

[Mesa-dev] [PATCH 3/3] Fix build of appleglx

2014-05-13 Thread Jon TURNEY
kes things more complex than they need to be. More untangling is needed to allow that Signed-off-by: Jon TURNEY --- configure.ac | 5 ++ src/glx/Makefile.am| 11 ++- src/glx/apple/Makefile | 131 ---

Re: [Mesa-dev] [PATCH 3/3] Fix build of appleglx

2014-05-20 Thread Jon TURNEY
On 20/05/2014 09:57, Jeremy Huddleston Sequoia wrote: Reviewed-by: Jeremy Huddleston Sequoia with one minor change (see below): Thanks very much for taking the time to review these. On May 13, 2014, at 05:15, Jon TURNEY wrote: +SUBDIRS+=. tests + include $(top_srcdir)/install-lib-links.mk

[Mesa-dev] [PATCH 0/3] Fix Apple-DRI GLX (v2)

2014-05-21 Thread Jon TURNEY
t a 'make check' test which requires DRI2 under HAVE_DRI2 Fix the new apple/Makefile.am for srcdir != builddir Jon TURNEY (3): Fix build for darwin Make DRI dependencies and build depend on the target Fix build of appleglx configure.ac | 106 +++

[Mesa-dev] [PATCH 3/3] Fix build of appleglx

2014-05-21 Thread Jon TURNEY
kes things more complex than they need to be. More untangling is needed to allow that v2: Correct apple/Makefile.am for srcdir != builddir Signed-off-by: Jon TURNEY Reviewed-by: Jeremy Huddleston Sequoia --- configure.ac | 5 ++ src/glx/Makefile.am

[Mesa-dev] [PATCH 1/3] Fix build for darwin

2014-05-21 Thread Jon TURNEY
default to -with-dri-drivers=swrast v2: Use -Wl,-Bsymbolic, as before, not -Bsymbolic Test that ld --version-script works, rather than just looking for it in ld --help Don't use -Wl,--no-undefined on darwin, either Signed-off-by: Jon TURNEY Reviewed-by: Jeremy Huddleston Sequoia --

[Mesa-dev] [PATCH 2/3] Make DRI dependencies and build depend on the target

2014-05-21 Thread Jon TURNEY
e cases where a more detailled decision is made at a lower level. HAVE_APPLEDRI enables building of an Apple-specific direct rendering interface, still which requires additional fixing up to build properly. v2: Place xfont.c and drisw_glx.c into correct categories. Update 'make check

Re: [Mesa-dev] [PATCH] automake: correctly append the version-script

2014-05-25 Thread Jon TURNEY
On 25/05/2014 17:47, Emil Velikov wrote: Turns out that the AC conditional did not include the the version-scripts as expected. Rather it truncated the remaining linker flags. Oh dear, that doesn't work as intended at all :-( Thanks for fixing this. Reviewed-by: Jon TURNEY I was unde

[Mesa-dev] [PATCH 0/2] Build a driswrast-using libGL on non-DRM targets

2014-06-03 Thread Jon TURNEY
be removed in future. Jon TURNEY (2): glx: Fix build in GLX_DIRECT_RENDERING !GLX_USE_APPLEGL !GLX_USE_DRM case configure: Always default to --enable-driglx-direct configure.ac | 17 ++--- src/glx/glxcmds.c | 2 +- src/glx/glxext.c | 17 - 3 files c

[Mesa-dev] [PATCH 1/2] glx: Fix build in GLX_DIRECT_RENDERING !GLX_USE_APPLEGL !GLX_USE_DRM case

2014-06-03 Thread Jon TURNEY
-by: Jon TURNEY --- configure.ac | 1 + src/glx/glxcmds.c | 2 +- src/glx/glxext.c | 17 - 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 9c64400..d2adb15 100644 --- a/configure.ac +++ b/configure.ac @@ -939,6 +939,7

[Mesa-dev] [PATCH 2/2] configure: Always default to --enable-driglx-direct

2014-06-03 Thread Jon TURNEY
Always default to --enable-driglx-direct, now that will build driswrast, but won't try to use dri[123] on platforms which don't have that. Signed-off-by: Jon TURNEY --- configure.ac | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/configure.ac b/co

Re: [Mesa-dev] [PATCH 1/2] glx: Fix build in GLX_DIRECT_RENDERING !GLX_USE_APPLEGL !GLX_USE_DRM case

2014-06-03 Thread Jon TURNEY
On 03/06/2014 15:19, Aaron Watry wrote: On Tue, Jun 3, 2014 at 8:14 AM, Jon TURNEY wrote: Some untangling to fix building in the dri_platform=none, --enable-driglx-direct case, where only driswast can be used. Turn the test for including the glXGetScreenDriver()/glXGetScreenDriver() interface

Re: [Mesa-dev] [PATCH 3/4] configure: error out when building xa only with swrast

2014-02-28 Thread Jon TURNEY
On 28/02/2014 21:38, Emil Velikov wrote: > Here is a very nice example of what I'm trying to prevent: > > Jon Turney has a tinderbox setup [1] at fd.org. > > For his needs he builds gallium swrast+llvm on top of a indirect > rendered libGL. For unknown reason he has

Re: [Mesa-dev] [PATCH 12/20] drivers/dri: link megadriver with -no-undefined

2014-03-06 Thread Jon TURNEY
On 04/03/2014 21:12, Emil Velikov wrote: > From: Jon TURNEY > > v2: (Emil) > - Do not link agaist libglapi. > > Signed-off-by: Jon TURNEY > Signed-off-by: Emil Velikov > --- > src/mesa/drivers/dri/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [Mesa-dev] [PATCH 00/20] Automake cleanups and Cygwin fixes

2014-03-06 Thread Jon TURNEY
likov/Mesa/ > > Review and comments are greatly appreciated. except for my NAK for 12/20, Reviewed-by: Jon TURNEY ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH mesa-demos] glxgears: Smooth animation with AIGLX

2014-03-26 Thread Jon TURNEY
the same issue, but I haven't yet investigated that. Signed-off-by: Jon TURNEY --- src/xdemos/glxgears.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/xdemos/glxgears.c b/src/xdemos/glxgears.c index 7a3b567..fdd6179 100644 --- a/src/xdemos/glxgear

[Mesa-dev] [PATCH 1/2] Use X11_INCLUDES instead of X11_CFLAGS

2015-09-04 Thread Jon TURNEY
X11_CFLAGS is undefined, so these tests will fail to build if x11proto is installed in a non-standard location. (See also commits 35189d76, bc93c3798, 54b028ba, d901d7e08, etc.) Signed-off-by: Jon TURNEY --- src/glx/tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 2/2] Remove unneeded X11_CFLAGS

2015-09-04 Thread Jon TURNEY
X11_CFLAGS is never defined. Path to X11 headers is not needed here, so just remove. Future work: Using AM_CFLAGS here looks wrong, as this Makefile only builds C++ files Signed-off-by: Jon TURNEY --- src/mesa/main/tests/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa

[Mesa-dev] [PATCH 0/2] Fix remaining uses of X11_CFLAGS

2015-09-04 Thread Jon TURNEY
X11_CFLAGS isn't defined by configure.ac since commmit 35189d76 removed PKG_CHECK_MODULES([X11],[x11]) Fix the remaining uses of X11_CFLAGS. There are no uses of X11_LIBS Jon TURNEY (2): Use X11_INCLUDES instead of X11_CFLAGS Remove unneeded X11_CFLAGS src/glx/tests/Makefile.am

[Mesa-dev] [PATCH] Use IMP_LIB_EXT when checking for LLVM shared libraries

2015-09-04 Thread Jon TURNEY
When checking for LLVM shared libraries, use IMP_LIB_EXT for the extension for shared libraries appropriate to the target, rather than hardcoding '.so' Also add some comments to explain why we have this circus of pain. Signed-off-by: Jon TURNEY --- configu

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-09-04 Thread Jon TURNEY
On 03/07/2015 16:34, Emil Velikov wrote: On 02/07/15 16:32, Jon TURNEY wrote: On 02/07/2015 13:42, Emil Velikov wrote: On 27 June 2015 at 12:21, Jon TURNEY wrote: This smells to me like there's something not quite right about the partitioning of stuff between libmesa and libglapi, but I

Re: [Mesa-dev] [PATCH 2/5] applegl: Provide requirements of _SET_DrawBuffers

2015-09-04 Thread Jon TURNEY
On 13/07/2015 16:32, Emil Velikov wrote: P.S. Why is there no appledriproto package, similar to xf86driproto and friends ? Having appledri{,str}.h duplicated seems fragile and ill-advised. I think this all pre-dates X.org modularization It would probably make sense to have it as a separate pac

Re: [Mesa-dev] [PATCH 00/11] Generated GLX dispatch updates

2016-03-30 Thread Jon Turney
On 24/03/2016 18:09, Adam Jackson wrote: This long-overdue series synchronizes the GLX dispatch scripts with the state of the world in xserver. We no longer use the CALL_* pattern instead emitting gl* calls directly (or thunking through GetProcAddress if needed). We also use overflow-paranoid ma

Re: [Mesa-dev] [PATCH] egl: Remove skeleton implementation of EGL_MESA_screen_surface

2015-05-14 Thread Jon TURNEY
On 01/05/2015 16:35, Adam Jackson wrote: No backend wires this up to anything, and the extension spec has been marked obsolete for 4+ years. Signed-off-by: Adam Jackson [...] -/* EGL_MESA_screen extension >>> PRELIMINARY <<< */ -#ifndef EGL_MESA_screen_surface -#define EGL_MESA_screen_surfac

Re: [Mesa-dev] [PATCH:mesa] swrast: Build fix for Solaris

2015-05-17 Thread Jon TURNEY
On 16/05/2015 05:12, Alan Coopersmith wrote: Ah yes, I see Jons patch now in https://bugs.freedesktop.org/show_bug.cgi?id=90147#c9 That looks like it should work for Solaris too, so whichever the Mesa developers prefer... Alan's patch is clearly superior, so please apply.

Re: [Mesa-dev] [PATCH] rtasm,translate: Re-enable SSE on Mingw64.

2014-11-19 Thread Jon TURNEY
On 19/11/2014 15:25, Jose Fonseca wrote: No idea. But the impression I generally have is MinGW has come a long way since then (3 years ago.) I think there was at least one bug in mesa which prevented this from working, see commit cedfd79b ___ mesa-d

Re: [Mesa-dev] [PATCH 1/4] glcpp: Implicitly resolve version after the first non-space/hash token.

2016-03-09 Thread Jon Turney
On 05/03/2016 03:33, Kenneth Graunke wrote: We resolved the implicit version directive when processing control lines, such as #ifdef, to ensure any built-in macros exist. However, we failed to resolve it when handling ordinary text. [...] diff --git a/src/compiler/glsl/glcpp/tests/146-version-

Re: [Mesa-dev] [PATCH 1/4] glcpp: Implicitly resolve version after the first non-space/hash token.

2016-03-12 Thread Jon Turney
On 10/03/2016 19:26, Kenneth Graunke wrote: On Wednesday, March 9, 2016 3:18:50 PM PST Jon Turney wrote: On 05/03/2016 03:33, Kenneth Graunke wrote: We resolved the implicit version directive when processing control lines, such as #ifdef, to ensure any built-in macros exist. However, we

[Mesa-dev] [PATCH 4/4] Disable use of weak in threads_posix.h on Cygwin

2016-06-13 Thread Jon Turney
Weak doesn't work the same on PE/COFF as on ELF, they are only weak references. Specifically, since nothing else pulls in the object which contains pthread_mutexattr_init() (and coming from the C library, that is the only thing that object contains), means that it ends up as 0 Signed-off-by

[Mesa-dev] [PATCH 0/4] Various Cygwin fixes

2016-06-13 Thread Jon Turney
Jon Turney (2): configure: Don't require pthread-stubs on Cygwin Disable use of weak in threads_posix.h on Cygwin Yaakov Selkowitz (2): configure: Define _GNU_SOURCE for Cygwin as well Use correct names for dlopen()ed files on Cygwin configure.ac

[Mesa-dev] [PATCH 3/4] configure: Don't require pthread-stubs on Cygwin

2016-06-13 Thread Jon Turney
Commit 1f4869a2 unconditionally requires pthread-stubs. Unfortunately, the cleverness that pthread-stubs is doesn't work with PE/COFF, and historically Cygwin doesn't have a pthread-stubs.pc. Don't require pthread-stubs on Cygwin. Signed-off-by: Jon Turney --- co

[Mesa-dev] [PATCH 1/4] configure: Define _GNU_SOURCE for Cygwin as well

2016-06-13 Thread Jon Turney
: Yaakov Selkowitz Reviewed-by: Jon Turney --- configure.ac | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 33d1fef..4967c56 100644 --- a/configure.ac +++ b/configure.ac @@ -254,15 +254,12 @@ case "$host_os" in *-android) a

[Mesa-dev] [PATCH 2/4] Use correct names for dlopen()ed files on Cygwin

2016-06-13 Thread Jon Turney
From: Yaakov Selkowitz Signed-off-by: Yaakov Selkowitz Reviewed-by: Jon Turney --- src/egl/drivers/dri2/egl_dri2.c| 2 ++ src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ src/glx/dri_common.c | 3 +++ src/mesa/main/texcompress_s3tc.c | 2 ++ 4

Re: [Mesa-dev] [PATCH v2 29/40] {st, targets}/dri: use static/dynamic pipe-loader

2015-11-21 Thread Jon Turney
4d92c73daa08abe0a10a5b73565f3a42805090a9 Mon Sep 17 00:00:00 2001 From: Jon Turney Date: Sat, 21 Nov 2015 16:32:26 + Subject: [PATCH] Fix Cygwin build since 23fb1145 by linking gallium_dri with libxmlconfig --- src/gallium/targets/dri/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

Re: [Mesa-dev] [PATCH] configure: check for dladdr via AC_CHECK_FUNC/AC_CHECK_LIB

2014-08-08 Thread Jon TURNEY
On 08/08/2014 18:58, Ilia Mirkin wrote: The problem is that AC_CHECK_FUNCS would stick the LDFLAGS before the conftest.c arg while AC_CHECK_LIB sticks the -ldl after conftest.c. This apparently matters with newer gcc's. There's probably some The key difference seems to be that lto was enabled,

Re: [Mesa-dev] [PATCH 03/19] glx/drisw: add support for DRI2rendererQueryExtension

2014-08-18 Thread Jon TURNEY
: Jon TURNEY Date: Sun, 17 Aug 2014 17:22:22 +0100 Subject: [PATCH] Fix build since 679c2ef "glx/drisw: add support for DRI2rendererQueryExtension", when only building drisw renderer. Signed-off-by: Jon TURNEY --- src/glx/Makefile.am | 6 +++--- src/glx/dri2_query_renderer.c |

Re: [Mesa-dev] [PATCH 10/19] auxiliary/os: introduce os_get_total_physical_memory helper function

2014-08-18 Thread Jon TURNEY
unknown platforms, teach it about the existence of Cygwin. From 03e0df4455810e255c22a0532b9e66dcc3d60a1d Mon Sep 17 00:00:00 2001 From: Jon TURNEY Date: Sun, 17 Aug 2014 17:21:27 +0100 Subject: [PATCH] Teach os_get_physical_memory about Cygwin Signed-off-by: Jon TURNEY --- src/gallium/auxiliary/os

Re: [Mesa-dev] [PATCH 03/19] glx/drisw: add support for DRI2rendererQueryExtension

2014-08-20 Thread Jon TURNEY
On 18/08/2014 13:08, Emil Velikov wrote: On 18/08/14 12:47, Jon TURNEY wrote: On 14/08/2014 23:18, Emil Velikov wrote: The extension is used by GLX_MESA_query_renderer, which can be provided for by hardware and software drivers. v2: Use designated initializers. v3: Move drisw_query_renderer_

Re: [Mesa-dev] [PATCH v2 01/26] util: move os_time.[ch] to src/util

2017-11-10 Thread Jon Turney
ds/5790) Patch attached. From a186f46272c9677f9c33764cbd9d8dc9d442b473 Mon Sep 17 00:00:00 2001 From: Jon Turney Date: Fri, 10 Nov 2017 11:41:13 + Subject: [PATCH] util: include unistd.h, which may be required for usleep prototype MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-En

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-10 Thread Jon Turney
users, prior to this series. Patch attached. From e04c7cfa3a3a560476d361a828070f7785da8bf0 Mon Sep 17 00:00:00 2001 From: Jon Turney Date: Fri, 10 Nov 2017 12:22:25 + Subject: [PATCH] Also provide timespec_get fallback if a POSIX platform doesn't have it ... not just on Windows Signe

[Mesa-dev] [PATCH] glx/windows: Fix building libwindowsdri when libX11 headers are installed in a non-standard location

2017-11-10 Thread Jon Turney
Signed-off-by: Jon Turney --- src/glx/windows/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/windows/Makefile.am b/src/glx/windows/Makefile.am index f84288b935c..f4f8e9664d7 100644 --- a/src/glx/windows/Makefile.am +++ b/src/glx/windows/Makefile.am @@ -10,6 +10,9

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-10 Thread Jon Turney
On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaration of timespec_get() also needs to be provided for POSIX systems which don't have

[Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

2017-11-13 Thread Jon Turney
It's ok to use an empty list for dependencies:, but it's not ok to try to use the found() method of it. See also https://github.com/mesonbuild/meson/issues/2324 Signed-off-by: Jon Turney --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mes

Re: [Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

2017-11-14 Thread Jon Turney
On 13/11/2017 17:41, Dylan Baker wrote: I thought I'd fixed this already, Reviewed-by: Dylan Baker This workaround is already in place for dep_xxf86vm. I took a brief look, and didn't see anywhere the same problem could occur with any of the other uses of [] for a dependency. Q

[Mesa-dev] [PATCH] meson: Don't define HAVE_PTHREAD only on linux

2017-11-15 Thread Jon Turney
not Windows just means we can't build at all. When we are building for Windows, I'm not sure if dependency('threads') would ever find anything, or defining HAVE_PTHREAD has any effect, but avoid defining it there, just in case. Signed-off-by: Jon Turney --- meson.build | 2 +

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-15 Thread Jon Turney
On 15/11/2017 11:21, Nicolai Hähnle wrote: On 13.11.2017 23:55, Rob Herring wrote: On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney wrote: On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I&#

Re: [Mesa-dev] [PATCH v2] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

2017-11-15 Thread Jon Turney
On 15/11/2017 14:35, Nicolai Hähnle wrote: From: Nicolai Hähnle v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds Cc: Jon Turney Cc: Rob Herring Cc: Alexander von Gluck IV Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103674 Fixes: f1a364878431 ("threads: update for lat

[Mesa-dev] [PATCH] mapi: Teach es{1, 2}api/ABI-check shared library names on Cygwin

2017-11-20 Thread Jon Turney
Ideally we'd be able to get the library filename from libtool, but that doesn't seem to be a feature... Use of ${uname} is presumably ok here as we won't be running 'make check' if we are cross-compiling Signed-off-by: Jon Turney --- src/mapi/es1api/ABI-check | 1

Re: [Mesa-dev] [PATCH 5/6] meson: add logic to select apple and windows dri

2017-11-21 Thread Jon Turney
On 21/11/2017 00:50, Dylan Baker wrote: This is still not fully correct (haiku and BSD are probably not correct), but Linux is not regressed and this should be correct for macOS and Windows. Signed-off-by: Dylan Baker --- meson.build | 15 +-- 1 file changed, 13 insertions(+), 2

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

2017-11-25 Thread Jon Turney
On 25/11/2017 04:24, Matt Turner wrote: diff --git a/src/util/u_endian.h b/src/util/u_endian.h index 7bbd7dc215..3d5c006f35 100644 --- a/src/util/u_endian.h +++ b/src/util/u_endian.h @@ -67,4 +67,7 @@ #endif +#warn Unknown Endianness for this platform. Assuming little endian +#define PIPE_ARC

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

2017-11-27 Thread Jon Turney
-sha1_test fails when built for the wrong endianess, so there is some hope to notice this... From e5c6197bdb4dec926ab31534b8533dd1bf14dfa1 Mon Sep 17 00:00:00 2001 From: Jon Turney Date: Mon, 27 Nov 2017 13:32:53 + Subject: [PATCH] Also include endian.h on cygwin If u_endian.h can'

[Mesa-dev] [PATCH 5/7] meson: build src/glx/windows

2017-11-27 Thread Jon Turney
--- src/glx/meson.build | 25 +-- src/glx/windows/meson.build | 48 + 2 files changed, 63 insertions(+), 10 deletions(-) create mode 100644 src/glx/windows/meson.build diff --git a/src/glx/meson.build b/src/glx/meson.build i

[Mesa-dev] [PATCH 1/7] meson: fix generated source inclusion on macOS and Windows

2017-11-27 Thread Jon Turney
From: Dylan Baker --- src/mapi/glapi/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/meson.build b/src/mapi/glapi/meson.build index 14ffa68ad0d..8856a95fb66 100644 --- a/src/mapi/glapi/meson.build +++ b/src/mapi/glapi/meson.build @@ -26,7 +26,7 @@ s

[Mesa-dev] [PATCH 4/7] meson: set _GNU_SOURCE on cygwin

2017-11-27 Thread Jon Turney
--- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index d0618f97344..cf6e028746a 100644 --- a/meson.build +++ b/meson.build @@ -467,7 +467,7 @@ if cc.compiles('int foo(void) { return 0; } int bar(void) __attribute__((alias(" endif #

[Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

2017-11-27 Thread Jon Turney
--- meson.build | 6 -- src/glx/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 68361fc4606..524a03eaa97 100644 --- a/meson.build +++ b/meson.build @@ -866,7 +866,7 @@ if with_platform_x11 dep_x11 = dependency('x11'

[Mesa-dev] [PATCH 6/7] meson: don't require dri2proto for darwin or windows

2017-11-27 Thread Jon Turney
--- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index cf6e028746a..68361fc4606 100644 --- a/meson.build +++ b/meson.build @@ -888,7 +888,9 @@ if with_platform_x11 endif endif if with_glx == 'dri' -dep_dri2proto = depen

[Mesa-dev] [PATCH 2/7] meson: Don't build egl on macOS or Windows

2017-11-27 Thread Jon Turney
From: Dylan Baker --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 53013e47ec4..c24225c0297 100644 --- a/meson.build +++ b/meson.build @@ -261,7 +261,10 @@ endif _egl = get_option('egl') if _egl == 'auto' - with_egl = wi

[Mesa-dev] [PATCH 3/7] meson: set windows glx defines

2017-11-27 Thread Jon Turney
--- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index c24225c0297..d0618f97344 100644 --- a/meson.build +++ b/meson.build @@ -378,6 +378,8 @@ if with_platform_x11 endif if with_dri_platform == 'drm' pre_args += '-DGLX_USE_DRM' +

[Mesa-dev] [PATCH 0/7] [RFC] meson: build src/glx/windows

2017-11-27 Thread Jon Turney
rated source inclusion on macOS and Windows meson: Don't build egl on macOS or Windows Jon Turney (5): meson: set windows glx defines meson: set _GNU_SOURCE on cygwin meson: build src/glx/windows meson: don't require dri2proto for darwin or windows meson: fix deps and underl

Re: [Mesa-dev] [PATCH 5/7] meson: build src/glx/windows

2017-11-29 Thread Jon Turney
On 27/11/2017 18:35, Dylan Baker wrote: Quoting Jon Turney (2017-11-27 05:58:32) --- src/glx/meson.build | 25 +-- src/glx/windows/meson.build | 48 + 2 files changed, 63 insertions(+), 10 deletions(-) create mode

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

2017-11-29 Thread Jon Turney
On 28/11/2017 18:21, Dylan Baker wrote: Quoting Emil Velikov (2017-11-27 06:31:35) IIRC Windows mandates binaries with unresolved symbols. Other platforms allow such behaviour. I think we want to set b_lundef=true, to catch these issues as part of the build process. We already do so in the auto

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

2017-11-30 Thread Jon Turney
On 29/11/2017 17:34, Dylan Baker wrote: Quoting Jon Turney (2017-11-29 08:22:54) On 28/11/2017 18:21, Dylan Baker wrote: Quoting Emil Velikov (2017-11-27 06:31:35) IIRC Windows mandates binaries with unresolved symbols. Other platforms allow such behaviour. I think we want to set b_lundef

  1   2   3   >