On 20/05/2014 09:57, Jeremy Huddleston Sequoia wrote:
Reviewed-by: Jeremy Huddleston Sequoia with one minor change (see below):
Thanks very much for taking the time to review these.
On May 13, 2014, at 05:15, Jon TURNEY wrote:
+SUBDIRS+=. tests
+
include $(top_srcdir)/install-lib-links.mk
Because SUBDIRS is set conditionally, you should add:
DIST_SUBDIRS = tests apple
to handle what I assume is an eventual goal of supporting 'make dist'
I don't think that is needed in this case, as automake should be smart
enough to work it out correctly.
To quote the automake manual [1]:
"If SUBDIRS is defined conditionally using Automake conditionals,
Automake will define DIST_SUBDIRS automatically from the possible values
of SUBDIRS in all conditions.
If SUBDIRS contains AC_SUBST variables, DIST_SUBDIRS will not be defined
correctly because Automake does not know the possible values of these
variables. In this case DIST_SUBDIRS needs to be defined manually."
[1]
http://www.gnu.org/software/automake/manual/html_node/SUBDIRS-vs-DIST_005fSUBDIRS.html
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
