[Mesa-dev] [PATCH 14/14] st/mesa: Use compressed fog mode for atifs.

2017-03-30 Thread Gustaw Smolarczyk
Signed-off-by: Gustaw Smolarczyk --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 6 +++--- src/mesa/state_tracker/st_atom_shader.c | 17 + 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/src/mesa/state_tracker/st_atifs_to_tgsi.c b/src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-07 Thread Gustaw Smolarczyk
2017-04-07 16:31 GMT+02:00 Marek Olšák : > On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk > wrote: >> Signed-off-by: Gustaw Smolarczyk >> --- >> src/mesa/main/enable.c | 1 + >> src/mesa/main/fog.c| 9 + >> src/mesa/main/mtypes.h | 14 ++

Re: [Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

2017-04-07 Thread Gustaw Smolarczyk
2017-04-07 16:40 GMT+02:00 Marek Olšák : > On Fri, Apr 7, 2017 at 4:35 PM, Marek Olšák wrote: >> On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk >> wrote: >>> Signed-off-by: Gustaw Smolarczyk >>> --- >>> src/mesa/main/mtypes.h | 83 ++

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-07 Thread Gustaw Smolarczyk
2017-04-07 23:56 GMT+02:00 Marek Olšák : > On Fri, Apr 7, 2017 at 6:54 PM, Gustaw Smolarczyk > wrote: >> 2017-04-07 16:31 GMT+02:00 Marek Olšák : >>> On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk >>> wrote: >>>> Signed-off-by: Gustaw Smolarczyk

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-08 Thread Gustaw Smolarczyk
2017-04-08 18:37 GMT+02:00 Marek Olšák : > On Sat, Apr 8, 2017 at 12:53 AM, Gustaw Smolarczyk > wrote: >> 2017-04-07 23:56 GMT+02:00 Marek Olšák : >>> On Fri, Apr 7, 2017 at 6:54 PM, Gustaw Smolarczyk >>> wrote: >>>> 2017-04-07 16:31 GMT+02:00 Marek

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

2018-06-18 Thread Gustaw Smolarczyk
hange when the vertex shader is missing (unless that was intended - I am not really familiar with how fixed function shaders work alongside new features). You could also move or update the comment that is just above your change. Regards, Gustaw Smolarczyk >vprog = ctx->_Shader->

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

2018-06-18 Thread Gustaw Smolarczyk
2018-06-18 10:39 GMT+02:00 Iago Toral : > On Mon, 2018-06-18 at 09:43 +0200, Gustaw Smolarczyk wrote: > > 2018-06-18 4:39 GMT+02:00 Timothy Arceri : > > This is required for compatibility profile support. > --- > src/mesa/main/ff_fragment_shader.cpp | 6 +- > 1 fi

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

2018-06-18 Thread Gustaw Smolarczyk
2018-06-18 11:19 GMT+02:00 Iago Toral : > On Mon, 2018-06-18 at 10:45 +0200, Gustaw Smolarczyk wrote: > > 2018-06-18 10:39 GMT+02:00 Iago Toral : > > > On Mon, 2018-06-18 at 09:43 +0200, Gustaw Smolarczyk wrote: > > > > 2018-06-18 4:39 GMT+02:00 Timothy Arceri :

Re: [Mesa-dev] [PATCH v2] mesa: rotation of 0-vector

2018-09-18 Thread Gustaw Smolarczyk
*/ > +optimized = GL_TRUE; > +/* rotate only around x-axis */ > +M(1,1) = c; > +M(2,2) = c; > +if (x < 0.0F) { Isn't x guaranteed to be 0.0F here? And I think you wanted to treat it as 1.0F in that case, so that

Re: [Mesa-dev] [PATCH] radv: fix descriptor pool allocation size

2018-09-18 Thread Gustaw Smolarczyk
riptorPoolCreateInfo::pPoolSizes with a member equal to that type. What it implies (I think), is that VkDescriptorPoolCreateInfo::maxSets and descriptorCount of each VkDescriptorPoolCreateInfo::pPoolSizes are treated separately. I don't think you sh

Re: [Mesa-dev] [PATCH 1.5/2] ac/surface/gfx9: let addrlib choose the preferred swizzle kind

2018-11-21 Thread Gustaw Smolarczyk
dth; > sin.height = in->height; > sin.numSlices = in->numSlices; > sin.numMipLevels = in->numMipLevels; > sin.numSamples = in->numSamples; > sin.numFrags = in->numFrags; > > - if (flags & RADEON_SURF_SCANOUT) { Isn

Re: [Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

2018-03-02 Thread Gustaw Smolarczyk
gt; > > > > +from __future__ import print_function > > > > > > > > > > CopyRight = ''' > > > > > /* > > > > > @@ -60,7 +61,7 @@ class StringTable: > > > > > """ > > > > &g

Re: [Mesa-dev] [PATCH 07/16] radv: Implement VK_KHR_maintenance3.

2018-03-07 Thread Gustaw Smolarczyk
line layouts. These have nothing to do with the pipeline. They > are > * just muttiple descriptor set layouts pasted together > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > index 00bb70612e..593cfc9a36 100644 > --- a/src/amd/vulkan/radv_device.c > +++ b/src/amd/vulkan/radv_device.c > @@ -875,6 +87

Re: [Mesa-dev] [PATCH] st/mesa: expand glDrawPixels cache to handle multiple images

2018-01-25 Thread Gustaw Smolarczyk
st_drawpixels_cache_entry(struct st_context *st) > > +{ > > + unsigned oldest_age = ~0u, oldest_index = ~0u; > > + unsigned i; > > + > > + /* Find entry with oldest (lowest) age */ > > + for (i = 0; i < ARRAY_SIZE(st->drawpix_cache.entries); i++)

Re: [Mesa-dev] [PATCH 3/9] glsl/lower_64bit: extract non-64bit sources from vectors.

2018-02-03 Thread Gustaw Smolarczyk
ir_factory body(&instructions, mem_ctx); > > for (unsigned i = 0; i < num_operands; i++) { > - expand_source(body, ir->operands[i], src[i]); > + if (ir->operands[i]->type->is_64bit()) > + expand_source(body, ir->operands[i], src[i]); >

Re: [Mesa-dev] [PATCH] nir: remove the abs call in is_neg_power_of_two

2018-02-09 Thread Gustaw Smolarczyk
o holds for INT_MIN, for example for 32-bit int, INT_MIN == -2^31 and -(unsigned)INT_MIN == (unsigned)INT_MIN == 2^31. In other words - by first converting to unsigned, we make any overflow happening during computation defined as wrapping, and we want the result to be unsigned anyway. As

Re: [Mesa-dev] [PATCH] mesa/main: Fix memset in formatquery.c

2017-03-17 Thread Gustaw Smolarczyk
17 mar 2017 10:01 "Alejandro Piñeiro" napisał(a): On 17/03/17 06:26, Edward O'Callaghan wrote: > We memset number of elements without multiplication by the > element size. > > Signed-off-by: Edward O'Callaghan > --- > src/mesa/main/formatquery.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [Mesa-dev] [PATCH 2/2] anv: Advertise larger heap sizes

2017-03-18 Thread Gustaw Smolarczyk
18 mar 2017 05:24 "Jason Ekstrand" napisał(a): Instead of just advertising the aperture size, we do something more intelligent. On systems with a full 48-bit PPGTT, we can address 100% of the available system RAM from the GPU. In order to keep clients from burning 100% of your available RAM for

Re: [Mesa-dev] [PATCH 2/2] radv: do not use a bitfield when dirtying the vertex buffers

2017-09-06 Thread Gustaw Smolarczyk
2017-09-06 15:53 GMT+02:00 Samuel Pitoiset : > Useless to track which one has been updated because we > re-upload all the vertex buffers in one shot. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 5 +++-- > src/amd/vulkan/radv_private.h| 2 +- > 2 files changed

Re: [Mesa-dev] [PATCH] radv: check return from mkdir

2018-10-05 Thread Gustaw Smolarczyk
ret == -1) > > if (ret == -1 && errno != EEXIST) ? Won't EEXIST be returned even in case the path already exists but is not a directory? [1] Regards, Gustaw Smolarczyk [1] http://man7.org/linux/man-pages/man2/mkdir.2.html > > > + return false

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add support for Raven2

2018-10-27 Thread Gustaw Smolarczyk
radeonsi/si_pipe.c > @@ -1026,23 +1026,24 @@ struct pipe_screen *radeonsi_screen_create(struct > radeon_winsys *ws, > sscreen->has_msaa_sample_loc_bug = (sscreen->info.family >= > CHIP_POLARIS10 && > sscreen->

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-10-28 Thread Gustaw Smolarczyk
| Mesa and X developer > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Hi, What was the conclusion of this discussion? I don't see any whitelist

Re: [Mesa-dev] [PATCH 02/14] vbo: Remove the VBO_SAFE_FALLBACK flag.

2018-10-30 Thread Gustaw Smolarczyk
wt., 30 paź 2018, 06:08 : > From: Mathias Fröhlich > > On finishing a display list playback the VBO_SAFE_FALLBACK bit > s/SAFE/SAVE/g (here and in the title) Regards, Gustaw Smolarczyk is still kept in vbo_save_context::replay_flags. But examining > replay_flags and the dis

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-10-30 Thread Gustaw Smolarczyk
wt., 30 paź 2018, 23:01 Marek Olšák : > On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer wrote: > >> On 2018-10-28 11:27 a.m., Gustaw Smolarczyk wrote: >> > pon., 17 wrz 2018 o 18:24 Michel Dänzer >> napisał(a): >> >> >> >> On 2018-09-15 3:04 a

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-10-30 Thread Gustaw Smolarczyk
wt., 30 paź 2018 o 23:55 Marek Olšák napisał(a): > > On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk > wrote: >> >> wt., 30 paź 2018, 23:01 Marek Olšák : >>> >>> On Mon, Oct 29, 2018 at 12:43 PM Michel Dänzer wrote: >>>> >>>> On

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-10-30 Thread Gustaw Smolarczyk
śr., 31 paź 2018 o 00:23 Marek Olšák napisał(a): > > On Tue, Oct 30, 2018 at 7:11 PM Gustaw Smolarczyk > wrote: >> >> wt., 30 paź 2018 o 23:55 Marek Olšák napisał(a): >> > >> > On Tue, Oct 30, 2018 at 6:32 PM Gustaw Smolarczyk >> > wrote:

Re: [Mesa-dev] [PATCH 2/2] util/ralloc: Make sizeof(linear_header) a multiple of 8

2018-11-13 Thread Gustaw Smolarczyk
ssert((uintptr_t)&ptr[1] % SUBALLOC_ALIGNMENT == 0); > > > return &ptr[1]; > > > } > > > > These patches are: > > > > Reviewed-by: Eric Anholt > > Thanks a bunch! I hope this is useful f

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: add lp_fence_timedwait() helper

2019-04-11 Thread Gustaw Smolarczyk
mp;f->mutex); > + assert(f->issued); > + while (f->count < f->rank) { > + ret = cnd_timedwait(&f->signalled, &f->mutex, &ts); Shouldn't ret be checked for thrd_busy here as well? Otherwise, the function will busy-wait after the timeout is rea

Re: [Mesa-dev] [PATCH 1/3] llvmpipe: add lp_fence_timedwait() helper

2019-04-16 Thread Gustaw Smolarczyk
wt., 16 kwi 2019 o 12:11 Emil Velikov napisał(a): > > On Thu, 11 Apr 2019 at 17:55, Gustaw Smolarczyk wrote: > > > > czw., 11 kwi 2019 o 18:06 Emil Velikov > > napisał(a): > > > > > > The function is analogous to lp_fence_wait() while taking at timeo

Re: [Mesa-dev] [PATCH v2 1/3] llvmpipe: add lp_fence_timedwait() helper

2019-04-25 Thread Gustaw Smolarczyk
turn (f->count >= f->rank && ret == thrd_success); Is checking for ret == thrd_success here really necessary? If the first part is true we already know that the fence has been signalled. With this changed or not: Reviewed-by: Gustaw Smolarczyk > +} > + > +

Re: [Mesa-dev] [PATCH v2 1/3] llvmpipe: add lp_fence_timedwait() helper

2019-04-25 Thread Gustaw Smolarczyk
czw., 25 kwi 2019 o 20:11 Gustaw Smolarczyk napisał(a): > > czw., 25 kwi 2019 o 19:42 Emil Velikov napisał(a): > > > > The function is analogous to lp_fence_wait() while taking at timeout > > (ns) parameter, as needed for EGL fence/sync. > > > > v2: >

Re: [Mesa-dev] [PATCH 3/3] u_dynarray: turn util_dynarray_{grow, resize} into element-oriented macros

2019-05-04 Thread Gustaw Smolarczyk
bytes(struct util_dynarray *buf, unsigned nelts, size_t > eltsize) > { > + if (unlikely(nelts > UINT_MAX / eltsize)) { > + util_dynarray_fini(buf); > + return 0; > + } > + > + unsigned newsize = nelts * eltsize; > void *p = util_dynarray_ensu

Re: [Mesa-dev] r600g on rv635 and broken mipmaps

2011-04-30 Thread Gustaw Smolarczyk
I can confirm this breakage on rv670 too. It may be related to all chips < RV710 (just a guess). The bug report: https://bugs.freedesktop.org/show_bug.cgi?id=35312 I compile mesa with attached patch since then, but that flush should indeed be implicit, not explicit. 2011/4/30 Mathias Fröhlich : >

[Mesa-dev] Typo in "r600g: add initial cayman acceleration support."

2011-05-25 Thread Gustaw Smolarczyk
The line 209 of src/gallium/drivers/r600/r600_opcodes.h: #define EG_V_SQ_CF_WORD1_SQ_CF_INST_HALT 0x001f has been duplicated by this patch. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Mesa-dev] [PATCH] glxinfo: add support for creating/querying core-profile contexts

2011-06-12 Thread Gustaw Smolarczyk
I found some bugs in this code. 2011/6/11 Brian Paul : > The -c flag says to try to create a core profile (no legacy features) > using glXCreateContextAttribsARB().  A core profile may advertise a > different set of extensions than a compatibility profile (though, > the only difference with NVIDIA

Re: [Mesa-dev] [PATCH] glxinfo: add support for creating/querying core-profile contexts

2011-06-13 Thread Gustaw Smolarczyk
2011/6/13 Brian Paul : > On 06/12/2011 12:56 PM, Gustaw Smolarczyk wrote: >> >> I found some bugs in this code. >> >> 2011/6/11 Brian Paul: >>> >>> The -c flag says to try to create a core profile (no legacy features) >>> using glXCrea

Re: [Mesa-dev] multiple versions in version string

2011-06-20 Thread Gustaw Smolarczyk
Isn't that version because it uses indirect rendering? AFAIK indirect limits GL version to 1.4. There is the version of X's AIGLX driver in parentheses, but only 1.4 features can be used. But it may not be the case here. Could you check wheter glxinfo says that direct rendering is enabled? 2011/6

Re: [Mesa-dev] multiple versions in version string

2011-06-20 Thread Gustaw Smolarczyk
Try the following command: LIBGL_DEBUG=verbose glxinfo and see what's the problem (just a few beginning lines that are new). Have you installed mesa from sources? If so, didn't you forget about dri drivers (in your case, swrast_dri.so)? 2011/6/20 tom fogal : > Gustaw Smolarczyk wri

Re: [Mesa-dev] [PATCH 1/2] getenv4d-with-error: New test for a bug in glGetProgramEnvParameter4dARB().

2011-06-29 Thread Gustaw Smolarczyk
2011/6/29 Eric Anholt : > --- >  tests/all.tests                                    |    4 + >  tests/spec/CMakeLists.txt                          |    1 + >  tests/spec/arb_vertex_program/CMakeLists.gl.txt    |   16 >  tests/spec/arb_vertex_program/CMakeLists.txt       |    1 + >  .../spec/ar

[Mesa-dev] mesa master: commit 2699fce0d69db5158427c8b6c8194b2eefc5e58b

2011-06-30 Thread Gustaw Smolarczyk
Commit 2699fce0d69db5158427c8b6c8194b2eefc5e58b: The first chunk (/common.py) looks really strange. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] gallivm: Fix build with llvm-3.0

2011-07-06 Thread Gustaw Smolarczyk
LLVM 3.0svn changes pretty rapidly. The change in Target->createMCInstPrinter() signature which inspired commits 40ae214067673edbda79371969d1730b6194d83e and 92e29dc5b0474c073b0f05d60629fc6c3decfca4 has been reverted. Signed-off-by: Gustaw Smolarczyk --- src/gallium/auxiliary/gall

[Mesa-dev] A problem in commit be7407b75b12c70e1925c10117937ae2b9e6711f

2011-08-02 Thread Gustaw Smolarczyk
I found (presumably) a bug in commit be7407b75b12c70e1925c10117937ae2b9e6711f of mesa master. The function util_format_swizzle_4f() does not handle UTIL_FORMAT_SWIZZLE_W. The "<" should be replaced by "<=". ___ mesa-dev mailing list mesa-dev@lists.freede

Re: [Mesa-dev] OpenGL to DirectX with Mesa3D

2011-08-25 Thread Gustaw Smolarczyk
2011/8/25 Anonimo Veneziano : > Hi all > I am a programmer but not very skilled in 3D graphics (so pardon me if I > write something wrong). > I need to build my own opengl32.dll to redirect my OpenGL application calls > to DirectX (better if 10 or 11, but 9 could be ok too) > TitaniumGL and 3DAnaly

[Mesa-dev] [PATCH] r600g: Start a new TEX clause if the texture lookup address was fetched in the current clause

2011-02-18 Thread Gustaw Smolarczyk
The comment in Fabian Bieler's patch is a bit German. There should be "and" instead of "und". ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Bug: could not compile mesa because of lacking component

2011-03-14 Thread Gustaw Smolarczyk
from ubuntu 11.04), but we only link with X86 one. The attached patch fixes it by initializing only X86 disassembler. I understand that this is the only backend we support now, right? From 0997970aa9927d37e884212046e3ea0e7eea915b Mon Sep 17 00:00:00 2001 From: Gustaw Smolarczyk Date: Mon, 14 Mar 2011

Re: [Mesa-dev] Bug: could not compile mesa because of lacking component

2011-03-14 Thread Gustaw Smolarczyk
Yes, it works that way too. This way all libs are linked, but ld ignores unused ones (they're static libs), so it shouldn't be any problem. 2011/3/14 José Fonseca : > On Mon, 2011-03-14 at 10:55 -0700, Gustaw Smolarczyk wrote: >> The commit 110f5e2056f80d0b87f2a4388bc3572707

Re: [Mesa-dev] [PATCH 5/6] glsl: Perform type checking on "^^" operands.

2011-04-10 Thread Gustaw Smolarczyk
2011/4/10 Eric Anholt : > +      op[0] = get_scalar_boolean_operand(instructions, state, this, 0, "LHS", > +                                        &error_emitted); > +      op[1] = get_scalar_boolean_operand(instructions, state, this, 1, "LHS", > +                                        &error_emi

Re: [Mesa-dev] GL_ARB_sampler_objects branch

2011-04-11 Thread Gustaw Smolarczyk
Some of the changes in commit ecfaab88b2577bd0395bc05d75a036126806a9c4 of this branch are wrong (found by inspection), likely due to find-replace typo. As an example in r600c: > -static void evergreenSetTexBorderColor(radeonTexObjPtr t, const GLfloat > color[4]) > +static void evergreenSetTexSampl

<    1   2