On Mon, Apr 24, 2017 at 11:59 PM, Eric Anholt wrote:
> I wrote this code with reference to pixman, though I've only decided to
> cover Linux (what I'm testing) and Android (seems obvious enough). Linux
> has getauxval() as a cleaner interface to the /proc entry, but it's more
> glibc-specific and
On Tue, May 2, 2017 at 7:36 PM, Eric Anholt wrote:
> Fixes deqp_gles2 undefine_invalid_object_* failures.
> ---
> src/compiler/glsl/glcpp/glcpp-parse.y | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y
> b/src/compiler/glsl/glcp
On Wed, May 3, 2017 at 1:23 AM, Eric Anholt wrote:
> Erik Faye-Lund writes:
>
>> On Tue, May 2, 2017 at 7:36 PM, Eric Anholt wrote:
>>> Fixes deqp_gles2 undefine_invalid_object_* failures.
>>> ---
>>> src/compiler/glsl/glcpp/glcpp-parse.y | 7 ++-
On Mon, May 15, 2017 at 11:27 AM, Nicolai Hähnle wrote:
> Hi all,
>
> This series aims to simplify how we handle unnamed struct types and fix some
> bugs on the way. Some of the patches should be uncontroversial, and all of
> them align with my understanding of the GLSL spec, but the spec isn't
>
On Thu, Nov 16, 2017 at 6:26 PM, Ilia Mirkin wrote:
> On Thu, Nov 16, 2017 at 7:15 AM, Wladimir wrote:
>>> I think it would be reasonable to re-emit the shader state (or maybe
>>> just the varyings) when the primitive type changes from points to
>>> non-points. It virtually never happens that the
Reviewed-by: Erik Faye-Lund
On Fri, Jul 7, 2017 at 4:11 PM, Brian Paul wrote:
> This function always returned GL_TRUE. Just make it a void function.
> Remove unreachable code following the call to vbo_save_NotifyBegin()
> in save_Begin() in dlist.c
>
> There were some stale c
On Thu, Dec 14, 2017 at 6:02 AM, Timothy Arceri wrote:
> Fixes 56 crashes in radeonsi.
56 crashes with what? Piglit?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, Oct 2, 2017 at 2:57 PM, Emil Velikov wrote:
> On 2 October 2017 at 07:59, Matt Turner wrote:
>> Straight import of the libtxc_dxtn sources. Will be squashed with next
>> commit that reorganizes them into a more familiar form
>
> The code builds and works like a charm, so I won't bother sq
On Thu, Oct 5, 2017 at 8:59 PM, Jochen Rollwagen wrote:
> Am 04.10.2017 um 05:59 schrieb Matt Turner:
>>
>> On Tue, Oct 3, 2017 at 11:01 AM, Jochen Rollwagen
>> wrote:
>>>
>>> From 4cebe50a9bade6717923e104c954f3fad75f71bb Mon Sep 17 00:00:00 2001
>>> From: Jochen Rollwagen
>>> Date: Tue, 3 Oct
On Wed, Oct 11, 2017 at 7:41 PM, Dylan Baker wrote:
> This series is somewhat larger than the one to enable classic drivers. I've
> made
> an effort to split the patches up better this go around, so hopefully that
> will
> make review easier.
>
> I have enabled 3 drivers here, which are probably
On Jan 2, 2017 06:03, "Ilia Mirkin" wrote:
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +-
src/gallium/docs/source/tgsi.rst | 11 +++
src/gallium/include/pipe/p_shader_tokens.h | 2 +-
3 files changed, 13 insertions(+), 2 deletions(-)
diff
Ah, right. Thanks for the explanation!
On Jan 4, 2017 14:02, "Ilia Mirkin" wrote:
> On Wed, Jan 4, 2017 at 4:24 AM, Erik Faye-Lund
> wrote:
> > On Jan 2, 2017 06:03, "Ilia Mirkin" wrote:
> >
> > Signed-off-by: Ilia Mirkin
> > ---
&g
On Jan 4, 2017 14:45, "Jason Ekstrand" wrote:
On Jan 4, 2017 4:54 AM, "Erik Faye-Lund" wrote:
On Jan 3, 2017 16:34, "Jason Ekstrand" wrote:
On Fri, Dec 16, 2016 at 6:49 AM, Juan A. Suarez Romero
wrote:
> From: Samuel Iglesias Gonsálvez
>
> S
On Jan 5, 2017 10:20, "Samuel Iglesias Gonsálvez"
wrote:
We need to pick two 32-bit values per component to perform the right
shuffle operation.
v2 (Jason):
- Add assert to check matching bit sizes (Jason)
- Simplify the code to pick components (Jason)
Signed-off-by: Samuel Iglesias Gonsálvez
On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote:
> On 11.01.2017 13:17, Marek Olšák wrote:
>>
>> On Tue, Jan 10, 2017 at 6:48 PM, Jason Ekstrand
>> wrote:
>>>
>>> I'll be honest, I'm not a fan... Given that D3D10 has one defined
>>> behavior,
>>> D3D9 has another, and GL doesn't specify, I
On Wed, Jan 11, 2017 at 5:32 PM, Marek Olšák wrote:
> On Wed, Jan 11, 2017 at 4:33 PM, Erik Faye-Lund wrote:
>> On Wed, Jan 11, 2017 at 4:14 PM, Nicolai Hähnle wrote:
>>> On 11.01.2017 13:17, Marek Olšák wrote:
>>>>
>>>> On Tue, Jan 10, 2
On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote:
> On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand wrote:
>> On Wed, Jan 11, 2017 at 9:32 AM, Samuel Pitoiset
>> wrote:
>>>
>>>
>>>
>>> On 01/11/2017 05:32 PM, Marek Olšák wrote:
>&g
On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand wrote:
> On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund
> wrote:
>>
>> On Wed, Jan 11, 2017 at 7:22 PM, Marek Olšák wrote:
>> > On Wed, Jan 11, 2017 at 7:09 PM, Jason Ekstrand
>> > wrote:
>> >>
On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset
wrote:
>
>
> On 01/11/2017 07:34 PM, Erik Faye-Lund wrote:
>>
>> On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand
>> wrote:
>>>
>>> On Wed, Jan 11, 2017 at 10:31 AM, Erik Faye-Lund
>>> wrote:
On Wed, Jan 11, 2017 at 9:42 PM, Erik Faye-Lund wrote:
> On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset
> wrote:
>>
>>
>> On 01/11/2017 07:34 PM, Erik Faye-Lund wrote:
>>>
>>> On Wed, Jan 11, 2017 at 7:33 PM, Jason Ekstrand
>>> wrote:
>>
On Wed, Jan 11, 2017 at 9:49 PM, Erik Faye-Lund wrote:
> On Wed, Jan 11, 2017 at 9:42 PM, Erik Faye-Lund wrote:
>> On Wed, Jan 11, 2017 at 9:22 PM, Samuel Pitoiset
>> wrote:
>>>
>>>
>>> On 01/11/2017 07:34 PM, Erik Faye-Lund wrote:
>>>>
Here's a few cleanup-patches I've had in my tree for a while, that
I thought I should send upstream soon.
Erik Faye-Lund (3):
st/mesa: avoid aliasing violation in st_cb_perfmon.c
gallium/docs: remove documentation of removed arg
glsl: ir_explog_to_explog2 is no more
src/ga
Signed-off-by: Erik Faye-Lund
---
src/mesa/state_tracker/st_cb_perfmon.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/state_tracker/st_cb_perfmon.c
b/src/mesa/state_tracker/st_cb_perfmon.c
index cd7fdc0..23d32dc 100644
--- a/src/mesa/state_tracker
nt tree if they encounter it.
Signed-off-by: Erik Faye-Lund
---
src/mesa/program/ir_to_mesa.cpp| 4 +++-
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cp
geom was removed in e968975 ("gallium: remove the geom_flags param
from is_format_supported", Tue Mar 8 00:01:58 2011 +0100), but the
documentation of it was left over. Let's bring the documentation up
to date.
Signed-off-by: Erik Faye-Lund
---
src/gallium/docs/source/screen.rst
Thanks, pushed.
On Fri, Mar 31, 2017 at 4:42 PM, Nicolai Hähnle wrote:
> Series is
>
> Reviewed-by: Nicolai Hähnle
>
> On 31.03.2017 12:57, Erik Faye-Lund wrote:
>>
>> Here's a few cleanup-patches I've had in my tree for a while, that
>> I thought I
On Apr 13, 2017 20:59, "Eric Anholt" wrote:
This will allow Raspbian's ARMv6 builds to take advantage of the new NEON
code, and could prevent problems if vc4 ends up getting used on a v7 CPU
without NEON.
---
src/gallium/drivers/vc4/vc4_screen.c | 3 +++
src/gallium/drivers/vc4/vc4_tiling.h | 2
Just as a fun toy, I decided to give an animated SVG "variation" of
this a go myself:
https://codepen.io/kusma/pen/vrXppL
The actual SVG can be found here:
https://gitlab.freedesktop.org/snippets/492
The gears were generated by this python script, based on the glxgears
source code:
https://git
; Cheers
>
> Mike
>
> On Thu, 7 Jun 2018 at 10:02 Erik Faye-Lund wrote:
>>
>> Just as a fun toy, I decided to give an animated SVG "variation" of
>> this a go myself:
>>
>> https://codepen.io/kusma/pen/vrXppL
>>
>> The actual SVG can
On Thu, Jun 7, 2018 at 9:25 AM, Daniel Stone wrote:
> Hi,
>
> On 2 June 2018 at 16:45, Jason Ekstrand wrote:
>> When the migration happens, there will be a very brief (less than 30
>> minutes?) period during which no one will be able to push to either repo.
>> I'll fire off an e-mail as well as m
On Fri, Jun 8, 2018 at 2:06 PM, Rob Clark wrote:
> On Fri, Jun 8, 2018 at 3:02 AM, Jordan Justen wrote:
>> On Thu, Jun 7, 2018 at 2:56 AM Eero Tamminen
>> wrote:
>>> On 07.06.2018 12:01, Erik Faye-Lund wrote:
>>> > Just as a fun toy, I decided to give an an
On Fri, Jun 8, 2018 at 4:09 PM Rhys Perry wrote:
>
> Might be good to do something like this: https://codepen.io/anon/pen/ERNdYJ
> So that those with NoScript or something won't have gears constantly
> rotating on their screen.
>
Yeah, good point.
___
m
I've updated my attempt here, to now have the original colors, and
centered the M-corners on the text a bit more properly:
https://codepen.io/kusma/pen/vrXppL
On Tue, Jun 12, 2018 at 2:51 AM Rob Clark wrote:
>
> On Mon, Jun 11, 2018 at 6:24 PM, Laura Ekstrand wrote:
> > I really like the rotate
On Tue, Jun 12, 2018 at 1:59 PM Ilia Mirkin wrote:
>
> On Tue, Jun 12, 2018 at 7:04 AM, Erik Faye-Lund wrote:
> > I've updated my attempt here, to now have the original colors, and
> > centered the M-corners on the text a bit more properly:
> >
> > https://cod
On Tue, Jun 12, 2018 at 2:12 PM Erik Faye-Lund wrote:
>
> On Tue, Jun 12, 2018 at 1:59 PM Ilia Mirkin wrote:
> >
> > On Tue, Jun 12, 2018 at 7:04 AM, Erik Faye-Lund wrote:
> > > I've updated my attempt here, to now have the original colors, and
> > >
On Tue, Jun 12, 2018 at 1:03 AM Dylan Baker wrote:
>
> ---
> docs/meson.html | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/docs/meson.html b/docs/meson.html
> index 6697dbb34ef..7541e7a71b0 100644
> --- a/docs/meson.html
> +++ b/docs/meson.html
> @@ -1,9 +1,9 @@
>
Typo in the subject, should be "meson", not "meosn".
On Tue, Jun 12, 2018 at 1:03 AM Dylan Baker wrote:
>
> They require the pipe-loaders, which require xmlconfig, which doesn't
> build with msvc.
> ---
> src/gallium/tests/meson.build | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
On Wed, Jun 20, 2018 at 3:03 AM Jonathan Marek wrote:
>
> Signed-off-by: Jonathan Marek
> ---
> src/gallium/drivers/freedreno/a2xx/fd2_program.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_program.c
> b/src/gallium/drivers/freedreno/a2xx/fd2
On Tue, Jun 26, 2018, 14:00 Rob Clark wrote:
> On Tue, Jun 26, 2018 at 3:32 AM, Erik Faye-Lund
> wrote:
> > On Wed, Jun 20, 2018 at 3:03 AM Jonathan Marek
> wrote:
> >>
> >> Signed-off-by: Jonathan Marek
> >> ---
> >> src/gallium/drive
Unless I'm misunderstanding, this seems to indicate that the hardware
has a fixed set of sample positions, which I don't think is true for
most hardware. Instead, the sample locations is a function of the
multisampling mode for a given surface...
On Thu, Jun 28, 2018 at 3:45 PM Gert Wollny wrote:
On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny wrote:
>
> Am Donnerstag, den 28.06.2018, 17:09 +0200 schrieb Erik Faye-Lund:
> > Unless I'm misunderstanding, this seems to indicate that the hardware
> > has a fixed set of sample positions, which I don't think is true fo
On Thu, Jun 28, 2018 at 5:54 PM Gert Wollny wrote:
>
> Am Donnerstag, den 28.06.2018, 17:40 +0200 schrieb Erik Faye-Lund:
> > On Thu, Jun 28, 2018 at 5:31 PM Gert Wollny > m> wrote:
> > >
> > > There are two aspects:
> > >
> > > For each n
a crash in dEQP-GLES31.functional.draw_indirect.random.0
on VirGL for me.
Signed-off-by: Erik Faye-Lund
---
This is a resend of a mail that didn't reach the mailing-list yet.
Sorry if it appears twice for someone!
src/gallium/auxiliary/util/u_vbuf.c | 3 +++
1 file changed, 3 insertions(
a crash in dEQP-GLES31.functional.draw_indirect.random.0
on VirGL for me.
Signed-off-by: Erik Faye-Lund
---
I noticed this while debugging something else, so I thought I'd send
a patch upstream, as the problem doesn't seem unique to my usecase.
src/gallium/auxiliary/util/u_vbuf.c |
On Thu, Jun 28, 2018 at 7:49 PM Gert Wollny wrote:
>
> Am Donnerstag, den 28.06.2018, 18:09 +0200 schrieb Erik Faye-Lund:
> > It still seems kinda strange (and fragile) to me to try to enumerate
> > all possible sample locations up-front instead of querying a given
> >
On Thu, Jun 28, 2018 at 11:12 PM Fritz Koenig wrote:
>
> Adds an extension to glFramebufferParameteri
> that will specify if the framebuffer is vertically
> flipped. Historically system framebuffers are
> vertically flipped and user framebuffers are not.
> Checking to see the state was done by loo
itions for intermediate sample counts
> - fix unused varible warning
> - update description
> v4: explain better what this patch assumes and how it handles sample numbers
> that are not directly advertised (thanks go to Erik Faye-Lund for making
> me aware that this s
On Fri, Jun 29, 2018 at 12:52 PM Erik Faye-Lund wrote:
>
> On Fri, Jun 29, 2018 at 12:39 PM Gert Wollny
> wrote:
> >
> > Use caps to obtain the multisample sample positions for up to 16
> > positions and implement the according Gallium interface.
> >
> > T
On Fri, Apr 27, 2018 at 11:17 AM, samiuddi
wrote:
> Test: CtsDisplayTestCases pass
>
> Signed-off-by: samiuddi
> ---
> src/egl/drivers/dri2/platform_android.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/egl/drivers/dri2/platform_android.c
> b/src/egl/drivers/dri2/platform_an
This adds an environment-varaible that can be used for driver-specific
flags, as well as a flag for it to enable verbose output.
While we're at it, quiet some overly chatty debug-output by default.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 6 --
This is just debug-cruft left over. Let's just get rid of it.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/drivers/virgl/virgl_encode.h
b/src/gallium/drivers/virgl/virgl_encode.h
index 749cd
This is the only direct call-site for fprintf in virgl; all other
call-sites call debug_printf instead. So let's follow in style here.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ga
Sorry, made a mistake when sending this series out. I'll resend
properly soon.
On Mon, Aug 20, 2018 at 2:03 PM, Erik Faye-Lund
wrote:
This adds an environment-varaible that can be used for driver-specific
flags, as well as a flag for it to enable verbose output.
While we're at
This is the only direct call-site for fprintf in virgl; all other
call-sites call debug_printf instead. So let's follow in style here.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ga
t variable.
Erik Faye-Lund (4):
virgl: delete commented out fprintf-call
virgl: replace fprintf-call with debug_printf
virgl: introduce $VIRGL_DEBUG=verbose
virgl: add debug-switch to output TGSI
src/gallium/drivers/virgl/virgl_context.c | 6 --
src/gallium/drivers/virgl/virgl_enco
This is just debug-cruft left over. Let's just get rid of it.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/drivers/virgl/virgl_encode.h
b/src/gallium/drivers/virgl/virgl_encode.h
index 749cd
This adds an environment-varaible that can be used for driver-specific
flags, as well as a flag for it to enable verbose output.
While we're at it, quiet some overly chatty debug-output by default.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 6 --
This is quite useful for debugging shader-transpiling issues in
virglrenderer.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_encode.c | 3 +++
src/gallium/drivers/virgl/virgl_screen.c | 1 +
src/gallium/drivers/virgl/virgl_screen.h | 1 +
3 files changed, 5 insertions
has an
exhaustive list of qualifiers here, and it does not include an option
with both.
So let's factor out the precise/invariant handling from the
type_qualifier rule so we can reuse it, as there's some intricate
subtleties here.
For reference: glslangValidator already allows this.
Sig
On ma., aug. 27, 2018 at 9:49 AM, Gert Wollny
wrote:
Am Montag, den 20.08.2018, 14:10 +0200 schrieb Erik Faye-Lund:
This is quite useful for debugging shader-transpiling issues in
virglrenderer.
Isn't this coverted by ST_DEBUG=tgsi?
Ah, I wasn't even aware of this.
There&#
x->cbuf->cdw,
hdr_len);
...instead.
Otherwise we'll get spewing on stderr, which has been known to cause
issues for some test-suite runners.
With that fixed:
Reviewed-by: Erik Faye-Lund
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Ping?
On on., aug. 22, 2018 at 7:34 PM, Erik Faye-Lund
wrote:
There's seems to be nothing in the GLSL (ES) specifications that
diallow
redeclaring a variable as both 'precise' and 'invariant' in the same
statement. But the way the parse-rules are structured this fai
MaxAtomicCounters has already been assigned in the loop above in the
ssbo_atomic = true case, so this will calculate the same value as the
default.
While we're at it, fixup indentation on the MaxAtomicBufferBindings
assign.
Signed-off-by: Erik Faye-Lund
---
src/mesa/state_tr
final step currently needed to pass dEQP GLES-3.1 (as well as
GLES-3.2) using virgl/virglrenderer on i965 hardware.
Erik Faye-Lund (6):
st/mesa: use real bool for can_ubo
st/mesa: clean up atomic vs ssbo code
st/mesa: simplify MaxAtomicBufferSize-logic
gallium: add PIPE_CAP_MAX_COMBINED_SHAD
This gets rid of a r600 specific hack in the state-tracker, and prepares
for other drivers to be able to use hw-atomics.
While we're at it, clean up some indentation in the various drivers.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++
src/ga
SSBOs without incorrectly
dropping the last SSBO.
This has the nice result that the SSBOs and atomic buffers are dealt
with almost completely orthogonally, easing some upcoming patches.
Signed-off-by: Erik Faye-Lund
---
src/mesa/state_tracker/st_extensions.c | 27 --
1
This moves the evergreen-specific max-sizes out as a driver-cap, so
other drivers with less strict requirements also can use hw-atomics.
Remove ssbo_atomic as it's no longer needed.
We should now be able to use hw-atomics for some stages and not for
other, if needed.
Signed-off-by: Erik
We're doing full c99 now, so there's no point in using the old boolean
type.
Signed-off-by: Erik Faye-Lund
---
This is not technically nessecary for the series, but IMO a nice cleanup
nevertheless.
src/mesa/state_tracker/st_extensions.c | 6 +++---
1 file changed, 3 insertions(+), 3
virgl_protocol.h is considered to have it's upstream in the
virglrenderer repository, and somehow these minor differences has
crept in.
Let's sync with the upstream to avoid this.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_protocol.h | 2 +-
1 file changed, 1
From: Tomeu Vizoso
Emulating atomics on top of ssbos can lead to too small max SSBO count,
so let's use the hw-atomics mechanism to expose atomic buffers instead.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 37 ++
src/gallium/dr
On fr., aug. 31, 2018 at 7:35 PM, Gurchetan Singh
wrote:
On Thu, Aug 30, 2018 at 6:41 AM Erik Faye-Lund
wrote:
From: Tomeu Vizoso
Emulating atomics on top of ssbos can lead to too small max SSBO
count,
so let's use the hw-atomics mechanism to expose atomic buffers
in
On fr., aug. 31, 2018 at 7:44 PM, Gurchetan Singh
wrote:
On Thu, Aug 30, 2018 at 6:41 AM Erik Faye-Lund
wrote:
This moves the evergreen-specific max-sizes out as a driver-cap, so
other drivers with less strict requirements also can use hw-atomics.
Remove ssbo_atomic as it's no l
PM Gurchetan Singh
wrote:
On Thu, Aug 30, 2018 at 6:41 AM Erik Faye-Lund
wrote:
>
> From: Tomeu Vizoso
>
> Emulating atomics on top of ssbos can lead to too small max SSBO
count,
> so let's use the hw-atomics mechanism to expose atomic buffers
instead.
>
> S
MaxAtomicCounters has already been assigned in the loop above in the
ssbo_atomic = true case, so this will calculate the same value as the
default.
While we're at it, fixup indentation on the MaxAtomicBufferBindings
assign.
Signed-off-by: Erik Faye-Lund
Reviewed-by: Marek Olšák
---
src
SSBOs without incorrectly
dropping the last SSBO.
This has the nice result that the SSBOs and atomic buffers are dealt
with almost completely orthogonally, easing some upcoming patches.
Signed-off-by: Erik Faye-Lund
Reviewed-by: Marek Olšák
---
src/mesa/state_tracker/st_extensions.c
This moves the evergreen-specific max-sizes out as a driver-cap, so
other drivers with less strict requirements also can use hw-atomics.
Remove ssbo_atomic as it's no longer needed.
We should now be able to use hw-atomics for some stages and not for
other, if needed.
Signed-off-by: Erik
state-tracker requirement.
- [Marek] Added documentation of the new caps
Erik Faye-Lund (6):
st/mesa: use real bool for can_ubo
st/mesa: clean up atomic vs ssbo code
st/mesa: simplify MaxAtomicBufferSize-logic
gallium: add PIPE_CAP_MAX_COMBINED_SHADER_BUFFERS
gallium
This gets rid of a r600 specific hack in the state-tracker, and prepares
for other drivers to be able to use hw-atomics.
While we're at it, clean up some indentation in the various drivers.
Signed-off-by: Erik Faye-Lund
Reviewed-by: Marek Olšák
Reviewed-by: Wladimir J. van der Laan
---
We're doing full c99 now, so there's no point in using the old boolean
type.
Signed-off-by: Erik Faye-Lund
Reviewed-by: Marek Olšák
---
src/mesa/state_tracker/st_extensions.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/state_tracker/st_extension
virgl_protocol.h is considered to have it's upstream in the
virglrenderer repository, and somehow these minor differences has
crept in.
Let's sync with the upstream to avoid this.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_protocol.h | 2 +-
1 file changed, 1
From: Tomeu Vizoso
Emulating atomics on top of ssbos can lead to too small max SSBO count,
so let's use the hw-atomics mechanism to expose atomic buffers instead.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_context.c | 37 ++
src/gallium/dr
no longer crash (although it still
fails):
bin/copyteximage 2D -samples=2 -auto
Signed-off-by: Erik Faye-Lund
---
This is the patch that I'm a bit unsure about. More details in the
cover letter.
src/gallium/drivers/virgl/virgl_texture.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(
When we fail to map memory, we should also free trans to avoid
leaking memory.
Noticed while reading code.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_texture.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/virgl/virgl_texture.c
b/src/gallium
ughts here? It seems you introduced this
inconsistency in the very first commit to virgl. Was there some
expectation of some third, non-depth handling case here that just didn't
get noticed until now?
Erik Faye-Lund (4):
virgl: free trans on map-error
virgl: drop needless return-code
vir
We don't use the size we calculate in this function, so let's just
drop the calculation
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_texture.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/gallium/drivers/virgl/virgl_texture.c
b/s
We always return TRUE, and we never check the return-value. Let's
just drop the return value instead.
Signed-off-by: Erik Faye-Lund
---
src/gallium/drivers/virgl/virgl_texture.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/drivers/virgl/virgl_texture
0xBBB30CA: st_api_create_context (st_manager.c:896)
by 0xB981E76: dri_create_context (dri_context.c:155)
by 0xB97BDCE: driCreateContextAttribs (dri_util.c:473)
by 0x5288331: dri3_create_context_attribs (dri3_glx.c:309)
by 0x5264D64: glXCreateContextAttribsARB (create_context.c:78)
Signed-off-by: Erik
On to., sep. 6, 2018 at 3:00 PM, Emil Velikov
wrote:
Hi Erik,
On 6 September 2018 at 11:48, Erik Faye-Lund
wrote:
If we end up never taking the loop that writes ret, we can end up
with
an uninitialized value, and if we're *really* unlucky, that value
can
be -1, causing us to go
"},
+ { "glsl", debug_shader_glsl, "Print GLSL shaders created from
TGSI"},
+ { "glsl", debug_shader_streamout, "Print GLSL shaders created
from TGSI"},
Typo? Shouldn't the string be "streamout", and the description be
somet
On to., sep. 6, 2018 at 3:25 PM, Emil Velikov
wrote:
On 5 September 2018 at 16:34, Gert Wollny
wrote:
+
+enum virgl_debug_flags {
+ debug_shader_tgsi = 1 << 0,
+ debug_shader_glsl = 1 << 1,
+ debug_shader_streamout = 1 << 2,
+ debug_shader = debug_shader_tgsi | debug_shader_
88d24s8ms4
Signed-off-by: Erik Faye-Lund
Fixes: a8987b88ff1 "virgl: add driver for virtio-gpu 3D (v2)"
---
I noticed this crash while testing this patch:
https://patchwork.freedesktop.org/patch/248805/
src/gallium/drivers/virgl/virgl_texture.c | 2 ++
1 file changed, 2 insertions(
If we update the program-state etc, we risk compiling needless shaders,
which can cost quite a bit of performance.
Signed-off-by: Erik Faye-Lund
---
This was motivated by seeing an unexpected shader-compile with
nonsensical state on start-up in glxgears.
src/mesa/main/clear.c | 34
ed, Sep 12, 2018 at 12:05 PM Erik Faye-Lund
wrote:
If we update the program-state etc, we risk compiling needless
shaders,
which can cost quite a bit of performance.
Signed-off-by: Erik Faye-Lund
---
This was motivated by seeing an unexpected shader-compile with
nonsensical state on s
ids a crash while running Piglit's glx/glx-visuals-stencil
test, both on virgl and r600g.
Signed-off-by: Erik Faye-Lund
---
src/mesa/state_tracker/st_atom_framebuffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_atom_framebuffer.c
, let's make a helper for it.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 6 +++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
index c51b3c17c0d..14f9a6b8987 100644
ums there.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index 2e2ef9a05bb..b715af1a468 100644
--- a/src/mesa/main/glformats.c
+++ b/src/mesa/main/glfo
This makes the logic a little bit easier to follow; this is *either*
about ES2 compatibility *or* about gles. GL_RGB565 was added already in
OpenGL ES 1.0.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa
This makes the logic a little bit easier to follow, and reduce a bit of
repetition.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 27 +++
2 files changed, 17 insertions(+), 16 deletions(-)
diff --git a/src/mesa/main
ARB_texture_rgb10_a2ui isn't supported on OpenGL ES, we shouldn't expose
it there even if the driver supports it.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/context.h | 6 ++
src/mesa/main/glformats.c | 12 ++--
2 files changed, 12 insertions(+), 6 deletions(-)
di
_mesa_has_FOO_bar() knows about the APIs these extensions should be
supported under, so let's use that to simplify these checks a bit.
Signed-off-by: Erik Faye-Lund
---
src/mesa/main/glformats.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src
301 - 400 of 768 matches
Mail list logo
