Re: [Mesa-dev] [PATCH 6/7] mesa: build xmlconfig to a separate static library

2015-06-11 Thread Erik Faye-Lund
On Thu, Jun 11, 2015 at 1:19 AM, Matt Turner wrote: > On Wed, Jun 10, 2015 at 3:54 PM, Emil Velikov > wrote: >> From: Erik Faye-Lund >> >> As we use the file from both the dri modules and loader, we end up with >> multiple definition of the symbols provid

Re: [Mesa-dev] [PATCH 1/6] mesa/es3.1: Do not allow zero size multisampled textures

2015-06-23 Thread Erik Faye-Lund
On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt wrote: > From: Marta Lofstedt > > According to GLES 3.1 CTS test: > ES31-CTS.texture_storage_multisample. > APIGLTexStorage2DMultisample. > multisample_texture_tex_storage_2d_ > invalid_and_border_case_texture_sizes. > > Textures of size 0x0 are not

Re: [Mesa-dev] [PATCH 2/6] mesa/es3.1: Correct error code for illegal internal formats

2015-06-23 Thread Erik Faye-Lund
On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt wrote: > From: Marta Lofstedt > > According to GLES 3.1 CTS test: > ES31-CTS.texture_storage_multisample. > APIGLTexStorage2DMultisample. > multisample_texture_tex_storage_2d_non_color_depth_or_stencil_ > internal_formats_receted. > > An illegal int

Re: [Mesa-dev] [PATCH 3/6] mesa/es3.1 : Correct error code for zero samples

2015-06-23 Thread Erik Faye-Lund
On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt wrote: > From: Marta Lofstedt > > According to GLES 3.1 CTS test: > ES31-CTS.texture_storage_multisample. > APIGLTexStorage2DMultisample. > multisample_texture_tex_storage_2d_zero_sample- > > A call to glTexStorageMultisample with target > GL_TEXTUR

Re: [Mesa-dev] [PATCH 2/6] mesa/es3.1: Correct error code for illegal internal formats

2015-06-23 Thread Erik Faye-Lund
On Tue, Jun 23, 2015 at 3:11 PM, Erik Faye-Lund wrote: > On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt > wrote: >> From: Marta Lofstedt >> >> According to GLES 3.1 CTS test: >> ES31-CTS.texture_storage_multisample. &

Re: [Mesa-dev] [PATCH 4/6] mesa/es3.1 : Correct error code for defect texture target

2015-06-23 Thread Erik Faye-Lund
On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt wrote: > From: Marta Lofstedt > > According to GLES 3.1 CTS test: > ES31-CTS.texture_storage_multisample. > APIGLGetTexLevelParameterifv. > invalid_texture_target_rejected: > > GL_INVALID_ENUM should be generated when > glGetTexLevelParameteriv is c

Re: [Mesa-dev] [PATCH 5/6] mesa/es31: AtomicBufferBindings should be initialized to zero.

2015-06-23 Thread Erik Faye-Lund
On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Accoring to GLES 3.1 CTS: > GLES 3.1 CTS: ES31-CTS.shader_atomic_counters. > basic-buffer-bind. > > AtomicBufferBindings size and start should be initialized > to zero. > OpenGL 3.1 says: "Buffer variables in shad

Re: [Mesa-dev] [PATCH 6/6] mesa/es3.1: Fix error code for glCreateShaderProgram

2015-06-23 Thread Erik Faye-Lund
On Tue, Jun 23, 2015 at 2:23 PM, Marta Lofstedt wrote: > From: Marta Lofstedt > > According to the OpenGL ES standard, 7.3. > For a call to glCreateShaderProgram with count < 0, > a GL_INVALID_VALUE error should be generated. > OpenGL 4.5 defines it the same way.

Re: [Mesa-dev] [RFC shader-db] Add support for shadertoy tests

2015-06-24 Thread Erik Faye-Lund
On Wed, Jun 24, 2015 at 2:18 AM, Rob Clark wrote: > On Tue, Jun 23, 2015 at 7:27 PM, Dylan Baker wrote: >> I have a couple of python pointers for you, feel free to take them or >> leave them. > > cool, thanks.. > > What do others think about including shadertoy in shader-db? If it is > a useful

[Mesa-dev] [PATCH v2 4/7] glsl: No need to lock in _mesa_glsl_release_types

2015-06-25 Thread Erik Faye-Lund
This function only gets called while mesa is unloading, so there's no potential of racing or multiple calls at the same time. So let's just get rid of the locking. Signed-off-by: Erik Faye-Lund --- src/glsl/glsl_types.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[Mesa-dev] [PATCH v2 1/7] mesa/main: Get rid of outdated GDB-hack

2015-06-25 Thread Erik Faye-Lund
All of these enums are now in use around in the code, so there's no need to explicitly use them here any more. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa

[Mesa-dev] [PATCH v2 5/7] util: port _mesa_strto[df] to C

2015-06-25 Thread Erik Faye-Lund
instead of depending on a C++ compiler to initialize at image-load time. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner --- src/glsl/glcpp/glcpp.c| 3 ++ src/glsl/main.cpp | 3 ++ src/mesa/main/context.c | 3 ++ src/util/Makefile.sources | 2 +- src/util/strtod.c

[Mesa-dev] [PATCH v2 6/7] mesa/main: free locale at exit

2015-06-25 Thread Erik Faye-Lund
In order to save a small leak if mesa is continously loaded and unloaded, let's free the locale when the shared object is unloaded. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.c | 12 +++- src/util/strtod.c | 8 src/util/strtod.h | 3 +++ 3

[Mesa-dev] [PATCH v2 7/7] util: assert to verify that locale is initialized

2015-06-25 Thread Erik Faye-Lund
Add an assert to Verify that the locale has been initialized when we call strtod. This might help some developers sleep better at night. Signed-off-by: Erik Faye-Lund --- src/util/strtod.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/util/strtod.c b/src/util/strtod.c index

[Mesa-dev] [PATCH v2 2/7] dri: don't touch the shader compiler

2015-06-25 Thread Erik Faye-Lund
igned-off-by: Erik Faye-Lund --- src/mesa/drivers/dri/common/dri_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index e7ababe..ae4592c 100644 --- a/src/mesa/drivers/dri/common/dri_util.c +++ b/src/mesa/dr

[Mesa-dev] [PATCH v2 3/7] mesa/main: only call _mesa_destroy_shader_compiler once on exit

2015-06-25 Thread Erik Faye-Lund
There's no point in calling _mesa_destroy_shader_compiler multiple times on exit; the resources will only be released once anyway. So let's move the atexit-call into the part that is only called once. Signed-off-by: Erik Faye-Lund --- src/mesa/main/context.c | 7 ++- 1 file

[Mesa-dev] [PATCH v2 0/7] port _mesa_strto[df] to C

2015-06-25 Thread Erik Faye-Lund
it of Mesa, and cleaned up a bunch of stuff in that area. And as a result, this time we end up freeing the locale also. No Piglit regressions observed. [1]: <1426446329-23984-1-git-send-email-kusmab...@gmail.com> Erik Faye-Lund (7): mesa/main: Get rid of outdated GDB-hack dri: don't

Re: [Mesa-dev] [PATCH v2 4/7] glsl: No need to lock in _mesa_glsl_release_types

2015-06-25 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 12:29 AM, Matt Turner wrote: > On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund wrote: >> This function only gets called while mesa is unloading, so there's >> no potential of racing or multiple calls at the same time. So let's >> just get r

Re: [Mesa-dev] [PATCH v2 5/7] util: port _mesa_strto[df] to C

2015-06-25 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 12:44 AM, Matt Turner wrote: > On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund wrote: >> _mesa_strtod and _mesa_strtof are only used from the GLSL compiler and >> the ARB_[vertex|fragment]_program code, meaning that the locale doesn't >> need to

Re: [Mesa-dev] [PATCH v2 6/7] mesa/main: free locale at exit

2015-06-25 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 12:36 AM, Matt Turner wrote: > On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund wrote: >> In order to save a small leak if mesa is continously loaded and >> unloaded, let's free the locale when the shared object is unloaded. >> >&g

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-26 Thread Erik Faye-Lund
On Thu, Jun 25, 2015 at 1:48 AM, Davin McCall wrote: > This is an alternative to my earlier patch [1] (and it is now constructed > properly using git format-patch). > > Quick background: > There is a problem in exec_list due to it directly including a trio > of 'struct exec_node *' members to impl

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 1:23 PM, Davin McCall wrote: > On 26/06/15 12:03, Davin McCall wrote: >> >> ... The stored value of 'n' is not accessed by any other type than the >> type of n itself. This value is then cast to a different pointer type. You >> are mistaken if you think that the cast access

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 3:05 PM, Davin McCall wrote: > On 26/06/15 12:55, Erik Faye-Lund wrote: > > On Fri, Jun 26, 2015 at 1:23 PM, Davin McCall wrote: > > On 26/06/15 12:03, Davin McCall wrote: > > ... The stored value of 'n' is not accessed by any other type th

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 4:16 PM, Davin McCall wrote: > On 26/06/15 14:53, Erik Faye-Lund wrote: >> >> On Fri, Jun 26, 2015 at 3:05 PM, Davin McCall wrote: >>> >>> On 26/06/15 12:55, Erik Faye-Lund wrote: >>> >>> On Fri, Jun 26, 2015 at 1:23

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 4:01 PM, Francisco Jerez wrote: > Davin McCall writes: > >> On 26/06/15 14:31, Eirik Byrkjeflot Anonsen wrote: >>> Erik Faye-Lund writes: >>> >>>> On Fri, Jun 26, 2015 at 1:23 PM, Davin McCall wrote: >>>>> On

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 4:53 PM, Francisco Jerez wrote: > Erik Faye-Lund writes: > >> On Fri, Jun 26, 2015 at 4:16 PM, Davin McCall wrote: >>> On 26/06/15 14:53, Erik Faye-Lund wrote: >>>> >>>> On Fri, Jun 26, 2015 at 3:05 PM, Davin McCall wrote:

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 5:09 PM, Erik Faye-Lund wrote: > On Fri, Jun 26, 2015 at 4:53 PM, Francisco Jerez > wrote: >> Erik Faye-Lund writes: >> >>> On Fri, Jun 26, 2015 at 4:16 PM, Davin McCall wrote: >>>> On 26/06/15 14:53, Erik Faye-Lund wrote: >

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 5:25 PM, Francisco Jerez wrote: > Erik Faye-Lund writes: > >> On Fri, Jun 26, 2015 at 4:53 PM, Francisco Jerez >> wrote: >>> Erik Faye-Lund writes: >>> >>>> On Fri, Jun 26, 2015 at 4:16 PM, Davin McCall wrot

Re: [Mesa-dev] [PATCH v2] glsls: Modify exec_list to avoid strict-aliasing violations

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 5:32 PM, Davin McCall wrote: > On 26/06/15 15:29, Erik Faye-Lund wrote: > > On Fri, Jun 26, 2015 at 4:16 PM, Davin McCall wrote: > > On 26/06/15 14:53, Erik Faye-Lund wrote: > > On Fri, Jun 26, 2015 at 3:05 PM, Davin McCall wrote: > > [...] &

Re: [Mesa-dev] [PATCH v2 0/7] port _mesa_strto[df] to C

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 6:03 PM, Emil Velikov wrote: > On 25 June 2015 at 23:10, Matt Turner wrote: >> On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund wrote: >>> Back in March[1], I sent a patch porting _mesa_strto[df] to >>> C rather than C++. I fixed up

Re: [Mesa-dev] [PATCH v2 0/7] port _mesa_strto[df] to C

2015-06-26 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 6:14 PM, Ilia Mirkin wrote: > On Fri, Jun 26, 2015 at 12:03 PM, Emil Velikov > wrote: >> On 25 June 2015 at 23:10, Matt Turner wrote: >>> On Thu, Jun 25, 2015 at 2:05 PM, Erik Faye-Lund wrote: >>>> Back in March[1], I sent a patch

[Mesa-dev] [PATCH v3 0/6] port _mesa_strto[df] to C

2015-06-26 Thread Erik Faye-Lund
Here's the third version of this series (previsou version was posted as [1]). A couple of typos in patch 4 was fixed, an incorrectly squashed hunk was removed from patch 5. And finally, patch 7 was skipped completely. [1]: <1435266326-13540-1-git-send-email-kusmab...@gmail.com> Erik F

[Mesa-dev] [PATCH v3 5/6] util: port _mesa_strto[df] to C

2015-06-26 Thread Erik Faye-Lund
instead of depending on a C++ compiler to initialize at image-load time. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner --- src/glsl/glcpp/glcpp.c| 3 ++ src/glsl/main.cpp | 3 ++ src/mesa/main/context.c | 3 ++ src/util/Makefile.sources | 2 +- src/util/strtod.c

[Mesa-dev] [PATCH v3 4/6] glsl: No need to lock in _mesa_glsl_release_types

2015-06-26 Thread Erik Faye-Lund
This function only gets called while mesa is unloading, so there's no potential of racing or multiple calls at the same time. So let's just get rid of the locking. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner --- src/glsl/glsl_types.cpp | 8 1 file changed, 4

[Mesa-dev] [PATCH v3 1/6] mesa/main: Get rid of outdated GDB-hack

2015-06-26 Thread Erik Faye-Lund
All of these enums are now in use around in the code, so there's no need to explicitly use them here any more. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner --- src/mesa/main/context.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH v3 6/6] mesa/main: free locale at exit

2015-06-26 Thread Erik Faye-Lund
In order to save a small leak if mesa is continously loaded and unloaded, let's free the locale when the shared object is unloaded. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner --- src/mesa/main/context.c | 12 +++- src/util/strtod.c | 8 src/util/str

[Mesa-dev] [PATCH v3 2/6] dri: don't touch the shader compiler

2015-06-26 Thread Erik Faye-Lund
igned-off-by: Erik Faye-Lund Reviewed-by: Matt Turner --- src/mesa/drivers/dri/common/dri_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index e7ababe..ae4592c 100644 --- a/src/mesa/drivers/dri/c

[Mesa-dev] [PATCH v3 3/6] mesa/main: only call _mesa_destroy_shader_compiler once on exit

2015-06-26 Thread Erik Faye-Lund
There's no point in calling _mesa_destroy_shader_compiler multiple times on exit; the resources will only be released once anyway. So let's move the atexit-call into the part that is only called once. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner --- src/mesa/main/con

Re: [Mesa-dev] [PATCH v3 6/6] mesa/main: free locale at exit

2015-06-27 Thread Erik Faye-Lund
On Fri, Jun 26, 2015 at 9:05 PM, Brian Paul wrote: > On 06/26/2015 12:06 PM, Erik Faye-Lund wrote: >> >> In order to save a small leak if mesa is continously loaded and >> unloaded, let's free the locale when the shared object is unloaded. >> >> Signed-off-by

[Mesa-dev] [PATCH v4 5/6] util: port _mesa_strto[df] to C

2015-06-28 Thread Erik Faye-Lund
instead of depending on a C++ compiler to initialize at image-load time. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul --- src/glsl/glcpp/glcpp.c| 3 ++ src/glsl/main.cpp | 3 ++ src/mesa/main/context.c | 3 ++ src/util/Makefile.sources | 2 +-

[Mesa-dev] [PATCH v4 3/6] mesa/main: only call _mesa_destroy_shader_compiler once on exit

2015-06-28 Thread Erik Faye-Lund
There's no point in calling _mesa_destroy_shader_compiler multiple times on exit; the resources will only be released once anyway. So let's move the atexit-call into the part that is only called once. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul ---

[Mesa-dev] [PATCH v4 4/6] glsl: No need to lock in _mesa_glsl_release_types

2015-06-28 Thread Erik Faye-Lund
This function only gets called while mesa is unloading, so there's no potential of racing or multiple calls at the same time. So let's just get rid of the locking. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul --- src/glsl/glsl_types.cpp | 8 --

[Mesa-dev] [PATCH v4 6/6] mesa/main: free locale at exit

2015-06-28 Thread Erik Faye-Lund
In order to save a small leak if mesa is continously loaded and unloaded, let's free the locale when the shared object is unloaded. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul --- src/mesa/main/context.c | 12 +++- src/util/strtod.c

[Mesa-dev] [PATCH v4 2/6] dri: don't touch the shader compiler

2015-06-28 Thread Erik Faye-Lund
igned-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul --- src/mesa/drivers/dri/common/dri_util.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index e7ababe..ae4592c 100644 --- a/src

[Mesa-dev] [PATCH v4 1/6] mesa/main: Get rid of outdated GDB-hack

2015-06-28 Thread Erik Faye-Lund
All of these enums are now in use around in the code, so there's no need to explicitly use them here any more. Signed-off-by: Erik Faye-Lund Reviewed-by: Matt Turner Reviewed-by: Brian Paul --- src/mesa/main/context.c | 27 --- 1 file changed, 27 deletions(-)

[Mesa-dev] [PATCH v4 0/6] port _mesa_strto[df] to C

2015-06-28 Thread Erik Faye-Lund
Here's the fourth, and hopefully final version of this series. The only code-change this time is fixing up the definition of one_time_fini to have an explict void argument-list. Erik Faye-Lund (6): mesa/main: Get rid of outdated GDB-hack dri: don't touch the shader compiler mesa/

Re: [Mesa-dev] [PATCH v4 0/6] port _mesa_strto[df] to C

2015-06-29 Thread Erik Faye-Lund
On Mon, Jun 29, 2015 at 6:40 PM, Matt Turner wrote: > Thanks! > > Pushed, and sent a note describing how to fix the problems caused by > renaming strtod.cpp -> strtod.c. Thanks a lot :) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lis

[Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Erik Faye-Lund
After c61bc6e ("util: port _mesa_strto[df] to C"), "make check" fails due to a missing _mesa_locale_init. Fixup this oversight. Signed-off-by: Erik Faye-Lund Tested-by: Vinson Lee --- src/glsl/test.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl

Re: [Mesa-dev] [PATCH] glsl: add a missing call to _mesa_locale_init

2015-07-02 Thread Erik Faye-Lund
On Thu, Jul 2, 2015 at 2:56 PM, Ilia Mirkin wrote: > On Thu, Jul 2, 2015 at 5:54 PM, Matt Turner wrote: >> On Thu, Jul 2, 2015 at 2:22 PM, Ilia Mirkin wrote: >>> Can this be done at dlopen/init time? For example what happens if you do >>> >>> static int foo = _mesa_locale_init() >>> >>> IIRC thi

[Mesa-dev] [PATCH v2] glsl: add a missing call to _mesa_locale_init

2015-07-03 Thread Erik Faye-Lund
After c61bc6e ("util: port _mesa_strto[df] to C"), "make check" fails due to a missing _mesa_locale_init. Fixup this oversight, by moving the stand-alone compiler initializer inside initialize_context_to_defaults(). Signed-off-by: Erik Faye-Lund --- Here's what the lat

Re: [Mesa-dev] [RFC 2/2] gallium: add tegra support

2015-10-14 Thread Erik Faye-Lund
On Sun, Oct 11, 2015 at 5:09 PM, Christian Gmeiner wrote: > @@ -2181,6 +2188,13 @@ if test -n "$with_gallium_drivers"; then > done > fi > > +dnl We need to validate some needed dependencies for renderonly drivers. > + > +if test "x$HAVE_GALLIUM_NOUVEAU" != xyes -a "x$HAVE_GALLIUM_TEGRA" == x

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-20 Thread Erik Faye-Lund
On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote: > From: Nanley Chery > > - { "GL_SUN_multi_draw_arrays", o(dummy_true), > GLL,1999 }, > +#define EXT(name_str, driver_cap, api_flags, ) \ > +{ .name = "GL_" #name_str, .

Re: [Mesa-dev] [RFC 10/21] mesa: Remove equality check in helper functions

2015-10-21 Thread Erik Faye-Lund
On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery wrote: > From: Nanley Chery > > Since the version numbers being compared are integral and we don't ever > expect gl_context::Version to be equal to 0, subtract 1 from the rhs of > the equation and perform the optimization of removing the equality che

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Add shared flag to missing locations

2015-10-22 Thread Erik Faye-Lund
On Wed, Oct 21, 2015 at 10:34 PM, Marek Olšák wrote: > On Wed, Oct 21, 2015 at 12:28 PM, Axel Davy wrote: >> The PIPE_BIND_SHARED flag should be added whenever >> the resource may be shared with another process. >> >> In particular if the resource is imported, or may >> be exported, the flag shou

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Add shared flag to missing locations

2015-10-22 Thread Erik Faye-Lund
On Thu, Oct 22, 2015 at 10:54 AM, Marek Olšák wrote: > On Thu, Oct 22, 2015 at 10:22 AM, Erik Faye-Lund wrote: >> On Wed, Oct 21, 2015 at 10:34 PM, Marek Olšák wrote: >>> On Wed, Oct 21, 2015 at 12:28 PM, Axel Davy wrote: >>>> The PIPE_BIND_SHARED flag sho

Re: [Mesa-dev] [PATCH 2/4] st/dri2: Add shared flag to missing locations

2015-10-22 Thread Erik Faye-Lund
On Thu, Oct 22, 2015 at 12:18 PM, Marek Olšák wrote: > On Thu, Oct 22, 2015 at 10:56 AM, Erik Faye-Lund wrote: >> On Thu, Oct 22, 2015 at 10:54 AM, Marek Olšák wrote: >>> On Thu, Oct 22, 2015 at 10:22 AM, Erik Faye-Lund >>> wrote: >>>> On Wed, Oct 2

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

2015-10-25 Thread Erik Faye-Lund
On Sat, Oct 24, 2015 at 7:08 PM, Rob Clark wrote: > From: Rob Clark > > +#define NIR_PASS_PROGRESS(pass, nir, ...) ({ \ > + assert(nir_shader_is_mutable(nir)); \ > + bool __ret = pass(nir, ##__VA_ARGS__); \ > + nir_validate_shader(nir);

Re: [Mesa-dev] [PATCH 3/9] nir: Add lowering of POW instructions if the lower flag is set.

2015-02-02 Thread Erik Faye-Lund
On Sun, Feb 1, 2015 at 10:17 PM, Eric Anholt wrote: > This could be done in a separate pass like we do in GLSL IR, but it seems > to me like having the definitions of the transformations in the two > directions next to each other makes a lot of sense. > --- > src/glsl/nir/nir_opt_algebraic.py | 1

Re: [Mesa-dev] [PATCH] gallium/util: Don't use __builtin_clrsb in util_last_bit().

2015-02-03 Thread Erik Faye-Lund
On Tue, Feb 3, 2015 at 2:28 AM, Matt Turner wrote: > Unclear circumstances lead to undefined symbols on x86. > > Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=536916 A comment[1] on the gentoo bug-tracker suggest doing something along these lines instead (untested)... [1]: https://bugs.gento

Re: [Mesa-dev] [PATCH] gallium/util: Don't use __builtin_clrsb in util_last_bit().

2015-02-03 Thread Erik Faye-Lund
On Tue, Feb 3, 2015 at 7:58 PM, Matt Turner wrote: > On Tue, Feb 3, 2015 at 6:13 AM, Erik Faye-Lund wrote: >> On Tue, Feb 3, 2015 at 2:28 AM, Matt Turner wrote: >>> Unclear circumstances lead to undefined symbols on x86. >>> >>> Bugzilla: https://bugs.gento

Re: [Mesa-dev] [PATCH 2/2] nir/validate: Validate that only float ALU outputs are saturated

2015-02-03 Thread Erik Faye-Lund
On Tue, Feb 3, 2015 at 9:43 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_validate.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c > index 7c801b2..89dfdf8 100644 > --- a/src/glsl/nir/nir_validate.c > +++ b/src/glsl

Re: [Mesa-dev] [PATCH 2/2] nir/validate: Validate that only float ALU outputs are saturated

2015-02-03 Thread Erik Faye-Lund
On Feb 3, 2015 10:39 PM, "Jason Ekstrand" wrote: > > > > On Tue, Feb 3, 2015 at 1:08 PM, Erik Faye-Lund wrote: >> >> On Tue, Feb 3, 2015 at 9:43 PM, Jason Ekstrand wrote: >> > --- >> > src/glsl/nir/nir_validate.c | 8 >> >

Re: [Mesa-dev] Expected wide line rendering with clipping

2015-02-07 Thread Erik Faye-Lund
On Fri, Feb 6, 2015 at 1:11 PM, Iago Toral wrote: > Hi, > > Eduardo and I have been looking into a few dEQP test failures that deal > with wide line rendering. There are a few of them that fail because of > how clipping is implemented for this case. > > The problem in these cases seems to be that

Re: [Mesa-dev] [PATCH 3/3] nir: Add algebraic optimizations for comparisons with identical operands.

2015-02-07 Thread Erik Faye-Lund
On Sat, Feb 7, 2015 at 6:16 AM, Eric Anholt wrote: > No change on shader-db on i965. > --- > src/glsl/nir/nir_opt_algebraic.py | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/glsl/nir/nir_opt_algebraic.py > b/src/glsl/nir/nir_opt_algebraic.py > index a5fe19a..0512a8f 100644

Re: [Mesa-dev] Expected wide line rendering with clipping

2015-02-09 Thread Erik Faye-Lund
On Mon, Feb 9, 2015 at 12:35 PM, Roland Scheidegger wrote: > Am 09.02.2015 um 09:53 schrieb Iago Toral: >> On Fri, 2015-02-06 at 21:27 +0100, Roland Scheidegger wrote: >>> Am 06.02.2015 um 13:11 schrieb Iago Toral: Hi, Eduardo and I have been looking into a few dEQP test failures th

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Layout a 1D miptree horizontally

2015-02-18 Thread Erik Faye-Lund
On Wed, Feb 18, 2015 at 6:02 PM, Ian Romanick wrote: > On 02/17/2015 06:03 AM, Neil Roberts wrote: >> + /* When this layout is used the horizontal alignment is fixed at 64 and >> the >> +* hardware ignores the value given in the surface state >> +*/ >> + const unsigned int align_w = 6

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Layout a 1D miptree horizontally

2015-02-18 Thread Erik Faye-Lund
On Thu, Feb 19, 2015 at 1:12 AM, Matt Turner wrote: > On Wed, Feb 18, 2015 at 3:34 PM, Erik Faye-Lund wrote: >> On Wed, Feb 18, 2015 at 6:02 PM, Ian Romanick wrote: >>> On 02/17/2015 06:03 AM, Neil Roberts wrote: >>>> + /* When this layout is used the horiz

Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

2015-02-26 Thread Erik Faye-Lund
On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner wrote: > On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote: >> Should be defined in math.h. If not, we can add them to c99_math.h > > And FWIW, the MSDN page [0] says that if you define _USE_MATH_DEFINES > before including math.h, these will be define

Re: [Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions

2015-02-26 Thread Erik Faye-Lund
On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund wrote: > On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner wrote: >> On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul wrote: >>> Should be defined in math.h. If not, we can add them to c99_math.h >> >> And FWIW, the MSDN pa

Re: [Mesa-dev] [PATCH 1/8] util: Change hash_table to use quadratic probing.

2015-03-01 Thread Erik Faye-Lund
On Sat, Feb 28, 2015 at 1:53 PM, Thomas Helland wrote: > This should give better cache locality, less memory consumption, > less code, and should also be faster since we avoid a modulo operation. > > This is not the quadratic probing function you see most places. > They do not accumulate, so you t

Re: [Mesa-dev] Question about handling RGBA/BGRA in etnaviv driver

2017-02-03 Thread Erik Faye-Lund
On Fri, Feb 3, 2017 at 11:06 AM, Wladimir wrote: > Yes, but it seems suboptimal, incurring overhead on every rendered pixel. Why would this incur overhead? Can't the etnaviv-hardware perform swizzles for free? I'd assume you could just remap writes to gl_FragColor-compoents... > > Another way th

Re: [Mesa-dev] [PATCH V2] glsl: fix atomic buffer index for bindings other than 0

2015-07-25 Thread Erik Faye-Lund
On Sat, Jul 25, 2015 at 4:24 PM, Timothy Arceri wrote: > Since commit c0cd5b var->data.binding was being used as a replacement > for atomic buffer index, but they don't have to be the same value they > just happen to end up the same when binding is 0. > > Now we store atomic buffer index in the un

Re: [Mesa-dev] [PATCH v2] mesa: AtomicBufferBindings should be initialized to zero.

2015-08-13 Thread Erik Faye-Lund
ctx->Shared->NullBufferObj); > - ctx->AtomicBufferBindings[i].Offset = -1; > - ctx->AtomicBufferBindings[i].Size = -1; > + ctx->AtomicBufferBindings[i].Offset = 0; > + ctx->AtomicBufferBindings[i].Size = 0; > } > } > Loo

[Mesa-dev] [PATCH 2/2] mesa: limit scope of GL 1.0 compatibility shim

2015-08-24 Thread Erik Faye-Lund
OpenGL doesn't expect internalformat={1,2,3,4} to work elsewhere than glTexImage{1,2,3}D, as clearly stated in the spec of glCopyTexImage2D (taken from the OpenGL 1.1 spec, similar wording is present up to OpenGL 3.1 core, where OpenGL 1.0 compatibility was scrapped entirely): "Parameters level, i

[Mesa-dev] [PATCH 1/2] mesa: only look up base-format once

2015-08-24 Thread Erik Faye-Lund
There's no point in repeatedly looking up the base-format of an internalformat. So let's cache it in a variable instead. Signed-off-by: Erik Faye-Lund --- src/mesa/main/teximage.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/teximage.c b/src

Re: [Mesa-dev] [PATCH 03/10] nir: add helpers to check if we can unroll loops

2016-09-16 Thread Erik Faye-Lund
On Thu, Sep 15, 2016 at 9:03 AM, Timothy Arceri wrote: > This will be used by the loop unroll and lcssa passes. > > V2: > - Check instruction count is not too large for unrolling > - Add helper for complex loop unrolling > --- > src/compiler/nir/nir.h | 31 +++ > 1 fil

Re: [Mesa-dev] [PATCH 02/10] nir: Add a loop analysis pass

2016-09-16 Thread Erik Faye-Lund
On Thu, Sep 15, 2016 at 9:03 AM, Timothy Arceri wrote: > + const int bias[] = { -1, 1, 1 }; > + > + for (unsigned i = 0; i < ARRAY_SIZE(bias); i++) { > + iter_int = iter_int + bias[i]; > + > + switch (cond_op) { > + case nir_op_ige: > + case nir_op_ilt: > + case nir_op

Re: [Mesa-dev] [PATCH] st/mesa: only enable MSAA coverage options when we have a MSAA buffer

2016-09-18 Thread Erik Faye-Lund
On Fri, Sep 16, 2016 at 4:42 PM, Brian Paul wrote: > On 09/16/2016 08:07 AM, Marek Olšák wrote: >> >> On Thu, Sep 15, 2016 at 11:20 PM, Brian Paul wrote: >>> >>> Regardless of whether GL_MULTISAMPLE is enabled (it's enabled by default) >>> we should not set the alpha_to_coverage or alpha_to_one f

Re: [Mesa-dev] Expose ES 3.2 symbols in libGLESv2.so?

2016-09-22 Thread Erik Faye-Lund
On Wed, Sep 21, 2016 at 8:57 PM, Kenneth Graunke wrote: > Commit 5921f372c89a68fac6ddefc009442721d9df4db2 exposed GLES 3.1 symbols > in libGLESv2.so. Are we supposed to do the same thing for GLES 3.2? > > I imagine we're supposed to, but I'm not certain what spec actually > defines the ABI or whe

Re: [Mesa-dev] Expose ES 3.2 symbols in libGLESv2.so?

2016-09-22 Thread Erik Faye-Lund
On Thu, Sep 22, 2016 at 5:45 PM, Emil Velikov wrote: > On 22 September 2016 at 08:10, Erik Faye-Lund wrote: >> On Wed, Sep 21, 2016 at 8:57 PM, Kenneth Graunke >> wrote: >>> Commit 5921f372c89a68fac6ddefc009442721d9df4db2 exposed GLES 3.1 symbols >>> in libGLES

Re: [Mesa-dev] Required-for-rendering internal formats

2016-10-13 Thread Erik Faye-Lund
On Thu, Oct 13, 2016 at 5:35 PM, Nicolai Hähnle wrote: > On 13.10.2016 17:15, Ilia Mirkin wrote: >> >> Anyone else have opinions on this? Should st/mesa be adding >> PIPE_BIND_RENDER_TARGET for all textures of the internal formats >> listed in table 8.12? (Which would, in this case, force RGBA8 to

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: > On 09.08.2016 15:58, Rob Clark wrote: >> >> tbh, git submodules are more annoying than they need to be, and I'm >> not really terribly excited to use that for something that is a build >> dependency. Maybe just move it into libdrm instead? >

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 7:24 PM, Nicolai Hähnle wrote: > > On 09.08.2016 18:22, Erik Faye-Lund wrote: >> >> On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: >>> >>> On 09.08.2016 15:58, Rob Clark wrote: >>>> >>>> >>>

Re: [Mesa-dev] [PATCH 1/6] nir: Convert ineg(b2i(a)) to a if it's a boolean.

2016-08-10 Thread Erik Faye-Lund
On Wed, Aug 10, 2016 at 4:30 AM, Kenneth Graunke wrote: > On Haswell (GL 3.3): > > total instructions in shared programs: 6211678 -> 6211584 (-0.00%) > instructions in affected programs: 18968 -> 18874 (-0.50%) > helped: 62 > HURT: 0 > LOST: 0 > GAINED: 4 > > On Broadwell (GL 4.4): > > total ins

Re: [Mesa-dev] [PATCH 2/6] nir: Turn bcsel of +/- 1.0 and 0.0 into b2f sequences.

2016-08-10 Thread Erik Faye-Lund
On Wed, Aug 10, 2016 at 4:30 AM, Kenneth Graunke wrote: > On Haswell (GL 3.3): > > total instructions in shared programs: 6208759 -> 6203860 (-0.08%) > instructions in affected programs: 856541 -> 851642 (-0.57%) > helped: 3157 > HURT: 113 > LOST: 7 > GAINED: 15 > > On Broadwell (GL 4.4): > > to

Re: [Mesa-dev] [PATCH 1/6] nir: Convert ineg(b2i(a)) to a if it's a boolean.

2016-08-10 Thread Erik Faye-Lund
On Wed, Aug 10, 2016 at 5:40 PM, Jason Ekstrand wrote: > On Aug 10, 2016 1:00 AM, "Erik Faye-Lund" wrote: >> >> On Wed, Aug 10, 2016 at 4:30 AM, Kenneth Graunke >> wrote: >> > On Haswell (GL 3.3): >> > >> > total instructions in shared

Re: [Mesa-dev] [PATCH 2/6] nir: Turn bcsel of +/- 1.0 and 0.0 into b2f sequences.

2016-08-10 Thread Erik Faye-Lund
On Wed, Aug 10, 2016 at 5:48 PM, Jason Ekstrand wrote: > On Aug 10, 2016 1:02 AM, "Erik Faye-Lund" wrote: >> >> On Wed, Aug 10, 2016 at 4:30 AM, Kenneth Graunke >> wrote: >> > On Haswell (GL 3.3): >> > >> > total instructions in shared

Re: [Mesa-dev] [PATCH] vbo: Correctly handle attribute offsets in dlist draw.

2016-08-19 Thread Erik Faye-Lund
On Thu, Aug 18, 2016 at 7:50 PM, wrote: > From: Mathias Fröhlich > > Hi, > > I found the below while fixing a similar problem lately in > the immediate mode glBegin/glEnd code path. > > Please review > Thanks > > Mathias > > > > When executing a display list draw with a shader program > using th

Re: [Mesa-dev] [PATCH] vbo: Correctly handle attribute offsets in dlist draw.

2016-08-19 Thread Erik Faye-Lund
On Fri, Aug 19, 2016 at 10:38 AM, Mathias Fröhlich wrote: > On Friday, 19 August 2016 09:20:41 CEST Erik Faye-Lund wrote: >> On Thu, Aug 18, 2016 at 7:50 PM, wrote: >> > From: Mathias Fröhlich >> > >> > Hi, >> > >> > I found the below while

Re: [Mesa-dev] [PATCH] Revert "foo"

2016-09-01 Thread Erik Faye-Lund
On Thu, Sep 1, 2016 at 11:36 AM, Emil Velikov wrote: > This reverts commit 917e906379bc261c65e2cc4942d7bd3d8366f030. Huh? I can't see this commit in mesa.git... ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailm

Re: [Mesa-dev] [PATCH 1/7] EGL: Update eglext.h

2016-09-12 Thread Erik Faye-Lund
An easy-ish way of upgrading a single source file from an upstream and keeping the changes that were done on top, is to branch out from the last update-commit, and update there. Then when merged, git will understand that the changes on top should still be applied when merging. Unfortunately, it bre

[Mesa-dev] [PATCH] compiler: avoid warning about redefinition of PYTHON_GEN

2016-10-26 Thread Erik Faye-Lund
PYTHON_GEN is defined to the exact same thing in both Makefile.glsl.am and Makefile.nir.am. This makes automake complain, so let's lift the definition up to Makefile.am, the same way as MKDIR_GEN. Signed-off-by: Erik Faye-Lund --- src/compiler/Makefile.am | 1 + src/com

Re: [Mesa-dev] [PATCH 2/2] spirv: Use a simpler and more correct implementaiton of tanh()

2016-12-10 Thread Erik Faye-Lund
m_float(nb, > 1))); > return; > + } > > case GLSLstd450Asinh: >val->ssa->def = nir_fmul(nb, nir_fsign(nb, src[0]), Otherwise, looks good! Reviewed-by: Erik Faye-Lund ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

2016-07-07 Thread Erik Faye-Lund
On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: > This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering > producing some constants that were getting compared. > > total instructions in shared programs: 112276 -> 112198 (-0.07%) > instructions in affected programs: 2239 -

Re: [Mesa-dev] [PATCH 1/2] nir: Add optimization for (a || True == True)

2016-07-07 Thread Erik Faye-Lund
On Thu, Jul 7, 2016 at 7:01 PM, Connor Abbott wrote: > On Thu, Jul 7, 2016 at 12:57 PM, Erik Faye-Lund wrote: >> On Thu, Jul 7, 2016 at 2:12 AM, Eric Anholt wrote: >>> This was appearing in vc4 VS/CS in mupen64, due to vertex attrib lowering >>> producing some

Re: [Mesa-dev] context sharing of framebuffer objects

2013-09-30 Thread Erik Faye-Lund
On Mon, Sep 30, 2013 at 11:01 AM, Henri Verbeet wrote: > On 30 September 2013 02:18, Dave Airlie wrote: >> So this led me to look at the spec and the mesa code, and I noticed it >> appears at some point maybe around 3.1 that FBOs are no longer >> considered shared objects at least in core profile

Re: [Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-10-11 Thread Erik Faye-Lund
On Mon, Sep 23, 2013 at 11:02 PM, Erik Faye-Lund wrote: > On Mon, Sep 23, 2013 at 10:35 PM, Erik Faye-Lund wrote: >> The preprocessor currently eats multiple #else directives >> int the same #if(def) ... #endif block. While I haven't been able >> to find anything th

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Erik Faye-Lund
On Mon, Oct 21, 2013 at 4:05 PM, Chris Healy wrote: > I have a headless platform I need OpenGL to work on that does not have X. > It is x86 with Intel HD 4000 graphics. > > Ultimately, I'm just wanting to use OpenGL to render to memory for encoding > to H.264 and streaming. > > I'm trying to build

Re: [Mesa-dev] libGL without X

2013-10-21 Thread Erik Faye-Lund
On Tue, Oct 22, 2013 at 2:58 AM, Chris Healy wrote: > On Mon, Oct 21, 2013 at 2:03 PM, Erik Faye-Lund wrote: >> On Mon, Oct 21, 2013 at 4:05 PM, Chris Healy wrote: >> > I have a headless platform I need OpenGL to work on that does not have >> > X. >> > I

Re: [Mesa-dev] [PATCH 1/2] glsl: Optimize (not A) or (not B) into not (A and B).

2013-10-24 Thread Erik Faye-Lund
On Thu, Oct 24, 2013 at 2:19 AM, Matt Turner wrote: > A few Serious Sam 3 shaders affected: > > instructions in affected programs: 4384 -> 4344 (-0.91%) > --- > src/glsl/opt_algebraic.cpp | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/glsl/opt_algebraic.cpp b/src/g

  1   2   3   4   5   6   7   8   >