Re: [Mesa-dev] [PATCH 7/7] radv: Expose VK_KHR_maintenance1

2017-01-29 Thread Edward O'Callaghan
Patches 4&5 LGTM, Reviewed-by: Edward O'Callaghan On 01/30/2017 12:19 PM, Bas Nieuwenhuizen wrote: > Patch 1-3, 6-7 are > > Reviewed-by: Bas Nieuwenhuizen > > The other two you'll need to find someone else to review as I'm not > going to review my own pa

Re: [Mesa-dev] [PATCH 0/3] radv: VK_KHR_shader_draw_parameters.

2017-01-31 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 02/01/2017 07:42 AM, Bas Nieuwenhuizen wrote: > A basic implementation of VK_KHR_shader_draw_parameters. I haven't > bothered with optimizing it away in the case the shader doesn't > use it, but the impact seems low anyw

Re: [Mesa-dev] [PATCH 1/3] st: st_atom_shader.c C99 tidy up

2017-01-31 Thread Edward O'Callaghan
Patches 1,2&3 are, Reviewed-by: Edward O'Callaghan On 02/01/2017 11:58 AM, Timothy Arceri wrote: > From: Timothy Arceri > > --- > src/mesa/state_tracker/st_atom_shader.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/mesa/state

Re: [Mesa-dev] [PATCH 1/2] radv/ac: add const_index to fetch index for gs inputs

2017-01-31 Thread Edward O'Callaghan
Patches 1&2 are, Reviewed-by: Edward O'Callaghan On 02/01/2017 12:12 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes clip distance fetches as they are single item loads > with a const_index like float[1]. > > Fixes: > dEQP-VK.clipping.user_defined.*.v

Re: [Mesa-dev] Potentially EOL ilo gallium driver

2017-02-01 Thread Edward O'Callaghan
escriptions, etc.). Sorry for the confusions and burdens it bring to > others, and thanks to the few individuals/groups who find it useful > for their needs at various times. > > > On Thu, Dec 8, 2016 at 8:33 AM, Edward O'Callaghan > wrote: >> >> >> O

Re: [Mesa-dev] Potentially EOL ilo gallium driver

2017-02-01 Thread Edward O'Callaghan
On 02/02/2017 12:38 AM, Emil Velikov wrote: > On 1 February 2017 at 12:49, Edward O'Callaghan > wrote: >> Hi guys, >> >> Chia-I Wu thanks so much for getting back to me on this and I think your >> right that Vk is the future - indeed the history was a littl

[Mesa-dev] [PATCH 1/3] ilo: EOL unplumb unmaintained gallium drv from winsys

2017-02-02 Thread Edward O'Callaghan
This is no longer actively maintained and is just accumulating bitrot. Signed-off-by: Edward O'Callaghan --- .../auxiliary/pipe-loader/pipe_loader_drm.c| 5 --- src/gallium/auxiliary/target-helpers/drm_helper.h | 29 - src/gallium/targets/dri/tar

[Mesa-dev] [PATCH 3/3] ilo: EOL unmaintained older gallium intel driver

2017-02-02 Thread Edward O'Callaghan
This is no longer actively maintained and is just accumulating bitrot. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/ilo/Android.mk | 35 - src/gallium/drivers/ilo/Automake.inc | 11 - src/gallium/drivers/ilo/Makefile.am| 33 -

[Mesa-dev] [PATCH 2/3] ilo: EOL drop unmaintained gallium drv from buildsys

2017-02-02 Thread Edward O'Callaghan
This is no longer actively maintained and is just accumulating bitrot. Signed-off-by: Edward O'Callaghan --- Android.mk | 4 ++-- Makefile.am | 2 +- configure.ac| 12 +--- docs/rel

Re: [Mesa-dev] [PATCH] radv/ac: correctly size shared memory usage.

2017-02-02 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/03/2017 12:47 PM, Dave Airlie wrote: > From: Dave Airlie > > We count the number of slots used, but slots are vec4 sized, > so we have to scale by 16 not 4. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_ll

Re: [Mesa-dev] [PATCH] radv: fix compute shared memory stores since 64-bit.

2017-02-02 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/03/2017 12:04 PM, Dave Airlie wrote: > From: Dave Airlie > > These regressed and caused doom to stop loading. > > Fixes: > 03724af26 radv/ac: Implement Float64 load/store var. > > Signed-off-by: Dave Airlie > --- >

Re: [Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

2017-02-03 Thread Edward O'Callaghan
On 02/04/2017 05:48 AM, Bas Nieuwenhuizen wrote: > > On Fri, Feb 3, 2017, at 19:24, Jason Ekstrand wrote: >> On Fri, Feb 3, 2017 at 9:23 AM, Samuel Pitoiset >> mailto:samuel.pitoi...@gmail.com>> wrote: >> >> This is similar to the MESA_GLSL_VERSION_OVERRIDE envvar (mainly >> for develope

Re: [Mesa-dev] [PATCH 0/2] RadeonSI: Use UMR for hang debugging

2017-02-04 Thread Edward O'Callaghan
Thanks for getting this out to the wider community ! Patch 1 isn't the most ideal way to invocate the umr binary but I can't think of an immediately better solution. So, Patches 1 & 2 are, Reviewed-by: Edward O'Callaghan On 02/05/2017 09:44 AM, Marek Olšák wrote: > Hi,

Re: [Mesa-dev] [PATCH 0/8] radv: implement sparseBinding

2017-02-05 Thread Edward O'Callaghan
From what I understand this series is, Reviewed-by: Edward O'Callaghan A few rather trivial style bits to be fixed pertaining of space before '(', e.g., 'if(..)' -> 'if ('. On 02/05/2017 10:43 PM, Bas Nieuwenhuizen wrote: > This implements the sparseBi

Re: [Mesa-dev] [PATCH] glsl: binding qualifier must match with opaque-uniforms only

2017-02-05 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/06/2017 05:53 AM, Andres Gomez wrote: > The binding point is a valid layout qualifier for Uniform Blocks, > Shader Storage Blocks and Opaque-Uniforms. > > From page 60 (page 66 of the PDF) of the GLSL 4.20 spec, v11: > > " A l

Re: [Mesa-dev] [PATCH] radeon/ac: move common llvm build functions to a separate file.

2017-02-06 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/03/2017 11:05 AM, Dave Airlie wrote: > From: Dave Airlie > > Suggested by Marek. > > Signed-off-by: Dave Airlie > --- > src/amd/Makefile.sources | 2 + > src/amd/common/ac_llvm_bui

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-10 Thread Edward O'Callaghan
On 02/08/2017 09:13 AM, Timothy Arceri wrote: > On Tue, 2017-02-07 at 10:56 +0100, Marek Olšák wrote: >> On Tue, Feb 7, 2017 at 2:57 AM, Kenneth Graunke > g> wrote: >>> On Monday, February 6, 2017 8:54:40 PM PST Marek Olšák wrote: On Mon, Feb 6, 2017 at 8:20 PM, Ernst Sjöstrand wrote: >

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-10 Thread Edward O'Callaghan
On 02/10/2017 10:36 PM, Marek Olšák wrote: > On Fri, Feb 10, 2017 at 12:26 PM, Edward O'Callaghan > wrote: >> >> >> On 02/08/2017 09:13 AM, Timothy Arceri wrote: >>> On Tue, 2017-02-07 at 10:56 +0100, Marek Olšák wrote: >>>> On Tue, Feb 7, 2017

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-10 Thread Edward O'Callaghan
On 02/10/2017 10:50 PM, Marek Olšák wrote: > On Fri, Feb 10, 2017 at 12:48 PM, Edward O'Callaghan > wrote: >> >> >> On 02/10/2017 10:36 PM, Marek Olšák wrote: >>> On Fri, Feb 10, 2017 at 12:26 PM, Edward O'Callaghan >>> wrote: >>

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-10 Thread Edward O'Callaghan
matter next > week or next month. We'll likely not support glmark anyway, so the fix > will most likely be disabling multithreading on the fly than trying to > fix the crash. > > Marek > > > On Feb 10, 2017 12:58 PM, "Edward O'Callaghan" >

Re: [Mesa-dev] radv cik fixes

2017-02-13 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 02/14/2017 05:10 PM, Dave Airlie wrote: > Hey, > > This is a bunch of CIK fixes I found thanks to Lyude for remote > access to a test machine. > > The main one is 1/4, it changes the memory base alignment > so that

Re: [Mesa-dev] [PATCH] radv: adopt some init config workarounds from radeonsi.

2017-02-13 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/14/2017 05:25 PM, Dave Airlie wrote: > From: Dave Airlie > > Just one bonaire fix. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/si_cmd_buffer.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) >

Re: [Mesa-dev] [PATCH 0/3] radv: Support image operations without format.

2017-02-14 Thread Edward O'Callaghan
This series LGTM, Reviewed-by: Edward O'Callaghan On 02/15/2017 11:36 AM, Bas Nieuwenhuizen wrote: > No regressions on CTS 1.0.2 mustpass, though I don't think there are > tests for these extensions. I checked there were no references to the > format in the nir->LLVM conve

Re: [Mesa-dev] [PATCH] radv: query cmds should mark a cmd buffer as having draws.

2017-02-14 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/15/2017 11:00 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes a regression with the remove non-draw cmd buffers in > queries. > > Fixes: 8b47b97215a radv: detect command buffers that do no work and drop them > (v2) &g

Re: [Mesa-dev] [RFC] spec: MESA_program_binary

2017-02-15 Thread Edward O'Callaghan
On 02/16/2017 01:52 PM, Timothy Arceri wrote: > In order add functionality to ARB_get_program_binary we need > binary format enums. > --- > > Techland games such as Dead Island and Dying Light make use of > GetProgramBinary(). My current guess is the Dead Island crash > https://bugs.freedesktop

Re: [Mesa-dev] [PATCH 1/4] radeon/ac: add ac_emit_imsb helper.

2017-02-15 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 02/16/2017 02:48 PM, Dave Airlie wrote: > From: Dave Airlie > > We want to use a different intrinsic on newer llvm, so move this > code to a shared area. > > Signed-off-by: Dave Airlie > --- > src/am

Re: [Mesa-dev] [PATCH 1/3] radeon/ac: add emit umsb shared code.

2017-02-15 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 02/16/2017 02:55 PM, Dave Airlie wrote: > From: Dave Airlie > > Since we shared imsb, makes sense to share umsb. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_llvm_build.c | 25 +

Re: [Mesa-dev] [PATCH] radv: Invert ring SGPR check.

2017-02-18 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 02/19/2017 01:39 PM, Bas Nieuwenhuizen wrote: > I assume this wants to check if all pipelines use the same SGPR for > the rings. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 +- > 1 file changed,

Re: [Mesa-dev] [PATCH 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-19 Thread Edward O'Callaghan
On 02/20/2017 11:15 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/r600/r600_pipe.c | 19 +++ > src/gallium/drivers/radeon/r600_pipe_common.c | 8 +++- > src/gallium/drivers/radeon/r600_pipe_common.h | 5 + > src/gallium/drivers/radeonsi/si_pipe.c

Re: [Mesa-dev] [PATCH] radv: handle subpass cache flushes

2017-02-19 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/20/2017 04:17 PM, Dave Airlie wrote: > From: Dave Airlie > > This splits out the cache flush bit setting code > dependent on the src/dest access flags. > > It then calls it from the subpass barrier code. > > It also marks a

[Mesa-dev] [PATCH] radeonsi, r600g: Rename 'R600_DEBUG' -> 'RADEON_DEBUG'

2017-02-20 Thread Edward O'Callaghan
The name has become a little misleading now that it applies to both r600g and radeonsi. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_pipe.c | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 2 +- src/gallium/drivers/radeonsi/glsl_

[Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

2017-02-20 Thread Edward O'Callaghan
The name has become a little misleading now that it applies to both r600g and radeonsi. V.2: Michel Dänzer - R600_DEBUG must continue to work. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_pipe.c | 1 + src/gallium/drivers/radeon/r600_pipe_com

Re: [Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

2017-02-20 Thread Edward O'Callaghan
On 02/20/2017 09:15 PM, Edward O'Callaghan wrote: > The name has become a little misleading now that it applies > to both r600g and radeonsi. > > V.2: Michel Dänzer - R600_DEBUG must continue to work. > > Signed-off-by: Edward O'Callaghan > --- > sr

Re: [Mesa-dev] [PATCH v2] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

2017-02-20 Thread Edward O'Callaghan
On 02/20/2017 10:41 PM, Gustaw Smolarczyk wrote: > 2017-02-20 11:19 GMT+01:00 Edward O'Callaghan : >> >> On 02/20/2017 09:15 PM, Edward O'Callaghan wrote: >>> The name has become a little misleading now that it applies >>> to both r600g and radeonsi. &

Re: [Mesa-dev] [PATCH v2] radeonsi: handle MultiDrawIndirect in si_get_draw_start_count

2017-02-20 Thread Edward O'Callaghan
v2 is, Acked-by: Edward O'Callaghan On 02/21/2017 09:05 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Also handle the GL_ARB_indirect_parameters case where the count itself > is in a buffer. > > Use transfers rather than mapping the buffers directly. This antici

Re: [Mesa-dev] [PATCH V2 3.5/4] st/mesa: get on-disk shader cache

2017-02-21 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/21/2017 02:18 PM, Timothy Arceri wrote: > V2: make sure callback exists before calling it > --- > src/mesa/state_tracker/st_context.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/state_tracker/st_

Re: [Mesa-dev] [PATCH V4 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

2017-02-21 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/21/2017 05:10 PM, Timothy Arceri wrote: > For gpu generations that use LLVM we create a timestamp string > containing both the LLVM and Mesa build times, otherwise we just > use the Mesa build time. > > V2: share code in r600_pipe_co

Re: [Mesa-dev] [PATCH 1/3] radv/ac: rename num clips/cull to output clips/culls

2017-02-21 Thread Edward O'Callaghan
This series is, Reviewed-by: Edward O'Callaghan On 02/21/2017 03:14 PM, Dave Airlie wrote: > From: Dave Airlie > > As geom shaders can have different ones on entry and exit. > > also move to uint8_t as these are never that big. > > Signed-off-by: Dave Airli

Re: [Mesa-dev] [PATCH 1/2] vulkan/wsi: move image count to shared structure.

2017-02-21 Thread Edward O'Callaghan
wait, why is this needed at all Dave? The application should be querying and picking the correct GPU as you well know. This seems unwise to tamper with the mechanism defined by the specification. Kindly, Edward. On 02/21/2017 01:47 PM, Jason Ekstrand wrote: > Fine by me > > Reviewed-by: Jason E

Re: [Mesa-dev] V4 TGSI on-disk shader cache

2017-02-21 Thread Edward O'Callaghan
The rest of this series is, Reviewed-by: Edward O'Callaghan On 02/22/2017 02:45 PM, Timothy Arceri wrote: > Changes in V4: > > - split tgsi cache code into its own file > - add missing fallback for tgsi cache miss > - share the sha1 generated by the load function with the

[Mesa-dev] [PATCH v3] radeonsi, r600g: Alias 'R600_DEBUG' with 'RADEON_DEBUG'

2017-02-21 Thread Edward O'Callaghan
The name has become a little misleading now that it applies to both r600g and radeonsi. V.2: Michel Dänzer - R600_DEBUG must continue to work. V.3: fixup missed case in V.2. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_pipe.c | 1 + src/gallium/dr

Re: [Mesa-dev] [PATCH 4/4] mesa: Avoid out-of-bounds stack read via _mesa_Materiali

2017-02-22 Thread Edward O'Callaghan
indeed 1, 3 & 4 - good catches, Reviewed-by: Edward O'Callaghan On 02/23/2017 07:29 AM, Marek Olšák wrote: > For 1, 3, 4: > > Reviewed-by: Marek Olšák > > I need some time to review patch 2 unless someone else beats me to it. > > Marek > > On Wed, Feb

Re: [Mesa-dev] [PATCH 1/4 v3] gallium: implement util_clear_texture

2017-02-22 Thread Edward O'Callaghan
On 02/23/2017 12:52 PM, Roland Scheidegger wrote: > For the series: > Reviewed-by: Roland Scheidegger Reviewed-by: Edward O'Callaghan > > (I'll commit this tomorrow). > > Roland > > Am 22.02.2017 um 16:56 schrieb Lars Hamre: >> v3: have util_clear_

Re: [Mesa-dev] [PATCH] radeon: fix r600 builds when old version of llvm is present

2017-02-22 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/23/2017 01:37 PM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c > b/src

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix crash in shader cache cased by race condition

2017-02-22 Thread Edward O'Callaghan
1&2 are, Reviewed-by: Edward O'Callaghan On 02/23/2017 02:59 PM, Timothy Arceri wrote: > If a thread doesn't load GLSL IR from cache but does load TGSI > from cache (that was created by another thread) than it will > crash due to expecting gl_program_parameter_list to ha

Re: [Mesa-dev] [PATCH] doc: GL_ARB_buffer_storage is supported on llvmpipe/swr

2017-02-24 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 02/25/2017 07:45 AM, Gregory Hainaut wrote: > At least, the extension is exported (gallium capability > PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT is 1) > > Signed-off-by: Gregory Hainaut > --- > docs/features.txt | 2 +- > 1 file

[Mesa-dev] [PATCH] gallium/nine: Fix build regression

2017-02-25 Thread Edward O'Callaghan
commit 4a88396 dropped 'PIPE_CAP_USER_INDEX_BUFFERS' however this case was missed. Signed-off-by: Edward O'Callaghan --- src/gallium/state_trackers/nine/device9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/device9.c

[Mesa-dev] [PATCH] st/nine: Drop USER_INDEX_BUFFERS check

2017-02-25 Thread Edward O'Callaghan
igned-off-by: Mike Lothian Signed-off-by: Edward O'Callaghan --- src/gallium/state_trackers/nine/device9.c | 3 +-- src/gallium/state_trackers/nine/device9.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_tracke

Re: [Mesa-dev] [PATCH] gallium/nine: Fix build regression

2017-02-25 Thread Edward O'Callaghan
yes sorry disregard this one, I got report this independently. sorry for the noise. On 02/25/2017 10:18 PM, Mike Lothian wrote: > Are we better off just checking for cmst_active now? Since that's all > we're checking > > On Sat, 25 Feb 2017 at 11:12 Edward O'

Re: [Mesa-dev] [PATCH] st/nine: Drop USER_INDEX_BUFFERS check

2017-02-25 Thread Edward O'Callaghan
oh yes I missed that, you want to have drop the negation in your patch Mike. On 02/25/2017 10:28 PM, Mike Lothian wrote: > I think my question regarding the double negative still stands. Is it > "!This->cmst_active" ot "This->cmst_active" > > On Sat, 2

Re: [Mesa-dev] [PATCH v4] st/nine: Drop USER_INDEX_BUFFERS check

2017-02-25 Thread Edward O'Callaghan
esktop.org/show_bug.cgi?id=99953 > Reported-and-tested-by: Vinson Lee (v1) > Cc: Marek Olšák > Cc: Axel Davy > Signed-off-by: Mike Lothian > Signed-off-by: Edward O'Callaghan > --- > src/gallium/state_trackers/nine/device9.c | 3 +-- > src/gallium/state_trackers/nine/de

Re: [Mesa-dev] [PATCH v5] st/nine: Drop USER_INDEX_BUFFERS check

2017-02-25 Thread Edward O'Callaghan
Very noisy but you got there in the end, Reviewed-by: Edward O'Callaghan On 02/25/2017 10:50 PM, Mike Lothian wrote: > This fixes 4a883966c1f74f43afc145d2c3d27af7b8c5e01a where the > PIPE_CAP was removed. > > Now USER_INDEX_BUFFERS are always enabled remove the check and

Re: [Mesa-dev] [PATCH] radv/ac: Add integer->integer casts.

2017-02-25 Thread Edward O'Callaghan
Acked-by: Edward O'Callaghan On 02/26/2017 12:39 PM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > src/amd/common/ac_nir_to_llvm.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/amd/common/ac_nir_to_

Re: [Mesa-dev] [PATCH] swr: enable clear_texture with util_clear_texture

2017-02-25 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 02/26/2017 02:09 PM, Bruce Cherniak wrote: > Passes corresponding piglit tests. > --- > src/gallium/drivers/swr/swr_context.cpp | 1 + > src/gallium/drivers/swr/swr_screen.cpp | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) &

[Mesa-dev] Support 'GL_ARB_conditional_render_inverted' for r600 & radeonsi

2015-07-27 Thread Edward O'Callaghan
helping me test this! Kind Regards, Edward. -- Edward O'Callaghan edward.ocallag...@koparo.com From 430bb99cdd589611a56b19d1a649bfad3c20d261 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Mon, 27 Jul 2015 11:01:47 +1000 Subject: [PATCH] r60

Re: [Mesa-dev] Support 'GL_ARB_conditional_render_inverted' for r600 & radeonsi

2015-07-28 Thread Edward O'Callaghan
dward. -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Jul 28, 2015, at 09:26 PM, Marek Olšák wrote: > Hi Edward, > > please use git send-email next time. Now I have to paste your patch here. > > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index 15bb57f..

[Mesa-dev] [PATCH 1/2] r600: Fix some printf format warns pretaining to PRIi64

2015-07-29 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index 413aa3d..7c5113e 100644

[Mesa-dev] [PATCH 0/2] Misc compiler warn fixes

2015-07-29 Thread Edward O'Callaghan
Rather boring patches to fix a few compiler warnings. Edward O'Callaghan (2): r600: Fix some printf format warns pretaining to PRIi64 mesa: Fix printf format specifier warn of the ptrdiff_t src/gallium/drivers/r600/compute_memory_pool.c | 8 src/mesa/main/buffer

[Mesa-dev] [PATCH 2/2] mesa: Fix printf format specifier warn of the ptrdiff_t

2015-07-29 Thread Edward O'Callaghan
See §7.19.6.1, paragraph 7 of the ISO C specification. Signed-off-by: Edward O'Callaghan --- src/mesa/main/bufferobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9425b09..453b864 100644 --- a/src/mesa

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix printf format specifier warn of the ptrdiff_t

2015-07-29 Thread Edward O'Callaghan
On Thu, Jul 30, 2015, at 09:53 AM, Ilia Mirkin wrote: > I assume that you mean the C99 spec? I don't think MSVC supports %t or %z > :( Correct, why not it is standard C99 sounds like a compiler bug to me if that is really the case :/ > > On Wed, Jul 29, 2015 at 7:46 PM, E

[Mesa-dev] [PATCH] r600: Remove assert that not general in some stream instr's

2015-07-30 Thread Edward O'Callaghan
Don't trigger assert on some stream emit instructions. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp b/src/gallium/drivers/r600/sb/sb_bc_finalize

[Mesa-dev] [PATCH/RFC] Minor assert fix

2015-07-30 Thread Edward O'Callaghan
I believe this assert isn't vaild in generality of possible stream emit instructions out the sb backend finalizer. Edward O'Callaghan (1): r600: Remove assert that not general in some stream instr's src/gallium/drivers/r600/sb/sb_bc_finalize.cpp | 2 -- 1 file chang

Re: [Mesa-dev] [PATCH] r600: Remove assert that not general in some stream instr's

2015-07-31 Thread Edward O'Callaghan
O'Callaghan edward.ocallag...@koparo.com On Fri, Jul 31, 2015, at 12:47 PM, Dave Airlie wrote: > seems like one I wrote already.. > http://lists.freedesktop.org/archives/mesa-dev/2015-July/088404.html > > Dave. > > On 31 July 2015 at 12:42, Edward O'Callaghan > wrote: &

Re: [Mesa-dev] [PATCH 1/3] addrlib: add support for Fiji (v2)

2015-08-04 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 4, 2015, at 03:51 AM, Alex Deucher wrote: > v2: fix tonga chip check > > Reviewed-by: Marek Olšák > Reviewed-by: Christian König > Reviewed-by: David Zhang >

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add support for FIJI (v4)

2015-08-04 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 4, 2015, at 03:51 AM, Alex Deucher wrote: > v2: incorporate comments from Marek > v3: add missing fiji case in winsys init > use tonga raster config (double check th

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add fiji pci id

2015-08-04 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 4, 2015, at 03:51 AM, Alex Deucher wrote: > Reviewed-by: Marek Olšák > Reviewed-by: Christian König > Reviewed-by: David Zhang > Signed-off-by: Alex Deucher &g

Re: [Mesa-dev] [PATCH] gallium/radeon: fix r600g build if LLVM is disabled

2015-08-09 Thread Edward O'Callaghan
LGTM Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 8, 2015, at 10:05 PM, Marek Olšák wrote: > From: Marek Olšák > > MESA_LLVM_VERSION_PATCH is undefined. > --- > src/gallium/drivers/radeon/r600_pipe_common.

Re: [Mesa-dev] [PATCH] radeonsi: add new OLAND pci id

2015-08-10 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 11, 2015, at 05:36 AM, Alex Deucher wrote: > Signed-off-by: Alex Deucher > Cc: mesa-sta...@lists.freedesktop.org > --- > include/pci_ids/radeonsi_pci_ids.h | 1 + > 1

Re: [Mesa-dev] [PATCH 2/2][RFC] docs: Add the 2015 ARB extensions

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 03:48 AM, Thomas Helland wrote: > Signed-off-by: Thomas Helland > --- > This adds a section for the extensions nvidia has chosen to > call the "GL ARB 2

Re: [Mesa-dev] [PATCH 1/5] main: add extension GL_ARB_shader_image_size

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 02:43 AM, Martin Peres wrote: > Signed-off-by: Martin Peres > --- > src/glsl/glcpp/glcpp-parse.y| 3 +++ > src/glsl/glsl_parser_extras

Re: [Mesa-dev] [PATCH 1/2] r600g: fix polygon offset scale

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 09:02 AM, Marek Olšák wrote: > From: Marek Olšák > > The value was copied from r300g, which uses 1/12 subpixels, but this hw > uses 1/16 subpixels. > &g

Re: [Mesa-dev] [PATCH 2/2] r600g: allow setting geometry shader sampler states

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 09:03 AM, Marek Olšák wrote: > From: Marek Olšák > > We were ignoring them. This is both hilarious and sad. > > Cc: mesa-sta...@lists.freedesktop.org >

Re: [Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

2015-08-11 Thread Edward O'Callaghan
-- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 05:54 AM, Marek Olšák wrote: > On Mon, Aug 10, 2015 at 8:30 PM, Zoltan Gilian > wrote: > > --- > > src/gallium/drivers/r600/evergreen_compute.c | 25 ++ > &

Re: [Mesa-dev] [PATCH] st/mesa: small cleanup in st_extensions.c

2015-08-11 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 07:34 AM, Ilia Mirkin wrote: > Reviewed-by: Ilia Mirkin > > On Tue, Aug 11, 2015 at 5:26 PM, Marek Olšák wrote: > > From: Marek Olšák > > >

Re: [Mesa-dev] [PATCH] gallium: add support for GLES texture float extensions (v2)

2015-08-12 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 08:45 PM, Marek Olšák wrote: > From: Marek Olšák > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74329 > > v2: add a CAP for half floats >

Re: [Mesa-dev] [PATCH 05/12] glsl: fix isinf() for doubles

2015-08-16 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 15, 2015, at 09:56 AM, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > ___ > mesa-dev mailing list > mesa-dev@lists.

Re: [Mesa-dev] [PATCH 06/12] glsl: fix ir_constant::equals() for doubles

2015-08-16 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 15, 2015, at 09:52 AM, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > ___ > mesa-dev mailing list > mesa-dev@lists.

Re: [Mesa-dev] [PATCH 01/12] nir/builder: include nir.h

2015-08-16 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 15, 2015, at 08:30 AM, Connor Abbott wrote: > This makes intelligent autocomplete plugins much happier. > > Signed-off-by: Connor Abbott > --- > src/glsl/nir/nir_b

Re: [Mesa-dev] [PATCH 03/12] nir: fix constant folding of bfi

2015-08-16 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Sat, Aug 15, 2015, at 08:30 AM, Connor Abbott wrote: > Signed-off-by: Connor Abbott > --- > src/glsl/nir/nir_opcodes.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH] winsys/amdgpu: fix the type of memory usage counters

2015-08-18 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 19, 2015, at 02:48 AM, Alex Deucher wrote: > On Tue, Aug 18, 2015 at 12:43 PM, Marek Olšák wrote: > > From: Marek Olšák > > Reviewed-by: Alex Deucher > > &g

Re: [Mesa-dev] [PATCH 2/2] android: enable amdgpu winsys in radeonsi driver

2015-08-18 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 18, 2015, at 07:53 PM, Mauro Rossi wrote: > --- > src/gallium/targets/dri/Android.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] android: fix cflags and includes for amdgpu winsys

2015-08-18 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 18, 2015, at 07:53 PM, Mauro Rossi wrote: > --- > src/gallium/winsys/amdgpu/drm/Android.mk | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/

[Mesa-dev] [PATCH] r600g: minor refactor for tessellation support

2015-08-18 Thread Edward O'Callaghan
From: Edward O'Callaghan This gets some churn out the way while prepping for r600g tessellation support that I am trying to work on. Since that will take me some time this also avoids rebases and the such like while keeping seperate indirectly related patches to the actual tessellation su

[Mesa-dev] [PATCH] r600: Rewrite r600_shader_selector_key() to use a switch stmt

2015-08-18 Thread Edward O'Callaghan
From: Edward O'Callaghan Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_state_common.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_stat

[Mesa-dev] [PATCH 2/2] r600: Turn 'r600_shader_key' struct into union

2015-08-19 Thread Edward O'Callaghan
From: Edward O'Callaghan This struct was getting a bit crowded, following the lead of radeonsi, mirror the idea of having sub-structures for each shader type. Turning 'r600_shader_key' into an union saves some trivial memory and CPU cycles for the shader keys. Signed-off-by: Edw

[Mesa-dev] [PATCH 1/2] r600: Rewrite r600_shader_selector_key() to use a switch stmt

2015-08-19 Thread Edward O'Callaghan
From: Edward O'Callaghan Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_state_common.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600/r600_state_common.c b/src/gallium/drivers/r600/r600_stat

[Mesa-dev] [PATCH 0/2] r600g: minor refactor for tessellation support [V.2]

2015-08-19 Thread Edward O'Callaghan
From: Edward O'Callaghan This gets some churn out the way while prepping for r600g tessellation support that I am trying to work on. Since that will take me some time this also avoids rebases and the such like while keeping seperate indirectly related patches to the actual tessellation su

[Mesa-dev] [PATCH 0/4] r600g: Make better use of the TGSI API

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan Minor cleanups that intend to make better use of the TGSI parser API tgsi_scan_shader(). Edward O'Callaghan (4): r600g: Remove dead assigment to 'gs_input_prim' in shader state r600g: Move geometry properties state from shader to selector

[Mesa-dev] [PATCH 1/4] r600g: Remove dead assigment to 'gs_input_prim' in shader state

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan Note that 'geometry shader properties' should be carried in the selector state over the shader state in any case. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_shader.c | 3 --- src/gallium/drivers/r600/r600_shader.h | 1 -

[Mesa-dev] [PATCH 2/4] r600g: Move geometry properties state from shader to selector

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/evergreen_state.c | 16 src/gallium/drivers/r600/r600_pipe.h | 5 + src/gallium/drivers/r600/r600_shader.c | 6 +++--- src/gallium/drivers/r600/r60

[Mesa-dev] [PATCH 3/4] r600g: Don't repeat tgsi_scan_shader(), just use result

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan tgsi_shader_scan() has already happened so just use the results. Signed-off-by: Edward O'Callaghan Signed-off-by: Dave Airlie --- src/gallium/drivers/r600/r600_shader.c | 35 ++ 1 file changed, 10 insertions(+), 25 deletion

[Mesa-dev] [PATCH 4/4] r600g: Use TGSI parse results instead of manually exfiltrating

2015-08-25 Thread Edward O'Callaghan
From: Edward O'Callaghan This makes better use of the work that the TGSI API has done for us. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/s

Re: [Mesa-dev] r600 multiple stream support + one misc debug patch

2015-08-25 Thread Edward O'Callaghan
This patch series is: Reviewed-by: Edward O'Callaghan P.S. thanks for polishing it Dave! -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Aug 25, 2015, at 11:18 AM, Dave Airlie wrote: > This adds multiple stream support for ARB_gpu_shader5, and one > othe

[Mesa-dev] [PATCH 0/4] r600g: Make better use of the TGSI API (V.2)

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan Minor cleanups that intend to make better use of the TGSI parser API tgsi_scan_shader(). V.2 adjustment; Set geometery property state within r600_create_shader_state(). Edward O'Callaghan (4): r600g: Remove dead assigment to 'gs_input_prim' in

[Mesa-dev] [PATCH 4/4] r600g: Use TGSI parse results instead of manually exfiltrating

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan This makes better use of the work that the TGSI API has done for us. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/s

[Mesa-dev] [PATCH 2/4] r600g: Move geometry properties state from shader to selector

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/evergreen_state.c | 16 src/gallium/drivers/r600/r600_pipe.h | 5 + src/gallium/drivers/r600/r600_shader.c | 6 +++--- src/gallium/drivers/r600/r60

[Mesa-dev] [PATCH 3/4] r600g: Set geometry properties in r600_create_shader_state()

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan The selector is shared by all shader variants, so the individual shaders shouldn't change it. Use tgsi_shader_scan() results to set geometry properties within a r600_create_shader_state() call and treat said propertices in the selector as read-o

[Mesa-dev] [PATCH 1/4] r600g: Remove dead assigment to 'gs_input_prim' in shader state

2015-08-29 Thread Edward O'Callaghan
From: Edward O'Callaghan Note that 'geometry shader properties' should be carried in the selector state over the shader state in any case. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_shader.c | 3 --- src/gallium/drivers/r600/r600_shader.h | 1 -

Re: [Mesa-dev] [PATCH] r600g: fix calculation for gpr allocation

2015-08-31 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan -- Edward O'Callaghan edward.ocallag...@koparo.com On Tue, Sep 1, 2015, at 12:34 PM, Dave Airlie wrote: > From: Dave Airlie > > I've been chasing a geom shader hang on rv635 since I wrote > r600 geom code, and finally I hacked

[Mesa-dev] [PATCH] r600g: Simplify out a couple of unnecessary branches

2015-09-01 Thread Edward O'Callaghan
From: Edward O'Callaghan Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_shader.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index b7d7828..1ab389c 10

  1   2   3   4   5   6   >