Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

2018-01-19 Thread Daniel Stone
Hi, On 19 January 2018 at 16:26, Emil Velikov wrote: > On 18 January 2018 at 21:30, Dylan Baker wrote: >> I'm willing to defer to you on this, if you think that checking headers for >> ETIME is too fragile then we can leave it (you definitely have more >> experience >> in these things). I'm jus

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-09-15 Thread Daniel Stone
Hi, On 15 September 2017 at 14:30, Emil Velikov wrote: > On 15 September 2017 at 14:04, Daniel Stone wrote: >> I'd be slightly wary of this current series. Currently, both >> libwayland-server.so and libwayland-client.so define >> wl_buffer_interface separately: >&g

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-09-15 Thread Daniel Stone
Hi, On 15 September 2017 at 16:13, Emil Velikov wrote: > On 15 September 2017 at 15:13, Daniel Stone wrote: >> But if you avoid wl_resource_instance_of() and replace it with >> wl_resource_get_destroy_listener(), you can side-step the problem, by >> not relying on con

[Mesa-dev] [PATCH 1/2] i965: Fix duplication of DRI images

2017-09-19 Thread Daniel Stone
by: Daniel Stone Signed-off-by: Daniel Stone --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index ad081f0658..bc2bba00b6 100644 --- a/src/mesa/driver

[Mesa-dev] [PATCH 2/2] i965: Only set planar_format if it's actually one

2017-09-19 Thread Daniel Stone
ed-by: Daniel Stone Signed-off-by: Daniel Stone --- src/mesa/drivers/dri/i965/intel_screen.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index bc2bba00b6..8382e571e3 100644 --- a/src

[Mesa-dev] [PATCH] vulkan/wsi/wayland: Implement explicit fencing

2017-09-19 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/vulkan/Makefile.am | 10 src/vulkan/Makefile.sources | 4 +- src/vulkan/wsi/wsi_common_wayland.c | 100 ++-- 3 files changed, 110 insertions(+), 4 deletions(-) diff --git a/src/vulkan/Makefile.am b

Re: [Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

2017-09-20 Thread Daniel Stone
Hi Emil, On 19 September 2017 at 11:25, Emil Velikov wrote: > On 15 September 2017 at 16:41, Daniel Stone wrote: >> On 15 September 2017 at 16:13, Emil Velikov wrote: >>> Right, I'm looking through both functions and I'm struggling a bit. >>> Can I bother

Re: [Mesa-dev] [PATCH 2/2] i965: Only set planar_format if it's actually one

2017-09-20 Thread Daniel Stone
Hi, On 19 September 2017 at 12:10, Jason Ekstrand wrote: > On Tue, Sep 19, 2017 at 6:40 AM, Daniel Stone wrote: >> The planar_format image property was always set even for >> non-planar formats. This was breaking CCS support as >> intel_from_planar is now making sure we

Re: [Mesa-dev] [PATCH] vulkan/wsi/wayland: Stop printing out the DRM device

2017-09-22 Thread Daniel Stone
On 22 September 2017 at 12:45, Jason Ekstrand wrote: > Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl/wayland: Make wayland_drm_init declaration match the implementation

2017-09-26 Thread Daniel Stone
nstantly die when an accelerated client connected. I've pushed this revert: commit 5b7e65136440f60a6afe85c9517f42861ee07224 (fdo/master) Author: Daniel Stone Date: Fri Sep 22 15:40:59 2017 -0700 Revert "wayland-drm: constify the callbacks struct" The wayland-drm callb

Re: [Mesa-dev] [PATCH 2/4] vulkan/wsi/wayland: Stop caching Wayland displays

2017-09-27 Thread Daniel Stone
Hi, On 26 September 2017 at 23:55, Jason Ekstrand wrote: > @@ -833,24 +816,19 @@ wsi_wl_surface_create_swapchain(VkIcdSurfaceBase > *icd_surface, > chain->vk_format = pCreateInfo->imageFormat; > chain->drm_format = wl_drm_format_for_vk_format(chain->vk_format, alpha); > > - chain->disp

Re: [Mesa-dev] [PATCH 3/4] vulkan/wsi/wayland: Copy wl_proxy objects from oldSwapchain if available

2017-09-27 Thread Daniel Stone
Hi, On 26 September 2017 at 23:55, Jason Ekstrand wrote: > static void > -wsi_wl_display_destroy(struct wsi_wl_display *display) > +wsi_wl_display_ref(struct wsi_wl_display *display) > +{ > + display->refcount++; > +} Better: static struct wsi_wl_display * wsi_wl_display_ref(struct wsi_wl_dis

Re: [Mesa-dev] [PATCH 4/4] vulkan/wsi/wayland: Return better error messages

2017-09-27 Thread Daniel Stone
Good stuff; thanks for cleaning that up. Modulo my comments on 2 and 3, the series is: Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] egl/wayland: Make wayland_drm_init declaration match the implementation

2017-09-27 Thread Daniel Stone
Hi, On 27 September 2017 at 14:56, Emil Velikov wrote: > On 26 September 2017 at 21:51, Daniel Stone wrote: >> The wayland-drm callback struct is referenced, rather than duplicated, >> inside wayland-drm. Constifying this struct involved moving it on to the >>

Re: [Mesa-dev] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

2017-09-27 Thread Daniel Stone
Hi Marek, On 27 September 2017 at 15:55, Marek Olšák wrote: > if (dmabuf_ret && dmabuf_ret->val.val_bool) { >uint64_t cap; > >if (drmGetCap(sPriv->fd, DRM_CAP_PRIME, &cap) == 0 && >(cap & DRM_PRIME_CAP_IMPORT)) { > dri2ImageExtension.createImageFromFds =

[Mesa-dev] [PATCH] broadcom: Fix out-of-tree build include path

2017-09-27 Thread Daniel Stone
Cc: Eric Anholt Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.") --- src/broadcom/Makefile.cle.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/broadcom/Makefile.cle.am b/src/broadcom/Makefile.cle.am index 368826796d..1c262d0396 100644 ---

[Mesa-dev] [PATCH v2] broadcom: Fix out-of-tree build include path

2017-09-27 Thread Daniel Stone
Cc: Eric Anholt Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.") --- src/broadcom/Makefile.cle.am| 4 +++- src/gallium/drivers/vc4/Makefile.am | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/broadcom/Makefile.cle.am b/src/broadcom/Mak

Re: [Mesa-dev] XDC 2017 feedback

2017-09-28 Thread Daniel Stone
Hi, On 28 September 2017 at 03:49, Ian Romanick wrote: > On 09/27/2017 04:55 PM, Rob Clark wrote: >> Sadly by the time we were aware of the dates for the khronos f2f it >> was not possible to change the dates for XDC :-( >> >> The XDC dates were set in Feb, and afaict the khronos dates were >> an

Re: [Mesa-dev] [RFC v3 13/23] vulkan/wsi: Move linear alloc into radv

2017-09-28 Thread Daniel Stone
Hi, On 28 September 2017 at 09:10, Dave Airlie wrote: > If we get a nouveauv ever we would have to have this, so not really wanting > this. Thanks for taking a look. The reason I did this wasn't just to get it out of the WSI, but because we need it in the driver anyway. Without modifiers, it's

Re: [Mesa-dev] initial meson port

2017-09-28 Thread Daniel Stone
Hi, Sorry for the top-post but the Gmail mobile app no longer believes in inline quoting. As for installing newer Meson, that's not strictly needed. As you say, Meson deliberately doesn't have difficult or changing dependencies. It can also be run straight from a checkout without mangling $PATH or

Re: [Mesa-dev] [PATCH 7/7] wayland-egl: rework and simplify wl_egl_window initialization

2017-09-29 Thread Daniel Stone
a good idea. > > The wl_egl_window_resize() call is replaced with an explicit set of the > width/height. Thanks for doing this; series is: Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.fre

Re: [Mesa-dev] [PATCH] st/dri: don't expose modifiers in EGL if the driver doesn't implement them

2017-10-02 Thread Daniel Stone
Hi Andy, On 27 September 2017 at 20:34, Andy Furniss wrote: > Marek Olšák wrote: >> Sorry too late, I pushed it. >> >> I don't know if stable is affected. > > It regresses things starting on radeonsi using weston eg. > > mpv - > > [vo/opengl/wayland] error occurred on the display fd: closing file

[Mesa-dev] [PATCH] egl/wayland: Don't use dmabuf with no modifiers

2017-10-02 Thread Daniel Stone
The dmabuf interface requires a valid modifier to be sent. If we don't explicitly get a modifier from the driver, we can't know what to send; it must be inferred from legacy side-channels (or assumed to linear, if none exists). If we have no modifier, then we can only have a single-plane format an

Re: [Mesa-dev] [PATCH] egl/wayland: Don't use dmabuf with no modifiers

2017-10-02 Thread Daniel Stone
Hey Emil, On 2 October 2017 at 17:08, Emil Velikov wrote: > On 2 October 2017 at 16:55, Daniel Stone wrote: >> The dmabuf interface requires a valid modifier to be sent. If we don't >> explicitly get a modifier from the driver, we can't know what to send; >> it mu

[Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-02 Thread Daniel Stone
: a65db0ad1c ("st/dri: don't expose modifiers in EGL if the driver doesn't implement them") Fixes: 02cc359372 ("egl/wayland: Use linux-dmabuf interface for buffers") Reported-by: Andy Furniss Cc: Marek Olšák Signed-off-by: Daniel Stone --- src/egl/driver

[Mesa-dev] [PATCH v2 2/2] egl/wayland: Don't use dmabuf with no modifiers

2017-10-02 Thread Daniel Stone
The dmabuf interface requires a valid modifier to be sent. If we don't explicitly get a modifier from the driver, we can't know what to send; it must be inferred from legacy side-channels (or assumed to linear, if none exists). If we have no modifier, then we can only have a single-plane format an

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-02 Thread Daniel Stone
Hi Andy, On 2 October 2017 at 17:51, Andy Furniss wrote: > These are still a regression for me over git revert a65db0ad1c > > weston-simple-egl works as does mpv opengl windowed. > > The issue is that kodi or fullscreen mpv is mostly junk, IIRC from an old > bug this is to do with direct scan out

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-02 Thread Daniel Stone
On 2 October 2017 at 18:34, Daniel Stone wrote: > Marek, Michel, any ideas? Looks like the winsys buffers we create lose > all their tiling information between client and KMS. You can test it > just by running 'weston-simple-egl -f', with whatever version of > Weston, and t

Re: [Mesa-dev] [PATCH 1/2] wayland-drm: use a copy of the wayland_drm_callbacks struct

2017-10-04 Thread Daniel Stone
efore the display/surface/buffers have all been destroyed, we're screwed anyway, since the authenticate callback will still point into oblivion. So the commit message probably needs some rework. Regardless: Reviewed-by: Daniel Stone Cheers, Daniel ___ me

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-04 Thread Daniel Stone
Hi Marek, On 3 October 2017 at 17:00, Marek Olšák wrote: > On Mon, Oct 2, 2017 at 8:09 PM, Daniel Stone wrote: >> Perhaps unsurprisingly, adding __DRI_IMAGE_USE_SCANOUT to >> src/egl/drivers/dri2/platform_wayland.c in the createImage() fallback >> path (i.e. not createImag

Re: [Mesa-dev] [PATCH v2 06/12] meson: Build i965 and dri stack

2017-10-06 Thread Daniel Stone
Hi, On 5 October 2017 at 18:12, Dylan Baker wrote: > This gets pretty much the entire classic tree building, as well as > i965, including the various glapis. There are some workarounds for bugs > that are fixed in meson 0.43.0, which is due out on October 8th. I'm not really sure what prompt you

Re: [Mesa-dev] [PATCH v2 09/12] meson: build gbm

2017-10-06 Thread Daniel Stone
Hi, On 5 October 2017 at 22:22, Dylan Baker wrote: > Quoting Eric Anholt (2017-10-05 12:43:47) >> Dylan Baker writes: >> > +install_headers('main/gbm.h') >> > + >> > +pkg.generate( >> > + name : 'gbm', >> > + filebase : 'gbm', >> > + description : 'Mesa gbm library', >> > + version : meson.p

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-09 Thread Daniel Stone
Hi Marek, On 4 October 2017 at 12:38, Marek Olšák wrote: > Yeah I don't have an answer to that. I think it's better to pageflip than > blit. Can Wayland reallocate the buffer to make it displayable? If not, it > may be better to create displayable buffers always. Not sure what you mean by 'Wayla

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

2017-10-09 Thread Daniel Stone
Hi, On 9 October 2017 at 16:29, Marek Olšák wrote: > On Mon, Oct 9, 2017 at 5:22 PM, Daniel Stone wrote: >> Which is exactly the problem validateUsage() is supposed to solve. All >> we can do is rely on gbm_bo_import failing (which is best, as it can >> never be used for

Re: [Mesa-dev] [PATCH 2/4] ac/surface: add ac_surface::is_displayable

2017-10-10 Thread Daniel Stone
Hi Marek, On 9 October 2017 at 18:05, Marek Olšák wrote: > surf->is_linear = surf->u.legacy.level[0].mode == > RADEON_SURF_MODE_LINEAR_ALIGNED; > + surf->is_displayable = surf->micro_tile_mode == > RADEON_MICRO_MODE_DISPLAY || > + surf->micro_tile_mode

Re: [Mesa-dev] [PATCH 0/4] Gallium+RadeonSI: implement __DRIimageExtension::validateUsage properly

2017-10-10 Thread Daniel Stone
patches 3 and 4 are: Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: fix assert in wsi image code.

2017-10-11 Thread Daniel Stone
On 11 October 2017 at 00:47, Dave Airlie wrote: > This assert was firing just running demos. > > Jason said it should be this. Yeah, that confused me going past in a rebase the other day, but I didn't look any closer at it. Reviewed-by

Re: [Mesa-dev] [PATCH 1/2] anv: bo_cache: allow importing a BO larger than needed

2017-10-11 Thread Daniel Stone
cations") > Signed-off-by: Lionel Landwerlin Reviewed-by: Daniel Stone And 2/2 is Acked-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] include: Update GL headers from khronos opengl registry.

2017-10-11 Thread Daniel Stone
On 11 October 2017 at 18:04, Eric Anholt wrote: > Taken from their c6a99aff31874697741a08cbc8a3488606ce59c7, keeping the > BUILDING_MESA hunk in place. Both are: Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2017-01-10 Thread Daniel Stone
Hi, On 10 January 2017 at 05:49, Ben Widawsky wrote: > On 17-01-09 11:56:04, Jason Ekstrand wrote: >> Do we need to do any error checking here? Do we need to check for the >> right dri image extension version? Do we need to check queryImage != >> NULL? Do we need to check a return value? >> >>

Re: [Mesa-dev] [PATCH v2] gbm/drm: Pick the oldest available buffer in get_back_bo

2017-01-11 Thread Daniel Stone
Hey Emil, On 11 January 2017 at 16:24, Emil Velikov wrote: > On 25 November 2016 at 16:57, Emil Velikov wrote: >> Don't we want to apply this in the platform_wayland as well ? >> One thing that comes to mind is that wayland does purge the >> old/unlocked buffers via update_buffers() thus the sce

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-12 Thread Daniel Stone
Hi Ben, On 3 January 2017 at 02:36, Ben Widawsky wrote: > static uint32_t > gbm_dri_bo_get_stride(struct gbm_bo *_bo, int plane) > { > - return _bo->stride; > + struct gbm_dri_device *dri = gbm_dri_device(_bo->gbm); > + struct gbm_dri_bo *bo = gbm_dri_bo(_bo); > + __DRIimage *image; >

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-12 Thread Daniel Stone
On 12 January 2017 at 14:32, Daniel Stone wrote: > If allocated, this image is just leaked, along with its reference on > the BO. Same problem in gbm_dri_bo_get_handle_for_plane. ... and gbm_dri_bo_get_offset. Cheers, Daniel ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH 00/32] [v2] Renderbuffer Decompression (and GBM modifiers)

2017-01-12 Thread Daniel Stone
Hi Ben, On 3 January 2017 at 02:36, Ben Widawsky wrote: > Same as v1 with the requested fixes and tags added. v1 is here: > https://lists.freedesktop.org/archives/intel-gfx/2016-December/113639.html > > I haven't yet updated kmscube to use Kristian's GET_PLANE2, but I will be > doing > it this w

Re: [Mesa-dev] [PATCH] Add missing copyright header to wayland-egl-priv.h

2017-01-12 Thread Daniel Stone
Ben's work is the only copyrightable piece I can see here, so: Reviewed-by: Daniel Stone Cheers, Daniel On 12 January 2017 at 15:38, Micah Fedke wrote: > --- > src/egl/wayland/wayland-egl/wayland-egl-priv.h | 27 > ++ > 1 file changed, 27 insertions(

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2017-01-12 Thread Daniel Stone
Hi, On 10 January 2017 at 10:46, Daniel Stone wrote: > On 10 January 2017 at 05:49, Ben Widawsky wrote: >>> I ask because I genuinely don't know how this stuff is supposed to work. >>> Returning a default of 1 seems reasonable. >> >> I'm not entirel

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-12 Thread Daniel Stone
Hi, On 3 January 2017 at 02:36, Ben Widawsky wrote: > static uint32_t > gbm_dri_bo_get_stride(struct gbm_bo *_bo, int plane) > { > - return _bo->stride; > + struct gbm_dri_device *dri = gbm_dri_device(_bo->gbm); > + struct gbm_dri_bo *bo = gbm_dri_bo(_bo); > + __DRIimage *image; > +

Re: [Mesa-dev] [PATCH 08/32] gbm: Export a per plane getter for offset

2017-01-12 Thread Daniel Stone
Hi, On 3 January 2017 at 02:36, Ben Widawsky wrote: > +static uint32_t > +gbm_dri_bo_get_offset(struct gbm_bo *_bo, int plane) > +{ > + struct gbm_dri_device *dri = gbm_dri_device(_bo->gbm); > + struct gbm_dri_bo *bo = gbm_dri_bo(_bo); > + int offset = 0; > + > + if (!dri->image || dri->

Re: [Mesa-dev] [PATCH 05/32] [v2] gbm: Export a getter for per plane handles

2017-01-12 Thread Daniel Stone
Hi, On 5 January 2017 at 04:43, Ben Widawsky wrote: > diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c > index c61d56b44a..f9c1afd8cb 100644 > --- a/src/gbm/backends/dri/gbm_dri.c > +++ b/src/gbm/backends/dri/gbm_dri.c > @@ -622,6 +622,33 @@ gbm_dri_bo_get_planes(struc

Re: [Mesa-dev] [PATCH v3 2/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Daniel Stone
t; To make it cleaner to cherry-pick let's have this as 1/2. Do add the > following tag. > Cc: mesa-sta...@lists.freedesktop.org > > With the above, pre-emptively > Reviewed-by: Emil Velikov and Reviewed-by: Daniel Stone Cheers, Daniel _

Re: [Mesa-dev] [PATCH v3 1/2] egl/wayland: Avoid race conditions when on non-main thread

2017-01-13 Thread Daniel Stone
same position here, so the two initialisation functions are identical from top to the first roundtrip() call, plus the equivalent cleanup, this patch is: Reviewed-by: Daniel Stone I went through and the rest seemed fine. I would've preferred the wrapped display to be called wl_dpy and the previous

Re: [Mesa-dev] [PATCH] egl/wayland: resolve quirky try_damage_buffer() implementation

2017-01-13 Thread Daniel Stone
e API, thus we can drop the quirky solution. Works for me: Reviewed-by: Daniel Stone > One way to avoid the issue w/o bumping the requirement (for -stable) is > to add fall-back define alongside weak implementation of the functions. > The latter should "return false" and wil

Re: [Mesa-dev] [PATCH v2 1/2] egl/wayland: use the destroy_window_callback for swrast

2017-01-16 Thread Daniel Stone
; attached to already destroyed Wayland window we'll get a segfault. >> >> v2: set the correct callback alongside the window->private. (Dan) >> > Humble poke on this and 2/2 ? Both are: Reviewed-by: Daniel Stone Cheers, Daniel __

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Daniel Stone
Hi Jose, On 24 March 2017 at 14:03, Jose Fonseca wrote: > On 22/03/17 20:57, Dylan Baker wrote: >> Cross compiling for mingw is supported, and it provides a way to >> differentiate >> the build, host, and target machines [1], I've cross compiled for >> aarch64-linux-gnu, and it was trivial (I've

Re: [Mesa-dev] [RFC libdrm 0/2] Replace the build system with meson

2017-03-24 Thread Daniel Stone
Hi, On 24 March 2017 at 17:51, Eric Anholt wrote: > Dylan Baker writes: >> I also think it's worth talking to Eric (who said he's porting X to meson), >> Daniel Stone (who has patches to port weston to meson), and Peter Hutterer >> (who >> has patches t

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

2017-03-27 Thread Daniel Stone
Hey Rob, On 26 March 2017 at 14:59, Rob Clark wrote: > Figured I should figure out what this meson stuff is all about. After a > bit of hunting around to find examples to look at (and interruptions) it > took maybe ~1hr to convert (for someone who never looked at meson > before). The build spee

Re: [Mesa-dev] [PATCH kmscube 3/3] meson build support (v2)

2017-03-27 Thread Daniel Stone
On 27 March 2017 at 12:50, Rob Clark wrote: > On Mon, Mar 27, 2017 at 7:37 AM, Fabio Estevam wrote: >> gst-decoder.c:189:40: note: each undeclared identifier is reported >> only once for each function it appears in >> Makefile:613: recipe for target 'kmscube-gst-decoder.o' failed >> make: *** [km

Re: [Mesa-dev] [PATCH 4/5] vulkan/wsi/wayland: Pass damage through to the compositor

2017-04-03 Thread Daniel Stone
Hi Jason, On 1 April 2017 at 06:37, Jason Ekstrand wrote: > @@ -594,7 +595,19 @@ wsi_wl_swapchain_queue_present(struct wsi_swapchain > *wsi_chain, > > assert(image_index < chain->base.image_count); > wl_surface_attach(chain->surface, chain->images[image_index].buffer, 0, > 0); > - wl_

Re: [Mesa-dev] [PATCH 4/5] vulkan/wsi/wayland: Pass damage through to the compositor

2017-04-03 Thread Daniel Stone
Hi, On 3 April 2017 at 15:45, Jason Ekstrand wrote: > On Mon, Apr 3, 2017 at 1:54 AM, Daniel Stone wrote: >> Very scrupulous version check, but you forgot to actually use >> wl_surface_damage_buffer. ;) > > Gah!!! I'll get that fixed. Assuming that change, now that

Re: [Mesa-dev] [PATCH] egl/wayland: allow building with Wayland 1.10

2017-04-06 Thread Daniel Stone
Hi Brian, On 6 April 2017 at 19:49, Brian Paul wrote: > Fedora 24 only has Wayland 1.10, not 1.11. This change lets us build Mesa/EGL > with Wayland 1.10 on that distro. > > A new wayland-compat.h file has stubs for the wl_proxy_create_wrapper() and > wl_proxy_wrapper_destroy() functions which w

Re: [Mesa-dev] [PATCH] egl/wayland: allow building with Wayland 1.10

2017-04-06 Thread Daniel Stone
Hi Brian, On 6 April 2017 at 20:17, Daniel Stone wrote: > On 6 April 2017 at 19:49, Brian Paul wrote: >> Fedora 24 only has Wayland 1.10, not 1.11. This change lets us build >> Mesa/EGL >> with Wayland 1.10 on that distro. >> >> A new waylan

Re: [Mesa-dev] Gitlab migration

2018-05-29 Thread Daniel Stone
Hi Mark, On 26 May 2018 at 00:47, Mark Janes wrote: > Daniel Stone writes: >> We had a go at using Jenkins for some of this: Intel's been really >> quite successful at doing it internally, but our community efforts >> have been a miserable failure. After a few years I

Re: [Mesa-dev] Gitlab migration

2018-05-29 Thread Daniel Stone
Hi, On 26 May 2018 at 07:42, Marek Olšák wrote: > On Thu, May 24, 2018 at 6:46 AM, Daniel Stone wrote: >> cgit and anongit will not be orphaned: they remain as push mirrors so >> are updated simultaneously with GItLab pushes, as will the GitHub >> mirrors. Realisticall

Re: [Mesa-dev] Gitlab migration

2018-05-29 Thread Daniel Stone
Hey, On 27 May 2018 at 16:35, Rob Clark wrote: > On Sun, May 27, 2018 at 10:47 AM, Jason Ekstrand wrote: >> Given the number of people who have said they still like the mailing list, >> that's probably a discussion for another email thread. > > It would be kinda clever if gitlab could automagica

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

2018-05-29 Thread Daniel Stone
On 29 May 2018 at 15:17, Eric Engestrom wrote: > On Tuesday, 2018-05-29 09:50:46 -0400, Adam Jackson wrote: >> GL_LIB expands to GLX_mesa, but applications should not link against >> that. -lGL is never wrong, just hardcode it. > > Agreed, and Archlinux has had this patch since basically forever:

Re: [Mesa-dev] GitLab Migration: Users and Groups

2018-05-30 Thread Daniel Stone
Hey, On 30 May 2018 at 21:40, Ilia Mirkin wrote: > Given that not everyone will be a master by default, it would be good > to also set out criteria for adding and removing masters. I'm not > proposing anything heavy -- perhaps by a majority vote of the existing > masters to either add or remove s

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-05-31 Thread Daniel Stone
Hi Laura, On 30 May 2018 at 23:53, Laura Ekstrand wrote: > @@ -0,0 +1,9 @@ > +pages: > + stage: deploy > + script: > + - mkdir .public > + - cp -r docs/* .public > + - mv .public public You should be able to just write into the 'public' folder directly. It seems like creating a new di

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-05-31 Thread Daniel Stone
(dri2_surf->wl_win->attached_width != dri2_surf->wl_win->width || > + dri2_surf->wl_win->attached_height != dri2_surf->wl_win->height) { Not initialising attached_{width,height} should not cause any problems with these checks. By definition there cannot have been any buf

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-05-31 Thread Daniel Stone
Hi Eric, On 31 May 2018 at 17:13, Eric Engestrom wrote: > On Thursday, 2018-05-31 16:57:17 +0100, Daniel Stone wrote: >> Not initialising attached_{width,height} should not cause any problems >> with these checks. By definition there cannot have been any buffers >> allocate

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Daniel Stone
On 1 June 2018 at 11:10, Eric Engestrom wrote: > On Thursday, 2018-05-31 14:59:58 -0700, Jason Ekstrand wrote: >> If you could deal with Daniel's feedback and v3 just this patch sooner >> rather than later, that would be good. I'd like to merge it before we >> switch to gitlab so we can start usi

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Daniel Stone
Hi, On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: > My question then: is mandatory to call eglSwapBuffers() to ensure > wl_egl_window_get_attached_size() returns the right window size? Because I > found nothing related about this. If it is mandatory, then calling > eglSwapBuffers() in the

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

2018-06-01 Thread Daniel Stone
Hi, On 1 June 2018 at 11:23, Eric Engestrom wrote: > On Friday, 2018-06-01 11:16:29 +0100, Daniel Stone wrote: >> https://docs.gitlab.com/ee/user/project/pages/introduction.html >> > Be aware that Pages are by default branch/tag agnostic and their >> > deploymen

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-01 Thread Daniel Stone
Hi, On 1 June 2018 at 15:35, Brendan King wrote: > IMG has a similar patch to the one you describe, but without the changes to > the resize_callback, so just this bit: > > @@ -255,6 +257,12 @@ dri2_wl_create_window_surface(_EGLDriver *drv, > _EGLDisplay *disp, >goto cleanup_surf; > }

Re: [Mesa-dev] GitLab migration update

2018-06-03 Thread Daniel Stone
Hi, On 2 June 2018 at 16:45, Jason Ekstrand wrote: > My current plan (if Daniel is amenable) is to due the migration late next > week. I'm tentatively thinking Thursday morning pacific but that may change > depending on Daniel's schedule. That works for me. > When the migration happens, there

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-03 Thread Daniel Stone
Hi Laura, On 25 May 2018 at 01:27, Laura Ekstrand wrote: > When reviewing these patches, please note: > 1. This patch series does *not* touch content. Please do not bikeshed >the content of webpages here. That will be addressed in later >commits. > 2. Ple

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-04 Thread Daniel Stone
Hi Juan, On 4 June 2018 at 12:43, Juan A. Suarez Romero wrote: > On Fri, 2018-06-01 at 16:32 +0100, Daniel Stone wrote: >> I think you're right, and this needs more rework to be consistent. >> >> wl_egl_window_get_attached_size() always returns the size of the last &g

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-04 Thread Daniel Stone
Hi Dylan, On 4 June 2018 at 19:18, Dylan Baker wrote: > Quoting Daniel Stone (2018-06-03 13:19:51) >> One thing I've just remembered is that https://www.mesa3d.org/archive/ >> serves all the tarballs for Mesa releases. Given how Pages is >> structured, we don't ha

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

2018-06-04 Thread Daniel Stone
On 4 June 2018 at 19:29, Dylan Baker wrote: > Quoting Daniel Stone (2018-06-04 11:20:45) >> Is git-lfs mainly about supporting large individual files, or large >> collections of relatively small files? The tarballs aren't massive, >> there are just tons of them. If it

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-05 Thread Daniel Stone
Hi Juan, On 5 June 2018 at 09:51, Juan A. Suarez Romero wrote: > On Mon, 2018-06-04 at 13:22 +0100, Daniel Stone wrote: >> The first query will correctly return (w1,h1). The second query will >> incorrectly also return (w1,h1), even though the surface will never >> have

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-05 Thread Daniel Stone
Hi Eric, On 5 June 2018 at 17:49, Eric Engestrom wrote: > On Tuesday, 2018-06-05 09:11:58 -0700, Jason Ekstrand wrote: >> Given the discussion below, I think we'll make piglit a sub-project of >> mesa. Those who need commit access to piglit but not mesa can be added >> directly to the piglit pro

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-05 Thread Daniel Stone
On 5 June 2018 at 17:55, Eric Engestrom wrote: > On Tuesday, 2018-06-05 17:52:17 +0100, Daniel Stone wrote: >> > I assume that's now mesa, libdrm, piglit, shader-db, crucible, kmscube, >> > mesa-demos; what about igt? Anything else? >> >> We current

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Daniel Stone
Sorry, but as written this will regress ability to import NV12 images as separately-addressed planes with shader conversion to RGB; Kodi, Mutter and Weston all use this. On Wed, 6 Jun 2018, 6:48 pm Jason Ekstrand, wrote: > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Daniel Stone
Right, it's a feature we use, because we do all import them as separate EGLImages ... and we won't if it's not advertised. On Wed, 6 Jun 2018, 7:05 pm Jason Ekstrand, wrote: > On Wed, Jun 6, 2018 at 11:03 AM, Jason Ekstrand > wrote: > >> On Wed, Jun 6, 2018 at 11

Re: [Mesa-dev] [PATCH 5/7] i965/screen: Don't advertise support for RG formats

2018-06-06 Thread Daniel Stone
We definitely do, but I assume it's not been tested recently ... (Sorry about mangled formatting) On Wed, 6 Jun 2018, 8:42 pm Jason Ekstrand, wrote: > On June 6, 2018 12:37:58 Daniel Stone wrote: > >> Right, it's a feature we use, because we do all import them as separat

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-07 Thread Daniel Stone
Hi Emil, On 5 June 2018 at 18:21, Emil Velikov wrote: > On 5 June 2018 at 18:02, Daniel Stone wrote: >>>> drm-gralloc.git > Empty - please nuke, alongside bugzilla & other infra. Done. >>>> drm.git > Out of curiosity - this and others (say igt) projects

Re: [Mesa-dev] GitLab migration update

2018-06-07 Thread Daniel Stone
Hi, On 2 June 2018 at 16:45, Jason Ekstrand wrote: > When the migration happens, there will be a very brief (less than 30 > minutes?) period during which no one will be able to push to either repo. > I'll fire off an e-mail as well as messages in #dri-devel and #intel-3d > shortly before we actua

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

2018-06-19 Thread Daniel Stone
Hi Dylan, On Tue, 19 Jun 2018 at 16:42, Dylan Baker wrote: > Historical artifact. When I created the proposed branch we didn't have a > policy > of putting it on master instead of a personal repo, and we were discussing a > transition to gitlab. I also seem to remember that the gitlab doesn't all

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

2018-04-24 Thread Daniel Stone
Hi Johan, On 24 April 2018 at 09:44, Johan Helsing wrote: > If the call to dri_destroy_buffer is delayed until the next eglMakeCurrent, > that would also solve the problem (I'm not sure how that would affect other > things, though). It _must_ be: If the EGL surface surface is not current to an

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-04-30 Thread Daniel Stone
On 27 April 2018 at 16:56, Michel Dänzer wrote: > And only free no longer needed back buffers there as well. > > We want to stick to the same back buffer throughout a frame, otherwise > we can run into various issues. Thanks for dealing with this Michel! Acked-by:

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

2018-05-05 Thread Daniel Stone
On 5 May 2018 at 10:15, Mike Lothian wrote: > Out of interest can you try running the vulkan smoketest, I'm seeing this: > > smoketest > terminate called after throwing an instance of 'std::runtime_error' > what(): VkResult -101004 returned > Aborted (core dumped) VK_ERROR_OUT_OF_DATE_KHR i

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-06 Thread Daniel Stone
Hi, On 5 May 2018 at 19:07, Jason Ekstrand wrote: > On Sat, May 5, 2018 at 6:34 AM, Bas Nieuwenhuizen > wrote: >> @@ -1043,7 +1043,8 @@ x11_image_init(VkDevice device_h, struct >> x11_swapchain *chain, >> uint32_t bpp = 32; >> >> if (chain->base.use_prime_blit) { >> - result = wsi_

Re: [Mesa-dev] [PATCH] vulkan/wsi: Only use LINEAR modifier for prime if supported.

2018-05-08 Thread Daniel Stone
.2" > CC: 18.1 > CC: Abel Garcia Dorta > CC: Daniel Stone Acked-by: Daniel Stone Reviewed-by: Jason Ekstrand Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Gitlab migration

2018-05-24 Thread Daniel Stone
Hi all, I'm going to attempt to interleave a bunch of replies here. On 23 May 2018 at 20:34, Jason Ekstrand wrote: > The freedesktop.org admins are trying to move as many projects and services > as possible over to gitlab and somehow I got hoodwinked into spear-heading > it for mesa. There are a

Re: [Mesa-dev] Gitlab migration

2018-05-24 Thread Daniel Stone
Hi, On 24 May 2018 at 11:46, Daniel Stone wrote: > It _is_ possible to bend Jenkins to your will - Mark's excellent and > super-helpful work with Intel's CI is testament to that - and in some > environments it's fine, but after a few years of trying, I just don't &g

Re: [Mesa-dev] Gitlab migration

2018-05-24 Thread Daniel Stone
Hi, On 24 May 2018 at 02:23, Jason Ekstrand wrote: > On Wed, May 23, 2018 at 5:49 PM, Jordan Justen > wrote: >> Another project I'm involved with had a contingency that swore >> github's "issues" were completely inadequate compared to bugzilla, >> which is to say that I don't think there is cons

Re: [Mesa-dev] [PATCH 01/16] Added ci yaml file for Gitlab.

2018-05-25 Thread Daniel Stone
Hi Eric, On 25 May 2018 at 12:15, Eric Engestrom wrote: > If I'm misunderstanding gitlab-ci and this is running one the same > filesystem as the website, then you'll need to `rm -r public` before the > move, otherwise `mv .public public` will not do what you want :) It's always run in a fresh co

Re: [Mesa-dev] [PATCH mesa] egl: add helper to combine two u32 into one u64

2018-08-21 Thread Daniel Stone
ver treated as signed. Might be worth a note in the commit about signedness. Reviewed-by: Daniel Stone Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH libdrm] Add basic CONTRIBUTING file

2018-08-22 Thread Daniel Stone
On Wed, 22 Aug 2018 at 11:51, Daniel Vetter wrote: > +See the gitlab project owners for contact details of the libdrm maintainers. Think this should be 'See MAINTAINERS' ... ? The rest looks good to me, though I would encourage linking to Patchwork so people can find patches from others, as well

Re: [Mesa-dev] [PATCH 3/3] i965/screen: Allow modifiers on sRGB formats

2018-08-31 Thread Daniel Stone
ts[i].fourcc == __DRI_IMAGE_FOURCC_SARGB > > > || > > > + intel_image_formats[i].fourcc == __DRI_IMAGE_FOURCC_SABGR) > > > + return false; > > > > > > > This should be a continue. Fixed locally. > > With that, the series is > Reviewed-by: Eric Engestrom ... and also: Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] egl/wayland: do not leak wl_buffer when it is locked

2018-08-31 Thread Daniel Stone
nlock only or free wl_buffer too (Daniel) > > This also fixes dEQP-EGL.functional.swap_buffers_with_damage.* tests. Thanks Juan! Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

<    1   2   3   4   5   6   7   8   9   >