Patches #1, #2, #5, #7 are Reviewed-by: Christian König
Patch #3 the csc_matrix need a better name since we now store more and
more additional info in there, but that can as well be a follow up patch.
Patch #4 is Acked-by: Christian König
Patch #6 I think there was a simpler option for
Am 07.02.19 um 15:21 schrieb James Zhu:
On 2019-02-07 4:49 a.m., Christian König wrote:
Patches #1, #2, #5, #7 are Reviewed-by: Christian König
Patch #3 the csc_matrix need a better name since we now store more and
more additional info in there, but that can as well be a follow up patch
Indeed nice cleanup, I wonder if that helps with our current problem as
well. But allocation failures are printed in dmesg as well, aren't they?
Anyway patches are Acked-by: Christian König
Regards,
Christian.
On 10.09.2015 19:56, Marek Olšák wrote:
Hi,
I have realized that if we fa
From: Boyuan Zhang
Signed-off-by: Boyuan Zhang
Reviewed-by: Christian König
---
src/gallium/state_trackers/va/picture.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/state_trackers/va/picture.c
b/src/gallium/state_trackers/va/picture.c
index 9b94b39..eda7204 100644
--- a
From: Boyuan Zhang
Signed-off-by: Boyuan Zhang
Reviewed-by: Christian König
---
src/gallium/drivers/radeon/radeon_uvd.c | 6 ++
src/gallium/drivers/radeon/radeon_video.c | 5 +
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeon/radeon_uvd.c
b
On 23.09.2015 17:34, Matt Turner wrote:
Should these patches go to the stable branch as well?
Good point, most likely yes.
Thanks,
Christian.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-
Hi Grigori,
On 23.09.2015 19:46, Grigori Goronzy wrote:
Hi,
On 23.09.2015 10:11, Christian König wrote:
From: Boyuan Zhang
Signed-off-by: Boyuan Zhang
Reviewed-by: Christian König
---
Thanks, nice to see this finally getting fixed, and it was a pretty
simple thing after all... well, not
On 01.10.2015 05:44, Michel Dänzer wrote:
On 01.10.2015 04:11, Marek Olšák wrote:
From: Marek Olšák
This can cause incorrect address calculations and hangs.
v2: do it properly
Cc: mesa-sta...@lists.freedesktop.org
Tested-and-Reviewed-by: Christian König
---
src/gallium/drivers/radeonsi
On 04.01.2016 23:31, Julien Isorce wrote:
From: Julien Isorce
The counter was not set but used by the nouveau driver.
It is required otherwise visual output is garbage.
Signed-off-by: Julien Isorce
Reviewed-by: Christian König
---
src/gallium/state_trackers/va/picture.c| 8
Am 18.12.2015 um 16:04 schrieb Emil Velikov:
On 16 December 2015 at 20:14, Christian König wrote:
@@ -174,6 +175,51 @@ static VAStatus vlVaPostProcBlit(vlVaDriver *drv,
vlVaContext *context,
return VA_STATUS_SUCCESS;
}
+static struct pipe_video_buffer *
+vlVaApplyDeint(vlVaDriver
Am 11.01.2016 um 20:55 schrieb Marek Olšák:
On Mon, Jan 11, 2016 at 8:00 PM, Rob Clark wrote:
On Mon, Jan 11, 2016 at 1:52 PM, Marek Olšák wrote:
On Mon, Jan 11, 2016 at 6:07 PM, Rob Clark wrote:
Quite possibly I am.. although wouldn't I still have the same issue
with other state trackers?
From: Christian König
Only enable it when we compile the state tracker as well.
Signed-off-by: Christian König
---
configure.ac | 1 +
src/mesa/state_tracker/st_extensions.c | 2 ++
src/mesa/state_tracker/st_vdpau.c | 6 ++
3 files changed, 9 insertions
eeded. Let's say a distro builds
with vdpau and everything else enabled, but then ships the libraries
separately...
On Thu, Jan 21, 2016 at 11:05 AM, Christian König
wrote:
From: Christian König
Only enable it when we compile the state tracker as well.
Signed-off-by: Chris
at.
Thanks
Emil
On 21 January 2016 at 21:02, Christian König wrote:
Advertising NV_vdpau_interop while the backend for the driver isn't
installed is fine, cause this only means that the OpenGL side has support
for it.
Mesa doesn't have a runtime dependency on libvdpau and to initialize
NV
Am 22.01.2016 um 19:24 schrieb Ilia Mirkin:
On Fri, Jan 22, 2016 at 1:15 PM, Christian König
wrote:
Form autofoo perspective things look great.
Thanks, that exactly what I wanted to know.
Although I second Ilia's concern - we need a form of runtime detection
here. Pretty much all di
ed to stable branches, because
released versions of xf86-video-amdgpu unnecessarily try to map the
front buffer)
Signed-off-by: Michel Dänzer
For those two Reviewed-by: Christian König .
---
src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
Am 01.02.2016 um 17:09 schrieb Leo Liu:
The scaling lsit should be filling out with zig zag scan
Cc: "11.0 11.1"
Signed-off-by: Leo Liu
---
src/gallium/state_trackers/omx/vid_dec_h264.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/src/gallium/st
ather than on each loop iter?
Also (and more importantly) it appears like you forgot to add
vl_zscan_normal_16?
patch 1 is sent, not sure why it haven't arrived.
Yeah, patch #1 arrived a bit later for me as well. No idea why.
I think we can leave optimizing the away which list to use to
(-)
Good catch, patch is Reviewed-by: Christian König
Do you have commit access or should I push it?
Thanks,
Christian.
diff --git a/src/gallium/state_trackers/vdpau/surface.c
b/src/gallium/state_trackers/vdpau/surface.c
index 0550141..d418d56 100644
--- a/src/gallium/state_trackers/vdpau/surface.c
Am 30.03.2016 um 06:36 schrieb Dieter Nützel:
Hello Christian,
after all this new VDPAU stuff, I get after ages (months/years) only
black window with
mplayer -vo vdpau /data/Filme/test.mkv
on r600, NI, Turks XT.
Switching between full screen and window mode ('F') the innner (black)
window pa
From: Christian König
Similar to radeonsi linear layout should work for all not compressed
or depth/stencil formats. Fixes issues with VDPAU on r600.
Signed-off-by: Christian König
---
src/gallium/drivers/r600/evergreen_state.c | 5 +
src/gallium/drivers/r600/r600_state.c | 5
Yeah, thinking about this since I've seen Michels response this morning.
The only major thing which is different is the TLB pressure, e.g. VRAM
is allocated continuously and so you can work much more with setting the
fragmentation flag in the VM page tables.
If you have a system to test this
cache _shouldn't_ be used, just use the cache always.
Cc: Christian König
Nice catch. Patch is Reviewed-by: Christian König
Christian.
---
src/gallium/drivers/r600/r600_uvd.c | 2 +-
src/gallium/drivers/radeon/radeon_video.c | 4 ++--
src/gallium/drivers/radeon/radeon_video.
From: Christian König
They are not firmware version dependent.
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/radeon_vce.c| 38 ++
src/gallium/drivers/radeon/radeon_vce.h| 7 +
src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 32
From: Christian König
v2: make this also compatible with original released firmware
v3 (chk): switch to original idea of separate files for fw versions
Signed-off-by: Leo Liu
Signed-off-by: Christian König
Reviewed-by: Alex Deucher (v2)
---
src/gallium/drivers/radeon/Makefile.sources | 1
it.
Thanks a lot for doing this, patch is Reviewed-by: Christian König
---
configure.ac | 15 ---
src/gallium/auxiliary/Makefile.am| 23
src/gallium/auxiliary/Makefile.sources | 39 +--
? E.g. what we might want to do is providing
Ubuntu/Debian packages with only the AMD drivers compiled into a
specialized dri_radeon.so etc...
The patch itself looks good to be, but I'm not an expert on automake. So
it is Acked-by: Christian König
---
src/gallium/drivers/r300/Automak
libva.so.1
Don't mean to come as rude, but did you even build the series ? It seems
to be failing on my system.
On 24/09/14 18:46, Leo Liu wrote:
From: Christian König
This patch adds a skeleton VA-API state tracker,
which is filled with live in the subsequent patches.
v2: fixes in conf
How about assuming for each CS that it can use the compute ring and as
soon as we submit a PM4 command that can only be executed on the
graphics ring note that this CS needs to be executed on the graphics ring?
Just an idea,
Christian.
Am 25.09.2014 um 21:02 schrieb Tom Stellard:
On Mon, Sep
Am 28.09.2014 um 22:13 schrieb Ilia Mirkin:
On Sun, Sep 28, 2014 at 4:09 PM, Emil Velikov wrote:
On 28/09/14 20:08, Emil Velikov wrote:
On 28/09/14 19:04, Ilia Mirkin wrote:
On Sun, Sep 28, 2014 at 1:35 PM, Emil Velikov wrote:
[snip]
This, however, has nothing to do with mesa. When I set -
Am 02.10.2014 um 19:34 schrieb Marek Olšák:
From: Marek Olšák
This fixes a crash when exiting Firefox. I have really no idea how Firefox
does it. It seems to involve multiple contexts and multithreading.
That looks to me like we now release all sampler views with the current
context and not
Am 03.10.2014 um 03:53 schrieb Ilia Mirkin:
On Thu, Oct 2, 2014 at 7:59 PM, Emil Velikov wrote:
On 02/10/14 06:41, Ilia Mirkin wrote:
On Mon, Sep 29, 2014 at 8:33 PM, Emil Velikov wrote:
On 29/09/14 17:24, Matt Turner wrote:
On Mon, Sep 29, 2014 at 9:16 AM, Emil Velikov wrote:
So all in a
Am 02.10.2014 um 22:37 schrieb Alex Deucher:
On Thu, Oct 2, 2014 at 1:51 PM, Christian König wrote:
Am 02.10.2014 um 19:34 schrieb Marek Olšák:
From: Marek Olšák
This fixes a crash when exiting Firefox. I have really no idea how Firefox
does it. It seems to involve multiple contexts and
1 schrieb Ilia Mirkin:
On Mon, Oct 6, 2014 at 11:31 AM, Emil Velikov wrote:
On 05/10/14 01:26, Ilia Mirkin wrote:
On Fri, Oct 3, 2014 at 3:43 AM, Christian König wrote:
Am 03.10.2014 um 03:53 schrieb Ilia Mirkin:
On Thu, Oct 2, 2014 at 7:59 PM, Emil Velikov
wrote:
On 02/10/14 06:41, Ilia
Am 07.10.2014 um 15:07 schrieb Ilia Mirkin:
On Tue, Oct 7, 2014 at 9:04 AM, Christian König wrote:
Am 07.10.2014 um 03:11 schrieb Ilia Mirkin:
I'm under the assumption that OMX/etc don't do anything ridiculous. If
they do, it's a bug just like this vdpau situation, and should
From: Christian König
Signed-off-by: Christian König
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index bef5753..59b90e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1806,9 +1806,9 @@ dnl Directory for VA libs
From: Christian König
Signed-off-by: Christian König
---
configure.ac | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index bc589b7..c37018f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1794,16 +1794,13 @@ AC_ARG_WITH([vdpau-libdir
From: Christian König
We don't have GALLIUM_STATE_TRACKERS_DIRS any more.
Signed-off-by: Christian König
---
configure.ac | 1 -
1 file changed, 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index c37018f..bef5753 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1438,7 +1
From: Christian König
This reverts commit bbe6f7f865cd4316b5f885507ee0b128a20686eb.
Signed-off-by: Christian König
---
configure.ac | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/configure.ac b/configure.ac
index 680dff4..bc589b7 100644
--- a/configure.ac
From: Michael Varga
This patch cleans the function handleVASliceDataBufferType() for better
readability.
v2 (chk): minor commit message changes
Signed-off-by: Michael Varga
Signed-off-by: Christian König
---
src/gallium/state_trackers/va/picture.c | 75 ++---
1
Am 07.10.2014 um 15:19 schrieb Ilia Mirkin:
On Tue, Oct 7, 2014 at 9:13 AM, Christian König wrote:
Am 07.10.2014 um 15:07 schrieb Ilia Mirkin:
On Tue, Oct 7, 2014 at 9:04 AM, Christian König
wrote:
Am 07.10.2014 um 03:11 schrieb Ilia Mirkin:
I'm under the assumption that OMX/etc don
Reviewed-by: Christian König
On 20.03.2015 14:59, Jose Fonseca wrote:
Fixes MSVC
warning C4090: '=' : different 'const' qualifiers
---
src/mesa/state_tracker/st_vdpau.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st
From: Christian König
The data in memory is in big endian format and needs to be converted
into CPU byte order. So the patch actually reversed what needs to be done.
Signed-off-by: Christian König
---
src/gallium/auxiliary/vl/vl_vlc.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion
if (enc->use_vui)
+ enc->vui = vui;
We should set the callback independent of whether or not it is used,
after all that is just a vtbl.
With that fixed this patch and #1 in this series is Reviewed-by:
Christian König .
Regards,
Christian.
enc->encode = e
Questions for VDPAU should probably go to either the Mesa list or the
VDPAU list, libva is completely unrelated to this.
Well is it possible that you just locked up the GPU? Please take a look
at /sys/kernel/debug/dri/0/radeon_fence_info and dmesg.
Regards,
Christian.
Am 18.02.2016 um 23:43
Am 25.02.2016 um 17:54 schrieb Marek Olšák:
From: Marek Olšák
Clearly a good idea. Patch is Reviewed-by: Christian König
---
src/gallium/drivers/radeonsi/si_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_debug.c
b/src
From: Christian König
The hardware simply doesn't support that correctly.
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/radeon_video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeon/radeon_video.c
b/src/gallium/drivers/radeon/radeon_vi
From: Christian König
For exporting a specific layer of an array texture.
Signed-off-by: Christian König
---
src/gallium/include/state_tracker/drm_driver.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/gallium/include/state_tracker/drm_driver.h
b/src/gallium/include
Hi everyone,
the following series of patches define and implement an new DMA-Buf based
interface for interop between VDPAU and OpenGL in Mesa.
The basic idea is that we want to be independent of the source code versions
used in both and so avoid using Mesa internal structures for the interop.
I
From: Christian König
Add layer support to export individual array layers.
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/r600_texture.c | 1 +
src/gallium/drivers/radeon/radeon_winsys.h| 1 +
src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 2 ++
src/gallium/winsys
From: Christian König
Works around a bug in radeonsi and tiling is actually
not very beneficial in this use case.
Signed-off-by: Christian König
---
src/gallium/state_trackers/vdpau/output.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/vdpau
From: Christian König
Linear layout should work for all formats as well.
Signed-off-by: Christian König
---
src/gallium/drivers/radeonsi/si_state.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index
From: Christian König
We are going to need that in the Mesa state tracker as well.
Signed-off-by: Christian König
---
src/gallium/include/state_tracker/vdpau_funcs.h | 65
src/gallium/state_trackers/vdpau/bitmap.c| 2 +-
src/gallium/state_trackers/vdpau
From: Christian König
We are going to need this for EGL_EXT_image_dma_buf_import.
Signed-off-by: Christian König
---
src/gallium/include/state_tracker/drm_driver.h| 5 +
src/gallium/state_trackers/dri/dri2.c | 2 ++
src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 1
From: Christian König
Avoid using internal structures from another API.
Signed-off-by: Christian König
---
src/mesa/state_tracker/st_vdpau.c | 176 --
1 file changed, 129 insertions(+), 47 deletions(-)
diff --git a/src/mesa/state_tracker/st_vdpau.c
b/src
From: Christian König
Use DMA-buf for the VDPAU interop interface instead of using
internal structures.
Signed-off-by: Christian König
---
src/gallium/include/state_tracker/vdpau_dmabuf.h | 94 +++
src/gallium/include/state_tracker/vdpau_interop.h | 7 +-
2 files changed
From: Christian König
That should allow us to get away from passing internal structures around.
Signed-off-by: Christian König
---
src/gallium/state_trackers/vdpau/ftab.c | 6 ++-
src/gallium/state_trackers/vdpau/output.c| 40 +-
src/gallium/state_trackers/vdpau
From: Christian König
Add offset support to handle NV12 offsets as well.
Signed-off-by: Christian König
---
src/gallium/drivers/r300/r300_texture.c | 6 +++---
src/gallium/drivers/radeon/r600_texture.c | 26 ++
src/gallium/drivers/radeon/radeon_winsys.h
That configuration can't work correctly.
With HDMI the audio data is interleaved in the video vertical and
horizontal sync periods. So if you don't have video you don't have any
way to submit audio either.
What the driver properly does is providing a dummy video signal so that
audio can be t
The only of hand "hack" I can see is to open up an HDMI connector,
shortcut the hot plug detection pin and then connect that as "output
device" to the amplifier.
It should fix your issues with the hot plug detection. You most likely
still won't get a valid EDID, but that can be overridden easi
Nouveau needs to be tested first, I have doubts that this will work out
of the box for them as well.
Christian.
Am 10.03.2016 um 11:42 schrieb Marek Olšák:
Reviewed-by: Marek Olšák
Why do we still need the gallium codepath?
Marek
On Tue, Mar 8, 2016 at 1:21 PM, Christian König wrote
Am 09.03.2016 um 15:53 schrieb Marek Olšák:
On Wed, Mar 9, 2016 at 4:54 AM, Michel Dänzer wrote:
On 08.03.2016 21:21, Christian König wrote:
From: Christian König
Linear layout should work for all formats as well.
The hardware actually doesn't support linear e.g. for compressed forma
Ups, yeah that's a rebase problem. Sorry for not compiling R300 once more.
Patch is Reviewed-by: Christian König
Regards,
Christian.
Am 17.03.2016 um 16:49 schrieb Brian Paul:
Fixes compilation error since 5aea0d691.
---
src/gallium/drivers/r300/r300_texture.c | 2 +-
1 file chang
From: Christian König
We support 5.1 for a while now.
Signed-off-by: Christian König
---
src/gallium/drivers/radeon/radeon_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/radeon_video.c
b/src/gallium/drivers/radeon/radeon_video.c
index
main CE IB instead, which makes the problem go away.
Just a guess, but does commit 9f8fb5a2b339ba83493991ca8f1173a939a696d3
in Alex drm-next-4.7 tree helps with the problem?
commit 9f8fb5a2b339ba83493991ca8f1173a939a696d3
Author: Christian König
Date: Fri May 6 14:52:57 2016 +0200
Am 26.05.2016 um 11:27 schrieb Andy Furniss:
Alex Deucher wrote:
On Wed, May 25, 2016 at 10:57 AM, Christian König
wrote:
From: Christian König
We support 5.1 for a while now.
Resend as the last one didn't have the CCs.
I know (well think) vdpau doesn't really mention 5.2 any
Am 27.05.2016 um 15:16 schrieb Emil Velikov:
On 27 May 2016 at 11:28, Christian König wrote:
Am 26.05.2016 um 11:27 schrieb Andy Furniss:
Alex Deucher wrote:
On Wed, May 25, 2016 at 10:57 AM, Christian König
wrote:
From: Christian König
We support 5.1 for a while now.
Resend as the
From: Christian König
We support 5.2 for a while now.
v2: we even support 5.2 for H264, 5.1 is for HEVC.
Signed-off-by: Christian König
Cc:
---
src/gallium/drivers/radeon/radeon_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon
Am 28.05.2016 um 00:45 schrieb Andy Furniss:
Emil Velikov wrote:
On 27 May 2016 at 15:40, Christian König
wrote:
No, what I'm saying is that it is a number and not an enum.
This way you don't need to change the specification when you want to
support
a new level.
That's
Am 31.05.2016 um 03:24 schrieb Eric Engestrom:
CoverityID: 1337953
Signed-off-by: Eric Engestrom
---
Note that I do not know this code at all; I'm blindly following Coverity's
advice on this one :]
Well and that is completely nonsense. The buffer was already reallocated
when this error hap
buf) {
- surf->templat.buffer_format = old_surf_format;
pipe_mutex_unlock(drv->mutex);
return VA_STATUS_ERROR_ALLOCATION_FAILED;
}
surf->buffer->destroy(surf->buffer);
surf->buffer = tmp_buf;
+ surf->templat.buffer_format =
eeds to be fixed instead.
Christian.
Am 31.05.2016 um 14:51 schrieb Christian König:
Yeah, that solution looks more correct to me.
Christian.
Am 31.05.2016 um 14:44 schrieb Julien Isorce:
Hi,
Thx for looking at it but are you sure your diff compiles ?
Can you try this instead:
--- a/s
Am 02.06.2016 um 08:41 schrieb Nayan Deshmukh:
Check for null pointer before accessing arrays in get/put bits
native/YCbCr/Indexed in VdpOutputSurface and VdpVideoSurface.
Signed-off-by: Nayan Deshmukh
Reviewed and pushed.
Thanks for the help,
Christian.
---
src/gallium/state_trackers/vd
Am 07.06.2016 um 13:28 schrieb Nayan Deshmukh:
Apply the luma key filter to the YCbCr values during the CSC conversion
in video buffer shader. The initial values of max and min luma are set
to opposite values to disable the filter initially and will be set when
enabling it.
Signed-off-by: Nayan
Am 07.06.2016 um 14:19 schrieb Mathieu Malaterre:
On Tue, Jun 7, 2016 at 8:05 AM, Mathieu Malaterre wrote:
Hi Alex,
On Mon, Jun 6, 2016 at 7:20 PM, Alex Deucher wrote:
On Mon, Jun 6, 2016 at 1:16 PM, Marek Olšák wrote:
[+ dri-devel]
On Mon, Jun 6, 2016 at 8:42 AM, Mathieu Malaterre wrote
Am 07.06.2016 um 19:42 schrieb Nayan Deshmukh:
Apply the luma key filter to the YCbCr values during the CSC conversion
in video buffer shader. The initial values of max and min luma are set
to opposite values to disable the filter initially and will be set when
enabling it.
Add extra parmeters m
Am 02.06.2016 um 16:00 schrieb Julien Isorce:
In order to do zero-copy between two different devices
the memory should not be tiled.
This is currently no way to set pipe_resource template's flag
from pipe_video_buffer template. So disabled_tiling is added.
Choosed "disable" prefix so that CALLO
Am 02.06.2016 um 16:03 schrieb Julien Isorce:
Instead of changing the format on the existing template
which makes error handling not nice and confuses coverity.
CoverityID: 1337953
Signed-off-by: Julien Isorce
Reviewed-by: Christian König
---
src/gallium/state_trackers/va/image.c | 8
Am 02.06.2016 um 16:03 schrieb Julien Isorce:
Signed-off-by: Julien Isorce
Actually I'm not sure if that is correct.
If you release the VABuffer of an exported resource you won't be able to
properly close the handle with vlVaReleaseBufferHandle().
On the other hand the semantic VA requires
With the type fixed both patches are Reviewed-by: Christian König
If there aren't any more objections I'm going to push the patches now.
Regards,
Christian.
Am 08.06.2016 um 11:28 schrieb Michel Dänzer:
AFAIK the term is "luma keying"
I'm clearly not deep enough into VA-API to judge if that is correct or
not, but it sounds sane to me.
So feel free to add an Acked-by: Christian König
on the patch.
Cheers,
Christian.
Am 08.06.2016 um 13:13 schrieb Julien Isorce:
Hi Christian,
Thx for the review.
pipe_resource_refe
Am 08.06.2016 um 14:20 schrieb Julien Isorce:
On 8 June 2016 at 09:16, Christian König <mailto:deathsim...@vodafone.de>> wrote:
Am 02.06.2016 um 16:00 schrieb Julien Isorce:
In order to do zero-copy between two different devices
the memory should not
ted to say with my comment back then.
Regards,
Christian.
On 8 June 2016 at 14:07, Christian König <mailto:deathsim...@vodafone.de>> wrote:
Am 08.06.2016 um 14:20 schrieb Julien Isorce:
On 8 June 2016 at 09:16, Christian König mailto:deathsim...@vodafone.de>> wrote:
From: Christian König
We had the CSC code twice in there, factor it out into a separate function.
Signed-off-by: Christian König
---
src/gallium/auxiliary/vl/vl_compositor.c | 76 +---
1 file changed, 41 insertions(+), 35 deletions(-)
diff --git a/src/gallium
From: Christian König
Signed-off-by: Christian König
---
src/gallium/state_trackers/vdpau/query.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/state_trackers/vdpau/query.c
b/src/gallium/state_trackers/vdpau/query.c
index a279ad3..912bf97 100644
--- a/src/gallium
Hi guys,
Two minor things I've noticed after pushing the original patches.
The first one is that we only changed the function for progressive frames in
the compositor. Add luma keying for interlaced frames as well.
The second issue is that we have forgotten to claim support for lumakeying now.
@@ vl_video_buffer_template(struct pipe_resource *templ,
templ->bind = PIPE_BIND_SAMPLER_VIEW | PIPE_BIND_RENDER_TARGET;
templ->usage = usage;
+ if (tmpl->bind)
The "if" here is probably superfluous.
With that fixed the patch is Reviewed-by: Christian König
.
Regards,
Christian.
Am 14.06.2016 um 22:14 schrieb Boyuan Zhang:
Signed-off-by: Boyuan Zhang
As I said before please drop this change as it is unrelated to
supporting encoding with VA-API and we need to find a conclusion on how
to handle things first.
Christian.
---
src/gallium/drivers/radeon/radeon_vce.h
Am 14.06.2016 um 22:14 schrieb Boyuan Zhang:
Signed-off-by: Boyuan Zhang
---
src/gallium/include/pipe/p_video_state.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/gallium/include/pipe/p_video_state.h
b/src/gallium/include/pipe/p_video_state.h
index d353be6..d519d17
Am 14.06.2016 um 22:14 schrieb Boyuan Zhang:
Signed-off-by: Boyuan Zhang
We need to find an interface that works both for OpenMAX as well as
VA-API and not implement a separate interface for each state tracker.
So I would suggest to implement the logic to provide the reference
picture list
Please split that up into multiple parts. E.g. adding the config
structure, new image format support etc..
Julien, can you take a look as well if you have time and work a bit with
Boyuan to get this cleaned up?
Thanks in advance,
Christian.
Am 14.06.2016 um 22:14 schrieb Boyuan Zhang:
Signe
Really nice work. I now understand where your problem is with the scaled
surface.
Please see the further comments below.
Am 16.06.2016 um 20:15 schrieb Nayan Deshmukh:
v2: fix a typo and add a newline to code
Signed-off-by: Nayan Deshmukh
---
src/gallium/state_trackers/vdpau/mixer.c
Clearly a good idea to move this into common code, but there is just one
important thing you are missing here.
We intentional export the *_winsys_create() in the created libraries to
have only one global file descriptor for all libraries. See the
following files as well:
src/gallium/targets/v
s for the review.
I don't understand the compositor code fully yet. How can I create a
unscaled image with it?
Regards,
Nayan.
On Fri, Jun 17, 2016 at 9:15 PM, Christian König
mailto:deathsim...@vodafone.de>> wrote:
Really nice work. I now understand where your problem is wit
Am 20.06.2016 um 16:13 schrieb Rob Herring:
On Mon, Jun 20, 2016 at 8:31 AM, Nicolai Hähnle wrote:
On 17.06.2016 21:05, Rob Herring wrote:
On Fri, Jun 17, 2016 at 1:45 PM, Emil Velikov
wrote:
On 17 June 2016 at 18:45, Rob Herring wrote:
Now that the pipe-loader is reference counting the sc
Am 20.06.2016 um 17:39 schrieb Rob Herring:
On Mon, Jun 20, 2016 at 9:27 AM, Christian König
wrote:
Am 20.06.2016 um 16:13 schrieb Rob Herring:
On Mon, Jun 20, 2016 at 8:31 AM, Nicolai Hähnle
wrote:
On 17.06.2016 21:05, Rob Herring wrote:
On Fri, Jun 17, 2016 at 1:45 PM, Emil Velikov
Am 21.06.2016 um 15:53 schrieb Rob Herring:
On Mon, Jun 20, 2016 at 1:15 PM, Christian König
wrote:
Am 20.06.2016 um 17:39 schrieb Rob Herring:
On Mon, Jun 20, 2016 at 9:27 AM, Christian König
wrote:
Am 20.06.2016 um 16:13 schrieb Rob Herring:
On Mon, Jun 20, 2016 at 8:31 AM, Nicolai
Am 21.06.2016 um 16:50 schrieb Boyuan Zhang:
Signed-off-by: Boyuan Zhang
Please move that patch to the end of the series. E.g. implement the
existing interface first, then add the new one and make the changes to
support the new one.
Regards,
Christian.
---
src/gallium/include/pipe/p_vi
Am 21.06.2016 um 16:50 schrieb Boyuan Zhang:
Signed-off-by: Boyuan Zhang
---
src/gallium/drivers/radeon/radeon_vce.c| 171 +++
src/gallium/drivers/radeon/radeon_vce.h| 1 +
src/gallium/drivers/radeon/radeon_vce_52.c | 447 +++--
3 files changed, 533
Am 21.06.2016 um 21:21 schrieb Nayan Deshmukh:
use bicubic filtering as high quality scaling L1.
v2: fix a typo and add a newline to code
v3: -render the unscaled image on a temporary surface (Christian)
-apply noise reduction and sharpness filter on
unscaled surface
-render the
801 - 900 of 1819 matches
Mail list logo
