Re: [Mesa-dev] [PATCH] winsys/radeon: (trivial) rename variable for consistency

2016-10-05 Thread Christian König
Am 05.10.2016 um 05:51 schrieb Alexandre Demers: Signed-off-by: Alexandre Demers I don't mind getting this straight, but are we really using "offset" instead of "off" all over the place? Anyway this one is Reviewed-by: Christian König . Regards, Christian.

Re: [Mesa-dev] [PATCH 1/5] st/va: Return more useful config attributes

2016-10-13 Thread Christian König
Am 13.10.2016 um 00:52 schrieb Mark Thompson: The encoder attributes are needed for a user of the encoder to be able to configure it sensibly without internal knowledge. Reviewed-by: Christian König for the whole series. Do you have commit access? Regards, Christian. --- src/gallium

Re: [Mesa-dev] [PATCH 1/5] st/va: Return more useful config attributes

2016-10-14 Thread Christian König
Am 13.10.2016 um 11:06 schrieb Mark Thompson: On 13/10/16 08:20, Christian König wrote: Am 13.10.2016 um 00:52 schrieb Mark Thompson: The encoder attributes are needed for a user of the encoder to be able to configure it sensibly without internal knowledge. Reviewed-by: Christian König for

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-08 Thread Christian König
Hi Nayan, ok let's take a step back and put the lanczos filtering aside for a moment. I have another task for you which is more urgent right now. The order we do things in vlVdpVideoMixerRender() was never 100% correct, so we have at least three problems here which needs fixing: 1) The nois

Re: [Mesa-dev] [PATCH] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Christian König
Am 08.08.2016 um 22:10 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header I see where the problem is, but the fix is incorrect. You always search for the emulation prevention three byte even when the previous fill has done so already. So it

[Mesa-dev] [PATCH] st/omx/dec/h264: pass default scaling lists in raster format

2016-08-09 Thread Christian König
From: Indrajit Das --- src/gallium/state_trackers/omx/vid_dec_h264.c | 40 +-- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/gallium/state_trackers/omx/vid_dec_h264.c b/src/gallium/state_trackers/omx/vid_dec_h264.c index bc7feaa..10f2959 100644 ---

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-09 Thread Christian König
stian. Am 08.08.2016 um 16:32 schrieb Nayan Deshmukh: Hi Christian, I am more than happy to solve these problems, the Lanczos filtering was getting a little stale anyway because I was not able to reproduce the problems Andy was facing. On Mon, Aug 8, 2016 at 6:24 PM, Christian

Re: [Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Christian König
Am 09.08.2016 um 15:56 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/g

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Christian König
Am 09.08.2016 um 15:47 schrieb Nicolai Hähnle: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa repository at src/gallium/winsys/amdgpu/drm

Re: [Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Christian König
Am 09.08.2016 um 17:18 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/auxiliary/vl/vl_rbsp.h | 14 -- 1 fi

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-09 Thread Christian König
Am 09.08.2016 um 19:21 schrieb Nayan Deshmukh: Hi Christian, A few questions. On Tue, Aug 9, 2016 at 5:10 PM, Christian König mailto:deathsim...@vodafone.de>> wrote: I am more than happy to solve these problems, the Lanczos filtering was getting a little stale anyway b

Re: [Mesa-dev] [PATCH v2 00/16] radeonsi: improve handling of temporary arrays

2016-08-11 Thread Christian König
Am 11.08.2016 um 11:29 schrieb Nicolai Hähnle: On 10.08.2016 23:36, Marek Olšák wrote: On Wed, Aug 10, 2016 at 9:23 PM, Nicolai Hähnle wrote: Hi, this is a respin of the series which scans the shader's TGSI to determine which channels of an array are actually written to. Most of the st/mesa

Re: [Mesa-dev] [PATCH] st/omx/dec/h264: pass default scaling lists in raster format

2016-08-11 Thread Christian König
Leo, could you take a look, test and/or review this? If you don't have time just say so and I'm going to give it a try. Regards, Christian. Am 09.08.2016 um 11:54 schrieb Christian König: From: Indrajit Das --- src/gallium/state_trackers/omx/vid_dec_h

Re: [Mesa-dev] [PATCH] st/vdpau: change the order in which filters are applied

2016-08-11 Thread Christian König
Am 11.08.2016 um 16:27 schrieb Nayan Deshmukh: Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers

Re: [Mesa-dev] [PATCH] st/vdpau: change the order in which filters are applied

2016-08-12 Thread Christian König
Am 11.08.2016 um 17:12 schrieb Nayan Deshmukh: Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. It is good practice to put a v1,v2 etc... after the commit mes

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-16 Thread Christian König
Am 12.08.2016 um 16:02 schrieb Nayan Deshmukh: Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. v2: apply the filters on all the surfaces (Christian) v3: use g

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-16 Thread Christian König
Am 16.08.2016 um 19:50 schrieb Nayan Deshmukh: Hi Christian, On Tue, Aug 16, 2016 at 11:02 PM, Christian König wrote: Am 16.08.2016 um 19:29 schrieb Nayan Deshmukh: Hi Andy, Thanks for testing. On Tue, Aug 16, 2016 at 9:14 PM, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Andy, You

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-16 Thread Christian König
Am 16.08.2016 um 19:29 schrieb Nayan Deshmukh: Hi Andy, Thanks for testing. On Tue, Aug 16, 2016 at 9:14 PM, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Andy, You are right :( It messes up chroma but only in case of sharpen at least for me. Retested and denoise is also affected for me.

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-17 Thread Christian König
Top and Bottom field are separated in this representation. So you got a maximum of 3 planes multiplied by two fields. Regards, Christian. Am 17.08.2016 um 11:11 schrieb Andy Furniss: Nayan Deshmukh wrote: Sorry for the misleading language. What I meant was that the filter should only be app

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-19 Thread Christian König
ters by checking the width and height of surfaces respectively. The chroma artifacts are still present, different from the initial ones. Any suggestion for the fixup? I tried debugging, but I think I am missing something. Regards, Nayan. On Wed, Aug 17, 2016 at 2:59 PM, Andy Furniss wrote: Chris

Re: [Mesa-dev] [PATCH 0/2] st/va: minor clean-ups

2016-08-20 Thread Christian König
Reviewed-by: Christian König for both. Regards, Christian. Am 20.08.2016 um 18:14 schrieb Kai Wasserbäch: Hey, just noticed a duplicate call to context->decoder->end_frame() while looking through the recent changes. This is just a trivial clean-up and no functional change is intende

Re: [Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

2016-08-23 Thread Christian König
Am 21.08.2016 um 23:11 schrieb Eric Engestrom: Fixes: c59628d11b134fc01638 ("st/va: enable dual instances encode by sync surface") Signed-off-by: Eric Engestrom Reviewed-by: Christian König Do you have commit access? Regards, Christian. --- src/gallium/state_trackers/va/sur

Re: [Mesa-dev] [PATCH] vl/rbsp: fix another three byte not detected

2016-08-23 Thread Christian König
tly don't have the time to double check that, but it sounds reasonable to me. So patch is Acked-by: Christian König . Cheers, Christian. --- src/gallium/auxiliary/vl/vl_rbsp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_rbsp.h b/sr

Re: [Mesa-dev] [PATCH 0/2] st/va: minor clean-ups

2016-08-24 Thread Christian König
I've just pushed both. Thanks for the help, Christian. Am 23.08.2016 um 16:39 schrieb Kai Wasserbäch: Hey Boyuan, hey Christian, Zhang, Boyuan wrote on 22.08.2016 22:52: Thanks for cleaning up the codes. The duplicated end_frame and unused variable are due to the new patch submitted last Frid

Re: [Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

2016-08-24 Thread Christian König
Am 22.08.2016 um 22:59 schrieb Eric Engestrom: On Mon, Aug 22, 2016 at 09:44:59AM +0200, Christian König wrote: Am 21.08.2016 um 23:11 schrieb Eric Engestrom: Fixes: c59628d11b134fc01638 ("st/va: enable dual instances encode by sync surface") Signed-off-by: Eric Engestrom R

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

2016-08-25 Thread Christian König
. But since the interpolation that would occur in matrix filter would use the nearest neighbor so I tried to do it using linear interpolation and the artifacts were reduced but still, there were minor artifacts. Regards, Nayan. On Fri, Aug 19, 2016 at 5:57 PM, Christian König wrote: Hi Nayan, d

[Mesa-dev] [PATCH] st/vdpau: Revert "change the order in which filters are applied(v3)"

2016-08-26 Thread Christian König
From: Christian König This reverts commit 09dff7ae2e179d5a3490481762c6bd3d50430c9f. Turned out this can cause some artifacts in the output. Let's revert it for now until we have sorted out all issues. Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/mixer.c

Re: [Mesa-dev] [PATCH] st/vdpau: use temporary buffers while applying filters

2016-08-26 Thread Christian König
Am 26.08.2016 um 07:51 schrieb Nayan Deshmukh: We use temporary buffers so that we don't read and write to the same surface at the same time. We don't need to use linear layout now. Signed-off-by: Nayan Deshmukh Looks really good to me, can you rebase this on the revert of the earlier patch

Re: [Mesa-dev] [PATCH v2] st/vdpau: use temporary buffers while applying filters

2016-08-29 Thread Christian König
Am 26.08.2016 um 11:53 schrieb Nayan Deshmukh: Use temporary buffers so that we don't read and write to the same surface at the same time. We don't need to use linear layout now. v2: rebase the patch against reverted change Signed-off-by: Nayan Deshmukh Reviewed, tested and pushed. Thanks f

Re: [Mesa-dev] [PATCH v2] st/vdpau: use temporary buffers while applying filters

2016-08-29 Thread Christian König
er than delayed rendering to render directly to the surface? Also, I will need some direction to get started. Regards, Nayan. On Mon, Aug 29, 2016 at 3:26 PM, Christian König wrote: Am 26.08.2016 um 11:53 schrieb Nayan Deshmukh: Use temporary buffers so that we don't read and write to the same

[Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v4

2016-08-31 Thread Christian König
From: Nayan Deshmukh v2: avoid dividing by zero when calculating lanczos v4 (chk): rebase on master Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_lanczos_filter.c | 445 +++ src/gallium/auxiliary/vl/v

[Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-08-31 Thread Christian König
From: Nayan Deshmukh HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_L7 uses lanczos filter with number representing the size of the sinc window. v3: avoid L8 and L9 to allow for other scaling algrithms v4 (chk): rebased on master Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/v

[Mesa-dev] Lanczos filter V4

2016-08-31 Thread Christian König
Hi Nayan, picking this topic up once more. Following this mail are your patches rebased on top of current master. I also played around with them a bit. One bug I've found which should also be reproducible for you is when switching mpv from windowed to fullscreen and back the video seems to become

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Christian König
Am 01.09.2016 um 05:28 schrieb Michel Dänzer: On 31/08/16 06:53 PM, Nayan Deshmukh wrote: Hi Christian, You missed a few things in the merge. I will send in the updated patch. I looked at the code in vl_winsys.c and vl_winsys3.c and also at the code in presentation.c where delayed rendering is

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-01 Thread Christian König
Am 02.09.2016 um 04:03 schrieb Michel Dänzer: On 02/09/16 10:17 AM, Michel Dänzer wrote: On 02/09/16 12:58 AM, Leo Liu wrote: On 09/01/2016 11:54 AM, Nayan Deshmukh wrote: I saw the code in dri3_glx.c and I could somewhat relate some basic code structure to the vl_winsys_dri3.c. But I am new t

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-02 Thread Christian König
Am 02.09.2016 um 15:27 schrieb Leo Liu: On 09/02/2016 02:11 AM, Christian König wrote: Am 02.09.2016 um 04:03 schrieb Michel Dänzer: On 02/09/16 10:17 AM, Michel Dänzer wrote: On 02/09/16 12:58 AM, Leo Liu wrote: On 09/01/2016 11:54 AM, Nayan Deshmukh wrote: I saw the code in dri3_glx.c

Re: [Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v4

2016-09-02 Thread Christian König
Am 02.09.2016 um 16:10 schrieb Leo Liu: On 09/02/2016 09:50 AM, Christian König wrote: Am 02.09.2016 um 15:27 schrieb Leo Liu: On 09/02/2016 02:11 AM, Christian König wrote: Am 02.09.2016 um 04:03 schrieb Michel Dänzer: On 02/09/16 10:17 AM, Michel Dänzer wrote: On 02/09/16 12:58 AM

Re: [Mesa-dev] [PATCH] st/omx/dec: set dst rect to match src size

2016-09-03 Thread Christian König
Leo Liu Reviewed-by: Christian König . --- src/gallium/state_trackers/omx/vid_dec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/omx/vid_dec.c b/src/gallium/state_trackers/omx/vid_dec.c index 069899a..90f435b 100644 --- a/src/gal

Re: [Mesa-dev] [PATCH 0/7] omx hevc decode support

2016-09-06 Thread Christian König
The whole series is Acked-by: Christian König . I tried to look closer into it, but I only have two hands and one head. Regards, Christian. Am 31.08.2016 um 15:51 schrieb Leo Liu: This set implements hevc decode for omx, it includes basic structures from h264 implementation and hevc specific

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-06 Thread Christian König
Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: On Mon, Sep 5, 2016 at 2:48 AM, Michel Dänzer wrote: On 05/09/16 04:37 AM, Ilia Mirkin wrote: On Tue, Mar 8, 2016 at 7:21 AM, Christian König wrote: @@ -80,7 +82,7 @@ vlVdpOutputSurfaceCreate(VdpDevice device, res_tmpl.depth0 = 1

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-06 Thread Christian König
Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: On Tue, Sep 6, 2016 at 2:22 PM, Christian König wrote: Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: On Mon, Sep 5, 2016 at 2:48 AM, Michel Dänzer wrote: On 05/09/16 04:37 AM, Ilia Mirkin wrote: On Tue, Mar 8, 2016 at 7:21 AM, Christian König

Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

2016-09-07 Thread Christian König
:) Patch is Reviewed-by: Christian König . Leo do you want to push it or should I take care of this? Regards, Christian. --- src/gallium/state_trackers/va/config.c | 2 +- src/gallium/state_trackers/va/picture.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-07 Thread Christian König
Am 07.09.2016 um 17:36 schrieb Ilia Mirkin: On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: On 07/09/16 04:19 AM, Christian König wrote: Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: On Tue, Sep 6, 2016 at 2:22 PM, Christian König wrote: Am 06.09.2016 um 16:23 schrieb Ilia Mirkin: On

Re: [Mesa-dev] [PATCH 09/10] st/vdpau: implement the new DMA-buf based interop

2016-09-07 Thread Christian König
Am 07.09.2016 um 18:06 schrieb Marek Olšák: On Wed, Sep 7, 2016 at 5:36 PM, Ilia Mirkin wrote: On Wed, Sep 7, 2016 at 4:08 AM, Michel Dänzer wrote: On 07/09/16 04:19 AM, Christian König wrote: Am 06.09.2016 um 21:05 schrieb Ilia Mirkin: On Tue, Sep 6, 2016 at 2:22 PM, Christian König

Re: [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

2016-09-08 Thread Christian König
eo/x-raw, format=NV12 ! vaapisink Signed-off-by: Julien Isorce Tested-by: Víctor Manuel Jáquez Leal Reviewed-by: Christian König . But somebody should double check if that doesn't break transcoding for AMD GPUs. We had some problems with that in the past. Regards, Christian. ---

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU

2016-09-08 Thread Christian König
Am 08.09.2016 um 08:23 schrieb Michel Dänzer: On 08/09/16 01:13 PM, Nayan Deshmukh wrote: On Thu, Sep 8, 2016 at 9:03 AM, Michel Dänzer mailto:mic...@daenzer.net>> wrote: On 08/09/16 02:48 AM, Nayan Deshmukh wrote: > use a linear buffer in case of back buffer > > Signed-off-b

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU

2016-09-08 Thread Christian König
Am 08.09.2016 um 10:42 schrieb Michel Dänzer: On 08/09/16 05:05 PM, Christian König wrote: Am 08.09.2016 um 08:23 schrieb Michel Dänzer: On 08/09/16 01:13 PM, Nayan Deshmukh wrote: On Thu, Sep 8, 2016 at 9:03 AM, Michel Dänzer mailto:mic...@daenzer.net>> wrote: On 08/09/16 02

Re: [Mesa-dev] [PATCH] vl/dri3: handle the case of different GPU

2016-09-09 Thread Christian König
Am 09.09.2016 um 03:38 schrieb Michel Dänzer: On 08/09/16 05:59 PM, Christian König wrote: Am 08.09.2016 um 10:42 schrieb Michel Dänzer: On 08/09/16 05:05 PM, Christian König wrote: Am 08.09.2016 um 08:23 schrieb Michel Dänzer: On 08/09/16 01:13 PM, Nayan Deshmukh wrote: On Thu, Sep 8, 2016

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

2016-09-12 Thread Christian König
Am 12.09.2016 um 15:01 schrieb Marek Olšák: On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: Support multi-planar YUV for external EGLImage's (currently just in the dma-buf import path) by lowering to multiple texture fetch's for each plane and CSC in shader. Signed-off-by: Rob Clark --- s

Re: [Mesa-dev] [PATCH] st/va: force to flush the last p frame in idr period

2016-10-18 Thread Christian König
this is committed. https://bugs.freedesktop.org/show_bug.cgi?id=98005 Yeah, add a line like "Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=98005";. With that done the patch is Reviewed-by: Christian König . Regards, Christian. Alex Signed-off-by: Boyuan Zhang --- s

Re: [Mesa-dev] [PATCH] st/va: set default rt formats when calling vaCreateConfig

2016-10-18 Thread Christian König
tribs[i].type = VASurfaceAttribPixelFormat; > attribs[i].value.type = VAGenericValueTypeInteger; > attribs[i].flags = VA_SURFACE_ATTRIB_GETTABLE | VA_SURFACE_ATTRIB_SETTABLE; > Actual code LGTM

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

2016-10-18 Thread Christian König
Am 18.10.2016 um 11:19 schrieb Andy Furniss: boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it if the user space doesn't set baseline? I don't know how in gstreamer as it seems to try to use b-fra

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

2016-10-18 Thread Christian König
Am 18.10.2016 um 15:42 schrieb Andy Furniss: Andy Furniss wrote: Christian König wrote: Am 18.10.2016 um 11:19 schrieb Andy Furniss: boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it i

Re: [Mesa-dev] Delayed rendering in st/vdpau

2016-10-24 Thread Christian König
Hi Thomas, that's just an optimization. DRI2 can't send buffers allocated by the client to the X server for displaying, e.g. all allocations must be done by X. So in the simple case of just rendering directly into the output buffer without any advanced filters I just delayed the rendering un

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

2016-10-24 Thread Christian König
Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function without checking if it's available or not. Keep in mind that we possible compile both D

Re: [Mesa-dev] [PATCH 09/24] radeon/vce: use nblk_y instead of npix_y

2016-10-25 Thread Christian König
Am 25.10.2016 um 00:33 schrieb Marek Olšák: From: Marek Olšák npix_y will be removed. level[0].npix_y will be removed too. nblk_y should be the same as npix_y if the block height == 1. However, nblk_y is aligned to the tile size, so it can be greater than npix_y. Mhm, what if block_height is

Re: [Mesa-dev] [PATCH] radeon/vce Handle H.264 level 5.2

2016-10-25 Thread Christian König
explicit "case 52:" here as well just for documentation purposes. With that fixed the patch is Reviewed-by: Christian König . Regards, Christian. dpb = 184320; break; ___ mesa-dev mailing lis

Re: [Mesa-dev] [PATCH] st/omx/enc Raise default encode level

2016-10-25 Thread Christian König
Am 25.10.2016 um 00:46 schrieb Andy Furniss: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281 Signed-off-by: Andy Furniss Reviewed-by: Christian König . --- src/gallium/state_trackers/omx/vid_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH 09/24] radeon/vce: use nblk_y instead of npix_y

2016-10-25 Thread Christian König
Am 25.10.2016 um 12:18 schrieb Marek Olšák: On Tue, Oct 25, 2016 at 9:32 AM, Christian König wrote: Am 25.10.2016 um 00:33 schrieb Marek Olšák: From: Marek Olšák npix_y will be removed. level[0].npix_y will be removed too. nblk_y should be the same as npix_y if the block height == 1

Re: [Mesa-dev] mesa-dev is failing to bounce some mails

2016-10-27 Thread Christian König
Am 27.10.2016 um 13:14 schrieb Emil Velikov: On 27 October 2016 at 12:06, Andres Gomez wrote: On Wed, 2016-10-26 at 19:35 +0300, Andres Gomez wrote: Hi, recently, we have noticed that we are not receiving some of the mails that we have sent to the ML. The mails are archived, though, but we d

Re: [Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

2016-10-31 Thread Christian König
, Oct 1, 2016 at 1:57 PM, Christian König mailto:deathsim...@vodafone.de>> wrote: Am 01.10.2016 um 00:06 schrieb Marek Olšák: On Fri, Sep 30, 2016 at 11:23 PM, Dave Airlie mailto:airl...@gmail.com>> wrote: On 1 October 2016 at 06:11, Marek Olšá

Re: [Mesa-dev] [PATCH] st/mesa: fix the layer of VDPAU surface samplers

2016-11-04 Thread Christian König
Am 03.11.2016 um 22:06 schrieb Nicolai Hähnle: From: Nicolai Hähnle A latent bug in VDPAU interop was exposed by commit e5cc84dd43be066c1dd418e32f5ad258e31a150a. Before that commit, the st_vdpau code created samplers with first_layer == last_layer == 1 that the general texture handling code wo

Re: [Mesa-dev] [PATCH] st/mesa: fix the layer of VDPAU surface samplers

2016-11-04 Thread Christian König
Am 04.11.2016 um 10:11 schrieb Nicolai Hähnle: On 04.11.2016 09:47, Christian König wrote: Am 03.11.2016 um 22:06 schrieb Nicolai Hähnle: From: Nicolai Hähnle A latent bug in VDPAU interop was exposed by commit e5cc84dd43be066c1dd418e32f5ad258e31a150a. Before that commit, the st_vdpau code

Re: [Mesa-dev] [PATCH v2] st/mesa: fix the layer of VDPAU surface samplers

2016-11-04 Thread Christian König
thing, adding the layer_override to make the non-DMABUF case work. v2: add the layer_override Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98512 Cc: 13.0 Cc: Christian König Cc: Ilia Mirkin Reviewed-by: Christian König . -- This fixes the problem on radeon, but it would be good

Re: [Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

2016-11-05 Thread Christian König
Am 04.11.2016 um 17:43 schrieb Marek Olšák: On Fri, Nov 4, 2016 at 5:23 PM, Alex Deucher wrote: On Fri, Nov 4, 2016 at 10:57 AM, Marek Olšák wrote: On Nov 4, 2016 3:29 PM, "Emil Velikov" wrote: On 31 October 2016 at 15:12, Marek Olšák wrote: First, DRI_PRIME should work OK on radeon & amd

Re: [Mesa-dev] [st/omx/dec/h264] Handing negative POC

2016-11-24 Thread Christian König
Hi, patch is Reviewed-by: Christian König . Regards, Christian. Am 24.11.2016 um 07:57 schrieb Namburu, Chandu-babu: Hi , I have been working on an issue where the for a particular stream playback is stuttering and there are lot of frame drops. That particular stream has negative POC

[Mesa-dev] [PATCH 2/2] st/va: flush pipeline after post processing

2016-11-28 Thread Christian König
From: sguttula This will flush the pipeline,which will allow to share dma-buf based buffers. Signed-off-by: Suresh Guttula Reviewed-by: Christian König --- src/gallium/state_trackers/va/postproc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/va/postproc.c b

[Mesa-dev] [PATCH 1/2] gallium: Moving X11 dependencies under HAVE_PLATFORM_X11

2016-11-28 Thread Christian König
From: sguttula This patch will exclude X11 dependencies from gallium video driver for freon based platforms which dont use X11 Signed-off-by: Guttula, Suresh Reviewed-by: Christian König --- src/gallium/auxiliary/Makefile.am | 7 +++ src/gallium/auxiliary/Makefile.sources | 4

Re: [Mesa-dev] [PATCH 2/2] st/va: flush pipeline after post processing

2016-11-29 Thread Christian König
Am 29.11.2016 um 14:46 schrieb Nicolai Hähnle: On 28.11.2016 15:51, Christian König wrote: From: sguttula This will flush the pipeline,which will allow to share dma-buf based buffers. Signed-off-by: Suresh Guttula Reviewed-by: Christian König Why is there no fence? Relying on the

Re: [Mesa-dev] [PATCH 2/2] st/va: flush pipeline after post processing

2016-11-29 Thread Christian König
Am 29.11.2016 um 15:06 schrieb Nicolai Hähnle: On 29.11.2016 14:50, Christian König wrote: Am 29.11.2016 um 14:46 schrieb Nicolai Hähnle: On 28.11.2016 15:51, Christian König wrote: From: sguttula This will flush the pipeline,which will allow to share dma-buf based buffers. Signed-off-by

Re: [Mesa-dev] [PATCH 2/2] st/va: flush pipeline after post processing

2016-11-29 Thread Christian König
Am 29.11.2016 um 15:28 schrieb Nicolai Hähnle: On 29.11.2016 15:12, Christian König wrote: Am 29.11.2016 um 15:06 schrieb Nicolai Hähnle: On 29.11.2016 14:50, Christian König wrote: Am 29.11.2016 um 14:46 schrieb Nicolai Hähnle: On 28.11.2016 15:51, Christian König wrote: From: sguttula

Re: [Mesa-dev] [PATCH 1/2] st/va: force to submit two consecutive single jobs

2016-12-02 Thread Christian König
rate control calculation. Adjust the number of i/p frame remaining accordingly. v2: fixed regression issues introduced by previous version Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=98005 Signed-off-by: Boyuan Zhang Acked-by: Christian König . for the series. --- src/ga

Re: [Mesa-dev] [PATCH 1/3] st/va: automake: cleanup C{PP,}FLAGS

2016-12-02 Thread Christian König
Am 02.12.2016 um 17:26 schrieb Emil Velikov: From: Emil Velikov Remove some transitional left overs from the gallium pipe-loader rework and kill off unneeded AM_CPPFLAGS. Signed-off-by: Emil Velikov Reviewed-by: Christian König . --- src/gallium/state_trackers/va/Makefile.am | 12

Re: [Mesa-dev] [PATCH] st/vdpau: fix compiler warning in vlVdpVideoMixerRender

2016-12-05 Thread Christian König
Am 05.12.2016 um 06:25 schrieb Nayan Deshmukh: Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König . --- src/gallium/state_trackers/vdpau/mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/mixer.c b/src/gallium

[Mesa-dev] [PATCH] vl/zscan: fix "Fix trivial sign compare warnings"

2016-12-14 Thread Christian König
From: Christian König The variable actually needs to be signed, otherwise converting it to a float doesn't work as expected. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=98914 Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_zscan.c | 2 +- 1 file changed, 1 inse

Re: [Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

2016-12-15 Thread Christian König
Am 15.12.2016 um 15:07 schrieb Emil Velikov: On 15 December 2016 at 13:57, Nayan Deshmukh wrote: I send out the wrong series, the earlier one. I am sending the v2. I am not sure of the reason as to why it was returning a bool anyways. So I was hoping that someone could point out the reason.

Re: [Mesa-dev] [PATCH 1/4] vl: add h264 constrained baseline profile

2016-12-22 Thread Christian König
Am 20.12.2016 um 23:27 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang Signed-off-by: Boyuan Zhang Reviewed-by: Christian König for the whole series. --- src/gallium/auxiliary/util/u_video.h | 1 + src/gallium/include/pipe/p_video_enums.h | 1 + 2 files changed, 2 insertions

Re: [Mesa-dev] [PATCH 1/5] st/xvmc: use goto to make code more readable (v2)

2016-12-22 Thread Christian König
Am 16.12.2016 um 12:58 schrieb Nayan Deshmukh: v2: add missing semicolon Signed-off-by: Nayan Deshmukh Patch #2-#4 are Reviewed-by: Christian König . For patch #1 and #5 I'm a bit hesitated to add them without testing. XvMC isn't widely used any more, but we should still try to

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: use bicubic filter for scaling(v6.1)

2016-06-29 Thread Christian König
Am 29.06.2016 um 15:24 schrieb Nayan Deshmukh: use bicubic filtering as high quality scaling L1. v2: fix a typo and add a newline to code v3: -render the unscaled image on a temporary surface (Christian) -apply noise reduction and sharpness filter on unscaled surface -render the

Re: [Mesa-dev] [PATCH 2/3] st/omx: add support for nouveau / interlaced

2016-06-29 Thread Christian König
Am 29.06.2016 um 14:46 schrieb Leo Liu: On 06/28/2016 05:07 AM, Christian König wrote: Hi Leo, nice catch patch is Reviewed-by: Christian König . But we still need to fix transcoding issue with interlaced as true. Our transcode support tunneling, basic the decode buffer will be used

Re: [Mesa-dev] [PATCH] radeon uvd add uvd fw version for amdgpu

2016-06-29 Thread Christian König
Am 29.06.2016 um 18:35 schrieb Alex Deucher: On Wed, Jun 29, 2016 at 11:38 AM, Leo Liu wrote: From: sonjiang Signed-off-by: sonjiang Cc: "12.0" For the series: Reviewed-by: Alex Deucher Reviewed-by: Christian König as well. Christian. --- src/gallium/driv

Re: [Mesa-dev] [PATCH 1/2] radeon/vce: check alignment for dpb buffer

2016-06-30 Thread Christian König
Am 29.06.2016 um 21:53 schrieb Leo Liu: This will make safer for not acrossing the boundary Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vce.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/dri

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

2016-07-01 Thread Christian König
Am 01.07.2016 um 13:14 schrieb Emil Velikov: Hi all, On 29 June 2016 at 20:20, Christian König wrote: Am 29.06.2016 um 18:35 schrieb Alex Deucher: On Wed, Jun 29, 2016 at 11:38 AM, Leo Liu wrote: From: sonjiang Signed-off-by: sonjiang Cc: "12.0" For the series: Reviewe

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Christian König
Hi Boyuan, as Emil wrote as well try to add some commit messages to the set. For this patch something like the following should do it: Allow to specify more parameters in the encoding interface which where previously just hardcoded in the encoder. Additional to that we need to reorder the p

Re: [Mesa-dev] [PATCH 04/12] st/va: use correct pitch value for deriveimage call

2016-07-01 Thread Christian König
Am 30.06.2016 um 20:30 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/image.c | 55 --- 1 file changed, 51 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_trackers/va/im

Re: [Mesa-dev] [PATCH 05/12] st/va: add nv12 i420 yv12 format to deriveimage call

2016-07-01 Thread Christian König
Am 30.06.2016 um 20:30 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang That only works by coincident correctly, the buffer only contains a reference to the first texture plane and not all of them. So vlVaMapBuffer() won't be able to come up with something reasonable for other planes. A

Re: [Mesa-dev] [PATCH 06/12] st/va: colorspace conversion when image is yv12 and surface is nv12

2016-07-01 Thread Christian König
Am 30.06.2016 um 20:30 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/image.c | 48 +-- 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_trackers/va/im

Re: [Mesa-dev] [PATCH 08/12] st/va: add functions for VAAPI encode

2016-07-01 Thread Christian König
Am 30.06.2016 um 20:30 schrieb Boyuan Zhang: Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/buffer.c | 6 + src/gallium/state_trackers/va/picture.c| 170 - src/gallium/state_trackers/va/va_private.h | 3 + 3 files changed, 177 insertion

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Christian König
Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now. I see the new options are now in radeon_vce_52.c whereas before radeo

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-01 Thread Christian König
Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don'

Re: [Mesa-dev] [PATCH 1/2] radeon/vce: increase cpb height alignment

2016-07-04 Thread Christian König
Am 04.07.2016 um 17:46 schrieb Leo Liu: Height should be aligned with 2 macroblocks, thus making safer for tiled mode Signed-off-by: Leo Liu For both patches Reviewed-by: Christian König . --- src/gallium/drivers/radeon/radeon_vce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-07-05 Thread Christian König
Am 01.07.2016 um 18:18 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first

[Mesa-dev] [PATCH 3/4] radeon/uvd: fix contex buffer destruction in the error path

2016-07-07 Thread Christian König
From: Christian König Destroying a not allocated buffer is harmless. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon

[Mesa-dev] [PATCH 4/4] radeon/uvd: simplify sending context buffer message

2016-07-07 Thread Christian König
From: Christian König Just send it whenever it is allocated. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c

[Mesa-dev] [PATCH 1/4] radeon/video: fix coding style in radeon_video.c

2016-07-07 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_video.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_video.c b/src/gallium/drivers/radeon/radeon_video.c index 5b29c78..69e4416

[Mesa-dev] [PATCH 2/4] radeon/uvd: move polaris fw check into radeon_video.c

2016-07-07 Thread Christian König
From: Christian König It's actually not very clever to claim to support H.264 and then fail to create a decoder. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c | 8 src/gallium/drivers/radeon/radeon_video.c | 16 +--- 2 files change

Re: [Mesa-dev] [PATCH 1/4] radeon/video: fix coding style in radeon_video.c

2016-07-07 Thread Christian König
Am 07.07.2016 um 15:51 schrieb Aaron Watry: On Thu, Jul 7, 2016 at 4:57 AM, Christian König mailto:deathsim...@vodafone.de>> wrote: From: Christian König mailto:christian.koe...@amd.com>> Signed-off-by: Christian König mailto:christian.koe...@amd.com>> --

Re: [Mesa-dev] [PATCH 2/4] radeon/uvd: move polaris fw check into radeon_video.c

2016-07-07 Thread Christian König
Am 07.07.2016 um 15:33 schrieb Leo Liu: On 07/07/2016 05:57 AM, Christian König wrote: From: Christian König It's actually not very clever to claim to support H.264 and then fail to create a decoder. Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_uvd.c

Re: [Mesa-dev] [PATCH 1/4] vl/compositor: move weave shader out from rgb weaving

2016-07-11 Thread Christian König
er in a header file. But that's only a minor cleanup we can do later on as well. The patches are Acked-by: Christian König either way. Regards, Christian. --- src/gallium/auxiliary/vl/vl_compositor.c | 157 --- src/gallium/auxiliary/vl/vl_compositor.h |

Re: [Mesa-dev] [PATCH mesa] vl: fix memory leak

2016-07-13 Thread Christian König
Good catch, since we need only 16 offsets I think we could simply allocate it on the stack as well. Or am I missing something? Regards, Christian. Am 13.07.2016 um 00:02 schrieb Eric Engestrom: CovID: 1363008 Signed-off-by: Eric Engestrom --- src/gallium/auxiliary/vl/vl_bicubic_filter.c |

<    1   2   3   4   5   6   7   8   9   10   >