Looks good. Thanks for the quick fix.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, July 11, 2017 2:02 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: fix texture swizzle writemasking
Commit
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, July 12, 2017 9:28 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: move comment, declaration in
svga_init_shader_key_common()
put the comment
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, July 12, 2017 9:28 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] draw: s/unsigned/enum tgsi_semantic/
---
src/gallium/auxiliary/draw
Series looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, December 7, 2017 2:25:05 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende; Roland Scheidegger
Subject: [PATCH 2/2] gallium/util: don't p
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Saturday, December 23, 2017 9:13:47 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: fix TGSI_TEXTURE_SHADOW1D coordinate selection
Fixes
For this series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Sunday, December 24, 2017 2:40:28 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: use tgsi_util_get_shadow_ref_src_index() in a couple
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, December 28, 2017 8:19:24 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: check for null fs pointer in update_samplers()
This can happen when
Looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, December 28, 2017 11:09:34 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee
Subject: [PATCH] svga: update SVGA_NEW_ flags for updating sampler state
The
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, October 3, 2017 1:04:16 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 4/4] util: include string.h in u_string.h
To fix MinGW compiler
Looks good to me.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, April 6, 2017 11:49 AM
To: mesa-dev@lists.freedesktop.org
Cc: Jose Fonseca; Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: remove pre-SVGA3D_HWVERSION_WS8_B1 code
3D
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, June 14, 2018 8:13:01 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] st/mesa: add missing switch cases in
glsl_to_tgsi_visitor::visit()
To silence
With this patch, _ElementSize is initialized along with the rest
of the vertex array attributes in new_draw_rasterpos_stage().
This fixes a crash in st_pipe_vertex_format() when running
topogun-1.06-orc-84k-resize trace file with VMware svga driver.
---
src/mesa/state_tracker/st_cb_rasterpos.c | 5
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, April 30, 2018 7:42 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] tgsi: use enums instead of unsigned in ureg code
---
src/gallium/auxiliary/tgsi
Looks good.
Also verified that the workaround fixes the crashes that are seen with VMware
svga driver due to this bug.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, May 8, 2018 7:43:49 AM
To: mesa-dev@lists.freedesktop.org
Cc: Matt Turner
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, February 28, 2018 7:29 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: fix blending regression
The earlier Mesa commit 3d06c8afb5 ("st/mesa:
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, January 25, 2018 8:48:00 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee; Roland Scheidegger
Subject: [PATCH 3/3] mesa: whitespace fixes in varray.h
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, January 25, 2018 10:38:51 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: s/Bool/SVGA3dBool/ in SVGA3dDevCapResult
And fix whitespace. To sync up
For this series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, January 30, 2018 7:36:27 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: use opcode local var to simplify some code
---
src
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, January 30, 2018 7:36:43 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] st/mesa: whitespace, formatting fixes in
st_glsl_to_tgsi.cpp
>From: Brian Paul
>Sent: Wednesday, February 14, 2018 1:15 PM
>To: mesa-dev@lists.freedesktop.org
>Cc: Charmaine Lee; Neha Bhende
>Subject: [PATCH 1/3] svga: call tgsi_scan_shader() for dummy shaders
>If we fail to compile the normal VS or FS we fall back to a simple/
>dumm
For patch 2 and 3, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, February 14, 2018 1:15:14 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 3/3] svga: move duplicated code for setting fillmode/flatshade
Looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, February 14, 2018 6:57:21 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: call tgsi_scan_shader() for dummy shaders
If we fail to
Looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, February 15, 2018 8:31:12 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: replace gotos with else clauses
Simple clean-up.
---
src
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, February 16, 2018 12:59:28 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: replaced 'unsigned' with proper enum types in shader code
---
s
Change series looks good.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, March 1, 2017 6:45:54 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: fix crash regression since e027935a795
During
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, August 21, 2017 11:55 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: replace gotos with conditionals in array drawing code
No Piglit regressions
Looks good. Thanks.
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, August 22, 2017 1:21:56 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] vbo: fix glVertexAttrib(index=0)
Depending on which extension
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, August 30, 2017 10:16:05 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: include sample count in surface_size() computation
Use MAX2() because
Instead of saving primitive offset in the minmax cache key,
save the actual buffer offset which is used in the cache lookup.
Fixes rendering artifact seen with GoogleEarth when run with
VMware driver.
---
src/mesa/vbo/vbo_minmax_index.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-
Instead of saving primitive offset in the minmax cache key,
save the actual buffer offset which is used in the cache lookup.
Fixes rendering artifact seen with GoogleEarth when run with
VMware driver.
v2: Per Brian's comment, initialize offset to avoid compiler warning.
Cc: mesa-sta...@lists.fre
Reviewed-by: Charmaine Lee
> On Sep 3, 2017, at 10:13 PM, Tapani Pälli wrote:
>
> incompatible pointer to integer conversion assigning to 'GLintptr' (aka 'int')
> from 'const char *' [-Werror,-Wint-conversion]
>
> offset = indices;
&g
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Tuesday, October 9, 2018 8:06:26 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] svga: change svga_destroy_shader_variant() to return void
Java2d opengl pipeline passes NULL piAttribList to
wglCreatePbufferARB(). So skip parsing the attribute list
if it is NULL.
---
src/gallium/state_trackers/wgl/stw_ext_pbuffer.c | 80
1 file changed, 41 insertions(+), 39 deletions(-)
diff --git a/src/gallium/state_trackers
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, July 27, 2018 7:21:53 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] mesa: move var decls in texstore_rgba()
Move them closer to where
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, May 4, 2016 1:03 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Sinclair Yeh
Subject: [PATCH] mesa: include texture format in glGenerateMipmap error message
---
src/mesa/main
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Wednesday, May 4, 2016 1:03 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Sinclair Yeh
Subject: [PATCH] glapi: fix parameter type for GetSamplerParameterIuivEXT() in
es_EXT.xml
The function
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Thursday, May 12, 2016 10:40 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Sinclair Yeh
Subject: [PATCH] st/mesa: remove unused st_context::default_texture
The code which used this was removed
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, May 23, 2016 1:35 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; mesa-sta...@lists.freedesktop.org
Subject: [PATCH] mesa: raise error for glEnable(GL_VERTEX_ARRAY), etc. in core
profile
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, March 30, 2018 7:42 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH] glapi: define GL_API to be GLAPI in glapi_dispatch.c
This fixes a Windows build warning
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, April 13, 2018 9:03:41 AM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 3/3] glsl: #undef THIS macro to fix MSVC build
THIS is a macro in one
For the series, Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Friday, April 13, 2018 2:35:37 PM
To: mesa-dev@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 5/5] gallium/osmesa: link with winsock2 library on Windows
To fix the
This patch fixes a missing argument to CreateAtomicCmpXchg for older
version of LLVM.
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
index 79d1029..
The patch looks good to me.
It replaces my earlier patch request on the same issue.
Reviewed-by: Charmaine Lee
On 8/2/19, 9:54 AM, "Brian Paul" wrote:
On 08/02/2019 10:36 AM, srol...@vmware.com wrote:
> From: Roland Scheidegger
>
> These versions sti
maine
From: Michel Dänzer
Sent: Tuesday, February 11, 2020 2:03 AM
To: Neha Bhende; Brian Paul; Charmaine Lee
Cc: mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [Review Request (master branch)] svga: Use
pipe_shader_state_from_tgsi to set shader state
Hi Charmaine,
it looks like you p
This fixes surface leak when no winsys buffers are bound.
---
src/mesa/main/context.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
index 34da16b..04ef4d5 100644
--- a/src/mesa/main/context.c
+++ b/src/mesa/main/context.c
@@ -1765,6 +1765
With commit c89e8470e58, framebuffers are purged after unbinding context,
but this change also introduces a heap corruption when running Rhino application
on VMware svga device. Instead of purging the framebuffers after the context
is unbound, this patch first ubinds the winsys buffers, then purges
>From: Brian Paul
>Sent: Monday, May 20, 2019 6:39 AM
>To: Charmaine Lee; mesa-dev@lists.freedesktop.org; Neha Bhende;
>marek.ol...@amd.com
>Subject: Re: [PATCH 2/2] mesa: unreference current winsys buffers when
>unbinding winsys buffers
>Both look OK to me. Do they n
Reviewed-by: Charmaine Lee
From: Brian Paul
Sent: Monday, May 20, 2019 6:36:33 AM
To: mesa-dev@lists.freedesktop.org
Cc: Neha Bhende; Charmaine Lee
Subject: [PATCH] svga: clamp max_const_buffers to SVGA_MAX_CONST_BUFS
In case the device reports 15 (or
101 - 148 of 148 matches
Mail list logo
