Re: [Mesa-dev] [PATCH 1/2] i965/tiled_memcpy: Add alignment assumption decorations

d_memcpy.c | 30 > +++--- > 1 file changed, 22 insertions(+), 8 deletions(-) Simple enough. GCC has supported __builtin_assume_aligned since 2011-ish, so the builtin is safe to use IMO. Reviewed-by: Chad Versace (I'm really back from parental

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

So we can never assume that either address is aligned, as it may be a user ptr. I didn't test it, but it looks correct to me. Reviewed-by: Chad Versace (I'm really back from parental leave! I just built Mesa for the first time in 9 weeks! Of course, I had to install

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

On 04/05/2016 04:50 PM, Jason Ekstrand wrote: > On Tue, Apr 5, 2016 at 4:26 PM, Chad Versace <mailto:chad.vers...@intel.com>> wrote: > > On 04/04/2016 06:04 PM, Jason Ekstrand wrote: > > It's possible, when doing an x-tiled copy, to end up with a case where

Re: [Mesa-dev] [PATCH 3/3] i965/tiled_memoyp: Get rid of the direction parameter to get_memcpy

osely, and I like their approach. For the series, Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] dri: Fix robust context creation via EGL attribute

driCreateContextAttribs() emits an error if bit __DRI_CTX_FLAG_ROBUST_BUFFER_ACCESS is set for an ES context. But, EGL_EXT_create_context_robustness and EGL 1.5 both allow creation of robust ES contexts. One requests a robust ES context by setting the EGL_CONTEXT_OPENGL_ROBUST_ACCESS *attribute*,

[Mesa-dev] [PATCH] util: Fix warning of invalid return value

_mesa_libgcrypt_init() returns NULL, but its return type is void. Cc: Mark Janes --- src/util/mesa-sha1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/mesa-sha1.c b/src/util/mesa-sha1.c index ca6b89b..b6a192f 100644 --- a/src/util/mesa-sha1.c +++ b/src/util/mesa

Re: [Mesa-dev] Merging the Vulkan driver

On 04/05/2016 12:30 PM, Jason Ekstrand wrote: ... > If people step up with code review, I'm hoping that we can merge some > time this week or next. > > --Jason Ekstrand Woo! The Vulkan code is finally merged! ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] i965: The future of blorp

On Sat 16 Apr 2016, Jason Ekstrand wrote: > All, > With Topi's gen8/9 blorp patches on the list, I wanted to start a brief > discussion about the future of blorp in the hopes of us all being on the > same page and not stepping on each other's toes. I think everyone is now > agreed that blorp is th

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

ny identifier (including a > >>>>> preprocessor define) starting with double underscore is reserved for the > >>>>> implementation and causes the program's behavior to be undefined? The > >>>>> kernel is kind of part of the imp

Re: [Mesa-dev] [PATCH 5/7] isl: fix warnings in release build

On Sat 16 Apr 2016, Grazvydas Ignotas wrote: > Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings > in release build. > > Signed-off-by: Grazvydas Ignotas > --- > I have no commit access, if this patch is ok, please someone push. This isl patch is Reviewe

Re: [Mesa-dev] [PATCH 6/7] anv: fix warnings in release build

On Sat 16 Apr 2016, Grazvydas Ignotas wrote: > Mark variables MAYBE_UNUSED to avoid unused-but-set-variable warnings > in release build. > > Signed-off-by: Grazvydas Ignotas This anvil patch is Reviewed-by: Chad Versace ___ mesa-dev maili

Re: [Mesa-dev] [PATCH 1/7] util: add MAYBE_UNUSED for config dependent variables

On Tue 19 Apr 2016, Ian Romanick wrote: > On 04/19/2016 12:15 PM, Chad Versace wrote: > > On Tue 19 Apr 2016, Emil Velikov wrote: > >> On 19 April 2016 at 19:38, Ian Romanick wrote: > >>> On 04/19/2016 07:48 AM, Emil Velikov wrote: > >>>> On 18 April 2

Re: [Mesa-dev] [PATCH 01/13] i965: Add a dependency on libisl

On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > configure.ac | 3 ++- > src/Makefile.am | 9 +++-- > src/intel/Makefile.am | 4 > src/mesa/drivers/dri/i965/Makefile.am | 7 ++- > 4 files changed, 15 insertions(+), 8 dele

Re: [Mesa-dev] [PATCH 02/13] isl: Add an ISL_RESTRICT #define for use in isl.h

On Tue 19 Apr 2016, Matt Turner wrote: > On Sat, Apr 16, 2016 at 12:45 PM, Jason Ekstrand wrote: > > C++ doesn't define the "restrict" keyword so g++ barfs when it sees isl.h. > > Having our own define lets us define it to be a no-op for C++. > > --- > > src/intel/isl/isl.h | 18 ++---

Re: [Mesa-dev] [PATCH 03/13] isl: Don't use designated initializers in the header

On Tue 19 Apr 2016, Emil Velikov wrote: > On 16 April 2016 at 20:45, Jason Ekstrand wrote: > > C++ doesn't support designated initializers and g++ in particular doesn't > > handle them when the struct gets complicated, i.e. has a union. > > --- > > src/intel/isl/isl.h | 32 ---

Re: [Mesa-dev] [PATCH 04/13] isl: Take a devinfo in lower_storage_image_format instead of an isl_device

Patch 4 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/13] isl: Add a helper for determining when a typed load/store can be used

On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 7 +++ > src/intel/isl/isl_storage_image.c | 10 ++ > 2 files changed, 17 insertions(+) > +bool > +isl_has_matching_typed_storage_image_format(const struct brw_device_info > *devinfo, > +

Re: [Mesa-dev] [PATCH 06/13] anv/image: Use the has_matching_typed_storage_image_format helper from isl

On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) Patch 6 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 07/13] isl/format: Break the guts of has_[us]int_channel into a helper

isl_base_type type) I think the 'of' in the function name sounds awkward, a little Java-ish. 'isl_format_has_channel_type' sounds better. With or without the change, patch 7 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa

Re: [Mesa-dev] [PATCH 08/13] isl/format: Add more isl_format_has_type_channel functions

On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h| 23 +++ > src/intel/isl/isl_format.c | 24 > 2 files changed, 43 insertions(+), 4 deletions(-) Patch 8 is Reviewed-by:

Re: [Mesa-dev] [PATCH 10/13] i965/fs_surface_builder: Take a GL format enum instead of mesa_format

_reg &addr, >unsigned surf_dims, unsigned arr_dims, > - mesa_format format); > + unsigned format); Please do the same for the the declarations, because 'unsigned format' is ambiguous. With that change, patch 10

Re: [Mesa-dev] [PATCH 02/13] isl: Add an ISL_RESTRICT #define for use in isl.h

On Tue 19 Apr 2016, Jason Ekstrand wrote: > On Tue, Apr 19, 2016 at 3:14 PM, Chad Versace > wrote: > > > On Tue 19 Apr 2016, Matt Turner wrote: > > > On Sat, Apr 16, 2016 at 12:45 PM, Jason Ekstrand > > wrote: > > > > C++ doesn't define the "r

Re: [Mesa-dev] [PATCH 11/13] i965/fs_surface_builder: Explicitly handle FORMAT_NONE in num_image_coordinates

something we can rely on. > --- > src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp | 1 + > 1 file changed, 1 insertion(+) Patch 11 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.fr

Re: [Mesa-dev] [PATCH 12/13] i965/fs_surface_builder: Add a helper for converting GL to ISL formats

On Sat 16 Apr 2016, Jason Ekstrand wrote: > --- > .../drivers/dri/i965/brw_fs_surface_builder.cpp| 55 > ++ > 1 file changed, 55 insertions(+) Patch 12 is Reviewed-by: Chad Versace ___ mesa-dev mailing l

Re: [Mesa-dev] [PATCH 13/13] i965/fs_surface_builder: Use isl instead of mesa for format info

)); > + isl_format_has_snorm_channel(format)); The above two lines seem to be the only non-trivial diff in this patch. I inspected it closely, and I'm convinced it's correct. > } > } Patch 13 is Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH 14/13] i965/surface_state: Use libisl functions for image format lowering

ormats.c | 109 > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 21 +++-- > 3 files changed, 12 insertions(+), 120 deletions(-) Patch 14/13? Hmm? This patch is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-d

Re: [Mesa-dev] [PATCH 03/13] isl: Don't use designated initializers in the header

re executed", then you're never running `make clean` again :) Thanks for the branch. All the patches on that branch look good to me, and are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 01/13] i965: Add a dependency on libisl

On 04/22/2016 10:50 AM, Jason Ekstrand wrote: > > > On Fri, Apr 22, 2016 at 10:15 AM, Jonathan Gray > wrote: > > On Fri, Apr 22, 2016 at 05:31:29PM +0100, Emil Velikov wrote: >> On 22 April 2016 at 16:08, Jonathan Gray > > wrote: >>> It is worth not

Re: [Mesa-dev] [PATCH] mesa: add tags file to gitignore

On Sat 16 Apr 2016, Grazvydas Ignotas wrote: > For ctags users like me. > > Signed-off-by: Grazvydas Ignotas > --- > I have no commit access, if this patch is ok, please someone push. Hi Grazvydas, I just pushed your patch. ___ mesa-dev mailing list me

Re: [Mesa-dev] [PATCH 0/2] two super simple patches

On Sun 17 Apr 2016, Eduardo Lima Mitev wrote: > Both patches are: > > Reviewed-by: Eduardo Lima Mitev > > Thanks! > Eduardo > > On 04/16/2016 09:26 PM, Juha-Pekka Heikkila wrote: > > These are just fixes for error paths. > > > > Juha-Pekka Heikkila (2): > > meta: Avoid random memory access o

Re: [Mesa-dev] [PATCH] anv: honor DESTDIR when installing icd file

On Sun 17 Apr 2016, Laurent Carlier wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=94969 > --- > src/intel/vulkan/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the fix. I pushed this to master with my r-b. ___ mes

[Mesa-dev] [PATCH 1/7] egl/dri2: Check return value of __DRI2fence::create_fence()

From: Chad Versace If it returns NULL, then return early with an error. Cc: Marek Olšák --- src/egl/drivers/dri2/egl_dri2.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 34d6bfe..c2a856f 100644 --- a/src/egl

[Mesa-dev] [PATCH 3/7] i915/sync: Don't crash when deleting sync object

From: Chad Versace Don't pass NULL to drm_intel_bo_unreference(). It doesn't like that. Bug found by code inspection. --- src/mesa/drivers/dri/i915/intel_syncobj.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i915/intel_syncobj.c

[Mesa-dev] [PATCH 2/7] i965/sync: Don't crash when deleting sync object

From: Chad Versace Don't pass NULL to drm_intel_bo_unreference(). It doesn't like that. Bug found by code inspection. --- src/mesa/drivers/dri/i965/intel_syncobj.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_syncobj.c

[Mesa-dev] [PATCH 5/7] i915/sync: Return early when calloc fails

--- src/mesa/drivers/dri/i915/intel_syncobj.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i915/intel_syncobj.c b/src/mesa/drivers/dri/i915/intel_syncobj.c index 92a246d..92b5b63 100644 --- a/src/mesa/drivers/dri/i915/intel_syncobj.c +++ b/src/mesa/drivers/dri/i915/i

[Mesa-dev] [PATCH 0/7] i965: Enable EGL_KHR_fence_sync

The first 6 patches are small cleanups. The real implementation is patch 7/7. Enabling EGL_KHR_fence_sync also gives us EGL_KHR_wait_sync for free. This series lives on the tag: git://github.com/chadversary/mesa i965-egl-khr-fence-sync-v01 Chad Versace (7): egl/dri2: Check return value

[Mesa-dev] [PATCH 6/7] i965/sync: Replace prefix 'intel_sync' -> 'intel_gl_sync'

I'm about to implement DRI2_Fenc in intel_syncobj.c. To prevent madness, we need to prefix functions for GL_ARB_sync with 'gl' and functions for DRI2_Fence with 'dri'. Otherwise, the file will become a jumble of similiarly named functions. For example: old-name: intel_client_wait_sync()

[Mesa-dev] [PATCH 4/7] i965/sync: Return NULL when calloc fails

--- src/mesa/drivers/dri/i965/intel_syncobj.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_syncobj.c b/src/mesa/drivers/dri/i965/intel_syncobj.c index 3bc32df..a425b9e 100644 --- a/src/mesa/drivers/dri/i965/intel_syncobj.c +++ b/src/mesa/drivers/dri/i965/i

[Mesa-dev] [PATCH 7/7] i965/sync: Implement DRI2_Fence extension

From: Chad Versace This enables EGL_KHR_fence_sync and EGL_KHR_wait_sync. Below is the difference in piglit results, before and after this patch. No regressions and several tests improve from 'skip' to 'pass'. Out of EGL_KHR_fence_sync tests, two of the multithreaded tests s

Re: [Mesa-dev] [PATCH 1/7] egl/dri2: Check return value of __DRI2fence::create_fence()

On Fri 01 May 2015, Matt Turner wrote: > On Fri, May 1, 2015 at 1:01 PM, Chad Versace wrote: > > From: Chad Versace > > Different From: email address? Oops. I forgot to configure my local .git/config after a fresh clone. Thanks fo

Re: [Mesa-dev] [PATCH 7/7] i965/sync: Implement DRI2_Fence extension

On Mon 04 May 2015, Daniel Stone wrote: > Hi, > > On 1 May 2015 at 21:02, Chad Versace wrote: > > +static bool > > +brw_fence_has_completed(struct brw_fence *fence) > > +{ > > + if (fence->signalled) > > + return true; > > + > &g

Re: [Mesa-dev] [PATCH 7/9] egl/wayland: assume EGL_WINDOW_BIT

On Wed 06 May 2015, Daniel Stone wrote: > Hi, > > On 6 May 2015 at 07:25, Pekka Paalanen wrote: > > On Wed, 6 May 2015 11:00:13 +1000 > > Dave Airlie wrote: > >> On 2 May 2015 at 20:15, Axel Davy wrote: > >> > Only EGL_WINDOW_BIT is supported. Remove tests related. > >> > >> Is this there no pl

Re: [Mesa-dev] [PATCH 1/6] egl/main: drop support for external egl drivers

On Mon 11 May 2015, Emil Velikov wrote: > The only user (egl_gallium) is not longer around. > > Signed-off-by: Emil Velikov For the series, Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [PATCH 1/6] egl/main: drop support for external egl drivers

On Tue 12 May 2015, Chad Versace wrote: > On Mon 11 May 2015, Emil Velikov wrote: > > The only user (egl_gallium) is not longer around. > > > > Signed-off-by: Emil Velikov > > For the series, > Reviewed-by: Chad Versace Um... except for patch 5, the one that

Re: [Mesa-dev] [PATCH 5/6] egl/main: expose only core EGL functions statically

r Nvidia's EGL library. 2. "Non-portable" means, in my opinion, not only non-portable across different vendor's implementations of libEGL but also across versions of a single vendor's implementation. So, this patch does not violate any ABI contrac

Re: [Mesa-dev] [PATCH] egl/main: fix EGL_KHR_get_all_proc_addresses

On Tue 12 May 2015, Emil Velikov wrote: > The extension requires that the address of the core functions should be > available via eglGetProcAddress. Currently the list is guarded by > _EGL_GET_CORE_ADDRESSES, which was only set for the scons (windows) > build. > > Unconditionally enable it for all

Re: [Mesa-dev] [PATCH] egl: more define fixes for EGL_MESA_image_dma_buf_export

> >> #endif > > Considering how these can go (have been) subtly broken without many > > people realising can we just nuke the #ifdef spaghetti ? I'm > > suspecting that they are present in order to prevent build issues, > > when the compiler picks up the non-mesa he

Re: [Mesa-dev] Stable libEGL ABI ?

On Fri 08 May 2015, Emil Velikov wrote: > Hi all, > > Just had a quick look at Debian's repo and noticed something rather > worrying - the ABI of our libEGL is not stable. > Stable in the sense of - we provide a growing list of static symbols > for each new function an EGL extension adds. > > Thi

Re: [Mesa-dev] [PATCH 03/15] egl: combine VersionMajor and VersionMinor into one variable

On Wed 13 May 2015, Marek Olšák wrote: > From: Marek Olšák > > --- > src/egl/main/eglapi.c | 9 - > src/egl/main/egldisplay.h | 3 +-- > 2 files changed, 5 insertions(+), 7 deletions(-) Patches 1-3 are Reviewed-by: Chad Versace I'm looking at the

Re: [Mesa-dev] [PATCH 04/15] egl: import headers from Khronos EGL registry

On Thu 14 May 2015, Emil Velikov wrote: > Hi Marek, > On 12/05/15 22:54, Marek Olšák wrote: > > From: Marek Olšák > > > > with the extension of keeping: > > #define KHRONOS_APICALL __attribute__((visibility("default"))) > > > > And don't include mesa headers in egl.h. > Can we do this more g

Re: [Mesa-dev] [PATCH 09/15] egl: add EGL 1.5 functions that don't need any changes from extensions

On Wed 13 May 2015, Marek Olšák wrote: > From: Marek Olšák > > Declare the functions without the suffix, so that the core names are exported. > --- > src/egl/main/eglapi.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) Patches 5-9 are Reviewe

Re: [Mesa-dev] [PATCH 10/15] egl: add eglWaitSync

; >> 64bit value, while a 32bit one being popped. My x86 assembly days were > >> mostly before x86_64 became a thing so ^^ might sound a bit stupid :) > > > > It's EGLBoolean, not EGLenum. Also, no cast is needed between basic types. > > > > typedef int32_t

Re: [Mesa-dev] [PATCH 11/15] egl: add eglGetSyncAttrib

On Wed 13 May 2015, Marek Olšák wrote: > From: Marek Olšák > > --- > src/egl/main/eglapi.c | 14 +- > src/egl/main/eglapi.h | 2 +- > src/egl/main/eglsync.c | 2 +- > src/egl/main/eglsync.h | 2 +- > 4 files changed, 16 insertions(+), 4 deletions(-) > I see two issues below. >

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

On Fri 15 May 2015, Emil Velikov wrote: > On 12/05/15 22:54, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/egl/main/eglapi.c | 38 ++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c > > in

Re: [Mesa-dev] [PATCH 1/3] egl: import egl.h from registry (v2)

On Sat 23 May 2015, Marek Olšák wrote: > From: Marek Olšák > > v2: split the commit into 3 patches Thanks for splitting the patches up. For the series, Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [PATCH 04/15] egl: import headers from Khronos EGL registry

On Thu 28 May 2015, Marek Olšák wrote: > Hi Chad, > > I broke up the patches and sent them as a separate patch series a few days > ago. > > [PATCH 1/3] egl: import egl.h from registry (v2) > [PATCH 2/3] egl: import eglext.h from registry and cleanup eglmesaext.h (v2) > [PATCH 3/3] egl: import pl

Re: [Mesa-dev] [PATCH 11/15] egl: add eglGetSyncAttrib

On Thu 28 May 2015, Marek Olšák wrote: > Hi Chad, > > A new patch is attached. Thanks for the changes. This patch is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/list

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

On Thu 28 May 2015, Eirik Byrkjeflot Anonsen wrote: > Marek Olšák writes: > > > I don't understand. Using size_t should prevent the integer overflow. > > Is there anything else wrong other than no fail path for malloc? I > > also don't understand how calloc can help here. > > > > Marek > > "size

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

On Thu 28 May 2015, Marek Olšák wrote: > A new patch is attached. Please review. LGTM. Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 13/15] egl: add new platform functions

On Thu 28 May 2015, Marek Olšák wrote: > A new patch is attached. Please review. > Looks good to me. Reviewed-by: Chad Versace Later, if and when some platform extension defines a pointer-sized attribute, then we will need to invert the function order. That is, eglGetPlatformDisplayEX

Re: [Mesa-dev] [PATCH 15/15] egl: expose EGL 1.5 if all requirements are met

The last two patches, 14-15, are Reviewed-by: Chad Versace I think I've reviewed all the patches in this series. Please let me know if I missed any. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

struct intel_mipmap_tree *mt); > > > > > > +#define MIPTREE_LAYOUT_ACCELERATED_UPLOAD (1<<0) > > > > I was wondering if we could call the the flags something else than layout. > > The manner of upload doesn't technically have much to do with layout. Maybe > > just flags, shrug. I have nitpick too :) I'd like to see these defined in an anonymous enum block so the token names show up in gdb. enum { MIPTREE_LAYOUT_FORCE_ALL_SLICE_AT_LOD = 1 << 1, ..., }; I agree with Topi that "layout" isn't the best choice of name, but I also can't think of anything better. So "layout" is good with me. We can rename it later if it causes confusion. > > > > > +#define MIPTREE_LAYOUT_FORCE_ALL_SLICE_AT_LOD (1<<1) > > > +#define MIPTREE_LAYOUT_FOR_BO (1<<2) > > > +#define MIPTREE_LAYOUT_DISABLE_AUX (1<<3) > > > > Maybe a separating new line here as well? +1 ... This patch, with or without my and Topi's suggestions, is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/6] i965/gen9: Only allow Y-Tiled MCS buffers

://patchwork.freedesktop.org/patch/46984/), > > NOTE: This patch shouldn't actually do anything since SKL doesn't yet use fast > clears, and that's the only case we can get to this function (by way of > intel_update_winsys_renderbuffer_miptree) >

Re: [Mesa-dev] [PATCH 3/6] i965: Extract tiling from fast clear decision

laims. > To signify this change, I've also renamed the function to indicate it is a > distinction made on the miptree. I am torn as to whether or not it was a good > idea to remove "non_msrt" since it's a really nice thing for grep. > > Cc: Chad Versace >

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

On Fri 29 May 2015, Matt Turner wrote: > On Thu, May 28, 2015 at 10:21 AM, Ben Widawsky > > @@ -286,7 +284,7 @@ intel_miptree_create_layout(struct brw_context *brw, > > mt->logical_height0 = height0; > > mt->logical_depth0 = depth0; > > mt->fast_clear_state = INTEL_FAST_CLEAR_STATE_NO_M

Re: [Mesa-dev] [PATCH 4/6] i965/gen8: Correct HALIGN for AUX surfaces

On Thu 28 May 2015, Ben Widawsky wrote: > This restriction was attempted in this commit: > commit 47053464630888f819ef8cc44278f1a1220159b9 > Author: Anuj Phogat > Date: Fri Feb 13 11:21:21 2015 -0800 > >i965/gen8: Use HALIGN_16 if MCS is enabled for non-MSRT > > However, the commit itself

Re: [Mesa-dev] [PATCH 5/6] i965/gen9: Set HALIGN_16 for all aux buffers

On Thu 28 May 2015, Ben Widawsky wrote: > Just like the previous patch, but for the GEN9 constraints. > > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

Re: [Mesa-dev] [PATCH 4/6] i965/gen8: Correct HALIGN for AUX surfaces

On Fri 29 May 2015, Chad Versace wrote: > On Thu 28 May 2015, Ben Widawsky wrote: > > This restriction was attempted in this commit: > > commit 47053464630888f819ef8cc44278f1a1220159b9 > > Author: Anuj Phogat > > Date: Fri Feb 13 11:21:21 2015 -0800 > > >

Re: [Mesa-dev] [PATCH 6/6] i965/gen8+: Add aux buffer alignment assertions

_mt = mt->mcs_mt; >aux_mode = GEN8_SURFACE_AUX_MODE_MCS; > + assert(brw->gen < 9 || mt->align_w == 16); > + assert(brw->gen < 8 || mt->num_samples > 0 || mt->align_w == 16); > } Same here. With some PRM quotes sprinkle

Re: [Mesa-dev] [PATCH 1/6] i965: Consolidate certain miptree params to flags

On Fri 29 May 2015, Kenneth Graunke wrote: > On Friday, May 29, 2015 12:33:10 PM Chad Versace wrote: > > On Fri 29 May 2015, Matt Turner wrote: > > > On Thu, May 28, 2015 at 10:21 AM, Ben Widawsky > > > > @@ -286,7 +284,7 @@ intel_miptree_create_layout(struct br

[Mesa-dev] [PATCH] i965/fs: Fix unused variable warning

Annotate offset_components with attribute 'unused'. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 0f1a286..3c24a87 100644 --- a/src/mesa/d

Re: [Mesa-dev] [PATCH v3] egl/dri2: implement platform_surfaceless (v3)

On Mon 08 Jun 2015, Zach Reizner wrote: > From: Haixia Shi > > The surfaceless platform is for off-screen rendering only. Render node support > is required. > > Only consider the render nodes. Do not use normal nodes as they require > auth hooks. > > v3: change platform_null to platform_surface

Re: [Mesa-dev] [PATCH 2/2] i965: add runtime check for SSSE3 rgba8_copy

On Thu 06 Nov 2014, Timothy Arceri wrote: Also cleans up some if statements in the *faster functions. I have comments about the cleanup below. diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/drivers/dri/i965/intel_tex_subimage.c index cb5738a..0deeb75 100644 --- a/src/

[Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge

Fixes: Intel CHRMOS-1377 Reported-by: Lu Hua Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

Re: [Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge

On Mon 10 Nov 2014, kalyan kondapally wrote: The patch seems to fix the crash I used to see while running this WebGL conformance test on my machine (Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz). and now I can see all the tests pass. I believe 78770 is a different issue (Added my comments to 78770) a

Re: [Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge

On Tue 11 Nov 2014, Ian Romanick wrote: On 11/10/2014 04:02 PM, Chad Versace wrote: map->stride = mt->pitch; - map->ptr = base + y * map->stride + x * mt->cpp; + + /* The variables in below pointer arithmetic are 32-bit. The arithmetic + * overflows for

Re: [Mesa-dev] EXT/ARB direct state access extensions

+Laura. This thread is about you. On Sun 16 Nov 2014, Gustaw Smolarczyk wrote: Ok. It would be helpful to note the progress in the docs/GL3.txt file. The overview of ARB_dsa summarizes the difference between it and the EXT variant, so I understand the undesirability of implementing EXT_dsa. Gu

Re: [Mesa-dev] [PATCH] i965/blorp: Fix hiz ops on MSAA surfaces

On Tue 18 Nov 2014, Chris Forbes wrote: Two things were broken here: - The depth/stencil surface dimensions were broken for MSAA. - Sample count was programmed incorrectly. Result was the depth resolve didn't work correctly on MSAA surfaces, and so sampling the surface later produced garbage. F

[Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge (v2)

/textures/texture-size-limit.html Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=78770 Fixes: Intel CHRMOS-1377 Reported-by: Lu Hua Signed-off-by: Chad Versace --- v2: - Simplify diff. Change types of x,y to intptr_t instead of casting intermediate arithmetic expressions to

Re: [Mesa-dev] [PATCH] i965: Fix segfault in WebGL Conformance on Ivybridge (v2)

Committed, with Cc stable tags in message. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/4] i965: Use safer pointer arithmetic in intel_texsubimage_tiled_memcpy()

casts are cleaner). Cc: Ian Romanick Cc: Kenneth Graunke Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/driver

[Mesa-dev] [PATCH 3/4] i965: Use safer pointer arithmetic in intel_texsubimage_tiled_memcpy()

casts are cleaner). Cc: Ian Romanick Cc: Kenneth Graunke Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src/mesa/driver

Re: [Mesa-dev] [PATCH 3/4] i965: Use safer pointer arithmetic in intel_texsubimage_tiled_memcpy()

Mailman, wake up! I sent this patch series to mesa-dev twice this evening. And each time, only one patch (PATCH 3/4) got through to the mailing list. Weird. git-send-email says that all mail was sent ok. Weird again. If you want to see my patches, they're on my branch 'i965-safer-pointer-ari

[Mesa-dev] [PATCH 1/4] i965: Remove spurious casts in copy_image_with_memcpy()

If a pointer points to raw, untyped memory and is never dereferenced, then declare it as 'void*' instead of casting it to 'void*'. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_copy_image.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) d

[Mesa-dev] [PATCH 1/4] i965: Remove spurious casts in copy_image_with_memcpy()

If a pointer points to raw, untyped memory and is never dereferenced, then declare it as 'void*' instead of casting it to 'void*'. Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_copy_image.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) d

[Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

ust be doing pointer arithmetic on 'out_ptr'. Using ptrdiff_t instead of int should make a little bit harder to hit overflow bugs. As a side-effect, some function-scope variables needed to be retyped to avoid compilation errors. Cc: Ian Romanick Cc: Kenneth Graunke Signed-off-by: Chad Vers

[Mesa-dev] [PATCH 0/4] i965: Safer pointer arithmetic

k patch 3 is suitable for the stable branches. Let me what you think about that. [1] http://github.com/chadversary/mesa/tree/i965-safer-pointer-arith Chad Versace (4): i965: Remove spurious casts in copy_image_with_memcpy() i965: Fix intel_miptree_map() signature to be more 64-bit safe i

[Mesa-dev] [PATCH 4/4] i965: Use safer pointer arithmetic in gather_oa_results()

* (int) I smell 32-bit overflow all over this code. This patch retypes 'snapshot_size' to 'ptrdiff_t', which should fix any potential overflow. Cc: Ian Romanick Cc: Kenneth Graunke Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_performance_monitor.c | 2 +

[Mesa-dev] [PATCH 4/4] i965: Use safer pointer arithmetic in gather_oa_results()

* (int) I smell 32-bit overflow all over this code. This patch retypes 'snapshot_size' to 'ptrdiff_t', which should fix any potential overflow. Cc: Ian Romanick Cc: Kenneth Graunke Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_performance_monitor.c | 2 +

[Mesa-dev] [PATCH 0/4] i965: Safer pointer arithmetic

k patch 3 is suitable for the stable branches. Let me what you think about that. [1] http://github.com/chadversary/mesa/tree/i965-safer-pointer-arith Chad Versace (4): i965: Remove spurious casts in copy_image_with_memcpy() i965: Fix intel_miptree_map() signature to be more 64-bit safe i

[Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

ust be doing pointer arithmetic on 'out_ptr'. Using ptrdiff_t instead of int should make a little bit harder to hit overflow bugs. As a side-effect, some function-scope variables needed to be retyped to avoid compilation errors. Cc: Ian Romanick Cc: Kenneth Graunke Signed-off-by: Chad Vers

Re: [Mesa-dev] [PATCH 1/4] i965: Remove spurious casts in copy_image_with_memcpy()

On Wed 19 Nov 2014, Matt Turner wrote: On Wed, Nov 19, 2014 at 3:35 AM, Kristian Høgsberg wrote: On Tue, Nov 18, 2014 at 9:02 PM, Chad Versace wrote: If a pointer points to raw, untyped memory and is never dereferenced, then declare it as 'void*' instead of casting it to 'void

[Mesa-dev] [PATCH] egl: Expose EGL_KHR_get_all_proc_addresses and its client extension

Signed-off-by: Chad Versace --- You can find this on my branch 'EGL_KHR_get_all_proc_addresses'. http://github.com/chadversary/mesa/tree/EGL_KHR_get_all_proc_addresses src/egl/main/eglapi.c | 17 + src/egl/main/egldisplay.h | 1 + src/egl/main/eglglobals.c | 4 +++

Re: [Mesa-dev] [PATCH 2/4] i965: Fix intel_miptree_map() signature to be more 64-bit safe

On Wed 19 Nov 2014, Kenneth Graunke wrote: On Wednesday, November 19, 2014 02:13:03 PM Ian Romanick wrote: On 11/18/2014 09:11 PM, Chad Versace wrote: > This patch should diminish the likelihood of pointer arithmetic overflow > bugs, like the one fixed by b69c7c5dac. > > Change

Re: [Mesa-dev] [PATCH] egl: Create queryable strings in eglInitialize().

ps we should just remove API.QueryString altogether? Perhaps Brian >> knows of a reason not to... > > Getting rid of that could be nice. We could inline _eglQueryString, > avoid locking the display, and throw out eglmisc.c/eglmisc.h. Yes, let's get rid of API.QueryString. Mesa's egl/main directory contains a superfluous amount of virtual dispatch, and API.QueryString is one of the guilty parties. I like this patch is. It's Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Defer the throttle until we submit new commands

uld happen definitely immediately before submitting the batch, not immediately before the user wants to use the cpu to build a new batch. This patch solves my major complaint with the original patches you sent. Reviewed-by: Chad Versace But... please fix the style conventions in my comments belo

Re: [Mesa-dev] [PATCH] egl: Remove eglQueryString virtual dispatch.

On 03/13/2015 05:59 PM, Matt Turner wrote: Patch is Reviewed-by: Chad Versace > --- > Chad, you suggested it would be nice to remove the locking from > eglQueryString, but I don't see a way to do it. eglQueryString has > to generate EGL_NOT_INITIALIZED if the display

Re: [Mesa-dev] [PATCH 1/2] egl/dri2: implement platform_null (v2).

Time to revive this patch! Why? - I don't like large patchsets living in Chrome OS for too long. - Frank submitted Waffle patches to support this, and I hesitate to add Waffle support unless the platform is upstream. Of course, the patch no longer applies to master. So I rebased and pushed

Re: [Mesa-dev] DMA_BUF render targets disabled for intel

On Thu 02 Apr 2015, Axel Davy wrote: Hi, you may be interesting look at this related bug report: https://bugs.freedesktop.org/show_bug.cgi?id=87452#c5 Yours, Axel Davy On 02/04/2015 11:58, Volker Vogelhuber wrote : We currently want to stream OpenGL output to an FPGA that does not provide a

Re: [Mesa-dev] [PATCH 1/2] egl/dri2: implement platform_null (v2).

On Tue 07 Apr 2015, Kristian Høgsberg wrote: On Tue, Apr 7, 2015 at 6:46 PM, Frank Henigman wrote: The name "surfaceless" suits me. Does this platform need to provide a hint to the user about buffer format? Platform drm does this via the EGL_NATIVE_VISUAL_ID query of eglGetConfigAttrib(), retu

<    5   6   7   8   9   10   11   12   13   14   >