There is nothing particularly useful to do currently if the update
fails, but there is no point carrying on either. As a result, this has a
behavior change.
v2: Make the return type a bool (Topi)
Cc: Topi Pohjolainen
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index 805de5b461
Allows us to continue utilizing common miptree creation using __DRIimage
without creating a new DRIimage (for the intel_process_dri2_buffer()
case).
This is a bit ugly, but I think it's the best one can do.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri
v2: Put the commit message as a comment (Topi)
Cc: Topi Pohjolainen
Cc: Ville Syrjälä
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers
-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 97 +++
1 file changed, 85 insertions(+), 12 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index d79cc61
v2: Leave "image+mod" (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 33
1 file changed, 29 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/d
more concise (Topi)
Cc: Topi Pohjolainen
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_blorp.c | 8
src/mesa/drivers/dri/i965/brw_context.c | 13 +++--
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12 ++--
src
Upper layers of the code will have the need to specify full or partial
resolves (more on this in the next patch). This code simply adds the new
enums and plumbs it in as minimally as necessary.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_blorp.c
This provides a common function or creating miptrees when there is an
existing DRIimage to use. That provides an easy way to add CCS
allocation.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_fbo.c | 17 -
src/mesa/drivers/dri
patch.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index dfd64
called a
partial resolve. The partial resolve will only do a resolve of the fast
clear color and leave the rest of the compressed data alone.
This patch enables using this resolve type for cases where the
framebuffer will be passed along to the kernel for display.
Signed-off-by: Ben Widawsky
Acked
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++-
src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++--
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/mesa
v2: Try to keep the assert as recommended by Topi. This requires
modifying the num_samples check to be <= 1 because internally created
buffers set num_samples = 0.
Cc: Topi Pohjolainen
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c |
On 17-01-03 08:21:06, Chad Versace wrote:
On Sun 01 Jan 2017, Ben Widawsky wrote:
Cc: Topi Pohjolainen
Cc: Chad Versace
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/brw_blorp.c | 2 +-
src/mesa/drivers/dri/i965/brw_draw.c | 3 ++-
src/mesa/drivers/dri/i965
populated, so I'll
assume you're correct about this. So with Emil's suggestion, everything up to
here is:
Reviewed-by: Ben Widawsky
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 16-11-24 20:50:37, Varad Gautam wrote:
This is the second revision to the EGL_EXT_image_dma_buf_import_modifiers [1]
series at [2], addressing the comments received. This diverges from v1 due to
some reordered/squashed changes, hence the resend.
1-4 are Reviewed-by: Ben Widawsky
5-9,12-13
On 17-01-03 13:12:43, Chad Versace wrote:
On Tue 03 Jan 2017, Ben Widawsky wrote:
On 17-01-03 08:21:06, Chad Versace wrote:
> On Sun 01 Jan 2017, Ben Widawsky wrote:
> > Cc: Topi Pohjolainen
> > Cc: Chad Versace
> > Signed-off-by: Ben Widawsky
> > ---
>
On 17-01-02 18:37:02, Ben Widawsky wrote:
The idea behind modifiers like this is that the user of GBM will have
some mechanism to query what properties the hardware supports for its BO
or surface. This information is directly passed in (and stored) so that
the DRI implementation can create an
.
Fixes piglit "egl_khr_gl_renderbuffer_image-clear-shared-image GL_RGBA"
on Skylake. (But the GL_DEPTH_COMPONENT24 test still crashes).
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99265
Cc: Ben Widawsky
---
Hey Ben, this probably conflicts with your RBC patches, which I haven't
r
hiz buffer gets deleted fixes the crash.
For good measure, this patch also deletes all pending CCS/MCS ops when
the CCS/MCS buffer gets deleted. I'm now aware of any bugs
caused by the dangling ops, but deleting them is clearly the right thing
to do.
Cc: Ben Widawsky
Bugzilla:
On 17-01-04 22:55:17, Varad Gautam wrote:
Hi Ben,
On Wed, Jan 4, 2017 at 3:25 AM, Ben Widawsky wrote:
On 16-11-24 20:50:37, Varad Gautam wrote:
This is the second revision to the EGL_EXT_image_dma_buf_import_modifiers
[1]
series at [2], addressing the comments received. This diverges from
On 17-01-04 09:51:20, Topi Pohjolainen Topi Pohjolainen wrote:
On Mon, Jan 02, 2017 at 06:37:13PM -0800, Ben Widawsky wrote:
v2: Leave "image+mod" (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 33 +
On 17-01-04 10:00:59, Topi Pohjolainen Topi Pohjolainen wrote:
On Mon, Jan 02, 2017 at 06:37:18PM -0800, Ben Widawsky wrote:
In the foreseeable future it doesn't seem to make sense to have multiple
resolve flags. What does make sense is to have the caller give an
indication to the lower l
On 17-01-04 10:34:17, Topi Pohjolainen Topi Pohjolainen wrote:
On Wed, Jan 04, 2017 at 09:40:51AM +0200, Pohjolainen, Topi wrote:
On Mon, Jan 02, 2017 at 06:37:10PM -0800, Ben Widawsky wrote:
> This code will disable actually creating these buffers for the scanout,
> but it puts the allo
On 17-01-04 10:57:40, Topi Pohjolainen Topi Pohjolainen wrote:
On Wed, Jan 04, 2017 at 10:26:50AM +0200, Pohjolainen, Topi wrote:
On Mon, Jan 02, 2017 at 06:37:15PM -0800, Ben Widawsky wrote:
> Allows us to continue utilizing common miptree creation using __DRIimage
> without creating
On 17-01-04 10:29:45, Topi Pohjolainen Topi Pohjolainen wrote:
On Mon, Jan 02, 2017 at 06:37:21PM -0800, Ben Widawsky wrote:
On Gen9 hardware, the display engine is able to scanout a compressed
framebuffer by providing an offset to auxiliary compression information.
Unfortunately, the hardware
On 17-01-04 10:41:58, Topi Pohjolainen Topi Pohjolainen wrote:
On Mon, Jan 02, 2017 at 06:37:22PM -0800, Ben Widawsky wrote:
v2: Try to keep the assert as recommended by Topi. This requires
modifying the num_samples check to be <= 1 because internally created
buffers set num_samples = 0.
v2: Make the error return be -1 instead of 0 because I think 0 is
actually valid.
Cc: Daniel Stone
Signed-off-by: Ben Widawsky
---
src/gbm/backends/dri/gbm_dri.c | 28
src/gbm/gbm-symbols-check | 1 +
src/gbm/main/gbm.c | 18
On 17-01-05 12:16:45, Chad Versace wrote:
This patch has a regressing side-effect: it disables CCS for all single-sample
miptrees created by glRenderbufferStorage(). After stepping through some Piglit
tests, I believe the problem is that line 161 below always returns false for
such miptrees becau
On 17-01-05 17:55:15, Topi Pohjolainen Topi Pohjolainen wrote:
On Wed, Jan 04, 2017 at 06:36:05PM -0800, Ben Widawsky wrote:
On 17-01-04 10:41:58, Topi Pohjolainen Topi Pohjolainen wrote:
> On Mon, Jan 02, 2017 at 06:37:22PM -0800, Ben Widawsky wrote:
> > v2: Try to keep the
On 17-01-02 18:37:17, Ben Widawsky wrote:
v2: Put the commit message as a comment (Topi)
Cc: Topi Pohjolainen
Cc: Ville Syrjälä
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 5 -
1 file changed, 4 insertions(+), 1
On 17-01-09 11:56:04, Jason Ekstrand wrote:
On Thu, Dec 1, 2016 at 2:09 PM, Ben Widawsky
wrote:
From: Ben Widawsky
This will be used by clients that need to know the number of planes
allocated for them on behalf of the GL or other API. The best current
example of this is when an extra
On 17-01-09 16:42:19, Jason Ekstrand wrote:
Somehow I didn't actually get the original e-mail so I'm replying via
git-send-email...
On 01/02, Ben Widawsky wrote:
Modifiers will be obtains or guessed by the client and passed in during
image creation/import.
This requires bumping th
On 17-01-05 16:58:56, Rainer Hochecker wrote:
From: Rainer Hochecker
This allows eglCreateImageKHR to access P010 surfaces created by vaapi
Signed-off-by: Rainer Hochecker
Acked-by: Ben Widawky
---
include/GL/internal/dri_interface.h | 4
src/egl/drivers/dri2/egl_dri2.c
On 17-01-09 15:45:47, Jason Ekstrand wrote:
On Wed, Jan 4, 2017 at 8:43 PM, Ben Widawsky wrote:
v2: Make the error return be -1 instead of 0 because I think 0 is
actually valid.
Cc: Daniel Stone
Signed-off-by: Ben Widawsky
---
src/gbm/backends/dri/gbm_dri.c | 28
On 17-01-09 15:53:06, Jason Ekstrand wrote:
On Mon, Jan 9, 2017 at 3:50 PM, Jason Ekstrand wrote:
On Mon, Jan 2, 2017 at 6:36 PM, Ben Widawsky wrote:
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 26
On 17-01-12 14:33:01, Daniel Stone wrote:
On 12 January 2017 at 14:32, Daniel Stone wrote:
If allocated, this image is just leaked, along with its reference on
the BO. Same problem in gbm_dri_bo_get_handle_for_plane.
... and gbm_dri_bo_get_offset.
Cheers,
Daniel
Does this work (compile tes
On 17-01-09 17:03:48, Jason Ekstrand wrote:
On Mon, Jan 2, 2017 at 6:37 PM, Ben Widawsky wrote:
The idea behind modifiers like this is that the user of GBM will have
some mechanism to query what properties the hardware supports for its BO
or surface. This information is directly passed in
On 17-01-12 14:44:33, Daniel Stone wrote:
Hi Ben,
On 3 January 2017 at 02:36, Ben Widawsky wrote:
Same as v1 with the requested fixes and tags added. v1 is here:
https://lists.freedesktop.org/archives/intel-gfx/2016-December/113639.html
I haven't yet updated kmscube to use Krist
On 17-01-12 14:22:09, Jason Ekstrand wrote:
On Thu, Jan 12, 2017 at 10:57 AM, Daniel Stone wrote:
Hi,
On 5 January 2017 at 04:43, Ben Widawsky wrote:
> diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_
dri.c
> index c61d56b44a..f9c1afd8cb 100644
> ---
Other things are out of order, but I need to add a getter so I'm just
fixing those.
This helps people adding to GBM know where the right place to put things
is.
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/main/gbm.c
've gotten GET_PLANE2 working as well. It can be demonstrated in
kmscube:
https://github.com/bwidawsk/kmscube/tree/modifiers
Cc: Kristian H. Kristensen
Cc: Daniel Stone
Cc: Eric Engestrom
Cc: Jason Ekstrand
Ben Widawsky (34):
gbm: Move getters to match order in header file (trivial)
v2: Make the error return be -1 instead of 0 because I think 0 is
actually valid.
v3: Set errno to EINVAL when the specified plane is above the total
planes. (Jason Ekstrand)
Return the bo's handle if there is no image ie. for dumb images like cursor
(Daniel)
Signed-off-by: Ben Widawsky
This will be used so we can query information per plane.
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 7 +++
src/gbm/main/gbm.c | 2 +-
src/gbm/main/gbmint.h | 1 +
3 files changed, 9 insertions
, ie. dumb bo (Daniel)
Cc: Daniel Stone
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 27 +++
src/gbm/gbm-symbols-check | 1 +
src/gbm/main/gbm.c | 10 ++
src/gbm/
: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 36
src/gbm/gbm-symbols-check | 1 +
src/gbm/main/gbm.c | 15 +++
src/gbm/main/gbm.h | 3 +++
src/gbm/main
v2: Preserve legacy behavior when plane is 0 (Jason Ekstrand)
EINVAL when input plane is greater than total planes (Jason Ekstrand)
Don't leak the image after fromPlanar (Daniel)
Move bo->image check below plane count preventing bad index succeeding (Daniel)
Signed-off-by: Ben Widawsky
I intend to need to get to the devinfo structure, and storing the screen
is an easy way to do that.
It seems to be the consensus that you cannot share an image between
multiple screens.
Scape-goat: Rob Clark
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
v2: Other way round... to make consistent, make both return type have
the fixed width - uint32_t.
Cc: Daniel Stone
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/main/gbm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src
2 MiB
Reads: .8 MiB
Similar functionality was introduced and then reverted here:
commit 6a0d036483caf87d43ebe2edd1905873446c9589
Author: Ben Widawsky
Date: Thu Apr 21 20:14:58 2016 -0700
i965: Always use Y-tiled buffers on SKL+
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Ac
llow usage + modifiers
v3: Make NAND actually NAND. Bug introduced in v2. (Jason)
Cc: Kristian Høgsberg
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom (v1)
Acked-by: Daniel Stone
---
include/GL/internal/dri_interface.h | 27 ++-
s
Cc: Daniel Stone
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 37
src/gbm/gbm-symbols-check| 1 +
src/gbm/main/gbm.c | 19
sr
This will expose all the modifier based APIs used by GBM.
This patch was split out for v3 of the series.
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/intel_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src
ps://lists.freedesktop.org/archives/intel-gfx/2017-January/116636.html
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom (v1)
Acked-by: Daniel Stone
---
src/egl/drivers/dri2/platform_drm.c | 19 +---
src/gbm/backends/dri/gbm_dri.c | 51
. As a
result, 0 was repurposed to mean a modifier for a LINEAR layout.
NOTE: This patch was added for v3 of the patch series.
References: https://patchwork.kernel.org/patch/9419157/
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/intel_image.h | 1 +
src/mesa/drivers/dri/i965
st X
tiled.
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
i
oken saved for the last patch, this patch now does less so
it was renamed.
v2: Leave "image+mod" (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_screen.c | 34
1 file changed,
n aux offset possible.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_image.h | 3 +++
src/mesa/drivers/dri/i965/intel_screen.c | 5 +
2 files changed, 8 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_image.h
b/src/mesa/drivers/dri
This patch adds support for handling X tiled modifier. This isn't
particularly useful but it makes our code complete.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --
in miptree_release
v33:
Remove is_scanout assert in intel_miptree_create. It doesn't work with
latest codebase - not sure it ever should have worked.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/intel_mipmap_tre
This provides a common function or creating miptrees when there is an
existing DRIimage to use. That provides an easy way to add CCS
allocation.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_fbo.c | 17 -
src/mesa/drivers/dri
Since the code doesn't support modifiers yet, this patch should do
nothing other than prepare for more patches.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 64
1 file changed, 49 insertions(+), 15 dele
v2: Put the commit message as a comment (Topi)
Cc: Topi Pohjolainen
Cc: Ville Syrjälä
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers
Allows us to continue utilizing common miptree creation using __DRIimage
without creating a new DRIimage (for the intel_process_dri2_buffer()
case).
This is a bit ugly, but I think it's the best one can do.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index 971013f2dd
Make the code only disable CCS when it has to, unlike before where it
disabled CCS and enabled it when it could. This is much more inline with
how it should work in a few patches, where we have fewer restrictions as
to when we disable CCS.
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri
ectly.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index 451c5ccf4e..8ec33ce5df 100644
intel_miptree_make_shareable() when it's
scanout.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen (v1)
---
src/mesa/drivers/dri/i965/brw_context.c | 3 ++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 -
2 files changed, 10 insertions(+), 2 dele
patch.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index 12b3b071e4..9914eff6e0 100644
There is nothing particularly useful to do currently if the update
fails, but there is no point carrying on either. As a result, this has a
behavior change.
v2: Make the return type a bool (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
---
src/mesa
Upper layers of the code will have the need to specify full or partial
resolves (more on this in the next patch). This code simply adds the new
enums and plumbs it in as minimally as necessary.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
---
src/mesa
more concise (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_blorp.c | 8
src/mesa/drivers/dri/i965/brw_context.c | 13 +++--
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12 ++--
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
---
src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++-
src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++--
3 files changed, 6 insertions(+), 4
We no longer allocate a miptree for the mcs_buf, so this is not a useful
assertion.
While here, move the CCS disabling so that we only conditionally shut it
off. This helps us dtrt later when CCS is used in more places.
Recommended-by: Topi Pohjolainen
Signed-off-by: Ben Widawsky
---
src/mesa
nen
Cc: Chad Versace
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
ind
ces: https://patchwork.kernel.org/patch/9482393/
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/arc/arcpgu_crtc.c | 1 +
drivers/gpu/drm/arm/hdlcd_crtc.c| 1 +
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
drivers/gpu/drm/armada/armada_crtc.c
Sorry, ignore this. I sent to the wrong list.
On 17-01-26 14:16:23, Ben Widawsky wrote:
Originally based off of a patch by Kristian.
This new ioctl extends DRM_IOCTL_MODE_GETPLANE, by returning information
about the modifiers that will work with each format.
It's modified from Krist
On 17-01-23 15:32:32, Chad Versace wrote:
On Fri 20 Jan 2017, Rafael Antognolli wrote:
I have tested this series with the branches that you mentioned, and with
piglit with the patches from my own branch:
https://github.com/rantogno/piglit/tree/review/fences-v02
Everything seems to work fine. Y
On 17-03-23 14:02:13, Daniel Stone wrote:
Hi Ben,
On 24 January 2017 at 06:21, Ben Widawsky wrote:
@@ -1018,9 +1018,18 @@ intel_from_planar(__DRIimage *parent, int plane, void
*loaderPrivate)
int width, height, offset, stride, dri_format, index;
struct intel_image_format *f
On 17-04-06 20:12:35, Chris Wilson wrote:
IMG_context_priority
https://www.khronos.org/registry/egl/extensions/IMG/EGL_IMG_context_priority.txt
"This extension allows an EGLContext to be created with a priority
hint. It is possible that an implementation will not honour the
hint, especi
The API/entry point in mesa already checks the correct behavior,
however, it's possible to be handled by another implementation and those
implementations should not be able to abuse a weird combination of count
and pointer.
This fixes CID 1403193
Cc: Mark Janes
Signed-off-by: Ben Wid
_LOW_BIT;
+ break;
+default:
+ bit = -1;
+ break;
+ }
unreachable()?
Either way:
Reviewed-by: Ben Widawsky
+
+if (bit < 0 ||
+!(dpy->Extensions.IMG_context_priority & (1 << bi
gl_api api,
unsigned minor_version,
uint32_t flags,
bool notify_reset,
+ unsigned priority,
unsigned *error,
void *sharedContextPrivate)
{
LGTM on i965 (i915) and dri bits.
Acked-by: Ben Widawsky
--
Be
This is helpful for debugging as you will bail early with an error
message instead of a random SIGSEGV (or something more obscure).
---
drm-atomic.c | 9 +
drm-legacy.c | 8
2 files changed, 17 insertions(+)
diff --git a/drm-atomic.c b/drm-atomic.c
index 27c6b1e..c06e52f 100644
-
---
common.h | 4
1 file changed, 4 insertions(+)
diff --git a/common.h b/common.h
index 2eceac7..f3d9d32 100644
--- a/common.h
+++ b/common.h
@@ -32,6 +32,10 @@
#include
#include
+#ifdef HAVE_CONFIG_H
+ #include "config.h"
+#endif
+
#ifndef EGL_KHR_platform_gbm
#define EGL_KHR_plat
---
common.c | 13 -
common.h | 11 ++-
kmscube.c | 14 +++---
3 files changed, 29 insertions(+), 9 deletions(-)
diff --git a/common.c b/common.c
index e63bb39..eaaa9a4 100644
--- a/common.c
+++ b/common.c
@@ -31,9 +31,6 @@
static struct gbm gbm;
-#ifndef DRM_FO
Note: nothing happens here yet since LINEAR == 0.
---
configure.ac | 2 +-
drm-common.c | 37 +
2 files changed, 34 insertions(+), 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index 33167e4..f564ef3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3
---
common.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/common.c b/common.c
index 4bf3c5a..e63bb39 100644
--- a/common.c
+++ b/common.c
@@ -31,10 +31,23 @@
static struct gbm gbm;
+#ifndef DRM_FORMAT_MOD_LINEAR
+#define DRM_FORMAT_MOD_LINEAR 0
+#endif
+static int
---
configure.ac | 16
1 file changed, 16 insertions(+)
diff --git a/configure.ac b/configure.ac
index aa0ef36..33167e4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -49,5 +49,21 @@ if test "x$HAVE_GST" = "xyes"; then
fi
AM_CONDITIONAL(ENABLE_GST, [test "x$HAVE_GST" = "xyes"]
On 18-02-20 09:15:01, Antognolli, Rafael wrote:
On Tue, Feb 20, 2018 at 08:11:14AM -0800, Rafael Antognolli wrote:
On Fri, Feb 16, 2018 at 06:37:55PM -0800, Ben Widawsky wrote:
> On 18-02-16 13:44:00, Antognolli, Rafael wrote:
> > "This field controls the granularity of the re
antage of finer granularity
when preemption is available.
Does the kernel actually disable it? I thought the kernel just doesn't touch it
(I don't think it's whitelisted by the kernel either, it's just writable).
Signed-off-by: Rafael Antognolli
Cc: Ben Widawsky
---
This p
On 17-02-28 11:44:24, Jason Ekstrand wrote:
On Mon, Feb 27, 2017 at 7:23 PM, Ben Widawsky wrote:
On 17-02-27 18:40:41, Jason Ekstrand wrote:
On Mon, Feb 27, 2017 at 5:38 PM, Jason Ekstrand
wrote:
On Mon, Feb 27, 2017 at 4:56 PM, Ben Widawsky wrote:
On 17-01-31 13:24:55, Jason Ekstrand
v2: Make the error return be -1 instead of 0 because I think 0 is
actually valid.
v3: Set errno to EINVAL when the specified plane is above the total
planes. (Jason Ekstrand)
Return the bo's handle if there is no image ie. for dumb images like cursor
(Daniel)
Signed-off-by: Ben Widawsky
: Jason Ekstrand
Ben Widawsky (5):
gbm: Export a plane getter function
gbm: Export a getter for per plane handles
gbm: Create a gbm_device getter for stride
gbm: Export a per plane getter for stride
gbm: Export a per plane getter for offset
src/gbm/backends/dri/gbm_dri.c | 135
Jason's recommended change)
Make plane 0 return planar stride. This might break legacy behavior (Jason)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom (v1)
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 45 --
Jason's recommendation for handling the non-planar case.
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 33 +
src/gbm/gbm-symbols-check | 1 +
src/gbm/main/gbm.c
, ie. dumb bo (Daniel)
Cc: Daniel Stone
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 27 +++
src/gbm/gbm-symbols-check | 1 +
src/gbm/main/gbm.c | 10 ++
src/gbm/
This will be used so we can query information per plane.
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 7 +++
src/gbm/main/gbm.c | 2 +-
src/gbm/main/gbmint.h | 1 +
3 files changed, 9 insertions
On 17-03-07 08:28:09, Jason Ekstrand wrote:
On Mon, Mar 6, 2017 at 6:37 PM, Ben Widawsky wrote:
v2: Make the error return be -1 instead of 0 because I think 0 is
actually valid.
v3: Set errno to EINVAL when the specified plane is above the total
planes. (Jason Ekstrand)
Return the bo&#
e
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
---
src/gbm/backends/dri/gbm_dri.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index ac7ede87b6..9ddc2159fc 100644
--- a/src/gbm/backend
801 - 900 of 1066 matches
Mail list logo
