On 17-01-12 14:44:33, Daniel Stone wrote:
Hi Ben,
On 3 January 2017 at 02:36, Ben Widawsky <b...@bwidawsk.net> wrote:
Same as v1 with the requested fixes and tags added. v1 is here:
https://lists.freedesktop.org/archives/intel-gfx/2016-December/113639.html
I haven't yet updated kmscube to use Kristian's GET_PLANE2, but I will be doing
it this week, I hope. Now all patches but the last should be safe to merge
without the kernel actually defining, or supporting the new fourcc codes.
A couple of things I noticed whilst looking through: the new GBM
entrypoints all seem to leak the DRIimage, as noted (except I forgot
get_modifier too).
I don't think get_modifier has a leak - it doesn't do fromPlanar because we made
the decision (and it's already merged) that the modifier must be the same for
all planes. Unless you're thinking of something else. I got all the other leaks
thanks for spotting those; I feel stupid but I somehow thought the DRIimage that
got created was magically cleaned up somehow.
Also, probably more importantly, modifier 0 (linear) doesn't seem to be
handled; previously the LINEAR use flag accounted for this, so we should be
able to replace that by passing in a 0 modifier.
Yeah, before we started with GET_PLANE2 discussions, lack of modifier meant
linear, but now we have linear so I can handle that properly.
Daniel, I added your acked-by for all patches (even though I added a couple from
the original).
Fair enough; I have no real opinion on the later Intel-specific
patches, but if they work ...
I'll make sure to test it with your Weston branch at least to reciprocate.
Cheers,
Daniel
Thanks.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
