[Mesa-dev] [PATCH 47/75] st/nine: Fix specular w coordinate

2016-10-05 Thread Axel Davy
Found looking at Wine formulas. Fixes a few visual issues. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c

[Mesa-dev] [PATCH 45/75] st/nine: Fix condition for specular lightning

2016-10-05 Thread Axel Davy
Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 374e92f..1db312c 100644 --- a/src

[Mesa-dev] [PATCH 62/75] st/nine: Remove volume9 {Set/Get/Free}PrivateData functions

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Remove {Set/Get/Free}PrivateData in volume9. Functionality has been implement in IUnknown interface. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/nine_lock.c | 38 --- src/gallium/state_trackers/nine/volume9.c

[Mesa-dev] [PATCH 60/75] st/nine: Implement {Set/Get/Free}PrivateData in iunknown

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Implement {Set/Get/Free}PrivateData in iunknown to get rid of duplicated code in resource9 and volume9. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.c | 114 + src/gallium/state_trackers

[Mesa-dev] [PATCH 55/75] st/nine: Fix assert in NineUnknown_QueryInterface

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Tests showed that is allowed to call this method on object that have a zero refcount. Required for issue #230. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[Mesa-dev] [PATCH 70/75] st/nine: Assert on buffer creation failure

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Add an assert to make sure buffer creation doesn't fail. Add error handling in calling functions. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/swapchain9.c | 26 ++ 1 file changed, 18 insertions(

[Mesa-dev] [PATCH 34/75] st/nine: Fix tweening factor computation

2016-10-05 Thread Axel Davy
The computation was reversed. Deduced by tests on windows. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index

[Mesa-dev] [PATCH 19/75] st/nine: Partial software vertex processing support

2016-10-05 Thread Axel Davy
art of the application, but never use more than the normal limit. When the apps do not need the software vertex processing features, they do not seem to turn it on. This means it is ok if that path is slow. Thus no care has been made to make the path optimized. Signed-off-by: Axel Davy --- s

[Mesa-dev] [PATCH 46/75] st/nine: Disable parts of lighting calculation if no normal provided

2016-10-05 Thread Axel Davy
Behaviour found in Wine sources, and checked with some test apps. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 61 ++- 1 file changed, 35 insertions(+), 26 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium

[Mesa-dev] [PATCH 40/75] st/nine: Fix texbem

2016-10-05 Thread Axel Davy
Error found with wine tests. nine_shader was expecting another order than the one device9 was using. Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/device9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 10/75] st/nine: Add missing break

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Add missing break instruction. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/nine_pipe.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/nine/nine_pipe.h b/src/gallium/state_trackers/nine

[Mesa-dev] [PATCH 52/75] st/nine: Print interface id in NineUnknown_QueryInterface

2016-10-05 Thread Axel Davy
From: Patrick Rudolph To ease debugging print interface id. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/iunknown.c b/src/gallium

[Mesa-dev] [PATCH 63/75] st/nine: Remove resource9 {Set/Get/Free}PrivateData functions

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Remove {Set/Get/Free}PrivateData in resource9. Functionality has been implement in IUnknown interface. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/resource9.c | 115 +--- src/gallium/state_trackers

[Mesa-dev] [PATCH 66/75] st/nine: Prepare update_framebuffer for MS quality levels

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Compare resource's nr_samples instead of D3D multisample level. Required for multisample quality levels to work correct. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 8 1 file changed, 4 inser

[Mesa-dev] [PATCH 75/75] st/nine: More checks for GetRenderTargetData

2016-10-05 Thread Axel Davy
Fixes a wine test crash Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/device9.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c index 0c9e78b..b8d82be

[Mesa-dev] [PATCH 30/75] st/nine: Undefined specular should be full of zeros

2016-10-05 Thread Axel Davy
Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/nine_ff.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 391654f..d3772a6

[Mesa-dev] [PATCH 69/75] st/nine: Use NineDevice9_CreateDepthStencilSurface in swapchain9

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Replace custom code with NineDevice9_CreateDepthStencilSurface. All functionality is given now. --- src/gallium/state_trackers/nine/swapchain9.c | 30 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/gallium/state_trackers/nin

[Mesa-dev] [PATCH 56/75] st/nine: Add debugging output

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Add DBG calls to NineTexture9_GetLevelDesc and NineTexture9_GetSurfaceLevel to ease debugging. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/texture9.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium

[Mesa-dev] [PATCH 42/75] st/nine: Do not pollute rTmp in ff ps

2016-10-05 Thread Axel Davy
Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/nine_ff.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 680b967..1fc96fb 100644

[Mesa-dev] [PATCH 41/75] st/nine: Allocate temporaries on demand for ps ff

2016-10-05 Thread Axel Davy
Same change than for vs ff. This makes it easier to not introduce mistakes reusing temporaries whose result shouldn't be erased. Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/nine_ff.c | 24 ++-- 1 file changed, 10 inser

[Mesa-dev] [PATCH 31/75] st/nine: Fix ff SPECULARENABLE

2016-10-05 Thread Axel Davy
. Remove the vs code, and use the ps code. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index d3772a6

[Mesa-dev] [PATCH 65/75] st/nine: Add additional error handling in CheckDeviceMultiSampleType

2016-10-05 Thread Axel Davy
From: Patrick Rudolph Return one supported quality level in error cases. Return error on invalid multisample count. Fixes failing wine tests. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 6 ++ 1 file changed, 6 insertions

[Mesa-dev] [PATCH 39/75] st/nine: Fix ff computation for inverse

2016-10-05 Thread Axel Davy
Thanks to wine tests. Apparently 4x4 inverse is to be used, and if the inverse can't be calculated, the input matrix is to be used. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 26 ++ src/gallium/state_trackers/nine/nine_ff.h | 3 --- 2

[Mesa-dev] [PATCH 27/75] st/nine: Compact ff vs constants a bit

2016-10-05 Thread Axel Davy
There are several holes. This patch reduces the holes a bit, which reduces the size of the constant buffer uploaded. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH 01/75] llvmpipe: Fix overflow for 32 bits available memory computation

2016-10-06 Thread Axel Davy
On 06/10/2016 11:44, Emil Velikov wrote: Hi Axel, You seem to have forgotten/ignored virtually every suggestion for this patch from last time around. Did you send the wrong patch or ? Emil Well it was sitting on our repo, and I got persuaded I had addressed the issues. Looks like not. I'

[Mesa-dev] [PATCH 3/3] softpipe: Cap to 2 GB on 32 bits

2016-10-06 Thread Axel Davy
when 80% of the reported memory limit is used. This change helps some apps to start. Signed-off-by: Axel Davy --- src/gallium/drivers/softpipe/sp_screen.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c

[Mesa-dev] [PATCH 1/3] gallium/os: Fix overflow on 32 bits

2016-10-06 Thread Axel Davy
On systems with more than 4GB of ram, os_get_total_physical_memory was triggering an integer overflow for the linux and haiku path, when on 32 bits. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94561 Signed-off-by: Axel Davy --- src/gallium/auxiliary/os/os_misc.c | 4 ++-- 1 file

[Mesa-dev] [PATCH 2/3] llvmpipe: Cap to 2 GB on 32 bits

2016-10-06 Thread Axel Davy
when 80% of the reported memory limit is used. This change helps some apps to start. Signed-off-by: Axel Davy --- src/gallium/drivers/llvmpipe/lp_screen.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 02/75] gallium/util: Really allow aliasing for u_box_union_*

2016-10-06 Thread Axel Davy
Gallium nine relies on aliasing to work with this function. Without this patch, dirty region tracking was incorrect, which could lead to incorrect textures or vertex buffers. Fixes several game bugs with nine. Fixes https://github.com/iXit/Mesa-3D/issues/234 Signed-off-by: Axel Davy Reviewed-by

[Mesa-dev] [PATCH 02/75] gallium/util: Really allow aliasing of dst for u_box_union_*

2016-10-06 Thread Axel Davy
Gallium nine relies on aliasing to work with this function. Without this patch, dirty region tracking was incorrect, which could lead to incorrect textures or vertex buffers. Fixes several game bugs with nine. Fixes https://github.com/iXit/Mesa-3D/issues/234 Signed-off-by: Axel Davy Reviewed-by

Re: [Mesa-dev] [PATCH 02/75] gallium/util: Really allow aliasing for u_box_union_*

2016-10-06 Thread Axel Davy
Sorry, ignore this, I sent a new one with the corrected title. On 06/10/2016 19:57, Axel Davy wrote: Gallium nine relies on aliasing to work with this function. Without this patch, dirty region tracking was incorrect, which could lead to incorrect textures or vertex buffers. Fixes several game

Re: [Mesa-dev] [PATCH 04/75] st/nine: Fix some check flags

2016-10-06 Thread Axel Davy
On 06/10/2016 11:34, Emil Velikov wrote: On 5 October 2016 at 21:08, Axel Davy wrote: Uses the new defines introduced in previous commit. Please describe why the newly introduced flags are used over the present ones. Worth copying some of the in-source comment or referencing it ? -Emil Do

Re: [Mesa-dev] [PATCH 20/75] st/nine: Initial ProcessVertices support

2016-10-06 Thread Axel Davy
On 05/10/2016 22:08, Axel Davy wrote: HRESULT NINE_WINAPI NineDevice9_ProcessVertices( struct NineDevice9 *This, UINT SrcStartIndex, @@ -3174,33 +3188,69 @@ NineDevice9_ProcessVertices( struct NineDevice9 *This

Re: [Mesa-dev] [PATCH 20/75] st/nine: Initial ProcessVertices support

2016-10-06 Thread Axel Davy
On 06/10/2016 22:28, Ilia Mirkin wrote: On Thu, Oct 6, 2016 at 4:24 PM, Axel Davy wrote: On 05/10/2016 22:08, Axel Davy wrote: HRESULT NINE_WINAPI NineDevice9_ProcessVertices( struct NineDevice9 *This, UINT SrcStartIndex, @@ -3174,33 +3188,69

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-06 Thread Axel Davy
Hi, as of writing, there doesn't seem to be a concensus on the fix. Could one be found for Mesa 13 ? Gallium nine is apparently broken except on radeonsi which zeros out the next field... It'd need either the proposed patch of this thread merged, or to zero the next field everywhere. I guess oth

[Mesa-dev] [PATCH] st/nine: Memset pipe_resource templates

2016-10-09 Thread Axel Davy
Fixes regression introduced by ecd6fce2611e88ff8468a354cff8eda39f260a31 and is more future proof than just clearing the next field. Other nine usages did already zero out the templates. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 6 ++ src/gallium

Re: [Mesa-dev] [PATCH 1/3] gallium/os: Fix overflow on 32 bits

2016-10-10 Thread Axel Davy
On 10/10/2016 12:44, Emil Velikov wrote: On 6 October 2016 at 18:51, Axel Davy wrote: On systems with more than 4GB of ram, os_get_total_physical_memory was triggering an integer overflow for the linux and haiku path, when on 32 bits. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id

[Mesa-dev] [PATCH] gallium/os: Use unsigned integers for size computation

2016-10-11 Thread Axel Davy
Use uint64_t instead of int64_t in the calculation, as the result is uint64_t. Signed-off-by: Axel Davy --- This corrects the small mistake from 218459771a1801d7ad20dd340ac35a50f2b5b81a as reported by Emil. src/gallium/auxiliary/os/os_misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Mesa-dev] [PATCH] gallium/os: Use unsigned integers for size computation

2016-10-11 Thread Axel Davy
Chuck On Tue, Oct 11, 2016 at 12:59 PM, Axel Davy <mailto:axel.d...@ens.fr>> wrote: Use uint64_t instead of int64_t in the calculation, as the result is uint64_t. Signed-off-by: Axel Davy mailto:axel.d...@ens.fr>> --- This correc

Re: [Mesa-dev] [PATCH 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

2016-10-11 Thread Axel Davy
On 11/10/2016 20:31, Emil Velikov wrote: - udev = udev_new(); - if (!udev) - goto prime_clean; + if (drmGetDevice(default_fd, &device) != 0) + goto err; - default_device_id_path_tag = get_id_path_tag_from_fd(udev, default_fd); - if (!default_device_id_path_tag) - g

[Mesa-dev] [PATCH 1/2] st/nine: Remove useless code in nine_shader

2016-10-12 Thread Axel Davy
Since 1604efa6fda9b780e8537a131ad77f3e83e5a67a, lconsti and lconstb don't need to be initialized. Remove some leftovers from the previous code (which has now invalid use of ARRAY_SIZE on a pointer instead of an array). Reported by Coverity. Signed-off-by: Axel Davy --- src/ga

[Mesa-dev] [PATCH 2/2] st/nine: Fix possible segfault in surface ctor

2016-10-12 Thread Axel Davy
of previous code. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/surface9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/surface9.c b/src/gallium/state_trackers/nine/surface9.c index dc31bb9..664b78f 100644 --- a/src/gall

Re: [Mesa-dev] [PATCH 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

2016-10-12 Thread Axel Davy
On 12/10/2016 19:15, Emil Velikov wrote: On 11 October 2016 at 19:54, Axel Davy wrote: On 11/10/2016 20:31, Emil Velikov wrote: - udev = udev_new(); - if (!udev) - goto prime_clean; + if (drmGetDevice(default_fd, &device) != 0) + goto err; - default_device_id_path

Re: [Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

2016-10-14 Thread Axel Davy
y for libudev users and allow others to benefit from it as well. v2: Drop ranty comments, pick the correct device Cc: Axel Davy Signed-off-by: Emil Velikov --- src/loader/loader.c | 247 ++-- 1 file changed, 106 insertions(+), 141 deletions(-)

Re: [Mesa-dev] [PATCH 11/16] travis: remove no longer needed liudev-dev dependency

2016-10-15 Thread Axel Davy
typo in the commit title: libudev-dev Axel On 11/10/2016 20:31, Emil Velikov wrote: From: Emil Velikov Signed-off-by: Emil Velikov --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 5f489a4..3d107aa 100644 --- a/.travis.yml +++ b/.travis.yml

Re: [Mesa-dev] [PATCH v2 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

2016-10-15 Thread Axel Davy
On 14/10/2016 22:33, Emil Velikov wrote: On 14 October 2016 at 20:21, Axel Davy wrote: The code looks good. With the minor nitpick fixed, this patch is: Reviewed-by: Axel Davy Thanks. If you can skim through any of the other patches that'll be appreciated. Emil I've looked t

[Mesa-dev] [PATCH] st/nine: Fix multisample limit check

2016-10-16 Thread Axel Davy
Fixes regression introduced by b5603056872708fdd82f1224854097805a01d4c0 The regression prevents some apps to start. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine

Re: [Mesa-dev] [PATCH] st/nine: Fix multisample limit check

2016-10-16 Thread Axel Davy
I've pushed this just now to be sure it makes it for mesa 13. On 16/10/2016 11:47, Axel Davy wrote: Fixes regression introduced by b5603056872708fdd82f1224854097805a01d4c0 The regression prevents some apps to start. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapt

Re: [Mesa-dev] [PATCH 1/6] gallium/radeon: change the vendor string to Advanced Micro Devices, Inc.

2016-08-06 Thread Axel Davy
Hi, This looks like it will perturb driver detection of already written games. For example from the dolphin sources, this change would make them detect catalyst as driver. As it is known workarounds are applied depending on the driver detected, or some features are disabled, I believe it is

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-09-02 Thread Axel Davy
Le 02/09/2016 à 03:06, Michel Dänzer a écrit : On 02/09/16 12:37 AM, Alex Deucher wrote: On Thu, Sep 1, 2016 at 11:28 AM, Jason Ekstrand wrote: On Aug 31, 2016 11:39 PM, "Michel Dänzer" wrote: On 01/09/16 02:05 PM, Jason Ekstrand wrote: On Wed, Aug 31, 2016 at 7:00 PM, Michel Dänzer mailto:

Re: [Mesa-dev] [PATCH] loader/dri3: Overhaul dri3_update_num_back

2016-09-02 Thread Axel Davy
Le 02/09/2016 à 16:41, Axel Davy a écrit : Le 02/09/2016 à 03:06, Michel Dänzer a écrit : On 02/09/16 12:37 AM, Alex Deucher wrote: On Thu, Sep 1, 2016 at 11:28 AM, Jason Ekstrand wrote: On Aug 31, 2016 11:39 PM, "Michel Dänzer" wrote: On 01/09/16 02:05 PM, Jason Ekstrand wrot

Re: [Mesa-dev] [PATCH 2/3] egl: return corresponding offset of EGLImage instead of 0.

2016-09-08 Thread Axel Davy
some interface version implementation check. (another nitpick: queryImage return true or false, not EGL_TRUE/EGL_FALSE. It's better to convert, instead of assuming they're the same) Yours, Axel Davy On 06/09/2016 11:06, Chuanbo Weng wrote: The offset should not always be 0. For examp

Re: [Mesa-dev] [PATCH 2/3] egl: return corresponding offset of EGLImage instead of 0.

2016-09-08 Thread Axel Davy
That doesn't seem good to me. With that patch, that means that since no one is implementing __DRI_IMAGE_ATTRIB_OFFSET (yes I know in a later patch you implement it for i965), then what used to work will stop working (as the queryImage will return false). You need to introduce some interface

Re: [Mesa-dev] [PATCH v2 2/3] egl: return corresponding offset of EGLImage instead of 0.

2016-09-09 Thread Axel Davy
ALSE; offsets[0] = img_offset; } } return EGL_TRUE; Axel Davy On 09/09/2016 17:34, Weng, Chuanbo wrote: The comments from Emil can be summarized into the following code: if (offsets) { offsets[0] = 0; EGLint img_offset = 0;

[Mesa-dev] [PATCH 1/2] st/nine: Fix leak with integer and boolean constants

2016-10-18 Thread Axel Davy
. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 39 +--- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_state.c b/src/gallium/state_trackers/nine/nine_state.c index f6bf51e..ea72c77 100644

[Mesa-dev] [PATCH 2/2] st/nine: Fix leak at device dtor

2016-10-18 Thread Axel Davy
The datastructures to track dirty constants weren't freed. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c

Re: [Mesa-dev] [PATCH 2/2] st/nine: Fix leak at device dtor

2016-10-20 Thread Axel Davy
For some reason, it introduces crashes. Not sure why. I also figured out this doesn't free anything. There seems to be missing code to free the 'nine_range_pool', and we leak at every device dtor. Patch 1/2 is still an important fix to avoid leaks. On 18/10/2016 23:11, Axel D

[Mesa-dev] [PATCH 1/4] gallium/util: Add align_calloc

2016-10-22 Thread Axel Davy
Add implementation for align_calloc, which is align_malloc + memset. Signed-off-by: Axel Davy --- src/gallium/auxiliary/util/u_memory.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/util/u_memory.h b/src/gallium/auxiliary/util/u_memory.h index 597df62

[Mesa-dev] [PATCH 2/4] st/nine: Use align_calloc instead of align_malloc

2016-10-22 Thread Axel Davy
We are not sure exactly what needs to be 0 initialized, but we are missing some cases. 0 initialize all our current aligned allocation. Fixes Tree of Savior visual issues. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/buffer9.c | 2 +- src/gallium/state_trackers/nine

[Mesa-dev] [PATCH 4/4] st/nine: Fix locking CubeTexture surfaces

2016-10-22 Thread Axel Davy
Only one Face of Cubetextures were locked when in DEFAULT Pool. Fixes: https://github.com/iXit/Mesa-3D/issues/129 CC: "12.0 13.0" Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/surface9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_tra

[Mesa-dev] [PATCH 3/4] st/nine: Fix mistake in Volume9 UnlockBox

2016-10-22 Thread Axel Davy
In the format fallback path, the height was used instead of the depth. CC: "12.0 13.0" Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/volume9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/volume9.c b/s

Re: [Mesa-dev] [PATCH 1/4] gallium/util: Add align_calloc

2016-10-22 Thread Axel Davy
On 22/10/2016 16:42, Brian Paul wrote: On Sat, Oct 22, 2016 at 4:28 AM, Axel Davy <mailto:axel.d...@ens.fr>> wrote: Add implementation for align_calloc, which is align_malloc + memset. Signed-off-by: Axel Davy mailto:axel.d...@ens.fr>> --- src/gallium

[Mesa-dev] [PATCH 1/4 v2] gallium/util: Add align_calloc

2016-10-23 Thread Axel Davy
Add implementation for align_calloc, which is align_malloc + memset. v2: add if (ptr) before memset. Fix indentation. Signed-off-by: Axel Davy --- src/gallium/auxiliary/util/u_memory.h | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/util/u_memory.h b/src

[Mesa-dev] [PATCH 00/84] Introduce gallium nine internal multithreading

2016-12-07 Thread Axel Davy
ly most commands are said to be put into a worker thread, while buffer locks and check for query results are made with reentrant functions in the main thread. Some tests suggest MANAGED pool upload is done in the worker thread, like the gallium patch serie implements. Thus we expect performance to be

[Mesa-dev] [PATCH 05/84] st/nine: Move texture setting to nine_context_*

2016-12-07 Thread Axel Davy
And move samplers_shadow to nine_context. Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 36 src

[Mesa-dev] [PATCH 18/84] st/nine: Put ff data in a separate structure

2016-12-07 Thread Axel Davy
And make nine_state_access_transform take this new structure as input. Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 6 ++-- src

[Mesa-dev] [PATCH 09/84] st/nine: Move stream freq data to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 19 src/gallium/state_trackers/nine/nine_state.c | 32

[Mesa-dev] [PATCH 13/84] st/nine: Back all shader constants to nine_context

2016-12-07 Thread Axel Davy
For device vs shader float constants and may_swvp, the same tips than for the other constant types is used. Also memset the constants properly. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 138 ++ src/gallium/state_trackers/nine/nine_state.c | 349

[Mesa-dev] [PATCH 06/84] st/nine: Back textures into nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 1 + src/gallium/state_trackers/nine/device9.c | 2 ++ src/gallium

[Mesa-dev] [PATCH 04/84] st/nine: Track changed.texture only for stateblocks

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 4 +--- src/gallium/state_trackers/nine/device9.c | 3 ++- src/gallium

[Mesa-dev] [PATCH 02/84] st/nine: Move core of device clear to nine_state

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 130 + src/gallium/state_trackers/nine/nine_state.c | 166

[Mesa-dev] [PATCH 07/84] st/nine: Move stream_usage_mask to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 6 +++--- src/gallium/state_trackers/nine/nine_state.h | 3 ++- 2 files changed, 5

[Mesa-dev] [PATCH 19/84] st/nine: Refactor SetLight

2016-12-07 Thread Axel Davy
Call a helper function to set the light. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 24 src/gallium/state_trackers/nine/nine_state.c | 28 src/gallium/state_trackers/nine/nine_state.h | 3 +++ 3 files

[Mesa-dev] [PATCH 29/84] st/nine: Access pipe_context via NineDevice9_GetPipe

2016-12-07 Thread Axel Davy
Except for nine_ff and nine_state. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 13 +--- src/gallium/state_trackers/nine/basetexture9.h | 1 - src/gallium/state_trackers/nine/buffer9.c | 16 + src/gallium/state_trackers/nine/buffer9.h

[Mesa-dev] [PATCH 34/84] st/nine: Move Managed Pool handling out of nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 57 src/gallium/state_trackers/nine/nine_state.c | 32

[Mesa-dev] [PATCH 28/84] st/nine: Remove NineDevice9_GetCSO

2016-12-07 Thread Axel Davy
Was useless. Remove useless usage in swapchain9. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 6 -- src/gallium/state_trackers/nine/device9.h| 3 --- src/gallium/state_trackers/nine/swapchain9.c | 1 - src/gallium/state_trackers/nine/swapchain9.h | 1 - 4

[Mesa-dev] [PATCH 15/84] st/nine: Back RT to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 16 +++- src/gallium/state_trackers/nine/nine_state.c | 54

[Mesa-dev] [PATCH 24/84] st/nine: Back User Clip Planes to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 5 - src/gallium/state_trackers/nine/nine_state.c | 30

[Mesa-dev] [PATCH 20/84] st/nine: Refactor LightEnable

2016-12-07 Thread Axel Davy
Call a helper function. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 25 +--- src/gallium/state_trackers/nine/nine_state.c | 35 src/gallium/state_trackers/nine/nine_state.h | 4 3 files changed, 40 insertions

[Mesa-dev] [PATCH 08/84] st/nine: Move vtxbuf to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 33 -- src/gallium/state_trackers/nine/nine_state.c | 66

[Mesa-dev] [PATCH 25/84] st/nine: Track dirty state groups in nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 3 +- src/gallium/state_trackers/nine/device9.c | 2 +- src/gallium

[Mesa-dev] [PATCH 22/84] st/nine: Back ds to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 7 +++--- src/gallium/state_trackers/nine/nine_state.c | 33

[Mesa-dev] [PATCH 12/84] st/nine: Back sampler states to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 18 +++--- src/gallium/state_trackers/nine/nine_state.c | 83

[Mesa-dev] [PATCH 17/84] st/nine: Back viewport to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 4 ++- src/gallium/state_trackers/nine/nine_ff.c| 2 +- src/gallium

[Mesa-dev] [PATCH 01/84] st/nine: Introduce nine_context

2016-12-07 Thread Axel Davy
nine_context is a new structure which goal will be to contain all internal states. It will be the states of the second thread in the to-be-introduced CSMT mode. This patch moves several internal states to nine_context, while the next patches add the other fields. Signed-off-by: Axel Davy

[Mesa-dev] [PATCH 30/84] st/nine: Rename cso in nine_context to cso_shader

2016-12-07 Thread Axel Davy
This patch it to avoid name conflict when device->cso is moved to nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c| 12 ++-- src/gallium/state_trackers/nine/nine_state.h| 2 +- src/gallium/state_trackers/nine/pixelshader9.c | 4 ++--

[Mesa-dev] [PATCH 03/84] st/nine: Move draw calls to nine_state

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 209 +++-- src/gallium/state_trackers/nine/nine_ff.c | 84

[Mesa-dev] [PATCH 65/84] st/nine: Fix NineUnknown_Detach

2016-12-07 Thread Axel Davy
We don't bind the container in AddRef. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/iunknown.h b/src/gallium/state_trackers/nine/iunknown.h index d357aad..dd

[Mesa-dev] [PATCH 10/84] st/nine: Back vdecl to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 21 +-- src/gallium/state_trackers/nine/nine_ff.c | 10

[Mesa-dev] [PATCH 21/84] st/nine: Back all ff states in nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 60 -- src/gallium/state_trackers/nine/nine_ff.c | 114

[Mesa-dev] [PATCH 37/84] st/nine: Decompose nine_context_set_indices

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 32 +--- 1 file changed, 24 insertions(+), 8 deletions

[Mesa-dev] [PATCH 62/84] st/nine: Add CSMT_NO_WAIT_WITH_COUNTER

2016-12-07 Thread Axel Davy
From: Patrick Rudolph Similar to the other macros, but introduces a counter, which enables to know when the instructions has been executed. Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/nine_csmt_helper.h | 54 ++ 1 file changed, 54 insertions(+) diff

[Mesa-dev] [PATCH 60/84] st/nine: Optimize ColorFill

2016-12-07 Thread Axel Davy
When we lock the whole surface to overwrite it, we can use DISCARD. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c

[Mesa-dev] [PATCH 26/84] st/nine: Use atomics for nine_bind

2016-12-07 Thread Axel Davy
nine_bind didn't need atomics up to now, because it's use what always within a protected mutex. We need to use atomics because with the next patches several threads may use nine_bind. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.h | 5 +++-- 1 file changed, 3

[Mesa-dev] [PATCH 35/84] st/nine: Do not use NineBaseTexture9 in nine_context

2016-12-07 Thread Axel Davy
Some fields are subject to modification outside of nine_context (SetLod, etc). Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.c | 21 src/gallium/state_trackers/nine/nine_ff.c | 6 +-- src/gallium/state_trackers/nine/nine_state.c | 73

[Mesa-dev] [PATCH 11/84] st/nine: Back vs to nine_context

2016-12-07 Thread Axel Davy
And move programmable_vs storage and computation. Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 26 +-- src/gallium

[Mesa-dev] [PATCH 27/84] st/nine: Move query9 pipe calls to nine_context

2016-12-07 Thread Axel Davy
This will enable to use threading for them. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 33 src/gallium/state_trackers/nine/nine_state.h | 17 ++ src/gallium/state_trackers/nine/query9.c | 32

[Mesa-dev] [PATCH 51/84] st/nine: Simplify the logic to bind textures

2016-12-07 Thread Axel Davy
This makes the code more readable. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/basetexture9.h | 20 ++ src/gallium/state_trackers/nine/device9.c | 11 +- src/gallium/state_trackers/nine/stateblock9.c | 55 -- 3 files changed, 47

[Mesa-dev] [PATCH 36/84] st/nine: Decompose nine_context_set_stream_source

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 34 1 file changed, 25 insertions(+), 9 deletions

[Mesa-dev] [PATCH 23/84] st/nine: Back ps to nine_context

2016-12-07 Thread Axel Davy
Part of the refactor to move all gallium calls to nine_state.c, and have all internal states required for those calls in nine_context. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 29 src/gallium/state_trackers/nine/nine_ff.c| 6 ++-- src

<    1   2   3   4   5   6   7   8   9   10   >