[Mesa-dev] clover build fail with git llvm

Making all in state_trackers/clover make[3]: Entering directory '/mnt/sdb1/Src64/Mesa-git/mesa/src/gallium/state_trackers/clover' CXX llvm/libclllvm_la-invocation.lo llvm/invocation.cpp: In function 'void {anonymous}::optimize(llvm::Module*, unsigned int, const std::vector&)': llvm/invo

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

Mark Thompson wrote: On 26/01/17 18:26, Andy Furniss wrote: Tested with ffmpeg and gst-vaapi. Without this bits per frame is set way too low. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/picture.c | 32 1 file changed, 24 insertions(+), 8

[Mesa-dev] [PATCH v2] st/va encode handle ntsc framerate rate control

Tested with ffmpeg and gst-vaapi. Without this bits per frame is set way too low for fractional framerates. v2: Mark Thompson: simplify calculation. Use float. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/picture.c | 19 +-- 1 file changed, 13 insertions

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

Mark Thompson wrote: On 27/01/17 22:06, Andy Furniss wrote: Could use floats I guess like I did here. https://cgit.freedesktop.org/mesa/mesa/commit/?id=a5993022275c20061ac025d9adc26c5f9d02afee I don't know what the preference is between float and int. I think float is fine here? I

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

Christian König wrote: That looks correct to me, but I'm not deeply enough into the H264 encoding any more. Adding Leo and Boyuan to comment as well. I just sent v2 to list and tried to cc Boyuan and Leo but it failed. git send-email -1 -v2 --to=mesa-dev@lists.freedesktop.org --cc=christian.

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI

Rainer Hochecker wrote: On 27.01.2017 12:26, Andy Furniss wrote: Peter Frühberger wrote: just tell us when we can remove: https://github.com/FernetMenta/kodi-agile/blob/master/xbmc/cores/VideoPlayer/DVDCodecs/Video/VAAPI.cpp#L534 Maybe I mis-remember, but doesn't AMD also need som

Re: [Mesa-dev] [PATCH] st/va: Support fractional framerate in misc parameter

Mark Thompson wrote: Signed-off-by: Mark Thompson --- See - this is a recent addition, but is backwards-compatible. Depends on Andy's patch for actual support fo

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

Michel Dänzer wrote: On 30/01/17 12:08 AM, Andy Furniss wrote: Christian König wrote: That looks correct to me, but I'm not deeply enough into the H264 encoding any more. Adding Leo and Boyuan to comment as well. I just sent v2 to list and tried to cc Boyuan and Leo but it failed. git

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

Nayan Deshmukh wrote: Any ideas why? I am attaching the diff for reference. Could be that the shader based decoder has a bug with multiple slices as well. It could be. Andy can you test it with your hardware decoder to see if its specific to shader decoder. Can you re-send or attach anyth

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

Nayan Deshmukh wrote: Hi Andy, I am attaching the patches. Does it cause any difference in the corruption in this video? https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s Hi, it seems mpv and ffmpeg have been changing their vaapi code recently. With an old mpv the corr

Re: [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

Zhang, Boyuan wrote: Hi Leo, Christian and Julien, I tested the patch with Vaapi Encoding and Transcoding, it seems working fine. We are using "VAAPI_DISABLE_INTERLACE" env, so interlaced is always disabled. Though I notice it will break screen recording scripts for existing users who previous

Re: [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

Leo Liu wrote: Hi Andy, On 09/13/2016 06:22 AM, Andy Furniss wrote: Zhang, Boyuan wrote: Hi Leo, Christian and Julien, I tested the patch with Vaapi Encoding and Transcoding, it seems working fine. We are using "VAAPI_DISABLE_INTERLACE" env, so interlaced is always disabled.

Re: [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

Leo Liu wrote: On 09/13/2016 01:29 PM, Andy Furniss wrote: Leo Liu wrote: Hi Andy, On 09/13/2016 06:22 AM, Andy Furniss wrote: Zhang, Boyuan wrote: Hi Leo, Christian and Julien, I tested the patch with Vaapi Encoding and Transcoding, it seems working fine. We are using

Re: [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

Andy Furniss wrote: Leo Liu wrote: mpv --vo-vaapi all is apparently OK when playing say a 25fps vid, but I've found that if I push the framerate to refresh rate and do something that draws OSD than image is corrupted, possible many VM faults logged followed by a segfau

Re: [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

Andy Furniss wrote: Leo Liu wrote: Hi Andy, On 09/13/2016 06:22 AM, Andy Furniss wrote: Zhang, Boyuan wrote: Hi Leo, Christian and Julien, I tested the patch with Vaapi Encoding and Transcoding, it seems working fine. We are using "VAAPI_DISABLE_INTERLACE" env, so interlaced

[Mesa-dev] [PATCH] st/va: Make VAAPI_DISABLE_INTERLACE default true

Since bf901a2 st/va: also honors interlaced preference when providing a video format existing scripts and most use cases will need true. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

Leo Liu wrote: Hi Andy, On 09/13/2016 06:22 AM, Andy Furniss wrote: Zhang, Boyuan wrote: Hi Leo, Christian and Julien, I tested the patch with Vaapi Encoding and Transcoding, it seems working fine. We are using "VAAPI_DISABLE_INTERLACE" env, so interlaced is always disabled.

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Nayan Deshmukh wrote: This series implements lanczos interpolation filter. Andy, I have made some changes to the code. Can you test the patches. I hope the artifacts are reduced this time. The artifacts are still there. In addition 5,6 and 7 take an increasing time to start. It could be becau

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Andy Furniss wrote: Nayan Deshmukh wrote: This series implements lanczos interpolation filter. Andy, I have made some changes to the code. Can you test the patches. I hope the artifacts are reduced this time. The artifacts are still there. To be a bit more precise 2 and 4 seem to be

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Nayan Deshmukh wrote: Hi Andy, Thanks for testing the patches!! On Mon, Sep 19, 2016 at 5:24 AM, Andy Furniss wrote: Andy Furniss wrote: Nayan Deshmukh wrote: This series implements lanczos interpolation filter. Andy, I have made some changes to the code. Can you test the patches. I

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Andy Furniss wrote: bz2 compressed vid showing the issue - https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms To be clear this is just the test rez vid I used so you can possibly recreate the issue your self. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Andy Furniss wrote: Andy Furniss wrote: bz2 compressed vid showing the issue - https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms To be clear this is just the test rez vid I used so you can possibly recreate the issue your self. Hmm, interesting, with bicubic, hqscaling=1 this

Re: [Mesa-dev] [PATCH] st/va: Make VAAPI_DISABLE_INTERLACE default true

Julien Isorce wrote: On 16 September 2016 at 08:43, Christian König wrote: Am 15.09.2016 um 23:07 schrieb Julien Isorce: On 15 September 2016 at 16:02, Leo Liu wrote: On 09/15/2016 10:43 AM, Andy Furniss wrote: Since bf901a2 st/va: also honors interlaced preference when providing a

Re: [Mesa-dev] [PATCH] st/va: Make VAAPI_DISABLE_INTERLACE default true

Andy Furniss wrote: Hi @Andy, could you update your patch to move that debug env flag to radeon ? Thx I don't know mesa code that well so maybe I misunderstand, but, if I default to true and test in there it will affect vdpau decode as well which I guess will disable de-interlace and

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: bz2 compressed vid showing the issue - https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms To be clear this is just the test rez vid I used so you can possibly recreate the issue your self. Hmm, interesting, with

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: bz2 compressed vid showing the issue - https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms To be clear this is just the test rez vid I used so you can possibly recreate the issue your self. Hmm

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Christian König wrote: Am 21.09.2016 um 16:38 schrieb Andy Furniss: Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: bz2 compressed vid showing the issue - https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms To be clear this is just the test rez vid I used so you can

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Nayan Deshmukh wrote: Hi Andy, On Wed, Sep 21, 2016 at 9:30 PM, Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: bz2 compressed vid showing the issue - https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms To be clear

[Mesa-dev] [PATCH] st/va Avoid VBR bitrate calculation overflow

VBR bitrate calc needs 64 bits at high rates. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index 7f3d96d..cd2dabb

Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

Leo Liu wrote: On 09/07/2016 03:02 AM, Christian König wrote: Am 06.09.2016 um 22:39 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang This patch enables variable bit-rate for vaapi encoding. According to va.h, target bit-rate equals to maximum bit-rate multiplies by target_percentage. Sign

Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

Andy Furniss wrote: https://patchwork.freedesktop.org/patch/112040/ Hmm that got mungled I'll try again later going to be AFK for a while. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo

[Mesa-dev] [PATCH] st/va Avoid VBR bitrate calculation overflow

VBR bitrate calc needs 64 bits at high rates. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index 7f3d96d..cd2dabb

Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

Andy Furniss wrote: Andy Furniss wrote: https://patchwork.freedesktop.org/patch/112040/ Hmm that got mungled I'll try again later going to be AFK for a while. This one worked. https://patchwork.freedesktop.org/patch/112069/ ___ mesa-dev ma

Re: [Mesa-dev] [PATCH] st/va Avoid VBR bitrate calculation overflow

Ignore this one un-mungled version sent. Andy Furniss wrote: VBR bitrate calc needs 64 bits at high rates. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b

[Mesa-dev] [PATCH] v2 st/va Avoid VBR bitrate calculation overflow

VBR bitrate calc needs 64 bits at high rates. v2 use float. Signed-off-by: Andy Furniss --- src/gallium/state_trackers/va/picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index

Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: https://patchwork.freedesktop.org/patch/112040/ Hmm that got mungled I'll try again later going to be AFK for a while. This one worked. https://patchwork.freedesktop.org/patch/112069/ Or maybe a version that uses floa

Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

o for baseline higher than 42.94 mbit is not that extreme. Anyway Christian acked my v2 patch - https://patchwork.freedesktop.org/patch/112161/ Regards, Boyuan -Original Message- From: Andy Furniss [mailto:adf.li...@gmail.com] Sent: September-25-16 6:46 AM To: Liu, Leo; Christian

Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for vaapi encode

Andy Furniss wrote: Zhang, Boyuan wrote: For the overflow concern, unsigned int can handle about 4294Mbit/s, which we thought is big enough for real life cases, right? Yea, but it gets x 100 and my vce can do at least 2160p so for baseline higher than 42.94 mbit is not that extreme. OK so

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

Mark Thompson wrote: --- A simple fix to the problem described here: . With this applied, the driver no longer hangs/crashes when vaSyncSurface() is called in places other than for the first time after an encode operat

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

Mark Thompson wrote: On 27/09/16 00:49, Andy Furniss wrote: Mark Thompson wrote: --- A simple fix to the problem described here: <https://lists.freedesktop.org/archives/mesa-dev/2016-September/128076.html>. With this applied, the driver no longer hangs/crashes when vaSyncSurface() is

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

Mark Thompson wrote: On 27/09/16 16:48, Andy Furniss wrote: Ok, thanks, so with that I am back to where I was before it stopped working. In summary baseline works but JM ref decoder doesn't like the pocs. b frames don't work properly, but then they don't with gst vaapi either

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

Andy Furniss wrote: I started to get some numbers but found a possible bug = I made a 1000 frame 15mbit 1080p50 mkv with ffmpeg/libx264. Using it as source for transcode (s/w or h/w dec) it came out far too low bitrate. After re-applying debugging patch to mesa it turns out that framerate is

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

Andy Furniss wrote: Andy Furniss wrote: I started to get some numbers but found a possible bug = I made a 1000 frame 15mbit 1080p50 mkv with ffmpeg/libx264. Using it as source for transcode (s/w or h/w dec) it came out far too low bitrate. After re-applying debugging patch to mesa it turns

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

Mark Thompson wrote: On 28/09/16 11:47, Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: I started to get some numbers but found a possible bug = I made a 1000 frame 15mbit 1080p50 mkv with ffmpeg/libx264. Using it as source for transcode (s/w or h/w dec) it came out far too low

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

Boyuan Zhang wrote: This patch improves the performance of Vaapi Encode by enabling dual instances encoding. flush function is not called after each end_frame call. radeon/vce will do flush whenever 2 frames are submitted for encoding. Implement sync surface function to flush only if the frame ha

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

Zhang, Boyuan wrote: Hi Andy, Thanks for the testings. Regarding to the inconsistencies, the current Vaapi dual instances encoding behaviour is random. Whether or not the dual instances is being used depends on how early the player calls sync_surface function according to the current gstreamer-

Re: [Mesa-dev] [PATCH 1/2] radeonsi: disable ReZ

Marek Olšák wrote: From: Marek Olšák This is a serious performance fix. Discovered by luck. Hmm, maybe I should bump my bugs more aggressively :-) https://bugs.freedesktop.org/show_bug.cgi?id=94354 Cc: 12.0 --- src/gallium/drivers/radeonsi/si_state_shaders.c | 11 --- 1 file c

Re: [Mesa-dev] [PATCH 1/5] st/va: Return more useful config attributes

Mark Thompson wrote: On 13/10/16 08:20, Christian König wrote: Am 13.10.2016 um 00:52 schrieb Mark Thompson: The encoder attributes are needed for a user of the encoder to be able to configure it sensibly without internal knowledge. Reviewed-by: Christian König for the whole series. Do you

Re: [Mesa-dev] [PATCH 1/5] st/va: Return more useful config attributes

Andy Furniss wrote: Mark Thompson wrote: On 13/10/16 08:20, Christian König wrote: Am 13.10.2016 um 00:52 schrieb Mark Thompson: The encoder attributes are needed for a user of the encoder to be able to configure it sensibly without internal knowledge. Reviewed-by: Christian König for the

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Christian König wrote: Am 12.08.2016 um 16:02 schrieb Nayan Deshmukh: Apply the median and matrix filter before the compostioning we apply the deinterlacing first to avoid the extra overhead in processing the past and the future surfaces in deinterlacing. v2: apply the filters on all the surfac

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Nayan Deshmukh wrote: Hi Andy, You are right :( It messes up chroma but only in case of sharpen at least for me. Retested and denoise is also affected for me. I tried some changes and the chroma effects are fixed if we apply the sharpness filter to only to the first surface instead of all

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Nayan Deshmukh wrote: Hi Andy, So can you please it try it again by replacing VL_MAX_SURFACES with 1 in the for loop. It should probably fix the problems. Yea, I should have though of that - it does fix, but I see things have moved on anyway. __

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Nayan Deshmukh wrote: Sorry for the misleading language. What I meant was that the filter should only be applied to first resource i.e. use only first sampler_view and surface. As you replaced i by 0 the filter gets applied multiple times. I tried doing that and I am experiencing same problems i

Re: [Mesa-dev] [PATCH v3] st/vdpau: change the order in which filters are applied(v3)

Christian König wrote: Top and Bottom field are separated in this representation. So you got a maximum of 3 planes multiplied by two fields. Ahh, thanks. Regards, Christian. Am 17.08.2016 um 11:11 schrieb Andy Furniss: Nayan Deshmukh wrote: Sorry for the misleading language. What I

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

Boyuan Zhang wrote: This patch improves the performance of Vaapi Encode by enabling dual instances encoding. flush function is not called after each end_frame call. radeon/vce will do flush whenever 2 frames are submitted for encoding. Implement sync surface function to flush only if the frame

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

Andy Furniss wrote: Boyuan Zhang wrote: This patch improves the performance of Vaapi Encode by enabling dual instances encoding. flush function is not called after each end_frame call. radeon/vce will do flush whenever 2 frames are submitted for encoding. Implement sync surface function to

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it if the user space doesn't set baseline? I don't know how in gstreamer as it seems to try to use b-frames if you use other than baseline which doesn

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

Christian König wrote: Am 18.10.2016 um 11:19 schrieb Andy Furniss: boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it if the user space doesn't set baseline? I don't know how in

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

Andy Furniss wrote: Christian König wrote: Am 18.10.2016 um 11:19 schrieb Andy Furniss: boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't there be code allows it if the user space doesn't set baseline? I

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

Christian König wrote: Am 18.10.2016 um 15:42 schrieb Andy Furniss: Andy Furniss wrote: Christian König wrote: Am 18.10.2016 um 11:19 schrieb Andy Furniss: boyuan.zh...@amd.com wrote: From: Boyuan Zhang cabac is only supported in the h264 main and higher profiles So shouldn't the

Re: [Mesa-dev] [PATCH] st/va: disable cabac for h264 baseline profile

Andy Furniss wrote: I see va.h has a cabac switch and gstreamer exposes it - though it's not read by the driver. Maybe if that were hooked up then users could turn it on and profit :-). I was wrong about va.h having a switch, it was something different. Bah, looking in the wrong h

[Mesa-dev] [PATCH] radeon/vce Handle H.264 level 5.2

For gstreamer Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281 Signed-off-by: Andy Furniss --- src/gallium/drivers/radeon/radeon_vce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/drivers/radeon/radeon_vce.c

[Mesa-dev] [PATCH] st/omx/enc Raise default encode level

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281 Signed-off-by: Andy Furniss --- src/gallium/state_trackers/omx/vid_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/omx/vid_enc.c b/src/gallium/state_trackers/omx/vid_enc.c index

[Mesa-dev] [PATCH v2] radeon/vce Handle H.264 level 5.2

For gstreamer Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281 v2: explicitly add case 52 Signed-off-by: Andy Furniss --- src/gallium/drivers/radeon/radeon_vce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Christian König wrote: Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function without checking if it's available or not. Keep in mind that we pos

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Leo Liu wrote: On 10/25/2016 02:42 PM, Andy Furniss wrote: Christian König wrote: Nice work, have you been able to fix all the issues you mentioned on your last mail? Additional to that make sure that this set also keeps DRI2 working, in patch #2 it looks like you call the new function

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Nayan Deshmukh wrote: Hi Andy, It seems that you have compiled mesa with DRI3 enabled but vl_dri3_screen_create returns runs when called in device.c and hence VDPAU fallbacks to using DRI2. BTW I have sent in the v1.1 for patch 2 which play the video using dri2 in case of a fallback. Patch

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Nayan Deshmukh wrote: On Tue, Oct 25, 2016 at 11:11:13PM +0100, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Andy, It seems that you have compiled mesa with DRI3 enabled but vl_dri3_screen_create returns runs when called in device.c and hence VDPAU fallbacks to using DRI2. BTW I have sent

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox window manager, which does not use compositing - IIRC this has historically shown some

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox window manager, which does not use compositing - IIRC this has

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Nayan Deshmukh wrote: On Thu, Oct 27, 2016 at 11:52:13AM +0100, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Michel Dänzer wrote: On 27/10/16 07:52 PM, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering full screen. Windowed including re-sizing seems OK. I use Fluxbox

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers

Michel Dänzer wrote: On 28/10/16 08:19 PM, Andy Furniss wrote: Michel Dänzer wrote: On 27/10/16 07:52 PM, Andy Furniss wrote: Andy Furniss wrote: Michel Dänzer wrote: On 26/10/16 08:07 PM, Andy Furniss wrote: The bad = Starting with DRI3 (which is default) I still get trashed rendering

Re: [Mesa-dev] [PATCH] gallivm: Fix build after removal of deprecated attribute API

Tom Stellard wrote: --- Build tested only so far. src/gallium/auxiliary/draw/draw_llvm.c| 6 +- src/gallium/auxiliary/gallivm/lp_bld_intr.c | 48 +++- src/gallium/auxiliary/gallivm/lp_bld_intr.h | 13 - src/gallium/auxiliary/gallivm/lp_bld_sample_so

Re: [Mesa-dev] [PATCH] gallivm: Fix build after removal of deprecated attribute API

Aaron Watry wrote: On Tue, Nov 8, 2016 at 4:38 AM, Andy Furniss wrote: Tom Stellard wrote: --- Build tested only so far. src/gallium/auxiliary/draw/draw_llvm.c| 6 +- src/gallium/auxiliary/gallivm/lp_bld_intr.c | 48 +++- src/gallium/auxiliary/gallivm

Re: [Mesa-dev] [PATCH] st/omx/enc Raise default encode level

Can you apply this please. Christian König wrote: Am 25.10.2016 um 00:46 schrieb Andy Furniss: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281 Signed-off-by: Andy Furniss Reviewed-by: Christian König . --- src/gallium/state_trackers/omx/vid_enc.c | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH] radeon/vce Handle H.264 level 5.2

Hi, I did a v2, can it be applied? https://patchwork.freedesktop.org/patch/118006/ Christian König wrote: Am 25.10.2016 um 00:39 schrieb Andy Furniss: For gstreamer Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281 Signed-off-by: Andy Furniss --- src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH] radeon/vce Handle H.264 level 5.2

Leo Liu wrote: Hi Andy, Please rebase all your reviewed patches, and add RB, and send them to me I will commit them for you. Ok, thanks, I've sent two to you. Cheers, Leo On 12/05/2016 03:14 PM, Andy Furniss wrote: Hi, I did a v2, can it be applied? https://patchwork.freedeskto

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Nayan Deshmukh wrote: Hi Andy, One Issue I just tested - it doesn't work with sharpen or denoise, corrupted output compared to hqscale=0. The issue is fixed in the new patch series. Yes, this is OK now. All seems good apart from the slight offset on scaled up vids, though no one is really

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now. I see the new options are now in radeon_vce_52.c whereas before radeon_vce_40_2_2.c was changed - is this why? TIA

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously got cabac, but don't now. I see the new options are n

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by: Boyuan Zhang Is this supposed to be the same functionally as the first version? I notice on Tonga that I previously

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Christian König wrote: Am 05.07.2016 um 13:17 schrieb Christian König: Am 01.07.2016 um 18:18 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 18:02 schrieb Andy Furniss: Christian König wrote: Am 01.07.2016 um 16:42 schrieb Andy Furniss: Boyuan Zhang wrote: Signed-off-by

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Zhang, Boyuan wrote: Hi Andy, Thanks for the testing. I will look into the memory issue. For the cbr test, what was the bitrate you set? And by saying testing high rates, how high was the rate approximately? Testing more shows that I get the same size file independent of framerate. An example

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Andy Furniss wrote: omx doesn't have this issue, for 30mbit the files produced are 53M and 26M. Actually by default omx will make the same size files, I lucked into that behavior playing around with the control-rate param. ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Zhang, Boyuan wrote: Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. Seems good, no leak and no lock :-) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.fr

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Zhang, Boyuan wrote: Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. And thanks for providing the rate control info, I will do some test about it. Another issue is decode -> encode, this works OK with omx, but with someth

Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Andy Furniss wrote: Zhang, Boyuan wrote: Hi Andy, The memory issue is fixed. Please try the new patch set I just submitted. Should NOT have hard lock anymore. And thanks for providing the rate control info, I will do some test about it. Another issue is decode -> encode, this works OK w

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

Zhang, Boyuan wrote: Hi Andy, I just submitted another patch set, most of the issues you reported are solved, please see the information below: - Giving different frame rate should result different output size. The final result from my side is very close to the CBR I set. Please give a try wi

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

Andy Furniss wrote: Zhang, Boyuan wrote: Hi Andy, I just submitted another patch set, most of the issues you reported are solved, please see the information below: - Giving different frame rate should result different output size. The final result from my side is very close to the CBR I set

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

x0049e227 in transcode_step () at ffmpeg.c:4118 #8 transcode () at ffmpeg.c:4162 #9 0x004808e7 in main (argc=, argv=0x7fffdfb8) at ffmpeg.c:4355 Regards, Boyuan From: Andy Furniss Sent: July 19, 2016 2:39:44 PM To: Zhang, Boyuan; 'Christian König'; mesa-

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

Andy Furniss wrote: I tried again, and there's a possible further regression - though I have no idea whether it's ffmpeg or the newer patches here. Just thought I would mention it, as I haven't had time to look into it further yet. I can confirm this is a regression with the

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

Zhang, Boyuan wrote: Hi Andy, Thanks very much for providing all the information. The I420 U V swapping issue still can't be reproduced from my side, I will try it again later. CQP issue is fixed in the new patch set I just submitted. Please use " ... vaapiencodeh264 rate-control=cqp init-qp=x

Re: [Mesa-dev] [PATCH 06/11] vl/util: add copy func for yv12image to nv12surface

Zhang, Boyuan wrote: Hi Andy, I just submitted another patch set. 1. Fixed previously reported regression when using ffmpeg to encode. 2. Fixed I420 "width=720,height=480" garbage output issue. Please give a try from your side. Hi, The width 720 is OK now. Colors are still wrong. It seems f

Re: [Mesa-dev] Final review VA-API encode support

Christian König wrote: Hi guys, I would like to get this commit today. I just cleaned up patch #1 a bit, fixes some compiler warning in patch #3 and a build break in #4. Andy any more comments/testing on this or can I add your Tested-by: on it? I guess you saw comment in the other thread - on

Re: [Mesa-dev] [PATCH 3/9] st/va: add conversion for yv12 to nv12in putimage v2

Christian König wrote: From: Boyuan Zhang For putimage call, if image format is yv12 (or IYUV with U V field swap) This comment confuses me AIUI + checking on fourcc.org yv12 is YVU and IYUV/I420 is YUV and nv12 is UVUVUV... so compared to the normal way of writing yuv/yCbCr I wouldn't cal

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Nayan Deshmukh wrote: Hi Christian, I have sent the new patches, they should fix all the artifacts. :) I have briefly tried these over time and v3 1/2 + v2 2/2 still show artifacts for me. All versions have issues with 8/9, and I agree with the view that you shouldn't really use up all the le

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Nayan Deshmukh wrote: Thanks for testing :) On Monday, July 25, 2016, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Christian, I have sent the new patches, they should fix all the artifacts. :) I have briefly tried these over time and v3 1/2 + v2 2/2 still show artifacts for me. What

[Mesa-dev] [PATCH] vl/util: Fix YV12/I420 convert to NV12 U/V reversal.

Fix VAAPI YV12/I420 convert to NV12 U/V reversal. Input order is YVU when this is called. Signed-off-by: Andy Furniss --- src/gallium/auxiliary/util/u_video.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_video.h b/src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

Nayan Deshmukh wrote: Hi Christian On Wed, Aug 3, 2016 at 6:16 PM, Christian König wrote: Sorry for the delay I've been on vacation for a week. Good to hear back from you !! Where you able to fix the problem Andy reported? I was able to rather easily reproduce that. I have tested it on

  1   2   3   4   >