Re: [Mesa-dev] [PATCH] vc4: Fix automake linking error.

2018-08-01 Thread Andres Gomez
This looks good but, unfortunately, it seems to be breaking Travis build for the scons targets: https://travis-ci.org/Igalia/mesa/jobs/410431266 Please, Eric, could you try to see a way of solving this. I'm stuck not being able to create the 18.2 branch because of this build regression. On Tue,

[Mesa-dev] [PATCH 2/6] gallium/aux/util: use util_snprintf() in test_texture_barrier

2018-08-01 Thread Andres Gomez
of errors. Fixes: 56342c97ee7 ("gallium/u_tests: test FBFETCH and shader-based blending with MSAA") Cc: Marek Olšák Cc: Brian Paul Cc: Roland Scheidegger Cc: Dieter Nützel Signed-off-by: Andres Gomez --- src/gallium/auxiliary/util/u_tests.c | 4 ++-- 1 file changed, 2 insert

[Mesa-dev] [PATCH 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-01 Thread Andres Gomez
der") Cc: Marek Olšák Cc: Brian Paul Cc: Roland Scheidegger Cc: Mike Lothian Cc: Gert Wollny Cc: Dieter Nützel Signed-off-by: Andres Gomez --- src/mesa/main/texcompress_astc.cpp | 116 ++--- 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/src/mesa/ma

[Mesa-dev] [PATCH 1/6] glsl: use util_snprintf()

2018-08-01 Thread Andres Gomez
Instead of plain snprintf(). To fix the MSVC 2013 build. Fixes: 6ff0c6f4ebc ("gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times") Cc: Marek Olšák Cc: Brian Paul Cc: Roland Scheidegger Signed-off-by: Andres Gomez --- .../glsl/ir_builder_print_v

[Mesa-dev] [PATCH 5/6] ddebug: opt-out non UNIX code

2018-08-01 Thread Andres Gomez
ul Cc: Roland Scheidegger Cc: Nicolai Hähnle Signed-off-by: Andres Gomez --- src/gallium/auxiliary/driver_ddebug/dd_util.h | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/driver_ddebug/dd_util.h b/src/gallium/auxiliary/driver_ddebug/dd_util.h index 7720e9af9ca..681627

[Mesa-dev] [PATCH 0/6] fix the windows build with MSVC 2013

2018-08-01 Thread Andres Gomez
Just a small series of patches to fix the scons windows build with MSVC 2013. Detected while running with AppVeyor. Andres Gomez (6): glsl: use util_snprintf() gallium/aux/util: use util_snprintf() in test_texture_barrier kutil/queue: use util_snprintf() in util_queue_init ddebug: use

Re: [Mesa-dev] [PATCH 2/2] travis: install scons from pip

2018-08-01 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Wed, 2018-08-01 at 19:48 +0200, Juan A. Suarez Romero wrote: > The ubuntu version provided by Travis is a bit old, and does not detect > correctly some C functions. > > Use a more modern version through scons. > --- > .travis.yml | 8

Re: [Mesa-dev] [PATCH 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-01 Thread Andres Gomez
On Wed, 2018-08-01 at 16:43 -0400, Ilia Mirkin wrote: > On Wed, Aug 1, 2018 at 2:53 PM, Andres Gomez wrote: > > The binary constant notation "0b" is a GCC extension. Instead, we use > > hexadecimal notation to fix the MSVC 2013 build: > > > > Compili

Re: [Mesa-dev] [PATCH 1/2] scons: require scons 2.4 or greater

2018-08-01 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Wed, 2018-08-01 at 19:48 +0200, Juan A. Suarez Romero wrote: > There is a bug with scons 2.3, used in Travis, where it fails to detect > some C functions. > --- > SConstruct | 6 ++ > 1 file changed, 6 insertions(+) > > diff

[Mesa-dev] [PATCH v2 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-01 Thread Andres Gomez
uot;mesa: add ASTC 2D LDR decoder") Cc: Marek Olšák Cc: Brian Paul Cc: Roland Scheidegger Cc: Mike Lothian Cc: Gert Wollny Cc: Dieter Nützel Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- src/mesa/main/texcompress_astc.cpp | 116 ++--- 1 file changed, 58 insert

Re: [Mesa-dev] [PATCH v2 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-01 Thread Andres Gomez
lly sent them with you in Cc so you should have a copy or I would really have to start worrying about my mail delivery system ... 😕 Br. > > Marek > > On Wed, Aug 1, 2018 at 6:02 PM, Andres Gomez wrote: > > The binary constant notation "0b" is a GCC extension. Ins

[Mesa-dev] [PATCH 3/6] kutil/queue: use util_snprintf() in util_queue_init

2018-08-01 Thread Andres Gomez
: building terminated because of errors. Fixes: b238e33bc9d ("kutil/queue: add a process name into a thread name") Cc: Marek Olšák Cc: Brian Paul Cc: Roland Scheidegger Cc: Timothy Arceri Cc: Eric Engestrom Signed-off-by: Andres Gomez --- src/util/u_queue.c | 6 +++--- 1 file c

[Mesa-dev] [PATCH 4/6] ddebug: use util_snprintf() in dd_get_debug_filename_and_mkdir

2018-08-01 Thread Andres Gomez
rs. Fixes: 6ff0c6f4ebc ("gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times") Cc: Marek Olšák Cc: Brian Paul Cc: Roland Scheidegger Cc: Nicolai Hähnle Signed-off-by: Andres Gomez --- src/gallium/auxiliary/driver_ddebug/dd_util.h | 7 --- 1 file changed

Re: [Mesa-dev] [PATCH 5/6] ddebug: opt-out non UNIX code

2018-08-02 Thread Andres Gomez
On Wed, 2018-08-01 at 15:31 -0700, Dylan Baker wrote: > I pushed a patch earlier that *should* make mkdir and getpid work with msvc Thanks for the heads up. I'll drop this patch, then. > > Dylan > > Quoting Andres Gomez (2018-08-01 11:53:04) > > Opt-out the cod

Re: [Mesa-dev] [PATCH] vc4: Fix automake linking error.

2018-08-02 Thread Andres Gomez
The problem seemed to be scons itself. Therefore, this is: Reviewed-by: Andres Gomez On Wed, 2018-08-01 at 18:03 +0300, Andres Gomez wrote: > This looks good but, unfortunately, it seems to be breaking Travis > build for the scons targets: > https://travis-ci.org/Igalia/mesa/jobs/

[Mesa-dev] [PATCH 3/6] kutil/queue: use util_snprintf() in util_queue_init

2018-08-02 Thread Andres Gomez
: building terminated because of errors. Fixes: b238e33bc9d ("kutil/queue: add a process name into a thread name") Cc: Marek Olšák Cc: Brian Paul Cc: Roland Scheidegger Cc: Timothy Arceri Cc: Eric Engestrom Signed-off-by: Andres Gomez --- src/util/u_queue.c | 6 +++--- 1 file c

[Mesa-dev] [PATCH 4/6] ddebug: use util_snprintf() in dd_get_debug_filename_and_mkdir

2018-08-02 Thread Andres Gomez
rs. Fixes: 6ff0c6f4ebc ("gallium: move ddebug, noop, rbug, trace to auxiliary to improve build times") Cc: Marek Olšák Cc: Brian Paul Cc: Roland Scheidegger Cc: Nicolai Hähnle Signed-off-by: Andres Gomez --- src/gallium/auxiliary/driver_ddebug/dd_util.h | 7 --- 1 file changed

[Mesa-dev] [ANNOUNCE] mesa 18.0-0-rc1

2018-08-02 Thread Andres Gomez
Hota 1 Alyssa Rosenzweig 10 Andres Gomez 3 Andres Rodriguez 2 Andrew Galante 1 Andrii Simiklit 8 Antia Puentes 4 Anuj Phogat 61 Bas Nieuwenhuizen 1 Benedikt Schemmer 1 Boyan Ding 2 Boyuan Zhang 20 Brian Paul 30 Caio Marcelo de

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc1

2018-08-02 Thread Andres Gomez
The subject was obviously wrong 😕 On Thu, 2018-08-02 at 18:52 +0300, Andres Gomez wrote: > The first release candidate for Mesa 18.2.0 is now available. > > The plan is to have one release candidate every Wednesday, until the > anticipated final release on 22nd August 2018. > &g

[Mesa-dev] [PATCH] intel/tools: add error2aub creation into autotools

2018-08-02 Thread Andres Gomez
Cc: Dylan Baker Signed-off-by: Andres Gomez --- This just fixes running the default "meson _build" from the inflated tarball. Not sure we need to include more targets. src/intel/Makefile.tools.am | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v2 6/6] mesa: replace binary constants with hexadecimal constants

2018-08-02 Thread Andres Gomez
On Thu, 2018-08-02 at 12:55 -0400, Marek Olšák wrote: > > > On Thu, Aug 2, 2018, 2:42 AM Andres Gomez wrote: > > On Wed, 2018-08-01 at 19:54 -0400, Marek Olšák wrote: > > > For patches 5 & 6: > > > > > > Reviewed-by: Marek Olšák > > > &

Re: [Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc1

2018-08-02 Thread Andres Gomez
Forgot to mention that, in the path to 18.2.0, there is now a tracker bug for the regressions found since 18.1: https://bugs.freedesktop.org/show_bug.cgi?id=107457 On Thu, 2018-08-02 at 19:05 +0300, Andres Gomez wrote: > The subject was obviously wrong 😕 > > On Thu, 2018-08-02 at 18

Re: [Mesa-dev] [PATCH 1/2] travis: add ubuntu-toolchain-r-test

2018-08-07 Thread Andres Gomez
With a bit more clarifying commit log, this is: Reviewed-by: Andres Gomez On Mon, 2018-08-06 at 12:17 +0200, Juan A. Suarez Romero wrote: > LLVM 6.0 requires GCC 4.9, which is not available in main Travis > repository. > > Fixes: fd1121e8399 ("amd: remove support for LLVM

Re: [Mesa-dev] [PATCH 2/2] travis: meson/Vulkan requires LLVM 6.0

2018-08-07 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Mon, 2018-08-06 at 12:17 +0200, Juan A. Suarez Romero wrote: > RADV now requires LLVM 6.0. > > Fixes: fd1121e8399 ("amd: remove support for LLVM 5.0") > CC: Marek Olšák > --- > .travis.yml | 8 +--- > 1 file change

[Mesa-dev] [ANNOUNCE] Mesa 18.2.0-rc2

2018-08-08 Thread Andres Gomez
b331ea7d wayland/egl: update surface size on window resize Queued (17) === Andres Gomez (2): intel/tools: add error2aub creation into autotools Update version to 18.2.0-rc2 Chad Versace (1): drisw: Fix build on Android Nougat, which lacks shm (v2) Eric Anholt (7):

Re: [Mesa-dev] [PATCH] glsl: handle error case with ast_post_inc, ast_post_dec

2018-08-09 Thread Andres Gomez
Tapani, should we also include this in the stable queues ? On Tue, 2018-08-07 at 08:20 +0300, Tapani Pälli wrote: > Return ir_rvalue::error_value with ast_post_inc, ast_post_dec if > parser error was emitted previously. This way process_array_size > won't see bogus IR generated like with commit 9c

Re: [Mesa-dev] [PATCH v2] drirc: Allow extension midshader for Metro Redux

2018-08-09 Thread Andres Gomez
Vadym, should we also include this in the stable queues ? On Mon, 2018-08-06 at 15:52 +0300, vadym.shovkoplias wrote: > This fixes both Metro 2033 Redux and Metro Last Light Redux > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99730 > Signed-off-by: Eero Tamminen > Signed-off-by: Vad

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] anv: Stop racing relocation offsets

2018-08-09 Thread Andres Gomez
Romero wrote: > On Mon, 2017-06-26 at 22:39 +0300, Andres Gomez wrote: > > Jason, it doesn't seem like this patch has landed in master. Are you in > > need of review or is it that this has been superseded? > > > > > Gently ping to know what is the status fo

Re: [Mesa-dev] [Mesa-stable] [PATCH] meta: Fix BlitFramebuffer temp texture setup

2018-08-09 Thread Andres Gomez
Romero wrote: > On Tue, 2017-07-11 at 15:42 +0300, Ville Syrjälä wrote: > > On Mon, Jul 10, 2017 at 11:42:18PM +0300, Andres Gomez wrote: > > > Ville, has this patch fallen through the cracks ? > > > > Nope. I've still been looking into the issue whenever I've

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: use correct table offset for glAreTexturesResidentEXT

2018-08-09 Thread Andres Gomez
Emil, this patch has been stalled in the -stable ML for quite some time without update. Unless you say otherwise, I will just ignore it at this point and trust that you will also Cc -stable in the future, in case you come with another version. On Tue, 2017-09-26 at 18:52 +0200, Juan A. Suarez Rom

Re: [Mesa-dev] [Mesa-stable] [PATCH 07/10] gbm: unify error handling in gbm_dri_bo_import()

2018-08-09 Thread Andres Gomez
Emil, this patch never landed in master (nor got a R-b). Is this still relevant? Could you manage to get somebody to review it? I'd do it myself but I'm quite ignorant on the GBM bits. On Mon, 2017-10-16 at 17:04 +0100, Emil Velikov wrote: > From: Emil Velikov > > Fold the error handling for i

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: GLX_MESA_multithread_makecurrent is direct-only

2018-08-09 Thread Andres Gomez
Adam, which is the status of this patch? Is this effectively dropped? On Wed, 2017-12-06 at 16:13 -0500, Adam Jackson wrote: > On Wed, 2017-12-06 at 15:01 -0500, Ian Romanick wrote: > > On 12/06/2017 10:32 AM, Emil Velikov wrote: > > > On 5 December 2017 at 16:10, Adam Jackson wrote: > > > > This

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Unset ZRANGE_PRECISION when depth was zeroed

2018-08-09 Thread Andres Gomez
Bas, James, did you eventually come with a resolution for this? Can I just ignore this nominated patch in the -stable ML? On Wed, 2018-03-28 at 15:28 +0200, Bas Nieuwenhuizen wrote: > No final resolution yet. > > I was trying to fix my minor comment, but looks like I have a bunch of > CTS regress

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2018-08-09 Thread Andres Gomez
Emil, this patch has been stalled in the -stable ML for quite some time without update. Unless you say otherwise, I will just ignore it at this point and trust that you will also Cc -stable in the future, in case you come with another version. On Wed, 2017-09-27 at 17:36 +0200, Juan A. Suarez Rom

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/8] radv: don't flush src stages when dstStageMask == BOTTOM_OF_PIPE

2018-08-09 Thread Andres Gomez
Fredrik, which is the status of this series? Several patches got R-b but nothing has landed so far. Are you in need of more reviews for the rest of the patches in the series? On Tue, 2018-06-26 at 23:49 +0200, Fredrik Höglund wrote: > The Vulkan specification says: > >"An execution dependency

Re: [Mesa-dev] [PATCH] intel/isl: Avoid tiling on 16K-wide render targets

2018-08-09 Thread Andres Gomez
-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_error_blitframebuffer_multisampled_read_buffer_different_sizes GTF-GL46.gtf30.GL3Tests.framebuffer_blit.framebuffer_blit_functionality_multisampled_to_singlesampled_blit On Mon, 2018-07-30 at 19:25 +0300, Andres Gomez wrote: > That was quick! ☺

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: Unset ZRANGE_PRECISION when depth was zeroed

2018-08-09 Thread Andres Gomez
On Thu, 2018-08-09 at 15:33 +0200, Bas Nieuwenhuizen wrote: > On Thu, Aug 9, 2018 at 2:56 PM, Andres Gomez wrote: > > Bas, James, did you eventually come with a resolution for this? Can I > > just ignore this nominated patch in the -stable ML? > > The fix in this patch lan

[Mesa-dev] [ANNOUNCE] mesa 18.2.0-rc3

2018-08-15 Thread Andres Gomez
egl/android: fix regression in drm_gralloc path (v2) Queued (24) === Adam Jackson (1): glx: GLX_MESA_multithread_makecurrent is direct-only Andres Gomez (1): Update version to 18.2.0-rc3 Bas Nieuwenhuizen (3): radv: Fix missing Android platform define.

Re: [Mesa-dev] [PATCH] glsl: Avoid calling get_array_element for scalar constants

2018-08-15 Thread Andres Gomez
Danylo, should we also include this in the stable queues ? On Mon, 2018-08-13 at 18:57 +0300, Danylo Piliaiev wrote: > Accessing scalar constant as an array in function call or > initializer list triggered assert in get_array_element. > Examples: >func(0[0]); >vec2 t = { 0[0], 0 }; > > B

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

2016-04-28 Thread Andres Gomez
On Tue, 2016-04-26 at 12:16 +0200, Samuel Iglesias Gonsálvez wrote: > On 04/04/16 18:50, Andres Gomez wrote: > > > > This generalizes the validation also to be done for variables > > inside > > interface blocks, which, for some cases, was missing. > > > >

[Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-04 Thread Andres Gomez
Hi, as part of the work done to "Add FP64 support to the i965 shader backends" at: https://bugs.freedesktop.org/show_bug.cgi?id=92760 I've been working to add piglit tests that would check the new features added by this addition. Due to this, I've been checking and making modifications into the

Re: [Mesa-dev] About tolerance calculation on specific (builtin) functions

2016-05-09 Thread Andres Gomez
On Wed, 2016-05-04 at 13:48 -0400, Ilia Mirkin wrote: > On Wed, May 4, 2016 at 1:41 PM, Connor Abbott > wrote: > > > > On Wed, May 4, 2016 at 1:05 PM, Andres Gomez > > wrote: > > > > > > Hi, > > > > > > as part of the work don

[Mesa-dev] [PATCH] configure: added xcb to dri3 modules to pkg-conf

2016-05-20 Thread Andres Gomez
This fixes a recent linking error in libvulkan_common Signed-off-by: Andres Gomez --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6eee2bc..de62e8b 100644 --- a/configure.ac +++ b/configure.ac @@ -1319,7 +1319,7 @@ xdri

[Mesa-dev] [PATCH v2 3/5] mesa: simplify MESA_GL_VERSION_OVERRIDE behavior of API override

2018-03-18 Thread Andres Gomez
sten Cc: Ian Romanick Cc: Eric Engestrom Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/envvars.html | 25 ++--- src/mesa/main/version.c | 23 +++ 2 files changed, 29 insertions(+), 19 deletions(-) diff --git a/docs/envvars.html b/docs/envva

[Mesa-dev] [PATCH v2 2/5] dri_util: don't fail when not supporting ARB_compatibility with GL3.1

2018-03-18 Thread Andres Gomez
Cc: Marek Olšák Cc: Ian Romanick Cc: Kenneth Graunke Cc: Eric Engestrom Cc: Emil Velikov Signed-off-by: Andres Gomez Reviewed-by: Emil Velikov --- docs/features.txt | 11 +++ src/mesa/drivers/dri/common/dri_util.c | 10 ++ 2 files changed, 17 insertions(+), 4

[Mesa-dev] [PATCH 1/5] dri_util: when overriding, always reset the core version

2018-03-18 Thread Andres Gomez
-deqp-case=KHR-GL46.info.vendor While, this will fail: $ MESA_GL_VERSION_OVERRIDE=4.6COMPAT ./glcts --deqp-case=KHR-GL46.info.vendor Fixes: 464c56d3d5c ("dri_util: Use _mesa_override_gl_version_contextless") Cc: Ian Romanick Cc: Tapani Pälli Cc: Marek Olšák Signed-off-by: Andres Gom

[Mesa-dev] [PATCH v2 0/5] update MESA_GL_VERSION_OVERRIDE usage and documentation

2018-03-18 Thread Andres Gomez
ility profile with GL version X.Y. Andres Gomez (3): dri_util: when overriding, always reset the core version dri_util: don't fail when not supporting ARB_compatibility with GL3.1 mesa: adds some comments regarding MESA_GLES_VERSION_OVERRIDE usage Marek Olšák (2): mesa

[Mesa-dev] [PATCH 5/5] mesa: adds some comments regarding MESA_GLES_VERSION_OVERRIDE usage

2018-03-18 Thread Andres Gomez
Fixes: 03fd6704db9 ("mesa: Add support for a new override string MESA_GLES_VERSION_OVERRIDE") Cc: Jordan Justen Cc: Ian Romanick Signed-off-by: Andres Gomez Reviewed-by: Emil Velikov --- src/mesa/main/version.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) di

[Mesa-dev] [PATCH 4/5] mesa: adjust incorrect comment in texture_buffer_range

2018-03-18 Thread Andres Gomez
From: Marek Olšák --- src/mesa/main/teximage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 928e50d472d..c3f769d58ce 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5458,8 +5458,8 @@ tex

Re: [Mesa-dev] [PATCH] docs: add 17.3.8 in the release calendar

2018-03-19 Thread Andres Gomez
On Mon, 2018-03-19 at 13:56 +0100, Juan A. Suarez Romero wrote: > Mesa 18.0.0 has not been released yet, so let's extend 17.3 lifetime. > > CC: Andres Gomez > CC: Emil Velikov > --- > docs/release-calendar.html | 8 +++- > 1 file changed, 7 insertions(+), 1 del

Re: [Mesa-dev] [PATCH v2] docs: add 17.3.{8, 9} in the release calendar

2018-03-19 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Mon, 2018-03-19 at 16:28 +0100, Juan A. Suarez Romero wrote: > Mesa 18.0 series has not been released yet, so let's extend 17.3 lifetime. > > v2: add 17.3.9 in the calendar (Andres Gomez) > > CC: Andres Gomez > CC: Emil Velikov

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

2018-03-27 Thread Andres Gomez
On Wed, 2018-03-21 at 20:43 +, Emil Velikov wrote: > > All in all the idea sounds sane. As a summary/overall: > - Maintainer: open meta bug, send usual release plan + mention that > feature should be added to the tracker > - Developers: add bugs to tracker, or > - Developers: list via othe

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-27 Thread Andres Gomez
On Thu, 2018-03-22 at 16:24 -0700, Dylan Baker wrote: > Quoting Ilia Mirkin (2018-03-22 15:16:18) > > On Thu, Mar 22, 2018 at 6:00 PM, Dylan Baker wrote: > > > Quoting Ilia Mirkin (2018-03-21 17:39:14) > > > > Just one bit of feedback, for the rest I either agree or have no > > > > opinion: > > >

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-27 Thread Andres Gomez
On Thu, 2018-03-22 at 09:46 +0100, Juan A. Suarez Romero wrote: On Thu, 2018-03-22 at 00:28 +, Emil Velikov wrote: [...] > > > In detail: > > * make the patch queue, release date and blockers accessible at any > >point in time: [...] > > > > * patches with trivial conflicts can b

Re: [Mesa-dev] [RFC] Mesa release improvements - Release schedule

2018-04-12 Thread Andres Gomez
On Mon, 2018-03-12 at 16:00 +, Emil Velikov wrote: > On 12 March 2018 at 14:35, Andres Gomez wrote: > > Hi, > > > > * Release schedule: move from pre-announce Wed, announcement Fri [0] > >to pre-announce Mon, announcement Wed. > > * Why would we want

[Mesa-dev] nir/compiler: keep same bit size when lowering with flrp

2019-07-10 Thread Andres Gomez
This was probably not caught before because no supported test was exercising the flrp lowering with other bit size different than 32. With the arrival of VK_KHR_shader_float_controls we will have some of those and, unless we keep the bit size, we will end with something like: ../src/compiler/nir/

Re: [Mesa-dev] Applying fixes to stable branches

2021-01-07 Thread Andres Gomez
On Wed, 2021-01-06 at 19:19 -0500, Marek Olšák wrote: > Hi, > > How do you apply the fixes? The way it is done during the release process is semi-automated with the help of some scripts. > Is it possible to pick a random commit in master and apply all fixes that are > newer than that commit? I

Re: [Mesa-dev] [PATCH] nir: Fix anonymous union initialization with older GCC.

2019-03-22 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Fri, 2019-03-22 at 03:04 +, Vinson Lee wrote: > Fix this build error with GCC 4.4.7. > > CC nir/nir_opt_copy_prop_vars.lo > nir/nir_opt_copy_prop_vars.c: In function ‘load_element_from_ssa_entry_value’: > nir/nir_opt_copy_prop_va

[Mesa-dev] [PATCH v5 1/6] glsl/linker: location aliasing requires types to have the same width

2019-03-29 Thread Andres Gomez
and commit log (Andres). Fixes: 13652e7516a ("glsl/linker: Fix type checks for location aliasing") Cc: Ilia Mirkin Cc: Timothy Arceri Cc: Iago Toral Quiroga Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 115 ++-- 1 file changed, 76 inserti

Re: [Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-09 Thread Andres Gomez
I'll add locally to the commit log: Fixes the following test: KHR-GL44.enhanced_layouts.xfb_output_overlapping On Tue, 2019-02-12 at 23:57 +0200, Andres Gomez wrote: > From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: > > " No aliasing in output buffers is allow

Re: [Mesa-dev] [PATCH v2 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-10 Thread Andres Gomez
On Wed, 2019-04-10 at 10:40 +1000, Timothy Arceri wrote: > On 13/2/19 8:57 am, Andres Gomez wrote: > > From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: > > > >" No aliasing in output buffers is allowed: It is a compile-time or > > link-time

Re: [Mesa-dev] [PATCH v4 1/6] glsl/linker: location aliasing requires types to have the same width

2019-04-11 Thread Andres Gomez
fix is not that important so it could also be dropped. Take a look to the (additional) changes and feel free to pick or not. > > Thanks, > Dylan > > Quoting Andres Gomez (2019-02-01 10:05:52) > > From: Iago Toral Quiroga > > > > Regarding location aliasing requir

[Mesa-dev] [PATCH v3 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-21 Thread Andres Gomez
make it local to the validation process (Timothy). - Do not use a nested scope for the validation (Timothy). Cc: Timothy Arceri Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- src/compiler/glsl/link_varyings.cpp | 109 src/compiler/glsl/link_varyings.h | 6

Re: [Mesa-dev] [PATCH v3 6/6] glsl/linker: check for xfb_offset aliasing

2019-04-23 Thread Andres Gomez
failing for us. > > > See below for one addition: > > On 4/22/19 3:00 AM, Andres Gomez wrote: > > From page 76 (page 80 of the PDF) of the GLSL 4.60 v.5 spec: > > > >" No aliasing in output buffers is allowed: It is a compile-time or > > lin

[Mesa-dev] [MR] Revert "egl: Add a 565 pbuffer-only EGL config under X11."

2019-05-28 Thread Andres Gomez
This reverts commit dacb11a5. The reason for introducing this change was to fulfill CTS's requirement to be able to run a 565-no-depth-no-stencil config for ES 3.0 on X11. Unfortunately, enabling this causes other problems. The most relevant one is that, for i965, CTS was passing for GL 4.5 and n

<    2   3   4   5   6   7