Fixes the build for me here, and cl-program-tester from piglit seems to
work just fine for the few tests I just ran.
--Aaron
On Wed, Oct 28, 2015 at 9:47 AM, Laurent Carlier
wrote:
> https://bugs.freedesktop.org/show_bug.cgi?id=92705
>
> v2.1: use Linker::Flags::None instead of 0 and emplace_ba
On Fri, Feb 6, 2015 at 1:43 PM, Carl Worth wrote:
> This provides for atomic addition, which will be used by an upcoming
> shader-cache patch. A simple test is added to "make check" as well.
>
> Note: The various O/S functions differ on whether they return the
> original value or the value after
On Mon, Feb 6, 2017 at 9:42 PM, Timothy Arceri
wrote:
> In order to avoid costly fallback recompiles when cache items are
> created with an old version of Mesa or for a different gpu on the
> same system we want to create directories that look like this:
>
> ./{MESA_VERSION_STRING}/{GPU_ID}
>
> F
On Tue, Feb 7, 2017 at 3:43 PM, Timothy Arceri
wrote:
> On Wed, 8 Feb 2017 08:29:29 +1100
> Timothy Arceri wrote:
>
> > On Tue, 7 Feb 2017 11:40:12 -0600
> > Aaron Watry wrote:
> >
> > > On Mon, Feb 6, 2017 at 9:42 PM, Timothy Arceri
> > >
Using <<< for variable redirection is bash-specific behavior.
Ubuntu redirects sh -> dash, so this was erroring out.
Also, the initial error that led me to this was that srcdir is null when
running make check
so I just copied something similar to what the optimization-test script does.
---
src/g
On Sun, Feb 26, 2017 at 7:51 AM, Eric Engestrom wrote:
> On Friday, 2017-02-24 22:03:36 -0600, Aaron Watry wrote:
> > Using <<< for variable redirection is bash-specific behavior.
> > Ubuntu redirects sh -> dash, so this was erroring out.
> >
> > Also, th
On Mon, Feb 27, 2017 at 10:25 PM, Dieter Nützel
wrote:
> Hello Timothy,
>
> after your latest commit I get this:
>
Same here... My standard mesa build enables both r600g/radeonsi and also
does --enable-opencl which pulls LLVM/libelf into r600g for compute
purposes.
Looks like r600g isn't being
On Thu, Aug 6, 2015 at 6:36 AM, Thomas Helland
wrote:
> -NaN != NaN, and -Inf != Inf, so this should be safe.
>
What about -0.0 ? Does feq/fne treat both negative and positive zero as
equivalent?
--Aaron
> Found while working on my VRP pass.
>
> Shader-db results on my IVB:
> total instructi
Nevermind. Patch 2 answers that question in the commit message.
--Aaron
On Thu, Aug 6, 2015 at 10:25 AM, Aaron Watry wrote:
>
>
> On Thu, Aug 6, 2015 at 6:36 AM, Thomas Helland
> wrote:
>
>> -NaN != NaN, and -Inf != Inf, so this should be safe.
>>
>
> What
Thanks for this.
This at least lets me build a 32-bit mesa on 64-bit host again by disabling
the cache.
Tested-by: Aaron Watry
Tim: Just FYI, I get test failures for 32-bit builds on my x86-64 host.
With this patch, it no longer segfaults at least, just fails tests. If you
need more info, I
Hello,
I just got home and did a pull/build, and make check is failing as of a
very recent commit today...
${MESA_ROOT}/bin/test-driver: line 107: 5863 Segmentation fault (core
dumped) "$@" > $log_file 2>&1
FAIL: glsl/tests/uniform-initializer-test
PASS: glsl/glcpp/tests/glcpp-test
^Cmake[6
On Wed, Aug 10, 2016 at 7:34 PM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> Cause by 549222f5
>
s/Cause/Caused/ ?
Fixes the make check failure for me (haven't done a full piglit run, just
build/check/install test). Thanks for the quick turnaround.
--Aaron
&g
On Sat, Sep 3, 2016 at 1:59 PM, Jason Ekstrand wrote:
> In aad4f1550, we removed the concept of "fake" edges from NIR. Now, if you
> have a block at the end of an infinite loop it really has no predecessors.
> This updates the unit tests to match.
>
>
Fixes `make check` for me.
--Aaron
> Sign
Applies on top of v2 of Tom's gallivm change.
Signed-off-by: Aaron Watry
CC: Tom Stellard
CC: Jan Vesely
---
This fixes the build for me. I haven't done more than compile test this and run
make check.
src/gallium/drivers/llvmpipe/lp_state_fs.c| 2 +-
src/gallium/driver
On Tue, Nov 8, 2016 at 4:38 AM, Andy Furniss wrote:
> Tom Stellard wrote:
>
>> ---
>>
>> Build tested only so far.
>>
>> src/gallium/auxiliary/draw/draw_llvm.c| 6 +-
>> src/gallium/auxiliary/gallivm/lp_bld_intr.c | 48 +++-
>> src/gallium/auxiliary/gallivm/lp_b
disk_cache_get returns void*, but we were storing/comparing a char*.
Signed-off-by: Aaron Watry
---
Note that this did, and still, segfaults for me when I actually run it...
But at least the compiler is no longer complaining about the type mismatch.
src/compiler/glsl/tests/cache_test.c | 6
Avoids two warnings.
Signed-off-by: Aaron Watry
---
src/compiler/glsl/tests/cache_test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/tests/cache_test.c
b/src/compiler/glsl/tests/cache_test.c
index ca22605..0ef05aa 100644
--- a/src/compiler/glsl
Avoids three warnings.
Signed-off-by: Aaron Watry
---
Hope you don't mind my re-wrapping the long lines.
src/compiler/glsl/tests/blob_test.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl/tests/blob_test.c
b/src/compiler/glsl/tests/blob_t
On Tue, Nov 22, 2016 at 2:48 PM, Matt Turner wrote:
> On 11/22, Aaron Watry wrote:
>
>> disk_cache_get returns void*, but we were storing/comparing a char*.
>>
>> Signed-off-by: Aaron Watry
>> ---
>> Note that this did, and still, segfaults for me when I a
On Tue, Nov 22, 2016 at 8:27 PM, Aaron Watry wrote:
>
>
> On Tue, Nov 22, 2016 at 2:48 PM, Matt Turner wrote:
>
>> On 11/22, Aaron Watry wrote:
>>
>>> disk_cache_get returns void*, but we were storing/comparing a char*.
>>>
>>> Signed-off-b
s.
>
> Fixes Piglit's cl/program/build/fail/invalid-version-declaration.cl
> test.
>
> v2: fix inconsistent code formatting
>
> Signed-off-by: Vedran Miletić
> Reviewed-by: Francisco Jerez
>
Tested-by: Aaron Watry
> ---
> src/gallium/state_trackers/clover/ll
On Thu, Jul 7, 2016 at 4:57 AM, Christian König
wrote:
> From: Christian König
>
> Signed-off-by: Christian König
> ---
> src/gallium/drivers/radeon/radeon_video.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/gallium/drivers/radeon/radeon_video.c
>
It looks like CLBlast makes the same mistake that the CLU library did until
recently (fixed in 435957d667bc22cdb2f0bdc32).
It assumes that if your system has OpenCL 2.0 headers installed that the
OpenCL platforms present on the system also support CL 2.0.
In the case of Mesa, it doesn't support c
On Thu, Aug 4, 2016 at 2:54 PM, Sam Halliday wrote:
> Thanks Jan,
>
> This is what it comes up with
> https://gist.github.com/fommil/c97d4c8fb2790e28ecaf8d334ebf1746
>
> Are there any demo apps I could expect to run with this? What is
> involved in writing missing functionality?
>
I'll let other
The maximum workgroup size for a given kernel is based on the
capabilities of the device that it's being run on. Previously,
we were just returning the maximum value of a size_t which is
obviously wrong.
This patch uses the device's capabilities, but doesn't take into
account any resource usage wh
Reviewed-by: Aaron Watry
I have tested this on a Radeon 5400 (Cedar), and I just sent a few
generated tests to the piglit list.
--Aaron
On Wed, Oct 23, 2013 at 6:28 PM, Tom Stellard wrote:
> From: Tom Stellard
>
> ---
> lib/Target/R600/AMDGPUISelLowering.cpp | 1 +
> te
I ran this through a piglit CL test run on my 7850, no test fixes or
regressions.
--Aaron
On Tue, Oct 22, 2013 at 11:28 AM, Tom Stellard wrote:
> From: Tom Stellard
>
> Without DataLayout, a lot of optimization passes aren't run and the ones
> that are don't work as well.
> ---
> src/gallium/d
I just ran a quick.tests run on evergreen without any regressions.
Patch looks good to me, and doesn't seem to cause any regressions on
the hardware I have available to test with.
--Aaron
On Tue, Oct 22, 2013 at 11:28 AM, Tom Stellard wrote:
> From: Tom Stellard
>
> Without DataLayout, a lot o
On Tue, Oct 29, 2013 at 7:06 PM, Niels Ole Salscheider
wrote:
> Hi Tom,
>
> this has been on my todo list for quite a while.
>
> Your patch looks good to me, but in my experience a block with approximately
> the same size for each dimension gives slightly better performance in many
> cases when co
Reviewed and Tested-by: Aaron Watry
On Tue, Oct 29, 2013 at 11:48 AM, Tom Stellard wrote:
> From: Tom Stellard
>
> The ICD loader should be responsible for installing headers.
> ---
> src/gallium/state_trackers/clover/Makefile.am | 21 +++--
> 1 file chan
dso_list was added as an argument for createInternalizePass in 3.4, and then
it was removed again in the same llvm version.
---
src/gallium/state_trackers/clover/llvm/invocation.cpp | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
b/src
On Mon, Nov 4, 2013 at 7:04 PM, Matt Turner wrote:
> On Mon, Nov 4, 2013 at 4:48 PM, Brian Paul wrote:
>> ---
>> src/mesa/main/compiler.h |7 +--
>> 1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
>> index 61ce5db..275
I haven't looked in-depth at the rest of the patch, but I don't see
anywhere in vl_mpeg12_destroy that you are actually destroying the
context that you create in vl_create_mpeg12_decoder. Would I be
correct in assuming that this is leaked memory?
--Aaron
On Wed, Nov 6, 2013 at 8:13 AM, Christian
On Wed, Nov 6, 2013 at 8:13 AM, Christian König wrote:
> From: Christian König
>
> This makes VDPAU thread save again.
>
> Signed-off-by: Christian König
> ---
> src/gallium/auxiliary/vl/vl_mpeg12_decoder.c | 180
> ++-
> src/gallium/auxiliary/vl/vl_mpeg12_decoder.h |
I decided to have some fun and hooked valgrind up to my 7850 while running
a few OpenCL tests in piglit. This is the first batch of fixes.
Aaron Watry (6):
radeon/llvm: fix spelling error
radeon/llvm: Free libelf resources
radeon/llvm: Free created llvm memory buffer
radeonsi/compute
---
src/gallium/drivers/radeonsi/radeonsi_compute.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c
b/src/gallium/drivers/radeonsi/radeonsi_compute.c
index 28a3f17..6531bcd 100644
--- a/src/gallium/drivers/radeonsi/radeonsi_compute.c
+++ b/src/g
---
src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
index 286ccdd..57026bf 100644
--- a/src/gallium/drivers/radeon/rade
---
src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
index 339d7bf..927fb24 100644
--- a/src/gallium/auxiliary/pipe-loader/pipe_loade
---
src/gallium/drivers/radeon/radeon_llvm_util.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeon/radeon_llvm_util.c
b/src/gallium/drivers/radeon/radeon_llvm_util.c
index 7192dee..aec5d67 100644
--- a/src/gallium/drivers/radeon/radeon_llvm_util.c
+++ b/src/gallium/d
---
src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c
b/src/gallium/drivers/radeon/radeon_llvm_emit.c
index 8bf278b..20b3206 100644
--- a/src/gallium/drivers/radeon/radeon_llvm_emit.c
+++ b/src/galliu
---
src/gallium/drivers/radeonsi/radeonsi_compute.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c
b/src/gallium/drivers/radeonsi/radeonsi_compute.c
index 265dbd7..28a3f17 100644
--- a/src/gallium/drivers/radeon
tabs for spaces.
Do you want a v2, or are you happy with the patches assuming that I
fix the indentation?
--Aaron
>
> -Tom
>
> On Wed, Nov 06, 2013 at 10:36:49AM -0600, Aaron Watry wrote:
>> I decided to have some fun and hooked valgrind up to my 7850 while running
>> a few
Turns out that I don't have commit access to Mesa, just piglit. Feel
free to push if they look good.
I decided to have some fun and hooked valgrind up to my SI while running
a few OpenCL tests in piglit. This is the first batch of fixes.
Aaron Watry (6):
radeon/llvm: fix spelling
v2: Fix indentation
Reviewed-by: Tom Stellard
---
src/gallium/drivers/radeonsi/radeonsi_compute.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c
b/src/gallium/drivers/radeonsi/radeonsi_compute.c
index 265dbd7.
Reviewed-by: Tom Stellard
---
src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
index 339d7bf..927fb24 100644
--- a/src/gallium/auxil
v2: Fix indentation
Reviewed-by: Tom Stellard
---
src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c
b/src/gallium/drivers/radeon/radeon_llvm_emit.c
index 8bf278b..d2e5642 100644
--- a/src/gallium/dr
Reviewed-by: Tom Stellard
---
src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
index 286ccdd..57026bf 100644
--- a/src/
v2: Fix indentation
Reviewed-by: Tom Stellard
---
src/gallium/drivers/radeonsi/radeonsi_compute.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c
b/src/gallium/drivers/radeonsi/radeonsi_compute.c
index 32d2487..fff9b76 100644
--- a/src/gallium
v2: Fix indentation
Reviewed-by: Tom Stellard
---
src/gallium/drivers/radeon/radeon_llvm_util.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeon/radeon_llvm_util.c
b/src/gallium/drivers/radeon/radeon_llvm_util.c
index 7192dee..f2b3e13 100644
--- a/src/gallium/drive
radeon_llvm_compile allocates memory for binary.code, binary.config, or neither
depending on
what's being done.
We need to make sure to free that memory after it's no longer needed.
---
src/gallium/drivers/r600/r600_llvm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/gallium/dr
use memset to initialize to 0's... otherwise code_size and config_size could be
uninitialized when read later in this method. It's also hard to do NULL checks
on uninitialized pointers.
---
src/gallium/drivers/r600/r600_llvm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drive
Prevents a memory leak.
---
src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c
b/src/gallium/drivers/radeon/radeon_llvm_emit.c
index d2e5642..e35c212 100644
--- a/src/gallium/drivers/radeon/radeon_llvm
mit access, so feel free to push if you don't have any issues.
Aaron Watry (3):
r600/llvm: initialize radeon_llvm_binary
r600/llvm: Free binary.code/binary.config in r600_llvm_compile
radeon/llvm: Free elf_buffer after use
src/gallium/drivers/r600/r600_llvm.c | 8
src/
On Thu, Nov 14, 2013 at 10:29 AM, Tom Stellard wrote:
> From: Tom Stellard
>
> We need to do this until function calls are supported.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=64225
>
> CC: "10.0"
> ---
> src/gallium/drivers/radeon/radeon_llvm_util.c | 24 ++--
> 1 fi
(yet), so feel free to push if you don't have any
issues.
v2: Remove NULL checks in patches 2,3 and fix indentation in patch 1.
Aaron Watry (3):
r600/llvm: initialize radeon_llvm_binary
r600/llvm: Free binary.code/binary.config in r600_llvm_compile
radeon/llvm: Free elf_b
Prevents a memory leak.
v2: Remove null check
---
src/gallium/drivers/radeon/radeon_llvm_emit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c
b/src/gallium/drivers/radeon/radeon_llvm_emit.c
index d2e5642..92e7dbc 100644
--- a/src/gallium/driver
use memset to initialize to 0's... otherwise code_size and config_size
could be uninitialized when read later in this method.
It's also hard to do NULL checks on uninitialized pointers.
Reviewed-by: Tom Stellard
v2: Fix indentation
---
src/gallium/drivers/r600/r600_llvm.c | 1 +
1 file changed
radeon_llvm_compile allocates memory for binary.code, binary.config,
or neither depending on what's being done.
We need to make sure to free that memory after it's no longer needed.
v2: Don't bother checking for null before FREE()
---
src/gallium/drivers/r600/r600_llvm.c | 3 +++
1 file changed,
On Tue, Jun 3, 2014 at 10:26 AM, Jon TURNEY wrote:
> On 03/06/2014 15:19, Aaron Watry wrote:
>>
>> On Tue, Jun 3, 2014 at 8:14 AM, Jon TURNEY
>> wrote:
>>>
>>> Some untangling to fix building in the dri_platform=none,
>>> --enable-driglx-
Signed-off-by: Aaron Watry
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
index df26883..413a0c2 100644
--- a/src/gallium
On my machine, ${PREFIX}/lib/vdpau contains:
libvdpau_gallium.so.1 -> libvdpau_r600.so.1.0.0
libvdpau_r600.so*
libvdpau_radeonsi.so*
Note that libvdpau_gallium.so.1 is only created when I force an
ldconfig on my system (until then, I just have
libvdpau_[r600|radeonsi]*)
For some reason, while the
.1.0 radeonsi_dri.so
libMesaOpenCL.so.1libvdpau_r600.so.1libvdpau_radeonsi.so
libvdpau_radeonsi.so.1.0.0
libMesaOpenCL.so.1.0.0libvdpau_r600.so.1.0 libvdpau_radeonsi.so.1
r600_dri.so
awatry@ws-awatry:~/src/mesa/lib/gallium$
On Mon, Jun 23, 2014 at 1:12 PM, Emil Velikov wrote:
>
On Mon, Jun 23, 2014 at 12:10 PM, Ilia Mirkin wrote:
> On Mon, Jun 23, 2014 at 1:07 PM, Aaron Watry wrote:
>> On my machine, ${PREFIX}/lib/vdpau contains:
>> libvdpau_gallium.so.1 -> libvdpau_r600.so.1.0.0
>> libvdpau_r600.so*
>> libvdpau_radeonsi.so*
>>
&
On Mon, Jun 23, 2014 at 1:54 PM, Emil Velikov wrote:
> On 23/06/14 19:31, Aaron Watry wrote:
>> Using /usr/local as PREFIX and an empty /usr/local/lib/vdpau directory
>> to start, after make install of mesa I end up with
>> /usr/local/lib/vdpau/ containing:
>>
>>
to get the kernel without the correct number of attributes led
to memory corruption and luxrays crashing out.
Fixes the cl/program/execute/attributes.cl piglit test.
Signed-off-by: Aaron Watry
CC: Tom Stellard
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76223
---
src/gallium/driv
On Thu, Jul 3, 2014 at 9:56 AM, Tom Stellard wrote:
> On Wed, Jul 02, 2014 at 04:34:24PM -0500, Aaron Watry wrote:
>> Previously, we were assuming that kernel metadata nodes only had 1 operand.
>>
>> Kernels which have attributes can have more than 1, e.g.:
>> !0 = met
On Thu, Jul 3, 2014 at 11:29 AM, Tom Stellard wrote:
> On Thu, Jul 03, 2014 at 10:56:24AM -0400, Tom Stellard wrote:
>> On Wed, Jul 02, 2014 at 04:34:24PM -0500, Aaron Watry wrote:
>> > Previously, we were assuming that kernel metadata nodes only had 1 operand.
>> &
for luxrays are now present (at least with
>> my own libclc tree), at least with image support disabled in luxrays.
>>
>> If you enable image support, I believe that it is still going to fail
>> due to mismatches/oddness with the number of supported pixel formats.
&
Tested-by and Reviewed-by: Aaron Watry
On Mon, Jul 14, 2014 at 3:51 PM, Tom Stellard wrote:
> We were trying to print the error message after disposing the
> message object.
> ---
> src/gallium/drivers/radeon/radeon_llvm_emit.c | 11 ---
> 1 file changed, 4 insertions(
Hi list,
I was starting to look into getting cppamp-driver-ng working with
mesa/clover, and I quickly ran into a question...
cppamp-driver-ng explicitly lists which platforms are supported in its
OpenCL back-end's source code. I went to add in the Mesa/Clover
entries, and discovered that we're ac
x27;t want to rename clover to reflect what we call
it, then maybe I need to submit some patches to cppamp-driver-ng to
have them also use the vendor name in the case that the platform name
might be ambiguous.
--Aaron
On Wed, Jul 30, 2014 at 9:05 AM, Tom Stellard wrote:
> On Tue, Jul 29,
Looks good to me.
I've tested on Cedar (HD5400) with no OpenCL regressions, but cannot
test on SI because SETCC still causes issues (see
https://bugs.freedesktop.org/show_bug.cgi?id=66175). Once SETCC is
fixed for SI, we should probably add SI-CHECK lines to vselect.ll
--Aaron
On Tue, Jul 16, 2
, Jul 16, 2013 at 8:39 PM, Tom Stellard wrote:
> Hi,
>
> The attached three patches along with this one should fix VSELECT on SI
> as well.
>
> -Tom
>
> On Tue, Jul 16, 2013 at 05:12:40PM -0500, Aaron Watry wrote:
>> Looks good to me.
>>
>> I've teste
On Tue, Jul 9, 2013 at 11:21 PM, Tom Stellard wrote:
> From: Tom Stellard
>
> v2:
> - Extend to target size rather than aligned size
> - Support for big-endian
> ---
> src/gallium/state_trackers/clover/core/kernel.cpp | 58
> --
> src/gallium/state_trackers/clover/core/
It'll take me a while to attempt to parse everything that's going on
in these patches (and your resource descriptor types series that this
depends on), but I have sent it all through a piglit run on Evergreen
(Cedar). Everything was latest Mesa/LLVM/libclc upstream code as of
today.
Baseline: 567
s.
And as you said, the descriptors series fixed compute hangs for the
7850 on quite a few kernels which did comparison operations (max/clamp
kernels mostly, maybe some min).
You can definitely get a tested-by for both the descriptors series and this:
Tested-by: Aaron Watry wrote:
> It'll
on Pass Manager' on module 'radeon'.
1.Running pass 'AMDGPU DAG->DAG Pattern Instruction Selection' on
function '@vp8_loop_filter_all_edges_kernel'
Aborted (core dumped)
For that you get a:
Tested-By: Aaron Watry
On Wed, Aug 21, 2013 at 1:33 PM, Tom Ste
The changes look good to me... That seems to be a much more sane way
to add the item to the beginning of the linked list.
I've tested this on CEDAR (Radeon 5400) without any OpenCL
regressions, and the only piglit change was that the new piglit test
created for this bug now passes.
--Aaron
On T
I've managed to capture a trace that loads TF2 to the menu and reproduces
some of the flickering. I haven't managed to capture any gameplay yet due
to an error in CD Key authentication due to how I'm launching the game.
URL:
http://www.watrys.net/tf2_menu.trace.xz
--Aaron
On Wed, Feb 20, 2013
Hi Tom,
Mesa+Clover does indeed build against master llvm/clang, but I'm having
trouble building against it when I try to do a clean build of Piglit.
Error received:
[ 18%] Built target piglitutil_cl
Linking C executable ../../../../../bin/cl-custom-run-simple-kernel
/usr/local/lib/libOpenCL.so:
On Thu, Feb 21, 2013 at 8:33 AM, Tom Stellard wrote:
> On Thu, Feb 21, 2013 at 08:25:20AM -0600, Aaron Watry wrote:
> > Hi Tom,
> >
> > Mesa+Clover does indeed build against master llvm/clang, but I'm having
> > trouble building against it when I try to do a clea
On Thu, Feb 21, 2013 at 10:06 AM, Tom Stellard wrote:
> On Thu, Feb 21, 2013 at 10:02:34AM -0600, Aaron Watry wrote:
> > On Thu, Feb 21, 2013 at 8:33 AM, Tom Stellard wrote:
> >
> > > On Thu, Feb 21, 2013 at 08:25:20AM -0600, Aaron Watry wrote:
> > > > Hi T
On Fri, Feb 22, 2013 at 12:21 PM, Tom Stellard wrote:
> On Thu, Feb 21, 2013 at 08:25:20AM -0600, Aaron Watry wrote:
> > Hi Tom,
> >
> > Mesa+Clover does indeed build against master llvm/clang, but I'm having
> > trouble building against it when I try to do a clea
Same error here.
Configuration: ./autogen.sh --enable-texture-float --enable-opencl
--with-gallium-drivers=r600 --with-dri-drivers=radeon --prefix=/usr/local
--Aaron
On Tue, Feb 26, 2013 at 11:09 AM, Jordan Justen wrote:
> On Sat, Feb 23, 2013 at 7:29 AM, Brian Paul wrote:
> > This series re
LLVM moved a bunch of IR-related headers for version 3.3.
This fixes the libclc build to follow suit.
---
utils/prepare-builtins.cpp | 12
1 file changed, 12 insertions(+)
diff --git a/utils/prepare-builtins.cpp b/utils/prepare-builtins.cpp
index ae7731b..0141484 100644
--- a/uti
The python changes in this file look good to me. I haven't done a
line-by-line review of the SI changes.
I tested this patch and v2 of the related mesa series on r600g (radeon
6850) with a recent LLVM and fresh mesa master as of this evening. No real
change in the piglit CL test success/failure ra
Adds this function for both int and floating data types.
---
generic/include/clc/clc.h |2 ++
generic/include/clc/integer/max.h |2 ++
generic/include/clc/integer/max.inc |1 +
generic/include/clc/math/max.h |2 ++
generic/include/clc/math/max.inc|1 +
gene
---
generic/lib/SOURCES |1 +
generic/lib/integer/abs_diff.inc |2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/generic/lib/SOURCES b/generic/lib/SOURCES
index b593941..a97213b 100644
--- a/generic/lib/SOURCES
+++ b/generic/lib/SOURCES
@@ -4,6 +4,7 @@ geome
This series depends on the one-off patch I just sent to add max().
1) Fix the broken abs_diff integer built-in.
2) Add clamp for both integer and floating types in a new shared/ dir in order
to reduce code duplication and improve maintainability.
3) Move the max() function into the shared/ dire
Created under a new shared/ directory for functions which are available for
both integer and floating point types.
---
generic/include/clc/clc.h|3 +++
generic/include/clc/shared/clamp.h |5 +
generic/include/clc/shared/clamp.inc |1 +
generic/lib/SOURCES
Max(x,y) is available for all integer/floating types.
---
generic/include/clc/clc.h |3 +--
generic/include/clc/integer/max.h |2 --
generic/include/clc/integer/max.inc |1 -
generic/include/clc/math/max.h |2 --
generic/include/clc/math/max.inc|1 -
generi
PM, Aaron Watry wrote:
> This series depends on the one-off patch I just sent to add max().
>
> 1) Fix the broken abs_diff integer built-in.
> 2) Add clamp for both integer and floating types in a new shared/ dir in
> order
>to reduce code duplication and improve maintain
This implementation does a lot of bit shifting and masking. Suffice to say,
this is somewhat suboptimal... but it does look to produce correct results
(after the piglit tests were corrected for sign extension issues).
Someone who knows LLVM better than I could re-write this more efficiently.
---
Implements the min() OpenCL built-in in 2 stages.
1) Implement min() where the two argument types match
2) Make changes to support min(vec,scalar)
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa
This doesn't handle the integer cases for min(vector, scalar).
---
generic/include/clc/clc.h |1 +
generic/include/clc/shared/min.h |5 +
generic/include/clc/shared/min.inc |1 +
generic/lib/SOURCES|1 +
generic/lib/shared/min.cl | 11 +
Checks if the current GENTYPE is scalar, and if not, then defines a separate
implementation of the function which casts the second arg to vector before
proceeding.
---
generic/include/clc/integer/gentype.inc | 23 +++
generic/include/clc/math/gentype.inc|8
g
For any GENTYPE that isn't scalar, we need to implement a mixed
vector/scalar version of clamp/max.
This depends on the min() patches I sent to the list a few minutes ago.
---
generic/include/clc/shared/clamp.inc |4
generic/include/clc/shared/max.inc |4
generic/lib/shared/cl
configure.py allows overloading *.cl with *.ll, but will only ever build
the first file listed in SOURCES of ${file}.cl and ${file}.ll
add_sat, sub_sat, (and the soon to be submitted clz) all define interfaces in
${function_name}.ll which are implemented in ${function_name}_impl.ll.
Renaming the
Squashed commit of the following:
commit a0df0a0e86c55c1bdc0b9c0f5a739e5adef4b056
Author: Aaron Watry
Date: Mon Apr 15 18:42:04 2013 -0500
libclc: Rename clz.ll to clz_if.ll to ensure it gets built.
configure.py treats files that have the same name with the .cl and .ll
extensions
On Sun, Nov 24, 2013 at 11:36 PM, Siavash Eliasi
wrote:
> ---
> src/mesa/main/bufferobj.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> index b27f592..5581a5d 100644
> --- a/src/mesa/main/bufferobj.c
> +++ b/sr
1 - 100 of 392 matches
Mail list logo
