Re: [Mesa-dev] [PATCH] Android: enable noreturn and returns_nonnull attributes

2017-12-05 Thread Rob Herring
On Tue, Dec 5, 2017 at 5:56 AM, Emil Velikov wrote: > On 5 December 2017 at 02:21, Rob Herring wrote: >> Commit 94ca8e04adf6 ("spirv: Add vtn_fail and vtn_assert helpers") broke >> Android builds which have -Werror enabled with the following errors: >> >&g

Re: [Mesa-dev] [PATCH] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

2017-12-05 Thread Rob Herring
On Tue, Dec 5, 2017 at 11:01 AM, Robert Foss wrote: > On Tue, 2017-12-05 at 18:22 +0900, Tomasz Figa wrote: >> On Sat, Dec 2, 2017 at 4:43 AM, Rob Herring wrote: >> > On Fri, Dec 1, 2017 at 8:44 AM, Tomasz Figa >> > wrote: >> > > On Fri, Dec 1, 2017

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

2017-06-15 Thread Rob Herring
On Tue, Jun 13, 2017 at 1:55 PM, Chad Versace wrote: > On Fri 09 Jun 2017, Tapani Pälli wrote: >> >> >> On 06/08/2017 09:27 PM, Chad Versace wrote: >> > On Thu 08 Jun 2017, Tomasz Figa wrote: >> > > On Thu, Jun 8, 2017 at 4:08 PM, Tapani Pälli >> > > wrote: >> > > > >> > > > On 06/08/2017 09:36

Re: [Mesa-dev] [PATCH v1 6/7] android: add etnaviv driver build support

2017-06-16 Thread Rob Herring
On Fri, Jun 16, 2017 at 8:24 AM, Emil Velikov wrote: > Hi Rob, > > There's a handful of small nitpicks, but nothing serious. > > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Rob Herring >> >> Add etnaviv to Android makefiles. >> >> Sign

Re: [Mesa-dev] [PATCH] egl/android: Change order of EGLConfig generation (v2)

2017-06-22 Thread Rob Herring
(chadversary) testing on Android Nougat, this > was good enough to pacify the buggy clients. > > v2: Rebase to make patch cherry-pickable to stable. > > Cc: mesa-sta...@lists.freedesktop.org > Cc: Tomasz Figa > Cc: Rob Herring > Cc: Tapani Pälli > Cc: Emil Velikov Teste

[Mesa-dev] [PATCH] Android: add renderonly files to libmesa_gallium

2017-06-26 Thread Rob Herring
r_resource' src/gallium/winsys/pl111/drm/pl111_drm_winsys.c:37: error: undefined reference to 'renderonly_create_gpu_import_for_resource' Fixes: 7029ec05e2c7 ("gallium: Add renderonly-based support for pl111+vc4.") Cc: Eric Anholt Signed-off-by: Rob Herring --- Eric, not sur

[Mesa-dev] [PATCH] Android: use symlinks for driver loading

2017-06-28 Thread Rob Herring
Instead of having special driver loading logic for Android, create symlinks to gallium_dri.so so we can use the standard loading logic. Signed-off-by: Rob Herring --- src/egl/drivers/dri2/egl_dri2.c | 9 - src/gallium/drivers/freedreno/Android.mk | 1 + src/gallium/drivers

Re: [Mesa-dev] [PATCH] Android: use symlinks for driver loading

2017-06-28 Thread Rob Herring
On Wed, Jun 28, 2017 at 11:46 AM, Eric Anholt wrote: > Rob Herring writes: > >> Instead of having special driver loading logic for Android, create >> symlinks to gallium_dri.so so we can use the standard loading logic. >> >> Signed-off-by: Rob Herring > >

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

2017-06-28 Thread Rob Herring
On Tue, Jun 27, 2017 at 1:00 PM, Chad Versace wrote: > The new function takes a mesa_format and, if the format is an alpha > format with a non-alpha variant, returns the non-alpha format. > Otherwise, it returns the original format. [...] > @@ -123,6 +124,17 @@ $(intermediates)/main/get_hash.h:

Re: [Mesa-dev] [PATCH 1/3] mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]

2017-06-28 Thread Rob Herring
On Wed, Jun 28, 2017 at 4:23 PM, Chad Versace wrote: > On Wed 28 Jun 2017, Rob Herring wrote: >> On Tue, Jun 27, 2017 at 1:00 PM, Chad Versace >> wrote: >> > The new function takes a mesa_format and, if the format is an alpha >> > format with a non-alpha vari

[Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

2017-06-28 Thread Rob Herring
From: Eero Tamminen Commit f8d69beed49c64f883bb8ffb28d4960306baf575 moving sampler handling to genxml messed up change done by commit 6a7c5257cac23cd9767aa4bc8fdab68925b11157. This broke rendering in SynMark CSDof and TexFilterAniso tests. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=

[Mesa-dev] [PATCH] Android: i965: remove libdrm_intel dependency

2017-06-28 Thread Rob Herring
add the necessary include paths for the local copy of i915_drm.h. Signed-off-by: Rob Herring --- src/mesa/drivers/dri/i965/Android.mk | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/Android.mk b/src/mesa/drivers/dri/i965/Android.mk index 7ee

Re: [Mesa-dev] [PATCH] i965: Fix anisotropic filtering for mag filter

2017-06-28 Thread Rob Herring
On Wed, Jun 28, 2017 at 5:07 PM, Rob Herring wrote: > From: Eero Tamminen Ignore this. Rob ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-29 Thread Rob Herring
On Wed, Jun 28, 2017 at 8:15 PM, Eric Anholt wrote: > I want to remove vc4's dependency on headers from libdrm as well, but > storing multiple copies of drm_fourcc.h in our tree would be silly. > --- > {src/intel/drm => include/drm-uapi}/README | 0 > {src/intel/drm => include/drm-uapi}/drm

Re: [Mesa-dev] [PATCH v2] intel: Move the DRM uapi headers to a non-Intel location.

2017-06-29 Thread Rob Herring
rm_fourcc.h (100%) > rename {src/intel/drm => include/drm-uapi}/drm_mode.h (100%) > rename {src/intel/drm => include/drm-uapi}/i915_drm.h (100%) > delete mode 100644 src/intel/Makefile.drm.am For Android: Reviewed-by: Rob Herring ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] vc4: Introduce XML-based packet header generation like Intel's.

2017-06-29 Thread Rob Herring
dir $(@))" > + $(hide) $(PRIVATE_SCRIPT) $(PRIVATE_SCRIPT_FLAGS) $(PRIVATE_XML) > $@ > +endef > + > +$(intermediates)/genxml/v3d_packet_v21_pack.h: PRIVATE_SCRIPT := > $(MESA_PYTHON2) $(LOCAL_PATH)/cle/gen_pack_header.py > +$(intermediates)/genxml/v3d_packet_v21_pack.h: PRIVATE_XML := > $(LOCAL_PATH)/cle/v3d_packet_v21.xml > +$(intermediates)/genxml/v3d_packet_v21_pack.h: > $(LOCAL_PATH)/cle/v3d_packet_v21.xml $(LOCAL_PATH)/cle/gen_pack_header.py As Emil pointed out: s/genxml/cle/ With that, it builds fine on Android at least. Tested-by: Rob Herring Rob ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Android: fix typo in symlink for driver loading and 32 bit builds

2017-06-30 Thread Rob Herring
On Fri, Jun 30, 2017 at 1:54 AM, Mauro Rossi wrote: > There is typo in the mkdir command path, > the correct one is $(TARGET_OUT)/$(l)/$(MESA_DRI_MODULE_REL_PATH) Humm, I tested the the pre-O case by enabling it on master and thought it worked. Maybe TARGET_OUT_SHARED_LIBRARIES didn't exist pre-O

Re: [Mesa-dev] [PATCH] Android: fix typo in symlink for driver loading and 32 bit builds

2017-06-30 Thread Rob Herring
On Fri, Jun 30, 2017 at 1:54 AM, Mauro Rossi wrote: > There is typo in the mkdir command path, > the correct one is $(TARGET_OUT)/$(l)/$(MESA_DRI_MODULE_REL_PATH) > > The other issue is in 32bit builds, because lib64 does not exist there, > we can use TARGET_IS_64_BIT to refine the post install co

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

2017-06-30 Thread Rob Herring
On Fri, Jun 30, 2017 at 7:45 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- [...] > diff --git a/src/util/Android.mk b/src/util/Android.mk > index facdcf8..6c81322 100644 > --- a/src/util/Android.mk > +++ b/src/util/Android.mk > @@ -24,35 +24,80 @@ LOCAL_PATH := $(call my-dir) > > in

[Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-06-30 Thread Rob Herring
enough to prevent breaking GLX. Cc: Marek Olšák Cc: Eric Anholt Cc: Chad Versace Cc: Mauro Rossi Signed-off-by: Rob Herring --- I've tested only on Android and could use help testing with KDE which broke last time. This has been done on the Intel driver and *should* be okay, but mayb

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-07-07 Thread Rob Herring
On Wed, Jul 5, 2017 at 5:14 PM, Chad Versace wrote: > On Fri 30 Jun 2017, Rob Herring wrote: >> Add support for 32-bit RGBX/RGBA formats which are required for Android. >> >> The original patch (commit ccdcf91104a5) was reverted (commit >> c0c6ca40a25e) in mesa a

Re: [Mesa-dev] [PATCH] Android: Fix vc4 build since XML changes.

2017-07-10 Thread Rob Herring
On Wed, Jul 5, 2017 at 1:19 PM, Eric Anholt wrote: > For the automake build, -Isrc/ is implied from the gallium cflags, while > Android gallium driver builds don't get that by default. I think it'll be > better for vc4 to have broadcom includes appear as "#include > " to make it more clear where

Re: [Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

2017-07-11 Thread Rob Herring
On Tue, Jul 11, 2017 at 8:27 AM, Emil Velikov wrote: > From: Emil Velikov > > As said in the EGL_KHR_platform_android extensions > > For each EGLConfig that belongs to the Android platform, the > EGL_NATIVE_VISUAL_ID attribute is an Android window format, such as > WINDOW_FORMAT_RGBA_

Re: [Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

2017-07-11 Thread Rob Herring
On Tue, Jul 11, 2017 at 9:34 AM, Tomasz Figa wrote: > On Tue, Jul 11, 2017 at 11:16 PM, Rob Herring wrote: >> On Tue, Jul 11, 2017 at 8:27 AM, Emil Velikov >> wrote: >>> From: Emil Velikov >>> >>> As said in the EGL_KHR_platform_android extensions &

[Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-11 Thread Rob Herring
configs to the end is enough to prevent breaking GLX. The handling of RGBA/RGBX in dri_fill_st_visual is a fix from Marek Olšák. Cc: Eric Anholt Cc: Chad Versace Cc: Mauro Rossi Reviewed-by: Marek Olšák Signed-off-by: Rob Herring --- v2: - Incorporated dri_fill_st_visual RGBA/X handling from Marek

Re: [Mesa-dev] [PATCH 2/8] spirv: Add a prepass to set types on vtn_values

2017-12-12 Thread Rob Herring
On Thu, Dec 7, 2017 at 10:12 AM, Jason Ekstrand wrote: > This autogenerated pass will automatically find and set the type field > on all vtn_values. This way we always have the type and can use it for > validation and other checks. > --- > src/compiler/Makefile.nir.am | 4 + > src/

Re: [Mesa-dev] [RFC libdrm 1/5] android: Move gralloc handle struct to libdrm

2017-12-13 Thread Rob Herring
On Wed, Dec 13, 2017 at 11:30 AM, Robert Foss wrote: > This struct is used in mesa and drm_hwcomposer. > Versions of if have been implemented in several grallocs: > drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. > > Other than the 1:1 move of the struct a new generic name > has been chosen a

Re: [Mesa-dev] [RFC libdrm 3/5] android: Mark alloc_handle_t magic variable as const

2017-12-13 Thread Rob Herring
On Wed, Dec 13, 2017 at 11:30 AM, Robert Foss wrote: > Mark magic member of alloc_handle_t as const. > Also bump the version of alloc_handle_t. > > Sign-off-by: Robert Foss > --- > android/alloc_handle.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/android/alloc_h

[Mesa-dev] [PATCH] Android: fix missing generation of vtn_gather_types.c

2017-12-13 Thread Rob Herring
Commit bb1e6ff161c9 ("spirv: Add a prepass to set types on vtn_values") added generation of vtn_gather_types.c, but forgot to add it to the Android build files. Fixes: bb1e6ff161c9 ("spirv: Add a prepass to set types on vtn_values") Cc: Jason Ekstrand Signed-off-by: R

Re: [Mesa-dev] [PATCH v2] egl/android: Partially handle HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED

2017-12-13 Thread Rob Herring
On Wed, Dec 13, 2017 at 11:58 AM, Robert Foss wrote: > Hey Rob&Emil, > > I've chatted to both of you about this patch, and it seemed acceptable > to both of you. > > Can I have a s-o-b for either of you? I've applied it and pushed to master. Rob ___ me

Re: [Mesa-dev] [PATCH] Android: gallium_dri: add include to get "xmlpool/options.h"

2017-12-19 Thread Rob Herring
On Mon, Dec 18, 2017 at 8:45 PM, Yu, Qiang wrote: > I met this problem when upgrade mesa 17.2 to 17.3, and build without > a make clean. A clean build won't have this problem. I think I'm seeing a similar problem on CI builds with current master, but with intel_screen.c: external/mesa3d/src/mesa

Re: [Mesa-dev] [PATCH 1/1] Use getprogname from stdlib.h on all BSDs and APPLE

2017-12-20 Thread Rob Herring
On Sun, Dec 17, 2017 at 4:02 PM, Maya Rashish wrote: > Remove EOL NetBSD < 1.x (this didn't work, since we don't > include sys/param.h). > Remove EOL FreeBSD < 4.4 > > Functionally changes OpenBSD which now uses getprogname instead of > fallback. > --- > src/util/xmlconfig.c | 17 +++-

[Mesa-dev] [PATCH] Android: util: fix locale generation in options.h

2017-12-20 Thread Rob Herring
tions.h. Use "$<" instead of "$^" because we only need the first dependency (the script), not all dependencies. Signed-off-by: Rob Herring --- src/util/Android.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/Android.

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

2017-12-21 Thread Rob Herring
e fact the having at least initial backwards compatability would >> be nice. Anonymous unions can of course be used later on to provide >> backwards compatability if so desired. >> >> >> Get/Set functions >> - >> During the previous discussion[1

[Mesa-dev] [PATCH] egl/android: Fix build break with dri2_initialize_android _EGLDisplay parameter

2018-01-03 Thread Rob Herring
g 'disp', rename the function parameter 'dpy' to 'disp' to align with the other EGL platforms' implementations. Fixes: 2f421651aca9 ("egl: let each platform decided how to handle LIBGL_ALWAYS_SOFTWARE") Cc: Eric Engestrom Signed-off-b

Re: [Mesa-dev] [PATCH] egl/android: Fix build break with dri2_initialize_android _EGLDisplay parameter

2018-01-04 Thread Rob Herring
On Thu, Jan 4, 2018 at 8:16 AM, Eric Engestrom wrote: > On Wednesday, 2018-01-03 10:28:37 -0600, Rob Herring wrote: >> Commit 2f421651aca9 ("egl: let each platform decided how to handle >> LIBGL_ALWAYS_SOFTWARE") broke the build due to copy-n-paste of misnamed >>

[Mesa-dev] [PATCH] tgsi: include struct definitions for tgsi_build declarations

2018-01-08 Thread Rob Herring
/tgsi_build.h:47:1: error: 'tgsi_build_header' has C-linkage specified, but returns incomplete type 'struct tgsi_header' which could be incompatible with C [-Werror,-Wreturn-type-c-linkage] This error shows up on Android builds using clang and -Werror. Cc: Ilia Mirkin Signed

Re: [Mesa-dev] [PATCH] tgsi: include struct definitions for tgsi_build declarations

2018-01-08 Thread Rob Herring
On Mon, Jan 8, 2018 at 7:25 PM, Ilia Mirkin wrote: > On Mon, Jan 8, 2018 at 4:18 PM, Rob Herring wrote: >> Many of the functions declared in tgsi_build.h return structs (not struct >> pointers). Therefore the full struct definitions are needed to avoid >> warnings or

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

2018-01-12 Thread Rob Herring
v_color_range, is_updated etc.] >>>> >>>> >>>> https://chromium.googlesource.com/chromiumos/platform/minigbm/+/master/cros_gralloc/cros_gralloc_handle.h >>>> [use_flags, pixel_stride] >>>> >>>> In our case, removing our minigbm

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

2018-01-15 Thread Rob Herring
On Mon, Jan 15, 2018 at 7:09 AM, Robert Foss wrote: > Hey, > > On 01/13/2018 12:49 AM, Gurchetan Singh wrote: >> >> We can define accessor functions too (not ptrs), then the struct is >> opaque >> and you can do your own accessor implementation if aligning is not >> possible >> or desi

Re: [Mesa-dev] [PATCH v1 1/7] android: Move gralloc handle struct to libdrm

2018-01-16 Thread Rob Herring
On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote: > This struct is used in mesa and drm_hwcomposer. > Versions of if have been implemented in several grallocs: > drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. > > Other than the 1:1 move of the struct a new generic name > has been chosen a

Re: [Mesa-dev] [PATCH v1 1/7] android: Move gralloc handle struct to libdrm

2018-01-16 Thread Rob Herring
On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote: > This struct is used in mesa and drm_hwcomposer. > Versions of if have been implemented in several grallocs: > drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. > > Other than the 1:1 move of the struct a new generic name > has been chosen a

Re: [Mesa-dev] [PATCH v1 7/7] android: Add accessor functions for gralloc_handle_t variables

2018-01-16 Thread Rob Herring
On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote: > Supply accessor functions for most of the common gralloc_handle_t > variables. > > Signed-off-by: Robert Foss > --- > android/gralloc_handle.h | 57 > > 1 file changed, 57 insertions(+) > > d

Re: [Mesa-dev] [PATCH] egl: do not expose EGL_EXT_pixel_format_float yet

2018-01-18 Thread Rob Herring
On Wed, Jan 17, 2018 at 12:27 PM, Tapani Pälli wrote: > Let's expose this only when we have formats. There are some > known issues when this is exposed without formats (on Android). This is fixed now at least for master. Rob ___ mesa-dev mailing list m

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

2018-01-18 Thread Rob Herring
On Mon, Jan 15, 2018 at 6:31 AM, Tapani Pälli wrote: > This can/should be modified depending on needs. AFAIK by default, > this is the only path that can be read/written to by anyone. > > Signed-off-by: Tapani Pälli > --- > Android.common.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Mesa-dev] [PATCH] egl/dri: link directly to libglapi.so

2017-09-19 Thread Rob Herring
ve a handful of platform specific names of the > library. > > Cc: Jonathan Gray > Cc: Jon Turney > Cc: Julien Isorce > Cc: Rob Herring > Cc: Tomasz Figa > Signed-off-by: Emil Velikov > --- > src/egl/Android.mk | 2 ++ > src/egl/Makefile.am

[Mesa-dev] [PATCH] Android: move libraries to /vendor

2017-09-19 Thread Rob Herring
/system/vendor. Signed-off-by: Rob Herring --- Testing on prior Android versions would be appreciated. I don't think there should be any issues as /vendor has been supported for some time. Android.common.mk| 4 ++-- src/egl/Android.mk | 1 + src/ga

[Mesa-dev] [PATCH v2] Android: move libraries to /vendor

2017-09-21 Thread Rob Herring
/system/vendor. Signed-off-by: Rob Herring --- v2: - Set LOCAL_PROPRIETARY_MODULE globally. Thanks Tapani. Android.common.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Android.common.mk b/Android.common.mk index 6f70dd94a1f5..3447d34fd692 100644 --- a

Re: [Mesa-dev] initial meson port

2017-09-27 Thread Rob Herring
On Wed, Sep 27, 2017 at 12:38 PM, Eric Anholt wrote: > Dylan Baker writes: > >> [ Unknown signature status ] >> I've gone ahead and pushed the Vulkan drivers meson builds. >> >> For those interested in helping finish the conversion, I have a branch >> "wip/meson-4" on my github (github.com/dcbake

Re: [Mesa-dev] [PATCH v2] egl/dri: link directly to libglapi.so

2017-09-27 Thread Rob Herring
s us to remove a handful of platform specific workarounds, due > to the different name of the library. > > v2: > - Android: export the include dir (RobH) > - Drop unused local variable (Eric) > > Cc: Jonathan Gray > Cc: Jon Turney > Cc: Julien Isorce > Cc: Rob

[Mesa-dev] Fwd: errors for mesa master Android build 862

2017-10-01 Thread Rob Herring
FYI, 2 Android build errors on i965 and r600 started in the last week. I've been traveling and haven't investigated. Rob -- Forwarded message -- From: Date: Sat, Sep 30, 2017 at 5:19 PM Subject: errors for mesa master Android build 862 To: rob.herr...@linaro.org Build URL: ht

Re: [Mesa-dev] [PATCH 14/15] build: Remove HAVE_DLOPEN

2017-10-03 Thread Rob Herring
On Mon, Oct 2, 2017 at 1:59 AM, Matt Turner wrote: > --- > Android.common.mk | 1 - Reviewed-by: Rob Herring > configure.ac| 4 ++-- > meson.build | 1 - > src/mesa/SConscript | 4 > 4 files changed, 2 insertions(+), 8 deletions(-) > > diff --g

Re: [Mesa-dev] [PATCH v3 13/22] egl: add dri2_egl_surface_destroy_image_front() helper

2017-10-04 Thread Rob Herring
On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun wrote: > To share common destroy dri_image_front code. > > Signed-off-by: Mun Gwan-gyeong > --- > src/egl/drivers/dri2/egl_dri2.c | 14 ++ > src/egl/drivers/dri2/egl_dri2.h | 3 +++ > 2 files changed, 17 insertions(+) > > diff --git a/

Re: [Mesa-dev] [PATCH v3 07/22] egl: add dri2_egl_surface_update_buffer_age() helper

2017-10-04 Thread Rob Herring
On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun wrote: > To share common update buffer age code. > This updates old buffer's age and sets current back buffer's age to 1. > > Signed-off-by: Mun Gwan-gyeong > --- > src/egl/drivers/dri2/egl_dri2.c | 19 +++ > src/egl/drivers/dri2/eg

Re: [Mesa-dev] [PATCH v3 08/22] egl/tizen: add support of dri2_loader (v2)

2017-10-04 Thread Rob Herring
On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun wrote: > It adds support of dri2_loader to egl dri2 tizen backend. > - referenced a basic buffer flow and management implementation from android. > > And it implements a query buffer age extesion for tizen and turn on > swap_buffers_with_damage ext

Re: [Mesa-dev] [PATCH v3 13/22] egl: add dri2_egl_surface_destroy_image_front() helper

2017-10-04 Thread Rob Herring
On Wed, Oct 4, 2017 at 9:02 AM, Rob Herring wrote: > On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun wrote: >> To share common destroy dri_image_front code. >> >> Signed-off-by: Mun Gwan-gyeong >> --- >> src/egl/drivers/dri2/egl_dri2.c | 14 ++ &g

Re: [Mesa-dev] [PATCH 03/14] intel: Move definition of LOG_TAG from header into Makefiles

2017-10-09 Thread Rob Herring
On Mon, Oct 9, 2017 at 11:17 AM, Chad Versace wrote: > On Mon 09 Oct 2017, Tapani Pälli wrote: >> >> >> On 09/28/2017 03:11 AM, Chad Versace wrote: >> > This patch prevents compilation failures in upcoming Android Vulkan >> > patches, failures due to redefinition of LOG_TAG in Android system >> >

[Mesa-dev] [PATCH] Android: fix build break from r600/radeon split

2017-10-10 Thread Rob Herring
that drivers/radeon is only built when radeonsi (and therefore LLVM) is enabled. Fixes: 06bfb2d28f7a (r600: fork and import gallium/radeon) Cc: Marek Olšák Signed-off-by: Rob Herring --- src/gallium/Android.mk| 2 +- src/gallium/drivers/r600/Android.mk | 4 src/ga

[Mesa-dev] [PATCH] Android: disable i9x5 drivers on non-x86 builds

2017-10-11 Thread Rob Herring
The i965 driver has become dependent on x86 specific compiler builtin functions, so ensure it's disabled for non-x86 builds. Signed-off-by: Rob Herring --- Android.mk | 4 1 file changed, 4 insertions(+) diff --git a/Android.mk b/Android.mk index 9dc0bbd1d7d7..72a9b04be1e3 100644

[Mesa-dev] CI for Android builds

2017-10-12 Thread Rob Herring
I've made some improvements to my mesa Android CI job[1]. Previously, it just built using master twice a day and only emailed me. Now anyone (with commit rights) can push to mesa branches master or android/* and it will trigger a build emailing the last commit's author/committer on failure. It's s

Re: [Mesa-dev] [PATCH 7/8] android: support creating texture from gralloc buffer

2017-01-06 Thread Rob Herring
On Fri, Jan 6, 2017 at 11:35 AM, Wu Zhen wrote: > From: WuZhen > > Change-Id: Ifabf40fe94007f73171a89b23545002707817053 > Reviewed-by: Mauro Rossi > Reviewed-by: Chih-Wei Huang > --- > src/gallium/targets/dri/Android.mk| 1 + > src/gallium/winsys/sw/dri/dri_sw_winsys.c | 65 > +++

Re: [Mesa-dev] [PATCH v2 2/5] intel: Move tools/decoder.[ch] to common/gen_decoder.[ch].

2017-03-24 Thread Rob Herring
On Thu, Mar 23, 2017 at 5:32 PM, Matt Turner wrote: > On Wed, Mar 22, 2017 at 12:53 PM, Rob Herring wrote: >> On Wed, Mar 22, 2017 at 6:50 AM, Emil Velikov >> wrote: >>> n 21 March 2017 at 20:58, Kenneth Graunke wrote: >>>> On Tuesday, March 21, 20

Re: [Mesa-dev] [PATCH v3 2/4] vc4: Use a wrapper file to set VC4_BUILD_NEON instead of CFLAGS.

2017-04-18 Thread Rob Herring
On Fri, Apr 14, 2017 at 12:47 PM, Eric Anholt wrote: > Android.mk was setting the flag across the entire driver, so we didn't > have non-NEON versions getting built. This was going to be a problem with > the next commit, when I start auto-detecting NEON support and use the > non-NEON version when

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

2018-06-13 Thread Rob Herring
+Amit and John On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss wrote: > This patch both adds support for probing & filtering DRM nodes > and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD > gralloc call. > > Currently the filtering is based just on the driver name, > and the desired

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

2018-06-13 Thread Rob Herring
On Wed, Jun 13, 2018 at 12:19 PM, Amit Pundir wrote: > On 13 June 2018 at 20:45, Rob Herring wrote: >> >> +Amit and John >> >> On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss >> wrote: >> > This patch both adds support for probing & filtering D

[Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-19 Thread Rob Herring
GRALLOC_MODULE_PERFORM_GET_DRM_FD remains for now, but the definition is added locally to remove the header dependency. Signed-off-by: Rob Herring --- With this plus Robert's probing patch, we remove any gralloc implementation dependency (other than it has to be a pre 1.0 implementation...).

Re: [Mesa-dev] [RFC] egl/android: Add DRM node probing and filtering

2018-04-19 Thread Rob Herring
On Wed, Apr 18, 2018 at 11:03 AM, Robert Foss wrote: > This patch both adds support for probing & filtering DRM nodes > and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD > gralloc call. > > Currently the filtering is based just on the driver name, > and the desired name is supplie

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-20 Thread Rob Herring
On Fri, Apr 20, 2018 at 6:29 AM, Robert Foss wrote: > Hey Rob, > > This looks good to me. > Do you mind if I carry this patch my series to get it all pushed upstream at > once? No, not at all. Rob ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH v2 2/2] gallium/util: Android backtrace support

2018-04-24 Thread Rob Herring
On Sun, Apr 15, 2018 at 5:45 PM, Stefan Schake wrote: > We can't use any of the existing implementations in u_debug_stack. > Android technically has libunwind, but it's been modified to the point > where it no longer compiles with the Mesa usage. The library is also > not meant to be referenced by

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-26 Thread Rob Herring
On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov wrote: > On 26 April 2018 at 03:30, Chih-Wei Huang wrote: >> 2018-04-25 19:55 GMT+08:00 Robert Foss : >>> Hey Emil & Chih-Wei, >>> >>> On 04/24/2018 01:59 PM, Emil Velikov wrote: On 24 April 2018 at 12:28, Emil Velikov wrote: > On

Re: [Mesa-dev] [PATCH v1 1/2] egl/android: #ifdef out flink name support

2018-04-30 Thread Rob Herring
On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss wrote: > From: Rob Herring > > Maintaining both flink names and prime fd support which are provided by > 2 different gralloc implementations is problematic because we have a > dependency on a specific gralloc implementation header.

Re: [Mesa-dev] [PATCH v1 1/2] egl/android: #ifdef out flink name support

2018-05-01 Thread Rob Herring
On Tue, May 1, 2018 at 3:13 AM, Robert Foss wrote: > Hey Rob, > > > On 2018-05-01 04:20, Rob Herring wrote: >> >> On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss >> wrote: >>> >>> From: Rob Herring >>> >>> Maintaining both flin

Re: [Mesa-dev] [PATCH 0/3] egl/android: Remove dependencies on specific grallocs

2018-05-24 Thread Rob Herring
>> >> Changes since v1: >> - Added fix for build issue >> - Do not rely on libdrm for probing >> - Distinguish between errors and when no drm devices are found >> >> Changes since RFC: >> - Rebased work on the libdrm patch [2]. >> - Inc

Re: [Mesa-dev] [PATCH 0/3] egl/android: Remove dependencies on specific grallocs

2018-05-25 Thread Rob Herring
On Fri, May 25, 2018 at 4:15 AM, Robert Foss wrote: > > > On 2018-05-25 10:38, Tomasz Figa wrote: >> >> On Fri, May 25, 2018 at 5:33 PM Robert Foss >> wrote: >> >>> Hey, >> >> >>> On 2018-05-25 02:17, Rob Herring wrote: >

Re: [Mesa-dev] [PATCH 0/3] egl/android: Remove dependencies on specific grallocs

2018-05-25 Thread Rob Herring
On Fri, May 25, 2018 at 9:25 AM, Tomasz Figa wrote: > On Fri, May 25, 2018 at 10:59 PM Rob Herring wrote: > >> On Fri, May 25, 2018 at 4:15 AM, Robert Foss > wrote: >> > >> > >> > On 2018-05-25 10:38, Tomasz Figa wrote: >> >> >>

Re: [Mesa-dev] [PATCH 1/3] android: broadcom/genxml: fix collision with intel/genxml header-gen macro

2018-09-06 Thread Rob Herring
On Mon, Sep 3, 2018 at 4:27 PM Eric Anholt wrote: > > Mauro Rossi writes: > > > Fixes the following building error, happening when building both intel and > > broadcom: > > I wish someone maintaining android Mesa would work on making the meson > build work for them instead of just continuing to

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-20 Thread Rob Herring
masz Figa wrote: >>>> >>>> On Fri, Feb 16, 2018 at 11:33 PM, Robert Foss >>>> wrote: >>>>> >>>>> Hey Tomasz, >>>>> >>>>> >>>>> On 02/16/2018 05:10 AM, Tomaszzz Figa wrote: >>>>

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 Thread Rob Herring
On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov wrote: > Hi all, > > Pardon for dropping in late. I think you've got nearly everything > settled down, just sharing a couple of ideas. > > On 21 February 2018 at 04:19, Tomasz Figa wrote: >> On Wed, Feb 21, 2018 a

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-21 Thread Rob Herring
On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov wrote: > On 21 February 2018 at 18:50, Rob Herring wrote: >> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov >> wrote: >>> Hi all, >>> >>> Pardon for dropping in late. I think you've got nearly everyt

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-24 Thread Rob Herring
On Wed, Jan 24, 2018 at 4:04 AM, Tomasz Figa wrote: > Hi Robert, > > On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss > wrote: >> This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, >> since at least 4 implementations exist, and share a lot of contents. >> The idea is to keep the com

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-25 Thread Rob Herring
On Thu, Jan 25, 2018 at 10:21 AM, Robert Foss wrote: > Hey Tomasz, > > On 01/24/2018 11:04 AM, Tomasz Figa wrote: >> >> Hi Robert, >> >> On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss >> wrote: >>> >>> This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, >>> since at least 4 implemen

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-02 Thread Rob Herring
>>>>>>> } gralloc_funcs_t; >>> >>> >>> These ones? > >>> Yeah, if we could retrieve such function pointer struct using perform >>> or any equivalent (like the implementation-specific methods in >>> gralloc1, but not sur

Re: [Mesa-dev] [PATCH v2 1/6] android: Move gralloc handle struct to libdrm

2018-02-05 Thread Rob Herring
t; has been chosen and variables have had comments added to them. > > Signed-off-by: Robert Foss > --- > Changes since v1: > Suggested by Rob Herring: > - Fixed copyright statement > - Moved FDs to be first in handle > - Initialize native_handle_t using native_handle_cr

Re: [Mesa-dev] [PATCH v3 5/6] android: Change gralloc_handle_t format from Android format to fourcc

2018-02-08 Thread Rob Herring
ranslation will still have to happen somewhere. The cros implementation has both formats. We should perhaps figure out why both are needed (plus I haven't actually tested this change). So the rest of the series looks good to me, but I'd hold off on this one.

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-02-09 Thread Rob Herring
On Fri, Feb 9, 2018 at 3:58 AM, Tomasz Figa wrote: > On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote: >> On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote: >>> On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote: >>>> Hi Rob, >>>> >>

Re: [Mesa-dev] [PATCH] android: i965: generate code for OA counter queries

2017-03-19 Thread Rob Herring
On Thu, Mar 16, 2017 at 8:34 AM, Emil Velikov wrote: > On 13 March 2017 at 22:36, Mauro Rossi wrote: >> 2017-03-13 14:00 GMT+01:00 Emil Velikov : >>> >>> On 12 March 2017 at 23:01, Mauro Rossi wrote: >>> > Automake generation rules are replicated for android. >>> > $* macro was expected to retur

[Mesa-dev] [PATCH 4/5] Android: drop Android 4.4 (KitKat) support

2017-03-19 Thread Rob Herring
Any users of KitKat are likely using an older version of Mesa and KitKat support adds complexity to the make files. Dropping support allows removing the MESA_LOLLIPOP_BUILD make variable in various make files. Signed-off-by: Rob Herring --- Android.common.mk | 19

[Mesa-dev] [PATCH 3/5] Android: kill off {MESA_}ANDROID_VERSION defines

2017-03-19 Thread Rob Herring
The Android version defines are only needed for versions less than 4.2 which aren't really supported or tested. Signed-off-by: Rob Herring --- Android.common.mk | 2 -- Android.mk | 1 - src/egl/Android.mk | 5 +

[Mesa-dev] [PATCH 5/5] Android: disable AMD common when LLVM is disabled

2017-03-19 Thread Rob Herring
LLVM enabled builds are broken with AOSP master. If building all targets using "mmma external/mesa3d", the libmesa_amd_common will get built and fail due to LLVM dependencies. Fix this by making it dependent on MESA_ENABLE_LLVM. Signed-off-by: Rob Herring --- src/amd/Android.mk | 2

[Mesa-dev] [PATCH 0/5] Android build clean-up and fixes

2017-03-19 Thread Rob Herring
. Also, building with "mmma external/mesa3d" instead of just top-level make, uncovered a few other problems. Rob Rob Herring (5): Android: remove host libmesa_util Android: fix libz dependency for host targets Android: kill off {MESA_}ANDROID_VERSION defines Android: drop Android 4

[Mesa-dev] [PATCH 1/5] Android: remove host libmesa_util

2017-03-19 Thread Rob Herring
The host libmesa_util is never used for Android builds, so remove it. Signed-off-by: Rob Herring --- src/util/Android.mk | 35 --- 1 file changed, 35 deletions(-) diff --git a/src/util/Android.mk b/src/util/Android.mk index a39185ae49e0..64aafbe2ee15 100644

[Mesa-dev] [PATCH 2/5] Android: fix libz dependency for host targets

2017-03-19 Thread Rob Herring
ry dependencies" Signed-off-by: Rob Herring --- Android.common.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Android.common.mk b/Android.common.mk index 58bda59962be..89b1061eb100 100644 --- a/Android.common.mk +++ b/Android.common.mk @@ -127,4 +127,6 @@ endif # Quiet down the bui

Re: [Mesa-dev] [PATCH 4/5] Android: drop Android 4.4 (KitKat) support

2017-03-20 Thread Rob Herring
On Sun, Mar 19, 2017 at 10:09 PM, Chih-Wei Huang wrote: > 2017-03-20 9:33 GMT+08:00 Rob Herring : >> Any users of KitKat are likely using an older version of Mesa and >> KitKat support adds complexity to the make files. Dropping support >> allows removing the MESA_LOLLIPOP_B

Re: [Mesa-dev] [PATCH 3/5] Android: kill off {MESA_}ANDROID_VERSION defines

2017-03-20 Thread Rob Herring
On Mon, Mar 20, 2017 at 10:51 AM, Emil Velikov wrote: > Nit: > > Subject: Android: kill off {MESA_}ANDROID_VERSION defines aka Android > 4.1 and older > > On 20 March 2017 at 01:33, Rob Herring wrote: >> The Android version defines are only needed for versions less

Re: [Mesa-dev] [PATCH 4/5] Android: drop Android 4.4 (KitKat) support

2017-03-20 Thread Rob Herring
On Mon, Mar 20, 2017 at 11:03 AM, Emil Velikov wrote: > On 20 March 2017 at 01:33, Rob Herring wrote: >> Any users of KitKat are likely using an older version of Mesa and >> KitKat support adds complexity to the make files. Dropping support >> allows removing the MES

Re: [Mesa-dev] [PATCH 4/5] Android: drop Android 4.4 (KitKat) support

2017-03-20 Thread Rob Herring
On Mon, Mar 20, 2017 at 11:03 AM, Emil Velikov wrote: > On 20 March 2017 at 01:33, Rob Herring wrote: >> Any users of KitKat are likely using an older version of Mesa and >> KitKat support adds complexity to the make files. Dropping support >> allows removing the MES

[Mesa-dev] [PATCH v2 0/5] Android build clean-up and fixes

2017-03-21 Thread Rob Herring
27;ve dropped the hack for libmesa_amd_common. r600g and radeonsi are pretty broken and the hack alone is not enough. More work is needed. Rob Rob Herring (5): Android: clean-up trailing '\' in make variables Android: remove host libmesa_util Android: fix libz dependency for host ta

[Mesa-dev] [PATCH v2 1/5] Android: clean-up trailing '\' in make variables

2017-03-21 Thread Rob Herring
Fixed with the following command: perl -pe 'BEGIN{undef $/;} s/ \\\n\n/\n\n/smg' $(find . -name 'Android.*') Signed-off-by: Rob Herring --- v2: - new patch Android.common.mk | 2 +- src/compiler/Android.glsl.gen.mk | 4 ++-- src/com

[Mesa-dev] [PATCH v2 4/5] Android: kill off {MESA_}ANDROID_VERSION defines aka Android 4.1 and older

2017-03-21 Thread Rob Herring
The Android version defines are only needed for versions less than 4.2 which aren't really supported or tested. Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli --- v2: - Update subject - drop trailing \ on make variables Android.common.mk | 4 +--- Andro

[Mesa-dev] [PATCH v2 3/5] Android: fix libz dependency for host targets

2017-03-21 Thread Rob Herring
ry dependencies" Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli --- v2: - no change Android.common.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Android.common.mk b/Android.common.mk index 0130c585aed1..062f8328d87d 100644 --- a/Android.common.mk +++ b/Android.common

<    1   2   3   4   5   6   7   >