The pass keyword is the solution for python's whitespace significant
code. It's used when something is needed for whitespace rules, but not
for programming. Don't add it after actual code.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_send.py | 1 -
1 file chan
There are two ways to handle this. One is to use the _ placeholder value
when multiple values are needed. The second is to use list indexing to
get only the values actually needed when only one value is desired.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_send.py | 10
Don't assign variables that aren't actually used, just put them in _,
the python unused variable.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_x86-64_asm.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_x86-64_asm.py
b/src/mapi
This just saves a bit of typing.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_server_table.py | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/src/mapi/glapi/gen/glX_server_table.py
b/src/mapi/glapi/gen/glX_server_table.py
index 4549fbd..a4bc04f 100644
This makes the function a little simpler by using a special case for the
initial "ARB", and just walking the str as a sequence rather than
indexing into it.
It also uses a list to join rather than overwritting a str over and over
again.
Signed-off-by: Dylan Baker
---
src/mapi
This method is a no-op, but it shuts up tools that get upset that Print
calls a non-existent method.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py
index 73baef6
This code has for a long time returned 0 on entry. This makes the code
dead, and the one place it is invoked a no-op if statement (it will
always go down the if path).
Thanks to version control it's rather simple to restore it if someday
someone decides that they want it.
Signed-off-by:
The variable has the same value as the explicit None return, but makes
it clearer what's going on.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_common.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/glX_proto_common.py
b/src/mapi/
str is a builtin in python, although python doesn't prevent builtins
from being shadowed, its still a bad idea.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_send.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/mapi/glap
This is a pretty minor refactor, but it avoids having an else statement
with a nested if. It instead makes it one big if statement.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/mapi/glapi/gen
Rather than using a loop, and augmenting a variable use a generator and
sum to achieve the same result.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_x86_asm.py | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_x86_asm.py b/src/mapi
Rather than using a variable called junk, use _ for unused unpacked
values. This is much more idiomatic.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_common.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/glX_proto_common.py
b/src/mapi
Quoting Michael Schellenberger Costa (2016-04-01 01:30:53)
> Hi,
>
> minor nitpicks wrt ordering below
>
> Am 01.04.2016 um 02:04 schrieb Dylan Baker:
> > Completely clean the imports:
> > - Split so that one module is imported per line
> > - Remove unused i
Quoting Ilia Mirkin (2016-04-01 08:46:19)
> IMHO this is still quite fancy and unnecessarily complicated.
>
> How about
>
> temp = dict((f.offset, f) for f in self.functions_by_name.itervalues())
> return (temp[offset] for offset in sorted(temp))
>
> That's all that's happening there, right?
Quoting Ilia Mirkin (2016-04-01 11:47:49)
> On Fri, Apr 1, 2016 at 2:41 PM, Dylan Baker wrote:
> > Quoting Ilia Mirkin (2016-04-01 08:46:19)
> >
> > Something like this(?):
> >
> > temp = [(f.offset, f) for f in self.functions_by_name.itervalues()
> >
Quoting Eduardo Lima Mitev (2016-04-08 08:26:22)
> On 04/08/2016 01:35 AM, Kenneth Graunke wrote:
> > Some passes may not refer to options->..., at which point the compiler
> > will warn about an unused variable. Just cast to void unconditionally
> > to shut it up.
> >
> > Signed-off-by: Kenneth G
Quoting Kenneth Graunke (2016-04-08 11:48:01)
> On Friday, April 8, 2016 11:18:46 AM PDT Dylan Baker wrote: >
> > Quoting Eduardo Lima Mitev (2016-04-08 08:26:22)
> > > On 04/08/2016 01:35 AM, Kenneth Graunke wrote:
> > > > Some passes may not refer to options-
Quoting Dylan Baker (2016-04-08 14:54:38)
> Quoting Kenneth Graunke (2016-04-08 11:48:01)
> > On Friday, April 8, 2016 11:18:46 AM PDT Dylan Baker wrote: >
> > > Quoting Eduardo Lima Mitev (2016-04-08 08:26:22)
> > > > On 04/08/2016 01:35 AM, Kenneth Graunke wro
Quoting Connor Abbott
[sni]
>
> Well, I could make the change, but at this point it would be a bit
> more involved. I'd have to figure out how to get the list of files
> changed with each commit and then run a sed job on only them
> (otherwise I'd re-swap the arguments for everything else), and th
bump
signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Quoting Ian Romanick (2016-04-19 12:51:04)
> On 03/31/2016 05:04 PM, Dylan Baker wrote:
> > This allows, among other things, the proper use of the Copyright symbol
> > in the copyright header (which this patch also does).
> >
> > It cannot be used in the printed temp
Quoting Ian Romanick (2016-04-19 12:53:00)
> On 03/31/2016 05:04 PM, Dylan Baker wrote:
> > It's a bit odd to call IBM out in particular, especially since Brian
> > Paul is listed as a copyright holder on chronologically before IBM.
> > Either way this should probably
Quoting Ian Romanick (2016-04-19 13:00:16)
> This patch is
>
> Reviewed-by: Ian Romanick
>
> I guess the spurious whitespace changes in the previous patch should
> have been in this patch.
Probably, I'll see if I can fix that when I spin v2.
>
> On 03/31/201
ixed it in the intervening years...). Python doesn't fit the
expectations that most editors have for how a language works.
>
> Reviewed-by: Ian Romanick
>
> On 03/31/2016 05:04 PM, Dylan Baker wrote:
> > In python functions return None by default, and it's uncommon to us
Quoting Ian Romanick (2016-04-19 14:56:11)
> On 03/31/2016 05:04 PM, Dylan Baker wrote:
> > Remove parens that don't do anything. Mostly these are extra grouping
> > parens in if statements, that aren't needed. Unlike C python doesn't
> > require parens ar
Quoting Ian Romanick (2016-04-19 15:07:09)
> On 03/31/2016 05:04 PM, Dylan Baker wrote:
> > RuntimeError is a very specific type of error. In almost very case it's
> > being raised where an assert is the right choice, and in the rest using
> > a plain Exception is b
Quoting Ian Romanick (2016-04-19 14:55:19)
> On 03/31/2016 05:04 PM, Dylan Baker wrote:
> > Rather than using the string module, use the same method for the str
> > instance (join, split, replace, etc).
> >
> > It's more forward looking, since it will make smoothin
Quoting Ian Romanick (2016-04-19 15:14:59)
> On 03/31/2016 05:04 PM, Dylan Baker wrote:
> > This does basically the same thing as the previous implementation,
> > although it uses sorted() to act on the dictionary without first copying
> > the keys out into a list, and then i
Quoting Ian Romanick (2016-04-19 16:13:51)
> On 04/01/2016 11:47 AM, Ilia Mirkin wrote:
> > On Fri, Apr 1, 2016 at 2:41 PM, Dylan Baker wrote:
> >> Quoting Ilia Mirkin (2016-04-01 08:46:19)
> >>> IMHO this is still quite fancy and unnecessarily comp
sion that is causing problems along with the exception. Also, it
> will now report all of the errors it finds and then exit at the end like a
> standard C compiler would do.
>
> Cc: Dylan Baker
> ---
> src/compiler/nir/nir_algebraic.py | 17 -
> 1 file chan
Quoting Jason Ekstrand (2016-04-26 14:31:10)
>
>
> On Tue, Apr 26, 2016 at 12:47 PM, Dylan Baker wrote:
>
> Quoting Jason Ekstrand (2016-04-25 21:39:19)
> > Previously, if an exception was encountered anywhere, nir_algebraic
> would
> > just di
For what it's worth, patches 1-5 are:
Reviewed-by: Dylan Baker
On Wed, Apr 29, 2015 at 04:25:56PM -0700, Ian Romanick wrote:
> From: Ian Romanick
>
> Signed-off-by: Ian Romanick
> ---
> src/mesa/main/context.h | 8
> 1 file changed, 4 insertions(+), 4 deletio
You have a typo in the subject line: s/has/hash
signature.asc
Description: Digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
;"
As a nit, putting a newline between the table and the docstring is nice.
The only thing I wonder is does it make more sense to save this table as
a json document and use json.load instead of storing it as python? It is
just data with no function calls or definitions. It doesn&#x
With an opinion on using json rather than python for this data:
Patches 3-6: Reviewed-by: Dylan Baker
signature.asc
Description: Digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
Reviewed-by: Dylan Baker
On Wed, May 13, 2015 at 12:44:42PM -0700, Ian Romanick wrote:
> From: Ian Romanick
>
> Signed-off-by: Ian Romanick
> Cc: Dylan Baker
> ---
> src/mapi/glapi/gen/gl_XML.py | 22 +-
> 1 file changed, 5 insertions(+), 17 deletio
From: Dylan Baker
This makes the tools shut up about a bunch of problems, making them more
useful for catching actual problems.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/remap_helper.py | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/mapi
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_enums.py | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_enums.py b/src/mapi/glapi/gen/gl_enums.py
index f45782d..927a68b 100644
--- a/src/mapi/glapi/gen/gl_enums.py
From: Dylan Baker
Make the code simpler, cleaner, and easier to work with.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/remap_helper.py | 46 ++
1 file changed, 22 insertions(+), 24 deletions(-)
diff --git a/src/mapi/glapi/gen/remap_helper.py
b/src
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_apitemp.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_apitemp.py b/src/mapi/glapi/gen/gl_apitemp.py
index 7647428..5e985a2 100644
--- a/src/mapi/glapi/gen/gl_apitemp.py
+++ b/src/mapi/glapi
From: Dylan Baker
Shuts up analysis tools to make them return actual problems.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_procs.py | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_procs.py b/src/mapi/glapi/gen
From: Dylan Baker
Making the tools shut up about worthless errors so you can see real ones
is very useful
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_table.py | 42 ++
1 file changed, 26 insertions(+), 16 deletions(-)
diff --git a/src/mapi
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_gentable.py | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_gentable.py
b/src/mapi/glapi/gen/gl_gentable.py
index 06a5ebf..f7ffaf0 100644
--- a/src/mapi/glapi/gen
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_gentable.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_gentable.py
b/src/mapi/glapi/gen/gl_gentable.py
index f7ffaf0..32c1b68 100644
--- a/src/mapi/glapi/gen/gl_gentable.py
+++ b/src/mapi
From: Dylan Baker
This results in slightly less code, but code that is much more readable.
It has the advantage of putting everything together in one place, all of
the code is self documenting, help messages are auto-generated, choices
are automatically enforced, and the syntax is much less C
This is a small slice of a larger series I'm working on with the end
goal of using mako, the khronos XML, and being python3 compatible with
our generators. That series is over 100 patches already, and not even
finished with the first step of using mako. I've sent this out to get
some patches landed
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_enums.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_enums.py b/src/mapi/glapi/gen/gl_enums.py
index 927a68b..955f27d 100644
--- a/src/mapi/glapi/gen/gl_enums.py
+++ b/src/mapi/glapi/gen
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_x86_asm.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_x86_asm.py b/src/mapi/glapi/gen/gl_x86_asm.py
index 86d45f2..c0c7941 100644
--- a/src/mapi/glapi/gen/gl_x86_asm.py
+++ b/src/mapi/glapi
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_apitemp.py | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_apitemp.py b/src/mapi/glapi/gen/gl_apitemp.py
index 4157032..7647428 100644
--- a/src/mapi/glapi/gen
From: Dylan Baker
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_procs.py | 42 +++---
1 file changed, 19 insertions(+), 23 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_procs.py b/src/mapi/glapi/gen/gl_procs.py
index d5ffb92..cf6d2de 100644
--- a
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_x86_asm.py | 39 ++-
1 file changed, 14 insertions(+), 25 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_x86_asm.py b/src/mapi/glapi/gen/gl_x86_asm.py
index f855dba..86d45f2 100644
--- a/src/mapi/glapi/gen
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_recv.py | 55
1 file changed, 30 insertions(+), 25 deletions(-)
diff --git a/src/mapi/glapi/gen/glX_proto_recv.py
b/src/mapi/glapi/gen/glX_proto_recv.py
index d076409..dbc26a8 100644
--- a/src/mapi
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_x86-64_asm.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_x86-64_asm.py
b/src/mapi/glapi/gen/gl_x86-64_asm.py
index 0188964..cf42371 100644
--- a/src/mapi/glapi/gen/gl_x86-64_asm.py
+++ b
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_recv.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/glX_proto_recv.py
b/src/mapi/glapi/gen/glX_proto_recv.py
index dbc26a8..da468dc 100644
--- a/src/mapi/glapi/gen/glX_proto_recv.py
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_genexec.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_genexec.py b/src/mapi/glapi/gen/gl_genexec.py
index dbaafa7..0d58a8a 100644
--- a/src/mapi/glapi/gen/gl_genexec.py
+++ b/src/mapi/glapi
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_send.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/glX_proto_send.py
b/src/mapi/glapi/gen/glX_proto_send.py
index ea766af..2b33030 100644
--- a/src/mapi/glapi/gen/glX_proto_send.py
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_send.py | 59 +---
1 file changed, 28 insertions(+), 31 deletions(-)
diff --git a/src/mapi/glapi/gen/glX_proto_send.py
b/src/mapi/glapi/gen/glX_proto_send.py
index b93989f..ea766af 100644
--- a/src/mapi
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_server_table.py | 38 ++
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/src/mapi/glapi/gen/glX_server_table.py
b/src/mapi/glapi/gen/glX_server_table.py
index 47aa111..2d21f4e 100644
--- a/src
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_genexec.py | 29 -
1 file changed, 12 insertions(+), 17 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_genexec.py b/src/mapi/glapi/gen/gl_genexec.py
index 4e76fe3..dbaafa7 100644
--- a/src/mapi/glapi/gen
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_SPARC_asm.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_SPARC_asm.py
b/src/mapi/glapi/gen/gl_SPARC_asm.py
index df7a039..fa6217e 100644
--- a/src/mapi/glapi/gen/gl_SPARC_asm.py
+++ b/src
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_size.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/glX_proto_size.py
b/src/mapi/glapi/gen/glX_proto_size.py
index 59f65d4..75fc26f 100644
--- a/src/mapi/glapi/gen/glX_proto_size.py
This is roughly equivalent to the original getopt, except that it
removes the '-h' short option, which argparse reserves for
auto-generated help messages. It does retain the long option specified
by the getopt version, and changes the makefile to use that.
Signed-off-by: Dylan Baker
Also removes the redundant -m argument, which could only be set to
'generic', or it would raise an exception. This option wasn't used in
the make file.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_x86-64_asm.py | 40 +++--
1 file changed
Also drop -m switch, which only accepted a single value or raised an
error, and was unused in the makefile.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_SPARC_asm.py | 38 ++
1 file changed, 14 insertions(+), 24 deletions(-)
diff --git a/src/mapi
Err, yes. Fixed.
On Wed, May 20, 2015 at 06:27:22PM -0700, Matt Turner wrote:
> > glapi: gl_procs.py: Fix a few long hanging style things
>
> s/long/low/ presumably
signature.asc
Description: Digital signature
___
mesa-dev mailing list
mesa-dev@lists.
Fixed locally
On Wed, May 20, 2015 at 06:28:58PM -0700, Matt Turner wrote:
> On Wed, May 20, 2015 at 6:03 PM, Dylan Baker wrote:
> > Signed-off-by: Dylan Baker
> > ---
> > src/mapi/glapi/gen/gl_gentable.py | 29 +++--
> > 1 file changed, 15
The arguments for glX_proto_size.py changed slightly, the '-h' short
option was removed, because argparse reserves that for help messages.
The auto-tools based build was already updated to account for this
change, but the scons build was not.
Signed-off-by: Dylan Baker
---
The Scon
Well, I wrote the exact same patch and sent it a few seconds ago before
I noticed this.
Sorry to break things.
Reviewed-by: Dylan Baker
On Fri, May 22, 2015 at 01:23:52PM -0700, Brian Paul wrote:
> Replace -h with --header-tag as was done for the Makefile build.
> ---
> src/glx/SCons
On Tue, May 26, 2015 at 11:15:36AM +0100, Jose Fonseca wrote:
> argparse type is a nice type saver for simple data types, but it doesn't
> look a good fit for the input XML file:
>
> - Certain implementations of argparse (particularly python 2.7.3's)
> invoke the type constructor for the default
On Tue, May 26, 2015 at 02:05:41PM -0400, Ilia Mirkin wrote:
> On Tue, May 26, 2015 at 2:06 PM, Dylan Baker wrote:
> > On Tue, May 26, 2015 at 11:15:36AM +0100, Jose Fonseca wrote:
> >> argparse type is a nice type saver for simple data types, but it doesn't
> >> l
On Tue, May 26, 2015 at 02:15:37PM -0400, Ilia Mirkin wrote:
> On Tue, May 26, 2015 at 2:14 PM, Dylan Baker wrote:
> > On Tue, May 26, 2015 at 02:05:41PM -0400, Ilia Mirkin wrote:
> >> On Tue, May 26, 2015 at 2:06 PM, Dylan Baker
> >> wrote:
> >> > On Tue,
Tested-by: Dylan Baker
On Wednesday, July 02, 2014 02:28:07 PM Keith Packard wrote:
> A driver which doesn't have async flip support will queue up flips without any
> way to replace them afterwards. This means we've got a scanout buffer pinned
> as soon as we schedule a
Quoting Marek Olšák (2016-03-10 06:57:57)
> On Thu, Mar 10, 2016 at 3:30 PM, tournier.elie
> wrote:
> > First, thank you all for your answers.
> >
> > So if I summarize what was said, we need
> > Ian:
> > - add
> > - negate
> > - absolute value
> > - multiply
> > - reciprocal
> > - convert
Quoting Adam Jackson (2016-03-24 10:58:40)
> Broken by:
>
> commit 9ace0b542241c77ae82a0835ac8a09e2a7510eaf
> Author: Dylan Baker
> Date: Wed May 20 15:49:11 2015 -0700
>
> glapi: glX_proto_size.py: use argparse instead of getopt
>
> Whic
Quoting Adam Jackson (2016-03-24 11:09:56)
> Broken by:
>
> commit 9ace0b542241c77ae82a0835ac8a09e2a7510eaf
> Author: Dylan Baker
> Date: Wed May 20 15:49:11 2015 -0700
>
> glapi: glX_proto_size.py: use argparse instead of getopt
>
> Whic
Quoting Adam Jackson (2016-03-24 11:10:01)
> Signed-off-by: Adam Jackson
> ---
> src/mapi/glapi/gen/gl_XML.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py
> index 2e7123e..e11f6fc 100644
> --- a/src/mapi/glap
Quoting Adam Jackson (2016-03-24 11:10:03)
[snip]
> @@ -620,9 +617,10 @@ class PrintGlxReqSize_c(PrintGlxReqSize_common):
> if s == 0: s = 1
>
> sig += "(%u,%u)" % (f.offset_of(p.counter), s)
> -size += '%s%s' % (plus, p.size_string())
> -
Quoting Dylan Baker (2016-03-25 16:01:00)
> Quoting Adam Jackson (2016-03-24 11:10:01)
> > Signed-off-by: Adam Jackson
> > ---
> > src/mapi/glapi/gen/gl_XML.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/mapi/g
Quoting Ian Romanick (2016-03-28 11:03:58)
> On 03/25/2016 05:33 PM, Dylan Baker wrote:
> > Quoting Dylan Baker (2016-03-25 16:01:00)
> >> Quoting Adam Jackson (2016-03-24 11:10:01)
> >>> Signed-off-by: Adam Jackson
> >>> ---
> >>> src/ma
Quoting Adam Jackson (2016-03-29 07:41:01)
> On Mon, 2016-03-28 at 11:19 -0700, Dylan Baker wrote:
> > Quoting Ian Romanick (2016-03-28 11:03:58)
> > >
> > > On 03/25/2016 05:33 PM, Dylan Baker wrote:
> > > >
> > > > Quoting Dylan Baker (201
This adds support for python 2 in genxml, and disables python3 support
across the board, since genxml is now required for both vulkan and the
i965 OpenGL driver.
Dylan Baker (7):
genxml: mark gen_pack_header.py as encoded in utf-8
genxml: Make classes descendants of object
genxml: mark re
There is unicode in this file, and I'm actually surprised that the
python interpreter hasn't gotten grumpy.
Signed-off-by: Dylan Baker
---
src/intel/genxml/gen_pack_header.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/genxml/gen_pack_header.py
b/src/in
This is the default in python3, but in python2 you get old style
classes. No one likes old-style classes.
Signed-off-by: Dylan Baker
---
src/intel/genxml/gen_pack_header.py | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/intel/genxml/gen_pack_header.py
This fixes gen_pack_header to work on python 2, where name[0] is unicode
not str.
Signed-off-by: Dylan Bake
---
src/intel/genxml/gen_pack_header.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/genxml/gen_pack_header.py
b/src/intel/genxml/gen_pack_header.py
ind
This is a correctness issue.
Signed-off-by: Dylan Baker
---
src/intel/genxml/gen_pack_header.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/genxml/gen_pack_header.py
b/src/intel/genxml/gen_pack_header.py
index ddaa234..a0037cea 100644
--- a/src/intel
Signed-off-by: Dylan Baker
---
src/intel/genxml/gen_pack_header.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/genxml/gen_pack_header.py
b/src/intel/genxml/gen_pack_header.py
index 98e5676..468bfea 100644
--- a/src/intel/genxml/gen_pack_header.py
+++ b/src
Now there are not files that require python 3, so for now just remove
the python 3 dependency and use python 2. I think the right plan is to
just get all of the python ready for python 3, and then use whatever
python is available.
Signed-off-by: Dylan Baker
---
configure.ac | 8
Signed-off-by: Dylan Baker
---
src/intel/genxml/gen_pack_header.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/intel/genxml/gen_pack_header.py
b/src/intel/genxml/gen_pack_header.py
index a0037cea..98e5676 100644
--- a/src/intel/genxml/gen_pack_header.py
+++ b/src/intel/genxml
This is the default in python3, but in python2 you get old style
classes. No one likes old-style classes.
Signed-off-by: Dylan Baker
---
v2: - remove extra newlines
src/intel/genxml/gen_pack_header.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/genxml
This fixes gen_pack_header to work on python 2, where name[0] is unicode
not str.
Signed-off-by: Dylan Bake
---
v2: - remove extra newline
src/intel/genxml/gen_pack_header.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/genxml/gen_pack_header.py
b/src/intel/ge
;generated file, do not edit" warning.
Signed-off-by: Dylan Baker
---
src/intel/isl/Makefile.am| 7 +-
src/intel/isl/gen_format_layout.c.mako | 77 +
src/intel/isl/gen_format_layout.py | 143 +++
src/intel/isl/isl_format_
[snip]
Quoting Jason Ekstrand (2016-06-08 16:20:33)
> gen_format_layout.c.mako
>
> I made this comment in the office today but I think the mako here is simple
> enough that we might be better off just putting it all in one file.
>
I know you're not a fan of separate templates, and if the consen
Emil, should this take an argument, or is it fine as is? I was going to
ask Matt, but he's on vacation...
Dylan
signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo
Quoting Emil Velikov (2016-06-09 14:12:46)
> On 9 June 2016 at 21:56, Dylan Baker wrote:
> > Emil, should this take an argument, or is it fine as is? I was going to
> > ask Matt, but he's on vacation...
> >
> As Jason, suggested - it's better if the build prov
Quoting Dylan Baker (2016-06-09 15:06:42)
> Quoting Emil Velikov (2016-06-09 14:12:46)
> > On 9 June 2016 at 21:56, Dylan Baker wrote:
> > > Emil, should this take an argument, or is it fine as is? I was going to
> > > ask Matt, but he's on vacation...
> > &
;generated file, do not edit" warning.
Signed-off-by: Dylan Baker
v2: - Provide the python file with the csvfile and output location as
arguments (Jason, Emil)
- Put the mako template in the python file (Jason)
- Merge Emil's Android.mk changes
---
src/
;generated file, do not edit" warning.
Cc: "12.0"
Signed-off-by: Dylan Baker
Reviewed-by: Jason Ekstrand
Reviewed-by: Emil Velikov
---
I don't have commit access to Mesa, so it would be great if someone
could commit this for me.
v2: - Provide the python file with the
This fixes the following piglit tests:
spec/arb_enhanced_layouts/preprocessor/disabled-defined-core.*
Signed-off-by: Dylan Baker
---
src/compiler/glsl/glcpp/glcpp-parse.y | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y
b/src/compiler
Quoting Ian Romanick (2016-06-16 20:07:14)
> This patch is
>
> Reviewed-by: Ian Romanick
>
> On 06/16/2016 06:15 PM, Dylan Baker wrote:
> > This fixes the following piglit tests:
> > spec/arb_enhanced_layouts/preprocessor/disabled-defined-core.*
> >
Quoting Jason Ekstrand (2016-06-17 11:15:54)
>
> On Jun 17, 2016 11:07 AM, "Dylan Baker" wrote:
> >
> > Quoting Ian Romanick (2016-06-16 20:07:14)
> > > This patch is
> > >
> > > Reviewed-by: Ian Romanick
> > >
> > > On
201 - 300 of 2585 matches
Mail list logo
