Quoting Ilia Mirkin (2016-09-22 12:59:49)
> On Thu, Sep 22, 2016 at 3:56 PM, Dylan Baker wrote:
> > @@ -1305,6 +1318,7 @@ functions = [
> > "SamplerParameterfv",
> > "SamplerParameteri",
> > "SamplerParameteriv",
> >
Quoting Ilia Mirkin (2016-09-22 13:21:04)
> On Thu, Sep 22, 2016 at 4:17 PM, Dylan Baker wrote:
> > Quoting Ilia Mirkin (2016-09-22 12:59:49)
> >> On Thu, Sep 22, 2016 at 3:56 PM, Dylan Baker wrote:
> >> > @@ -1305,6 +1318,7 @@ functions = [
&
See commit 5921f372c89a68fac6ddefc009442721d9df4db2 for the rational of
this commit.
Signed-off-by: Dylan Baker
---
Changes since v2:
Re-sort the whole list, and remove duplicates, which there were several.
I've also checked that there are no duplicates by importing the li
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/static_data.py | 164 +++---
1 file changed, 82 insertions(+), 82 deletions(-)
diff --git a/src/mapi/glapi/gen/static_data.py
b/src/mapi/glapi/gen/static_data.py
index 396f941..bb11c1d 100644
--- a/src/mapi/glapi
This file currently uses a mixture of 3 and 4 space indent. I have
changed it all to 4 space indent, matching the settings in
$ROOT/.editorconfig.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/static_data.py | 2570 ++---
1 file changed, 1285 insertions
Quoting Ilia Mirkin (2016-09-22 14:37:05)
> On Thu, Sep 22, 2016 at 5:16 PM, Dylan Baker wrote:
> > See commit 5921f372c89a68fac6ddefc009442721d9df4db2 for the rational of
> > this commit.
> >
> > Signed-off-by: Dylan Baker
> > ---
> >
> > Changes
>
> > Build mesa 2241 failed
> > <https://ci.appveyor.com/project/jrfonseca-fdo/mesa/build/2241>
> >
> > Commit e66a2b879b by Dylan Baker <mailto:dy...@pnwbakers.com> on
> > 9/22/2016 6:30 PM:
> > mapi: export all GLES 3.2 functions in libGLESv
Quoting Jose Fonseca (2016-09-23 11:11:18)
> On 23/09/16 18:26, Dylan Baker wrote:
> > Quoting Jose Fonseca (2016-09-23 05:01:12)
> >> This seems to have broke Windows builds.
> >>
> >> It seems this is not only exporting symbols on GLESv2.so but everywhere.
&
bustness_share_group_isolation not started
> --
> 2.5.5
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Dylan Baker
signature.asc
Description
st it on, I've left that for someone else to wire up.
Since this requires GL 4.1, this is only available on gen8+.
Signed-off-by: Dylan Baker
---
docs/features.txt| 2 +-
docs/relnotes/12.1.0.html| 1 +
src/compiler/glsl/builtin_variables.cpp
Quoting Ilia Mirkin (2016-09-09 16:40:15)
> On Fri, Sep 9, 2016 at 7:14 PM, Dylan Baker wrote:
> > +EXT(ARB_shader_viewport_layer_array ,
> > ARB_shader_viewport_layer_array, GLL, GLC, x , x , 2015)
>
> This relies on GL 3.2 at least, so I think this sh
I like the easy way out in this case. Thanks for the pointer.
On Fri, Sep 9, 2016, at 18:03, Ilia Mirkin wrote:
> On Fri, Sep 9, 2016 at 8:59 PM, Dylan Baker wrote:
> >> Some piglit tests to check the TES behaviour would be nice.
> >
> > Yeah, I figured. I'
SET(0x0A84, bxt, "Intel(R) HD Graphics (Broxton)")
> -CHIPSET(0x1A84, bxt, "Intel(R) HD Graphics (Broxton)")
> -CHIPSET(0x1A85, bxt_2x6, "Intel(R) HD Graphics (Broxton 2x6)")
> -CHIPSET(0x5A84, bxt, "Intel(R) HD Graphics 505 (Broxton)")
> -CHIPSET(0x5A85, bxt_2x6, "Intel(R) HD Graphics 500 (Broxton 2x6)")
> --
> 2.10.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
I approve of your OCD,
Reviewed-by: Dylan Baker
signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-
> -
> -
> -
> -
> -
> -
> -
> -
> -
>
>
>
> --
> 2.9.0
>
I didn't look too closely, but your theory on why this fixes the scons build
makes sense to
Quoting Matt Turner (2016-10-26 14:06:02)
> On Wed, Oct 26, 2016 at 2:00 PM, Jason Ekstrand wrote:
> > On Oct 26, 2016 12:51 PM, "Matt Turner" wrote:
> >>
> >> ---
> >> src/intel/Makefile.genxml.am | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/src/intel/Makefi
Are you sure this is correct? Marek mentions in the referenced commit message
that these pass on softpipe, and they work on i965 and i915 just fine.
Dylan
Quoting Nicolai Hähnle (2016-11-17 13:59:26)
> From: Nicolai Hähnle
>
> This fixes the regression of radeonsi in
> glsl-1.10/execution/varia
Quoting Jason Ekstrand (2016-12-13 12:46:17)
> Hey All,
> I don't figure this will be terribly controversial (I'm about to be wrong,
> aren't I?) but how do people feel about switching our "primary" documentation
> focus, as far as we have one, to sphinx? Right now, Gallium uses sphinx for
> docum
Quoting Ian Romanick (2016-07-05 17:46:10)
> From: Ian Romanick
>
> Right now the generator generates nearly identical code. There is no
> change in the binary size.
>
>textdata bss dec hex filename
> 7529283 273096 28584 7830963 777db3 /tmp/i965_dri-64bit-before.so
> 75
Quoting Ian Romanick (2016-07-05 17:46:13)
> From: Ian Romanick
>
> If there is a way to do this cleanly in mako, I'm very interested to
> hear about it.
>
>textdata bss dec hex filename
> 7529003 273096 28584 7830683 777c9b /tmp/i965_dri-64bit-before.so
> 7528883 273096
efore running
> > into this issue? If it helps, this prints the version:
> > python <<< 'import mako; print(mako.__version__)'
>
> --
> Pali Rohár
> pali.ro...@gmail.com
> ___
> mesa-dev mailing
Quoting Ian Romanick (2016-07-19 12:25:07)
> From: Ian Romanick
>
> Signed-off-by: Ian Romanick
> ---
> src/compiler/glsl/ir_expression_operation.py | 24 +++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/src/compiler/glsl/ir_expression_operation.py
>
Quoting Ian Romanick (2016-07-19 12:24:57)
> From: Ian Romanick
>
> ldexp is weird because its two operands have different types. Add
> support for directly specifying the exact signatures of all the possible
> variations of an operation.
>
> Signed-off-by: Ian Romanick
> ---
> src/compiler/g
I didn't read over the code super closely, but all of the python looked
good and obvious minus a few nits (and they were all just nits).
For the python bits:
Acked-by: Dylan Baker
signature.asc
Description: signature
___
mesa-dev mailing list
set.
Signed-off-by: Dylan Baker
---
src/gbm/backends/dri/gbm_dri.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index 347bc99..9d9d1c4 100644
--- a/src/gbm/backends/dri/gbm_dri.c
+++ b/src/gbm/backends/dri
On Monday, July 14, 2014 03:48:58 PM Ian Romanick wrote:
> From: Ian Romanick
>
> The use of the Bloom filter rejects the vast majority of strings that
> are not in the table before expensive comparisons are performed. This
> Bloom filter uses two hashes. One is explicit (calculate_hash in the
On Monday, July 14, 2014 03:48:57 PM Ian Romanick wrote:
> From: Ian Romanick
>
> Valgrind massif results for a trimmed apitrace of dota2:
>
> ntime(i) total(B) useful-heap(B)
> extra-heap(B)stacks(B) Before (32-bit): 52 40,521,071,734
> 66,157,928
On Friday, July 18, 2014 07:41:57 AM Dylan Baker wrote:
> Currently mesa searches for two different environment variables,
> LIBGL_DRIVERS_PATH and GBM_DRIVERS_PATH. The first is used for search
> for DRI drivers in every case except GBM, and the latter is used
> exclusively for
uses
GBM_DRIVERS_PATH as a fallback if LIBGL_DRIVERS_PATH is NULL.
v2: - Use GBM_DRIVERS_PATH as a fallback
Signed-off-by: Dylan Baker
---
src/gbm/backends/dri/gbm_dri.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backend
On Thursday, July 24, 2014 09:32:38 PM Emil Velikov wrote:
> On 22/07/14 19:43, Dylan Baker wrote:
> > GBM_DRIVERS_PATH is not documented, and only used to set the location of
> > gbm drivers, while LIBGL_DRIVERS_PATH is used for everything else, and
> > is documented.
> &g
_output([opencv_test_ocl,
> '--gtest_list_tests']) +test_list = tests.splitlines()
> +group_name = ''
> +full_test_name = ''
> +for line in test_list:
> +#Test groups names start at the beginning of the l
On Friday, April 11, 2014 09:33:44 AM Carl Worth wrote:
> I'm (finally) getting around to putting together a new stable release. I
> apologize it's so late.
>
> I've just pushed about 66 patches to the 10.1 branch. This includes
> almost everything currently on master that was nominated for the st
On Friday, March 21, 2014 04:47:29 Kenneth Graunke wrote:
> This lets us distinguish MSAA resolves from other ordinary blits.
>
> Signed-off-by: Kenneth Graunke
> Cc: Dylan Baker
> Cc: Keith Packard
> Cc: Eric Anholt
> ---
> src/mesa/drivers/dri/i965/brw_blorp_blit.cp
I have a couple of comments, but they're just suggestions.
On Monday, December 15, 2014 10:12:54 PM Jason Ekstrand wrote:
> This commit builds on the nir_search.h infastructure by adds a bit of
> python code that makes it stupid easy to write an algebraic transformation
> pass. The nir_algebraic.p
On Tuesday, January 06, 2015 04:49:04 PM Jason Ekstrand wrote:
> On Tue, Jan 6, 2015 at 4:35 PM, Dylan Baker wrote:
>
> > I have a couple of comments, but they're just suggestions.
> > On Monday, December 15, 2014 10:12:54 PM Jason Ekstrand wrote:
> > > This c
Hi Conner, I have a couple of things you should change, and a suggestion
for you below, hopefully it all makes sense.
On Friday, January 16, 2015 04:46:07 PM Connor Abbott wrote:
> Before, we used a system where a file, nir_opcodes.h, defined some macros that
> were included to generate the enum v
On Friday, January 16, 2015 10:18:43 PM Connor Abbott wrote:
> Hi Dylan,
>
> On Fri, Jan 16, 2015 at 7:01 PM, Dylan Baker wrote:
> > Hi Conner, I have a couple of things you should change, and a suggestion
> > for you below, hopefully it all makes sense.
> >
> >
On Saturday, January 17, 2015 01:09:45 PM Connor Abbott wrote:
> On Sat, Jan 17, 2015 at 11:42 AM, ahmad wrote:
> > hi.
> >
> > "#! /usr/bin/env python" corresponds python 3.x series for some major
> > distro (arch,fedora ...) and python 2.x for some others.
> >
> > python 2.x and python 3.x are
Quoting Axel Davy (2019-01-12 09:40:40)
> Hi,
>
> I'm not sure the promise "1 mail per pull request" is working well.
> For example, taking one recent pull request
> https://gitlab.freedesktop.org/mesa/mesa/merge_requests/105
>
> I didn't receive anything, nor
> https://lists.freedesktop.org/arch
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/113
signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Quoting Chuck Atkins (2019-01-15 11:17:43)
> I'm jumping into Meson land now and I'm trying to configure the most recent
> release, 18.3.1, to build a minimal OSMesa containing only softpipe. So I'm
> trying to make sure everything is explicitly disabled and only turning on the
> few pieces I need
Quoting Chuck Atkins (2019-01-15 11:17:43)
> I'm jumping into Meson land now and I'm trying to configure the most recent
> release, 18.3.1, to build a minimal OSMesa containing only softpipe. So I'm
> trying to make sure everything is explicitly disabled and only turning on the
> few pieces I need
Quoting Chuck Atkins (2019-01-15 11:17:43)
> I'm jumping into Meson land now and I'm trying to configure the most recent
> release, 18.3.1, to build a minimal OSMesa containing only softpipe. So I'm
> trying to make sure everything is explicitly disabled and only turning on the
> few pieces I need
Currently something like:
meson -Dgallium-drivers= -Dvulkan-drivers= -Ddri-drivers=swrast -Dosmesa=classic
-Degl=false -Dglx=disabled
will error, which is wrong.
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/115
Dylan
signature.asc
Description: signature
__
Quoting Jason Ekstrand (2019-01-15 11:57:01)
> On Tue, Jan 15, 2019 at 12:52 PM Eric Anholt wrote:
>
> Daniel Stone writes:
>
> > Hi,
> >
> > On Tue, 15 Jan 2019 at 12:21, Rob Clark wrote:
> >> On Tue, Jan 15, 2019 at 1:02 AM Tapani Pälli
> wrote:
> >> > On 1/14/19
Quoting Pierre Moreau (2019-01-16 12:30:37)
> Changes since:
> * v10:
> - Add a new flag (`--enable-opencl-spirv` for autotools, and
> `-Dopencl-spirv=true` for meson) for enabling SPIR-V support in
> clover, and never automagically enable it without that flag. (Dylan Ba
Quoting Adam Jackson (2019-01-28 09:00:13)
> On Sat, 2019-01-26 at 13:56 +0100, Patrick Steinhardt wrote:
>
> > Unfortunately, I'm not aware of any easy way to do this. The
> > problem is not due to the compiler, as the program compiles and
> > links just fine with musl libc. Instead, this is a ru
Hello list,
This email announces the mesa 19.0 release candidate 1. I'll keep this email
fairly brief since I'm already running a little late on getting this done :)
I've just had to resolve quite a few autotools issues to get the dist built.
Notable in the 19.0-rc1 branch is SWR is set to requir
Quoting Mark Janes (2019-02-01 17:20:33)
> Eero Tamminen writes:
>
> > Hi,
> >
> > On 31.1.2019 1.37, Dylan Baker wrote:
> >> This email announces the mesa 19.0 release candidate 1. I'll keep this
> >> email
> >> fairly brief sinc
Quoting Emil Velikov (2019-02-05 04:09:45)
> From: Emil Velikov
>
> Cc: Rafael Antognolli
> Cc: Jason Ekstrand
> Cc: Dylan Baker
> Fixes: 927ba12b53c ("anv/tests: Adding test for the state_pool padding.")
> Signed-off-by: Emil Velikov
> ---
> src/intel/M
Quoting Emil Velikov (2019-02-05 04:09:45)
> From: Emil Velikov
>
> Cc: Rafael Antognolli
> Cc: Jason Ekstrand
> Cc: Dylan Baker
> Fixes: 927ba12b53c ("anv/tests: Adding test for the state_pool padding.")
> Signed-off-by: Emil Velikov
> ---
> src/intel/M
Hi list,
This is the announcement for mesa 19.0.0-rc2.
It's been a pretty slow first week for 19.0, most of the fixes here are for the
tarball itself. There's also a few fixes for vc4, anv, intel shared code, radv,
radeonsi, core mesa, v3d, st/mesa, and the dri3 loader.
As always, please test an
Quoting Eero Tamminen (2019-02-04 04:41:12)
> Hi,
>
> On 2.2.2019 3.20, Mark Janes wrote:
> > Eero Tamminen writes:
> >> On 31.1.2019 1.37, Dylan Baker wrote:
> >>> This email announces the mesa 19.0 release candidate 1. I'll keep this
> >>>
, Dec 23, 2018 at 9:32 PM Ilia Mirkin > <mailto:imir...@alum.mit.edu>> wrote:
> >
> > On Wed, Dec 19, 2018 at 1:30 PM Dylan Baker > <mailto:dy...@pnwbakers.com>> wrote:
> > >
> > > Quoting Nicolai Hähnle (2018-12-18 09:37:43
Hi List,
Mesa 19.0-rc3 is now available.
Due to a bug I discovered in the script that scrapes for stable nominations
(after uploading the tarball) there is basically nothing in the -rc3 release. As
a result I'm planning to make a -rc4 tomorrow. You can see the staging/19.0
branch to see the addit
Hi List,
I've gone ahead and made a -rc4 today as I tsaid I would yesterday. This
includes all of the patches from rc3, plus a whole set of changes that should
have been in both -rc2 and -rc3.
Among the changes pulled in since rc3:
- one fix for meson
- a plethora of nouveau fixes
- fixes for ra
a96bf0ecd0 731508b988 cec6cb01e216.
>
> One piece remained though - the wayland platform. Hence the following
> would fail:
>
> meson -Dgallium-drivers=etnaviv -Ddri-drivers=''\
>-Dtools=etnaviv -Dplatforms=wayland -Dglx=disabled \
> build/
>
>
Hi List,
Hot off the press is mesa 19.0-rc5. Due to a number of still opened bugs in the
release tracker this will not be the final release, and I predict at least one
more release candidate before the final release happens.
Just an FYI, I will not be working Thursday or Friday this week, so if I
esa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
For this patch:
Reviewed-by: Dylan Baker
signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Quoting Eleni Maria Stea (2019-02-22 13:02:30)
> Calculating the scissor rectangle fields with the y flipped (0 on top)
> can generate negative values that will cause assertion failure later on
> as the scissor fields are all unsigned. We must clamp the bbox values
> again to make sure they don't e
Hi List,
Sorry for the short summary, it took me longer to get the release ready than
normal and I'm running a bit short on time.
Mesa 19.0.0-rc6 is now available for your general consumption. Lots and lots in
this release candidate, mostly Intel, AMD, and NIR changes, but with a few other
things
Quoting Jordan Justen (2019-03-01 12:16:57)
> On 2019-02-20 07:36:48, Den wrote:
> > > Given the discussion below, I think we'll make piglit a sub-project of
> > > mesa. Those who need commit access to piglit but not mesa can be
> > > added directly to the piglit project.
> >
> > Hi list.
> >
Quoting Jordan Justen (2019-03-01 12:22:18)
> I guess piglit makes very light usage of bugzilla. Would it be simpler
> to just use gitlab issues in the piglit gitlab project?
>
> -Jordan
I think we should, anecdotally it seems like there are more spam bugs against
piglit than real bugs anyway. An
Quoting Mauro Rossi (2019-03-04 01:21:05)
> Hi Tapani,
> On Mon, Mar 4, 2019 at 6:51 AM Tapani Pälli wrote:
> >
> > Hi;
> >
> > On 3/3/19 10:10 PM, Mauro Rossi wrote:
> > > Necessary to avoid building error in Android,
> > > due to 'compiler/glsl/float64_glsl.h' file not found
> > >
> > > Fixes: c
Quoting Axel Davy (2019-01-22 12:08:05)
> Fixes regression caused by
> 42d672fa6a766363e5703f119607f7c7975918aa
> st/nine: Bind src not dst in nine_context_box_upload
>
> Before that patch, for user provided textures,
> when the texture was destroyed, the safety
> check for pending uploads, which
:
st/nine: Ignore window size if error
st/nine: Ignore multisample quality level if no ms
Bas Nieuwenhuizen (1):
radv: Interpolate less aggressively.
Brian Paul (1):
mesa: fix display list corner case assertion
Dylan Baker (1):
VERSION: bump version for rc7
Eric En
Quoting Axel Davy (2019-03-06 11:27:09)
> On 06/03/2019 20:13, Dylan Baker wrote:
> > Quoting Axel Davy (2019-01-22 12:08:05)
> >> Fixes regression caused by
> >> 42d672fa6a766363e5703f119607f7c7975918aa
> >> st/nine: Bind src not dst in nine_context_box_upl
before the 19.1 release.
Dylan
shortlog:
Brian Paul (1):
svga: remove SVGA_RELOC_READ flag in SVGA3D_BindGBSurface()
Danylo Piliaiev (1):
anv: Fix destroying descriptor sets when pool gets reset
Dylan Baker (4):
cherry-ignore: Update the cherry-ignore file
VERSION:
Quoting Eric Engestrom (2019-03-17 11:33:23)
> On Saturday, 2019-03-16 20:32:46 +, Lionel Landwerlin wrote:
> > There is merge request opened about this issue :
> > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/429
> >
> > I think the deps need to be moved from src/vulkan/wsi/meson.b
Quoting Damien Lespiau (2016-02-05 15:46:51)
> On Fri, Feb 05, 2016 at 01:55:19PM -0800, Sameer Kibey wrote:
> > Updated the list-workarounds script so that it
> > can parse Mesa directory if provided. Moved the
> > common code to a separate function to allow
> > reuse for both kernel and mesa.
> >
This seems perfectly fine to me. For what it's worth:
Reviewed-by: Dylan Baker
Quoting Matt Turner (2016-02-04 17:48:00)
> The next patch adds an algebraic rule that uses the constant 0xff00ff00.
>
> Without this change, the build fails with
>
>return hex(struct.unpack
Quoting Jason Ekstrand (2016-02-08 12:04:15)
[snip]
>
>I trust Dylan on patch 4. I was just trying to ensure that we got/used a
>32-bit value.
>--Jason
>Â
I mentioned to you offline, but I think it might be worth converting
at least the opt algebraic passes to use numpy, since
org/~dbaker/mesa wip/glapi-cleanup
I do not have mesa push access.
Dylan Baker (41):
glapi: clean imports in python files
glapi: encode python files in utf-8 rather than ascii
glapi: Update copyright in python files to cover more than IBM
glapi: remove unnecessary semi-colons in python
Completely clean the imports:
- Split so that one module is imported per line
- Remove unused imports
- Group stdlib imports, then 3rd party modules, and finally local
modules
- sort alphabetically within those groups
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_XML.py | 1
They don't do anything, they're not required, and they look weird. The
only use for semi-colons in python is to put two statements in a single
line, which is quite frowned upon by the python community.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_size
All versions of python that are even worth considering for support
(2.6+) have booleans (actually, so do a lot of versions not worth
supporting), so don't use 1 and 0 for emulating them, which also helps
to clarify the code, since returning an actual value of 1 or 0 happens).
Signed-off-by:
Don't call and store a value that might not be used unless it's know
it's needed.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py
index 3
ating system that doesn't have UTF-8 support)
then that would fail.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/apiexec.py | 3 ++-
src/mapi/glapi/gen/glX_XML.py | 3 ++-
src/mapi/glapi/gen/glX_proto_common.py | 3 ++-
src/mapi/glapi/gen/glX_proto_recv.py | 3 ++-
src/
the code to only use returns when they return a real
value, or are used for early returns.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_XML.py | 7 ---
src/mapi/glapi/gen/glX_proto_recv.py | 13 -
src/mapi/glapi/gen/glX_proto_send.py | 19 ---
-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py
index 9298995..b7178d6 100644
--- a/src/mapi/glapi/gen/gl_XML.py
+++ b/src/mapi/glapi/gen/gl_XML.py
This method (and it's sibling has_* methods) are deprecated in favor of
the 'item in container' syntax. There are countless advantages to this
for python, but for us this is necessary to get python 3 support.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_XML.py
, True, and
False) should always by done with 'is', basically everything else should
always be done with '=='.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_XML.py | 2 +-
src/mapi/glapi/gen/glX_proto_send.py | 8
src/mapi/glapi/gen/glX_proto_size
In python 2 range returns a new list, which is okay for very small
values, but can get quite expensive for larger lists. xrange on the
other hand is an iterator, which requires less memory and processing
power.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_size.py | 2 +-
src
Python's range and xrange functions start at 0 by default anyway, so
don't bother setting it explicitly to 0.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_size.py | 2 +-
src/mapi/glapi/gen/glX_server_table.py | 4 ++--
src/mapi/glapi/gen/gl_XML.py
Use the max function and a generator expression instead of a loop and
if. This is certainly no less efficient, and saves several lines of
code.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/mapi/glapi/gen
RuntimeError is a very specific type of error. In almost very case it's
being raised where an assert is the right choice, and in the rest using
a plain Exception is better, at least there it's obvious it's not that
the python runtime hit an internal error and died.
Signed-off-
One line if statements (if foo: break) are pretty uncommon, and are not
nearly as readable as their counterparts in other languages.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_XML.py| 3 ++-
src/mapi/glapi/gen/glX_proto_send.py | 9 ++---
src/mapi/glapi/gen
Originally I planned to make it more efficient, but then realized that
it wasn't actually used anywhere, so lets just delete it.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 10 --
1 file changed, 10 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_XML.py b/src
It's a bit odd to call IBM out in particular, especially since Brian
Paul is listed as a copyright holder on chronologically before IBM.
Either way this should probably have the standard "authors and/or
copyright holders", in keeping with the standard MIT license.k
Signed-off-
s directly, but usually that's
in cases where an implementation needs to call it's parent's method.
Instead it's best to use the function or operator that the magic method
implements.
This makes the code cleaner, more idiomatic, and just a bit nicer to
read.
Signed-off-by: Dylan
level functions and
classes, 1 between methods and nested functions), This doesn't result in
huge changes in any one file, but when considering all of the python
files it's quite a few changes.
This is only whitespace changes.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/
an iterator over that list, instead using an
efficient generator to yield each item one at a time.
The resulting function is less code, commented, and should be a little
more efficient.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 20 ++--
1 file changed, 6
This uses the collections.defaultdict to remove the need to check and
add an empty dict, since defaultdict will call the default factory for
us whenever a KeyError would be raised (by a missing key value).
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 11 ---
1 file
Use a boolean instead of 0 or 1, and use an assert rather than a runtime
error.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py
index 334fd6e
assert keyword. assert is a keyword in
python, it doesn't take parens, and accidentally (or purposefully to
group) will make the assert not behave in the expected way.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 2 +-
src/mapi/glapi/gen/gl_apitemp.py | 2 +-
src/mapi/glap
rather than a list.
In python tuples are mainly for heterogenous collections, especially
when position has relevance. Which makes them the right type for the
job.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
This allows large blocks of C code that is going to be printed to be
nested nicely in the python functions that print them, but still be
printed at the same level they were previously. This helps to make the
code visually more readable, and fixes syntax folding in vim.
Signed-off-by: Dylan Baker
This avoids recompiles of the re each time the function is called.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py
index a860b0d..73baef6 100644
--- a
.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/gl_XML.py | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py
index f96e44a..221bd18 100644
--- a/src/mapi/glapi/gen/gl_XML.py
+++ b/src/mapi/glapi/gen/gl_XML.py
This can easily be restored with a revert if it's ever actually needed.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_common.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mapi/glapi/gen/glX_proto_common.py
b/src/mapi/glapi/gen/glX_proto_common.py
index d1
7;t very common.
Signed-off-by: Dylan Baker
---
src/mapi/glapi/gen/glX_proto_common.py | 4 +---
src/mapi/glapi/gen/glX_proto_recv.py | 3 +--
src/mapi/glapi/gen/glX_proto_send.py | 15 +++
src/mapi/glapi/gen/glX_proto_size.py | 3 +--
src/mapi/glapi/gen/gl_XML.py |
101 - 200 of 2585 matches
Mail list logo
