Re: [Mesa-dev] [PATCH 1/6] nir/builder: Add the nir_imm_ivec3() helper

On Mon, 17 Jun 2019 06:51:15 -0700 Alyssa Rosenzweig wrote: > Reviewed-by, seems like a good idea to have the full set :) I don't intend to post a v2 of that patch since the rework proposed by Jason means we no longer call nir_imm_vec4(). If you think it's still worth applying it, feel free to p

[Mesa-dev] [PATCH v2 1/2] nir/lower_tex: Actually report when projector lowering happened

The code considers that projector lowering was done even if it's not really the case. Change the project_src() prototype to return a bool encoding whether projector lowering happened or not and update the progress var accordingly in nir_lower_tex_block(). Signed-off-by: Boris Brezillon Reviewed-b

[Mesa-dev] [PATCH v2 2/2] nir/lower_tex: Update ->sampler_dim value before calling get_texture_size()

get_texture_size() will create a txs instruction with ->sampler_dim set to the original tex->sampler_dim. The condition to call lower_rect() only checks the value of ->sampler_dim and whether lower_rect is requested or not. This leads to an infinite loop when calling nir_lower_tex() with the same o

[Mesa-dev] [PATCH v2 4/5] panfrost: Prepare things to support non-native texture ops

We are about to add support for the TXS (texture size) op which is not implemented using a midgard texture instruction. Let's rename emit_tex() into emit_texop_native() and repurpose emit_tex() as a dispatcher. Signed-off-by: Boris Brezillon --- Changes in v2: * New patch --- .../panfrost/midgar

[Mesa-dev] [PATCH v2 1/5] nir/lower_tex: Add a way to lower TXS(non-0-LOD) instructions

The V3D driver has an open-coded solution for this, and we need the same thing for Panfrost, so let's add a generic way to lower TXS(LOD) into max(TXS(0) >> LOD, 1). Signed-off-by: Boris Brezillon --- Changes in v2: * Use == 0 instead of ! * Rework the minification logic as suggested by Jason * A

[Mesa-dev] [PATCH v2 0/5] panfrost: Add support for TXS instructions

Hello, TXS is needed to support the OpenGL textureSize() function but not only. TXS instructions are also used by nir_lower_tex() to lower a RECT texture sampling into a 2D one, which I wanted to have working to test gallium-hud on panfrost. Note that I decided to add a new generic lowering step

[Mesa-dev] [PATCH v2 5/5] panfrost: Add support for TXS instructions

This patch adds support for nir_texop_txs instructions which are needed to support the OpenGL textureSize() function. This is also needed to support RECT texture sampling which is currently lowered to 2D sampling + a TXS() instruction by the nir_lower_tex() helper. Signed-off-by: Boris Brezillon

[Mesa-dev] [PATCH v2 2/5] panfrost: Make the sysval logic more generic

We are about to add support for nir_texop_txs which requires adding a sysval/uniform containing the texture size. Let's change the emit_sysval_read() prototype to take a nir_instr object instead of a nir_intrinsic_instr one so we can re-use this function when emitting a sysval for a txs instruction

[Mesa-dev] [PATCH v2 3/5] panfrost: Move sysval upload logic out of panfrost_emit_for_draw()

We're about to add more sysval types, and panfrost_emit_for_draw() is big enough, so let's move the sysval upload logic in a separate function. We also add one sub-function per sysval type to keep the panfrost_upload_sysvals() small/readable. Signed-off-by: Boris Brezillon Reviewed-by: Alyssa Ro

[Mesa-dev] [PATCH] panfrost: Adapt to constant name change in UABI

We hadn't updated the kernel header after the driver got into mainline. Signed-off-by: Tomeu Vizoso --- include/drm-uapi/panfrost_drm.h| 6 -- src/gallium/drivers/panfrost/pan_drm.c | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/include/drm-uapi/panfrost_drm.h

[Mesa-dev] [PATCH 3/3] radv: do not decompress levels without DCC with the graphics path

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fast_clear.c | 35 +++ 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c index cb7b43d546c..12fea8292c0 100644 --- a/src

[Mesa-dev] [PATCH 1/3] radv: check if DCC is enabled per mip not for the whole image

In other words, make use of radv_dcc_enabled() instead of radv_image_has_dcc() all over the places. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 22 +- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_meta_clear.c | 4 ++--

[Mesa-dev] [PATCH 2/3] radv: do not decompress levels without DCC with the compute path

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fast_clear.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c index 6e5fee552b0..cb7b43d546c 100644 --- a/src/amd/vulkan/radv_meta_fast_clear.c +++ b/

Re: [Mesa-dev] [PATCH 3/3] radv: do not decompress levels without DCC with the graphics path

R-b for the series On Tue, Jun 18, 2019, 10:27 AM Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 35 +++ > 1 file changed, 20 insertions(+), 15 deletions(-) > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c >

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 Bug ID: 110939 Summary: src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared Product: Mesa Version: 19.0

[Mesa-dev] [PATCH] radv: adjust the DCC base VA for mipmapped color attachments

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 1424eaef21d..1d59aaa0b03 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -4322

[Mesa-dev] [PATCH] radv: fix color decompressions for FMASK/CMASK

Only skip levels without DCC when it's a DCC decompression. Whoops. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fast_clear.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c index

Re: [Mesa-dev] [PATCH] radeonsi: reduce MAX_GEOMETRY_OUTPUT_VERTICES

On Fri, 2019-06-14 at 19:00 -0400, Marek Olšák wrote: > From: Nicolai Hähnle > > This fixes piglit spec@glsl-1.50@gs-max-output. > --- Does it make sense to nominate this for stable? J.A. > src/gallium/drivers/radeonsi/si_get.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(

Re: [Mesa-dev] [PATCH] radv: fix color decompressions for FMASK/CMASK

Reviewed-by: Bas Nieuwenhuizen On Tue, Jun 18, 2019 at 11:58 AM Samuel Pitoiset wrote: > > Only skip levels without DCC when it's a DCC decompression. > Whoops. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deleti

Re: [Mesa-dev] [PATCH] radv: adjust the DCC base VA for mipmapped color attachments

Reviewed-by: Bas Nieuwenhuizen On Tue, Jun 18, 2019 at 11:48 AM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > index 1424e

Re: [Mesa-dev] [PATCH] radv: make sure to init the DCC decompress compute path state

On Thu, 2019-06-13 at 12:44 +0200, Samuel Pitoiset wrote: > This fixes a segfault when forcing DCC decompressions on compute > because internal meta objects are not created since the on-demand > stuff. > Does it make sense to nominate this to stable? J.A. > Signed-off-by: Samuel Pitoise

Re: [Mesa-dev] [PATCH] radv: make sure to init the DCC decompress compute path state

On 6/18/19 12:05 PM, Juan A. Suarez Romero wrote: On Thu, 2019-06-13 at 12:44 +0200, Samuel Pitoiset wrote: This fixes a segfault when forcing DCC decompressions on compute because internal meta objects are not created since the on-demand stuff. Does it make sense to nominate this to stable?

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #1 from Tapani Pälli --- Can you include also information how did you configure the meson build? I think you should get this to work by at least having one platform defined, as example by setting "-Dplatforms=x11". -- You are recei

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #2 from Rolf Eike Beer --- meson --cross-file /opt/emlix/master/etc/meson-cross-file.txt --buildtype debugoptimized --prefix=/usr --sysconfdir=/etc -Ddri-drivers=swrast -Dgallium-drivers= -Dllvm=false -Dopengl=true -Dplatforms=,drm,x

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: make sure to init the DCC decompress compute path state

On Tue, 2019-06-18 at 12:12 +0200, Samuel Pitoiset wrote: > On 6/18/19 12:05 PM, Juan A. Suarez Romero wrote: > > On Thu, 2019-06-13 at 12:44 +0200, Samuel Pitoiset wrote: > > > This fixes a segfault when forcing DCC decompressions on compute > > > because internal meta objects are not created sinc

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #4 from Rolf Eike Beer --- It happens because of the leading ',' in platforms, which did not create a problem until now. I still think this should be caught instead of generating an invalid setup. -- You are receiving this mail bec

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #3 from Tapani Pälli --- Right, it's the empty option given there: "-Dplatforms=,drm,x11", remove the first ',' and that should fix your issue. -- You are receiving this mail because: You are the assignee for the bug. You are the Q

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #5 from Tapani Pälli --- (In reply to Rolf Eike Beer from comment #4) > It happens because of the leading ',' in platforms, which did not create a > problem until now. I still think this should be caught instead of generating > an in

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #6 from Rolf Eike Beer --- It was the result of an automatic selection step that went slightly wrong, i.e. it was a variable containing " x11 drm" and the replaced all spaces with ',' without trimming first. -- You are receiving th

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #7 from Tapani Pälli --- Why it does not error is that platforms list 'choices' includes empty string '' (meson_options.txt), I'm not sure if there's a good reason for that. We could alternatively remove the '' from choices or add ex

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #8 from Tapani Pälli --- Created attachment 144586 --> https://bugs.freedesktop.org/attachment.cgi?id=144586&action=edit add check for empty egl_platform Here's a fix proposal. -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #9 from Rolf Eike Beer --- Comment on attachment 144586 --> https://bugs.freedesktop.org/attachment.cgi?id=144586 add check for empty egl_platform LGTM -- You are receiving this mail because: You are the assignee for the bug. Yo

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #10 from Rolf Eike Beer --- I wonder if the check should not be the other way round: it should check that the default platform is in a list of platforms known to work, that way it would also catch typos that could lead to equally str

[Mesa-dev] [Bug 110939] src/egl/main/egldisplay.c: In function '_eglGetNativePlatform': error: '_EGL_PLATFORM_' undeclared

https://bugs.freedesktop.org/show_bug.cgi?id=110939 --- Comment #11 from Tapani Pälli --- (In reply to Rolf Eike Beer from comment #10) > I wonder if the check should not be the other way round: it should check > that the default platform is in a list of platforms known to work, that way > it wou

Re: [Mesa-dev] [PATCH] egl: Don't add hardware device if there is no render node v2.

On Mon, 17 Jun 2019 at 19:16, Ilia Mirkin wrote: > > On Mon, Jun 17, 2019 at 6:37 AM wrote: > > > > From: Mathias Fröhlich > > > > > > Emil, > > > > that one probably matches your original intent then. > > > > please review > > Thanks > > > > Mathias > > > > > > Do not offer a hardware drm backe

[Mesa-dev] [PATCH] panfrost: ci: Update results

Alyssa fixed some failing tests last night. Signed-off-by: Tomeu Vizoso --- .../drivers/panfrost/ci/expected-failures.txt | 15 --- 1 file changed, 15 deletions(-) diff --git a/src/gallium/drivers/panfrost/ci/expected-failures.txt b/src/gallium/drivers/panfrost/ci/expected-fail

Re: [Mesa-dev] [PATCH] panfrost: Adapt to constant name change in UABI

Reviewed-by: Alyssa Rosenzweig , thank you! signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] panfrost: ci: Update results

Not sure what would have fixed any of these but sure, A-b, I won't say no to fixed tests ^_^ What about the fragment_ops.scissor.* tests? signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.fr

[Mesa-dev] [PATCH] ac, radeonsi: Always mark buffer stores as inaccessiblememonly

inaccessiblememonly means that it doesn't modify memory accesible via normal LLVM pointers. This lets LLVM's dead store elimination, memcpy forwarding, etc. ignore functions with this attribute. We don't represent descriptors as pointers, so this property is always true of buffer and image stores.

Re: [Mesa-dev] [PATCH] panfrost: ci: Update results

On Tue, 18 Jun 2019 at 15:19, Alyssa Rosenzweig wrote: > > Not sure what would have fixed any of these but sure, A-b, I won't say > no to fixed tests ^_^ > > What about the fragment_ops.scissor.* tests? Don't know, what about them? They seem to pass. Cheers, Tomeu __

Re: [Mesa-dev] [PATCH] panfrost: ci: Update results

> Don't know, what about them? They seem to pass. There were a few that were failing before and have now been fixe-- oh wait, I remember to update the expectations myself. Never mind! :) signature.asc Description: PGP signature ___ mesa-dev mailing lis

[Mesa-dev] [PATCH] panfrost: Move to use ralloc for some allocations

We have some serious leaks, so plug some and also move to ralloc to limit the lifetime of some objects to that of their parent. Lots more such work to do. Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_context.c | 24 +++-- src/gallium/drivers/panfrost/pan_drm.c

Re: [Mesa-dev] [PATCH] panfrost: Move to use ralloc for some allocations

Woah :) I'm okay with this if CI is. I recall having issues when I tried this but maybe I'm just bad at memory. Actually, maybe I don't recall issues. Did I even try this? Like I said. Bad at memory. R-b, thank you ^^ signature.asc Description: PGP signature __

[Mesa-dev] [PATCH] radv: fix FMASK expand with SRGB formats

Found while working on DCC for MSAA. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fmask_expand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta_fmask_expand.c b/src/amd/vulkan/radv_meta_fmask_expand.c index a9567eaf0fd..e5d0868aab5

[Mesa-dev] [PATCH 1/6] radv: initialize levels without DCC during layout transitions

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index a26bf6c6a67..ebeee2c3723 100644 --- a/src/amd/vulkan/r

[Mesa-dev] [PATCH 2/6] radv: re-initialize DCC metadata after decompressing using compute

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fast_clear.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c index 4398cb7ca59..73642d5d6f3 100644 --- a/src/amd/vulkan/radv_meta_fa

[Mesa-dev] [PATCH 6/6] radv: enable DCC for mipmapped color textures on GFX8

It's tricky on GFX9, so only GFX8 for now. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 98df24d3546..3e5e4c01967 100644 --- a/src/amd/vul

[Mesa-dev] [PATCH 5/6] radv: do not fast clears if one level can't be fast cleared

And fallback to slow color clears. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index 7f8f69e10f6..ed7f19b1dce 100644 --- a/src/amd/vulka

[Mesa-dev] [PATCH 3/6] radv: add radv_dcc_clear_level() helper

For clearing only one level. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.h | 3 +++ src/amd/vulkan/radv_meta_clear.c | 23 --- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_meta.h b/src/amd/vulkan/radv_meta.h index

[Mesa-dev] [PATCH 4/6] radv: add fast clears support for mipmapped color images with DCC

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_clear.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index 49f572c6889..7f8f69e10f6 100644 --- a/src/amd/vulkan/radv_meta_clear.c +++

Re: [Mesa-dev] [PATCH v2 1/5] nir/lower_tex: Add a way to lower TXS(non-0-LOD) instructions

On Tue, Jun 18, 2019 at 2:38 AM Boris Brezillon < boris.brezil...@collabora.com> wrote: > The V3D driver has an open-coded solution for this, and we need the > same thing for Panfrost, so let's add a generic way to lower TXS(LOD) > into max(TXS(0) >> LOD, 1). > > Signed-off-by: Boris Brezillon >

[Mesa-dev] [PATCH 0/9] panfrost: Initial sRGB support

This series adds new flags and formats relevant to sRGB textures and framebuffers, which cause quite a bit of refactoring. One 'hidden gem' here is support for rendering to Mali's uncompressed tiled format (Utgard-style tiling). I suppose earning those magic bits is a tradeoff for not getting AFBC

[Mesa-dev] [PATCH 1/9] panfrost: Refactor texture targets

This combines the two cmdstream bits "is_3d" and "is_not_cubemap" into a single 2-bit texture target selection, noticing it's the same as the 2-bit selection in Midgard and Bifrost texturing ops. Accordingly, we share this definition and add the missing entry for 1D/buffer textures. This requires

[Mesa-dev] [PATCH 3/9] panfrost: Implement tiled rendering

We already can sample from Mali's linear/tiled encoding (the one from Utgard -- AFBC is mostly unrelated); let's be able to render to it as well. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_mfbd.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drive

[Mesa-dev] [PATCH 4/9] panfrost: Add sRGB render target flag

Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/include/panfrost-job.h | 1 + src/gallium/drivers/panfrost/pandecode/decode.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/drivers/panfrost/include/panfrost-job.h b/src/gallium/drivers/panfrost/include/pan

[Mesa-dev] [PATCH 8/9] panfrost: Disable AFBC on sRGB buffers

The performance impact is slightly mitigated by tiling the render target, but it's undeniably still slow compared to AFBC. Unfortunately, it doesn't look like AFBC and sRGB play nice... Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_afbc.c | 7 +++ 1 file changed, 7 in

[Mesa-dev] [PATCH 5/9] panfrost: Implement sRGB texturing

Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c index 4d9705671bd..5dac0820920 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 9/9] panfrost: Enable sRGB

Now that sRGB formats are supported for both rendering and sampling, advertise support. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_screen.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_screen.c b/src/gallium/drivers/panfrost/

[Mesa-dev] [PATCH 6/9] panfrost: Specify sRGB in the render target

Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_mfbd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_mfbd.c b/src/gallium/drivers/panfrost/pan_mfbd.c index f9a69e47e45..c082d0b91a3 100644 --- a/src/gallium/drivers/p

[Mesa-dev] [PATCH 2/9] panfrost: Decode rendering block type

A mode for rendering tiled/uncompressed was noticed, so we reshuffle the MFBD render target definitions to explicitly include block type. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/include/panfrost-job.h | 14 +--- src/gallium/drivers/panfrost/pan_mfbd.c | 8 -

[Mesa-dev] [PATCH 7/9] panfrost: Enable sRGB fixed-function blending

For fixed-function, we have hardware to handle sRGB so we just set a flag. For blend shaders, it's rather more involved; this is currently unimplemented. Assert it out for now; we don't need it quite yet. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/include/panfrost-job.h|

[Mesa-dev] [PATCH 0/3] panfrost/midgard: Pack constant bias/lod

Midgard texture ops taking bias/LOD(/offset) have both immediate and register modes, depending on whether the argument is constant or not. Rather than always using register mode and emitting dumb modes all over the place, support packing constant bias/LOD. Alyssa Rosenzweig (3): panfrost/midgard

[Mesa-dev] [PATCH 2/3] panfrost/midgard: Add helper to encode constant bias

Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 34 +++ 1 file changed, 34 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index 1cc551b603c..951457e27

[Mesa-dev] [PATCH 1/3] panfrost/midgard: Handle negative immediate bias

Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/disassemble.c | 7 --- src/gallium/drivers/panfrost/midgard/midgard.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/disassemble.c b/src/gallium/drivers/

[Mesa-dev] [PATCH 3/3] panfrost/midgard: Reorder to permit constant bias

Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 97 +-- 1 file changed, 48 insertions(+), 49 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index 95145

Re: [Mesa-dev] [PATCH] ac, radeonsi: Always mark buffer stores as inaccessiblememonly

Makes sense to me. Acked-by: Nicolai Hähnle -Original Message- From: Connor Abbott Sent: Dienstag, 18. Juni 2019 15:21 To: mesa-dev@lists.freedesktop.org Cc: Marek Olšák ; Haehnle, Nicolai ; Connor Abbott Subject: [PATCH] ac,radeonsi: Always mark buffer stores as inaccessiblememonly

[Mesa-dev] [PATCH] radv: disable viewport clamping even if FS doesn't write Z

This fixes new CTS dEQP-VK.pipeline.depth_range_unrestricted.*. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 8bc0d9b53e6..765f6105f7d 1

Re: [Mesa-dev] [PATCH] ac, radeonsi: Always mark buffer stores as inaccessiblememonly

Reviewed-by: Marek Olšák Marek On Tue, Jun 18, 2019 at 12:20 PM Haehnle, Nicolai wrote: > Makes sense to me. > > Acked-by: Nicolai Hähnle > > -Original Message- > From: Connor Abbott > Sent: Dienstag, 18. Juni 2019 15:21 > To: mesa-dev@lists.freedesktop.org > Cc: Marek Olšák ; Haehnl

[Mesa-dev] [PATCH] panfrost: Skip shading unaffected tiles

Looking at the scissor, we can discard some tiles. We specifially don't care about the scissor on the wallpaper, since that's a no-op if the entire tile is culled. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 9 + src/gallium/drivers/panfrost/pan_co

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: reduce MAX_GEOMETRY_OUTPUT_VERTICES

It's not needed in stable. This is a corner case for piglit. Marek On Tue, Jun 18, 2019 at 6:03 AM Juan A. Suarez Romero wrote: > On Fri, 2019-06-14 at 19:00 -0400, Marek Olšák wrote: > > From: Nicolai Hähnle > > > > This fixes piglit spec@glsl-1.50@gs-max-output. > > --- > > > Does it make se

[Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

From: Dave Airlie This is pointless in that we won't ever hit those paths in real life, but coverity complains. Fixes: f014ae3c7cce ("nouveau: add support for nir") --- src/gallium/drivers/nouveau/nv50/nv50_program.c | 1 + src/gallium/drivers/nouveau/nv50/nv50_state.c | 2 ++ src/gallium/dri

Re: [Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

ohh, nvm... I already know... On Tue, Jun 18, 2019 at 11:18 PM Karol Herbst wrote: > > On Tue, Jun 18, 2019 at 11:14 PM Dave Airlie wrote: > > > > From: Dave Airlie > > > > This is pointless in that we won't ever hit those paths in real life, > > but coverity complains. > > > > what does it act

Re: [Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

On Tue, Jun 18, 2019 at 11:14 PM Dave Airlie wrote: > > From: Dave Airlie > > This is pointless in that we won't ever hit those paths in real life, > but coverity complains. > what does it actually complain about? > Fixes: f014ae3c7cce ("nouveau: add support for nir") > --- > src/gallium/drive

[Mesa-dev] [PATCH] radeonsi: fix undefined shift in macro definition

From: Dave Airlie Pointed out by coverity --- src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c b/src/gallium/drivers/radeonsi/si_perfcounter.c index ad7f1eb3d99..75bd61730da 100644 ---

Re: [Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

Reviewed-by: Ilia Mirkin On Tue, Jun 18, 2019 at 5:14 PM Dave Airlie wrote: > > From: Dave Airlie > > This is pointless in that we won't ever hit those paths in real life, > but coverity complains. > > Fixes: f014ae3c7cce ("nouveau: add support for nir") > --- > src/gallium/drivers/nouveau/nv5

Re: [Mesa-dev] [PATCH] radeonsi: fix undefined shift in macro definition

Reviewed-by: Bas Nieuwenhuizen On Tue, Jun 18, 2019 at 11:20 PM Dave Airlie wrote: > > From: Dave Airlie > > Pointed out by coverity > --- > src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_pe

[Mesa-dev] [Bug 110884] can't start GDM when building mesa master branch with LTO

https://bugs.freedesktop.org/show_bug.cgi?id=110884 Marcos Simental changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

Re: [Mesa-dev] [PATCH] radv: fix FMASK expand with SRGB formats

r-b Fixes tag? On Tue, Jun 18, 2019 at 4:07 PM Samuel Pitoiset wrote: > > Found while working on DCC for MSAA. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fmask_expand.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_meta_

Re: [Mesa-dev] [PATCH 2/6] radv: re-initialize DCC metadata after decompressing using compute

r-b On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_fast_clear.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c > b/src/amd/vulkan/radv_meta_fast_cle

Re: [Mesa-dev] [PATCH 3/6] radv: add radv_dcc_clear_level() helper

On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > For clearing only one level. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta.h | 3 +++ > src/amd/vulkan/radv_meta_clear.c | 23 --- > 2 files changed, 23 insertions(+), 3 deletions(-) > > d

Re: [Mesa-dev] [PATCH 4/6] radv: add fast clears support for mipmapped color images with DCC

r-b On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_clear.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_meta_clear.c > b/src/amd/vulkan/radv_meta_clear.c > i

Re: [Mesa-dev] [PATCH 6/6] radv: enable DCC for mipmapped color textures on GFX8

r-b On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > It's tricky on GFX9, so only GFX8 for now. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_image.c b/src/am

Re: [Mesa-dev] [PATCH 5/6] radv: do not fast clears if one level can't be fast cleared

On Tue, Jun 18, 2019 at 4:12 PM Samuel Pitoiset wrote: > > And fallback to slow color clears. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_clear.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/amd/vulkan/radv_meta_clear.c > b/src/amd/vulkan/

[Mesa-dev] [PATCH 1/2] nir/loop_analyze: use nir_src to track the invariant

This helps reduce the amount of abstraction in this pass and allows us to retain more information about the src such as any swizzles. Retaining the swizzle information is required for a bugfix in a following patch. Fixes: 6772a17acc8e ("nir: Add a loop analysis pass") --- src/compiler/nir/nir_loo

[Mesa-dev] [PATCH 2/2] nir/loop_analyze: handle swizzles on invariant

Fixes: 6772a17acc8e ("nir: Add a loop analysis pass") --- src/compiler/nir/nir_loop_analyze.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_loop_analyze.c b/src/compiler/nir/nir_loop_analyze.c index ff73b32c51d..e85a404da1b 100644 --- a/src/compiler

Re: [Mesa-dev] [PATCH] egl: Don't add hardware device if there is no render node v2.

On Monday, 17 June 2019 19:33:26 CEST Emil Velikov wrote: > On 2019/06/17, mathias.froehl...@gmx.net wrote: > > From: Mathias Fröhlich > > > > > > Emil, > > > > that one probably matches your original intent then. > > > > please review > > Thanks > > > > Mathias > > > > > > Do not offer a h

Re: [Mesa-dev] [PATCH 2/2] panfrost/midgard: Enable autovectorization

Hi there, this patch seems to have caused the following regressions: +dEQP-GLES2.functional.shaders.conversions.vector_combine.bvec2_float_to_bvec3_fragment +dEQP-GLES2.functional.shaders.conversions.vector_combine.float_bool_to_bvec2_fragment +dEQP-GLES2.functional.shaders.conversions.vector_com

Re: [Mesa-dev] [PATCH 9/9] panfrost: Enable sRGB

On Tue, 18 Jun 2019 at 17:00, Alyssa Rosenzweig wrote: > > Now that sRGB formats are supported for both rendering and sampling, > advertise support. > > Signed-off-by: Alyssa Rosenzweig Hi there, this patch seems to have caused the following regressions: dEQP-GLES2.functional.fbo.render.recrea

Re: [Mesa-dev] [PATCH] android: virgl: fix libmesa_virgil_common build and dependencies

On 6/15/19 8:42 AM, Mauro Rossi wrote: Hi, there is a typo in the commit title, the library is libmesa_winsys_virgl_common I will correct it in the final commit Reviewed-by: Tapani Pälli Mauro On Sat, Jun 15, 2019 at 7:39 AM Mauro Rossi > wrote: Fixes