[Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush (v2)

2018-12-14 Thread Tomasz Figa
If there is no last fence, due to no rendering happening yet, just create a new signaled fence and return it, to match the expectations of the EGL sync fence API. Fixes random "Could not create sync fence 0x3003" assertion failures from Skia on Android, coming from the following code: https://and

Re: [Mesa-dev] [PATCH v2 09/29] nir: Make boolean conversions sized just like the others

2018-12-14 Thread Iago Toral
On Thu, 2018-12-13 at 07:02 -0600, Jason Ekstrand wrote: > On December 13, 2018 04:07:56 Iago Toral wrote: > > > On Thu, 2018-12-06 at 13:45 -0600, Jason Ekstrand wrote: > > (...) > > > diff --git a/src/compiler/nir/nir_builder.h > > > b/src/compiler/nir/nir_builder.h > > > index 30fa1d7ec8b..e0c

Re: [Mesa-dev] [PATCH v2 3/3] i965/gen9: Add workarounds for object preemption.

2018-12-14 Thread Kenneth Graunke
On Thursday, December 13, 2018 5:00:43 PM PST Rafael Antognolli wrote: > On Wed, Oct 31, 2018 at 04:27:31PM -0700, Kenneth Graunke wrote: > > On Wednesday, October 31, 2018 11:15:28 AM PDT Rafael Antognolli wrote: > > > On Tue, Oct 30, 2018 at 04:32:54PM -0700, Kenneth Graunke wrote: > > > > On Mon

Re: [Mesa-dev] [PATCH] genxml: Consistently use a numeric "MOCS" field

2018-12-14 Thread Kenneth Graunke
On Wednesday, December 12, 2018 9:09:54 AM PST Jason Ekstrand wrote: > On Tue, Dec 11, 2018 at 10:31 PM Kenneth Graunke > wrote: > > > When we first started using genxml, we decided to represent MOCS as an > > actual structure, and pack values. However, in many places, it was more > > convenient

Re: [Mesa-dev] [PATCH 1/2] ac: refactor visit_load_buffer

2018-12-14 Thread Samuel Pitoiset
On 12/13/18 6:06 PM, Rhys Perry wrote: This is so that we can split different types of loads more easily. Signed-off-by: Rhys Perry --- src/amd/common/ac_llvm_build.c | 8 ++-- src/amd/common/ac_nir_to_llvm.c | 80 - src/compiler/nir/nir.h | 2 +

Re: [Mesa-dev] [PATCH 2/2] ac: split 16-bit ssbo loads that may not be dword aligned

2018-12-14 Thread Samuel Pitoiset
See my comment on the first patch. Anyways, series is: Reviewed-by: Samuel Pitoiset On 12/13/18 6:06 PM, Rhys Perry wrote: Fixes: 7e7ee826982 ('ac: add support for 16bit buffer loads') Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108114 Signed-off-by: Rhys Perry --- src/amd/common

Re: [Mesa-dev] [PATCH] genxml: Consistently use a numeric "MOCS" field

2018-12-14 Thread Kenneth Graunke
On Wednesday, December 12, 2018 9:17:38 AM PST Jason Ekstrand wrote: > On Wed, Dec 12, 2018 at 11:09 AM Jason Ekstrand > wrote: > > > On Tue, Dec 11, 2018 at 10:31 PM Kenneth Graunke > > wrote: > > > >> When we first started using genxml, we decided to represent MOCS as an > >> actual structure,

[Mesa-dev] [PATCH] radv: report Vulkan version 1.1.90 for real

2018-12-14 Thread Samuel Pitoiset
I thought the value was correctly propagated, but actually not. Fixes: 2ac6d55f38c ("radv: bump reported version to 1.1.90") Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_extensions.py

Re: [Mesa-dev] [PATCH] etnaviv: drop redundant ctx function parameter

2018-12-14 Thread Lucas Stach
Am Mittwoch, den 12.12.2018, 14:45 +0100 schrieb Christian Gmeiner: > There is no need to have an extra ctx paramter as all the other > parameters carry all the needed information. > > Signed-off-by: Christian Gmeiner Reviewed-by: Lucas Stach > --- >  src/gallium/drivers/etnaviv/etnaviv_shader

Re: [Mesa-dev] [PATCH v6 0/8] Add and enable extension EXT_sRGB_write_control

2018-12-14 Thread Gert Wollny
Am Donnerstag, den 13.12.2018, 22:20 +0100 schrieb Erik Faye-Lund: > On Thu, 2018-11-15 at 13:45 +0100, Gert Wollny wrote: > > From: Gert Wollny > > > > Dear all, > > > > after the RFC and Ilias comments I reworked the series another > > time. > > Changes with respect to the RFC are > > -

Re: [Mesa-dev] [PATCH 41/59] intel/compiler: split is_partial_write() into two variants

2018-12-14 Thread Pohjolainen, Topi
On Fri, Dec 14, 2018 at 08:47:23AM +0100, Iago Toral wrote: > On Thu, 2018-12-13 at 12:49 +0200, Pohjolainen, Topi wrote: > > On Thu, Dec 13, 2018 at 09:10:24AM +0100, Iago Toral wrote: > > > On Wed, 2018-12-12 at 14:15 +0200, Pohjolainen, Topi wrote: > > > > On Wed, Dec 12, 2018 at 09:48:20AM +010

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-14 Thread Erik Faye-Lund
On Thu, 2018-12-13 at 10:46 -0800, Eric Anholt wrote: > Dylan Baker writes: > > > [ Unknown signature status ] > > In the autotools discussion I've come to realize that we also need > > to talk about > > the -DDEBUG guard. It seems that there are two different uses, and > > thus two > > different

Re: [Mesa-dev] [RFC PATCH 5/5] meson: libfreedreno depends upon libdrm (for fence support)

2018-12-14 Thread Juan A. Suarez Romero
On Wed, 2018-12-12 at 09:03 -0800, Dylan Baker wrote: > Thanks for looking into these. I've gone ahead and added the Fixes and Emil's > rb, > plus my rb and pushed *this* patch to master. I've pulled all of the others > except the "delete me" fixup into my branch (since I'll drop that patch before

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-14 Thread Erik Faye-Lund
On Thu, 2018-12-13 at 18:07 +0100, Axel Davy wrote: > On 13/12/2018 17:57, Mathias Fröhlich wrote: > > Hi, > > Initially it seemed to me that I am about the only one sticking > > with mailing lists. > > And I personally feel like a too small contributor to really try to > > influence your > > decis

[Mesa-dev] [Bug 108275] Breaking out of loop creates broken code on RADV

2018-12-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108275 --- Comment #10 from Samuel Pitoiset --- Can you try latest master? Apparently, https://cgit.freedesktop.org/mesa/mesa/commit/?id=5921a19d4b0c6491b3535b5154d585384c9ea144 fixes the problem for some reasons. I wonder if LLVM was confused with th

Re: [Mesa-dev] [RFC PATCH 5/5] meson: libfreedreno depends upon libdrm (for fence support)

2018-12-14 Thread Emil Velikov
On Fri, 14 Dec 2018 at 11:05, Juan A. Suarez Romero wrote: > > On Wed, 2018-12-12 at 09:03 -0800, Dylan Baker wrote: > > Thanks for looking into these. I've gone ahead and added the Fixes and > > Emil's rb, > > plus my rb and pushed *this* patch to master. I've pulled all of the others > > except

Re: [Mesa-dev] [PATCH] spirv/nir: adjust location assignment for the case of arrays of blocks

2018-12-14 Thread apinheiro
On 14/12/18 0:54, Timothy Arceri wrote: > > > On 13/12/18 11:11 pm, Alejandro Piñeiro wrote: >> This is needed due how the types get rearranged after the struct >> splitting. >> >> So for example, this array of blocks: >> >>    layout(location = 0) out block { >> vec4 v; >> vec3 v2; >>   

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-14 Thread Erik Faye-Lund
On Thu, 2018-12-13 at 21:27 +0100, Gert Wollny wrote: > IMHO allowing MRs is a good thing, so > Acked-by: Gert Wollny > > I've added a little remark below. > > Best, > Gert > > Am Mittwoch, den 05.12.2018, 15:32 -0800 schrieb Jordan Justen: > > +You should periodically check to see i

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-14 Thread Juan A. Suarez Romero
On Tue, 2018-12-11 at 15:29 +0100, Erik Faye-Lund wrote: > On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote: > > Virglrenderer does the wrong thing when given an instance divisor; > > it tries to use the element-index rather than the binding-index as > > the argument to glVertexBindingDiviso

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-14 Thread Samuel Pitoiset
On 12/13/18 9:27 PM, Gert Wollny wrote: IMHO allowing MRs is a good thing, so Acked-by: Gert Wollny Allowing MRs isn't a bad thing. The main problem IMHO is that now we have to look at both emails and MRs, and I think we are probably going to miss interesting/important changes. I've

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Gert Wollny
Am Montag, den 10.12.2018, 15:10 -0800 schrieb Dylan Baker: > Meson 0.49.0 has been out for a couple of days now, and I'd like to > make the final call for autotools. My patch is so massive that it's a > huge pain to send to the list, the latest versions is here: > https://gitlab.freedesktop.org/db

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-14 Thread Erik Faye-Lund
Sounds perfect, thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v5] anv/android: add GetAndroidHardwareBufferPropertiesANDROID

2018-12-14 Thread Tapani Pälli
Use the anv_format address in formats table as implementation-defined external format identifier for now. When adding YUV format support this might need to change. v2: code cleanup (Jason) v3: set anv_format address as identifier v4: setup suggestedYcbcrModel and suggested[X|Y]ChromaOffset as

Re: [Mesa-dev] [PATCH 10/15] anv/android: support creating images from external format

2018-12-14 Thread Tapani Pälli
On 12/11/18 3:27 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: Since we don't know the exact format at creation time, some initialization is done only when bound with memory in vkBindImageMemory. v2: demand dedicated allocation in vkGetImageMemoryRequirements2 if

[Mesa-dev] [PATCH v3] anv: support VkExternalFormatANDROID in vkCreateSamplerYcbcrConversion

2018-12-14 Thread Tapani Pälli
If external format is used, we store the external format identifier in conversion to be used later when creating VkImageView. v2: rebase to b43f955037c changes v3: added assert, ignore components when creating external format conversion (Lionel) Signed-off-by: Tapani Pälli --- src/intel/vul

Re: [Mesa-dev] [PATCH 13/15] anv: support VkSamplerYcbcrConversionInfo in vkCreateImageView

2018-12-14 Thread Tapani Pälli
On 12/11/18 3:48 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: If a conversion struct was passed, then initialize view using format from the conversion structure. v2: use vk_format directly from the anv_format struct Signed-off-by: Tapani Pälli One suggestion : R

Re: [Mesa-dev] [PATCH 15/15] anv/android: turn on VK_ANDROID_external_memory_android_hardware_buffer

2018-12-14 Thread Tapani Pälli
On 12/11/18 4:33 PM, Lionel Landwerlin wrote: On 27/11/2018 10:53, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin Thanks a lot! I've applied all changes you proposed and sent new versions on the ones where r-b was not given. I also pushed a new branch w

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Gert Wollny
Am Freitag, den 14.12.2018, 01:19 -0500 schrieb Ilia Mirkin: > I have to say that the user experience for autotools is WAY better > than for meson. As a concrete example, I had a meson build. Then I > updated meson (0.48.1 to 0.48.2). Now ninja -C foo doesn't work. > meson > --reconfigure (which pr

[Mesa-dev] [Bug 108275] Breaking out of loop creates broken code on RADV

2018-12-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108275 --- Comment #11 from Timothy Arceri --- (In reply to Samuel Pitoiset from comment #10) > Can you try latest master? Apparently, > https://cgit.freedesktop.org/mesa/mesa/commit/ > ?id=5921a19d4b0c6491b3535b5154d585384c9ea144 fixes the problem for

[Mesa-dev] [Bug 107822] Just Cause 3 Flickering Textures with AMD RADV

2018-12-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107822 fin4...@hotmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-14 Thread Tapani Pälli
On 12/14/18 12:53 PM, Erik Faye-Lund wrote: On Thu, 2018-12-13 at 10:46 -0800, Eric Anholt wrote: Dylan Baker writes: [ Unknown signature status ] In the autotools discussion I've come to realize that we also need to talk about the -DDEBUG guard. It seems that there are two different uses,

[Mesa-dev] [Bug 108275] Breaking out of loop creates broken code on RADV

2018-12-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108275 --- Comment #12 from mais...@archlinux.us --- Yes, with latest master, it works as expected. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Henri Verbeet
On Fri, 14 Dec 2018 at 15:42, Gert Wollny wrote: > Am Freitag, den 14.12.2018, 01:19 -0500 schrieb Ilia Mirkin: > > meson is not at a point where it Just Works. It ... sometimes works. > > The fact that everyone has scripts which wrap meson is a symptom of > > that. I don't feel good about dumping

Re: [Mesa-dev] [PATCH v2] docs: Document GitLab merge request process (email alternative)

2018-12-14 Thread Gert Wollny
Am Freitag, den 14.12.2018, 12:38 +0100 schrieb Samuel Pitoiset: > > On 12/13/18 9:27 PM, Gert Wollny wrote: > > IMHO allowing MRs is a good thing, so > >Acked-by: Gert Wollny > > > > Allowing MRs isn't a bad thing. The main problem IMHO is that now we > have to look at both emails and MRs,

[Mesa-dev] [PATCH v2 00/24] En route towards Khronos gl.xml

2018-12-14 Thread Emil Velikov
Hi all, Here is v2 of the gl dispatch rework, that makes use of the upstream Khronos gl.xml. Seen [1] for details. Changes since v1: - use os.path.join - existing mesa and new patches (Dylan) - new patch: drop gl_dispatch_stub declarations (Erik) - new patch: revert ABI breaking change (Erik)

[Mesa-dev] [PATCH v2 01/24] mesa: correctly use os.path.join in our python scripts

2018-12-14 Thread Emil Velikov
From: Emil Velikov With Windows in mind, using forward slash isn't the right thing to do. Even if it just works, we might want to fix it. As here, use __file__ instead of argv[0] and sys.path.insert over sys.path.append. With the path tweak being reportedly faster. Cc: Dylan Baker Suggested-by

[Mesa-dev] [PATCH v2 02/24] mapi: drop unneeded gl_dispatch_stub declarations

2018-12-14 Thread Emil Velikov
From: Erik Faye-Lund These declarations are not used anywhere - be that generated code or otherwise. [Emil: format the hunk from Erik into a patch] Signed-off-by: Emil Velikov --- src/mapi/mapi_abi.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mapi/mapi_abi.py b/

[Mesa-dev] [PATCH v2 09/24] mapi/new: sort by slot number

2018-12-14 Thread Emil Velikov
From: Emil Velikov Makes it easier to compare the newly generated header against the old one. Will be reverted after the transition. --- src/mapi/new/genCommon.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mapi/new/genCommon.py b/src/mapi/new/genCommon.py index b0925d80151..ec48d

[Mesa-dev] [PATCH v2 05/24] mapi: add all _glapi_table entrypoints to static_data.py

2018-12-14 Thread Emil Velikov
From: Emil Velikov Currently various parts of mesa use the glapi_table differently. Some use _glapi_get_proc_offset() to get the offset, while others directly reference the specific offset via _gloffset_Function. Add all static entries, to ensure things don't break as we flip to the upstream XM

[Mesa-dev] [PATCH v2 08/24] mapi/new: import mapi scripts from glvnd

2018-12-14 Thread Emil Velikov
From: Emil Velikov Currently we have over 20 scripts that generate the libGL* dispatch and various other functionality. More importantly we're using local XML files instead of the Khronos provides one(s). Resulting in an increasing complexity of writing, maintaining and bugfixing. One fairly ann

[Mesa-dev] [PATCH v2 11/24] mapi/new: reinstate _NO_HIDDEN suffixes in the new generator

2018-12-14 Thread Emil Velikov
From: Emil Velikov Strictly speaking we can rework the rest of the code so we do not need those. That said, this will require a series on it's own so let's carry this local quirk for now. Signed-off-by: Emil Velikov --- src/mapi/new/gen_gldispatch_mapi.py | 12 ++-- 1 file changed, 6 i

[Mesa-dev] [PATCH v2 03/24] Revert "mesa/main: remove ARB suffix from glGetnTexImage"

2018-12-14 Thread Emil Velikov
This reverts commit f1998e15ffccf260552bf559abe1a733a8ce990e. This changes the ABI, such that glGetnTexImageARB entry-point from the GLAPI gets removed. Thus accessing many functions by offset (as we do) will result in getting the wrong one. Follow-up work will swap the by-offset handling, but fo

[Mesa-dev] [PATCH v2 19/24] Revert "mapi/new: sort by slot number"

2018-12-14 Thread Emil Velikov
This reverts commit a1f5d9412cf7cacb3534635f6c2409fafbe6574e. We no longer needed to sort - it was meant only to ease compare against the old generated files. --- src/mapi/new/genCommon.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mapi/new/genCommon.py b/src/mapi/new/genCommon.py

[Mesa-dev] [PATCH v2 07/24] mapi: move genCommon.py to src/mapi/new

2018-12-14 Thread Emil Velikov
From: Emil Velikov The helper will also be used by the new Khronos gl.xml aware generator. v2: Move existing one, instead of duplicating it. Suggested-by: Kyle Brenneman Signed-off-by: Emil Velikov --- src/egl/Makefile.am | 6 -- src/egl/generate/gen_egl_dispatch.

[Mesa-dev] [PATCH v2 10/24] mapi/new: use the static_data offsets in the new generator

2018-12-14 Thread Emil Velikov
From: Emil Velikov Otherwise the incorrect ones will be used, effectively breaking the ABI. Note: some entries in static_data.py list a suffixed API, while (for ES* at least) we expect the one w/o suffix. v2: - rework path handling (Dylan) - use else if chain (Erik) Signed-off-by: Emil Velik

[Mesa-dev] [PATCH v2 04/24] mapi: sort static entrypoints numerically

2018-12-14 Thread Emil Velikov
From: Emil Velikov A few of the entrypoints were incorrectly placed. Sort those to align with the rest of the list. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/glapi/gen/static_data.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH v2 24/24] mapi: remove machinery handling CSV files

2018-12-14 Thread Emil Velikov
From: Emil Velikov We haven't have one in years, so just drop the code. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/mapi_abi.py | 80 1 file changed, 6 insertions(+), 74 deletions(-) diff --git a/src/mapi/mapi_abi.py b/src

[Mesa-dev] [PATCH v2 18/24] scons: wire the new generator for es1 and es2

2018-12-14 Thread Emil Velikov
From: Emil Velikov Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/shared-glapi/SConscript | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/mapi/shared-glapi/SConscript b/src/mapi/shared-glapi/SConscript index 060c61dadc

[Mesa-dev] [PATCH v2 23/24] mapi: remove old, unused ES* generator code

2018-12-14 Thread Emil Velikov
From: Emil Velikov As of earlier commit, everyone has switched to the new script for the ES dispatch. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/glapi/gen/gl_XML.py | 56 +- src/mapi/mapi_abi.py | 58 ---

[Mesa-dev] [PATCH v2 21/24] mapi/es*api: remove GL_EXT_multi_draw_arrays entrypoints

2018-12-14 Thread Emil Velikov
From: Emil Velikov Now we use the upstream XML file and a cleaner generator. Thus the symbols are no longer exported and we can drop them from this list. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/es1api/ABI-check | 7 +-- src/mapi/es2api/ABI-check | 6 +- 2

[Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

2018-12-14 Thread Emil Velikov
There is no need for the noop functions, the public_stubs and public_entries table or table size defines. Remove those. Pretty much all of this is applicable to GLVND, although it requires preparatory work. v2: - python style fixes (Dylan) - use "gldispatch" instead of not "glesv1" "glesv2" -

[Mesa-dev] [PATCH v2 16/24] autotools: wire the new generator for es1 and es2

2018-12-14 Thread Emil Velikov
The output produced functionally identical, with the following changes: - A cosmetic: swapped ABI compatible types [ GLclampf -> GLfloat, etc ] - B cosmetic: renamed parameters [ zNear -> n, etc ] - C dropped extension entrypoints - invalid/incorrect To make things easier to validate, normalise

[Mesa-dev] [PATCH v2 22/24] mapi/es2api: remove no longer present entrypoints

2018-12-14 Thread Emil Velikov
From: Emil Velikov With the previous scripts API from the following was incorrectly exported. Drop them from the list, since they're no longer around. GL_EXT_blend_func_extended GL_EXT_texture_integer Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/es2api/ABI-check | 5 -

[Mesa-dev] [PATCH v2 17/24] meson: wire the new generator for es1 and es2

2018-12-14 Thread Emil Velikov
From: Emil Velikov v2: use ${foo})_py naming (Dylan) Cc: Dylan Baker Cc: Eric Engestrom Signed-off-by: Emil Velikov --- src/mapi/es1api/meson.build| 6 +++--- src/mapi/es2api/meson.build| 6 +++--- src/mapi/glapi/gen/meson.build | 7 +++ 3 files changed, 13 insertions(+), 6 delet

[Mesa-dev] [PATCH v2 14/24] mapi/new: fixup the GLDEBUGPROCKHR typedef to the non KHR one

2018-12-14 Thread Emil Velikov
From: Emil Velikov This way we can reuse the latter, which is already present in the headers that we use. Thus we can drop the manual typedef we generate. We might want to merge this back in GLVND. Signed-off-by: Emil Velikov --- src/mapi/new/genCommon.py | 1 + src/mapi/new/gen_gld

[Mesa-dev] [PATCH v2 20/24] mapi/es*api: remove GL_OES_EGL_image entrypoints

2018-12-14 Thread Emil Velikov
From: Emil Velikov As some point in the past we fixed the scripts so, these are no longer exported. Drop them from the list. Signed-off-by: Emil Velikov Reviewed-by: Erik Faye-Lund --- src/mapi/es1api/ABI-check | 3 --- src/mapi/es2api/ABI-check | 3 --- 2 files changed, 6 deletions(-) diff

[Mesa-dev] [PATCH v2 06/24] genCommon.py: Fix typo in _LIBRARY_FEATURE_NAMES.

2018-12-14 Thread Emil Velikov
From: Emil Velikov Port glvnd commit 37fc6caa4b8 ("Fix typo in _LIBRARY_FEATURE_NAMES.") from Michal Srb. Signed-off-by: Emil Velikov --- src/egl/generate/genCommon.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/generate/genCommon.py b/src/egl/generate/genCommon

[Mesa-dev] [PATCH v2 12/24] mapi/new: split out public_entries handling

2018-12-14 Thread Emil Velikov
From: Emil Velikov The only instance that requires the public_entries table is the dispatch library - split that into another function. We have to be careful with when undefining the guard, so split it out. We might want to merge this back in GLVND. Minor GLVND cleanup will be needed first. Si

[Mesa-dev] [PATCH v2 15/24] mapi/new: remove duplicate GLvoid/void substitution

2018-12-14 Thread Emil Velikov
From: Emil Velikov We already do it a few lines above - drop the duplicate. Note that for consistency sake, we keep the substitution since the GL API is a mixed bad - some use GLvoid while others a normal void. We might want to merge this back in GLVND. Signed-off-by: Emil Velikov Reviewed-by

Re: [Mesa-dev] [PATCH v2 01/24] mesa: correctly use os.path.join in our python scripts

2018-12-14 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > With Windows in mind, using forward slash isn't the right thing to > do. > Even if it just works, we might want to fix it. > > As here, use __file__ instead of argv[0] and sys.path.inser

Re: [Mesa-dev] [PATCH v2 03/24] Revert "mesa/main: remove ARB suffix from glGetnTexImage"

2018-12-14 Thread Erik Faye-Lund
Acked-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > This reverts commit f1998e15ffccf260552bf559abe1a733a8ce990e. > > This changes the ABI, such that glGetnTexImageARB entry-point from > the > GLAPI gets removed. Thus accessing many functions by offset (as we > do)

Re: [Mesa-dev] [PATCH v2 06/24] genCommon.py: Fix typo in _LIBRARY_FEATURE_NAMES.

2018-12-14 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Port glvnd commit 37fc6caa4b8 ("Fix typo in _LIBRARY_FEATURE_NAMES.") > from Michal Srb. > > Signed-off-by: Emil Velikov > --- > src/egl/generate/genCommon.py | 2 +- > 1 file changed,

Re: [Mesa-dev] [PATCH v2 05/24] mapi: add all _glapi_table entrypoints to static_data.py

2018-12-14 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Currently various parts of mesa use the glapi_table differently. > > Some use _glapi_get_proc_offset() to get the offset, while others > directly reference the specific offset via _gloff

Re: [Mesa-dev] [PATCH v2 07/24] mapi: move genCommon.py to src/mapi/new

2018-12-14 Thread Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > The helper will also be used by the new Khronos gl.xml aware > generator. > > v2: Move existing one, instead of duplicating it. > > Suggested-by: Kyle Brenneman > Signed-off-by: Emil Velikov > --- > src/egl/Makef

Re: [Mesa-dev] [PATCH v2 08/24] mapi/new: import mapi scripts from glvnd

2018-12-14 Thread Erik Faye-Lund
On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Currently we have over 20 scripts that generate the libGL* dispatch > and > various other functionality. More importantly we're using local XML > files instead of the Khronos provides one(s). Resulting in an > increas

Re: [Mesa-dev] [PATCH v2 09/24] mapi/new: sort by slot number

2018-12-14 Thread Erik Faye-Lund
I assume this will be kicked out of the branch before we merge? I mean, either works, it just seems a bit pointless to keep patches to aid comparisons in our tree. On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Makes it easier to compare the newly generated heade

Re: [Mesa-dev] [PATCH v2 10/24] mapi/new: use the static_data offsets in the new generator

2018-12-14 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Otherwise the incorrect ones will be used, effectively breaking the > ABI. > > Note: some entries in static_data.py list a suffixed API, while (for > ES* > at least) we expect the one w/

Re: [Mesa-dev] [PATCH v2 11/24] mapi/new: reinstate _NO_HIDDEN suffixes in the new generator

2018-12-14 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > Strictly speaking we can rework the rest of the code so we do not > need > those. That said, this will require a series on it's own so let's > carry > this local quirk for now. > > Signe

Re: [Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

2018-12-14 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > There is no need for the noop functions, the public_stubs and > public_entries table or table size defines. Remove those. > > Pretty much all of this is applicable to GLVND, although it > requires preparatory wo

Re: [Mesa-dev] [PATCH v2 14/24] mapi/new: fixup the GLDEBUGPROCKHR typedef to the non KHR one

2018-12-14 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > This way we can reuse the latter, which is already present in the > headers that we use. Thus we can drop the manual typedef we generate. > > We might want to merge this back in GLVND. >

Re: [Mesa-dev] [PATCH v2 17/24] meson: wire the new generator for es1 and es2

2018-12-14 Thread Erik Faye-Lund
For 16 and 17: Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > From: Emil Velikov > > v2: use ${foo})_py naming (Dylan) > > Cc: Dylan Baker > Cc: Eric Engestrom > Signed-off-by: Emil Velikov > --- > src/mapi/es1api/meson.build| 6 +++--- > src/mapi

[Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

2018-12-14 Thread Jon Turney
Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) Include again, as functions prototyped by it are used in the GLX_USE_WINDOWSGL path. Make the include guard around the __glxGetMscRate() definition match

Re: [Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

2018-12-14 Thread Emil Velikov
On Fri, 14 Dec 2018 at 14:56, Jon Turney wrote: > > Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical > (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) > > Include again, as functions prototyped by it are used in > the GLX_USE_WINDOWSGL path. > > Make

[Mesa-dev] [Bug 109039] [CLOVER][CLANG-SVN] build failure CodeGenOptions.h: No such file or directory

2018-12-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109039 network...@rkmail.ru changed: What|Removed |Added CC||network...@rkmail.ru -- You are

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 Bug ID: 109062 Summary: meson incorrectly handles/reports libdrm_$foo Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 Emil Velikov changed: What|Removed |Added CC||baker.dyla...@gmail.com,

[Mesa-dev] [PATCH] clover: Fix include of CodeGenOptions.h, upstream moved it in r348827

2018-12-14 Thread Kai Wasserbäch
Signed-off-by: Kai Wasserbäch --- src/gallium/state_trackers/clover/llvm/compat.hpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/compat.hpp b/src/gallium/state_trackers/clover/llvm/compat.hpp index 975012cbda..9c5b9d8917 100644 --- a/src/gallium/

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Matt Turner
On Fri, Dec 14, 2018 at 4:12 AM Gert Wollny wrote: > I second that, I voiced my concerns in a former thread, especially that > so far this upcoming change has not been officially announced in the > release notes or on mesa-user, and that I don't understand why it is so > urgent to drop autotools w

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Ilia Mirkin
On Fri, Dec 14, 2018 at 11:32 AM Matt Turner wrote: > > On Fri, Dec 14, 2018 at 4:12 AM Gert Wollny wrote: > > I second that, I voiced my concerns in a former thread, especially that > > so far this upcoming change has not been officially announced in the > > release notes or on mesa-user, and th

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Alex Deucher
On Fri, Dec 14, 2018 at 11:32 AM Matt Turner wrote: > > On Fri, Dec 14, 2018 at 4:12 AM Gert Wollny wrote: > > I second that, I voiced my concerns in a former thread, especially that > > so far this upcoming change has not been officially announced in the > > release notes or on mesa-user, and th

[Mesa-dev] [Bug 109062] meson incorrectly handles/reports libdrm_$foo

2018-12-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109062 --- Comment #1 from Dylan Baker --- In meson we iterate through all of the libdrm versions required for each enabled target, then select the hightest version and check only for that version of libdrm and libdrm_*. We do this specifically to avoi

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Dylan Baker
Quoting Gert Wollny (2018-12-14 03:44:32) > Am Montag, den 10.12.2018, 15:10 -0800 schrieb Dylan Baker: > > Meson 0.49.0 has been out for a couple of days now, and I'd like to > > make the final call for autotools. My patch is so massive that it's a > > huge pain to send to the list, the latest ver

Re: [Mesa-dev] [PATCH v6 0/8] Add and enable extension EXT_sRGB_write_control

2018-12-14 Thread Gert Wollny
Hi all, Since I like MRs I've pushed the new version to https://gitlab.freedesktop.org/mesa/mesa/merge_requests/14 There is actually only one one-line change with respect to the series as posted here, so using the MR also saves everyones band-width. So far it was tested on r600 with the GLES

Re: [Mesa-dev] [PATCH 1/2] pci_ids: add new vega10 pci ids

2018-12-14 Thread Alex Deucher
Ping? Alex On Fri, Dec 7, 2018 at 4:11 PM Alex Deucher wrote: > > Signed-off-by: Alex Deucher > Cc: mesa-sta...@lists.freedesktop.org > --- > include/pci_ids/radeonsi_pci_ids.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/pci_ids/radeonsi_pci_ids.h >

Re: [Mesa-dev] [PATCH 02/18] pipe-loader: meson: reference correct library

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:05:51) > From: Emil Velikov > > The library is called libgalliumvl_stub - note singular. > > Fixes: 42ea0631f10 ("meson: build clover") > Signed-off-by: Emil Velikov > --- > src/gallium/targets/pipe-loader/meson.build | 2 +- > 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH 03/18] glx: meson: build src/glx only with -Dglx=dri

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:05:52) > From: Emil Velikov > > The library is the dri capable one, push the check src/meson.build, > instead of the current partial handling in src/glx/meson.build. > > Fixes: a47c525f328 ("meson: build glx") This is just a refactor, the Fixes: is unnecessar

Re: [Mesa-dev] [PATCH 04/18] glx: meson: drop includes from a link-only library

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:05:53) > From: Emil Velikov > > When producing the final libGL.so/libGLX_mesa.so we only link the local > static helper lib (libglx). Thus there's no reason for the includes. > > Fixes: a47c525f328 ("meson: build glx") > Signed-off-by: Emil Velikov > --- > s

[Mesa-dev] [PATCH] st/nir: Use nir_src_as_uint for tokens

2018-12-14 Thread Jason Ekstrand
--- src/mesa/state_tracker/st_nir_lower_builtin.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_nir_lower_builtin.c b/src/mesa/state_tracker/st_nir_lower_builtin.c index 195dc40b2ef..ab74d3183dc 100644 --- a/src/mesa/state_tracker/st_nir_lower_

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Andre Heider
On 14/12/2018 17:53, Dylan Baker wrote: Quoting Gert Wollny (2018-12-14 03:44:32) Am Montag, den 10.12.2018, 15:10 -0800 schrieb Dylan Baker: (2) It would be nice if Meson would distribute some default cross build files, currently everybody has to roll its own, and I guess in the end they all lo

Re: [Mesa-dev] last call for autotools

2018-12-14 Thread Dylan Baker
Quoting Andre Heider (2018-12-14 09:24:56) > On 14/12/2018 17:53, Dylan Baker wrote: > > Quoting Gert Wollny (2018-12-14 03:44:32) > >> Am Montag, den 10.12.2018, 15:10 -0800 schrieb Dylan Baker: > >> (2) It would be nice if Meson would distribute some default cross build > >> files, currently ever

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-14 Thread Dylan Baker
Quoting Tapani Pälli (2018-12-14 05:03:06) > > > On 12/14/18 12:53 PM, Erik Faye-Lund wrote: > > On Thu, 2018-12-13 at 10:46 -0800, Eric Anholt wrote: > >> Dylan Baker writes: > >> > >>> [ Unknown signature status ] > >>> In the autotools discussion I've come to realize that we also need > >>> t

Re: [Mesa-dev] [PATCH 05/18] glx: meson: wire up the dispatch-index-check test

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:05:54) > From: Emil Velikov > > Accidentally dropped with earlier commit.! > > Fixes: 4ccb9816737 ("meson: Use consistent style for tests") > Signed-off-by: Emil Velikov > --- > src/glx/tests/meson.build | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [Mesa-dev] [PATCH 06/18] glx/test: meson: assorted include fixes

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:05:55) > From: Emil Velikov > > Swap '..' with the symbolic inc_glx and add glproto as dependency. That > will pull the correct include, effectively fixing the tests on macOS. > > Fixes: a47c525f328 ("meson: build glx") > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 07/18] configure: add CXX11_CXXFLAGS to LLVM_CXXFLAGS

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:05:56) > From: Emil Velikov > > Seemingly with LLVM7 and GCC 5.0, the former won't properly advertise > -std=c++11 and the latter will choke. > > dd this temporary workaround, otherwise we'll get errors like: > > In file included from /usr/include/c++/5/type_

Re: [Mesa-dev] [PATCH 08/18] travis: flip to distro xenial, sudo true

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:05:57) > From: Emil Velikov > > The latter is the default these days and Travis will be removing sudo > soonish. > > Flipping to xenial, allows us to remove a bunch of hacks we have. Plus > it prevents us from adding new ones, to workaround what seems like a >

Re: [Mesa-dev] [PATCH 09/18] travis: meson: print the configured state

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:05:58) > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > .travis.yml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.travis.yml b/.travis.yml > index deec40cb135..6fefe06617a 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -670,5 +67

Re: [Mesa-dev] [PATCH 10/18] travis: printout llvm-config --version

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:05:59) > From: Emil Velikov > > Provides quick and easy feedback. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index 6fefe06617a..c69f322d7b3 100644 > --- a/.travi

Re: [Mesa-dev] [PATCH 11/18] travis: meson: use native files to override llvm-config

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:06:00) > From: Dylan Baker > > This is the supported way to do this, and should be more robust and > reliable. > > v2: [Emil] > - enable backslash escapes > - don't hardcode the path > - pass the argument directly to meson > > Reviewed-by: Emil Velikov (v

Re: [Mesa-dev] [PATCH 14/18] travis: meson: use FOO_DRIVERS directly

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:06:03) > From: Emil Velikov > > It makes for a shorter MESON_OPTIONS and cleaner handling. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/.travis.yml b/.travis.yml >

Re: [Mesa-dev] [PATCH 18/18] travis: meson: port gallium build combinations over

2018-12-14 Thread Dylan Baker
Quoting Emil Velikov (2018-12-13 08:06:07) > From: Emil Velikov > > This commit adds a number of build combos: > > - Gallium Drivers {SWR, RadeonSI, Others) > Each one has different LLVM requirements. Building SWR alone is twice > as slow as all other drivers combined. > > - Gallium ST Clover

  1   2   >