Free the context after destruction.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Sinclair Yeh
---
src/gallium/state_trackers/xa/xa_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/state_trackers/xa/xa_context.c
b/src/gallium/state_trackers/xa/xa_context.c
index 94f7185
The ioctl.cap_3d member was never freed.
Signed-off-by: Thomas Hellstrom
Reviewed-by: Sinclair Yeh
---
src/gallium/winsys/svga/drm/vmw_screen_ioctl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/winsys/svga/drm/vmw_screen_ioctl.c
b/src/gallium/winsys/svga/drm/vmw_screen_io
On Tue, 2018-11-27 at 23:20 -0800, Jordan Justen wrote:
> This adds the "Developer's Certificate of Origin 1.1" from the Linux
> kernel. It indicates that by using Signed-off-by you are certifying
> that your patch meets the DCO 1.1 guidelines.
>
> It also changes Signed-off-by from being optional
On 2018-11-28 00:47:25, Erik Faye-Lund wrote:
> On Tue, 2018-11-27 at 23:20 -0800, Jordan Justen wrote:
> > This adds the "Developer's Certificate of Origin 1.1" from the Linux
> > kernel. It indicates that by using Signed-off-by you are certifying
> > that your patch meets the DCO 1.1 guidelines.
On 28/11/18 6:52 pm, Thomas Helland wrote:
Den ons. 28. nov. 2018 kl. 04:26 skrev Timothy Arceri :
This adds allows loop analysis to detect inductions varibales that
are incremented in both branches of an if rather than in a main
loop block. For example:
loop {
block block_1:
Both patches:
Reviewed-by: Nicolai Hähnle
On 26.11.18 20:18, Ian Romanick wrote:
> From: Ian Romanick
>
> Ralloc has a feature that all allocations from a temporary memory
> context can be whisked away in a single call without fear of leaks. As
> the slab allocator is designed for use in mult
Hi,
On 28.11.2018 2.38, Ian Romanick wrote:
From: Ian Romanick
Found using pahole.
While Pahole does static analysis for binaries, Valgrind has tool that
can do also _run-time_ analysis of structures and other heap allocations
utilization:
http://valgrind.org/docs/manual/dh-manual.ht
Hi,
On 28.11.2018 5.25, Timothy Arceri wrote:
This adds allows loop analysis to detect inductions varibales that
are incremented in both branches of an if rather than in a main
loop block. For example:
[...]> Unfortunatly GCM could move the addition out of the if for us
(making this patch unre
On Tuesday, 2018-11-27 22:52:47 -0800, Matt Turner wrote:
> Reviewed-by: Matt Turner
>
> I'll commit it tomorrow.
When you do that, the commit title should be fixed to something like
egl: add missing #include in egldevice.h
since the original commit title doesn't apply anymore.
And while at
Thanks! Looks much better than my attempt.
Series overall work as expected and eliminate the loop from the
bug: https://bugs.freedesktop.org/show_bug.cgi?id=32211
Also found two typos:
On 11/28/18 5:25 AM, Timothy Arceri wrote:
From: Danylo Piliaiev
Removing the last continue can allow more
On Wednesday, 2018-11-28 01:18:16 -0800, Jordan Justen wrote:
> On 2018-11-28 00:47:25, Erik Faye-Lund wrote:
> > On Tue, 2018-11-27 at 23:20 -0800, Jordan Justen wrote:
> > > This adds the "Developer's Certificate of Origin 1.1" from the Linux
> > > kernel. It indicates that by using Signed-off-by
On Wed, 2018-11-28 at 01:18 -0800, Jordan Justen wrote:
> On 2018-11-28 00:47:25, Erik Faye-Lund wrote:
> > On Tue, 2018-11-27 at 23:20 -0800, Jordan Justen wrote:
> > > This adds the "Developer's Certificate of Origin 1.1" from the
> > > Linux
> > > kernel. It indicates that by using Signed-off-by
On Tuesday, 2018-11-27 19:45:50 -0800, Jordan Justen wrote:
> On 2018-11-27 19:20:09, Matt Turner wrote:
> > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> > wrote:
> > >
> > > This documents a mechanism for using GitLab Merge Requests as an
> > > optional, secondary way to get code reviews for
On Wed, 28 Nov 2018 at 14:29, Eric Engestrom wrote:
>
> On Wednesday, 2018-11-28 01:18:16 -0800, Jordan Justen wrote:
> > On 2018-11-28 00:47:25, Erik Faye-Lund wrote:
> > > On Tue, 2018-11-27 at 23:20 -0800, Jordan Justen wrote:
> > > > This adds the "Developer's Certificate of Origin 1.1" from t
On Wed, 28 Nov 2018 at 08:13, Thomas Hellstrom wrote:
>
> Free the context after destruction.
>
> Signed-off-by: Thomas Hellstrom
> Reviewed-by: Sinclair Yeh
Cc: mesa-sta...@lists.freedesktop.org
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing
On Wed, 2018-11-28 at 15:20 +, Emil Velikov wrote:
> On Wed, 28 Nov 2018 at 14:29, Eric Engestrom <
> eric.engest...@intel.com> wrote:
> > On Wednesday, 2018-11-28 01:18:16 -0800, Jordan Justen wrote:
> > > On 2018-11-28 00:47:25, Erik Faye-Lund wrote:
> > > > On Tue, 2018-11-27 at 23:20 -0800,
On Wed, 28 Nov 2018 at 08:14, Thomas Hellstrom wrote:
>
> The ioctl.cap_3d member was never freed.
>
> Signed-off-by: Thomas Hellstrom
> Reviewed-by: Sinclair Yeh
Cc: mesa-sta...@lists.freedesktop.org
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mai
On Wed, 28 Nov 2018 at 12:33, Eric Engestrom wrote:
>
> On Tuesday, 2018-11-27 22:52:47 -0800, Matt Turner wrote:
> > Reviewed-by: Matt Turner
> >
> > I'll commit it tomorrow.
>
> When you do that, the commit title should be fixed to something like
> egl: add missing #include in egldevice.h
>
On 11/28/2018 02:54 AM, Eero Tamminen wrote:
> Hi,
>
> On 28.11.2018 2.38, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> Found using pahole.
>
> While Pahole does static analysis for binaries, Valgrind has tool that
> can do also _run-time_ analysis of structures and other heap allocations
> u
On Wednesday, 2018-11-28 16:28:53 +0100, Erik Faye-Lund wrote:
> On Wed, 2018-11-28 at 15:20 +, Emil Velikov wrote:
> > On Wed, 28 Nov 2018 at 14:29, Eric Engestrom <
> > eric.engest...@intel.com> wrote:
> > > On Wednesday, 2018-11-28 01:18:16 -0800, Jordan Justen wrote:
> > > > On 2018-11-28 0
Otherwise, I get this error:
main/egldevice.h:54:13: error: ‘NULL’ undeclared (first use in this function)
dev = NULL;
^~~~
with this config:
./autogen.sh --enable-gles1 --enable-gles2 --with-platforms='surfaceless'
--disable-glx
--with-dri-drivers="i965" --with-
On 2018/11/23, Eric Engestrom wrote:
> On Thursday, 2018-11-22 15:04:54 +, Emil Velikov wrote:
> > Please add the hunk back?
>
> Right, I thought the -Wno-error after the -Werror=foo would disable all
> -Werror=*, but after testing it, you're right, I had misunderstood.
> Adding the android h
Am 28.11.18 um 07:37 schrieb Matt Turner:
> The common truncf(x + 0.5) fails for the floating-point value just less
> than 0.5 (nextafterf(0.5, 0.0)). nextafterf(0.5, 0.0) + 0.5, after
> rounding is 1.0, thus truncf does not produce the desired value.
>
> The solution is to add nextafterf(0.5, 0.0
Quoting Matt Turner (2018-11-27 19:20:09)
> On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> wrote:
> >
> > This documents a mechanism for using GitLab Merge Requests as an
> > optional, secondary way to get code reviews for patchsets.
> >
> > We still require all patches to be emailed.
> >
> > As
On 2018-11-28 06:59:42, Eric Engestrom wrote:
> On Tuesday, 2018-11-27 19:45:50 -0800, Jordan Justen wrote:
> > On 2018-11-27 19:20:09, Matt Turner wrote:
> > >
> > > Discussion point: I think attempting to have simultaneous review in
> > > two places is a recipe for wasted time.
> >
> > That's p
First off, +1 to experimenting with MRs. I've been working with GitLab MRs
in another context for some time and I think the process actually works out
really pretty well. There are issues, of course, but I don't think there's
any real show-stoppers as long as we have a bit of process around it su
https://bugs.freedesktop.org/show_bug.cgi?id=108713
Juan A. Suarez changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On 2018-11-28 09:22:35, Dylan Baker wrote:
> Quoting Matt Turner (2018-11-27 19:20:09)
> > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> > wrote:
> > >
> > > This documents a mechanism for using GitLab Merge Requests as an
> > > optional, secondary way to get code reviews for patchsets.
> > >
>
Mesa 18.2.6 is now available.
In this release we have:
Several patches fixing leaks in glsl, winsys and r600.
Improvements in the scripts that helps in preparing releases.
Added PCI IDs for Amber Lake and Whiskey Lake.
Fixes for radv, anv, i965 and vc4 drivers.
A couple of fixes in NIR backen
On 2018-11-28 10:14:49, Jason Ekstrand wrote:
> On Wed, Nov 28, 2018 at 11:35 AM Jordan Justen
> wrote:
> > On 2018-11-28 06:59:42, Eric Engestrom wrote:
> > > On Tuesday, 2018-11-27 19:45:50 -0800, Jordan Justen wrote:
> > > > On 2018-11-27 19:20:09, Matt Turner wrote:
> > > > >
> > > > > Discuss
Are those committed yet? They don't seem to apply cleanly on master.
Christian.
Am 27.11.18 um 02:56 schrieb Marek Olšák:
From: Marek Olšák
---
.../drivers/radeonsi/si_compute_blit.c| 4 +-
src/gallium/drivers/radeonsi/si_cp_dma.c | 49 ++-
src/gallium/driver
On Wed, Nov 28, 2018 at 1:16 PM Jordan Justen
wrote:
> On 2018-11-28 10:14:49, Jason Ekstrand wrote:
> > On Wed, Nov 28, 2018 at 11:35 AM Jordan Justen <
> jordan.l.jus...@intel.com>
> > wrote:
> > > On 2018-11-28 06:59:42, Eric Engestrom wrote:
> > > > On Tuesday, 2018-11-27 19:45:50 -0800, Jord
On Wed, Nov 28, 2018 at 2:16 PM Jordan Justen wrote:
>
> On 2018-11-28 10:14:49, Jason Ekstrand wrote:
> > On Wed, Nov 28, 2018 at 11:35 AM Jordan Justen
> > wrote:
> > > On 2018-11-28 06:59:42, Eric Engestrom wrote:
> > > > On Tuesday, 2018-11-27 19:45:50 -0800, Jordan Justen wrote:
> > > > > On
No. I can push them after they are reviewed or acked.
Marek
On Wed, Nov 28, 2018 at 2:16 PM Christian König <
ckoenig.leichtzumer...@gmail.com> wrote:
> Are those committed yet? They don't seem to apply cleanly on master.
>
> Christian.
>
> Am 27.11.18 um 02:56 schrieb Marek Olšák:
> > From: Mar
On Mon, Nov 26, 2018 at 8:54 PM Marek Olšák wrote:
>
> On Mon, Nov 26, 2018 at 8:46 AM Bas Nieuwenhuizen wrote:
>>
>> patches 4-7 are
>>
>> Reviewed-by: Bas Nieuwenhuizen
>>
>> though I agree with Christian that it would be nice to get a case
>> where 7 improves things before we submit it.
>>
>>
Fix build error.
CXXLDpipe_msm.la
../../../../src/gallium/drivers/freedreno/.libs/libfreedreno.a(freedreno_batch.o):
In function `batch_init':
src/gallium/drivers/freedreno/freedreno_batch.c:54: undefined reference to
`fd_device_version'
src/gallium/drivers/freedreno/freedreno_batch.c:59:
Reviewed-by: Bas Nieuwenhuizen
for the series. Any plans with the newly gotten GDS/OA support?
On Tue, Nov 27, 2018 at 2:57 AM Marek Olšák wrote:
>
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeonsi/si_pipe.c | 46 ++
> src/gallium/drivers/radeonsi/si_pipe.h |
Jordan Justen writes:
> This documents a mechanism for using GitLab Merge Requests as an
> optional, secondary way to get code reviews for patchsets.
>
> We still require all patches to be emailed.
>
> Aside from the potential usage for code review comments, it might also
> help reviewers to find
Jordan Justen writes:
> This adds the "Developer's Certificate of Origin 1.1" from the Linux
> kernel. It indicates that by using Signed-off-by you are certifying
> that your patch meets the DCO 1.1 guidelines.
>
> It also changes Signed-off-by from being optional to being required.
>
> Signed-of
Quoting Jordan Justen (2018-11-28 10:21:13)
> On 2018-11-28 09:22:35, Dylan Baker wrote:
> > Quoting Matt Turner (2018-11-27 19:20:09)
> > > On Tue, Nov 27, 2018 at 5:13 PM Jordan Justen
> > > wrote:
> > > >
> > > > This documents a mechanism for using GitLab Merge Requests as an
> > > > optional
Quoting Jason Ekstrand (2018-11-28 11:30:32)
> Yes, but the point is that we (the reviewers) know that we're conflicting.
> That's very different from what I could easily see happening *a lot* were ML
> reviewer A is perfectly happy with some bit of code but MR reviewer B asks for
> it to be compl
Jason Ekstrand writes:
> ---
> src/amd/common/ac_nir_to_llvm.c | 12
> src/compiler/glsl/glsl_to_nir.cpp | 2 +-
> src/compiler/nir/nir_builder.h| 12
> src/compiler/spirv/vtn_glsl450.c | 4 ++--
> .../drivers/fre
https://bugs.freedesktop.org/show_bug.cgi?id=108572
--- Comment #1 from Marco ---
Taking inspiration from:
https://bugs.freedesktop.org/show_bug.cgi?id=108879
I tried to comment the call to si_clear_buffer and magically clinfo start to
work again.
diff --git a/src/gallium/drivers/radeonsi/si_pip
https://bugs.freedesktop.org/show_bug.cgi?id=108572
--- Comment #2 from Marco ---
Created attachment 142654
--> https://bugs.freedesktop.org/attachment.cgi?id=142654&action=edit
clinfo output
Thi is the output of clinfo after applying the patch (commenting
si_clear_buffer)
--
You are receivi
https://bugs.freedesktop.org/show_bug.cgi?id=108572
Marco changed:
What|Removed |Added
Component|Gallium/StateTracker/Clover |Drivers/Gallium/radeonsi
Assignee|mes
On Wed, Nov 28, 2018 at 4:28 PM Vinson Lee wrote:
>
> Fix build error.
>
> CXXLDpipe_msm.la
> ../../../../src/gallium/drivers/freedreno/.libs/libfreedreno.a(freedreno_batch.o):
> In function `batch_init':
> src/gallium/drivers/freedreno/freedreno_batch.c:54: undefined reference to
> `fd_de
https://bugs.freedesktop.org/show_bug.cgi?id=108311
Dave Airlie changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Hello and apologies for such a delayed response — we were quite busy with the
SC’18
supercomputing conference.
On Oct 17, 2018, at 3:37 PM, Roland Scheidegger
mailto:srol...@vmware.com>> wrote:
Am 17.10.18 um 19:15 schrieb Gert Wollny:
Dear all,
we are looking into doing a CI for virglrenderer
On 2018-11-28 13:43:29, Eric Anholt wrote:
> Jordan Justen writes:
>
> > This adds the "Developer's Certificate of Origin 1.1" from the Linux
> > kernel. It indicates that by using Signed-off-by you are certifying
> > that your patch meets the DCO 1.1 guidelines.
> >
> > It also changes Signed-of
On Wed, Nov 28, 2018 at 4:31 PM Bas Nieuwenhuizen
wrote:
> Reviewed-by: Bas Nieuwenhuizen
>
Thanks.
> for the series. Any plans with the newly gotten GDS/OA support?
>
Maybe. Right now we just need to make it stable.
Marek
___
mesa-dev mailing lis
From: Marek Olšák
The spec was modified to support GLES. Tested by piglit.
---
docs/relnotes/19.0.0.html| 1 +
src/mesa/main/extensions_table.h | 2 +-
src/mesa/main/glformats.c| 19 +--
src/mesa/main/texcompress.c | 9 +
4 files changed, 24 insert
From: Marek Olšák
because the closed driver exposes it. Tested by piglit.
---
docs/relnotes/19.0.0.html| 1 +
src/compiler/glsl/builtin_functions.cpp | 10 ++
src/compiler/glsl/glsl_parser_extras.cpp | 1 +
src/compiler/glsl/glsl_parser_extras.h | 2 ++
src/mesa/mai
From: Marek Olšák
tested by piglit.
---
docs/relnotes/19.0.0.html| 1 +
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/glformats.c| 13 +++--
src/mesa/main/texcompress.c | 9 +
4 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/docs/rel
Hi Christian,
I just pushed the commits.
The best way to reproduce the out-of-memory errors is to run 2 instances of
the test simultaneously:
R600_DEBUG=testgdsmm glxgears &
R600_DEBUG=testgdsmm glxgears &
It takes about 10 seconds to finish and you'll get a lot of errors.
If you run it again,
Series is
Reviewed-by: Ilia Mirkin
Note that AMD_texture_texture4 is only defined for single-component
textures (not even RED allowed due to the age of the ext -- only ALPHA
/ LUMINANCE / DEPTH_COMPONENT / INTENSITY) -- but it doesn't say what
will happen when a "bad" texture is supplied. I gues
The closed driver treats it the same as textureGather.
Marek
On Wed, Nov 28, 2018 at 8:58 PM Ilia Mirkin wrote:
> Series is
>
> Reviewed-by: Ilia Mirkin
>
> Note that AMD_texture_texture4 is only defined for single-component
> textures (not even RED allowed due to the age of the ext -- only AL
From: Marek Olšák
Tested by piglit.
---
docs/features.txt | 2 +-
docs/relnotes/19.0.0.html | 2 ++
src/mapi/glapi/gen/gl_API.xml | 15 ++-
src/mesa/main/dd.h | 7 +++
src/mesa/main/extensions_table.h|
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.c | 31 ++
1 file changed, 31 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/radeonsi/si_pipe.c
index 503d8331906..cc56ce0c446 100644
--- a/src/gallium/drivers/radeonsi/s
From: Marek Olšák
---
src/util/u_queue.c | 56 ++
1 file changed, 32 insertions(+), 24 deletions(-)
diff --git a/src/util/u_queue.c b/src/util/u_queue.c
index 3812c824b6d..48c5c79552d 100644
--- a/src/util/u_queue.c
+++ b/src/util/u_queue.c
@@ -298,20
From: Marek Olšák
for ARB_parallel_shader_compile
---
src/util/u_queue.c | 50 --
src/util/u_queue.h | 8
2 files changed, 52 insertions(+), 6 deletions(-)
diff --git a/src/util/u_queue.c b/src/util/u_queue.c
index 612ad5e83c6..383a9c09919 1
From: Marek Olšák
---
src/gallium/include/pipe/p_screen.h| 13 ++
src/mesa/state_tracker/st_cb_program.c | 59 +-
2 files changed, 71 insertions(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_screen.h
b/src/gallium/include/pipe/p_screen.h
index c4d6e1
From: Marek Olšák
for ARB_parallel_shader_compile
---
src/util/u_queue.c | 49 +-
src/util/u_queue.h | 5 ++---
2 files changed, 33 insertions(+), 21 deletions(-)
diff --git a/src/util/u_queue.c b/src/util/u_queue.c
index 48c5c79552d..5aaf60ae78e 100
From: Marek Olšák
---
src/util/u_queue.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/util/u_queue.c b/src/util/u_queue.c
index 5aaf60ae78e..612ad5e83c6 100644
--- a/src/util/u_queue.c
+++ b/src/util/u_queue.c
@@ -582,29 +582,29 @@ util_queue_finish_execute(void
https://bugs.freedesktop.org/show_bug.cgi?id=77449
Bug 77449 depends on bug 106287, which changed state.
Bug 106287 Summary: 18.0.1 introduced glitches in Dying Light
https://bugs.freedesktop.org/show_bug.cgi?id=106287
What|Removed |Added
---
64 matches
Mail list logo
