[Mesa-dev] [PATCH v2] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Olivier Fourdan
get_supported_modifiers() and pixmap_from_buffers() requests both expect a window as drawable, passing a pixmap will fail as the Xserver will fail to match the given drawable to a window. That leads to dri3_alloc_render_buffer() to return NULL and breaks rendering when using GLX_DOUBLEBUFFER on pi

[Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Olivier Fourdan
get_supported_modifiers() and pixmap_from_buffers() requests both expect a window as drawable, passing a pixmap will fail as the Xserver will fail to match the given drawable to a window. That leads to dri3_alloc_render_buffer() to return NULL and breaks rendering when using GLX_DOUBLEBUFFER on pi

Re: [Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Daniel Stone
On Thu, 26 Jul 2018 at 08:46, Olivier Fourdan wrote: > get_supported_modifiers() and pixmap_from_buffers() requests both > expect a window as drawable, passing a pixmap will fail as the Xserver > will fail to match the given drawable to a window. > > That leads to dri3_alloc_render_buffer() to ret

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

2018-07-26 Thread Eric Engestrom
On Wednesday, 2018-07-25 14:00:29 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-07-25 11:45:56) > > CovID: 1438132 > > Signed-off-by: Eric Engestrom > > --- > > src/intel/vulkan/anv_device.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/src/intel/vu

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

2018-07-26 Thread Jason Ekstrand
On Thu, Jul 26, 2018 at 1:50 AM Eric Engestrom wrote: > On Wednesday, 2018-07-25 14:00:29 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-07-25 11:45:56) > > > CovID: 1438132 > > > Signed-off-by: Eric Engestrom > > > --- > > > src/intel/vulkan/anv_device.c | 4 +++- > > > 1 file chan

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

2018-07-26 Thread Lionel Landwerlin
On 25/07/18 19:45, Eric Engestrom wrote: CovID: 1438132 Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c inde

Re: [Mesa-dev] [PATCH mesa v2] vulkan/wsi: fix assignment in assert()

2018-07-26 Thread Lionel Landwerlin
On 25/07/18 20:03, Eric Engestrom wrote: CovID: 1438113, 1438118, 1438119, 1438121 Fixes: dc1d10b396179766227df "anv,radv: Add support for VK_KHR_get_display_properties2" Cc: Jason Ekstrand Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- src/vulkan/wsi/wsi_common_displa

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi: fix assignment in assert()

2018-07-26 Thread Lionel Landwerlin
On 25/07/18 19:54, Eric Engestrom wrote: CovID: 1438121 Fixes: dc1d10b396179766227df "anv,radv: Add support for VK_KHR_get_display_properties2" Cc: Jason Ekstrand Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- src/vulkan/wsi/wsi_common_display.c | 2 +- 1 file changed

Re: [Mesa-dev] [PATCH mesa] anv: drop unused local vars

2018-07-26 Thread Lionel Landwerlin
On 25/07/18 20:12, Eric Engestrom wrote: Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_descriptor_set.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index 8f

Re: [Mesa-dev] [PATCH mesa 1/3] anv: remove unnecessary semicolons in python

2018-07-26 Thread Lionel Landwerlin
On 25/07/18 20:14, Eric Engestrom wrote: Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_extensions.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

2018-07-26 Thread Eric Engestrom
On Thursday, 2018-07-26 02:03:58 -0700, Jason Ekstrand wrote: > On Thu, Jul 26, 2018 at 1:50 AM Eric Engestrom > wrote: > > > On Wednesday, 2018-07-25 14:00:29 -0700, Dylan Baker wrote: > > > Quoting Eric Engestrom (2018-07-25 11:45:56) > > > > CovID: 1438132 > > > > Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] intel/compiler: fix lower conversions to account for predication

2018-07-26 Thread Chema Casanova
Please include: Fixes: 5a12bdac09496e00 "i965/compiler: handle conversion to smaller type in the lowering pass for that" Reviewed-by: Jose Maria Casanova Crespo El 17/07/18 a las 11:10, Iago Toral Quiroga escribió: > The pass can create a temporary result for the instru

[Mesa-dev] [Bug 107385] full Screen Corruption when a program is fullscreen

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107385 Bug ID: 107385 Summary: full Screen Corruption when a program is fullscreen Product: Mesa Version: unspecified Hardware: Other OS: Linux (All) Status: NEW

[Mesa-dev] [Bug 107385] full Screen Corruption when a program is fullscreen

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107385 --- Comment #1 from monkeyinastripedsh...@gmail.com --- Created attachment 140827 --> https://bugs.freedesktop.org/attachment.cgi?id=140827&action=edit Corruption This is what it looks like on my monitors. -- You are receiving this mail beca

Re: [Mesa-dev] [PATCH v2] nir/gather_info: Set info.gs.uses_streams

2018-07-26 Thread Alejandro Piñeiro
Forgot to CC Jason On 24/07/18 15:28, Alejandro Piñeiro wrote: > From: Neil Roberts > > Whenever a non-zero stream is written to it now sets uses_streams to > true. This reflects the code in validate_geometry_shader_emissions for > GLSL. > > v2: set uses_streams at gather_info instead that at sp

Re: [Mesa-dev] [PATCH mesa] docs: trivial html fix

2018-07-26 Thread Emil Velikov
On 26 July 2018 at 01:01, Jordan Justen wrote: > You might as well add something like ">" => ">" to the subject. > Yes, please. Reviewed-by: Emil Velikov Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.or

Re: [Mesa-dev] [RFC][PATCH 5/5] Android.mk: Fix checkbuild on Mac builders.

2018-07-26 Thread Emil Velikov
On 25 July 2018 at 20:33, Alistair Strachan wrote: > On Wed, Jul 25, 2018 at 5:48 AM Emil Velikov wrote: >> >> On 25 July 2018 at 00:21, John Stultz wrote: >> > From: Alistair Strachan >> > >> > This is a forward port of a patch in the AOSP/master tree: >> > https://android.googlesource.com/pla

Re: [Mesa-dev] [RFC][PATCH 3/5] CleanSpec.mk: Remove HOST_OUT_release

2018-07-26 Thread Emil Velikov
On 25 July 2018 at 21:20, John Stultz wrote: > On Wed, Jul 25, 2018 at 1:06 PM, Dan Willemsen wrote: >> On Wed, Jul 25, 2018 at 12:35 PM John Stultz wrote: >>> >>> On Wed, Jul 25, 2018 at 5:36 AM, Emil Velikov >>> wrote: >>> > On 25 July 2018 at 00:21, John Stultz wrote: >>> >> From: Dan Will

[Mesa-dev] [Bug 107224] Incorrect Rendering in Deus Ex: Mankind Divided in-game menu

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107224 --- Comment #5 from Alex Smith --- Could you go into "~/.local/share/feral-interactive/Deus Ex Mankind Divided/preferences", find this line: 6 change 6 to 1, and see if that fixes the problem? -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH] i965: Disable guardband clipping on SandyBridge for odd dimensions

2018-07-26 Thread Vadym Shovkoplias
ping On Tue, Jul 3, 2018 at 5:09 PM, Vadim Shovkoplias < vadim.shovkopl...@gmail.com> wrote: > Hi mesa devs, > > Can anyone please review this ? > This patch fixes following bugs: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104388 > Bugzilla: https://bugs.freedesktop.org/show_bug.c

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-26 Thread Emil Velikov
On 25 July 2018 at 20:52, John Stultz wrote: > On Wed, Jul 25, 2018 at 5:42 AM, Emil Velikov > wrote: >> On 25 July 2018 at 00:21, John Stultz wrote: >>> From: Yong Yao >>> >>> This is a forward port of a patch from the AOSP/master branch: >>> https://android.googlesource.com/platform/external

[Mesa-dev] [Bug 107385] full Screen Corruption when a program is fullscreen

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107385 --- Comment #2 from Michel Dänzer --- (In reply to monkeyinastripedshirt from comment #0) > This seemed to appear a few days ago after updating the obiaf ppa on Ubuntu > 18. Can you look up in /var/log/apt/history.log which packages were update

Re: [Mesa-dev] [PATCH v2 1/2] egl/surfaceless: Define DRI_SWRastLoader extension when using swrast.

2018-07-26 Thread Emil Velikov
Hi David, On 18 July 2018 at 01:12, David Riley wrote: Commit message here should explain why this is needed. Is the current kms_swrast usage failing/crashing somewhere, etc. > Signed-off-by: David Riley > --- > src/egl/drivers/dri2/platform_surfaceless.c | 28 + > 1 file

[Mesa-dev] [Bug 107224] Incorrect Rendering in Deus Ex: Mankind Divided in-game menu

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107224 --- Comment #6 from network...@rkmail.ru --- (In reply to Alex Smith from comment #5) > Could you go into "~/.local/share/feral-interactive/Deus Ex Mankind > Divided/preferences", find this line: > > 6 > > change 6 to 1, and see if that fixes t

[Mesa-dev] [PATCH v3] nvc0: serialize before updating some constant buffer bindings

2018-07-26 Thread Rhys Perry
To avoid serializing, this has the user constant buffer always be 65536 bytes and enabled unless it's required that something else is used for constant buffer 0. Fixes artifacts with at least XCOM: Enemy Within, 0 A.D. and Unigine Valley, Heaven and Superposition. v2: changed uniform_buffer_bound

[Mesa-dev] [Bug 107369] "volatile" in OpenCL code not recognized by POLARIS10 and KABINI

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107369 --- Comment #4 from Aaron Watry --- My original theory (before I tested 6.0.1 myself) was that the spectre mitigation changes that went into 6.0.1 broke something about compilation of CL kernels, but that doesn't seem to have been the case (I di

Re: [Mesa-dev] [PATCH v2 2/2] egl/surfaceless: Allow DRMless fallback.

2018-07-26 Thread Emil Velikov
Hi David, On 18 July 2018 at 01:12, David Riley wrote: > Allow platform_surfaceless to use swrast even if DRM is not available. > To be used to allow a fuzzer for virgl to be run on a jailed VM without > hardware GL or DRM support. > > Signed-off-by: David Riley > --- > src/egl/drivers/dri2/pla

Re: [Mesa-dev] [PATCH 1/4] radv: move vk_format_table.c to generated sources

2018-07-26 Thread Emil Velikov
On 22 July 2018 at 09:14, Mauro Rossi wrote: > Android build system will try to compile vk_format_table.c > as a shipped source, but at compile time it will be missing, > we move it to generated source, where it belongs > > Signed-off-by: Mauro Rossi Please add Fixes: f4e499ec791 ("radv: add ini

Re: [Mesa-dev] Mesa 18.2.0 release plan

2018-07-26 Thread Mario Kleiner
Hello Andreas, the improved color depth 30 rendering support for nouveau is imho ready for merging since about a month: https://patchwork.freedesktop.org/project/mesa/patches/?submitter=14956&state=&q=&archive=&delegate= The patch series submitted at 2018-06-13, and the single patch "loader_dri3

Re: [Mesa-dev] [PATCH 3/4] android: radv: add Android.mk for vulkan.radv HAL module

2018-07-26 Thread Emil Velikov
On 22 July 2018 at 09:14, Mauro Rossi wrote: > radv implements the Android Vulkan HAL interface, this patch adds > Android.mk building rules by porting of radv automake rules. > vendor HAL module is installed as /vendor/lib/hw/vulkan.radv.so > > Signed-off-by: Mauro Rossi > --- > src/amd/vulkan/

[Mesa-dev] [Bug 107385] full Screen Corruption when a program is fullscreen

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107385 --- Comment #3 from monkeyinastripedsh...@gmail.com --- Created attachment 140838 --> https://bugs.freedesktop.org/attachment.cgi?id=140838&action=edit dmsg log -- You are receiving this mail because: You are the assignee for the bug. You are

[Mesa-dev] [Bug 107385] full Screen Corruption when a program is fullscreen

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107385 --- Comment #4 from monkeyinastripedsh...@gmail.com --- >Can you look up in /var/log/apt/history.log which packages were updated, and >what the old and new package versions are? 18.2~git1807210730.e1febb~oibaf~b possibly? I updated to that on s

Re: [Mesa-dev] [PATCH] util/disk_cache: Fix disk_cache_get_function_timestamp with disabled cache.

2018-07-26 Thread Emil Velikov
Hi Bas, Pardon for joining so late. On 18 July 2018 at 13:01, Bas Nieuwenhuizen wrote: > radv always needs it, so just check the header instead. Also > do not declare the function if the variable is not set, so we > get a nice compile error instead of failing to open a device > at runtime. > AFA

[Mesa-dev] [Bug 107385] full Screen Corruption when a program is fullscreen

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107385 --- Comment #5 from Michel Dänzer --- (In reply to monkeyinastripedshirt from comment #4) > 18.2~git1807210730.e1febb~oibaf~b possibly? I updated to that on sunday. What was the previous version? /var/log/apt/history.log lists both on the Upgra

Re: [Mesa-dev] [PATCH 3/4] android: radv: add Android.mk for vulkan.radv HAL module

2018-07-26 Thread Mauro Rossi
Hi Emil, Il giorno gio 26 lug 2018 alle ore 16:48 Emil Velikov ha scritto: > > On 22 July 2018 at 09:14, Mauro Rossi wrote: > > radv implements the Android Vulkan HAL interface, this patch adds > > Android.mk building rules by porting of radv automake rules. > > vendor HAL module is installed as

Re: [Mesa-dev] [PATCH] i965: Disable guardband clipping on SandyBridge for odd dimensions

2018-07-26 Thread Rafael Antognolli
Hi Vadym, Ken and Ian explained a bit the situation on this one to me, and it looks like neither of them are really against this patch. So unless someone else raise any concern, I'll ack and push the patch later today. Thanks for fixing this. Rafael On Thu, Jul 26, 2018 at 04:04:29PM +0300, Vad

[Mesa-dev] [Bug 107385] full Screen Corruption when a program is fullscreen

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107385 --- Comment #6 from Michel Dänzer --- Specifically, I'm interested in the versions of the xserver-xorg-video-radeon package. BTW, there's a new version 1:18.0.1+git1807251933.fed411~oibaf~x of that package, can you try if that helps for this is

Re: [Mesa-dev] [PATCH] util/disk_cache: Fix disk_cache_get_function_timestamp with disabled cache.

2018-07-26 Thread Bas Nieuwenhuizen
On Thu, Jul 26, 2018 at 5:01 PM, Emil Velikov wrote: > Hi Bas, > > Pardon for joining so late. > > On 18 July 2018 at 13:01, Bas Nieuwenhuizen wrote: >> radv always needs it, so just check the header instead. Also >> do not declare the function if the variable is not set, so we >> get a nice comp

Re: [Mesa-dev] [PATCH] util/disk_cache: Fix disk_cache_get_function_timestamp with disabled cache.

2018-07-26 Thread Bas Nieuwenhuizen
On Thu, Jul 26, 2018 at 5:15 PM, Bas Nieuwenhuizen wrote: > On Thu, Jul 26, 2018 at 5:01 PM, Emil Velikov > wrote: >> Hi Bas, >> >> Pardon for joining so late. >> >> On 18 July 2018 at 13:01, Bas Nieuwenhuizen wrote: >>> radv always needs it, so just check the header instead. Also >>> do not de

Re: [Mesa-dev] [PATCH 3/4] android: radv: add Android.mk for vulkan.radv HAL module

2018-07-26 Thread Mauro Rossi
Hello there, Il giorno gio 26 lug 2018 alle ore 17:09 Mauro Rossi ha scritto: > > Hi Emil, > > Il giorno gio 26 lug 2018 alle ore 16:48 Emil Velikov > ha scritto: > > > > On 22 July 2018 at 09:14, Mauro Rossi wrote: > > > radv implements the Android Vulkan HAL interface, this patch adds > > > An

Re: [Mesa-dev] [PATCH] util/disk_cache: Fix disk_cache_get_function_timestamp with disabled cache.

2018-07-26 Thread Emil Velikov
On 26 July 2018 at 16:25, Bas Nieuwenhuizen wrote: > On Thu, Jul 26, 2018 at 5:15 PM, Bas Nieuwenhuizen > wrote: >> On Thu, Jul 26, 2018 at 5:01 PM, Emil Velikov >> wrote: >>> Hi Bas, >>> >>> Pardon for joining so late. >>> >>> On 18 July 2018 at 13:01, Bas Nieuwenhuizen >>> wrote: radv

Re: [Mesa-dev] [PATCH 3/4] android: radv: add Android.mk for vulkan.radv HAL module

2018-07-26 Thread Emil Velikov
On 26 July 2018 at 16:32, Mauro Rossi wrote: > Hello there, > Il giorno gio 26 lug 2018 alle ore 17:09 Mauro Rossi > ha scritto: >> >> Hi Emil, >> >> Il giorno gio 26 lug 2018 alle ore 16:48 Emil Velikov >> ha scritto: >> > >> > On 22 July 2018 at 09:14, Mauro Rossi wrote: >> > > radv implement

[Mesa-dev] [PATCH 03/12] nir/print: Remove a bogus assert

2018-07-26 Thread Jason Ekstrand
In 1beef89ad85c47fb6, we made a bunch of changes to NIR to allow for more than four components. This assert was added to trigger if we ever saw a vec16 input variable. However, it didn't take into account the fact that we can get matrices as input/output variables and they break this assumption w

[Mesa-dev] [PATCH 01/12] util/list: Make some helpers take const lists

2018-07-26 Thread Jason Ekstrand
They're all just querying things about the list and not mutating anything. --- src/util/list.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/list.h b/src/util/list.h index 6edb7501109..09d1b4cae64 100644 --- a/src/util/list.h +++ b/src/util/list.h @@ -72,7 +7

[Mesa-dev] [PATCH 02/12] nir: Take if uses into account in ssa_def_components_read

2018-07-26 Thread Jason Ekstrand
Fixes: d800b7daa5440 "nir: Add a helper for figuring out what..." --- src/compiler/nir/nir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index bc7f05b3e86..a849664134f 100644 --- a/src/compiler/nir/nir.c +++ b/src/compiler/nir/nir.c @@ -14

[Mesa-dev] [PATCH 00/12] nir: Add some optimizations on variables

2018-07-26 Thread Jason Ekstrand
This series adds some optimizations on variables to try and help shaders with indirects where we can't just throw the variables away and use SSA. The particular motivation of this series is the tessellation control shaders in Batman: Arkham City as translated by DXVK. When DXVK translates a tessel

[Mesa-dev] [PATCH 07/12] nir: Add an array splitting pass

2018-07-26 Thread Jason Ekstrand
This pass looks for array variables where at least one level of the array is never indirected and splits it into multiple smaller variables. --- src/compiler/nir/nir.h| 1 + src/compiler/nir/nir_split_vars.c | 525 ++ 2 files changed, 526 insertions(+) di

[Mesa-dev] [PATCH 10/12] intel/nir: Use narrow_vec_vars

2018-07-26 Thread Jason Ekstrand
--- src/intel/compiler/brw_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c index 96ad77c3906..506051d6419 100644 --- a/src/intel/compiler/brw_nir.c +++ b/src/intel/compiler/brw_nir.c @@ -542,6 +542,7 @@ brw_nir_optimize(nir_shad

[Mesa-dev] [PATCH 08/12] intel/nir: Use the new structure and array splitting passes

2018-07-26 Thread Jason Ekstrand
--- src/intel/compiler/brw_nir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c index 5990427b731..96ad77c3906 100644 --- a/src/intel/compiler/brw_nir.c +++ b/src/intel/compiler/brw_nir.c @@ -541,6 +541,7 @@ brw_nir_optimize(nir_sh

[Mesa-dev] [PATCH 06/12] nir: Add a structure splitting pass

2018-07-26 Thread Jason Ekstrand
--- src/compiler/Makefile.sources | 1 + src/compiler/nir/meson.build | 1 + src/compiler/nir/nir.h| 1 + src/compiler/nir/nir_split_vars.c | 271 ++ 4 files changed, 274 insertions(+) create mode 100644 src/compiler/nir/nir_split_vars.c dif

[Mesa-dev] [PATCH 04/12] nir/instr_set: Fix nir_instrs_equal for derefs

2018-07-26 Thread Jason Ekstrand
We weren't returning at the end of the nir_isntr_type_deref case in nir_instrs_equal and it was falling through to the default of false. While we're at it, make the default unreachable because all statements in the switch now have their own returns. Had we done that before, we would have caught th

[Mesa-dev] [PATCH 11/12] nir: Add an array copy optimization

2018-07-26 Thread Jason Ekstrand
This peephole optimization looks for a series of load/store_deref or copy_deref instructions that copy an array from one variable to another and turns it into a copy_deref that copies the entire array. The pattern it looks for is extremely specific but it's good enough to pick up on the input arra

[Mesa-dev] [PATCH 09/12] nir: Add a array-of-vector variable narrowing pass

2018-07-26 Thread Jason Ekstrand
This pass looks for variables with vector or array-of-vector types and narrows the type to only the components used. --- src/compiler/nir/nir.h| 1 + src/compiler/nir/nir_split_vars.c | 530 +- 2 files changed, 523 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 05/12] nir/types: Add array_or_matrix helpers

2018-07-26 Thread Jason Ekstrand
--- src/compiler/nir_types.cpp | 15 +++ src/compiler/nir_types.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 3a3864414f3..c6f30368c95 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/nir_types.cpp @

[Mesa-dev] [PATCH 12/12] intel/nir: Enable nir_opt_find_array_copies

2018-07-26 Thread Jason Ekstrand
We have to be a bit careful with this one because we want it to run in the optimization loop but only in the first brw_nir_optimize call. Later calls assume that we've lowered away copy_deref instructions and we don't want to introduce any more. --- src/intel/compiler/brw_nir.c | 16 +-

Re: [Mesa-dev] [PATCH v2] nir/gather_info: Set info.gs.uses_streams

2018-07-26 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Jul 24, 2018 at 6:28 AM Alejandro Piñeiro wrote: > From: Neil Roberts > > Whenever a non-zero stream is written to it now sets uses_streams to > true. This reflects the code in validate_geometry_shader_emissions for > GLSL. > > v2: set uses_streams at gather

Re: [Mesa-dev] [PATCH mesa] anv: don't crash on vkDestroyDevice(NULL)

2018-07-26 Thread Jason Ekstrand
On Thu, Jul 26, 2018 at 2:26 AM Eric Engestrom wrote: > On Thursday, 2018-07-26 02:03:58 -0700, Jason Ekstrand wrote: > > On Thu, Jul 26, 2018 at 1:50 AM Eric Engestrom > > > wrote: > > > > > On Wednesday, 2018-07-25 14:00:29 -0700, Dylan Baker wrote: > > > > Quoting Eric Engestrom (2018-07-25 1

[Mesa-dev] [Bug 107388] GTK Apps severely glitching after updating from 18.1.3 to 18.1.4

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107388 Bug ID: 107388 Summary: GTK Apps severely glitching after updating from 18.1.3 to 18.1.4 Product: Mesa Version: 18.0 Hardware: x86-64 (AMD64) OS: Linux (Al

Re: [Mesa-dev] [PATCH 01/12] util/list: Make some helpers take const lists

2018-07-26 Thread Thomas Helland
This is: Reviewed-by: Thomas Helland 26. jul. 2018 18.04 skrev "Jason Ekstrand" : They're all just querying things about the list and not mutating anything. --- src/util/list.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/list.h b/src/util/list.h index 6ed

[Mesa-dev] [Bug 107388] GTK Apps severely glitching after updating from 18.1.3 to 18.1.4

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107388 Michel Dänzer changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |intel-3d-bugs@lists.freedes

Re: [Mesa-dev] [PATCH] util/disk_cache: Fix disk_cache_get_function_timestamp with disabled cache.

2018-07-26 Thread Bas Nieuwenhuizen
On Thu, Jul 26, 2018 at 5:55 PM, Emil Velikov wrote: > On 26 July 2018 at 16:25, Bas Nieuwenhuizen wrote: >> On Thu, Jul 26, 2018 at 5:15 PM, Bas Nieuwenhuizen >> wrote: >>> On Thu, Jul 26, 2018 at 5:01 PM, Emil Velikov >>> wrote: Hi Bas, Pardon for joining so late. On

[Mesa-dev] [Bug 106156] [TRACKER] Mesa 18.2 feature tracker

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106156 Andrés Gómez García changed: What|Removed |Added CC||mario.klei...@tuebingen.mpg

[Mesa-dev] [Bug 107369] "volatile" in OpenCL code not recognized by POLARIS10 and KABINI

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107369 --- Comment #5 from Aaron Watry --- I reverted llvm to the 6.0.0 version packaged in the padoka ppa (from my 7.0svn build) and libclc to the package manager's version and managed to reproduce the failure. Failing versions: libclc: 0.2.0+git20

Re: [Mesa-dev] [PATCH 02/12] nir: Take if uses into account in ssa_def_components_read

2018-07-26 Thread Caio Marcelo de Oliveira Filho
This patch as-is is Reviewed-by: Caio Marcelo de Oliveira Filho but consider the question below. On Thu, Jul 26, 2018 at 08:59:58AM -0700, Jason Ekstrand wrote: > Fixes: d800b7daa5440 "nir: Add a helper for figuring out what..." > --- > src/compiler/nir/nir.c | 3 +++ > 1 file changed, 3 inser

Re: [Mesa-dev] [PATCH 04/12] nir/instr_set: Fix nir_instrs_equal for derefs

2018-07-26 Thread Caio Marcelo de Oliveira Filho
This patch is Reviewed-by: Caio Marcelo de Oliveira Filho On Thu, Jul 26, 2018 at 09:00:00AM -0700, Jason Ekstrand wrote: > We weren't returning at the end of the nir_isntr_type_deref case in > nir_instrs_equal and it was falling through to the default of false. > While we're at it, make the d

Re: [Mesa-dev] [PATCH 04/12] nir/instr_set: Fix nir_instrs_equal for derefs

2018-07-26 Thread Thomas Helland
This is: Reviewed-by: Thomas Helland 2018-07-26 18:00 GMT+02:00 Jason Ekstrand : > We weren't returning at the end of the nir_isntr_type_deref case in > nir_instrs_equal and it was falling through to the default of false. > While we're at it, make the default unreachable because all statements > i

Re: [Mesa-dev] [PATCH 03/12] nir/print: Remove a bogus assert

2018-07-26 Thread Thomas Helland
This is already fixed in master it seems 2018-07-26 17:59 GMT+02:00 Jason Ekstrand : > In 1beef89ad85c47fb6, we made a bunch of changes to NIR to allow for > more than four components. This assert was added to trigger if we ever > saw a vec16 input variable. However, it didn't take into account

Re: [Mesa-dev] [PATCH 05/12] nir/types: Add array_or_matrix helpers

2018-07-26 Thread Thomas Helland
This patch is: Reviewed-by: Thomas Helland 2018-07-26 18:00 GMT+02:00 Jason Ekstrand : > --- > src/compiler/nir_types.cpp | 15 +++ > src/compiler/nir_types.h | 2 ++ > 2 files changed, 17 insertions(+) > > diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp > ind

[Mesa-dev] [Bug 107369] "volatile" in OpenCL code not recognized by POLARIS10 and KABINI

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107369 --- Comment #6 from Aaron Watry --- Passing "-fstack-protector-strong" into clang_bc_flags is what's breaking libclc for debian. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-26 Thread Rob Herring
On Wed, Jul 25, 2018 at 1:52 PM John Stultz wrote: > > On Wed, Jul 25, 2018 at 5:42 AM, Emil Velikov > wrote: > > On 25 July 2018 at 00:21, John Stultz wrote: > >> From: Yong Yao > >> > >> This is a forward port of a patch from the AOSP/master branch: > >> https://android.googlesource.com/plat

[Mesa-dev] [Bug 107369] "volatile" in OpenCL code not recognized by POLARIS10 and KABINI

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107369 --- Comment #7 from Gian-Carlo Pascutto --- Nice debugging. Is this LLVM miscompiling the library, or LLVM trying to do stack protection on AMD GCN code? -- You are receiving this mail because: You are the assignee for the bug. You are the QA

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-26 Thread John Stultz
On Thu, Jul 26, 2018 at 6:46 AM, Emil Velikov wrote: > On 25 July 2018 at 20:52, John Stultz wrote: >> On Wed, Jul 25, 2018 at 5:42 AM, Emil Velikov >> wrote: >>> On 25 July 2018 at 00:21, John Stultz wrote: From: Yong Yao This is a forward port of a patch from the AOSP/master

Re: [Mesa-dev] [PATCH 02/12] nir: Take if uses into account in ssa_def_components_read

2018-07-26 Thread Jason Ekstrand
On Thu, Jul 26, 2018 at 9:38 AM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > This patch as-is is > > Reviewed-by: Caio Marcelo de Oliveira Filho > > but consider the question below. > > On Thu, Jul 26, 2018 at 08:59:58AM -0700, Jason Ekstrand wrote: > > Fixes: d800b7daa5440

Re: [Mesa-dev] [PATCH v3] dri3: For 1.2, use root window instead of pixmap drawable

2018-07-26 Thread Eric Anholt
Olivier Fourdan writes: > get_supported_modifiers() and pixmap_from_buffers() requests both > expect a window as drawable, passing a pixmap will fail as the Xserver > will fail to match the given drawable to a window. > > That leads to dri3_alloc_render_buffer() to return NULL and breaks > render

Re: [Mesa-dev] [PATCH 06/12] nir: Add a structure splitting pass

2018-07-26 Thread Caio Marcelo de Oliveira Filho
On Thu, Jul 26, 2018 at 09:00:02AM -0700, Jason Ekstrand wrote: > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/meson.build | 1 + > src/compiler/nir/nir.h| 1 + > src/compiler/nir/nir_split_vars.c | 271 ++ > 4 files changed,

Re: [Mesa-dev] [PATCH v2] clover: Reduce wait_count in abort path.

2018-07-26 Thread Francisco Jerez
Jan Vesely writes: > Trigger waiter condition variable. > Passes 'events' CTS on carrizo and turks. > v2: reduce to 0 > > Signed-off-by: Jan Vesely Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/core/event.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] clover: Don't extend illegal integer types.

2018-07-26 Thread Francisco Jerez
Jan Vesely writes: > It's OK to pass them in memory, which is what kernel invocation needs. > Fixes AMDGCN regressions since llvm r337535 ("Reapply "AMDGPU: Fix handling > of alignment padding in DAG argument lowering"): > scalar-arithmetic-char > scalar-arithmetic-uchar > scal

Re: [Mesa-dev] [PATCH 1/2] intel/fs: New method for register_byte_use_pattern for fs_inst

2018-07-26 Thread Francisco Jerez
Chema Casanova writes: > El 20/07/18 a las 22:10, Francisco Jerez escribió: >> Chema Casanova writes: >> >>> El 20/07/18 a las 00:34, Francisco Jerez escribió: Chema Casanova writes: > El 14/07/18 a las 00:14, Francisco Jerez escribió: >> Jose Maria Casanova Crespo writes: >

[Mesa-dev] [PATCH 1/3 v2] util: Android.mk: Convert implicit rules to static pattern rules

2018-07-26 Thread John Stultz
From: Dan Willemsen This is a partial cherry-pick from AOSP's mesa3d tree: https://android.googlesource.com/platform/external/mesa3d/+/a88dcf769eb00a4ffc7183a0396d881a28b5a29b%5E%21/ "We're deprecating make implicit rules, preferring static pattern rules, or just regular rules." Without this

[Mesa-dev] [PATCH 3/3 v2] CleanSpec.mk: Remove HOST_OUT_release

2018-07-26 Thread John Stultz
From: Dan Willemsen This is a forward port of a patch from the AOSP/master tree: https://android.googlesource.com/platform/external/mesa3d/+/bd633f11de0c6ac1ed333a28344c74fd9898df9e%5E%21/ Which replaces HOST_OUT_release with HOST_OUT As per Dan's explanation, the current code was incorrect to

[Mesa-dev] [PATCH 2/3 v2] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-26 Thread John Stultz
From: Sumit Semwal This is a forward port of a patch from the AOSP/master tree: https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b0%5E%21/ Since https://android-review.googlesource.com/c/718518 added timespec_get() to bionic, mesa3d doesn't build

Re: [Mesa-dev] [PATCH 0/7] ASTC texture compression for all Gallium drivers

2018-07-26 Thread Marek Olšák
FYI, I'd like to include this in Mesa 18.2, which means I'll push this on Monday July 30 if there is no review. Marek On Mon, Jul 23, 2018 at 7:52 PM, Marek Olšák wrote: > Hi, > > This series enables ASTC texture compression for all Gallium drivers > that don't support it in hardware. The works

Re: [Mesa-dev] [PATCH 06/12] nir: Add a structure splitting pass

2018-07-26 Thread Thomas Helland
2018-07-26 18:00 GMT+02:00 Jason Ekstrand : > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/meson.build | 1 + > src/compiler/nir/nir.h| 1 + > src/compiler/nir/nir_split_vars.c | 271 ++ > 4 files changed, 274 insertions(+) >

Re: [Mesa-dev] [PATCH v2 1/2] egl/surfaceless: Define DRI_SWRastLoader extension when using swrast.

2018-07-26 Thread David Riley
On Thu, Jul 26, 2018 at 7:22 AM Emil Velikov wrote: > Hi David, > > On 18 July 2018 at 01:12, David Riley wrote: > > Commit message here should explain why this is needed. Is the current > kms_swrast usage failing/crashing somewhere, etc. > The change wasn't needed for kms_swrast, just for swra

Re: [Mesa-dev] [PATCH 2/3 v2] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-26 Thread Rob Herring
Resending from correct email... On Thu, Jul 26, 2018 at 12:28 PM John Stultz wrote: > > From: Sumit Semwal > > This is a forward port of a patch from the AOSP/master tree: > https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b0%5E%21/ > > Since http

Re: [Mesa-dev] [PATCH 2/3 v2] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-26 Thread John Stultz
On Thu, Jul 26, 2018 at 12:09 PM, Rob Herring wrote: > Resending from correct email... > > On Thu, Jul 26, 2018 at 12:28 PM John Stultz wrote: >> >> From: Sumit Semwal >> >> This is a forward port of a patch from the AOSP/master tree: >> https://android.googlesource.com/platform/external/mesa3d/

Re: [Mesa-dev] [PATCH v3 1/3] glsl: teach copy_propagation_elements to deal with whole variables

2018-07-26 Thread Thomas Helland
2018-07-25 3:03 GMT+02:00 Caio Marcelo de Oliveira Filho : > Keep information in acp_entry whether the entry is full or not, and > use the ACP in more nodes when visiting the instructions: > > - add_copy: write whole variables to the ACP state (regardless the > type). > > - visit(ir_dereference_v

[Mesa-dev] [Bug 107385] full Screen Corruption when a program is fullscreen

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107385 --- Comment #7 from monkeyinastripedsh...@gmail.com --- >xserver-xorg-video-radeon:amd64 (1:18.0.1-1, >1:18.0.1+git1807201017.64bd00~oibaf~b) The update is downloading right now and I'll let you know as soon as I've tested it. -- You are rece

Re: [Mesa-dev] [PATCH v3 2/3] glsl: use only copy_propagation_elements

2018-07-26 Thread Thomas Helland
This is: Reviewed-by: Thomas Helland 2018-07-25 3:03 GMT+02:00 Caio Marcelo de Oliveira Filho : > Now that the elements version handles both cases, remove the > non-elements version. > > Reviewed-by: Eric Anholt > --- > src/compiler/Makefile.sources | 1 - > src/compiler/glsl/glsl

Re: [Mesa-dev] [PATCH 07/12] nir: Add an array splitting pass

2018-07-26 Thread Jason Ekstrand
FYI, after further consideration, I've started reworking this pass to also be able to shorten arrays even if it can't split them. Probably best to wait on review for v2. On July 26, 2018 09:00:57 Jason Ekstrand wrote: This pass looks for array variables where at least one level of the array

Re: [Mesa-dev] [PATCH v3 3/3] glsl: propagate full variables eagerly

2018-07-26 Thread Thomas Helland
Since we're always going top-down through the program there should be no need to "walk backwards", so this approach should be enough to get the whole chain of assignments in one pass. Neat. Reviewed-by: Thomas Helland 2018-07-25 3:03 GMT+02:00 Caio Marcelo de Oliveira Filho : > When creating a ne

Re: [Mesa-dev] [PATCH] clover: Don't extend illegal integer types.

2018-07-26 Thread Jan Vesely
On Thu, 2018-07-26 at 10:51 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > It's OK to pass them in memory, which is what kernel invocation needs. > > Fixes AMDGCN regressions since llvm r337535 ("Reapply "AMDGPU: Fix handling > > of alignment padding in DAG argument lowering"): > >

[Mesa-dev] [Bug 107385] full Screen Corruption when a program is fullscreen

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107385 --- Comment #8 from monkeyinastripedsh...@gmail.com --- Created attachment 140844 --> https://bugs.freedesktop.org/attachment.cgi?id=140844&action=edit Xorg log Unfortunately no, `1:18.0.1+git1807251933.fed411~oibaf~b` does not solve the probl

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

2018-07-26 Thread Chad Versace
On Wed 25 Jul 2018, Tomasz Figa wrote: > Hi Chad, > > On Wed, Jul 25, 2018 at 10:11 AM Chad Versace > wrote: > > > > Problem 1: u_debug_stack_android.cpp transitively included > > "pipe/p_compiler.h", but src/gallium/include was missing from the C++ > > include path. > > > > Problem 2: Add -std=

[Mesa-dev] [Bug 107391] feature request: enforceable vsync and anisotropic filtering via environment variables

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107391 Bug ID: 107391 Summary: feature request: enforceable vsync and anisotropic filtering via environment variables Product: Mesa Version: unspecified Hardware: x86-64 (AMD64)

[Mesa-dev] [PATCH] intel_stub: Claim to support I915_PARAM_HAS_CONTEXT_ISOLATION.

2018-07-26 Thread Kenneth Graunke
Modern kernels support I915_PARAM_HAS_CONTEXT_ISOLATION, which allows us to whack certain context registers with impunity. One of those is INSTPM/CS_DEBUG_MODE2, which controls whether Constant Buffer 0 is relative to dynamic state base address, or a general GPU address. If it's relative (the defa

[Mesa-dev] [Bug 107351] Android 8.1: radv segfault with 3Dmark vulkan benchmarks

2018-07-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107351 --- Comment #11 from Mauro Rossi --- Hi Bas, thanks for your instructions I've tracked the line crashing in the radv_image.c file in master branch utente@utente-MS-7576:~/oreo-x86_hwc1$ addr2line -Cfe out/target/product/x86_64/symbols/system/

Re: [Mesa-dev] [PATCH v2 2/2] egl/surfaceless: Allow DRMless fallback.

2018-07-26 Thread David Riley
On Thu, Jul 26, 2018 at 7:30 AM Emil Velikov wrote: > Hi David, > > Hi Emil, Thanks for the comments. > On 18 July 2018 at 01:12, David Riley wrote: > > Allow platform_surfaceless to use swrast even if DRM is not available. > > To be used to allow a fuzzer for virgl to be run on a jailed VM w

[Mesa-dev] [PATCH 2/3 v3] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-26 Thread John Stultz
From: Sumit Semwal This is a forward port of a patch from the AOSP/master tree: https://android.googlesource.com/platform/external/mesa3d/+/bd30b663f55f8af73a0be4446349c5a2d4c641b0%5E%21/ Since https://android-review.googlesource.com/c/718518 added timespec_get() to bionic, mesa3d doesn't build

Re: [Mesa-dev] [PATCH 1/2] intel/fs: New method for register_byte_use_pattern for fs_inst

2018-07-26 Thread Chema Casanova
El 26/07/18 a las 20:02, Francisco Jerez escribió: > Chema Casanova writes: > >> El 20/07/18 a las 22:10, Francisco Jerez escribió: >>> Chema Casanova writes: >>> El 20/07/18 a las 00:34, Francisco Jerez escribió: > Chema Casanova writes: > >> El 14/07/18 a las 00:14, Francisco

  1   2   >