[Mesa-dev] [PATCH 2/4] radv: generate entrypoints for VK_ANDROID_native_buffer

Patch changes radv entrypoints generator to not skip this extension even though it is set as disabled in the vk.xml Reference: 63525ba730 ("android: enable VK_ANDROID_native_buffer") Fixes: 69f447553c ("vulkan: Drop vk_android_native_buffer.xml") Signed-off-by: Mauro Rossi --- src/amd/vulkan/rad

[Mesa-dev] [PATCH 4/4] android: radv: enable build of vulkan.radv HAL module

src/amd/Android.mk requires to include src/amd/vulkan/Android.mk to enable the build of vulkan.radv module Signed-off-by: Mauro Rossi --- src/amd/Android.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/Android.mk b/src/amd/Android.mk index 07af05287f..6129e360cb 100644 --- a/src/a

[Mesa-dev] [PATCH 3/4] android: radv: add Android.mk for vulkan.radv HAL module

radv implements the Android Vulkan HAL interface, this patch adds Android.mk building rules by porting of radv automake rules. vendor HAL module is installed as /vendor/lib/hw/vulkan.radv.so Signed-off-by: Mauro Rossi --- src/amd/vulkan/Android.mk | 166 ++ 1

[Mesa-dev] android: add support for vulkan radv

The following series adds support for vulkan radv for Android 8.1 [PATCH 1/4] radv: move vk_format_table.c to generated sources [PATCH 2/4] radv: generate entrypoints for VK_ANDROID_native_buffer [PATCH 3/4] android: radv: add Android.mk for vulkan.radv HAL module [PATCH 4/4] android: radv: enable

[Mesa-dev] [PATCH 1/4] radv: move vk_format_table.c to generated sources

Android build system will try to compile vk_format_table.c as a shipped source, but at compile time it will be missing, we move it to generated source, where it belongs Signed-off-by: Mauro Rossi --- src/amd/vulkan/Makefile.sources | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [Mesa-dev] [PATCH 03/10] nir: allow more nested loops to be unrolled

On Tue, Jul 10, 2018 at 11:49 PM Timothy Arceri wrote: > The innermost check was added to stop us from unrolling multiple > loops in a single pass, and to stop outer loops from unrolling. > Do you mean "multiple nested loops in a single pass..."? > When we successfully unroll a loop we need to

Re: [Mesa-dev] [PATCH 07/10] nir: add loop unroll support for wrapper loops

On Tue, Jul 10, 2018 at 11:49 PM Timothy Arceri wrote: > This adds support for unrolling the classic > > do { > // ... > } while (false) > > that is used to wrap multi-line macros. GLSL IR also wraps switch > statements in a loop like this. > > shader-db results IVB: > > total loo

[Mesa-dev] [Bug 105328] Can't include gl and gles headers simultaneously on non-64 bit architectures

https://bugs.freedesktop.org/show_bug.cgi?id=105328 Adrian Perez de Castro changed: What|Removed |Added CC||ago...@igalia.com,

Re: [Mesa-dev] [PATCH] virgl: Allow RGB32* textures only as buffer objects

On Sun, Jul 22, 2018 at 2:54 AM, Gert Wollny wrote: > Am Samstag, den 21.07.2018, 14:14 -0400 schrieb Ilia Mirkin: >> On Sat, Jul 21, 2018 at 1:48 PM, Gert Wollny > om> wrote: >> > Am Samstag, den 21.07.2018, 11:33 -0400 schrieb Ilia Mirkin: >> > > >> > > >> > > On Sat, Jul 21, 2018, 05:45 Gert Wo

Re: [Mesa-dev] [PATCH] virgl: Allow RGB32* textures only as buffer objects

Am Sonntag, den 22.07.2018, 09:59 -0400 schrieb Ilia Mirkin: > On Sun, Jul 22, 2018 at 2:54 AM, Gert Wollny om> wrote: > > Am Samstag, den 21.07.2018, 14:14 -0400 schrieb Ilia Mirkin: > > > On Sat, Jul 21, 2018 at 1:48 PM, Gert Wollny > > ra.c > > > om> wrote: > > > > Am Samstag, den 21.07.2018,

Re: [Mesa-dev] [PATCH 2/4] radv: generate entrypoints for VK_ANDROID_native_buffer

Patches 1-2 are Reviewed-by: Bas Nieuwenhuizen On Sun, Jul 22, 2018 at 10:14 AM, Mauro Rossi wrote: > Patch changes radv entrypoints generator to not skip this extension even > though it is set as disabled in the vk.xml > > Reference: 63525ba730 ("android: enable VK_ANDROID_native_buffer") > Fi

Re: [Mesa-dev] [PATCH] mesa: Fix copy-paste error in ConservativeRasterDilateRange initialization

Reviewed-by: Rhys Perry I'm not sure how much that's worth though, so I think I'll wait a few days being pushing it (I assume you can't push it) and see if anyone objects. On Wed, Jul 18, 2018 at 9:58 AM, Danylo Piliaiev wrote: > Signed-off-by: Danylo Piliaiev > --- > src/mesa/main/context.c

Re: [Mesa-dev] [PATCH] intel/blorp: Fix blits to R8G8B8_UNORM_SRGB sRGB harder

On 21/07/18 07:12, Jason Ekstrand wrote: The first fix attempt contained a nasty typo which somehow didn't get caught in review. It also didn't work as intended because the sRGB conversion was happening but then throwing away all but the red channel because it dind't know it was RGB. Really, it

Re: [Mesa-dev] [PATCH] anv: Properly handle GetImageSubresourceLayout on complex images

Reviewed-by: Lionel Landwerlin On 20/07/18 22:51, Jason Ekstrand wrote: We support mipmapped and arrayed linear images so we need to support vkGetImageSubresourceLayout on them. Fortunately, it's just a trivial call into ISL. --- src/intel/vulkan/anv_image.c | 23 --- 1

Re: [Mesa-dev] [PATCH 1/2] i965/disk_cache: Add extra unused character in renderer temp string

Reviewed-by: Lionel Landwerlin On 22/07/18 05:45, Jordan Justen wrote: This extra character should not be used by snprintf, but we make it available to verify that we printed the exact number we wanted, and didn't overflow. Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/brw_disk

Re: [Mesa-dev] [PATCH 2/2] i965/disk_cache: Add in the INTEL_DEBUG value to the renderer string

Nice catch! Reviewed-by: Lionel Landwerlin On 22/07/18 05:45, Jordan Justen wrote: Since various options within INTEL_DEBUG could impact code generation, we should add this into the renderer string so changing the INTEL_DEBUG setting will cause the shader cache to work properly. An example th

Re: [Mesa-dev] [PATCH] intel/blorp: Fix blits to R8G8B8_UNORM_SRGB sRGB harder

On Sun, Jul 22, 2018 at 1:23 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 21/07/18 07:12, Jason Ekstrand wrote: > > The first fix attempt contained a nasty typo which somehow didn't get > > caught in review. It also didn't work as intended because the sRGB > > conversion was

Re: [Mesa-dev] [PATCH 1/2] spirv: add support for SPV_KHR_post_depth_coverage

I've added my Reviewed-by: Jason Ekstrand and pushed the patches. Thanks, Ilia, for writing them and thanks, Yunchao, for rebasing them and finding the tests. --Jason On Fri, Jul 20, 2018 at 5:16 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Thanks for the changes, this seri

Re: [Mesa-dev] [PATCH 2/2] i965/disk_cache: Add in the INTEL_DEBUG value to the renderer string

On 2018-07-22 13:43:08, Lionel Landwerlin wrote: > Nice catch! > > Reviewed-by: Lionel Landwerlin Thanks! Tim pointed out on irc that disk_cache_create has a driver_flags param just for this purpose. Also, Jason asked that I update the Anvil driver too. I'll try to send out a v2 today. -Jordan

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

On 20 July 2018 at 21:13, Gert Wollny wrote: > There still seem to be a few quirks (see below) > > Best, >> >> diff --git a/src/gallium/drivers/virgl/virgl_buffer.c >> >> +static void virgl_set_shader_buffers(struct pipe_context *ctx, >> + enum pipe_shader_typ

Re: [Mesa-dev] [PATCH 03/10] nir: allow more nested loops to be unrolled

On 22/07/18 19:32, Jason Ekstrand wrote: On Tue, Jul 10, 2018 at 11:49 PM Timothy Arceri > wrote: The innermost check was added to stop us from unrolling multiple loops in a single pass, and to stop outer loops from unrolling. Do you mean "multiple nested

Re: [Mesa-dev] [PATCH 07/10] nir: add loop unroll support for wrapper loops

On 22/07/18 19:50, Jason Ekstrand wrote: On Tue, Jul 10, 2018 at 11:49 PM Timothy Arceri > wrote: This adds support for unrolling the classic     do {         // ...     } while (false) that is used to wrap multi-line macros. GLSL IR also wr

Re: [Mesa-dev] android: add support for vulkan radv

Patches 1-2 are Reviewed-by: Bas Nieuwenhuizen Patches 3-4 are Acked-by: Bas Nieuwenhuizen but I'm not that knowledgeable about the Android build system. On Sun, Jul 22, 2018 at 10:14 AM, Mauro Rossi wrote: > The following series adds support for vulkan radv for Android 8.1 > > [PATCH 1/4]

[Mesa-dev] [PATCH v2 1/2] i965, anv: Add extra unused character in disk_cache renderer temp string

This extra character should not be used by snprintf, but we make it available to verify that we printed the exact number we wanted, and didn't overflow. v2: * Also update Anvil Signed-off-by: Jordan Justen Reviewed-by: Lionel Landwerlin (v1) --- src/intel/vulkan/anv_device.c | 4

[Mesa-dev] [PATCH v2 2/2] i965, anv: Use INTEL_DEBUG for disk_cache driver flags

Since various options within INTEL_DEBUG could impact code generation, we need to set the disk cache driver_flags parameter based on the INTEL_DEBUG flags in use. An example that will affect the program generated by i965 is the INTEL_DEBUG=nocompact option. The DEBUG_DISK_CACHE_MASK value is adde

Re: [Mesa-dev] [PATCH] intel/compiler: fix lower conversions to account for predication

This is still pending review, any takers? Iago On Tue, 2018-07-17 at 11:10 +0200, Iago Toral Quiroga wrote: > The pass can create a temporary result for the instruction and then > moves from it to the original destination, however, if the original > instruction was predicated, the mov has to be p

Re: [Mesa-dev] [PATCH v2 1/2] i965, anv: Add extra unused character in disk_cache renderer temp string

Acked-by: Jason Ekstrand On Sun, Jul 22, 2018 at 9:28 PM Jordan Justen wrote: > This extra character should not be used by snprintf, but we make it > available to verify that we printed the exact number we wanted, and > didn't overflow. > > v2: > * Also update Anvil > > Signed-off-by: Jordan J

Re: [Mesa-dev] [PATCH v2 2/2] i965, anv: Use INTEL_DEBUG for disk_cache driver flags

This is better but there are still environment variables that affect compilation. For instance, the INTEL_SCALAR_VS/TCS/TES/GS environment variables. On Sun, Jul 22, 2018 at 9:28 PM Jordan Justen wrote: > Since various options within INTEL_DEBUG could impact code generation, > we need to set th

Re: [Mesa-dev] [PATCH] virgl: add initial shader_storage_buffer_object support. (v2)

Am Montag, den 23.07.2018, 09:04 +1000 schrieb Dave Airlie: > > > > + uint32_t max_shader_buffer = shader == PIPE_SHADER_FRAGMENT ? > > > + rs->caps.caps.v2.max_shader_buffer_frag_compute : > > > > Shouldn't max_shader_buffer_frag_compute also be used for > > PIPE_SHADER_COMPUTE? > > virg

Re: [Mesa-dev] [PATCH 07/10] nir: add loop unroll support for wrapper loops

On 22/07/18 19:50, Jason Ekstrand wrote: On Tue, Jul 10, 2018 at 11:49 PM Timothy Arceri > wrote: This adds support for unrolling the classic     do {         // ...     } while (false) that is used to wrap multi-line macros. GLSL IR also wr