Re: [Mesa-dev] [Mesa-stable] [PATCH] ac: fix the number of coordinates for ac_image_get_lod and arrays

2018-04-24 Thread Nicolai Hähnle
On 23.04.2018 21:45, Samuel Pitoiset wrote: On 04/23/2018 08:42 PM, Marek Olšák wrote: On Mon, Apr 23, 2018 at 1:12 PM, Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote:     On 04/23/2018 06:55 PM, Nicolai Hähnle wrote:     On 23.04.2018 17:52, Samuel Pitoiset wrote:

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

2018-04-24 Thread Johan Helsing
Emil: Your alternative patch won't work because dri_make_current is not necessarily called with NULL after a buffer has been destroyed. The problematic sequence is a pattern we use in QtWayland: //create temporary context surface1 = eglCreateWindowSurface() <-- dri_drawable pointer is malloce

[Mesa-dev] [Bug 106144] Max OpenGL window resolution

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106144 Inad changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-24 Thread Robert Foss
Hey Chih-Wei, On 04/23/2018 04:17 AM, Chih-Wei Huang wrote: What's the impact to drm_gralloc? I'm not terribly familiar with drm_gralloc, but as far as I understand it depends on flink name support at the moment. The overarching idea here is to make mesa gralloc independent, but also at the

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-24 Thread Tomasz Figa
On Tue, Apr 24, 2018 at 4:26 PM Robert Foss wrote: > Hey Chih-Wei, > On 04/23/2018 04:17 AM, Chih-Wei Huang wrote: > > What's the impact to drm_gralloc? > I'm not terribly familiar with drm_gralloc, but as far as I understand it > depends on flink name support at the moment. > The overarching

Re: [Mesa-dev] [PATCH v2] travis: update libva required version

2018-04-24 Thread Juan A. Suarez Romero
On Fri, 2018-04-20 at 16:42 +0200, Juan A. Suarez Romero wrote: > Commit fa328456e8f29 added VP9 config support, but this needs a newer > libva version, 1.7.0 or above. > > Fixes: fa328456e8f ("st/va: add VP9 config to enable profile2") Besides requesting R-B, CCing to @stable, as this fixes 18.1

[Mesa-dev] [Bug 106126] eglMakeCurrent does not always ensure dri_drawable->update_drawable_info has been called for a new EGLSurface if another has been created and destroyed first

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106126 Johan Helsing changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Mesa-dev] NIR issue with SPIRV ops that have operands with different bit-size

2018-04-24 Thread Samuel Iglesias Gonsálvez
Hello, Recently, we have found problems between some SPIRV opcodes and NIR. SPIR-V allows opcodes to mix different bit-sizes for their operands, such as for some bitfield operations and other ops like bitwise shifts. In NIR, when the ALU opcode doesn't have specified bitsizes for their operands

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

2018-04-24 Thread Michel Dänzer
On 2018-04-24 09:13 AM, Johan Helsing wrote: > Emil: Your alternative patch won't work because dri_make_current is not > necessarily called with NULL after a buffer has been destroyed. > > > The problematic sequence is a pattern we use in QtWayland: > > > //create temporary context > > surfac

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

2018-04-24 Thread Johan Helsing
If the call to dri_destroy_buffer is delayed until the next eglMakeCurrent, that would also solve the problem (I'm not sure how that would affect other things, though). As long as dri_make_current doesn't compare against a dangling pointer, I'm happy. Johan

Re: [Mesa-dev] [PATCH v2 06/12] glcpp/tests: Convert shell scripts to a python script

2018-04-24 Thread Juan A. Suarez Romero
On Fri, 2018-04-20 at 10:23 -0700, Dylan Baker wrote: > Quoting Juan A. Suarez Romero (2018-04-20 10:18:03) > > On Thu, 2018-04-05 at 14:51 -0700, Dylan Baker wrote: > > > This ports glcpp-test.sh and glcpp-test-cr-lf.sh to a python script that > > > accepts arguments for each line ending type. Thi

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

2018-04-24 Thread Daniel Stone
Hi Johan, On 24 April 2018 at 09:44, Johan Helsing wrote: > If the call to dri_destroy_buffer is delayed until the next eglMakeCurrent, > that would also solve the problem (I'm not sure how that would affect other > things, though). It _must_ be: If the EGL surface surface is not current to an

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

2018-04-24 Thread Michel Dänzer
Please don't top-post. On 2018-04-24 10:44 AM, Johan Helsing wrote: > If the call to dri_destroy_buffer is delayed until the next eglMakeCurrent, > that would also solve the problem (I'm not sure how that would affect other > things, though). Looking at the EGL spec, section 3.5.5 "Destroying R

[Mesa-dev] [Bug 106197] plasma wayland cant create platform surface with mesa 18.1.0 rc1

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106197 --- Comment #1 from Daniel Stone --- Please check the config.log or Meson output from your Mesa build to ensure that you are building with the DRM/GBM platform. -- You are receiving this mail because: You are the QA Contact for the bug.___

[Mesa-dev] [Bug 61933] Weston EGL clients hang with software rendering upon startup

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61933 Daniel Stone changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO

Re: [Mesa-dev] NIR issue with SPIRV ops that have operands with different bit-size

2018-04-24 Thread Rob Clark
On Tue, Apr 24, 2018 at 4:24 AM, Samuel Iglesias Gonsálvez wrote: > Hello, > > Recently, we have found problems between some SPIRV opcodes and NIR. > > SPIR-V allows opcodes to mix different bit-sizes for their operands, such as > for some bitfield operations and other ops like bitwise shifts. >

Re: [Mesa-dev] [PATCH 2/2] etnaviv: remove not needed includes

2018-04-24 Thread Philipp Zabel
Hi Christian, On Fri, 2018-04-20 at 14:55 +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_translate.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/gallium/drivers/etnaviv/etnaviv_translate.h > b/src/gallium/driver

[Mesa-dev] [PATCH] gm107/ir/lib: fix sched in div u32 builtin

2018-04-24 Thread Karol Herbst
Imad needs to set a read barrier. With significant big work groups I was getting wrong results for div u32. Turns out the issue was with the sched opcodes. CC: Samuel Pitoiset Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/lib/gm107.asm | 4 ++-- src/gallium/drivers/nouv

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

2018-04-24 Thread Emil Velikov
On 24 April 2018 at 08:13, Johan Helsing wrote: > Emil: Your alternative patch won't work because dri_make_current is not > necessarily called with NULL after a buffer has been destroyed. > Interesting, the trace attached in the bugreport does a proper makecurrent/surface dance. Namely, MakeCurren

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-24 Thread Emil Velikov
Hi Rob, Thanks for doing this. There's a couple of small nits, but the patch looks good IMHO. On the topic of keeping the old code behind a #define or just removing it, it'll be great if interested parties can reach a consensus. On 19 April 2018 at 22:09, Rob Herring wrote: > --- a/src/egl/dr

Re: [Mesa-dev] [PATCH] egl/android: remove flink name support

2018-04-24 Thread Emil Velikov
On 24 April 2018 at 12:28, Emil Velikov wrote: > On the topic of keeping the old code behind a #define or just removing > it, it'll be great if interested parties can reach a consensus. > Actually one can simply drop this code and drm_gralloc users can add a drm_ioctl_permit() hack. Namely: loose

[Mesa-dev] [RFC 2/3] freedreno/a5xx: update compute param handling

2018-04-24 Thread Rob Clark
Move to per-generation backend, since these are likely to be fairly generation specific, and that is nicer than having it split between freedreno_screen (for the global case) and fd5_compute (for the kernel-specific limits case) Signed-off-by: Rob Clark --- Not totally working yet, so there might

[Mesa-dev] [PATCH 1/3] clover+gallium: support per-kernel limits

2018-04-24 Thread Rob Clark
Some limits, such as max # of threads in a work-group, vary depending on the resources (ie. registers) used by a kernel. OpenCL provides clGetKernelWorkGroupInfo() for querying these kernel specific limits. To implement this properly, we need a variant of get_compute_param() which takes the comput

[Mesa-dev] [RFC 3/3] clover+gallium+freedreno: caps to reduce kernel recompiles

2018-04-24 Thread Rob Clark
Not all drivers care when cs.reg_*_mem change. (ir3 only cares about req_input_mem and removing that dependency should be easy.) Add some caps to let clover make better decisions about when it needs to re- create the compute-state CSO. This way, if the kernel is compiled early for clGetKernelWor

[Mesa-dev] [Bug 106157] [Tracker] Mesa 18.1 release tracker

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106157 --- Comment #1 from Darek --- Description: Some apps crash on startup (chromium, thunderbird, glxgears, eglgears_x11) Additional info: * package version(s) mesa-18.1.0rc1 (tested also with mesa-git-18.2.0_devel.101822.4559aefb5c)-meson build xo

[Mesa-dev] [Bug 106157] [Tracker] Mesa 18.1 release tracker

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106157 Daniel Stone changed: What|Removed |Added Component|Other |Drivers/X11 --- Comment #2 from Daniel S

[Mesa-dev] [Bug 106157] [Tracker] Mesa 18.1 release tracker

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106157 Darek changed: What|Removed |Added CC||dz1125.bug.trac...@gmail.co |

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-24 Thread Ian Romanick
On 04/23/2018 09:19 AM, Mark Janes wrote: > I enabled these tests, and could not make them fail in CI. Can I consider that a Tested-by? > This bug may also be related: > > https://bugs.freedesktop.org/show_bug.cgi?id=95009 If none of these tests fail with this patch, I'm included to close them

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-24 Thread Ian Romanick
On 04/23/2018 08:23 PM, Timothy Arceri wrote: > On 24/04/18 10:13, Dieter Nützel wrote: >> Hello Timo, >> >> what about 2 and 3, #1 landed. > > It turns out the old radeon classic drivers do make use of the param > dropped in patch 2 so I've decided to drop that patch, although the use > of that p

Re: [Mesa-dev] NIR issue with SPIRV ops that have operands with different bit-size

2018-04-24 Thread Ian Romanick
On 04/24/2018 05:44 AM, Rob Clark wrote: > On Tue, Apr 24, 2018 at 4:24 AM, Samuel Iglesias Gonsálvez > wrote: >> Hello, >> >> Recently, we have found problems between some SPIRV opcodes and NIR. >> >> SPIR-V allows opcodes to mix different bit-sizes for their operands, such as >> for some bitfie

Re: [Mesa-dev] [PATCH 1/3] mesa: some C99 tidy ups for framebuffer.c

2018-04-24 Thread Ian Romanick
Patches 1 and 3 are Reviewed-by: Ian Romanick On 04/24/2018 12:54 AM, Timothy Arceri wrote: > --- > src/mesa/main/framebuffer.c | 18 +- > 1 file changed, 5 insertions(+), 13 deletions(-) > > diff --git a/src/mesa/main/framebuffer.c b/src/mesa/main/framebuffer.c > index 249e775

Re: [Mesa-dev] NIR issue with SPIRV ops that have operands with different bit-size

2018-04-24 Thread Jason Ekstrand
On Tue, Apr 24, 2018 at 6:42 AM, Ian Romanick wrote: > On 04/24/2018 05:44 AM, Rob Clark wrote: > > On Tue, Apr 24, 2018 at 4:24 AM, Samuel Iglesias Gonsálvez > > wrote: > >> Hello, > >> > >> Recently, we have found problems between some SPIRV opcodes and NIR. > >> > >> SPIR-V allows opcodes to

[Mesa-dev] [Bug 106209] [opencl] [llvm-svn] build failure undefined reference to `clang::FrontendTimesIsEnabled'

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106209 Bug ID: 106209 Summary: [opencl] [llvm-svn] build failure undefined reference to `clang::FrontendTimesIsEnabled' Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [Bug 106209] [opencl] [llvm-svn] build failure undefined reference to `clang::FrontendTimesIsEnabled'

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106209 --- Comment #1 from LoneVVolf --- Created attachment 139055 --> https://bugs.freedesktop.org/attachment.cgi?id=139055&action=edit autoreconf output -- You are receiving this mail because: You are the assignee for the bug. You are the QA Cont

[Mesa-dev] [Bug 106209] [opencl] [llvm-svn] build failure undefined reference to `clang::FrontendTimesIsEnabled'

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106209 --- Comment #2 from LoneVVolf --- Created attachment 139056 --> https://bugs.freedesktop.org/attachment.cgi?id=139056&action=edit configure / make output -- You are receiving this mail because: You are the QA Contact for the bug. You are the

Re: [Mesa-dev] [PATCH 01/11] intel/compiler: lower 16-bit integer extended math instructions

2018-04-24 Thread Jason Ekstrand
It may be useful to just use nir_algebraic for this. We already do for trig workarounds. It's more painful from a build-system perspective but, in general, the fewer hand-rolled algebraic lowering passes we have, the better. On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga wrote: > The har

Re: [Mesa-dev] [PATCH 4/4] intel/compiler: Add scheduler deps for instructions that implicitly read g0

2018-04-24 Thread Mark Janes
Ian Romanick writes: > On 04/23/2018 09:19 AM, Mark Janes wrote: >> I enabled these tests, and could not make them fail in CI. > > Can I consider that a Tested-by? Sorry, I should have been more explicit. Yes, tested-by. >> This bug may also be related: >> >> https://bugs.freedesktop.org/show

Re: [Mesa-dev] [PATCH 01/11] intel/compiler: lower 16-bit integer extended math instructions

2018-04-24 Thread Rob Clark
side-note, not sure if it really effects what you are doing here, but karol ran into some cases, like 8bit signed imax, which needs to be "lowered" to 16b (or 32b) and converted back for hw that doesn't support smaller than 16b (or 32b). I think I have the same case with ir3, which also has 16b bu

Re: [Mesa-dev] [PATCH 02/11] intel/compiler: fix isign for 16-bit integers

2018-04-24 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga wrote: > We need to use 16-bit constants with 16-bit instructions, > otherwise we get the following validation error: > > "Destination stride must be equal to the ratio of the sizes of > the execution data type to

[Mesa-dev] [PATCH] spirv: Don’t check for NaN for most OpFOrd* comparisons

2018-04-24 Thread Neil Roberts
For all of the OpFOrd* comparisons except OpFOrdNotEqual the hardware should probably already return false if one of the operands is NaN so we don’t need to have an explicit check for it. This seems to at least work on Intel hardware. This should reduce the number of instructions generated for the

Re: [Mesa-dev] [PATCH 03/11] i965/compiler: handle conversion to smaller type in the lowering pass for that

2018-04-24 Thread Jason Ekstrand
On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga wrote: > The lowering pass was specialized to act on 64-bit to 32-bit conversions > only, > but the implementation is valid for other cases. > --- > src/intel/compiler/brw_fs_lower_conversions.cpp | 5 - > src/intel/compiler/brw_fs_nir.cp

[Mesa-dev] [PATCH 2/2] radv: enable out-of-order rasterization by default

2018-04-24 Thread Samuel Pitoiset
As the implementation is conservative, we can now enable it by default. It can be disabled with RADV_DEBUG=nooutoforder. Don't expect much more than 1% of improvements, but the gain seems consistent. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_devi

[Mesa-dev] [PATCH 1/2] radv: only disable out-of-order rast for perfect occlusion queries

2018-04-24 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 18 ++ src/amd/vulkan/radv_query.c | 4 ++-- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index baab8db617..baa28d408

Re: [Mesa-dev] [PATCH v2 06/12] glcpp/tests: Convert shell scripts to a python script

2018-04-24 Thread Dylan Baker
Quoting Juan A. Suarez Romero (2018-04-24 01:59:26) > On Fri, 2018-04-20 at 10:23 -0700, Dylan Baker wrote: > > Quoting Juan A. Suarez Romero (2018-04-20 10:18:03) > > > On Thu, 2018-04-05 at 14:51 -0700, Dylan Baker wrote: > > > > This ports glcpp-test.sh and glcpp-test-cr-lf.sh to a python script

[Mesa-dev] [PATCH 1/2] draw: simplify clip null tri logic

2018-04-24 Thread sroland
From: Roland Scheidegger Simplifies the logic when to emit null tris (albeit the reasons why we have to do this remain unclear). This is strictly just logic simplification, the behavior doesn't change at all. --- src/gallium/auxiliary/draw/draw_pipe_clip.c | 19 +-- 1 file change

[Mesa-dev] [PATCH 2/2] draw: fix different sign logic when clipping

2018-04-24 Thread sroland
From: Roland Scheidegger The logic was flawed, since mul(x,y) will be <= 0 (exactly 0) when the sign is the same but both numbers are sufficiently small (if the product is smaller than 2^-128). This could apparently lead to emitting a sufficient amount of additional bogus vertices to overflow the

Re: [Mesa-dev] NIR issue with SPIRV ops that have operands with different bit-size

2018-04-24 Thread Neil Roberts
Rob Clark writes: > Karol hit the same thing (with for example, shift instructions) with > the work for spv compute/kernel support. I *think* the number of > special cases isn't too high, so probably vtn should just insert the > appropriate conversion instruction (ie. u2u32, etc) so that if the

Re: [Mesa-dev] [PATCH 1/3] meson: don't build classic mesa tests without dri_drivers

2018-04-24 Thread Eric Anholt
Dylan Baker writes: > Since mesa_classic is not build-on-demand the tests will create a demand > and add a bunch of extra compilation. s/not //? Other than that, the series is Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ m

[Mesa-dev] [Bug 106209] [opencl] [llvm-svn] build failure undefined reference to `clang::FrontendTimesIsEnabled'

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106209 Aaron Watry changed: What|Removed |Added Blocks||99553 Referenced Bugs: https://bugs.fre

[Mesa-dev] [Bug 106197] plasma wayland cant create platform surface with mesa 18.1.0 rc1

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106197 --- Comment #2 from farmboy0+freedesk...@googlemail.com --- Created attachment 139066 --> https://bugs.freedesktop.org/attachment.cgi?id=139066&action=edit build log As far as I can see GBM is enabled. -- You are receiving this mail because:

Re: [Mesa-dev] [PATCH 1/2] radv: only disable out-of-order rast for perfect occlusion queries

2018-04-24 Thread Bas Nieuwenhuizen
On Tue, Apr 24, 2018 at 8:06 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 18 ++ > src/amd/vulkan/radv_query.c | 4 ++-- > 2 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_b

Re: [Mesa-dev] [PATCH] spirv: Don’t check for NaN for most OpFOrd* comparisons

2018-04-24 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Apr 24, 2018 at 7:55 AM, Neil Roberts wrote: > For all of the OpFOrd* comparisons except OpFOrdNotEqual the hardware > should probably already return false if one of the operands is NaN so > we don’t need to have an explicit check for it. This seems to at l

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-24 Thread Emil Velikov
On 13 April 2018 at 11:00, Daniel Vetter wrote: > This tries to align with the X.org communities's long-standing > tradition of trying to be an inclusive community and handing out > commit rights fairly freely. > > We also tend to not revoke commit rights for people no longer > regularly active in

Re: [Mesa-dev] [PATCH] nir: Look into uniform structs for samplers when counting num_textures.

2018-04-24 Thread Eric Anholt
Eric Anholt writes: > mesa/st decides whether to update samplers after a program change based on > whether num_textures is nonzero. By not counting samplers in a uniform > struct, we would segfault in > KHR-GLES3.shaders.struct.uniform.sampler_vertex if it was run in the same > context after a n

Re: [Mesa-dev] [PATCH] st/dri: Fix dangling pointer to a destroyed dri_drawable

2018-04-24 Thread Marek Olšák
On Tue, Apr 24, 2018 at 3:13 AM, Johan Helsing wrote: > Emil: Your alternative patch won't work because dri_make_current is not > necessarily called with NULL after a buffer has been destroyed. > > > The problematic sequence is a pattern we use in QtWayland: > > > //create temporary context > > s

[Mesa-dev] [PATCH] foo

2018-04-24 Thread Emil Velikov
Signed-off-by: Emil Velikov --- meson_options.txt| 2 +- src/gallium/state_trackers/dri/dri_context.c | 13 ++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index a573290b77..d2fd440b37 100644 --- a/me

[Mesa-dev] [PATCH] st/dri: constify dri_fill_st_visual's screen

2018-04-24 Thread Emil Velikov
From: Emil Velikov As the function says - only the visual is changed. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/dri/dri_screen.c | 3 ++- src/gallium/state_trackers/dri/dri_screen.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_track

Re: [Mesa-dev] [PATCH] foo

2018-04-24 Thread Emil Velikov
Sent out the wrong patch, please ignore. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/4] glsl: fold glcpp-test-cr-lf.sh into glcpp-test.sh

2018-04-24 Thread Emil Velikov
From: Emil Velikov As of recently both of these have been reworked so they invoke a python script. At the same time the latter can be executed with the combined arguments of both scripts. AKA we no longer need to have them separate. Signed-off-by: Emil Velikov --- src/compiler/Makefile.glsl.a

[Mesa-dev] [PATCH 1/4] glsl: remove execute bit/shebang from glcpp_test.py

2018-04-24 Thread Emil Velikov
From: Emil Velikov Mesa explicitly manages the invocation of all python scripts. Do so here, by removing the shebang line alongside the execute bit of the newly introduced script. Fixes: db8cd8e36771 ("glcpp/tests: Convert shell scripts to a python script") Cc: Dylan Baker Signed-off-by: Emil V

[Mesa-dev] [PATCH 4/4] glsl/tests/glcpp: reinstate "error out if no tests found"

2018-04-24 Thread Emil Velikov
From: Emil Velikov With the recent rework of converting the shell script to a python one the check for actual tests was dropped. Bring that back, since it was explicitly added considering we had a ~2 year period, during which the tests were not run. Fixes: db8cd8e36771 ("glcpp/tests: Convert sh

[Mesa-dev] [PATCH 3/4] glsl/glcpp/tests: reinstate srcdir/abs_builddir blurb

2018-04-24 Thread Emil Velikov
From: Emil Velikov Bring back the "detection" of the said variables, to allow standalone execution. Fixes: db8cd8e36771 ("glcpp/tests: Convert shell scripts to a python script") Cc: Dylan Baker Signed-off-by: Emil Velikov --- src/compiler/glsl/glcpp/tests/glcpp-test.sh | 13 + 1 f

Re: [Mesa-dev] [PATCH v2 2/2] gallium/util: Android backtrace support

2018-04-24 Thread Rob Herring
On Sun, Apr 15, 2018 at 5:45 PM, Stefan Schake wrote: > We can't use any of the existing implementations in u_debug_stack. > Android technically has libunwind, but it's been modified to the point > where it no longer compiles with the Mesa usage. The library is also > not meant to be referenced by

Re: [Mesa-dev] [PATCH 1/4] glsl: remove execute bit/shebang from glcpp_test.py

2018-04-24 Thread Dylan Baker
Quoting Emil Velikov (2018-04-24 10:49:19) > From: Emil Velikov > > Mesa explicitly manages the invocation of all python scripts. > Do so here, by removing the shebang line alongside the execute bit of > the newly introduced script. > > Fixes: db8cd8e36771 ("glcpp/tests: Convert shell scripts to

Re: [Mesa-dev] [PATCH 3/4] glsl/glcpp/tests: reinstate srcdir/abs_builddir blurb

2018-04-24 Thread Dylan Baker
Sure, Reviewed-by: Dylan Baker Quoting Emil Velikov (2018-04-24 10:49:21) > From: Emil Velikov > > Bring back the "detection" of the said variables, to allow > standalone execution. > > Fixes: db8cd8e36771 ("glcpp/tests: Convert shell scripts to a python > script") > Cc: Dylan Baker > Signed-

Re: [Mesa-dev] [PATCH 2/4] glsl: fold glcpp-test-cr-lf.sh into glcpp-test.sh

2018-04-24 Thread Dylan Baker
If you want to do these all at once that's fine, in meson we execute each mode individually, that's also pretty easy in meson, and would require more work for autotools, so this seems fine: Reviewed-by: Dylan Baker Quoting Emil Velikov (2018-04-24 10:49:20) > From: Emil Velikov > > As of recent

Re: [Mesa-dev] [PATCH 4/4] glsl/tests/glcpp: reinstate "error out if no tests found"

2018-04-24 Thread Dylan Baker
Quoting Emil Velikov (2018-04-24 10:49:22) > From: Emil Velikov > > With the recent rework of converting the shell script to a python one > the check for actual tests was dropped. > > Bring that back, since it was explicitly added considering we had a ~2 > year period, during which the tests wer

Re: [Mesa-dev] [PATCH v2 2/2] gallium/util: Android backtrace support

2018-04-24 Thread Stefan Schake
On Tue, Apr 24, 2018 at 8:10 PM, Rob Herring wrote: > On Sun, Apr 15, 2018 at 5:45 PM, Stefan Schake wrote: >> We can't use any of the existing implementations in u_debug_stack. >> Android technically has libunwind, but it's been modified to the point >> where it no longer compiles with the Mesa

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-24 Thread Daniel Vetter
On Tue, Apr 24, 2018 at 7:30 PM, Emil Velikov wrote: > On 13 April 2018 at 11:00, Daniel Vetter wrote: >> This tries to align with the X.org communities's long-standing >> tradition of trying to be an inclusive community and handing out >> commit rights fairly freely. >> >> We also tend to not re

Re: [Mesa-dev] [PATCH 1/2] radv: only disable out-of-order rast for perfect occlusion queries

2018-04-24 Thread Samuel Pitoiset
On 04/24/2018 07:21 PM, Bas Nieuwenhuizen wrote: On Tue, Apr 24, 2018 at 8:06 AM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 18 ++ src/amd/vulkan/radv_query.c | 4 ++-- 2 files changed, 12 insertions(+), 10 deletion

Re: [Mesa-dev] [PATCH] gm107/ir/lib: fix sched in div u32 builtin

2018-04-24 Thread Samuel Pitoiset
Correct. Reviewed-by: Samuel Pitoiset On 04/24/2018 12:39 PM, Karol Herbst wrote: Imad needs to set a read barrier. With significant big work groups I was getting wrong results for div u32. Turns out the issue was with the sched opcodes. CC: Samuel Pitoiset Signed-off-by: Karol Herbst ---

[Mesa-dev] [PATCH 1/7] ac/surface: handle DCC subresource fast clear restriction on VI

2018-04-24 Thread Marek Olšák
From: Marek Olšák v2: require the previous level to be clearable for determining whether the last unaligned level is clearable --- src/amd/common/ac_surface.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/a

Re: [Mesa-dev] [PATCH 2/2] draw: fix different sign logic when clipping

2018-04-24 Thread Jose Fonseca
On 24/04/18 17:27, srol...@vmware.com wrote: From: Roland Scheidegger The logic was flawed, since mul(x,y) will be <= 0 (exactly 0) when the sign is the same but both numbers are sufficiently small (if the product is smaller than 2^-128). This could apparently lead to emitting a sufficient amou

Re: [Mesa-dev] [PATCH 8/9] Revert "radeonsi: fix potential use-after-free of debug callbacks"

2018-04-24 Thread Marek Olšák
On Wed, Apr 18, 2018 at 6:11 AM, Nicolai Hähnle wrote: > How can this possibly deadlock? Is this during process exit, like in the > case where we got a deadlock when LLVM called abort()? > No. It deadlocks at the start. All threads are waiting on the barrier. The barrier should unblock all threa

[Mesa-dev] [Bug 106157] [Tracker] Mesa 18.1 release tracker

2018-04-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106157 Mark Janes changed: What|Removed |Added Depends on||105938 Referenced Bugs: https://bugs.fre

[Mesa-dev] [PATCH] radeon/vcn: fix mpeg4 msg buffer settings

2018-04-24 Thread boyuan.zhang
From: Boyuan Zhang Previous bit-fields assignments are incorrect and will result certain mpeg4 decode failed due to wrong flag values. This patch fixes these assignments. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 18 +- 1 file changed, 9 inse

[Mesa-dev] [PATCH] util/u_queue: fix a deadlock in util_queue_finish

2018-04-24 Thread Marek Olšák
From: Marek Olšák Cc: 18.0 18.1 --- src/util/u_queue.c | 9 + src/util/u_queue.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index dba23f96456..da513fd9cc5 100644 --- a/src/util/u_queue.c +++ b/src/util/u_queue.c @@ -304,20 +304,21 @@ u

Re: [Mesa-dev] [PATCH 8/9] Revert "radeonsi: fix potential use-after-free of debug callbacks"

2018-04-24 Thread Marek Olšák
I just sent a patch that fixes the deadlock. Marek On Tue, Apr 24, 2018 at 4:40 PM, Marek Olšák wrote: > On Wed, Apr 18, 2018 at 6:11 AM, Nicolai Hähnle > wrote: > >> How can this possibly deadlock? Is this during process exit, like in the >> case where we got a deadlock when LLVM called abort

Re: [Mesa-dev] [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-24 Thread Sean Paul
On Fri, Apr 13, 2018 at 6:01 AM Daniel Vetter wrote: > This tries to align with the X.org communities's long-standing > tradition of trying to be an inclusive community and handing out > commit rights fairly freely. > We also tend to not revoke commit rights for people no longer > regularly acti

[Mesa-dev] [PATCH] meson: Fix no-rtti in llvm detection

2018-04-24 Thread Dylan Baker
Because I clearly wasn't thinking and clearly didn't do a good job testing. Sigh Fixes: c5a97d658ec19cc02719d7f86c1b0715e3d9ffc4 ("meson: fix builds against LLVM built without rtti") Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [Mesa-dev] [PATCH 1/3] mesa: merge the driver functions DrawBuffers and DrawBuffer

2018-04-24 Thread Ian Romanick
On 04/24/2018 09:28 AM, Ian Romanick wrote: > On 04/23/2018 08:23 PM, Timothy Arceri wrote: >> On 24/04/18 10:13, Dieter Nützel wrote: >>> Hello Timo, >>> >>> what about 2 and 3, #1 landed. >> >> It turns out the old radeon classic drivers do make use of the param >> dropped in patch 2 so I've deci

Re: [Mesa-dev] [PATCH 01/11] intel/compiler: lower 16-bit integer extended math instructions

2018-04-24 Thread Jason Ekstrand
On Tue, Apr 24, 2018 at 7:38 AM, Rob Clark wrote: > side-note, not sure if it really effects what you are doing here, but > karol ran into some cases, like 8bit signed imax, which needs to be > "lowered" to 16b (or 32b) and converted back for hw that doesn't > support smaller than 16b (or 32b).

Re: [Mesa-dev] [PATCH 04/11] intel/compiler: implement conversion between float/int 16-bit types

2018-04-24 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga wrote: > --- > src/intel/compiler/brw_fs_nir.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/intel/compiler/brw_fs_nir.cpp > b/src/intel/compiler/brw_fs_nir.cpp > index 5e0dd37eefd..5c414e45b6

Re: [Mesa-dev] [PATCH 05/11] intel/compiler: implement conversions from 16-bit int/float to bool

2018-04-24 Thread Jason Ekstrand
On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga wrote: > --- > src/intel/compiler/brw_fs_nir.cpp | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/src/intel/compiler/brw_fs_nir.cpp > b/src/intel/compiler/brw_fs_nir.cpp > index 5c414e45b61..ad31f7c82d

Re: [Mesa-dev] [PATCH 06/11] nir/constant_folding: support 16-bit constants

2018-04-24 Thread Jason Ekstrand
On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga wrote: > From: Jose Maria Casanova Crespo > > --- > src/compiler/nir/nir_opt_constant_folding.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/compiler/nir/nir_opt_constant_folding.c > b/src/compiler/nir/nir_opt_constant_foldi

Re: [Mesa-dev] [PATCH 07/11] intel/compiler: implement nir_instr_type_load_const for 16-bit constants

2018-04-24 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga wrote: > From: Jose Maria Casanova Crespo > > --- > src/intel/compiler/brw_fs_nir.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/intel/compiler/brw_fs_nir.cpp > b/src/intel/compiler/brw_fs_

Re: [Mesa-dev] [PATCH 08/11] intel/compiler: fix brw_negate_immediate for 16-bit types

2018-04-24 Thread Jason Ekstrand
On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga wrote: > From: Jose Maria Casanova Crespo > > 16-bit immediates are replicated in each word of a 32-bit value > so we need to negate both. > --- > src/intel/compiler/brw_shader.cpp | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [Mesa-dev] [PATCH 11/11] anv/device: expose shaderInt16 support in gen8+

2018-04-24 Thread Jason Ekstrand
9-11 are Reviewed-by: Jason Ekstrand On Wed, Apr 11, 2018 at 12:20 AM, Iago Toral Quiroga wrote: > --- > src/intel/vulkan/anv_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 7522b7865c2..30

[Mesa-dev] [PATCH v2 2/6] drm-uapi: Update vc4 header with syncobj submit support

2018-04-24 Thread Stefan Schake
v2: Synchronized with kernel v2 Signed-off-by: Stefan Schake --- include/drm-uapi/vc4_drm.h | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/include/drm-uapi/vc4_drm.h b/include/drm-uapi/vc4_drm.h index 4117117..bc2d3ed 100644 --- a/include/drm-uapi/vc4_drm.h +++

[Mesa-dev] [PATCH v2 0/6] broadcom/vc4: Native fence fd support

2018-04-24 Thread Stefan Schake
v2 drops the submit flags, directly moves in fence handling to the job submit function and queries for the syncobj cap instead of using a separate support parameter. This series adds support for the native fence fd extension to vc4. The implementation relies on a newly introduced kernel interface

[Mesa-dev] [PATCH v2 1/6] broadcom/vc4: Drop libdrm_vc4 requirement

2018-04-24 Thread Stefan Schake
This was missed in the move back to the local uapi copy. libdrm_vc4 only seems to consist of headers that also exist in the Mesa tree. Signed-off-by: Stefan Schake --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index 33c8d08..9a38471 100644 --- a/

[Mesa-dev] [PATCH v2 5/6] broadcom/vc4: Store job fence in syncobj

2018-04-24 Thread Stefan Schake
This gives us access to the fence created for the render job. v2: Drop flag (Eric) Signed-off-by: Stefan Schake --- src/gallium/drivers/vc4/vc4_context.c | 10 -- src/gallium/drivers/vc4/vc4_context.h | 5 - src/gallium/drivers/vc4/vc4_job.c | 24 +++- 3 fil

[Mesa-dev] [PATCH v2 4/6] broadcom/vc4: Detect syncobj support

2018-04-24 Thread Stefan Schake
We need to know if the kernel supports syncobj submission since otherwise all the DRM syncobj calls fail. v2: Use drmGetCap to detect syncobj support (Eric) Signed-off-by: Stefan Schake --- src/gallium/drivers/vc4/vc4_screen.c | 6 ++ src/gallium/drivers/vc4/vc4_screen.h | 1 + 2 files chan

[Mesa-dev] [PATCH v2 6/6] broadcom/vc4: Native fence fd support

2018-04-24 Thread Stefan Schake
With the syncobj support in place, lets use it to implement the EGL_ANDROID_native_fence_sync extension. This mostly follows previous implementations in freedreno and etnaviv. v2: Drop the flags (Eric) Handle in_fence_fd already in job_submit (Eric) Drop extra vc4_fence_context_init (Eric)

[Mesa-dev] [PATCH v2 3/6] broadcom/vc4: Bump libdrm requirement

2018-04-24 Thread Stefan Schake
Require a version of libdrm with syncobj support. In the meson build, this currently introduces a requirement on libdrm_vc4 which we technically no longer need for vc4. Signed-off-by: Stefan Schake --- configure.ac | 2 ++ meson.build | 2 ++ 2 files changed, 4 insertions(+) diff --git a/confi

Re: [Mesa-dev] [PATCH v2 0/6] broadcom/vc4: Native fence fd support

2018-04-24 Thread Stefan Schake
On Wed, Apr 25, 2018 at 12:00 AM, Stefan Schake wrote: > v2 drops the submit flags, directly moves in fence handling to the > job submit function and queries for the syncobj cap instead of using > a separate support parameter. > > This series adds support for the native fence fd extension to vc4.

Re: [Mesa-dev] [PATCH] meson: Fix no-rtti in llvm detection

2018-04-24 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Apr 24, 2018 at 5:16 PM, Dylan Baker wrote: > Because I clearly wasn't thinking and clearly didn't do a good job > testing. Sigh > > Fixes: c5a97d658ec19cc02719d7f86c1b0715e3d9ffc4 >("meson: fix builds against LLVM built without rtti") > Signed-of

Re: [Mesa-dev] [PATCH] st/dri: constify dri_fill_st_visual's screen

2018-04-24 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Apr 24, 2018 at 1:48 PM, Emil Velikov wrote: > From: Emil Velikov > > As the function says - only the visual is changed. > > Signed-off-by: Emil Velikov > --- > src/gallium/state_trackers/dri/dri_screen.c | 3 ++- > src/gallium/state_trackers/dri/dri_s

Re: [Mesa-dev] [PATCH 3/3] mesa: call DrawBufferAllocate driver hook in update_framebuffer for windows-system FB

2018-04-24 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Apr 24, 2018 at 12:54 AM, Timothy Arceri wrote: > From: Boyan Ding > > When draw buffers are changed on a bound framebuffer, DrawBufferAllocate() > hook should be called. However, it is missing in update_framebuffer with > window-system

Re: [Mesa-dev] [PATCH 01/11] intel/compiler: lower 16-bit integer extended math instructions

2018-04-24 Thread Rob Clark
On Tue, Apr 24, 2018 at 5:45 PM, Jason Ekstrand wrote: > On Tue, Apr 24, 2018 at 7:38 AM, Rob Clark wrote: >> >> side-note, not sure if it really effects what you are doing here, but >> karol ran into some cases, like 8bit signed imax, which needs to be >> "lowered" to 16b (or 32b) and converted

  1   2   >