[Mesa-dev] [PATCH v2 11/11] i965/blorp: Also skip the fast clear if the clear color differs

2018-04-04 Thread Nanley Chery
If the aux state is CLEAR and clear color value has changed, only the surface state must be updated. The bit-pattern in the aux buffer is exactly the same. Reviewed-by: Jason Ekstrand --- src/mesa/drivers/dri/i965/brw_blorp.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --g

[Mesa-dev] [PATCH v2 08/11] i965: Add and use a getter for depth miptree clear values

2018-04-04 Thread Nanley Chery
Balance the miptree API by having a getter for depth clear values. --- src/mesa/drivers/dri/i965/brw_misc_state.c| 15 --- src/mesa/drivers/dri/i965/gen6_depth_state.c | 4 ++-- src/mesa/drivers/dri/i965/gen7_misc_state.c | 3 +-- src/mesa/drivers/dri/i965/gen8_depth_state.c

Re: [Mesa-dev] [PATCH v3 013/104] nir: Support deref instructions in remove_dead_variables

2018-04-04 Thread Jason Ekstrand
On Wed, Apr 4, 2018 at 1:53 PM, Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > Hi, > > > @@ -144,6 +197,45 @@ remove_dead_var_writes(nir_shader *shader, struct > set *live) > > nir_instr_remove(instr); > > } > >} > > + > > + /* We walk the

Re: [Mesa-dev] [PATCH 2/2] gallium/pp: fix MLAA shaders

2018-04-04 Thread Ilia Mirkin
This patch is Reviewed-by: Ilia Mirkin On Wed, Apr 4, 2018 at 4:11 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/auxiliary/postprocess/pp_mlaa.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/auxiliary/postprocess/pp_mlaa.h > b

Re: [Mesa-dev] [PATCH 1/2] gallium/pp: use user constant buffers

2018-04-04 Thread Ilia Mirkin
While I don't see anything obviously wrong in this patch, I also don't see any issues in the old code. What API misuse is this dealing with? On Wed, Apr 4, 2018 at 4:11 PM, Marek Olšák wrote: > From: Marek Olšák > > This fixes a radeonsi crash. > --- > src/gallium/auxiliary/cso_cache/cso_contex

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-04-04 Thread Mark Janes
Leo Liu writes: > On 04/04/2018 12:40 PM, Mark Janes wrote: >> Leo Liu writes: >> >>> On the CI family, firmware requires the destory command have to be the >>> last command in the IB, moving feedback command after destroy is causing >>> issues on CI cards, so we have to keep the previous logic

Re: [Mesa-dev] [PATCH 1/2] gallium/pp: use user constant buffers

2018-04-04 Thread Marek Olšák
On Wed, Apr 4, 2018 at 5:41 PM, Ilia Mirkin wrote: > While I don't see anything obviously wrong in this patch, I also don't > see any issues in the old code. What API misuse is this dealing with? > The constant buffer didn't follow the PIPE_CAP_CONSTBUF0_FLAGS rule. Marek __

[Mesa-dev] [PATCH] nir: rename variables in nir_lower_io_to_temporaries for clarity

2018-04-04 Thread Caio Marcelo de Oliveira Filho
In the emit_copies() function, the use of "newv" and "temp" names made sense when only copies from temporaries to the new variables were being done. But now there are other calls to copy with other pairings, and "temp" doesn't always refer to a temporary created in this pass. Use the names "dest" a

Re: [Mesa-dev] [PATCH v3 010/104] prog/nir: Simplify some load/store operations

2018-04-04 Thread Eric Anholt
Jason Ekstrand writes: > --- This one is: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] i965: return the fourcc saved in __DRIimage

2018-04-04 Thread James Xiong
From: "Xiong, James" The planar_format in __DRIimage contains the original fourcc used to create the image, if it's set, return the saved fourcc directly; Otherwise fall back to the old way. Also we should validate the input parameter "value" first as it might be NULL based on the SPEC. v2: fal

[Mesa-dev] [PATCH 1/2] i965: init image's planar_format in intel_create_image_from_texture

2018-04-04 Thread James Xiong
From: "Xiong, James" When creating a image from a texture, initialize the image's planar_format with the texture's. Signed-off-by: Xiong, James --- src/mesa/drivers/dri/i965/intel_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/

[Mesa-dev] [PATCH 0/2] wrong fourcc was returned for imported images

2018-04-04 Thread James Xiong
From: "Xiong, James" The importer creates an image out of the imported FOURCC_NV12 texture, the image's dri_format is set to R8(same as the first plane's format), when it queries the image's fourcc, mesa goes through intel_image_format table and returns FOURCC_R8. The solution is to 1) set the i

Re: [Mesa-dev] [PATCH 2/2] gallium/pp: fix MLAA shaders

2018-04-04 Thread Timothy Arceri
On 05/04/18 06:11, Marek Olšák wrote: From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99549 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] gallium/pp: use user constant buffers

2018-04-04 Thread Timothy Arceri
On 05/04/18 06:11, Marek Olšák wrote: From: Marek Olšák This fixes a radeonsi crash. The constant buffer didn't follow the PIPE_CAP_CONSTBUF0_FLAGS rule. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105026 --- src/gallium/auxiliary/cso_cache/cso_context.c | 17 s

[Mesa-dev] [PATCH] gallium/hud: add a simple HUD view that only draws text

2018-04-04 Thread Marek Olšák
From: Marek Olšák Add this prefix to the env var: "simple," For example: GALLIUM_HUD=simple,fps The X coordinates are the same, but the Y coordinates are different, because there is only text. '+' happens to behave the same as "\n". ',' happens to behave the same as "\n\n". --- src/gallium

Re: [Mesa-dev] [PATCH 1/2] dri: Add __DRI_IMAGE_FORMAT_SABGR8

2018-04-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Apr 3, 2018 at 5:48 AM, Tapani Pälli wrote: > ping .. > > (currently Android-IA sets EGL_KHR_gl_colorspace to false because these > are missing) > > > On 03/19/2018 01:41 PM, Tapani Pälli wrote: > >> Add format definition and required plumbing to create i

[Mesa-dev] [PATCH 15/17] radeonsi: always prefetch later shaders after the draw packet

2018-04-04 Thread Marek Olšák
From: Marek Olšák so that the draw is started as soon as possible. v2: only prefetch the API VS and VBO descriptors --- src/gallium/drivers/radeonsi/si_cp_dma.c | 89 +--- src/gallium/drivers/radeonsi/si_pipe.h | 2 +- src/gallium/drivers/radeonsi/si_state_dra

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

2018-04-04 Thread Laura Ekstrand
Jean, The main problem is not the conversion to rst. It's preserving the git history so that the patches are easily reviewable. I've started a branch here: https://cgit.freedesktop.org/~ldeks/mesa?h=website2. You see that the git diff shows me that the text of the website hasn't changed at all?

Re: [Mesa-dev] [RFC] - Rewrite mesa website in Sphinx

2018-04-04 Thread Laura Ekstrand
I forgot to note that you have to choose space->ignore in the diff options on cgit in order to see the easy-to-read git diff. On Wed, Apr 4, 2018 at 5:57 PM, Laura Ekstrand wrote: > Jean, > > The main problem is not the conversion to rst. It's preserving the git > history so that the patches ar

[Mesa-dev] [PATCH,v3] configure.ac/meson.build: Fix -latomic test

2018-04-04 Thread Nicolas Boichat
When compiling with LLVM 6.0 on x86 (32-bit) for Android, the test fails to detect that -latomic is actually required, as the atomic call is inlined. In the code itself (src/util/disk_cache.c), we see this pattern: p_atomic_add(cache->size, - (uint64_t)size); where cache->size is an uint64_t *, an

[Mesa-dev] GL_EXT_memory_object_fd on intel ?

2018-04-04 Thread Stuart Axon
Hi Mesa Devs,    Do intel mesa devs take requests ? I'm on the Linux Visual Artists group on Facebook and we've been wanting to implement something like Syphon (OSX) or Spout (windows) - where different processes can share textures. it looks like GL_EXT_memory_object_fd is just the thing.  Mesa

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-04-04 Thread Ilia Mirkin
On Wed, Apr 4, 2018 at 12:12 PM, Emil Velikov wrote: > On 22 March 2018 at 00:39, Ilia Mirkin wrote: >> Just one bit of feedback, for the rest I either agree or have no opinion: >> >> On Wed, Mar 21, 2018 at 8:28 PM, Emil Velikov >> wrote: >>> * unfit and late nominations: >>> * any reject

Re: [Mesa-dev] [PATCH 3/3] radv: implement a fast prefetch path for the vertex stage

2018-04-04 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel on Polaris 20 / RX580 with F1 2017, smoketest Dieter Am 04.04.2018 12:12, schrieb Samuel Pitoiset: This allows to start draws as soon as possible. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 40 +++

[Mesa-dev] [RFC] Disable virgl driver when no 3D for virtio.

2018-04-04 Thread Lepton Wu
I know this looks like a hack. But just want to send this out for comments to see how can I address this issue in mesa: virgl driver enabled image can't work on legacy qemu or GL disabled qemu. It seems another choice could be playing with MESA_LOADER_DRIVER_OVERRIDE to override driver name, but t

[Mesa-dev] [PATCH] loader: disable virgl driver when no 3D for virtio

2018-04-04 Thread Lepton Wu
If user are running mesa under old version of qemu or have turned off GL at runtime, virtio gpu driver actually doesn't work. Adding a detection here can make sure same disk image work with both cases. Signed-off-by: Lepton Wu --- src/loader/loader.c | 21 + 1 file changed, 2

[Mesa-dev] Some radeonsi NIR bindless prep patches

2018-04-04 Thread Timothy Arceri
I've been sitting on these for a while so decided to send them out while Karol and Jason sort out the core NIR patches. The first patch is an unrelated clean up. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mail

[Mesa-dev] [PATCH 5/6] radeonsi/nir: set uses_bindless_images for images

2018-04-04 Thread Timothy Arceri
V2: add missing intrinsics (Spotted-by: Samuel Pitoiset) --- src/gallium/drivers/radeonsi/si_shader_nir.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 01c8554272f

[Mesa-dev] [PATCH 4/6] nir: dont lower bindless samplers

2018-04-04 Thread Timothy Arceri
We neeed to skip the var if its not a uniform here as well as checking the bindless flag since UBOs can contain bindless samplers. --- src/compiler/nir/nir_lower_samplers_as_deref.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_samplers_as_de

[Mesa-dev] [PATCH 3/6] st/glsl_to_nir: set paramater value offset as driver location for packed uniforms

2018-04-04 Thread Timothy Arceri
This allows us to simplify the code and will also be useful for supporting bindless textures. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 7 ++- src/mesa/state_tracker/st_nir.h | 3 +-- src/mesa/state_tracker/st_nir_lower_uniforms_to_ubo.c | 12 -

[Mesa-dev] [PATCH 6/6] radeonsi/nir: tidy up si_nir_load_sampler_desc()

2018-04-04 Thread Timothy Arceri
This makes it easier to follow the code, and also initialises dynamic_index which will be useful for adding bindless textures support. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader

[Mesa-dev] [PATCH 2/6] radeonsi/nir: don't add bindless samplers/images to declared bitmasks

2018-04-04 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_shader_nir.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 7dd8314d4b5..01c8554272f 100644 --- a/src/gallium/drivers/radeonsi/si

[Mesa-dev] [PATCH 1/6] st/mesa: stop calling _mesa_init_shader_object_functions()

2018-04-04 Thread Timothy Arceri
This sets the LinkShader function for the driver, but for the st we set it properly with the following call to st_init_program_functions(). --- src/mesa/state_tracker/st_context.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_co

[Mesa-dev] [RFC PATCH] nir: extend nir_shader_compiler_options with is_scalar

2018-04-04 Thread Christian Gmeiner
As not every (upcoming) backend compiler is happy with nir_lower_xxx_to_scalar lowerings do them only if the backend is scalar (and not vec4) based. Signed-off-by: Christian Gmeiner --- src/amd/vulkan/radv_shader.c| 1 + src/broadcom/compiler/nir_to_vir.c | 1 + src/comp

[Mesa-dev] [Bug 105567] meson/ninja: 1. mesa/vdpau incorrect symlinks in DESTDIR and 2. Ddri-drivers-path Dvdpau-libs-path overrides DESTDIR

2018-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105567 --- Comment #6 from charlie --- Patches "meson-Set-.so-version-for-xa-like-autotools-does.patch" and "meson-fix-megadriver-symlinking.patch" makes correct vdpau symlinks using default options when installing to DESTDIR. 1) However when using o

<    1   2