Re: [Mesa-dev] [PATCH] radv: implement multisample image copies

Hi Dave, I'd appreciate if you could split all the ac stuff into a separate patch. The big issue I see with the patch is that we don't support multisample image stores yet. In particular, you have to copy over the fmask value (and find a way to skip over the fmask lookup in the tex instruction) o

Re: [Mesa-dev] [PATCH 4/4] radv: enable VK_AMD_shader_trinary_minmax extension

With the comments that have already been made resolved: Reviewed-by: Bas Nieuwenhuizen for the series. On Thu, Mar 8, 2018 at 11:14 PM, Daniel Schürmann wrote: > --- > src/amd/vulkan/radv_extensions.py | 1 + > src/amd/vulkan/radv_shader.c | 1 + > 2 files changed, 2 insertions(+) > > di

Re: [Mesa-dev] [PATCH] radv: Fix autotools build.

Acked-by: Samuel Pitoiset Can you please push this asap? On 03/09/2018 08:44 AM, Bas Nieuwenhuizen wrote: Forgot it again Fixes: b6347807a9 "radv: Generate icd files." --- src/amd/vulkan/Makefile.am | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH 1/4] nir: add support for min/max/median of 3 srcs

For the series: Reviewed-by: Samuel Pitoiset On 03/08/2018 11:14 PM, Daniel Schürmann wrote: From: Dave Airlie These are needed for SPV_AMD_shader_trinary_minmax, the AMD HW supports these. Co-authored-by: Daniel Schürmann Signed-off-by: Dave Airlie --- src/compiler/nir/nir_opcodes.py |

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On 2018-03-08 07:53 PM, Jason Ekstrand wrote: > On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker > wrote: > > > I know we've always given a lot of flexibility to vendor specific code > > (i965 or nouveau), but you hope everyone can understand my frustration > >

Re: [Mesa-dev] [PATCH 2/2] radv: run nir_opt_move_load_ubo

The spilled SGPRs/VGPRs is quite nice, but yes the VGPRs increase is not totally good, this is why the number of waves decreased... On 03/08/2018 11:42 PM, Timothy Arceri wrote: I gave this a run on radeonsi and the results were mixed. On the one hand we reduced some spills on the other hand we

[Mesa-dev] [Bug 105412] [OpenGL] [HD 7790] - VSYNC always ON in all videogames

https://bugs.freedesktop.org/show_bug.cgi?id=105412 --- Comment #1 from Michel Dänzer --- Please attach the Xorg log file and the output of dmesg and LIBGL_DEBUG=verbose vblank_mode=0 glxgears -info -- You are receiving this mail because: You are the QA Contact for the bug. You are the assign

Re: [Mesa-dev] [PATCH 1/2] nir: add nir_opt_move_load_ubo() optimization pass

On 03/08/2018 11:48 PM, Ian Romanick wrote: On 03/08/2018 06:50 AM, Samuel Pitoiset wrote: This pass moves load UBO operations just before their first use, loosely based on nir_opt_move_comparisons. If I'm reading this correctly, it moves UBO loads closer to the first use in the same block.

[Mesa-dev] [PATCH 2/2] nir/spirv: add support for the SubgroupBallotKHR SPIR-V capability

This capability is required for the VK_EXT_shader_subgroup_ballot extension. Signed-off-by: Daniel Schürmann --- src/compiler/spirv/spirv_to_nir.c | 3 +++ src/compiler/spirv/vtn_subgroup.c | 17 ++--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/compiler/spir

[Mesa-dev] [PATCH 1/2] nir/spirv: add support for the SubgroupVoteKHR SPIR-V capability

This capability is required for the VK_EXT_shader_subgroup_vote extension. Signed-off-by: Daniel Schürmann --- src/compiler/spirv/spirv_to_nir.c | 4 src/compiler/spirv/vtn_subgroup.c | 20 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/src/compiler/sp

Re: [Mesa-dev] [PATCH] etnaviv: allow mixing different bit depths for color and depth surfaces

2018-03-08 10:20 GMT+01:00 Lucas Stach : > Vivante hardware supports this just fine. There is no reason why this > shouldn't > be advertised as a valid combination. > > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +- > 1 f

Re: [Mesa-dev] [PATCH] autotools: include all meson.build files

On 2 March 2018 at 18:00, Dylan Baker wrote: > Otherwise SWR cannot be built with meson from an autotools generated > tarball, such as the 18.0.0-rc4 tarball. > > CC: George Kyriazis > CC: Emil Velikov > Fixes: 16bf81383080 ("meson/swr: re-shuffle generated files") > Signed-off-by: Dylan Baker

Re: [Mesa-dev] [PATCH mesa 01/21] vulkan: Add KHR_display extension using DRM [v4]

On Thursday, 2018-03-08 10:04:03 -0800, Keith Packard wrote: > Eric Engestrom writes: > > > I'm still slightly bothered by the build options inconsistency between > > autotools: reuse --with-platform=drm > > meson: new -D platform=display > > > > I'd be happy with either one being used

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi: clean up cleanup path

On Thursday, 2018-03-08 18:16:11 +, Emil Velikov wrote: > On 26 February 2018 at 13:51, Eric Engestrom > wrote: > > Cc: Keith Packard > > Signed-off-by: Eric Engestrom > > --- > > This will make Keith's addition much cleaner as well :) > > Hey, every little helps. Fwiw > Reviewed-by: Emil

Re: [Mesa-dev] [PATCH] r600: implement callstack workaround for evergreen.

On Fri, Mar 09, 2018 at 04:09:43PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This is ported from the sb backend, there are some issues with > evergreen stacks on the boundary between entries and ALU_PUSH_BEFORE > instructions. > > Whenever we are going to use a push before, we check the

Re: [Mesa-dev] [PATCH] mesa: Make gl_vertex_array contain pointers to first order VAO members.

On 03/09/2018 12:32 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Brian, The updated patch to be sure. The changes with removing the gl prefix lead to an other small change in _tnl_import_array not to have attrib twice in the argument list. Therefore the v2 again for review. I

Re: [Mesa-dev] [PATCH] draw: fix alpha value for very short aa lines

Reviewed-by: Brian Paul On 03/08/2018 09:30 PM, srol...@vmware.com wrote: From: Roland Scheidegger The logic would not work correctly for line lengths smaller than 1.0, even a degenerated line with length 0 would still produce a fragment with anyhwere between alpha 0.0 and 0.5. --- src/gall

[Mesa-dev] [Bug 105139] Assertion in Dying Light

https://bugs.freedesktop.org/show_bug.cgi?id=105139 --- Comment #3 from vadym --- Tried to run DyingLight on Ubuntu 16.04 but got an error that detected opengl version is 3.0 but needed is 3.3. But in glxinfo I can see 4.5 version of opengl. After this game is loaded and some audio is played but

[Mesa-dev] [PATCH] vulkan: simplify VK_USE_PLATFORM_*_KHR handling

From: Emil Velikov Instead of having multiple guards littered through the code, simply introduce static inline no-op functions when the respective macros are not set. Inspired by the same convention from the kernel. Cc: Eric Engestrom Signed-off-by: Emil Velikov --- Here is an example of my e

[Mesa-dev] WineConf 2018

I hope this won't be considered spam, in which case I'd like to apologise in advance. The annual Wine conference will this year take place from Friday June 29 until Sunday July 1, in The Hague, The Netherlands. In the interest of outreach to other projects, and since I believe Wine would be consid

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On March 9, 2018 00:35:06 Michel Dänzer wrote: On 2018-03-08 07:53 PM, Jason Ekstrand wrote: On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker mailto:dy...@pnwbakers.com>> wrote: > I know we've always given a lot of flexibility to vendor specific code > (i965 or nouveau), but you hope every

Re: [Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

Ping. Maybe it'd be better to just increase MAX_DYNAMIC_BUFFERS? I can't see any side effects of that other than increasing the size of radv_cmd_buffer? Alex On 5 March 2018 at 09:59, Alex Smith wrote: > I just checked what Rise of the Tomb Raider is using. Maximum it hits for > uniform buffer

[Mesa-dev] [PATCH] radv: Increase the number of dynamic uniform buffers.

The vulkan API is not ideal as it does not allow us have a shared limit. Feral needs 15+6 for one of their games, and I'm not a fan of overcommitting the limits, so increase the number of dynamic uniform buffers to 16. CC: CC: Alex Smith --- src/amd/vulkan/radv_device.c | 4 ++-- src/amd/vulk

Re: [Mesa-dev] [PATCH] radv: Increase maxDescriptorSet{Uniform, Storage}BuffersDynamic limits

Sorry, for the delay, I just sent a patch that makes the limits 16 + 8. Going forward it might be an idea to just make this a dynamically sized array and seriously increase the limits. On Fri, Mar 9, 2018 at 5:15 PM, Alex Smith wrote: > Ping. > > Maybe it'd be better to just increase MAX_DYNAMIC

[Mesa-dev] [PATCH] meson: Add moduledir to d3d.pc

This is required to build wine with the nine patchset Fixes: 6b4c7047d57178d3362a710ad503057c6a582ca3 ("meson: build gallium nine state_tracker") Reported-by: Mike Lothian Signed-off-by: Dylan Baker --- src/gallium/targets/d3dadapter9/meson.build | 1 + 1 file changed, 1 insertion(+) di

Re: [Mesa-dev] [PATCH] radv: Increase the number of dynamic uniform buffers.

Tested-by: Alex Smith Thanks! On 9 March 2018 at 16:21, Bas Nieuwenhuizen wrote: > The vulkan API is not ideal as it does not allow us have a > shared limit. > > Feral needs 15+6 for one of their games, and I'm not a fan > of overcommitting the limits, so increase the number of > dynamic unifo

Re: [Mesa-dev] Few issues with Meson

Quoting Mike Lothian (2018-03-06 05:07:34) > Hi > > When compiling wine I also noticed that the d3d.pc files didn't have moduledir > set, so wine couldn't find it > > configure: error: pkg-config couldn't find Gallium Nine module I've sent a patch for this. > > Regards > > Mike > > On Tue, 6

Re: [Mesa-dev] [PATCH] meson: Add moduledir to d3d.pc

On Friday, 2018-03-09 08:32:29 -0800, Dylan Baker wrote: > This is required to build wine with the nine patchset > > Fixes: 6b4c7047d57178d3362a710ad503057c6a582ca3 >("meson: build gallium nine state_tracker") > Reported-by: Mike Lothian > Signed-off-by: Dylan Baker Reviewed-by: Eric En

Re: [Mesa-dev] [PATCH] vulkan: simplify VK_USE_PLATFORM_*_KHR handling

On Friday, 2018-03-09 15:24:18 +, Emil Velikov wrote: > From: Emil Velikov > > Instead of having multiple guards littered through the code, simply > introduce static inline no-op functions when the respective macros are > not set. > > Inspired by the same convention from the kernel. Oh righ

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Fri, Mar 9, 2018 at 11:04 AM, Jason Ekstrand wrote: > On March 9, 2018 00:35:06 Michel Dänzer wrote: > >> On 2018-03-08 07:53 PM, Jason Ekstrand wrote: >>> >>> On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker >> > wrote: >>> >>> > I know we've always given a lot of f

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Fri, Mar 9, 2018 at 8:57 AM, Alex Deucher wrote: > On Fri, Mar 9, 2018 at 11:04 AM, Jason Ekstrand > wrote: > > On March 9, 2018 00:35:06 Michel Dänzer wrote: > > > >> On 2018-03-08 07:53 PM, Jason Ekstrand wrote: > >>> > >>> On Thu, Mar 8, 2018 at 8:45 AM, Dylan Baker >>>

Re: [Mesa-dev] [PATCH 1/5] i965: Hard code scratch_ids_per_subslice for Cherryview

Could this be the reason that BSW systems never reliably passed all unit tests? Up to now, we re-execute each failing test, and mark it as a pass if it succeeds a second time. I'd like to remove that crutch if possible. Jordan Justen writes: > Ken suggested that we might be underallocating scr

Re: [Mesa-dev] [PATCH 1/2] egl/wayland: Add 10bpc BGR configs

On Thursday, 2018-03-08 17:36:39 +, Daniel Stone wrote: > Add support for XBGR2101010 and ABGR2101010. > > Signed-off-by: Daniel Stone > Cc: Ilia Mirkin Reviewed-by: Eric Engestrom > --- > src/egl/drivers/dri2/platform_wayland.c | 12 > 1 file changed, 12 insertions(+) > >

Re: [Mesa-dev] [PATCH 1/3] meson: Use system_has_kms_drm in default driver selection

Greg V writes: > --- I've pushed this patch with Dylan's and my review on it. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

Working under embargoes does suck and quite a lot of people had seen this code but I think the process falls down a bit when Jason wrote (even tongue-in-cheek) "You're 4.5 hours too late, I'm afraid. I'd be happy to take some patches though. :-)" I know in this case Dylan writing patches is proba

Re: [Mesa-dev] [PATCH 04/56] anv/entrypoints: Generalize the string map a bit

On Fri, Mar 9, 2018 at 11:59 AM, Dave Airlie wrote: > Working under embargoes does suck and quite a lot of people had seen > this code but I think the process falls down a bit when Jason wrote > (even tongue-in-cheek) > "You're 4.5 hours too late, I'm afraid. I'd be happy to take some > patches

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

Ilia Mirkin writes: > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov wrote: >> So while others explore ways of improving the testing, let me propose >> a few ideas for improving the actual releasing process. >> >> >> - Making the current state always visible - have a web page, git >>branch an

[Mesa-dev] [Bug 105412] [OpenGL] [HD 7790] - VSYNC always ON in all videogames

https://bugs.freedesktop.org/show_bug.cgi?id=105412 --- Comment #2 from Matias N. Goldberg --- This could be caused by the Ubuntu's Unity Compositor (Compiz). You could try forcing VSync off in one of Compiz config/tweak tools. It could also be caused by the tear free parameter. To test that try

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 Bug ID: 105425 Summary: 3D & games produce periodic GPU crashes (Radeon R7 370) Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 MirceaKitsune changed: What|Removed |Added CC||sonichedgehog_hyperblast00@

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #1 from MirceaKitsune --- Created attachment 137948 --> https://bugs.freedesktop.org/attachment.cgi?id=137948&action=edit dmesg.txt -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 MirceaKitsune changed: What|Removed |Added Attachment #137948|dmesg.txt |dmesg description|

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #2 from MirceaKitsune --- Created attachment 137949 --> https://bugs.freedesktop.org/attachment.cgi?id=137949&action=edit journalctl journalctl --since "1 day ago" This encompasses multiple crashes caused today by Blender 2.79.

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #3 from MirceaKitsune --- Created attachment 137950 --> https://bugs.freedesktop.org/attachment.cgi?id=137950&action=edit lspci -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #4 from MirceaKitsune --- Created attachment 137951 --> https://bugs.freedesktop.org/attachment.cgi?id=137951&action=edit Xorg.0.log -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #5 from MirceaKitsune --- Created attachment 137952 --> https://bugs.freedesktop.org/attachment.cgi?id=137952&action=edit xsession-errors-:0 -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 MirceaKitsune changed: What|Removed |Added Priority|medium |high -- You are receiving this mail be

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 MirceaKitsune changed: What|Removed |Added See Also||https://bugs.freedesktop.or

[Mesa-dev] [Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #6 from MirceaKitsune --- An important note: The exact same freeze happens with both the "radeon" and "amdgpu" driver: Using either module makes absolutely no difference. -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 i...@yahoo.com changed: What|Removed |Added Depends on||105426 Referenced Bugs: https://bugs.f

[Mesa-dev] [Bug 105426] [regression] Mesa-18.0rc4 - black screen in some Valve games when run under Wine

https://bugs.freedesktop.org/show_bug.cgi?id=105426 Bug ID: 105426 Summary: [regression] Mesa-18.0rc4 - black screen in some Valve games when run under Wine Product: Mesa Version: unspecified Hardware: x86 (IA32)

[Mesa-dev] [Bug 105426] [regression] Mesa-18.0rc4 - black screen in some Valve games when run under Wine

https://bugs.freedesktop.org/show_bug.cgi?id=105426 Alex Deucher changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop

[Mesa-dev] [PATCH shader-db 4/4] run: handling binding of attribute variable name

Optional binding of variables can be processed before linking shader objects for creating shader program. It is activated by adding lines with a keyword "BindAttribLoc" followed by name and index as, "BindAttribLoc name_str1 " For example, [require] .. BindAttrbLoc vertex 1 BindAttrbLoc coor

Re: [Mesa-dev] [PATCH 3/5] intel/dev: Add devinfo cs_scratch_ids_per_subslice field

On Wednesday, March 7, 2018 12:36:02 PM PST Jordan Justen wrote: > On 2018-03-07 00:47:12, Kenneth Graunke wrote: > > On Wednesday, March 7, 2018 12:16:28 AM PST Jordan Justen wrote: > > > Suggested-by: Kenneth Graunke > > > Signed-off-by: Jordan Justen > > > --- > > > src/intel/dev/gen_device_i

[Mesa-dev] [PATCH] intel/tools: aubinator: Catch gen11 "enhanced execlist" submission

Different registers are used for execlist submission in gen11, so also watch those. This code only watches element zero of the submit queue, which is all aubdump currently writes. --- src/intel/tools/aubinator.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) dif

[Mesa-dev] [PATCH] u_blit: (trivial) u_blit.h needs to include p_defines.h

From: Roland Scheidegger (For the pipe_tex_filter enum) --- src/gallium/auxiliary/util/u_blit.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/util/u_blit.h b/src/gallium/auxiliary/util/u_blit.h index 085ea63..004ceae 100644 --- a/src/gallium/auxiliary/util/u_blit.h +

Re: [Mesa-dev] [PATCH] r600: implement callstack workaround for evergreen.

Looks great to me. (I think I even mentioned it looked odd to me that stack workarounds looked different on non-sb when I extended the sb workaround logic to exclude hemlock...) Reviewed-by: Roland Scheidegger Am 09.03.2018 um 07:09 schrieb Dave Airlie: > From: Dave Airlie > > This is ported f

[Mesa-dev] [PATCH] i965: Emit texture cache invalidates around blorp_copy

This is a terrible hack but it fixes CTS regressions. It's still incredibly unclear exactly what is going wrong in the hardware to cause this to be an issue so this isn't a good fix by any means. However, it does fix tests so there is that. Fixes: fb0e9b5197 "i965: Track the depth and render cac

[Mesa-dev] [Bug 105171] performance regression (3x slower) running glamor with PutImage workload (radeonsi)

https://bugs.freedesktop.org/show_bug.cgi?id=105171 --- Comment #9 from Clemens Eisserer --- So, shmput10 is now equally fast with Mesa-17.3.6 and Mesa-27.2.4 - however the real-world workload still suffers. Please have a look at http://93.83.133.214/downloads/JXRenderMark-1.0.1.zip - it is a st

[Mesa-dev] [Bug 105412] [OpenGL] [HD 7790] - VSYNC always ON in all videogames

https://bugs.freedesktop.org/show_bug.cgi?id=105412 --- Comment #3 from Vasya --- Created attachment 137954 --> https://bugs.freedesktop.org/attachment.cgi?id=137954&action=edit X.ORG log -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 105412] [OpenGL] [HD 7790] - VSYNC always ON in all videogames

https://bugs.freedesktop.org/show_bug.cgi?id=105412 --- Comment #4 from Vasya --- Created attachment 137955 --> https://bugs.freedesktop.org/attachment.cgi?id=137955&action=edit glxinfo results -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact fo

[Mesa-dev] [Bug 105412] [OpenGL] [HD 7790] - VSYNC always ON in all videogames

https://bugs.freedesktop.org/show_bug.cgi?id=105412 --- Comment #5 from Vasya --- (In reply to Matias N. Goldberg from comment #2) > Thus I should write: > xrandr --output HDMI-A-0 --set TearFree off I also HDMI-0 output, but this command doesn't give any effect > This could be caused by the Ubun