Re: [Mesa-dev] [PATCH 1/6] intel/vulkan: Support INTEL_NO_HW environment variable

Series is, Reviewed-by: Samuel Iglesias Gonsálvez Sam On 10/02/18 09:06, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/intel/vulkan/anv_device.c | 3 +++ > src/intel/vulkan/anv_private.h | 2 ++ > src/intel/vulkan/anv_queue.c | 2 +- > 3 files changed, 6 insertions(+), 1

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI v2

Hi Christian,   Finally something in the render pipeline has to wait until decoding is finished or the frame can't be rendered and this will result in blocking the render thread.   Regards, Rainer   Gesendet: Sonntag, 11. Februar 2018 um 13:13 Uhr Von: "Christian König" An: "rainer.hochec

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI v2

Hi Christian,   For Kodi it is better to wait on the thread that does decoding than later  by the render thread. Means it is desired to call it.   Does vaSyncSurface block as stated by the docs?   Regards, Rainer   Gesendet: Sonntag, 11. Februar 2018 um 11:02 Uhr Von: "Christian König" A

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI v2

Hi Christian,   We have enabled vsync, hence we wait for page flip and renderer will block.   I prefer having control at the application level. If all goes easy and you don't push the system to its limits, all fine. The fun part starts if you have to skip decoding cycles or drop frames to ca

Re: [Mesa-dev] [PATCH] glsl/linker: fix bug when checking precision qualifier

This patch is still unreviewed. Sam On 30/01/18 08:50, Samuel Iglesias Gonsálvez wrote: > According to GLSL ES 3.2 spec, see table in 9.2.1 "Linked Shaders" > section, the precision qualifier should match for uniform variables. > This also applies to previous GLSL ES 3.x specs. > > This 'if' che

Re: [Mesa-dev] [PATCH v2 0/5] i965: ASTC5x5 workaround

On 02/12/2018 09:44 AM, Tapani Pälli wrote: Hi; On 02/08/2018 09:50 AM, Rogovin, Kevin wrote: Hi, I gave it a whirl of setting the .mocs field set to 0 passed to isl_surf_fill_state() ALWAYS. Sadly CarChase GLES continued to hang (where as the GL did not because it does not use ASTC). This

[Mesa-dev] [Bug 105052] compiler/test_eu_compact failure with GCC 8

https://bugs.freedesktop.org/show_bug.cgi?id=105052 Bug ID: 105052 Summary: compiler/test_eu_compact failure with GCC 8 Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Sever

Re: [Mesa-dev] [PATCH 0/5] anv: Support CCS_E for images which may be used for

Series is, Reviewed-by: Samuel Iglesias Gonsálvez Sam On 06/02/18 00:13, Jason Ekstrand wrote: > This little series adds support for enabling CCS_E for images which may > have VK_IMAGE_USAGE_STORAGE_BIT set. Previously, we just bailed on these > images and disabled CCS. However, so long as we

[Mesa-dev] [Bug 104182] Seti@Home OpenCL program starts then returns: "CL file build failure"

https://bugs.freedesktop.org/show_bug.cgi?id=104182 Pavel Ondračka changed: What|Removed |Added CC||pavel.ondra...@email.cz --- Comment #4

[Mesa-dev] [AppVeyor] mesa master #6893 failed

Build mesa 6893 failed Commit 0b97eb02b0 by Eric Anholt on 2/10/2018 4:32 PM: egl/gbm: Fix compiler warning about visual matching.\n\nThe compiler doesn't know that num_visuals > 0.\n\nFixes: 37a8d907cc16 ("egl/gbm: Ensure EGLConfigs match GBM surface format")\

Re: [Mesa-dev] GBM, KMS/DRM, triple buffering

Hi Carlos, On 9 February 2018 at 18:26, Carlos Rafael Giani wrote: > thanks, I got it to work - almost. I am running this on the i.MX6 with > etnaviv. I do get some flickering, however. Flickering shouldn't be seen. It's possible that you're calling things incorrectly, however. For example: /*

Re: [Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

Hi Jason, On 10 February 2018 at 06:50, Jason Ekstrand wrote: > intel_from_planar(__DRIimage *parent, int plane, void *loaderPrivate) > { > int width, height, offset, stride, dri_format, index; > -const struct intel_image_format *f; > __DRIimage *image; > > -if (parent == NULL

Re: [Mesa-dev] [PATCH 04/17] egl/gbm: Fix compiler warning about visual matching.

Hi Eric, On 10 February 2018 at 16:32, Eric Anholt wrote: > The compiler doesn't know that num_visuals > 0. Reviewed and pushed, thanks! Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/list

[Mesa-dev] [Bug 104182] Seti@Home OpenCL program starts then returns: "CL file build failure"

https://bugs.freedesktop.org/show_bug.cgi?id=104182 --- Comment #5 from thinkingbeyondthesqu...@gmail.com --- Its still the task failing as boinc will periodically try to restart that same task until the task date expires. Each time generating that error. So the task never actually starts being pr

[Mesa-dev] [Bug 104182] Seti@Home OpenCL program starts then returns: "CL file build failure"

https://bugs.freedesktop.org/show_bug.cgi?id=104182 --- Comment #6 from Pavel Ondračka --- In that case you will need to run the task manually and see if there is some useful error, e.g. go to the seti folder in /var/lib/boinc-client/projects where the binary should be located and run it from the

[Mesa-dev] [AppVeyor] mesa master #6894 completed

Build mesa 6894 completed Commit f4e85ba93f by Samuel Pitoiset on 2/9/2018 12:54 PM: ac/nir: remove backlink to nir_to_llvm_context\n\nSigned-off-by: Samuel Pitoiset \nReviewed-by: Bas Nieuwenhuizen Configure your notification preferences __

Re: [Mesa-dev] GBM, KMS/DRM, triple buffering

Hi Carlos, Am Freitag, den 09.02.2018, 19:26 +0100 schrieb Carlos Rafael Giani: > Hi Daniel, > > thanks, I got it to work - almost. I am running this on the i.MX6 > with  > etnaviv. I do get some flickering, however. > > To test if something is wrong with the page flipping, I call > drmGetCap() 

[Mesa-dev] [PATCH 1/4] ac: move the outputs array to the ABI

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 47 +++-- src/amd/common/ac_shader_abi.h | 4 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d0

[Mesa-dev] [PATCH 3/4] ac: remove nir_to_llvm_context from ac_nir_translate()

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 4 ++-- src/amd/common/ac_nir_to_llvm.h | 3 +-- src/gallium/drivers/radeonsi/si_shader_nir.c | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src

[Mesa-dev] [PATCH 4/4] ac/nir: rename nir_to_llvm_context to radv_shader_context

There is still more to do in that area, but it's a good start. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 148 1 file changed, 74 insertions(+), 74 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_ni

[Mesa-dev] [PATCH 2/4] ac/nir: remove nir_to_llvm_context::nir link

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 61bbfade53..8e0da8ab23 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_ni

Re: [Mesa-dev] [PATCH] gm107/ir: avoid using kepler instruction capabilities

On Sat, Feb 10, 2018 at 7:41 PM, Ilia Mirkin wrote: > Split up the op properties table into generation-specific bits, and only > use the kepler ones on kepler. Fixes some CTS images tests. > > Signed-off-by: Ilia Mirkin thanks! Reviewed-by: Karol Herbst > --- > .../nouveau/codegen/nv50_ir_ta

Re: [Mesa-dev] [PATCH 03/17] gallium/llvmpipe: Fix compiler warnings about ddx/ddy/ddmax.

I'm wondering if it would help if no_rho_opt were const. But I suppose the problem there really is that the for loop and the if condition have swapped order the second time. Reviewed-by: Roland Scheidegger Am 10.02.2018 um 17:32 schrieb Eric Anholt: > My gcc doesn't figure out that dims >= 1 (see

[Mesa-dev] [PATCH v4 5/5] android: Change gralloc_handle_t members to be fixed width

In order to lessen future alignment issues, lets switch to fixed width integers where possible. This excludes the data_owner since it is a pid_t which in theory could be larger than 32 bits. Signed-off-by: Robert Foss Reviewed-by: Rob Herring --- android/gralloc_handle.h | 20 +++--

[Mesa-dev] [PATCH v4 3/5] android: Mark gralloc_handle_t magic variable as const

Mark magic member of gralloc_handle_t as const. Signed-off-by: Robert Foss Reviewed-by: Rob Herring --- android/gralloc_handle.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/gralloc_handle.h b/android/gralloc_handle.h index 7cbc8ee7cef3..5d8a19ea0c2e 100644 --- a/

[Mesa-dev] [PATCH v4 0/5] Implement commont gralloc_handle_t in libdrm

This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, since at least 4 implementations exist, and share a lot of contents. The idea is to keep the common stuff defined in one place, and libdrm is the common codebase to all of these platforms. Additionally, having this struct defined

[Mesa-dev] [PATCH v4 2/5] android: Add version variable to gralloc_handle_t

The version variable will be used for versioning of this struct and the corresponding accessor functions. Signed-off-by: Robert Foss Reviewed-by: Rob Herring --- android/gralloc_handle.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/android/gralloc_handle.h b/androi

[Mesa-dev] [PATCH v4 1/5] android: Move gralloc handle struct to libdrm

This struct is used in mesa and drm_hwcomposer. Versions of if have been implemented in several grallocs: drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. Other than the 1:1 move of the struct a new generic name has been chosen and variables have had comments added to them. Signed-off-by: Rob

[Mesa-dev] [PATCH v4 4/5] android: Remove member name from gralloc_handle_t

The name member of gralloc_handle_t is no longer needed and has been removed. The version field has also been bumped. Signed-off-by: Robert Foss Reviewed-by: Rob Herring --- android/gralloc_handle.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/android/gralloc_handle.h b

[Mesa-dev] [PATCH] nvc0: disable MS Images for sample_count == 1 on Maxwell

fixes KHR-GL45.multi_bind.dispatch_bind_textures on Maxwell Suggested-by: Ilia Mirkin Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/

Re: [Mesa-dev] [PATCH] nvc0: disable MS Images for sample_count == 1 on Maxwell

Reviewed-by: Ilia Mirkin I think things brings up the MSAAx1 question again. Apparently you're allowed to use a MSAAx1 image with image2DMS? Anyways, we can just avoid it all for now by not supporting it. On Mon, Feb 12, 2018 at 8:46 AM, Karol Herbst wrote: > fixes KHR-GL45.multi_bind.dispatch_

[Mesa-dev] [PATCH] etnaviv: add useful information to BO import errors

From: Philipp Zabel Signed-off-by: Philipp Zabel --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_resource.c b/src/gallium/drivers/etnaviv/etnaviv_resource.c index d70152e082dd..43

Re: [Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

Hi, On 10 February 2018 at 06:50, Jason Ekstrand wrote: > -} else if (parent->planar_format == NULL) { > + > +const struct intel_image_format *f = parent->planar_format; > +const int nplanes = f ? f->nplanes : 1; > + > +if (plane > nplanes) { > + if (parent->modifier == DRM_

[Mesa-dev] [PATCH] ac/shader: scan force_persample

Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 5 ++--- src/amd/common/ac_shader_info.c | 15 +++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index bf5b0bc1e1..86795875a1 10064

[Mesa-dev] [PATCH v4 3/8] radeon/uvd:add uvd hevc enc hw interface header

Add hevc encode hardware interface for UVD Signed-off-by: James Zhu --- src/gallium/drivers/radeon/radeon_uvd_enc.h | 469 1 file changed, 469 insertions(+) create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc.h diff --git a/src/gallium/drivers/radeon/radeo

[Mesa-dev] [PATCH v4 5/8] radeon/uvd:add uvd hevc enc functions

Implement UVD hevc encode functions Signed-off-by: James Zhu --- src/gallium/drivers/radeon/radeon_uvd_enc.c | 381 1 file changed, 381 insertions(+) create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc.c diff --git a/src/gallium/drivers/radeon/radeon_uvd_e

[Mesa-dev] [PATCH v4 4/8] radeon/uvd:add uvd hevc enc hw ib implementation

Implement required IBs for UVD HEVC encode. Signed-off-by: James Zhu --- src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c | 1131 +++ 1 file changed, 1131 insertions(+) create mode 100644 src/gallium/drivers/radeon/radeon_uvd_enc_1_1.c diff --git a/src/gallium/drivers/radeon

Re: [Mesa-dev] [PATCH v2 4/8] radeon/uvd:add uvd hevc enc hw ib implementation

Hi Mark, thanks for point them out. [PATCH v4 3/8] / [PATCH v4 4/8] / [PATCH v4 5/8] update accordingly. James. On 2018-02-08 05:13 PM, Mark Thompson wrote: On 06/02/18 20:05, James Zhu wrote: Implement required IBs for UVD HEVC encode. Signed-off-by: James Zhu --- src/gallium/drivers/

Re: [Mesa-dev] [PATCH] Haiku: convert to autotools

On 5 February 2018 at 22:14, kallisti5 wrote: > On 2018-02-05 15:39, Dylan Baker wrote: >> >> Quoting kallisti5 (2018-02-05 12:58:30) >>> >>> On 2017-10-24 11:47, Emil Velikov wrote: >>> > Hi Jerome, >>> > >>> > On 23 October 2017 at 16:58, Jerome Duval >>> > wrote: >>> >> * configure.ac: >>> >>

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

On Friday, 2018-02-09 20:45:10 -0800, Keith Packard wrote: > This adds support for the KHR_display extension to the anv and radv > Vulkan drivers. The drivers now attempt to open the master DRM node > when the KHR_display extension is requested so that the common winsys > code can perform the neces

[Mesa-dev] [Bug 102077] multilib mesa fail to build with "egl/drivers/dri2/platform_drm.c:542: undefined reference to `gbm_bo_get_bpp'"

https://bugs.freedesktop.org/show_bug.cgi?id=102077 --- Comment #4 from Emil Velikov --- (In reply to Nix from comment #3) > This is actually a Mesa bug: the install-time link of libEGL.la is picking > up libgbm from the installation prefix rather than the $DESTDIR-prepended > prefix: for some re

Re: [Mesa-dev] [PATCH 3/3] Revert "i965: add __DRI2_BLOB support and set cache functions"

For the series: Reviewed-by: Marek Olšák Marek On Fri, Feb 9, 2018 at 4:59 AM, Timothy Arceri wrote: > This reverts commit 9d322fde9781f9fc53c3baac6995ab1cbd8d6135. > --- > src/mesa/drivers/dri/i965/intel_screen.c | 21 - > 1 file changed, 21 deletions(-) > > diff --git a/

Re: [Mesa-dev] [PATCH 2/3] Revert "disk cache: initialize cache path and index only when used"

radeonsi uses the shader cache from multiple threads. Marek On Fri, Feb 9, 2018 at 4:59 AM, Timothy Arceri wrote: > This reverts commit 6a651b6b77b68db71a027c826abccc843ace88ef. > > This change was not thread safe. Applications are allowed to compile > multiple programs attached to the same cont

[Mesa-dev] [PATCH] gallium/hud: add pipe context parameter to extra HUD queries

Those have been missed when the new parameter was introduced, leading to incompatible pointer assignement warnings. Fixes: 3132afdf4c12 (gallium/hud: pass pipe_context explicitly to most functions) CC: Signed-off-by: Lucas Stach --- src/gallium/auxiliary/hud/hud_cpufreq.c | 2 +- src/gall

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

Hi Keith, A few top level comments: - using card/primary node and (missing) authentication Current code opens the primary node when VK_KHR_display is available. Thus running a platform=drm,x11,wayland build will fail, as the client is not authenticated with the X/WL server. - reuse "drm" as a

Re: [Mesa-dev] [PATCH 5/5] ac/nir: add nir_intrinsic_{load, store}_shared support

For the series: Reviewed-by: Marek Olšák Marek On Fri, Feb 9, 2018 at 2:48 AM, Timothy Arceri wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 46 > + > 1 file changed, 46 insertions(+) > > diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/

Re: [Mesa-dev] [PATCH] nir/spirv: add gl_spirv_validation method

On Tue, Jan 23, 2018 at 7:04 AM, Alejandro Piñeiro wrote: > Gentle ping to Jason, as he probably missed that I was trying (but > failed) to make a question. See below (also skipped most of the original > email) > > > On 18/01/18 13:31, Alejandro Piñeiro wrote: > > > > + > > +#include "nir

Re: [Mesa-dev] [PATCH 4/4] radv: Return NULL for entrypoints when not supported.

Hi Bas, On 11 February 2018 at 15:29, Bas Nieuwenhuizen wrote: > This implements strict checking for the entrypoint ProcAddr > functions. > > - InstanceProcAddr with instance = NULL, only returns the 3 allowed >entrypoints. > - DeviceProcAddr does not return any instance entrypoints. > -

Re: [Mesa-dev] [PATCH] gallium/hud: add pipe context parameter to extra HUD queries

Reviewed-by: Marek Olšák Marek On Mon, Feb 12, 2018 at 5:05 PM, Lucas Stach wrote: > Those have been missed when the new parameter was introduced, leading to > incompatible pointer assignement warnings. > > Fixes: 3132afdf4c12 (gallium/hud: pass pipe_context explicitly to most > functions) > C

[Mesa-dev] [PATCH] Move setting current_pipeline to cmd_state_init

We were setting current_pipeline to UINT32_MAX and then calling cmd_cmd_state_reset which memsets the entire state struct to 0 which implicitly resets current_pipeline to 3D. I have no idea how this hasn't caused everything to explode. Fixes: cd3feea74582 "anv/cmd_buffer: Rework anv_cmd_state_res

Re: [Mesa-dev] [PATCH] disk cache: move path creation back to constructor

On 9 February 2018 at 05:44, Tapani Pälli wrote: > This patch moves disk cache path and index creation back to the > constructor which matches previous behavior. We still allow create > to succeed without path so that cache can be used with callback > functionality. > > Fixes: c95d3ed091 "disk cac

Re: [Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

On Mon, Feb 12, 2018 at 6:36 AM, Daniel Stone wrote: > Hi, > > On 10 February 2018 at 06:50, Jason Ekstrand wrote: > > -} else if (parent->planar_format == NULL) { > > + > > +const struct intel_image_format *f = parent->planar_format; > > +const int nplanes = f ? f->nplanes : 1; > >

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

https://bugs.freedesktop.org/show_bug.cgi?id=104820 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

Re: [Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

Hi, On 12 February 2018 at 17:16, Jason Ekstrand wrote: > On Mon, Feb 12, 2018 at 6:36 AM, Daniel Stone wrote: >> On further thought, I don't see how this could work at all. If we call >> fromPlanar on plane 0 of a non-planar image with an aux plane, we need >> to land in the first branch (due t

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

https://bugs.freedesktop.org/show_bug.cgi?id=104820 --- Comment #11 from Roman Gilg --- Apparently this is a bug in Qt: https://bugreports.qt.io/browse/QTBUG-66348 Workaround is to delete $HOME/.cache/qtshadercache -- You are receiving this mail because: You are the QA Contact for the bug. You

Re: [Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

On Mon, Feb 12, 2018 at 9:45 AM, Daniel Stone wrote: > Hi, > > On 12 February 2018 at 17:16, Jason Ekstrand wrote: > > On Mon, Feb 12, 2018 at 6:36 AM, Daniel Stone > wrote: > >> On further thought, I don't see how this could work at all. If we call > >> fromPlanar on plane 0 of a non-planar im

[Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

From: Jason Ekstrand This commit fixes two bugs in intel_from_planar. First, if the planar format was non-NULL but only had a single plane, we were falling through to the planar case. If we had a CCS modifier and plane == 1, we would return NULL instead of the CCS plane. Second, if we did end

Re: [Mesa-dev] [PATCH] ac/shader: scan force_persample

Reviewed-by: Bas Nieuwenhuizen On Mon, Feb 12, 2018 at 3:57 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 5 ++--- > src/amd/common/ac_shader_info.c | 15 +++ > 2 files changed, 17 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 3/6] i965: Use gen_get_pci_device_id_override

Jordan Justen writes: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/intel_screen.c | 55 > ++-- > 1 file changed, 3 insertions(+), 52 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_screen.c > b/src/mesa/drivers/dri/i965/intel_scree

Re: [Mesa-dev] [PATCH 2/6] intel/common: Add gen_get_pci_device_id_override

Jordan Justen writes: > Signed-off-by: Jordan Justen > --- > src/intel/common/gen_device_info.c | 51 > ++ > src/intel/common/gen_device_info.h | 1 + > 2 files changed, 52 insertions(+) > > diff --git a/src/intel/common/gen_device_info.c > b/src/intel/com

Re: [Mesa-dev] [PATCH v2 0/8] The 2nd version for UVD HEVC encode

On 2018-02-10 11:06 AM, Mark Thompson wrote: On 08/02/18 23:05, Mark Thompson wrote: On 08/02/18 22:37, Alex Deucher wrote: On Thu, Feb 8, 2018 at 5:28 PM, Mark Thompson wrote: On 06/02/18 20:05, James Zhu wrote: The whole series are the updated version. Changes

[Mesa-dev] [PATCH v4 04/12] meson: use va-api version reported by pkg-config

Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker") Signed-off-by: Dylan Baker --- meson.build | 2 +- src/gallium/state_trackers/va/meson.build | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index b39e2

[Mesa-dev] [PATCH v4 10/12] meson: Fix omx-bellagio target linkage

This needs to use --whole-archive (link_whole in meson) to properly expose symbols. v4: - Always add libswdri and libswkmsdri to link_with Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker") Signed-off-by: Dylan Baker --- src/gallium/targets/omx-bellagio/meson.build | 7 ---

[Mesa-dev] [PATCH v4 08/12] meson: fix vdpau target linkage

The VDPAU state tracker needs to be linked with whole-archive (autotools does this). Because we are linking the whole archive we alos need to link with libswdri and libswkmsdri if those have been enabled. v4: - Always add libswdri and libswkmsdri to link_with list Fixes: 68076b87474e7959 ("meson:

[Mesa-dev] [PATCH v4 03/12] meson: Unconditionally add libswdri and libswkmsdri to dri link_with

Fixes: b154b44ae342 ("meson: build radeonsi gallium driver") Signed-off-by: Dylan Baker --- src/gallium/targets/dri/meson.build | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/gallium/targets/dri/meson.build b/src/gallium/targets/dri/meson.build index 75ce94a.

[Mesa-dev] [PATCH v4 11/12] meson: Fix xa target linkage

This needs to use --whole-archive (link_whole in meson) to properly expose symbols. v4: - Always add libswdri and libswkmsdri to link_with list Fixes: 0ba909f0f111824 ("meson: build gallium xa state tracker") Signed-off-by: Dylan Baker --- src/gallium/targets/xa/meson.build | 8 +--- 1 file

[Mesa-dev] [PATCH v4 05/12] meson: link dri3 xcb libs into vlwinsys instead of into each target

This makes the dependencies easier to manage, since each media target doesn't need to worry about linking to half a dozen libraries. Fixes: b1b65397d0c4978e3 ("meson: Build gallium auxiliary") Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build| 7 ++- src/gallium/ta

[Mesa-dev] [PATCH v4 00/12] meson: fix gallium media target linkage

The linkage of all of the gallium media targets is broken in various ways in the meson build. This series should correct that by doing more what the autotools build does. Changes since v2: - Add patch to fix va-api version checking - link xcb libs into vlwinsys instead of into each media state t

[Mesa-dev] [PATCH v4 07/12] meson: Actually link xvmc target with libxvmc

Unlike vdpau this is required. Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker") Signed-off-by: Dylan Baker --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index b5fa5a8..3925ec4 100644 --- a/meson.build +++ b/meson.build @@ -452

[Mesa-dev] [PATCH v4 06/12] meson: actually link with libomxil-bellagio

This state tracker actually needs to link, unlike vdpau. Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker") Signed-off-by: Dylan Baker --- meson.build | 5 - 1 file changed, 5 deletions(-) diff --git a/meson.build b/meson.build index 570c508..b5fa5a8 100644 --- a/meson.buil

[Mesa-dev] [PATCH v4 09/12] meson: fix va target linkage

The state tracker needs to be linked with whole-archive (like autotools). As a result there are symbols from libswdri and libswkmsdri that are needed, so link those as well. v4: - Always add libswdri and libswkmsdri to link_with list Fixes: 5a785d51a6d6 ("meson: build gallium va state tracker") S

[Mesa-dev] [PATCH v4 01/12] meson: define empty variables for libswdri and libswkmsdri

This allows these variables to unconditionally included in `link_with` lists, even if they're not used. This allows deleting duplicated logic in nearly every gallium target implemented in meson today. This also removes the now useless `build_by_default` flag from swdri and swkmsdri. v4: - add this

[Mesa-dev] [PATCH v4 12/12] meson: fix xvmc target linkage

This needs to link the state tracker with --whole-archive to expose the right symbols. v4: - Always add libswdri and libswkmsdri to the link_with list Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker") Signed-off-by: Dylan Baker --- src/gallium/targets/xvmc/meson.build | 8 +++

[Mesa-dev] [PATCH v4 02/12] meson: add libswdri and libswkmsdri to link_with unconditionally

Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") Signed-off-by: Dylan Baker --- src/gallium/targets/d3dadapter9/meson.build | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/gallium/targets/d3dadapter9/meson.build b/src/gallium/targets/d3dadapt

[Mesa-dev] [PATCH] gallium: drop all the guard band float caps.

From: Dave Airlie Nobody queries these and nobody sets them to anything useful, the docs say TODO. Drop them until a use appears. Signed-off-by: Dave Airlie --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/etnaviv/etnaviv_screen.c | 5 - src/gallium/d

Re: [Mesa-dev] [PATCH 2/6] intel/common: Add gen_get_pci_device_id_override

On 2018-02-12 11:01:01, Scott D Phillips wrote: > Jordan Justen writes: > > > +/** > > + * Get the overridden PCI ID for the device. This is set with the > > + * INTEL_DEVID_OVERRIDE environment variable. > > + * > > + * Returns -1 if the override is not set. > > + */ > > +int > > +gen_get_pci_de

Re: [Mesa-dev] [PATCH 3/6] i965: Use gen_get_pci_device_id_override

On 2018-02-12 10:53:47, Scott D Phillips wrote: > Jordan Justen writes: > > > Signed-off-by: Jordan Justen > > --- > > src/mesa/drivers/dri/i965/intel_screen.c | 55 > > ++-- > > 1 file changed, 3 insertions(+), 52 deletions(-) > > > > diff --git a/src/mesa/drivers/

Re: [Mesa-dev] [PATCH 01/17] r200: Remove dead rop table

I thought I removed that... thanks for taking care of this. Reviewed-by: Ian Romanick On 02/10/2018 08:32 AM, Eric Anholt wrote: > Fixes: 0aaa27f29187 ("mesa: Pass the translated color logic op > dd_function_table::LogicOpcode") > Cc: Ian Romanick > --- > src/mesa/drivers/dri/r200/r200_state.

Re: [Mesa-dev] [PATCH 17/17] glsl: Suppress sign-compare warning generated by flex 2.6.1.

Supposedly later versions of flex fix this... or so I heard. On 02/10/2018 08:33 AM, Eric Anholt wrote: > I got the following warning: > > src/compiler/glsl/glsl_lexer.cpp:1521:18: warning: comparison between signed > and unsigned integer expressions [-Wsign-compare] >for ( n = 0; n < max_si

Re: [Mesa-dev] [PATCH 11/17] glsl/tests: Fix a compiler warning about signed/unsigned loop comparison.

Reviewed-by: Ian Romanick On 02/10/2018 08:33 AM, Eric Anholt wrote: > Cc: Ian Romanick > Fixes: d32956935edf ("glsl: Walk a list of ir_dereference_array to mark array > elements as accessed") > --- > src/compiler/glsl/tests/array_refcount_test.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [Mesa-dev] [PATCH 07/17] glsl: Silence warnings in the uniform initializer test about 16-bit types

Shutting up this warning has been (fairly low) on my to-do list for some time now... thanks for beating me to it. :) Reviewed-by: Ian Romanick On 02/10/2018 08:33 AM, Eric Anholt wrote: > They should probably get unit tests implemented, but this cleans up a > bunch of warnings in my build for no

[Mesa-dev] [PATCH] meson: use a custom target instead of a generator for i965 oa

generators really are never the thing you want. The problem in this case is that a generator must create a file that contains any file that the generated target depends on. Since brw_oa.py doesn't generate such a file the generated sources are not regenerated even if the xml files they should depen

Re: [Mesa-dev] [PATCH] meson: use a custom target instead of a generator for i965 oa

I ran into the same issue with gputop. Acked-by: Lionel Landwerlin On 12/02/18 20:00, Dylan Baker wrote: generators really are never the thing you want. The problem in this case is that a generator must create a file that contains any file that the generated target depends on. Since brw_oa.py

[Mesa-dev] [PATCH] anv: Don't resolve or ambiguate non-existent layers

The previous code was trying to avoid non-existent layers by taking a MAX with anv_image_aux_layers. Unfortunately, it wasn't taking into account that layer_count starts at base_layer which may not be zero. Instead, we need to subtract base_layer from anv_image_aux_layers with a guard against roll

[Mesa-dev] [PATCH] Move setting current_pipeline to cmd_state_init

We were setting current_pipeline to UINT32_MAX and then calling cmd_cmd_state_reset which memsets the entire state struct to 0 which implicitly resets current_pipeline to 3D. I have no idea how this hasn't caused everything to explode. Fixes: cd3feea74582 "anv/cmd_buffer: Rework anv_cmd_state_res

Re: [Mesa-dev] [PATCH 09/17] spirv: Silence compiler warning about undefined srcs[0]

On 02/10/2018 08:33 AM, Eric Anholt wrote: > It doesn't know that elems >= 1. Does adding assume(elems >= 1) help? > Cc: Jason Ekstrand > --- > src/compiler/spirv/spirv_to_nir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/

Re: [Mesa-dev] [PATCH 08/17] loader: Fix compiler warnings about truncating the PCI ID path.

On 02/10/2018 08:33 AM, Eric Anholt wrote: > My build was producing: > > ../src/loader/loader.c:121:67: warning: ‘%1u’ directive output may be > truncated writing between 1 and 3 bytes into a region of size 2 > [-Wformat-truncation=] > > and we can avoid this careful calculation by just using a

Re: [Mesa-dev] [PATCH] gallium: drop all the guard band float caps.

Looks alright to me. Not sure why they were introduced - d3d9 has queryable caps for them (d3d10 does not, allows guard band but not required). Maybe they were relevant for d3d9 software vertex processing mode at some point, but it looks like we never actually used them with gallium. Reviewed-by: R

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

Eric Engestrom writes: > copy/paste error: s/drm/display/ That's actually intentional -- any system which supports 'drm' can support the display backend as it's based on that. Maybe it should use a different test? (note that I haven't been using the autotools backend recently, so it may not be g

Re: [Mesa-dev] [PATCH] Move setting current_pipeline to cmd_state_init

I guess the default context setup in the kernel is very 3D friendly. Reviewed-by: Lionel Landwerlin On 12/02/18 21:42, Jason Ekstrand wrote: We were setting current_pipeline to UINT32_MAX and then calling cmd_cmd_state_reset which memsets the entire state struct to 0 which implicitly resets cu

[Mesa-dev] [PATCH] virgl: fix caps ioctl size check.

From: Dave Airlie The size check seems backwards, if userspace gives us a size larger it is probably asking for a newer version of the caps, so we just fill in the caps version we have at the smaller size, and it can work it out from there. Userspace will probably still need a fallback as old ke

[Mesa-dev] [PATCH] radeonsi/nir: fix shader ballot return value bitsize

Fixes cts test: KHR-GL46.shader_ballot_tests.ShaderBallotFunctionBallot --- src/gallium/drivers/radeonsi/si_shader_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 39fb8ece25

Re: [Mesa-dev] [PATCH] anv: Don't resolve or ambiguate non-existent layers

On Mon, Feb 12, 2018 at 01:41:44PM -0800, Jason Ekstrand wrote: > The previous code was trying to avoid non-existent layers by taking a > MAX with anv_image_aux_layers. Unfortunately, it wasn't taking into ^ MIN With that fixed, this patch is Reviewed-by: Nanley Chery > account that layer_cou

[Mesa-dev] [PATCH] ac/nir_to_llvm: fix image size for arrays of arrays

Fixes cts test: KHR-GL44.shader_image_size.advanced-changeSize --- src/amd/common/ac_nir_to_llvm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 15402694fc..c0a0da1656 100644 --- a/src/amd/comm

Re: [Mesa-dev] [PATCH 04/13] mesa: decrease the array size of ctx->Texture.FixedFuncUnit to 8

Minor nits below. Otherwise, for the series, Reviewed-by: Brian Paul On 02/08/2018 06:18 PM, Marek Olšák wrote: From: Marek Olšák GL allows doing glTexEnv on 192 texture units, while in reality, only MaxTextureCoordUnits units are used by fixed-func shaders. There is a piglit patch that ad

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

Emil Velikov writes: > A few top level comments: Thanks much for looking over this code. I realize it's a large amount of change and hence more work to review. > - using card/primary node and (missing) authentication > Current code opens the primary node when VK_KHR_display is available. > Thu

Re: [Mesa-dev] [PATCH 3/7] vulkan: Add EXT_acquire_xlib_display

Quoting Keith Packard (2018-02-09 20:45:12) > This extension adds the ability to borrow an X RandR output for > temporary use directly by a Vulkan application. For DRM, we use the > Linux resource leasing mechanism. > > Signed-off-by: Keith Packard > --- > configure.ac

Re: [Mesa-dev] [PATCH 6/7] vulkan: Add new VK_MESA_query_timestamp extension

Quoting Keith Packard (2018-02-09 20:45:15) > This extension adds a single function to query the current GPU > timestamp, just like glGetInteger64v(GL_TIMESTAMP, ×tamp). This > function is needed to complete the implementation of > GOOGLE_display_timing, which needs to be able to coorelate GPU and

[Mesa-dev] [PATCH 1/2] intel/isl: Add an isl_color_value_is_zero helper

Cc: mesa-sta...@lists.freedesktop.org --- src/intel/isl/isl.c | 20 src/intel/isl/isl.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 59f512f..f4b0502 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -269

[Mesa-dev] [PATCH 2/2] anv: Be more careful about fast-clear colors

Previously, we just used all the channels regardless of the format. This is less than ideal because some channels may have undefined values and this should be ok from the client's perspective. Even though the driver should do the correct thing regardless of what is in the undefined value, it makes

  1   2   >