Re: [Mesa-dev] [PATCH] i965/tiled_memcpy: ytiled_to_linear a cache line at a time

2018-02-08 Thread Chris Wilson
Quoting Scott D Phillips (2018-02-08 00:16:34) > Chris Wilson writes: > > > From: Scott D Phillips > > > > Similar to the transformation applied to linear_to_ytiled, also align > > each readback from the ytiled source to a cacheline (i.e. transfer a > > whole cacheline from the source before mov

Re: [Mesa-dev] [PATCH v2] intel/tools: new intel_sanitize_gpu tool

2018-02-08 Thread Rogovin, Kevin
HI, Review comments below. -Original Message- From: Phillips, Scott D Sent: Thursday, February 8, 2018 2:19 AM To: mesa-dev@lists.freedesktop.org; Rogovin, Kevin Subject: [PATCH v2] intel/tools: new intel_sanitize_gpu tool From: Kevin Rogovin Adds a new debug tool to pad each GEM B

Re: [Mesa-dev] [PATCH 1/2] st/va: Enable vaExportSurfaceHandle()

2018-02-08 Thread Christian König
Am 08.02.2018 um 00:10 schrieb Mark Thompson: It is present from libva 2.1 (VAAPI 1.1.0 or higher). Signed-off-by: Mark Thompson Acked-by: Christian König Reviewed-by: Christian König for both. Going to push those two now. Thanks a lot for the help, Christian. --- Retested with up-to-da

Re: [Mesa-dev] [PATCH 01/10] st/mesa: rename some vars related to indirect draw count

2018-02-08 Thread Mathias Fröhlich
Hi Brian, For #1, #3-#10 this is Reviewed-by: Mathias Fröhlich #2 sounds very plausible to me but I can't tell for sure if there is a corner case left. I assume that it passes piglit without regressions and --debug-enabled on a relevant gallium driver target? best Mathias

Re: [Mesa-dev] [PATCH v2] intel/tools: new intel_sanitize_gpu tool

2018-02-08 Thread Chris Wilson
Quoting Scott D Phillips (2018-02-08 00:19:04) > From: Kevin Rogovin > > Adds a new debug tool to pad each GEM BO allocated with (weak) > pseudo-random noise values which are then checked after each > batchbuffer dispatch to the kernel. This can be quite valuable to > find diffucult to track down

Re: [Mesa-dev] [PATCH] meson: Add build option for tools

2018-02-08 Thread Eric Anholt
Scott D Phillips writes: > Add a build option to control building some of the misc tools we > have. Also set the executables to install, presumably you want > that if you're asking for the build. I took a look, since I've got some WIP vc5 tools that really should live in Mesa instead of an exter

[Mesa-dev] [Bug 105013] [regression] GLX video playback is corrupt with Mesa 17.3 (but is fine with 17.2)

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105013 --- Comment #2 from Daniel van Vugt --- Bisected. 5198e48a0d9a991d897cf4c71fdb82ac0e43b025 is the first bad commit commit 5198e48a0d9a991d897cf4c71fdb82ac0e43b025 Author: Thomas Hellstrom Date: Fri Aug 11 09:57:51 2017 +0200 loader_dri3

Re: [Mesa-dev] [PATCH] intel: Add Coffee Lake brand strings

2018-02-08 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2018-01-29 13:59:02, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > include/pci_ids/i965_pci_ids.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/pci_ids/i965_pci_ids.h b/include/pci_ids/i965_pci_ids.h > index e947b

[Mesa-dev] [Bug 105013] [regression] GLX video playback is corrupt with Mesa 17.3 (but is fine with 17.2)

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105013 Timo Aaltonen changed: What|Removed |Added CC||tjaal...@ubuntu.com -- You are receivi

[Mesa-dev] [Bug 105013] [regression] GLX+VA-API+clutter-gst video playback is corrupt with Mesa 17.3 (but is fine with 17.2)

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105013 Daniel van Vugt changed: What|Removed |Added Summary|[regression] GLX video |[regression] |playb

[Mesa-dev] [Bug 105013] [regression] GLX+VA-API+clutter-gst video playback is corrupt with Mesa 17.3 (but is fine with 17.2)

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105013 Michel Dänzer changed: What|Removed |Added CC||thellst...@vmware.com -- You are recei

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-08 Thread Pierre Moreau
On 2018-02-07 — 12:36, Francisco Jerez wrote: > Pierre Moreau writes: > > > On 2018-02-06 — 20:50, Jan Vesely wrote: > > [snip] > >> > > Happy to here suggestions for solving the current conflict in uses of > >> > > PIPE_SHADER_CAP_PREFERRED_IR. > >> > > >> > One option could be to: > >> > * loo

[Mesa-dev] [PATCH] mesa: add glsl version query (v3)

2018-02-08 Thread Vadym Shovkoplias
Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS and glGetStringi for GL_SHADING_LANGUAGE_VERSION v2: - Combine similar functionality into _mesa_get_shading_language_version() function. - Change GLSL version return mechanism. v3: - Add return of empty string for GLSL ver 1.10. - Move _

Re: [Mesa-dev] [PATCH] meson: Add build option for tools

2018-02-08 Thread Jordan Justen
On 2018-02-07 16:55:24, Scott D Phillips wrote: > diff --git a/src/compiler/glsl/meson.build b/src/compiler/glsl/meson.build > index b0c0de810a6..6c46e466c96 100644 > --- a/src/compiler/glsl/meson.build > +++ b/src/compiler/glsl/meson.build > @@ -230,7 +230,8 @@ glsl_compiler = executable( >dep

Re: [Mesa-dev] [PATCH] mesa: add glsl version query (v2)

2018-02-08 Thread Vadym Shovkoplias
Hi Brian, Thanks for review comments! We've just finished v3 of this patch. Regarding Piglit test I'll try to implement appropriate changes. Regards, Vadym On Wed, Feb 7, 2018 at 5:58 PM, Brian Paul wrote: > On 02/07/2018 03:01 AM, Vadym Shovkoplias wrote: > >> Add support for GL_NUM_SHADING_L

Re: [Mesa-dev] [PATCH kmscube] formats: use weston's egl config matching logic, move format defines up

2018-02-08 Thread Eric Engestrom
On Wednesday, 2018-02-07 23:17:48 -0500, Ilia Mirkin wrote: > The GBM surface format has to match the DRM mode. Both are used in a > couple of places, so move the defines to a common place so that they can > be adjusted easily. > > Signed-off-by: Ilia Mirkin > --- > > Tested with both RGB565 and

Re: [Mesa-dev] [PATCH] r600/radeonsi/clover: use PIPE_SHADER_CAP_SUPPORTED_IRS with clover

2018-02-08 Thread Pierre Moreau
Reviewed-by: Pierre Moreau On 2018-02-08 — 10:57, Timothy Arceri wrote: > PIPE_SHADER_CAP_PREFERRED_IR was conlicting with PIPE_SHADER_IR_NIR > for compute shaders, so we let clover pick the one it wants to use. > > This change indirectly enables NIR support for compute shaders > on radeonsi. >

Re: [Mesa-dev] [PATCH] meson: Add build option for tools

2018-02-08 Thread Eric Engestrom
On Thursday, 2018-02-08 01:30:04 -0800, Jordan Justen wrote: > On 2018-02-07 16:55:24, Scott D Phillips wrote: > > diff --git a/src/compiler/glsl/meson.build b/src/compiler/glsl/meson.build > > index b0c0de810a6..6c46e466c96 100644 > > --- a/src/compiler/glsl/meson.build > > +++ b/src/compiler/glsl

[Mesa-dev] [Bug 105013] [regression] GLX+VA-API+clutter-gst video playback is corrupt with Mesa 17.3 (but is fine with 17.2)

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105013 --- Comment #3 from Thomas Hellström --- Hm, This is really a cleanup commit assuming that it's illegal to pass drawables around different screens. But I see now that the @draw argument to get_dri_screen() is not used in the implementations,

Re: [Mesa-dev] [PATCH] r600/radeonsi/clover: use PIPE_SHADER_CAP_SUPPORTED_IRS with clover

2018-02-08 Thread Michel Dänzer
On 2018-02-08 12:57 AM, Timothy Arceri wrote: > PIPE_SHADER_CAP_PREFERRED_IR was conlicting with PIPE_SHADER_IR_NIR > for compute shaders, so we let clover pick the one it wants to use. > > This change indirectly enables NIR support for compute shaders > on radeonsi. This should be 3 separate cha

[Mesa-dev] [Bug 105013] [regression] GLX+VA-API+clutter-gst video playback is corrupt with Mesa 17.3 (but is fine with 17.2)

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105013 Thomas Hellström changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev

[Mesa-dev] [Bug 104949] swrast: Epiphany WEB browser core dumps under Mesa 17.3.3

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104949 --- Comment #10 from Wayne Blaszczyk --- (In reply to Daniel Stone from comment #3) > Yeah, good catch! Bug filed: https://bugs.webkit.org/show_bug.cgi?id=182490 I've applied the following patch to webkitgtk-2.18.6 https://bug-182490-attachment

Re: [Mesa-dev] [PATCH kmscube] formats: use weston's egl config matching logic, move format defines up

2018-02-08 Thread Daniel Stone
Hi Ilia, On 8 February 2018 at 04:17, Ilia Mirkin wrote: > The GBM surface format has to match the DRM mode. Both are used in a > couple of places, so move the defines to a common place so that they can > be adjusted easily. Thanks for doing this Ilia! Hopefully people stop copying broken code n

[Mesa-dev] [PATCH] r600/sb: Check whether optimizations would result in reladdr conflict

2018-02-08 Thread Gert Wollny
Two cases are handled with this patch: 1. If copy propagation tries to eliminated a move from a relative array access then it could optimize MOV R1, ARRAY[RELADDR_1] MOV R2, ARRAY[RELADDR_2] OP2 R3, R1 R2 into OP2 R3, ARRAY[RELADDR_1], ARRAY[RELADDR_2] which is for

[Mesa-dev] [PATCH 3/7] ac/nir: remove set but unused export_mask

2018-02-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 1 - src/amd/common/ac_nir_to_llvm.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 9aa439a4ca..aa7503136c 100644 --- a/src/amd/common/ac_nir_to_llvm.

[Mesa-dev] [PATCH 2/7] ac/nir: remove dead code in handle_vs_outputs_post()

2018-02-08 Thread Samuel Pitoiset
The memcpy can't be reached because the condition is always false. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 62de7e3d01..9a

[Mesa-dev] [PATCH 4/7] ac/nir: add radv_export_param() helper

2018-02-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 43 + 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index aa7503136c..f1f846caeb 100644 --- a/src/amd/co

[Mesa-dev] [PATCH 10/18] egl/wayland: Add bpp to visual map

2018-02-08 Thread Daniel Stone
Both the DRI2 GetBuffersWithFormat interface, and SHM buffer allocation, had their own format -> bpp lookup tables. Replace these with a lookup into the visual map. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 36 +++-- 1 file changed, 12

[Mesa-dev] [PATCH 5/7] ac/shader: scan info about output PS declarations

2018-02-08 Thread Samuel Pitoiset
NIR->LLVM should only be a translation pass, and all scan stuff should be done before. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 7 +++ src/amd/common/ac_nir_to_llvm.h | 3 --- src/amd/common/ac_shader_info.c | 37 + src/amd/co

[Mesa-dev] [PATCH 07/18] egl/wayland: Use visual map for buffer_from_image

2018-02-08 Thread Daniel Stone
When creating a wl_buffer on an upstream Wayland display from an existing EGLImage, use the dri2_wl_visual map rather than another hardcoded list of formats. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 38 - 1 file changed, 18 inserti

[Mesa-dev] [PATCH 06/18] egl/wayland: Use visual map for config->format lookup

2018-02-08 Thread Daniel Stone
Having hoisted the format -> config map into common code, we now use it for config -> format lookups. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 61 +++-- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/src/egl/drivers/dr

[Mesa-dev] [PATCH 03/18] egl/wayland: Widen channel masks to bpp

2018-02-08 Thread Daniel Stone
Widen the channel masks given in the visual table to the full width of the pixel format, i.e. as many leading zeros as required. No functional change. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 25 - 1 file changed, 20 insertions(+), 5 dele

[Mesa-dev] [PATCH 13/18] gbm/dri: Add RGBA masks to GBM format table

2018-02-08 Thread Daniel Stone
Eventually, we can replace the visuals list inside GBM EGL driver with this one. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 46 +- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm

[Mesa-dev] [PATCH 18/18] gbm: Add support for 10bpp BGR formats

2018-02-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010 formats. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index ed64ad61bf0..b7da65be27b 100644 --- a/src/gbm/back

[Mesa-dev] [PATCH 11/18] egl/wayland: Remove has_format enum

2018-02-08 Thread Daniel Stone
Instead of the has_format enum, use an index into the visual array. This makes adding new formats less typing. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/src/egl/drive

[Mesa-dev] [PATCH 14/18] gbm/dri: Expose visuals table through gbm_dri_device

2018-02-08 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c| 21 ++--- src/gbm/backends/dri/gbm_driint.h | 9 + 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 65f612e68b4..ed64a

[Mesa-dev] [PATCH 05/18] egl/wayland: Add format enums to visual map

2018-02-08 Thread Daniel Stone
Extend the visual map from only containing names and bitmasks, to also carrying the three format enums we need. These are the DRIImage format tokens for internal allocation, FourCC codes for wl_drm and dmabuf protocol, and wl_shm codes for swrast drivers. We will later use these formats to elimina

[Mesa-dev] [PATCH 16/18] egl/gbm: Ensure EGLConfigs match GBM surface format

2018-02-08 Thread Daniel Stone
When we create an EGL window surface on a GBM surface, ensure that the EGLConfig is compatible with the GBM format, notwithstanding XRGB/ARGB interchange. For example, rendering with an XRGB EGLConfig on to an ARGB gbm_surface (and vice-versa) are acceptable, but rendering with an XRGB2101

[Mesa-dev] [PATCH 15/18] egl/gbm: Remove duplicate format table

2018-02-08 Thread Daniel Stone
Now that we have mask/channel information in gbm_dri's format conversion table, we can remove the copy in EGL. As this table contains more formats (notably including R8 and RG8, which can be used for BO but not surface allocation), we now compare the masks of all channels when trying to find a sui

[Mesa-dev] [PATCH 02/18] egl/wayland: Hoist format <-> EGLConfig definition up

2018-02-08 Thread Daniel Stone
Pull the mapping between Wayland formats and EGLConfigs up to the top level, so we can reuse it elsewhere. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/egl/drive

[Mesa-dev] [PATCH 12/18] egl/wayland: Use an array for modifiers

2018-02-08 Thread Daniel Stone
Each Wayland EGLDisplay currently contains a struct with one vector of modifiers per format, hardcoded in the header. To allow easier support for more formats, turn this into an array of u_vectors which is opaque outside of platform_wayland.c. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2

[Mesa-dev] [PATCH 1/7] ac/nir: remove useless check in si_llvm_init_export_args()

2018-02-08 Thread Samuel Pitoiset
values can't be NULL because we use ac_build_export_null() now. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index ca9d318c8d..62de7e3d01 100644 --- a/src

[Mesa-dev] [PATCH 7/7] ac/nir: clean up handle_fs_outputs_post()

2018-02-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 64 - 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 747f82549e..550c12d249 100644 --- a/src/amd/co

[Mesa-dev] [PATCH 09/18] egl/wayland: Use visual map for DRIImage<->FourCC map

2018-02-08 Thread Daniel Stone
When trying to translate between DRIImage format enums and FourCC codes, use our visual map rather than an open-coded subset. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 08/18] egl/wayland: Use visual map for format advertisement

2018-02-08 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 75 - 1 file changed, 36 insertions(+), 39 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 0839f5e85a7..b5659b1 100644

[Mesa-dev] [PATCH 04/18] egl/wayland: Use proper enum type in visual definition

2018-02-08 Thread Daniel Stone
No semantic change. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index a9f8b51d986..fac66c8c2e2 100644 --- a/src/egl/d

[Mesa-dev] [PATCH 6/7] ac/nir: add radv_load_output() helper

2018-02-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 766d96c5e0..747f82549e 100644 --- a/src/amd/com

[Mesa-dev] [PATCH 00/18] Wayland/GBM format cleanups and 10bpc BGR

2018-02-08 Thread Daniel Stone
Hi, When Ilia asked for suggestions on where to look to add 10bpc BGR support to the GBM and Wayland EGL backends, I had a quick look; the number of places the formats were duplicated and lossily/inconsistently translated between rapidly annoyed me enough to just type this series up. This gives bo

[Mesa-dev] [PATCH 03/18] egl/wayland: Widen channel masks to bpp

2018-02-08 Thread Daniel Stone
Widen the channel masks given in the visual table to the full width of the pixel format, i.e. as many leading zeros as required. No functional change. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 25 - 1 file changed, 20 insertions(+), 5 dele

[Mesa-dev] [PATCH 04/18] egl/wayland: Use proper enum type in visual definition

2018-02-08 Thread Daniel Stone
No semantic change. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index a9f8b51d986..fac66c8c2e2 100644 --- a/src/egl/d

[Mesa-dev] [PATCH 02/18] egl/wayland: Hoist format <-> EGLConfig definition up

2018-02-08 Thread Daniel Stone
Pull the mapping between Wayland formats and EGLConfigs up to the top level, so we can reuse it elsewhere. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/egl/drive

[Mesa-dev] [PATCH 17/18] egl/wayland: Add 10bpc BGR configs

2018-02-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010. Signed-off-by: Daniel Stone Cc: Ilia Mirkin --- src/egl/drivers/dri2/platform_wayland.c | 12 1 file changed, 12 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 7ab085c

[Mesa-dev] [PATCH 13/18] gbm/dri: Add RGBA masks to GBM format table

2018-02-08 Thread Daniel Stone
Eventually, we can replace the visuals list inside GBM EGL driver with this one. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 46 +- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm

[Mesa-dev] [PATCH 10/18] egl/wayland: Add bpp to visual map

2018-02-08 Thread Daniel Stone
Both the DRI2 GetBuffersWithFormat interface, and SHM buffer allocation, had their own format -> bpp lookup tables. Replace these with a lookup into the visual map. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 36 +++-- 1 file changed, 12

[Mesa-dev] [PATCH 08/18] egl/wayland: Use visual map for format advertisement

2018-02-08 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 75 - 1 file changed, 36 insertions(+), 39 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 0839f5e85a7..b5659b1 100644

[Mesa-dev] [PATCH 07/18] egl/wayland: Use visual map for buffer_from_image

2018-02-08 Thread Daniel Stone
When creating a wl_buffer on an upstream Wayland display from an existing EGLImage, use the dri2_wl_visual map rather than another hardcoded list of formats. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 38 - 1 file changed, 18 inserti

[Mesa-dev] [PATCH 11/18] egl/wayland: Remove has_format enum

2018-02-08 Thread Daniel Stone
Instead of the has_format enum, use an index into the visual array. This makes adding new formats less typing. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/src/egl/drive

[Mesa-dev] [PATCH 01/18] egl/wayland: Fix ARGB/XRGB transposition in config map

2018-02-08 Thread Daniel Stone
When 0b2b7191214eb moved from an if tree to a struct to map between wl_drm formats and EGLConfigs, it transposed the mapping between XRGB and ARGB. Luckily, everyone exposes both formats, so this is harmless. Signed-off-by: Daniel Stone Fixes: 0b2b7191214eb ("egl/wayland: introduce dri2_wl_add_co

[Mesa-dev] [PATCH 12/18] egl/wayland: Use an array for modifiers

2018-02-08 Thread Daniel Stone
Each Wayland EGLDisplay currently contains a struct with one vector of modifiers per format, hardcoded in the header. To allow easier support for more formats, turn this into an array of u_vectors which is opaque outside of platform_wayland.c. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2

[Mesa-dev] [PATCH 05/18] egl/wayland: Add format enums to visual map

2018-02-08 Thread Daniel Stone
Extend the visual map from only containing names and bitmasks, to also carrying the three format enums we need. These are the DRIImage format tokens for internal allocation, FourCC codes for wl_drm and dmabuf protocol, and wl_shm codes for swrast drivers. We will later use these formats to elimina

[Mesa-dev] [PATCH 06/18] egl/wayland: Use visual map for config->format lookup

2018-02-08 Thread Daniel Stone
Having hoisted the format -> config map into common code, we now use it for config -> format lookups. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 61 +++-- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/src/egl/drivers/dr

[Mesa-dev] [PATCH 16/18] egl/gbm: Ensure EGLConfigs match GBM surface format

2018-02-08 Thread Daniel Stone
When we create an EGL window surface on a GBM surface, ensure that the EGLConfig is compatible with the GBM format, notwithstanding XRGB/ARGB interchange. For example, rendering with an XRGB EGLConfig on to an ARGB gbm_surface (and vice-versa) are acceptable, but rendering with an XRGB2101

[Mesa-dev] [PATCH 15/18] egl/gbm: Remove duplicate format table

2018-02-08 Thread Daniel Stone
Now that we have mask/channel information in gbm_dri's format conversion table, we can remove the copy in EGL. As this table contains more formats (notably including R8 and RG8, which can be used for BO but not surface allocation), we now compare the masks of all channels when trying to find a sui

[Mesa-dev] [PATCH 17/18] egl/wayland: Add 10bpc BGR configs

2018-02-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010. Signed-off-by: Daniel Stone Cc: Ilia Mirkin --- src/egl/drivers/dri2/platform_wayland.c | 12 1 file changed, 12 insertions(+) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 7ab085c

[Mesa-dev] [PATCH 09/18] egl/wayland: Use visual map for DRIImage<->FourCC map

2018-02-08 Thread Daniel Stone
When trying to translate between DRIImage format enums and FourCC codes, use our visual map rather than an open-coded subset. Signed-off-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 14/18] gbm/dri: Expose visuals table through gbm_dri_device

2018-02-08 Thread Daniel Stone
Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c| 21 ++--- src/gbm/backends/dri/gbm_driint.h | 9 + 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 65f612e68b4..ed64a

[Mesa-dev] [PATCH 18/18] gbm: Add support for 10bpp BGR formats

2018-02-08 Thread Daniel Stone
Add support for XBGR2101010 and ABGR2101010 formats. Signed-off-by: Daniel Stone --- src/gbm/backends/dri/gbm_dri.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index ed64ad61bf0..b7da65be27b 100644 --- a/src/gbm/back

[Mesa-dev] [PATCH v2] r600/sb: Check whether optimizations would result in reladdr conflict

2018-02-08 Thread Gert Wollny
v2: * Check whether the node src and dst registers are NULL before using them. * fix a type in the commit message. Two cases are handled with this patch: 1. If copy propagation tries to eliminated a move from a relative array access then it could optimize MOV R1, ARRAY[RELADD

Re: [Mesa-dev] [PATCH 00/18] Wayland/GBM format cleanups and 10bpc BGR

2018-02-08 Thread Ilia Mirkin
On Thu, Feb 8, 2018 at 9:05 AM, Daniel Stone wrote: > Hi, > When Ilia asked for suggestions on where to look to add 10bpc BGR > support to the GBM and Wayland EGL backends, I had a quick look; the > number of places the formats were duplicated and lossily/inconsistently > translated between rapidl

Re: [Mesa-dev] [PATCH] r600/radeonsi/clover: use PIPE_SHADER_CAP_SUPPORTED_IRS with clover

2018-02-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Feb 8, 2018 at 12:57 AM, Timothy Arceri wrote: > PIPE_SHADER_CAP_PREFERRED_IR was conlicting with PIPE_SHADER_IR_NIR > for compute shaders, so we let clover pick the one it wants to use. > > This change indirectly enables NIR support for compute shaders >

[Mesa-dev] [Bug 104949] swrast: Epiphany WEB browser core dumps under Mesa 17.3.3

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104949 Daniel Stone changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH V3 1/8] amd/common:add uvd hevc enc support check in hw query

2018-02-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Feb 7, 2018 at 5:41 PM, James Zhu wrote: > Based on amdgpu hardware query information to check if UVD hevc enc support > > Signed-off-by: James Zhu > --- > src/amd/common/ac_gpu_info.c | 12 +++- > src/amd/common/ac_gpu_info.h | 1 + > 2 files c

Re: [Mesa-dev] [PATCH 3/7] radv: add support for 16bit UBO loads

2018-02-08 Thread Marek Olšák
On Wed, Feb 7, 2018 at 7:47 PM, Daniel Schürmann wrote: > Signed-off-by: Daniel Schürmann > --- > src/amd/common/ac_llvm_build.c | 25 + > src/amd/common/ac_llvm_build.h | 8 > src/amd/common/ac_nir_to_llvm.c | 14 -- > 3 files changed, 45 insertio

Re: [Mesa-dev] [PATCH 3/7] radv: add support for 16bit UBO loads

2018-02-08 Thread Marek Olšák
BTW, changes to src/amd shouldn't be prefixed with "radv", because the code is shared with radeonsi and it may confuse people. Marek On Thu, Feb 8, 2018 at 4:05 PM, Marek Olšák wrote: > On Wed, Feb 7, 2018 at 7:47 PM, Daniel Schürmann > wrote: >> Signed-off-by: Daniel Schürmann >> --- >> src/

[Mesa-dev] [PATCH 1/3] st/mesa: don't translate blend state when it's disabled for a colorbuffer

2018-02-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_atom_blend.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_blend.c b/src/mesa/state_tracker/st_atom_blend.c index f7327d6..a5f7edb 100644 --- a/src/mesa/state_tracker/st_atom_blend.c +++

[Mesa-dev] [PATCH 3/3] st/mesa: generate blend state according to the number of enabled color buffers

2018-02-08 Thread Marek Olšák
From: Marek Olšák Non-MRT cases always translate blend state for 1 color buffer only. MRT cases only check and translate blend state for enabled color buffers. This also avoids an assertion failure in translate_blend for: dEQP-GLES31.functional.draw_buffers_indexed.overwrite_common.common_adv

[Mesa-dev] [PATCH 2/3] st/mesa: don't translate blend state when color writes are disabled

2018-02-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_atom_blend.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_blend.c b/src/mesa/state_tracker/st_atom_blend.c index a5f7edb..2a8da75 100644 --- a/src/mesa/state_tracker/st_atom_blend.c

Re: [Mesa-dev] [PATCH 10/10] tgsi: use TGSI_INTERPOLATE_x arguments instead of zeros in ureg code

2018-02-08 Thread Roland Scheidegger
For the series: Reviewed-by: Roland Scheidegger Am 08.02.2018 um 03:17 schrieb Brian Paul: > TGSI_INTERPOLATE_CONSTANT and TGSI_INTERPOLATE_LOC_CENTER have the > value zero so there's no change in behavior. It seems funny to > declare these fs input registers with constant interpolation. But >

Re: [Mesa-dev] [PATCH v2] intel/tools: new intel_sanitize_gpu tool

2018-02-08 Thread Jason Ekstrand
On Thu, Feb 8, 2018 at 12:27 AM, Chris Wilson wrote: > Quoting Scott D Phillips (2018-02-08 00:19:04) > > From: Kevin Rogovin > > > > Adds a new debug tool to pad each GEM BO allocated with (weak) > > pseudo-random noise values which are then checked after each > > batchbuffer dispatch to the ke

[Mesa-dev] [Bug 105013] [regression] GLX+VA-API+clutter-gst video playback is corrupt with Mesa 17.3 (but is fine with 17.2)

2018-02-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105013 --- Comment #5 from Timo Aaltonen --- Thanks, tested on top of 18.0.0-rc2 and it works now. -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing list mesa-d

Re: [Mesa-dev] [PATCH] meson: Add build option for tools

2018-02-08 Thread Dylan Baker
Quoting Scott D Phillips (2018-02-07 16:55:24) > Add a build option to control building some of the misc tools we > have. Also set the executables to install, presumably you want > that if you're asking for the build. > --- > meson.build | 5 + > meson_options.txt

Re: [Mesa-dev] [PATCH] meson: Add build option for tools

2018-02-08 Thread Dylan Baker
Oh, freedreno also has a standalone compiler, os we should probably add a fredreeno option as well. Dylan Quoting Scott D Phillips (2018-02-07 16:55:24) > Add a build option to control building some of the misc tools we > have. Also set the executables to install, presumably you want > that if yo

[Mesa-dev] [PATCH] tgsi: s/unsigned/enum tgsi_semantic/ in ureg_DECL_output()

2018-02-08 Thread Brian Paul
So the function matches the prototype. Found with clang. --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c index 40a047a..3da2ef2 100644 --- a/src/gallium/

Re: [Mesa-dev] [PATCH] tgsi: s/unsigned/enum tgsi_semantic/ in ureg_DECL_output()

2018-02-08 Thread Brian Paul
On 02/08/2018 09:55 AM, Brian Paul wrote: So the function matches the prototype. Found with clang. --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c in

[Mesa-dev] [PATCH 1/2] tgsi: s/unsigned/enum tgsi_semantic/ in ureg_DECL_output()

2018-02-08 Thread Brian Paul
So the function matches the prototype. Found with clang. v2: fix copy&paste error --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c index 40a047a..41281da

[Mesa-dev] [PATCH 2/2] gallium/util: silence clang warning in blitter code

2018-02-08 Thread Brian Paul
Silence "warning: comparison of constant 4294967295 with expression of type 'ubyte'". --- src/gallium/auxiliary/util/u_blitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 63d1307..98c3a

Re: [Mesa-dev] [PATCH] r600/radeonsi/clover: use PIPE_SHADER_CAP_SUPPORTED_IRS with clover

2018-02-08 Thread Jan Vesely
On Thu, 2018-02-08 at 10:57 +1100, Timothy Arceri wrote: > PIPE_SHADER_CAP_PREFERRED_IR was conlicting with PIPE_SHADER_IR_NIR > for compute shaders, so we let clover pick the one it wants to use. > > This change indirectly enables NIR support for compute shaders > on radeonsi. > --- > src/galliu

Re: [Mesa-dev] [PATCH 2/2] gallium/util: silence clang warning in blitter code

2018-02-08 Thread Jose Fonseca
On 08/02/18 17:02, Brian Paul wrote: Silence "warning: comparison of constant 4294967295 with expression of type 'ubyte'". --- src/gallium/auxiliary/util/u_blitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxili

Re: [Mesa-dev] [PATCH v3 5/6] android: Change gralloc_handle_t format from Android format to fourcc

2018-02-08 Thread Rob Herring
On Tue, Feb 6, 2018 at 9:20 AM, Robert Foss wrote: > Change the gralloc_handle_t format to signify the fourcc pixel format > code instead of the Android pixel format definition. > > This is desirable since the fourcc code is what is used within the DRM > subsystem. Naturally translation will still

[Mesa-dev] [PATCH] st/mesa: Initialize tex_target in compile_tgsi_instruction

2018-02-08 Thread Michel Dänzer
From: Michel Dänzer Initialize to TGSI_TEXTURE_BUFFER (== 0), same as was done before the variable type was changed to enum tgsi_texture_type. Fixes a bunch of piglit failures with radeonsi, e.g.: gles-3.0-transform-feedback-uniform-buffer-object: ../../../../src/gallium/auxiliary/tgsi/tgsi_ut

Re: [Mesa-dev] [PATCH kmscube] formats: use weston's egl config matching logic, move format defines up

2018-02-08 Thread Ilia Mirkin
On Thu, Feb 8, 2018 at 6:28 AM, Daniel Stone wrote: > Hi Ilia, > > On 8 February 2018 at 04:17, Ilia Mirkin wrote: >> The GBM surface format has to match the DRM mode. Both are used in a >> couple of places, so move the defines to a common place so that they can >> be adjusted easily. > > Thanks

Re: [Mesa-dev] [PATCH 2/2] intel/compiler: Use null destination register for memory fence messages

2018-02-08 Thread Anuj Phogat
On Wed, Feb 7, 2018 at 2:46 PM, Kenneth Graunke wrote: > On Wednesday, February 7, 2018 1:21:53 PM PST Anuj Phogat wrote: > > On Wed, Feb 7, 2018 at 12:24 PM, Francisco Jerez wrote: > > > Anuj Phogat writes: > > > > On Wed, Feb 7, 2018 at 11:55 AM, Francisco Jerez wrote: > > > > > You can also ju

Re: [Mesa-dev] [PATCH v2 3/3] ac: add 64bit support to ac_find_lsb()

2018-02-08 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Feb 8, 2018 at 1:25 AM, Timothy Arceri wrote: > v2: use LLVMBuildTrunc() > --- > src/amd/common/ac_llvm_build.c | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/src/amd/common/ac_llvm_build.

Re: [Mesa-dev] [PATCH] st/mesa: Initialize tex_target in compile_tgsi_instruction

2018-02-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Feb 8, 2018 at 6:50 PM, Michel Dänzer wrote: > From: Michel Dänzer > > Initialize to TGSI_TEXTURE_BUFFER (== 0), same as was done before the > variable type was changed to enum tgsi_texture_type. > > Fixes a bunch of piglit failures with radeonsi, e.g.: >

Re: [Mesa-dev] [PATCH 01/18] egl/wayland: Fix ARGB/XRGB transposition in config map

2018-02-08 Thread Eric Engestrom
On February 8, 2018 2:06:23 PM UTC, Daniel Stone wrote: > When 0b2b7191214eb moved from an if tree to a struct to map between > wl_drm formats and EGLConfigs, it transposed the mapping between XRGB > and ARGB. Luckily, everyone exposes both formats, so this is harmless. > > Signed-off-by: Danie

Re: [Mesa-dev] [PATCH 2/2] gallium/util: silence clang warning in blitter code

2018-02-08 Thread Roland Scheidegger
For the series: Reviewed-by: Roland Scheidegger Am 08.02.2018 um 18:02 schrieb Brian Paul: > Silence "warning: comparison of constant 4294967295 with expression > of type 'ubyte'". > --- > src/gallium/auxiliary/util/u_blitter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [Mesa-dev] [PATCH v4 20/24] anv/cmd_buffer: Rework aux tracking

2018-02-08 Thread Nanley Chery
On Wed, Feb 07, 2018 at 09:42:25PM -0800, Jason Ekstrand wrote: > This commit completely reworks aux tracking. This includes a number of > somewhat distinct changes: > > 1) Since we are no longer fast-clearing multiple slices, we only need > to track one fast clear color and one fast clear t

[Mesa-dev] [PATCH] gallium: Mute arrays for several meta like callbacks v3

2018-02-08 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi Marek, you mean like this? Well, not perfect but that survives piglit quick on radeonsi then. Please review best and thanks Mathias Set the _DrawArray pointer to NULL when calling into the Drivers Bitmap/CopyPixels/DrawAtlasBitmaps/DrawPixels/DrawTex hooks. This f

Re: [Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

2018-02-08 Thread Jan Vesely
On Tue, 2018-02-06 at 18:39 +0200, Andres Gomez wrote: > On Tue, 2018-02-06 at 11:01 -0500, Jan Vesely wrote: > > On Tue, 2018-02-06 at 17:42 +0200, Andres Gomez wrote: > > > Fixes: 3bf1e036e8a ("amd: remove support for LLVM 3.9") > > > Cc: Marek Olšák > > > Cc: Emil Velikov > > > Cc: Jan Vesely

Re: [Mesa-dev] [PATCH 11/11] r600/radeonsi/clover: always assume PIPE_SHADER_IR_NATIVE for clover

2018-02-08 Thread Jan Vesely
On Thu, 2018-02-08 at 10:25 +0100, Pierre Moreau wrote: > On 2018-02-07 — 12:36, Francisco Jerez wrote: > > Pierre Moreau writes: > > > > > On 2018-02-06 — 20:50, Jan Vesely wrote: > > > [snip] > > > > > > Happy to here suggestions for solving the current conflict in uses > > > > > > of > > > >

  1   2   3   >