For the series:
Reviewed-by: Roland Scheidegger <srol...@vmware.com>
Am 08.02.2018 um 03:17 schrieb Brian Paul:
> TGSI_INTERPOLATE_CONSTANT and TGSI_INTERPOLATE_LOC_CENTER have the
> value zero so there's no change in behavior. It seems funny to
> declare these fs input registers with constant interpolation. But
> it looks like ureg_DECL_input_layout() is not called anywhere and
> ureg_DECL_input() is only called from
> util_make_geometry_passthrough_shader().
> ---
> src/gallium/auxiliary/tgsi/tgsi_ureg.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c
> b/src/gallium/auxiliary/tgsi/tgsi_ureg.c
> index b2cc45d..40a047a 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_ureg.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_ureg.c
> @@ -371,7 +371,8 @@ ureg_DECL_input_layout(struct ureg_program *ureg,
> unsigned array_size)
> {
> return ureg_DECL_fs_input_cyl_centroid_layout(ureg,
> - semantic_name, semantic_index, 0, 0, 0,
> + semantic_name, semantic_index,
> + TGSI_INTERPOLATE_CONSTANT, 0, TGSI_INTERPOLATE_LOC_CENTER,
> index, usage_mask, array_id, array_size);
> }
>
> @@ -384,7 +385,9 @@ ureg_DECL_input(struct ureg_program *ureg,
> unsigned array_size)
> {
> return ureg_DECL_fs_input_cyl_centroid(ureg, semantic_name,
> semantic_index,
> - 0, 0, 0, array_id, array_size);
> + TGSI_INTERPOLATE_CONSTANT, 0,
> + TGSI_INTERPOLATE_LOC_CENTER,
> + array_id, array_size);
> }
>
>
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
