This did the wrong thing if we had e.g. an array for which only some
of the attributes use the instance index. Tripped up some new CTS
tests.
CC:
---
src/amd/common/ac_nir_to_llvm.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/src/amd/common/a
On Fri, Jan 19, 2018 at 03:47:24PM -0800, Jason Ekstrand wrote:
> Reviewed-by: Nanley Chery
> ---
> src/intel/vulkan/anv_image.c | 48
> ++--
> 1 file changed, 29 insertions(+), 19 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vul
On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote:
> This moves it to being based on layout_to_aux_usage instead of being
> hard-coded based on bits of a priori knowledge of how transitions
> interact with layouts. This conceptually simplifies things because
> we're now using layout_t
v2 (Jason Ekstrand):
- Return an enum instead of a boolean
v3 (Jason Ekstrand):
- Return ANV_FAST_CLEAR_NONE instead of false (Topi)
- Rename ANV_FAST_CLEAR_ANY to ANV_FAST_CLEAR_DEFAULT_VALUE
- Add documentation for the enum values
Reviewed-by: Topi Pohjolainen
---
src/intel/vulkan/anv_ima
On Mon, Jan 22, 2018 at 12:07 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Fri, Jan 19, 2018 at 03:47:24PM -0800, Jason Ekstrand wrote:
> > Reviewed-by: Nanley Chery
> > ---
> > src/intel/vulkan/anv_image.c | 48 ++
> --
> > 1 file chang
Reviewed-by: Tapani Pälli
On 01/20/2018 02:29 AM, Chris Wilson wrote:
The forward port of commit 6d87500fe12e ("dri: Change
__DriverApiRec::CreateContext to take a struct for attribs") failed to
adapt the set of allowed attributes for the earlier introduction of
context priorities (commit 1617f
On Mon, Jan 22, 2018 at 12:17 AM, Pohjolainen, Topi <
topi.pohjolai...@gmail.com> wrote:
> On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote:
> > This moves it to being based on layout_to_aux_usage instead of being
> > hard-coded based on bits of a priori knowledge of how transitions
On Fri, Jan 19, 2018 at 03:47:28PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_blorp.c | 14 ++
> 1 file changed, 6 insertions(+), 8 deletions(-)
Reviewed-by: Topi Pohjolainen
>
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index ccb9d18
Build mesa 6663 failed
Commit 5048572352 by Jason Ekstrand on 1/12/2018 1:33 AM:
i965: Set tiling on BOs imported with modifiers\n\nWe need this to ensure that GTT maps work on buffers we get from Vulkan\non the off chance that someone does a readpixels or some
Note to back-porters: I forgot to add a "fixes" tag but these and the
other two I pushed with them should go into 17.3 as they fix the modifiers
support we landed there.
On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand
wrote:
> We need this to ensure that GTT maps work on buffers we get from Vul
On Mon, Jan 22, 2018 at 12:30:30AM -0800, Jason Ekstrand wrote:
> On Mon, Jan 22, 2018 at 12:17 AM, Pohjolainen, Topi <
> topi.pohjolai...@gmail.com> wrote:
>
> > On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote:
> > > This moves it to being based on layout_to_aux_usage instead of be
On 01/13/2018 04:23 AM, Dylan Baker wrote:
> Quoting Ian Romanick (2018-01-12 12:06:59)
>> From: Ian Romanick
>>
>> This is useful for preparing data to go in a Mesa commit message.
>>
>> Signed-off-by: Ian Romanick
>> ---
>> report.py | 53 +++--
>
I don't see patches 4, 8, 9 and 18 in the mailing list. Are they blocked?
Sam
On 20/01/18 20:11, Jason Ekstrand wrote:
> Our previous scheme for Get*ProcAddr was to just return what we could and
> not care about the details. This meant that GetInstanceProcAddr returned
> all anv_ entrypoints an
Build mesa 6664 completed
Commit 005375717b by Matthew Nicholls on 1/19/2018 2:11 PM:
radv: restore previous stencil reference after depth-stencil clear\n\nCc: mesa-sta...@lists.freedesktop.org\nReviewed-by: Samuel Pitoiset \nReviewed-by: Alex Smith
I don't think they're blocked by mailman decided to give up over the
week-end so it may have gotten lost. Here's a branch:
https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/anv-proc-addr
On Mon, Jan 22, 2018 at 1:03 AM, Samuel Iglesias Gonsálvez <
sigles...@igalia.com> wrote:
> I don't se
On Fri, Jan 19, 2018 at 03:47:29PM -0800, Jason Ekstrand wrote:
> Currently, this helper does nothing but we call it every place where an
> image is written through the render pipeline. This will allow us to
> properly mark the aux state so that we can handle resolves correctly.
I can't tell 100%
Quoting Tapani Pälli (2018-01-22 08:26:15)
> Reviewed-by: Tapani Pälli
>
> On 01/20/2018 02:29 AM, Chris Wilson wrote:
> > The forward port of commit 6d87500fe12e ("dri: Change
> > __DriverApiRec::CreateContext to take a struct for attribs") failed to
> > adapt the set of allowed attributes for t
Since patch 1 was rejected this time around for being too large I've also
sent the series directly to Leo and Julien.
On Sat, Jan 20, 2018 at 8:01 AM, Gurkirpal Singh
wrote:
> I've added the right patches as a reply.
>
> Sry again for the inconvenience
>
> On Sat, Jan 20, 2018 at 3:38 AM, Gurkir
On Mon, Jan 22, 2018 at 1:22 AM, Chris Wilson
wrote:
> Quoting Tapani Pälli (2018-01-22 08:26:15)
> > Reviewed-by: Tapani Pälli
> >
> > On 01/20/2018 02:29 AM, Chris Wilson wrote:
> > > The forward port of commit 6d87500fe12e ("dri: Change
> > > __DriverApiRec::CreateContext to take a struct for
On Fri, Jan 19, 2018 at 03:47:32PM -0800, Jason Ekstrand wrote:
> Now that this isn't a multi-case if and it's just the one case, it's a
> bit clearer if the condition is just part of the if instead of being
> pulled out into a boolean variable.
Reviewed-by: Topi Pohjolainen
> ---
> src/intel/v
On Fri, Jan 19, 2018 at 03:47:33PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 31 ++-
> 1 file changed, 14 insertions(+), 17 deletions(-)
Reviewed-by: Topi Pohjolainen
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/
On Fri, Jan 19, 2018 at 03:47:34PM -0800, Jason Ekstrand wrote:
> Even though the blorp pass looks a bit on the sketchy side, the end
> result in the Vulkan driver is very nice. Instead of having this weird
> case where you do a fast clear and then maybe have to resolve, we just
> do the ambiguate
On Fri, Jan 19, 2018 at 03:47:35PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_image.c | 13 +++--
> 1 file changed, 3 insertions(+), 10 deletions(-)
Reviewed-by: Topi Pohjolainen
>
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
> index e34ac95
On Fri, Jan 19, 2018 at 03:47:36PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 34 +++---
> 1 file changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> ind
Quoting Jason Ekstrand (2018-01-22 09:45:55)
> On Mon, Jan 22, 2018 at 1:22 AM, Chris Wilson
> wrote:
>
> Quoting Tapani Pälli (2018-01-22 08:26:15)
> > Reviewed-by: Tapani Pälli
> >
> > On 01/20/2018 02:29 AM, Chris Wilson wrote:
> > > The forward port of commit 6d87500fe12
On 22 January 2018 at 10:27, Chris Wilson wrote:
> Quoting Jason Ekstrand (2018-01-22 09:45:55)
>> On Mon, Jan 22, 2018 at 1:22 AM, Chris Wilson
>> wrote:
>>
>> Quoting Tapani Pälli (2018-01-22 08:26:15)
>> > Reviewed-by: Tapani Pälli
>> >
>> > On 01/20/2018 02:29 AM, Chris Wils
On 11.01.2018 12:22, Ilia Mirkin wrote:
On Thu, Jan 11, 2018 at 3:51 AM, Gert Wollny wrote:
Am Donnerstag, den 11.01.2018, 08:09 +0100 schrieb Gert Wollny:
Am Mittwoch, den 10.01.2018, 15:27 -0500 schrieb Ilia Mirkin:
[...]
If your hardware executes all the vertices in parallel, then a
barri
using void* for functions we need newer CL headers for.
Signed-off-by: Karol Herbst
---
src/gallium/state_trackers/clover/api/dispatch.cpp | 29 +-
src/gallium/state_trackers/clover/api/dispatch.hpp | 116 +
2 files changed, 144 insertions(+), 1 deletion(-)
diff --git a
On 18.01.2018 00:48, Bas Nieuwenhuizen wrote:
Fixes: 91074bb11bda "radv/ac: Implement Float64 SSBO stores."
---
src/amd/common/ac_nir_to_llvm.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to
Reviewed-by: Nicolai Hähnle
On 18.01.2018 02:03, Timothy Arceri wrote:
Fixes: f4e499ec7914 "radv: add initial non-conformant radv vulkan driver"
---
src/amd/common/ac_nir_to_llvm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/
v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris)
use unreachable with unknown priority (Samuel)
v3: add stubs in gem_stubs.c (Emil)
use priority defines from gen_defines.h
Signed-off-by: Tapani Pälli
Reviewed-by: Samuel Iglesias Gonsálvez (v2)
Reviewed-by: Chris Wilson (v2)
---
src/intel
Signed-off-by: Tapani Pälli
---
src/intel/common/gen_defines.h | 52 ++
1 file changed, 52 insertions(+)
create mode 100644 src/intel/common/gen_defines.h
diff --git a/src/intel/common/gen_defines.h b/src/intel/common/gen_defines.h
new file mode 100644
in
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/brw_bufmgr.h | 4
src/mesa/drivers/dri/i965/brw_context.c | 8 +---
src/mesa/drivers/dri/i965/intel_screen.c | 8 +---
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.h
Hi Jean,
thanks for the interest :)
On 17.01.2018 21:50, Jean Hertel wrote:
Hello Michel,
Hello Nicolai,
I have spent some more time reading the Mesa source code and trying to figure
out how the prime configuration works.
If i understood correctly the driconf XML format should have an option
Quoting Tapani Pälli (2018-01-22 12:29:31)
> Signed-off-by: Tapani Pälli
1&2 Reviewed-by: Chris Wilson
-Chris
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Nicolai Hähnle
On 19.01.2018 00:05, Timothy Arceri wrote:
---
src/amd/common/ac_nir_to_llvm.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index cf0b3d998c..4f240db4ac 100644
--- a/src/amd/
Why hasn't this been noticed before? Does Vulkan not have multiple streams?
Anyway, series is:
Reviewed-by: Nicolai Hähnle
On 18.01.2018 23:26, Timothy Arceri wrote:
---
src/amd/common/ac_nir_to_llvm.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/amd/com
Reviewed-by: Nicolai Hähnle
On 22.01.2018 00:52, Timothy Arceri wrote:
---
src/amd/common/ac_nir_to_llvm.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index ac3a949bd3..eabdc83f16 100644
--- a/src/amd
On 22.01.2018 02:54, Timothy Arceri wrote:
---
src/amd/common/ac_nir_to_llvm.c | 38
src/gallium/drivers/radeonsi/si_shader_nir.c | 9 +++
2 files changed, 47 insertions(+)
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_
On 22.01.2018 04:57, Timothy Arceri wrote:
Fixes the following piglit tests:
arb_blend_func_extended-fbo-extended-blend
arb_blend_func_extended-fbo-extended-blend-explicit
arb_blend_func_extended-fbo-extended-blend-explicit_gles3
arb_blend_func_extended-fbo-extended-blend-pattern
arb_blend_func_
Signed-off-by: Tapani Pälli
---
include/GL/internal/dri_interface.h | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/include/GL/internal/dri_interface.h
b/include/GL/internal/dri_interface.h
index 34a5c9fb01..de367d8f77 100644
--- a/include/GL/intern
v2: cleanup, move callbacks to _egl_display struct (Emil Velikov)
Signed-off-by: Tapani Pälli
---
src/egl/drivers/dri2/egl_dri2.c | 39 +++
src/egl/drivers/dri2/egl_dri2.h | 1 +
src/egl/main/eglapi.c | 30 ++
src/egl/mai
Another go at EGL_ANDROID_blob_cache, some patches are re-sent but I
thought it would be easier to read when sending all patches at once.
Most important change here is that I've done refactoring to disk cache
so that it can live without path/index. Path will get generated only
when cache is act
This patch makes disk_cache initialize path and index lazily so
that we can utilize disk_cache without a path using callback
functionality introduced by next patch.
Signed-off-by: Tapani Pälli
---
src/util/disk_cache.c | 114 --
1 file changed, 73
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/intel_screen.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index a4e34e9f2c..84009382c6 100644
--- a/src/mesa/drivers/dri/i
v2: add disk_cache_has_key, disk_cache_put_key support
using blob cache (Nicolai, Jordan)
Signed-off-by: Tapani Pälli
---
src/util/disk_cache.c | 49 +
src/util/disk_cache.h | 19 +++
2 files changed, 68 insertions(+)
diff --gi
For the series:
Reviewed-by: Nicolai Hähnle
On 10.01.2018 20:12, Samuel Pitoiset wrote:
This allows to reduce the number of dwords that are loaded
with buffer_load_format_xyzw. For example, when the only used
channel is 1, the driver will emit buffer_load_format_x instead.
Shader stats for DO
On 10.01.2018 20:49, Marek Olšák wrote:
From: Marek Olšák
Cc: 17.2 17.3
---
src/gallium/auxiliary/util/u_threaded_context.c | 13 +
src/gallium/auxiliary/util/u_threaded_context.h | 8
2 files changed, 21 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_thread
On 10.01.2018 20:49, Marek Olšák wrote:
From: Marek Olšák
Please add a bug report or reference to what fails without it.
It does make sense though, so
Reviewed-by: Nicolai Hähnle
Cc: 17.2 17.3
---
src/gallium/drivers/radeon/r600_texture.c | 14 --
1 file changed, 12 inse
Both patches:
Reviewed-by: Nicolai Hähnle
On 19.01.2018 05:12, Timothy Arceri wrote:
This is needed for ARB_bindless_texture support.
---
src/compiler/glsl/glsl_to_nir.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/compiler/glsl/glsl_to_nir.cpp
b/src/compiler/glsl/glsl_to
On 18.01.2018 08:17, Timothy Arceri wrote:
This is what radeonsi does. Fixes remaing piglit subtest in:
./bin/arb_shader_image_size-builtin --quick -auto -fbo
Reviewed-by: Nicolai Hähnle
---
src/amd/common/ac_nir_to_llvm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
On 19.01.2018 12:03, Timothy Arceri wrote:
Fixes a bunch of ARB_sample_shading piglit tests.
Reviewed-by: Nicolai Hähnle
---
src/gallium/drivers/radeonsi/si_shader_nir.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c
b/src/gallium/dri
On 19.01.2018 12:46, Timothy Arceri wrote:
Fixes the following piglit tests:
arb_tessellation_shader/fs-primitiveid-instanced
glsl-1.50/primitive-id-no-gs
glsl-1.50/primitive-id-no-gs-first-vertex
glsl-1.50/primitive-id-no-gs-instanced
glsl-1.50/primitive-id-no-gs-strip
glsl-1.50/primitive-id-no
On 19.01.2018 07:05, Tapani Pälli wrote:
On 01/18/2018 05:49 PM, Nicolai Hähnle wrote:
On 17.01.2018 17:10, Tapani Pälli wrote:
On 17.01.2018 13:34, Nicolai Hähnle wrote:
On 15.01.2018 13:31, Tapani Pälli wrote:
Hello;
Here's a refactored series of EGL_ANDROID_blob_cache. Now cache
funct
On 20.01.2018 02:38, Timothy Arceri wrote:
Fixes the following piglit test on radeonsi:
./bin/arb_enhanced_layouts-gs-stream-location-aliasing
Reviewed-by: Nicolai Hähnle
---
src/amd/common/ac_nir_to_llvm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/amd
On 20.01.2018 04:11, Timothy Arceri wrote:
Fixes the following piglit tests:
arb_shader_image_load_store/layer/image3d/layered binding test
arb_shader_image_load_store/max-size/image3d max size test/2048x8x8x1
arb_shader_image_load_store/max-size/image3d max size test/8x2048x8x1
arb_shader_image
On 19.01.2018 06:50, Timothy Arceri wrote:
This fixes a segfault for varyings not starting at component 0.
Reviewed-by: Nicolai Hähnle
---
src/amd/common/ac_llvm_build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac
On 19.01.2018 06:07, Timothy Arceri wrote:
Fixes the following ARB_arrays_of_arrays piglit tests:
basic-imagestore-const-uniform-index
basic-imagestore-mixed-const-non-const-uniform-index
basic-imagestore-mixed-const-non-const-uniform-index2
basic-imagestore-non-const-uniform-index
Reviewed-by
Hey,
Nicolai Hähnle wrote on 22.01.2018 14:18:
> On 20.01.2018 04:11, Timothy Arceri wrote:
>> Fixes the following piglit tests:
>>
>> arb_shader_image_load_store/layer/image3d/layered binding test
>> arb_shader_image_load_store/max-size/image3d max size test/2048x8x8x1
>> arb_shader_image_load_sto
I read this thru a few times, and found just two typos:
Reviewed-by: Topi Pohjolainen
There are a lot of details that could go wrong and another set of eyes
on it would be really good.
On Fri, Jan 19, 2018 at 03:47:37PM -0800, Jason Ekstrand wrote:
> This commit completely reworks aux tracking
On 19 January 2018 at 06:53, Tapani Pälli wrote:
>
>
> On 01/18/2018 04:55 PM, Emil Velikov wrote:
>>
>> On 17 January 2018 at 16:11, Tapani Pälli wrote:
>>>
>>>
>>>
>>> On 17.01.2018 13:28, Nicolai Hähnle wrote:
On 16.01.2018 18:45, Emil Velikov wrote:
>
>
> Hi Tapani,
On Fri, Jan 19, 2018 at 03:47:38PM -0800, Jason Ekstrand wrote:
> Now that we're tracking aux properly per-slice, we can enable this for
> applications which actually care.
> ---
> src/intel/vulkan/anv_blorp.c | 22 +++---
> src/intel/vulkan/genX_cmd_buffer.c | 13 +--
On 22/01/18 23:45, Nicolai Hähnle wrote:
On 22.01.2018 04:57, Timothy Arceri wrote:
Fixes the following piglit tests:
arb_blend_func_extended-fbo-extended-blend
arb_blend_func_extended-fbo-extended-blend-explicit
arb_blend_func_extended-fbo-extended-blend-explicit_gles3
arb_blend_func_extende
On Fri, Jan 19, 2018 at 03:47:39PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/blorp/blorp.h | 9 +--
> src/intel/blorp/blorp_clear.c | 10
> src/intel/blorp/blorp_genX_exec.h | 16 ++--
> src/intel/blorp/blorp_priv.h
On 22/01/18 23:37, Nicolai Hähnle wrote:
Why hasn't this been noticed before?
I knew it was broken but the state tracker needed to be fixed first
which I hadn't gotten to, fortunately Rob fixed it for me :) [1]
[1]
https://cgit.freedesktop.org/mesa/mesa/commit/?id=4c69961daf45a6a64970e5831
On Fri, Jan 19, 2018 at 03:47:40PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/blorp/blorp.c | 2 +-
> src/intel/blorp/blorp.h | 19 +
> src/intel/blorp/blorp_clear.c | 2 +-
> src/intel/blorp/blorp_genX_exec.h
https://bugs.freedesktop.org/show_bug.cgi?id=104553
--- Comment #8 from Ilia Mirkin ---
FYI idr had a separate script to reduce the giant test cases to the
smallest that would still fail. It should be in one of his piglit branches
in his personal fd.o git repo. (I'm on the go, hence no specific U
On 22 January 2018 at 12:29, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> src/intel/common/gen_defines.h | 52
> ++
> 1 file changed, 52 insertions(+)
> create mode 100644 src/intel/common/gen_defines.h
>
Please add the file to the src/intel
Signed-off-by: Chuck Atkins
---
src/gallium/drivers/swr/swr_loader.cpp | 100 +
src/gallium/drivers/swr/swr_public.h | 6 +-
src/gallium/drivers/swr/swr_screen.cpp | 26 +++--
src/gallium/drivers/swr/swr_screen.h | 3 +
4 files changed, 79 insertions(+
Signed-off-by: Chuck Atkins
---
src/gallium/drivers/swr/swr_loader.cpp | 100 +
src/gallium/drivers/swr/swr_public.h | 6 +-
src/gallium/drivers/swr/swr_screen.cpp | 26 +++--
src/gallium/drivers/swr/swr_screen.h | 3 +
4 files changed, 79 insertions(+
Courtesy of clang static analyzer.
I was hunting for potential sources of memory corruption using Mesa with
a GL trace, and happened to find this (unrelated) issue.
---
src/gallium/drivers/svga/svga_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/svga/svga_contex
For context, without this, the library handle from dlopen never get's
closed, even under successful operation, and the swr_screen created never
get's freed on error. Also error conditions resulted in exit() rather than
NULL return.
- Chuck
On Mon, Jan 22, 2018 at 10:12 AM, Chuck Atkins
wrote:
According to the SPIR-V spec:
“Stream must be an of a constant instruction with a scalar
integer type. That constant is the output-primitive stream number.”
The previous code was treating it as an integer literal.
---
This is part of the GL SPIR-V branch to enable streams for transform
feedbac
On 22 January 2018 at 15:13, Jose Fonseca wrote:
> Courtesy of clang static analyzer.
>
> I was hunting for potential sources of memory corruption using Mesa with
> a GL trace, and happened to find this (unrelated) issue.
> ---
> src/gallium/drivers/svga/svga_context.c | 1 +
> 1 file changed, 1
On 22 January 2018 at 15:12, Chuck Atkins wrote:
> Signed-off-by: Chuck Atkins
Please include your follow-up reply/context as commit message.
> // arch-specific dll entry point
> PUBLIC struct pipe_screen *swr_create_screen_internal(struct sw_winsys
> *winsys);
>
> +// cleanup for failed scre
On 21 January 2018 at 16:15, Jason Ekstrand wrote:
> Fair enough. I wasn't sure what you meant.
>
> Reviewed-by: Jason Ekstrand
>
Thanks, tweaked a bit and pushed to master.
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.
Am 22.01.2018 um 08:16 schrieb Tapani Pälli:
>
>
> On 01/22/2018 08:48 AM, Ilia Mirkin wrote:
>> What es3 does require, though, is mrt. Maybe add something that
>> ensures that mrt is supported?
>
> I guess that would be EXT_draw_buffers? That is currently enabled with
> 'dummy_true'.
But only b
https://bugs.freedesktop.org/show_bug.cgi?id=100951
--- Comment #4 from Kristian Høgsberg ---
Can you really claim it's "known broken" when nobody told the maintainer?
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.__
On 22.01.2018 17:10, Emil Velikov wrote:
On 22 January 2018 at 12:29, Tapani Pälli wrote:
Signed-off-by: Tapani Pälli
---
src/intel/common/gen_defines.h | 52 ++
1 file changed, 52 insertions(+)
create mode 100644 src/intel/common/gen_defines.h
Hi Emil,
Please include your follow-up reply/context as commit message.
>
Will do.
> +// cleanup for failed screen creation
> > +PUBLIC void swr_destroy_screen_internal(struct swr_screen **screen);
>
> I'm fairly sure you don't need to make this function public. It's used
> within the same bina
https://bugs.freedesktop.org/show_bug.cgi?id=103543
Vedran Miletić changed:
What|Removed |Added
Status|NEEDINFO|NEW
CC|
This makes the followingt changes to address cleanup issues:
- Error conditions now return null instead of calling exit()
- swr_creen is now freed upon error, rather than leak.
- Library handle from dlopen is now closed upon swr_screen destruction
v2: Added additional context in commit msg and rem
https://bugs.freedesktop.org/show_bug.cgi?id=103543
--- Comment #8 from Vedran Miletić ---
Created attachment 136898
--> https://bugs.freedesktop.org/attachment.cgi?id=136898&action=edit
build errors
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Cont
This makes the following changes to address cleanup issues:
- Error conditions now return NULL instead of calling exit()
- swr_creen is now freed upon error, rather than leak.
- Library handle from dlopen is now closed upon swr_screen destruction
v2: Added additional context in commit msg and remo
On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand wrote:
> We need this to ensure that GTT maps work on buffers we get from Vulkan
> on the off chance that someone does a readpixels or something. Soon, we
> will be removing GTT maps from i965 entirely and this can be reverted.
> None the less, it's
On 22.01.2018 15:16, Nicolai Hähnle wrote:
On 19.01.2018 07:05, Tapani Pälli wrote:
On 01/18/2018 05:49 PM, Nicolai Hähnle wrote:
On 17.01.2018 17:10, Tapani Pälli wrote:
On 17.01.2018 13:34, Nicolai Hähnle wrote:
On 15.01.2018 13:31, Tapani Pälli wrote:
Hello;
Here's a refactored ser
From: Emil Velikov
With earlier rework the user and provider of the symbol are within the
same binary. Thus there's no point in exporting the function.
Spotted while reviewing patch from Chuck, that nearly added another
unneeded PUBLIC function.
Cc: Chuck Atkins
Cc: Tim Rowley
Fixes: f50aa214
On 22 January 2018 at 17:03, Chuck Atkins wrote:
> Hi Emil,
>
>> Please include your follow-up reply/context as commit message.
>
>
> Will do.
>
>
>> > +// cleanup for failed screen creation
>> > +PUBLIC void swr_destroy_screen_internal(struct swr_screen **screen);
>>
>> I'm fairly sure you don't
https://bugs.freedesktop.org/show_bug.cgi?id=104732
Bug ID: 104732
Summary: [radv] Binding descriptor sets disturbs other pipeline
bindings
Product: Mesa
Version: git
Hardware: All
OS: All
Status
Hi Emil,
Fixes: a4be2bcee2f ("swr: allow a single swr architecture to be builtin")
>
It doesn't fix anything that was broken from that commit. The issues with
error handling were already present before then, it's just that the changes
in a4be2bcee2f were substantial so this commit works off the
On January 22, 2018 09:10:52 Kristian Høgsberg wrote:
On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand wrote:
We need this to ensure that GTT maps work on buffers we get from Vulkan
on the off chance that someone does a readpixels or something. Soon, we
will be removing GTT maps from i965 ent
On Mon, Jan 22, 2018 at 10:03 AM, Jason Ekstrand wrote:
> On January 22, 2018 09:10:52 Kristian Høgsberg wrote:
>
>> On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand
>> wrote:
>>>
>>> We need this to ensure that GTT maps work on buffers we get from Vulkan
>>> on the off chance that someone does a
On Sun, Jan 21, 2018 at 8:05 PM, Jason Ekstrand wrote:
> This new function is an import and a set tiling in one go.
> ---
> src/mesa/drivers/dri/i965/brw_bufmgr.c | 41
> ++
> src/mesa/drivers/dri/i965/brw_bufmgr.h | 4
> 2 files changed, 36 insertions(+), 9
On Fri, Jan 19, 2018 at 03:47:21PM -0800, Jason Ekstrand wrote:
> Reviewed-by: Topi Pohjolainen
> ---
> src/intel/vulkan/anv_blorp.c | 38
> ++
> src/intel/vulkan/anv_private.h | 9 +
> src/intel/vulkan/genX_cmd_buffer.c | 13 +++--
>
On Thursday, January 18, 2018 11:47:33 PM PST Iago Toral wrote:
> On Thu, 2018-01-18 at 15:49 -0800, Kenneth Graunke wrote:
> > We have to start render targets at binding table index 0 in order to
> > use
> > headerless FB write messages, and in fact already assume this in a
> > bunch
> > of places
On Fri, Jan 19, 2018 at 03:47:23PM -0800, Jason Ekstrand wrote:
> v2 (Jason Ekstrand):
> - Return an enum instead of a boolean
>
> Reviewed-by: Topi Pohjolainen
> ---
> src/intel/vulkan/anv_image.c | 70
> ++
> src/intel/vulkan/anv_private.h | 13 +
On Mon, Jan 22, 2018 at 4:29 AM, Tapani Pälli
wrote:
> v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris)
> use unreachable with unknown priority (Samuel)
>
> v3: add stubs in gem_stubs.c (Emil)
> use priority defines from gen_defines.h
>
> Signed-off-by: Tapani Pälli
> Reviewed-by: Samuel Ig
On Mon, Jan 22, 2018 at 10:48 AM, Nanley Chery
wrote:
> On Fri, Jan 19, 2018 at 03:47:23PM -0800, Jason Ekstrand wrote:
> > v2 (Jason Ekstrand):
> > - Return an enum instead of a boolean
> >
> > Reviewed-by: Topi Pohjolainen
> > ---
> > src/intel/vulkan/anv_image.c | 70 +
On Fri, Jan 19, 2018 at 03:47:26PM -0800, Jason Ekstrand wrote:
> This moves it to being based on layout_to_aux_usage instead of being
> hard-coded based on bits of a priori knowledge of how transitions
> interact with layouts. This conceptually simplifies things because
> we're now using layout_t
On Mon, Jan 22, 2018 at 11:03:07AM -0800, Jason Ekstrand wrote:
> On Mon, Jan 22, 2018 at 10:48 AM, Nanley Chery
> wrote:
>
> > On Fri, Jan 19, 2018 at 03:47:23PM -0800, Jason Ekstrand wrote:
> > > v2 (Jason Ekstrand):
> > > - Return an enum instead of a boolean
> > >
> > > Reviewed-by: Topi Poh
1 - 100 of 152 matches
Mail list logo
