Re: [Mesa-dev] [PATCH 3/4] i965/bufmgr: Add a set_tiling helper

2018-01-12 Thread Chris Wilson
Quoting Jason Ekstrand (2018-01-12 01:40:52) > This helper should be used carefully as setting tiling is a racy > operation since it potentially interacts with other processes. Still, > it is a useful thing to be able to do. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/drivers/dri/

Re: [Mesa-dev] Update radeon/uvd and radeon/vcn mpeg2 quantiser matrices only when required and modify the st/va accordingly

2018-01-12 Thread Christian König
A bit text in the actual mail would have been nice. E.g. that this is to fix VA-API issues with GStreamer and MPEG2. Anyway patches are Reviewed-by: Christian König . Regards, Christian. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https:/

[Mesa-dev] [PATCH] ac/shader: gather If TES reads TESSINNER or TESSOUTER

2018-01-12 Thread Samuel Pitoiset
This shouldn't be scanned in the pipeline. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 +- src/amd/common/ac_nir_to_llvm.h | 1 - src/amd/common/ac_shader_info.c | 4 src/amd/common/ac_shader_info.h | 3 +++ src/amd/vulkan/radv_pipeline.c | 2 -- 5 files changed,

Re: [Mesa-dev] [PATCH 23/29] anv/cmd_buffer: Sync clear values in begin_subpass

2018-01-12 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:13PM -0800, Jason Ekstrand wrote: > This is quite a bit cleaner because we now sync the clear values at the > same time as we do the fast clear. For loading the clear values into > the surface state, we now do it once when we handle the LOAD_OP_LOAD > instead of every

[Mesa-dev] Update radeon/uvd and radeon/vcn mpeg2 quantiser matrices only when required and modify the st/va accordingly

2018-01-12 Thread Das, Indrajit-kumar
0002-radeon-vcn-update-quantiser-matrices-only-when-reque.patch Description: 0002-radeon-vcn-update-quantiser-matrices-only-when-reque.patch 0003-st-va-clear-pointers-for-mpeg2-quantiser-matrices.patch Description: 0003-st-va-clear-pointers-for-mpeg2-quantiser-matrices.patch 0001-radeon-uvd-

[Mesa-dev] [PATCH v2] loader/dri3: Avoid freeing renderbuffers in use

2018-01-12 Thread Thomas Hellstrom
Upon reception of an event that lowered the number of active back buffers, the code would immediately try to free all back buffers with an id equal to or higher than the new number of active back buffers. However, that could lead to an active or to-be-active back buffer being freed, since the old

Re: [Mesa-dev] [PATCH] ac/shader: gather If TES reads TESSINNER or TESSOUTER

2018-01-12 Thread Timothy Arceri
Looks good to me. Reviewed-by: Timothy Arceri On 12/01/18 22:49, Samuel Pitoiset wrote: This shouldn't be scanned in the pipeline. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 +- src/amd/common/ac_nir_to_llvm.h | 1 - src/amd/common/ac_shader_info.c | 4

Re: [Mesa-dev] [PATCH 24/29] anv/cmd_buffer: Do subpass image transitions in begin/end_subpass

2018-01-12 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:14PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 187 > + > 1 file changed, 65 insertions(+), 122 deletions(-) > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

2018-01-12 Thread Robert Foss
On 1/12/18 9:29 AM, Tomasz Figa wrote: Hi Rob, On Fri, Jan 12, 2018 at 5:26 AM, Robert Foss wrote: Heya, On 12/22/17 1:09 PM, Tomasz Figa wrote: On Fri, Dec 22, 2017 at 10:09 AM, Gurchetan Singh wrote: So the plan is for alloc_handle_t to not be sub-classed by the implementations, but

Re: [Mesa-dev] [PATCH 22/29] anv/cmd_buffer: Add a concept of pending load aspects

2018-01-12 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:12PM -0800, Jason Ekstrand wrote: > These are the same as pending clear aspects only for the "load" > operation. Reviewed-by: Topi Pohjolainen > --- > src/intel/vulkan/anv_private.h | 1 + > src/intel/vulkan/genX_cmd_buffer.c | 22 -- > 2 f

[Mesa-dev] [PATCH] ac: remove ac_shader_variant_info::fs::output_mask

2018-01-12 Thread Samuel Pitoiset
Unused. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 2 -- src/amd/common/ac_nir_to_llvm.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 90856933fd..7dff5fcaf8 100644 --- a/src/amd/common/ac_ni

[Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

2018-01-12 Thread Jon Turney
'meson -Ddri-drivers= -Dgallium-drivers=swrast -Dglx=dri' fails with 'dri based GLX requires at least one DRI driver' Signed-off-by: Jon Turney --- meson.build | 2 +- src/glx/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build ind

[Mesa-dev] [PATCH 0/2] meson: Fixes when gallium swarast is the only driver configured

2018-01-12 Thread Jon Turney
Jon Turney (2): meson: Fix configuring dri glx with only gallium drivers meson: Fix install and linking of gallium swrast only driver include/meson.build| 2 +- meson.build| 2 +- src/gallium/meson.build| 2 +- src/ga

[Mesa-dev] [PATCH 2/2] meson: Fix install and linking of gallium swrast only driver

2018-01-12 Thread Jon Turney
When configured 'meson -Ddri-drivers= -Dgallium-drivers=swrast -Dglx=dri' link and install a galliumized swrast_dri.so Also install dri.pc and internal/dri_interface.h Signed-off-by: Jon Turney --- include/meson.build| 2 +- src/gallium/meson.build| 2

Re: [Mesa-dev] [PATCH 21/29] anv/cmd_buffer: Iterate all subpass attachments when clearing

2018-01-12 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:11PM -0800, Jason Ekstrand wrote: > This unifies things a bit because we now handle depth and stencil at the > same time. It also ensures that clears happen for input attachments. > --- > src/intel/vulkan/genX_cmd_buffer.c | 69 >

Re: [Mesa-dev] [PATCH 24/29] anv/cmd_buffer: Do subpass image transitions in begin/end_subpass

2018-01-12 Thread Pohjolainen, Topi
On Tue, Nov 28, 2017 at 10:13:52AM -0800, Jason Ekstrand wrote: > On Tue, Nov 28, 2017 at 10:07 AM, Jason Ekstrand > wrote: > > > This patch causes a perf drop in sascha gears. I'm investigating. > > > > Found it! Read below. > > > > On Mon, Nov 27, 2017 at 7:06 PM, Jason Ekstrand > > wrote

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

2018-01-12 Thread Tomasz Figa
Hi Rob, On Fri, Jan 12, 2018 at 5:26 AM, Robert Foss wrote: > Heya, > > > On 12/22/17 1:09 PM, Tomasz Figa wrote: >> >> On Fri, Dec 22, 2017 at 10:09 AM, Gurchetan Singh >> wrote: >>> >>> So the plan is for alloc_handle_t to not be sub-classed by the >>> implementations, but have all necessary i

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

2018-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104214 ubitux changed: What|Removed |Added CC||freedesk...@pkh.me --- Comment #48 from ubitux

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

2018-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104214 Tapani Pälli changed: What|Removed |Added CC||martin.pe...@free.fr --- Comment #49 fro

Re: [Mesa-dev] [PATCH 2/2] [rfc] radv: inline push constants where possible. (v2)

2018-01-12 Thread Alex Smith
Looks like it's working fine here now. One comment inline below. On 12 January 2018 at 02:43, Dave Airlie wrote: > From: Dave Airlie > > Instead of putting the push constants into the upload buffer, > if we have space in the sgprs we can upload the per-stage > constants into the shaders directl

Re: [Mesa-dev] [PATCH v2 2/2] broadcom/vc4: Add support for HW perfmon

2018-01-12 Thread Boris Brezillon
On Thu, 11 Jan 2018 16:42:45 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > The V3D engine provides several perf counters. > > Implement ->get_driver_query_[group_]info() so that these counters are > > exposed through the GL_AMD_performance_monitor extension. > > This all looks goo

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

2018-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #50 from Martin Peres --- (In reply to Tapani Pälli from comment #49) > (In reply to Thomas Hellström from comment #47) > > (In reply to Mark Janes from comment #45) > > > Thomas: do you have any ideas on how we could catch this cat

Re: [Mesa-dev] [PATCH] st/mesa: enable ARB_enhanced_layouts on nir drivers

2018-01-12 Thread Rob Clark
On Fri, Jan 12, 2018 at 12:52 AM, Timothy Arceri wrote: > I'm guessing this may have been disable because of missing > component packing support. However recent nir linking changes > required nir based gallium drivers to support component packing > so this should now be ok to enable. > > Cc: Rob C

[Mesa-dev] [PATCH] ac: fix build error in si_shader

2018-01-12 Thread Mauro Rossi
assert() is replaced by unreachable(), to avoid following building error: external/mesa/src/gallium/drivers/radeonsi/si_shader.c:1967:1: error: control may reach end of non-void function [-Werror,-Wreturn-type] } ^ 1 error generated. Fixes: c797cd6 ("ac: add load_patch_vertices_in() to the abi")

Re: [Mesa-dev] [PATCH 5/6] i965/draw: Do resolves properly for textures used by TXF

2018-01-12 Thread Iago Toral
On Thu, 2018-01-11 at 07:38 -0800, Jason Ekstrand wrote: > On Thu, Jan 11, 2018 at 1:48 AM, Iago Toral > wrote: > > On Wed, 2018-01-10 at 11:22 -0800, Jason Ekstrand wrote: > > > > > --- > > > > >  src/mesa/drivers/dri/i965/brw_draw.c | 41 > > > > > > > > >

Re: [Mesa-dev] [PATCH v2] isl: don't crash when creating a huge image

2018-01-12 Thread Samuel Iglesias Gonsálvez
On 11/01/18 23:27, Jason Ekstrand wrote: > Sorry.  It's taken a bit of time but the WG has a decision and that is > that we are supposed to throw VK_ERROR_OUT_OF_DEVICE_MEMORY in this > case.  I believe you had an alternate version of the patch that did > something like that.  If so, we should re

[Mesa-dev] [PATCH 1/2] st/va: remove TODO line for JPEG data buffer handling

2018-01-12 Thread Leo Liu
Nothing to do Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index 895157375a..9adbe48f43 100644 --- a/src/gallium/state_trackers/va/picture.c

[Mesa-dev] [PATCH 2/2] st/va: add break for MPEG4 data buffer handling case

2018-01-12 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index 9adbe48f43..67177c783a 100644 --- a/src/gallium/state_trackers/va/picture.c +++ b/src/gal

Re: [Mesa-dev] [PATCH] amd/common: fix loading InstanceID for tess on < GFX9

2018-01-12 Thread Bas Nieuwenhuizen
On Thu, Jan 11, 2018 at 2:58 PM, Samuel Pitoiset wrote: > > > On 01/11/2018 02:56 PM, Samuel Pitoiset wrote: >> >> InstanceID is in VGPR2, not 1. >> >> One more failure that CTS didn't catch up... >> >> Reported-by: Alex Smith >> Signed-off-by: Samuel Pitoiset >> --- >> src/amd/common/ac_nir_t

Re: [Mesa-dev] [PATCH] radv/radeonsi/nir: lower 64bit flrp

2018-01-12 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Fri, Jan 12, 2018 at 1:13 AM, Timothy Arceri wrote: > Fixes a bunch of arb_gpu_shader_fp64 piglit tests for example: > > generated_tests/spec/arb_gpu_shader_fp64/execution/built-in-functions/fs-mix-double-double-double.shader_test > --- > src/amd/vulkan/radv_sh

Re: [Mesa-dev] [PATCH 2/2] ac/nir: fix translation of nir_op_b2i for doubles

2018-01-12 Thread Bas Nieuwenhuizen
Maybe just zero-extend the 32-bit value? (or truncate for 16-bit?) I don't know what generates better machinecode. On Fri, Jan 12, 2018 at 2:34 AM, Timothy Arceri wrote: > --- > > Open to suggestions for better ways to do this. > > src/amd/common/ac_nir_to_llvm.c | 13 ++--- > 1 file ch

Re: [Mesa-dev] [PATCH] ac: fix build error in si_shader

2018-01-12 Thread Bas Nieuwenhuizen
On Fri, Jan 12, 2018 at 3:47 PM, Mauro Rossi wrote: > assert() is replaced by unreachable(), to avoid following building error: > > external/mesa/src/gallium/drivers/radeonsi/si_shader.c:1967:1: > error: control may reach end of non-void function [-Werror,-Wreturn-type] > } > ^ > 1 error generated

Re: [Mesa-dev] Update radeon/uvd and radeon/vcn mpeg2 quantiser matrices only when required and modify the st/va accordingly

2018-01-12 Thread Leo Liu
On 01/12/2018 04:18 AM, Christian König wrote: A bit text in the actual mail would have been nice. E.g. that this is to fix VA-API issues with GStreamer and MPEG2. Anyway patches are Reviewed-by: Christian König . Please use `git send-email` instead of attachment. Also please add RB and a

Re: [Mesa-dev] [PATCH 1/2] st/va: remove TODO line for JPEG data buffer handling

2018-01-12 Thread Christian König
Am 12.01.2018 um 16:30 schrieb Leo Liu: Nothing to do Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/state_trackers/va/picture.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c ind

[Mesa-dev] [PATCH mesa] docs: ask for backport nominations to cc: the author

2018-01-12 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- docs/submittingpatches.html | 4 1 file changed, 4 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 0581391b2958253b8f4d..ba09aa4ad7329327e760 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.ht

[Mesa-dev] [PATCH mesa] docs/submittingpatches: document when to push patches

2018-01-12 Thread Eric Engestrom
Suggested-by: Emil Velikov Signed-off-by: Eric Engestrom --- docs/submittingpatches.html | 26 ++ 1 file changed, 26 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index ba09aa4ad7329327e760..34c375cdaa44fe4fc197 100644 --- a/docs/su

Re: [Mesa-dev] [PATCH 25/29] anv/cmd_buffer: Avoid unnecessary transitions before fast clears

2018-01-12 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:15PM -0800, Jason Ekstrand wrote: > Previously, we would always apply the layout transition at the beginning > of the subpass and then do the clear whether fast or slow. This meant > that there were some cases, specifically when the initial layout is > VK_IMAGE_LAYOUT

[Mesa-dev] [PATCH libdrm 2/2] drm/tegra: Sanitize format modifiers

2018-01-12 Thread Thierry Reding
From: Thierry Reding The existing format modifier definitions were merged prematurely, and recent work has unveiled that the definitions are suboptimal in several ways: - The format specifiers, except for one, are not Tegra specific, but the names don't reflect that. - The number space i

[Mesa-dev] [PATCH libdrm 1/2] drm/fourcc: Fix fourcc_mod_code() definition

2018-01-12 Thread Thierry Reding
From: Thierry Reding Avoid compiler warnings when the val parameter is an expression. Signed-off-by: Thierry Reding --- include/drm/drm_fourcc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index 3ad838d3f93f..a76ed8f9e

[Mesa-dev] [PATCH libdrm 0/2] drm/tegra: Sanitize format modifiers

2018-01-12 Thread Thierry Reding
From: Thierry Reding These UABI changes have now been merged into drm-next, so synchronize the libdrm headers and fixup the format modifiers in modetest. Thierry Thierry Reding (2): drm/fourcc: Fix fourcc_mod_code() definition drm/tegra: Sanitize format modifiers include/drm/drm_fourcc.h

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

2018-01-12 Thread Gurchetan Singh
> > Alright, so if I understand this correctly importing process would always > call gralloc registerBuffer(), which means that the FPs would always be > correct and usable by the importing process? Yes, the Android framework calls registerBuffer() when importing the buffer to a different process

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

2018-01-12 Thread Adam Jackson
On Fri, 2018-01-12 at 13:18 +, Jon Turney wrote: > 'meson -Ddri-drivers= -Dgallium-drivers=swrast -Dglx=dri' fails with 'dri > based GLX requires at least one DRI driver' > > Signed-off-by: Jon Turney > --- > meson.build | 2 +- > src/glx/meson.build | 2 +- > 2 files changed, 2 inse

Re: [Mesa-dev] meson: vdpau broken on r600

2018-01-12 Thread Ilia Mirkin
BTW, that should have said 'strace -f -e open', otherwise you get _way_ too much junk. On Thu, Jan 11, 2018 at 6:35 PM, Dylan Baker wrote: > Thanks Ilia, I figured there must be some GL_DRIVERS_PATH equivalent but > couldn't find it with google, I never think to run strace. That's probably the >

Re: [Mesa-dev] [PATCH 0/3] Meson build system

2018-01-12 Thread Eric Engestrom
On Monday, 2018-01-08 16:14:43 -0800, Dylan Baker wrote: > I forgot to CC you on this like you asked, Thanks for the ping :) I noticed a couple issues on patches 1 & 2, but those are easy to fix, and with that the series is r-b me. Thanks for the effort of writing the whole thing! I'll be glad t

Re: [Mesa-dev] meson: vdpau broken on r600

2018-01-12 Thread Dylan Baker
Thanks Ilia, I figured there must be some GL_DRIVERS_PATH equivalent but couldn't find it with google, I never think to run strace. That's probably the information I need to check on my nouveau machine. Dylan Quoting Ilia Mirkin (2018-01-11 15:30:23) > It looks at the vdpau provider sent down dow

Re: [Mesa-dev] [PATCH 1/3] Add meson build system

2018-01-12 Thread Eric Engestrom
On Friday, 2018-01-05 12:00:58 -0800, Dylan Baker wrote: > This patch adds a complete meson build system, including tests and > install. It has the necessary hooks to allow it be used as a subproject > for other meson based builds such as mesa. > > Signed-off-by: Dylan Baker > Reviewed-and-tested

Re: [Mesa-dev] [PATCH 2/3] autotools: Include meson.build files in tarball

2018-01-12 Thread Eric Engestrom
On Friday, 2018-01-05 12:00:59 -0800, Dylan Baker wrote: > Signed-off-by: Dylan Baker > --- > Makefile.am | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 7b86214..66f70ca 100644 > --- a/Makefile.am > +++ b/

Re: [Mesa-dev] [PATCH 3/3] README: Add note about meson

2018-01-12 Thread Eric Engestrom
On Friday, 2018-01-05 12:01:00 -0800, Dylan Baker wrote: > Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom > --- > README | 24 +--- > 1 file changed, 21 insertions(+), 3 deletions(-) > > diff --git a/README b/README > index 26cab9d..f3df9ac 100644 > --- a/README >

Re: [Mesa-dev] [PATCH 26/29] intel/blorp: Add a CCS ambiguation pass

2018-01-12 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:16PM -0800, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.h | 5 ++ > src/intel/blorp/blorp_clear.c | 106 > ++ > 2 files changed, 111 insertions(+) Reviewed-by: Topi Pohjolainen > > diff --git a/src/intel/blo

Re: [Mesa-dev] [PATCH 27/29] anv/cmd_buffer: Pull the undefined layout condition into the if

2018-01-12 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:17PM -0800, Jason Ekstrand wrote: > Now that this isn't a multi-case if and it's just the one case, it's a > bit clearer if the condition is just part of the if instead of being > pulled out into a boolean variable. Reviewed-by: Topi Pohjolainen > --- > src/intel/v

Re: [Mesa-dev] [PATCH 28/29] anv/cmd_buffer: Re-arrange the logic around UNDEFINED fast-clears

2018-01-12 Thread Pohjolainen, Topi
On Mon, Nov 27, 2017 at 07:06:18PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 31 ++- > 1 file changed, 14 insertions(+), 17 deletions(-) Reviewed-by: Topi Pohjolainen > > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/

Re: [Mesa-dev] [PATCH 17/29] anv/cmd_buffer: Move the color portion of clear_subpass into begin_subpass

2018-01-12 Thread Pohjolainen, Topi
On Thu, Jan 11, 2018 at 01:50:41PM -0800, Nanley Chery wrote: > On Fri, Dec 08, 2017 at 04:16:04PM +0200, Pohjolainen, Topi wrote: > > On Mon, Nov 27, 2017 at 07:06:07PM -0800, Jason Ekstrand wrote: > > > This doesn't really change much now but it will give us more/better > > > control over clears

Re: [Mesa-dev] [PATCH 17/29] anv/cmd_buffer: Move the color portion of clear_subpass into begin_subpass

2018-01-12 Thread Nanley Chery
On Mon, Nov 27, 2017 at 07:06:07PM -0800, Jason Ekstrand wrote: > This doesn't really change much now but it will give us more/better > control over clears in the future. The one interesting functional > change here is that we are now re-emitting 3DSTATE_DEPTH_BUFFERS and > friends for each clear.

Re: [Mesa-dev] [PATCH 3/4] i965/bufmgr: Add a set_tiling helper

2018-01-12 Thread Jason Ekstrand
On Fri, Jan 12, 2018 at 1:28 AM, Chris Wilson wrote: > Quoting Jason Ekstrand (2018-01-12 01:40:52) > > This helper should be used carefully as setting tiling is a racy > > operation since it potentially interacts with other processes. Still, > > it is a useful thing to be able to do. > > > > Cc

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

2018-01-12 Thread Rob Herring
On Fri, Jan 12, 2018 at 2:29 AM, Tomasz Figa wrote: > Hi Rob, > > On Fri, Jan 12, 2018 at 5:26 AM, Robert Foss > wrote: >> Heya, >> >> >> On 12/22/17 1:09 PM, Tomasz Figa wrote: >>> >>> On Fri, Dec 22, 2017 at 10:09 AM, Gurchetan Singh >>> wrote: So the plan is for alloc_handle_t to n

Re: [Mesa-dev] [PATCH 18/29] intel/blorp: Add a blorp_hiz_clear_depth_stencil helper

2018-01-12 Thread Nanley Chery
On Mon, Nov 27, 2017 at 07:06:08PM -0800, Jason Ekstrand wrote: > This is similar to blorp_gen8_hiz_clear_attachments except that it takes > actual images instead of trusting in the already set depth state. > --- > src/intel/blorp/blorp.h | 11 ++ > src/intel/blorp/blorp_clear.c | 50

[Mesa-dev] [PATCH 1/7] Allow warsow 85.shader_test to build on GLSL 1.20

2018-01-12 Thread Ian Romanick
From: Ian Romanick Nothing in the shader actually requires 1.30. This allows it to build on GM45 and Iron Lake... and other platforms stuck at GLSL 1.20. Signed-off-by: Ian Romanick --- shaders/warsow/85.shader_test | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 2/7] run: Use case independent matching for platform names

2018-01-12 Thread Ian Romanick
From: Ian Romanick All my scripts use uppercase names to generate names for results files. Signed-off-by: Ian Romanick --- run.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run.c b/run.c index 69fe23d..aa26946 100644 --- a/run.c +++ b/run.c @@ -395,7 +395,7 @@ main(int

[Mesa-dev] [PATCH 5/7] report.py: Add option to only display measurements that have changes

2018-01-12 Thread Ian Romanick
From: Ian Romanick This is useful for preparing data to go in a Mesa commit message. Signed-off-by: Ian Romanick --- report.py | 53 +++-- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/report.py b/report.py index e0068bc..72752c

[Mesa-dev] [PATCH 7/7 RFC] report.py: Gather and log some statistics about the helped / hurt data

2018-01-12 Thread Ian Romanick
From: Ian Romanick Also perform a T-test on the helped and hurt, and provide a recommendation based on the result of the T-test. I have seen several instances where the result of the T-test is the opposite of what you would expect by looking at the other logged data, so I'm not sure how useful /

[Mesa-dev] [PATCH 3/7] intel_run: Fix typo in LD_PRELOAD handling

2018-01-12 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- intel_run | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/intel_run b/intel_run index 10114ff..5a162f8 100755 --- a/intel_run +++ b/intel_run @@ -1,5 +1,5 @@ #!/bin/bash # -*- mode: sh -*- -LD_PRELOAD=${PWD}/intel_stub.s

[Mesa-dev] [PATCH 4/7] report.py: Add option to only display the final summary

2018-01-12 Thread Ian Romanick
From: Ian Romanick This is useful for preparing data to go in a Mesa commit message. Signed-off-by: Ian Romanick --- report.py | 60 1 file changed, 32 insertions(+), 28 deletions(-) diff --git a/report.py b/report.py index 003a1ee.

[Mesa-dev] [PATCH 6/7] report.py: Print small percentages as <.01%

2018-01-12 Thread Ian Romanick
From: Ian Romanick Previously an absolute value less than 0.0001 would be printed as 0.00%. Signed-off-by: Ian Romanick --- report.py | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/report.py b/report.py index 72752c1..175a953 100755 --- a/report.py +++ b/report.p

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

2018-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103078 Timo Aaltonen changed: What|Removed |Added CC||azari4...@gmail.com --- Comment #10 fro

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

2018-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103078 --- Comment #11 from Timo Aaltonen --- *** Bug 103217 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

2018-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103078 --- Comment #12 from Timo Aaltonen --- this is a bug in jogl, and apparently changing it to detect current Mesa makes it work again: https://jogamp.org/bugzilla/show_bug.cgi?id=1357 -- You are receiving this mail because: You are the assignee

[Mesa-dev] [PATCH 4/4] gallium/hud: Fix support for PIPE_DRIVER_QUERY_TYPE_FLOAT

2018-01-12 Thread Brian Paul
Evidently, nobody has used PIPE_DRIVER_QUERY_TYPE_FLOAT up to this point. Adding a driver query of this type which returns the query value in pipe_query_result::f resulted in garbage output in the HUD. The problem is the pipe_query_result::f field was being accessed as through the u64 field and b

[Mesa-dev] [PATCH 1/4] gallium/hud: s/unsigned/enum pipe_query_type/

2018-01-12 Thread Brian Paul
--- src/gallium/auxiliary/hud/hud_driver_query.c | 5 +++-- src/gallium/auxiliary/hud/hud_private.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_driver_query.c b/src/gallium/auxiliary/hud/hud_driver_query.c index 085bc62..630aae0 10064

[Mesa-dev] [PATCH 3/4] gallium/hud: remove uint64_t casts in sensor query_sti_load() function

2018-01-12 Thread Brian Paul
The hud_graph_add_value() function takes a double value, so just pass the current/critical values as-is since they're doubles. --- src/gallium/auxiliary/hud/hud_sensors_temp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_sensors_temp.

[Mesa-dev] [PATCH 2/4] gallium/hud: compute cpu load, percent with doubles

2018-01-12 Thread Brian Paul
The hud_graph_add_value() function takes a double precision value, so compute it that way. --- src/gallium/auxiliary/hud/hud_cpu.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_cpu.c b/src/gallium/auxiliary/hud/hud_cpu.c index 259bb83..

[Mesa-dev] [PATCH] svga: add num-commands-per-draw HUD query

2018-01-12 Thread Brian Paul
This query shows the ratio of total commands vs. drawing commands sent to the vgpu device. This gives some idea of how many state changes are sent per draw call. The closer the ratio is to 1.0, the better. --- src/gallium/drivers/svga/svga_cmd.c| 4 src/gallium/drivers/svga/svga_cmd

[Mesa-dev] [PATCH 02/17] vbo: whitespace fixes in vbo_save.h

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save.h | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index 485b7b1..2eec87a 100644 --- a/src/mesa/vbo/vbo_save.h +++ b/src/mesa/vbo/vbo_save.h @@ -76,8 +76,8 @@ struct vb

[Mesa-dev] [PATCH 04/17] vbo: rename vbo_save_vertex_store::buffer to buffer_map

2018-01-12 Thread Brian Paul
To match other parts of the VBO code and make things easier to understand. --- src/mesa/vbo/vbo_save.h | 2 +- src/mesa/vbo/vbo_save_api.c | 25 + src/mesa/vbo/vbo_save_draw.c | 2 +- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/src/mesa/vbo/vbo_

[Mesa-dev] [PATCH 07/17] vbo: remove unused vbo_save_context::count field

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index 74ff07e..34a7588 100644 --- a/src/mesa/vbo/vbo_save.h +++ b/src/mesa/vbo/vbo_save.h @@ -136,7 +136,6 @@ struct vbo_save_context { GLboolean out_of_memory; /**

[Mesa-dev] [PATCH 05/17] vbo: rename vbo_save_vertex_list::count to vertex_count

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save.h | 2 +- src/mesa/vbo/vbo_save_api.c | 14 +++--- src/mesa/vbo/vbo_save_draw.c | 9 + 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index 5eed3ae..2720d13 100644 --- a/src/mesa/v

[Mesa-dev] [PATCH 08/17] vbo: rename vbo_save_context::buffer to buffer_map

2018-01-12 Thread Brian Paul
And move the field and improve comments. --- src/mesa/vbo/vbo_save.h | 4 ++-- src/mesa/vbo/vbo_save_api.c | 14 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index 34a7588..e9f3cae 100644 --- a/src/mesa/vbo/vbo

[Mesa-dev] [PATCH 01/17] vbo: whitespace fixes in vbo_save_draw.c

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save_draw.c | 61 ++-- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/src/mesa/vbo/vbo_save_draw.c b/src/mesa/vbo/vbo_save_draw.c index 2a20bb8..17eff9b 100644 --- a/src/mesa/vbo/vbo_save_draw.c +++ b/src/mesa/vbo/vbo_sa

[Mesa-dev] [PATCH 09/17] vbo: removed unused ctx parameter for alloc_prim_store()

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save_api.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index 8312969..fefe420 100644 --- a/src/mesa/vbo/vbo_save_api.c +++ b/src/mesa/vbo/vbo_save_api.c @@ -294,11 +294,10 @@ vbo_save_unma

[Mesa-dev] [PATCH 15/17] vbo: add some comments in vbo_save_api.c

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save_api.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index 8eb3846..42d883f 100644 --- a/src/mesa/vbo/vbo_save_api.c +++ b/src/mesa/vbo/vbo_save_api.c @@ -1559,6 +1559,9 @@ vbo_save_SaveFlus

[Mesa-dev] [PATCH 16/17] vbo: rewrite some code in playback_copy_to_current()

2018-01-12 Thread Brian Paul
I think this is a little easier to understand. --- src/mesa/vbo/vbo_save_draw.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/mesa/vbo/vbo_save_draw.c b/src/mesa/vbo/vbo_save_draw.c index ee7f509..1694a04 100644 --- a/src/mesa/vbo/vbo_save_draw.c +++ b/src/

[Mesa-dev] [PATCH 11/17] vbo: minor code simplification in _save_compile_vertex_list()

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save_api.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index 84d8d1e..cb48cb8 100644 --- a/src/mesa/vbo/vbo_save_api.c +++ b/src/mesa/vbo/vbo_save_api.c @@ -501,10 +501,11 @@ _save_compi

[Mesa-dev] [PATCH 06/17] vbo: s/GLuint/GLbitfield/ for vbo_save_context::replay_flags

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index 2720d13..74ff07e 100644 --- a/src/mesa/vbo/vbo_save.h +++ b/src/mesa/vbo/vbo_save.h @@ -138,7 +138,7 @@ struct vbo_save_context { fi_type *buf

[Mesa-dev] [PATCH 10/17] vbo: rename prim to prims

2018-01-12 Thread Brian Paul
Using a plural name makes it easier to see that this is an array and not a pointer to a single object. --- src/mesa/vbo/vbo_save.h | 4 +-- src/mesa/vbo/vbo_save_api.c | 82 ++-- src/mesa/vbo/vbo_save_draw.c | 8 ++--- 3 files changed, 47 insertions(

[Mesa-dev] [PATCH 03/17] vbo: rename vbo_save_primitive_store::buffer to prims

2018-01-12 Thread Brian Paul
A little easier to understand. --- src/mesa/vbo/vbo_save.h | 2 +- src/mesa/vbo/vbo_save_api.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index 2eec87a..8240261 100644 --- a/src/mesa/vbo/vbo_save.h +++ b/src/mesa/vbo

[Mesa-dev] [PATCH 12/17] vbo: add comment that vbo_save_vertex_list::buffer_offset is in bytes

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h index 32782b13e..9d13e0a 100644 --- a/src/mesa/vbo/vbo_save.h +++ b/src/mesa/vbo/vbo_save.h @@ -73,7 +73,7 @@ struct vbo_save_vertex_list { fi_type

[Mesa-dev] [PATCH 13/17] vbo: rename some functions in vbo_save_draw.c

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save_draw.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/vbo/vbo_save_draw.c b/src/mesa/vbo/vbo_save_draw.c index d10d2dd..ee7f509 100644 --- a/src/mesa/vbo/vbo_save_draw.c +++ b/src/mesa/vbo/vbo_save_draw.c @@ -44,8 +44,8 @@

[Mesa-dev] [PATCH 17/17] vbo: optimize some display list drawing

2018-01-12 Thread Brian Paul
The vbo_save_vertex_list structure records one or more glBegin/End primitives which all have the same vertex format. To draw these primitives, we setup the vertex array state, then issue the drawing command. Before, the 'start' vertex was typically zero and we used the vertex array pointer to ind

[Mesa-dev] [PATCH 14/17] vbo: rename some functions in vbo_save_api.c

2018-01-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save_api.c | 74 ++--- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index cb48cb8..8eb3846 100644 --- a/src/mesa/vbo/vbo_save_api.c +++ b/src/mesa/vbo/vbo_save_

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

2018-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103078 --- Comment #13 from Roland Scheidegger --- (In reply to Timo Aaltonen from comment #12) > this is a bug in jogl, and apparently changing it to detect current Mesa > makes it work again: > > https://jogamp.org/bugzilla/show_bug.cgi?id=1357 The

Re: [Mesa-dev] [PATCH 19/29] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

2018-01-12 Thread Nanley Chery
On Mon, Nov 27, 2017 at 07:06:09PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 243 > - > src/intel/vulkan/anv_private.h | 17 ++- > src/intel/vulkan/genX_cmd_buffer.c | 68 ++- > 3 files changed, 188 insertions(+), 1

Re: [Mesa-dev] [PATCH 17/17] vbo: optimize some display list drawing

2018-01-12 Thread Ian Romanick
On 01/12/2018 02:23 PM, Brian Paul wrote: > The vbo_save_vertex_list structure records one or more glBegin/End > primitives which all have the same vertex format. > > To draw these primitives, we setup the vertex array state, then > issue the drawing command. Before, the 'start' vertex was typica

Re: [Mesa-dev] [PATCH 01/17] vbo: whitespace fixes in vbo_save_draw.c

2018-01-12 Thread Ian Romanick
Patches 1 - 16 are Reviewed-by: Ian Romanick I sent some comments / questions on patch 17. On 01/12/2018 02:23 PM, Brian Paul wrote: > --- > src/mesa/vbo/vbo_save_draw.c | 61 > ++-- > 1 file changed, 31 insertions(+), 30 deletions(-) > > diff --git a/

[Mesa-dev] [PATCH 09/10] i915: Silence unused parameter warnings

2018-01-12 Thread Ian Romanick
From: Ian Romanick ../../SOURCE/master/src/mesa/drivers/dri/i915/intel_fbo.c: In function ‘intel_alloc_window_storage’: ../../SOURCE/master/src/mesa/drivers/dri/i915/intel_fbo.c:290:48: warning: unused parameter ‘ctx’ [-Wunused-parameter] intel_alloc_window_storage(struct gl_context * ctx, str

[Mesa-dev] [PATCH 01/10] mesa: Also track a remapped version of the color logic op

2018-01-12 Thread Ian Romanick
From: Ian Romanick With the exception of NVIDIA hardware, these are is the values that all hardware and Gallium want. The remapping is currently implemented in at least 6 places. This starts the process of consolidating to a single place. Signed-off-by: Ian Romanick --- src/mesa/main/blend.c

[Mesa-dev] [PATCH 10/10] nouveau: Remove no-op nvgl_logicop_func function

2018-01-12 Thread Ian Romanick
From: Ian Romanick The values that this function returned were always the values passed in. The only thing that happened was either an assertion or undefined results when an unknown value was passed in. This doesn't seem that useful. Most of nouveau_gldefs.h could be removed in this manner. S

[Mesa-dev] [PATCH 02/10] i965: Use the translated color logic op from the context

2018-01-12 Thread Ian Romanick
From: Ian Romanick And delete the resulting dead code. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_context.h | 1 - src/mesa/drivers/dri/i965/genX_state_upload.c | 3 +- src/mesa/drivers/dri/i965/intel_state.c | 41 --- 3 files changed, 1

Re: [Mesa-dev] [PATCH 02/29] anv/blorp: Rework image clear/resolve helpers

2018-01-12 Thread Jason Ekstrand
On Tue, Dec 5, 2017 at 3:48 PM, Nanley Chery wrote: > On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote: > > This replaces image_fast_clear and ccs_resolve with two new helpers that > > simply perform an isl_aux_op whatever that may be on CCS or MCS. This > > is a bit cleaner as it

[Mesa-dev] [PATCH 06/10] i915: Use enum color_logic_ops for blits

2018-01-12 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_blit.c | 34 ++ src/mesa/drivers/dri/i915/intel_blit.h | 6 ++--- src/mesa/drivers/dri/i915/intel_fbo.c | 2 +- src/mesa/drivers/dri/i915/intel_mipmap_tree.c |

[Mesa-dev] [PATCH 07/10] i965: Make intelEmitCopyBlit static

2018-01-12 Thread Ian Romanick
From: Ian Romanick And rename to emit_copy_blit. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/intel_blit.c | 398 - src/mesa/drivers/dri/i965/intel_blit.h | 16 -- 2 files changed, 199 insertions(+), 215 deletions(-) diff --git a/src/mesa/drivers/

[Mesa-dev] [PATCH 08/10] i915: Make intelEmitCopyBlit static

2018-01-12 Thread Ian Romanick
From: Ian Romanick And rename to emit_copy_blit. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_blit.c | 299 +++ src/mesa/drivers/dri/i915/intel_blit.h | 16 -- src/mesa/drivers/dri/i915/intel_screen.h | 1 - 3 files changed, 149 insertions(

  1   2   >