[Mesa-dev] [PATCH 5/8] radv: use vk_zalloc instead of vk_alloc+memset

2017-11-10 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 5 ++--- src/amd/vulkan/radv_device.c | 14 +- src/amd/vulkan/radv_image.c | 5 ++--- src/amd/vulkan/radv_pipeline.c | 10 -- 4 files changed, 13 insertions(+), 21 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 4/8] radv: remove unnecessary memset() in radv_AllocateCommandBuffers()

2017-11-10 Thread Samuel Pitoiset
This should not be needed, if the allocation fails an error is returned and the host should handle it. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c ind

[Mesa-dev] [PATCH 2/8] radv: remove useless memset() in radv_CreateFence()

2017-11-10 Thread Samuel Pitoiset
All radv_fence fields are initialized here. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 5754816b14..aa0511fd8d 100644 --- a/src/amd/vulkan/radv_device.c +++ b/

[Mesa-dev] [PATCH 7/8] radv: optimize calling radv_cmd_buffer_trace_emit()

2017-11-10 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 10 +- src/amd/vulkan/radv_meta_buffer.c | 3 ++- src/amd/vulkan/si_cmd_buffer.c| 7 +-- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_

[Mesa-dev] [PATCH 3/8] radv: remove useless initializations in radv_create_cmd_buffer()

2017-11-10 Thread Samuel Pitoiset
There is a memset() above. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 563a54be52..1131cf6d89 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b

[Mesa-dev] [PATCH 1/8] radv: use vk_error() everywhere an error is returned

2017-11-10 Thread Samuel Pitoiset
For consistency and it might help for debugging purposes. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- src/amd/vulkan/radv_device.c | 36 ++-- src/amd/vulkan/radv_formats.c| 2 +- src/amd/vulkan/radv_pipeline.c

[Mesa-dev] [PATCH 8/8] radv: add unlikely() around radv_save_descriptors()

2017-11-10 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 7c163bdd4d..462790d5d0 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulk

[Mesa-dev] [PATCH 6/8] radv: optimize calling radv_save_pipeline()

2017-11-10 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index f58731b003..ee7f514f5f 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/s

[Mesa-dev] [PATCH] i965: Make L3 configuration atom listen for TCS/TES program updates.

2017-11-10 Thread Kenneth Graunke
The L3 configuration code already considers the TCS and TES programs, but failed to listen for TCS/TES program changes. This was somehow missing. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/drivers/dri/i965/gen7_l3_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/dri

[Mesa-dev] [PATCH] st/atifs: remove unrequired initialisation of gl_program fields

2017-11-10 Thread Timothy Arceri
As far as I can tell these fields are only used to query arb program info and are not related to ATI_fragment_shader. Cc: Miklós Máté --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 4 1 file changed, 4 deletions(-) diff --git a/src/mesa/state_tracker/st_atifs_to_tgsi.c b/src/mesa/state_

[Mesa-dev] [PATCH 1/2] radv: force enable LLVM sisched for The Talos Principle

2017-11-10 Thread Samuel Pitoiset
It seems safe and it improves performance by +4% (73->76). A drirc based solution is not what we want for now, keep it simple and improve later if it's really needed. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 20 1 file changed, 20 insertions(+) dif

[Mesa-dev] [PATCH 2/2] radv: add nosisched debug option

2017-11-10 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_device.c | 9 + 2 files changed, 10 insertions(+) diff --git a/src/amd/vulkan/radv_debug.h b/src/amd/vulkan/radv_debug.h index 193bca5f81..8e09c36528 100644 --- a/src/amd/vulkan/radv_debug.h +++ b/

[Mesa-dev] [PATCH] gallium/u_threaded: fix end_query regression

2017-11-10 Thread Nicolai Hähnle
From: Nicolai Hähnle Ouch... Fixes: 244536d3d6b4 ("gallium/u_threaded: avoid syncs for get_query_result") --- src/gallium/auxiliary/util/u_threaded_context.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_threaded_context.c b/src/gallium/auxiliary/util/u_thre

[Mesa-dev] [PATCH] util/u_queue: handle OS_TIMEOUT_INFINITE in util_queue_fence_wait_timeout

2017-11-10 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes e.g. piglit/bin/bufferstorage-persistent read -auto Fixes: e6dbc804a87a ("winsys/amdgpu: handle cs_add_fence_dependency for deferred/unsubmitted fences") --- src/util/u_queue.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/util/u_queue.h b/src/util/u_

Re: [Mesa-dev] [PATCH 3/3] etnaviv: Add sampler TS support

2017-11-10 Thread Wladimir J. van der Laan
On Fri, Nov 10, 2017 at 07:42:12AM +0100, Wladimir J. van der Laan wrote: > Hello Lucas, > > On Thu, Nov 09, 2017 at 06:15:51PM +0100, Lucas Stach wrote: > > Hi Wladimir! > > > > etna_resource_needs_flush is only called from two places - here, and > > > in resource_flush, where it also determines

[Mesa-dev] [PATCH] st/atifs: merge gl_program and ati_fragment_shader

2017-11-10 Thread Timothy Arceri
This increases the size of gl_program but in future a union can be used to offset this increase in memory use. Combining the two reduces code and make it easier to follow. Cc: Miklós Máté --- NOTE: compile tested only. src/mesa/drivers/common/driverfuncs.c | 3 - src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-10 Thread Julien Isorce
Thx for the suggestions. Anyone familiar with _mesa_get_format_block_size and _mesa_get_format_bytes wants to review this patch ? On 9 November 2017 at 17:10, Eric Engestrom wrote: > On Thursday, 2017-11-09 17:03:13 +, Julien Isorce wrote: > > v2: add early return if (flag & MAP_INTERNAL_MA

Re: [Mesa-dev] [PATCH 16/17] util: Add Mesa ARB_get_program_binary helper functions

2017-11-10 Thread Jose Fonseca
On 10/11/17 03:40, Jordan Justen wrote: On 2017-11-09 08:07:57, Jose Fonseca wrote: On 09/11/17 13:19, Emil Velikov wrote: Hi Jordan, On 9 November 2017 at 06:42, Jordan Justen wrote: Signed-off-by: Jordan Justen --- src/util/Makefile.sources | 2 + src/util/meson.build | 2 +

[Mesa-dev] [PATCH] util/u_thread: fix compilation on Mac OS

2017-11-10 Thread Nicolai Hähnle
From: Nicolai Hähnle Apparently, it doesn't have pthread barriers. p_config.h (which was originally used to guard this code) uses the __APPLE__ macro to detect Mac OS. Fixes: f0d3a4de75 ("util: move pipe_barrier into src/util and rename to util_barrier") Cc: Roland Scheidegger --- src/util/u

Re: [Mesa-dev] [PATCH v2 01/26] util: move os_time.[ch] to src/util

2017-11-10 Thread Jon Turney
On 06/11/2017 10:23, Nicolai Hähnle wrote: diff --git a/src/gallium/auxiliary/os/os_time.h b/src/util/os_time.h similarity index 89% rename from src/gallium/auxiliary/os/os_time.h rename to src/util/os_time.h index ca0bdd5a0c4..049ab118db2 100644 --- a/src/gallium/auxiliary/os/os_time.h +++ b/src

Re: [Mesa-dev] [PATCH] gallium/u_threaded: fix end_query regression

2017-11-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Nov 10, 2017 at 10:01 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Ouch... > > Fixes: 244536d3d6b4 ("gallium/u_threaded: avoid syncs for get_query_result") > --- > src/gallium/auxiliary/util/u_threaded_context.c | 2 -- > 1 file changed, 2 deleti

Re: [Mesa-dev] [PATCH] util/u_thread: fix compilation on Mac OS

2017-11-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Nov 10, 2017 at 12:38 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Apparently, it doesn't have pthread barriers. > > p_config.h (which was originally used to guard this code) uses the > __APPLE__ macro to detect Mac OS. > > Fixes: f0d3a4de75 ("uti

Re: [Mesa-dev] [PATCH] util/u_queue: handle OS_TIMEOUT_INFINITE in util_queue_fence_wait_timeout

2017-11-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Nov 10, 2017 at 10:41 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes e.g. piglit/bin/bufferstorage-persistent read -auto > > Fixes: e6dbc804a87a ("winsys/amdgpu: handle cs_add_fence_dependency for > deferred/unsubmitted fences") > --- > src/

Re: [Mesa-dev] [PATCH] st/atifs: remove unrequired initialisation of gl_program fields

2017-11-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Nov 10, 2017 at 9:49 AM, Timothy Arceri wrote: > As far as I can tell these fields are only used to query arb > program info and are not related to ATI_fragment_shader. > > Cc: Miklós Máté > --- > > src/mesa/state_tracker/st_atifs_to_tgsi.c | 4 > 1

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-10 Thread Jon Turney
On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaration of timespec_get() also needs to be provided for POSIX systems which don't have it. Not noticed previously as it (or xtime_get()) doesn't seem to have had any users, prior to thi

[Mesa-dev] [Bug 103668] mesa-17.3.0_rc3: FAIL: glsl/tests/cache-test

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103668 Bug ID: 103668 Summary: mesa-17.3.0_rc3: FAIL: glsl/tests/cache-test Product: Mesa Version: 17.3 Hardware: PowerPC OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 103668] mesa-17.3.0_rc3: FAIL: glsl/tests/cache-test

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103668 --- Comment #1 from Eric Engestrom --- (In reply to erhard_f from comment #0) > Failed to create ./cache-test-tmp/xdg-cache-home for shader cache (No such > file or directory)---disabling. > Failed to create ./cache-test-tmp/mesa-glsl-cache-dir

[Mesa-dev] [PATCH] st/program: fix compute shader nir references

2017-11-10 Thread Rob Clark
In case the IR is NIR, the driver takes reference to the nir_shader. Also, because there are no variants, we need to clone the shader, instead of sharing the reference with gl_program, which would result in a double free in _mesa_delete_program(). Signed-off-by: Rob Clark Reviewed-by: Marek Olšák

Re: [Mesa-dev] [PATCH 10/13] meson: build gallium xvmc state tracker

2017-11-10 Thread Aaron Watry
On Wed, 2017-11-01 at 15:49 -0700, Dylan Baker wrote: > --- > meson.build | 34 +- > meson_options.txt | 13 ++ > src/gallium/meson.build | 7 ++- > src/gallium/state_trackers/xvmc/meson.build | 52 > +++

Re: [Mesa-dev] [PATCH] util/u_thread: fix compilation on Mac OS

2017-11-10 Thread Brian Paul
Reviewed-by: Brian Paul Thanks. I was going to look into that one today. On 11/10/2017 04:38 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle Apparently, it doesn't have pthread barriers. p_config.h (which was originally used to guard this code) uses the __APPLE__ macro to detect Mac OS. Fi

[Mesa-dev] [PATCH] glx/windows: Fix building libwindowsdri when libX11 headers are installed in a non-standard location

2017-11-10 Thread Jon Turney
Signed-off-by: Jon Turney --- src/glx/windows/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/windows/Makefile.am b/src/glx/windows/Makefile.am index f84288b935c..f4f8e9664d7 100644 --- a/src/glx/windows/Makefile.am +++ b/src/glx/windows/Makefile.am @@ -10,6 +10,9 @@ pk

[Mesa-dev] [Bug 103668] mesa-17.3.0_rc3: FAIL: glsl/tests/cache-test

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103668 --- Comment #2 from Emil Velikov --- I'm suspecting something Gentoo related - either layout or FS. We have a similar issue in bug 103122, again Gentoo. Issue may not be as widespread as it seems - 17.3.0-rc3 is fine on pq (Pekka) setup. -- Y

[Mesa-dev] [Bug 103668] mesa-17.3.0_rc3: FAIL: glsl/tests/cache-test

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103668 --- Comment #3 from Ilia Mirkin --- That's pretty different... the other issue is about disk management, and probably restricted by gentoo's auto-sandbox thing somehow. This is PPC, so more likely an endian issue in the cache key computation co

Re: [Mesa-dev] [PATCH 4/4] st/mesa: use asynchronous flushes for glFlush

2017-11-10 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Nov 9, 2017 at 2:45 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Having the gallium driver thread flush in the background should be > sufficient for glFlush semantics. > > Various end-of-frame flushes (from st_context_flush and st

[Mesa-dev] [Bug 103668] mesa-17.3.0_rc3: FAIL: glsl/tests/cache-test

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103668 --- Comment #4 from Emil Velikov --- Right my bad. I missed the PPC piece in the report :-\ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.__

[Mesa-dev] [AppVeyor] mesa master #6106 failed

2017-11-10 Thread AppVeyor
Build mesa 6106 failed Commit d473f91758 by Bruce Cherniak on 11/9/2017 12:39 AM: swr: Fixed an uncommon freed-memory access during state validation\n\nState validation is performed during clear and draw calls. Validation\nduring clear was still accessing vert

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-11-10 Thread Emil Velikov
On 8 November 2017 at 22:10, Harish Krupo wrote: > Hi Emil, > > Emil Velikov writes: > >> On 27 October 2017 at 05:54, Harish Krupo wrote: >>> Hi Eric, >>> >>> Eric Engestrom writes: >>> On Monday, 2017-10-23 16:20:54 +0530, Harish Krupo wrote: > This passes 33/37 deqp tests related to

Re: [Mesa-dev] [PATCH] st/dri: fix android fence regression

2017-11-10 Thread Emil Velikov
On 9 November 2017 at 19:15, Marek Olšák wrote: > From: Marek Olšák > > Fixes piglit - egl_khr_fence_sync/android_native tests. > Broken by 884a0b2a9e55d4c1ca39475b50d9af598d7d7280. Introduce state-tracker flush flags, analogous to the pipe ones. Use the former when with stapi->flush(). Fixes:

Re: [Mesa-dev] [PATCH] util/u_thread: fix compilation on Mac OS

2017-11-10 Thread Roland Scheidegger
Yes, I guess it's a limitation of not-quite-posix mac os :-). Reviewed-by: Roland Scheidegger Am 10.11.2017 um 12:38 schrieb Nicolai Hähnle: > From: Nicolai Hähnle > > Apparently, it doesn't have pthread barriers. > > p_config.h (which was originally used to guard this code) uses the > __APP

Re: [Mesa-dev] [PATCH v2 01/26] util: move os_time.[ch] to src/util

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 13:35, Jon Turney wrote: On 06/11/2017 10:23, Nicolai Hähnle wrote: diff --git a/src/gallium/auxiliary/os/os_time.h b/src/util/os_time.h similarity index 89% rename from src/gallium/auxiliary/os/os_time.h rename to src/util/os_time.h index ca0bdd5a0c4..049ab118db2 100644 --- a/src/

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaration of timespec_get() also needs to be provided for POSIX systems which don't have it. Not noticed previously as it (or xtime_get()) doesn't s

Re: [Mesa-dev] [PATCH] util/u_thread: fix compilation on Mac OS

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 16:39, Roland Scheidegger wrote: Yes, I guess it's a limitation of not-quite-posix mac os :-). Reviewed-by: Roland Scheidegger Thanks! About a minute too late though... ;) Am 10.11.2017 um 12:38 schrieb Nicolai Hähnle: From: Nicolai Hähnle Apparently, it doesn't have pth

[Mesa-dev] [AppVeyor] mesa master #6107 completed

2017-11-10 Thread AppVeyor
Build mesa 6107 completed Commit e7972b8943 by Nicolai Hähnle on 11/10/2017 11:36 AM: util/u_thread: fix compilation on Mac OS\n\nApparently, it doesn't have pthread barriers.\n\np_config.h (which was originally used to guard this code) uses the\n__APPLE__ macr

Re: [Mesa-dev] [PATCH] st/dri: fix android fence regression

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 16:31, Emil Velikov wrote: On 9 November 2017 at 19:15, Marek Olšák wrote: From: Marek Olšák Fixes piglit - egl_khr_fence_sync/android_native tests. Broken by 884a0b2a9e55d4c1ca39475b50d9af598d7d7280. Introduce state-tracker flush flags, analogous to the pipe ones. Use the for

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-10 Thread Rafael Antognolli
On Fri, Nov 10, 2017 at 10:46:03AM +, Julien Isorce wrote: > Thx for the suggestions. > > Anyone familiar with _mesa_get_format_block_size and _mesa_get_format_bytes > wants to review this patch ? > > On 9 November 2017 at 17:10, Eric Engestrom wrote: > > On Thursday, 2017-11-09 17:03:

Re: [Mesa-dev] [PATCH 02/13] i965: remove ARB_compute_shader extension override

2017-11-10 Thread Emil Velikov
On 7 November 2017 at 11:54, Emil Velikov wrote: > From: Emil Velikov > > Checking the override was useful in the early stages of developing the > extension. > > Now that everything is wired, where possible, we can drop the check. > Doing so allows us to simplify some of the related code. > > Cc:

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] mesa 17.3.0-rc3

2017-11-10 Thread Andres Gomez
Hi, It seems we are a bit delayed with regard to the release-calendar [1]. Let's see when we finally get the final 17.3.0 but it may be that we will need to add a new cycle for 17.2.x and, also, move the 17.3.x release dates. Mentioning this specifically because I won't be able to be to the task

Re: [Mesa-dev] [PATCH 1/2] anv/gen10: Implement WaSampleOffsetIZ workaround

2017-11-10 Thread Rafael Antognolli
Since it's anv, I would like to hear from Jason or Nanley too. But it does seem to implement the workaround correctly, like we do in i965, so you have my Reviewed-by: Rafael Antognolli On Thu, Nov 09, 2017 at 11:14:42AM -0800, Anuj Phogat wrote: > We already have this workaround in OpenGL driver

Re: [Mesa-dev] [PATCH 2/2] anv/gen10: Enable float blend optimization

2017-11-10 Thread Rafael Antognolli
On Thu, Nov 09, 2017 at 11:14:43AM -0800, Anuj Phogat wrote: > On CNL this bit has been moved to CACHE_MODE_SS register. > We already have this enabled in OpenGL driver. > See Mesa commit 6c681b4cc1 > > Signed-off-by: Anuj Phogat > Cc: Nanley Chery > Cc: Rafael Antognolli > --- > src/intel/gen

Re: [Mesa-dev] [PATCH 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

2017-11-10 Thread Ian Romanick
(Sending from my phone... Sorry.) The one thing I would add is an issues section with a single issue about the decision to use a single enum for everything. On November 9, 2017 12:42:58 AM Jordan Justen wrote: Similar idea to Tim's "spec: MESA_program_binary", but simplified and written

[Mesa-dev] [Bug 103671] os_time.c:104:4: error: implicit declaration of function 'usleep' is invalid in C99

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103671 Bug ID: 103671 Summary: os_time.c:104:4: error: implicit declaration of function 'usleep' is invalid in C99 Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH 06/20] radeonsi: add nir support for es epilogue

2017-11-10 Thread Marek Olšák
On Fri, Nov 10, 2017 at 4:13 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_shader.c | 32 > +--- > 1 file changed, 21 insertions(+), 11 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_shader.c > b/src/gallium/drivers/radeonsi/si_shad

Re: [Mesa-dev] [PATCH 05/20] radeonsi: add nir support for ls epilogue

2017-11-10 Thread Marek Olšák
On Fri, Nov 10, 2017 at 4:13 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_shader.c | 37 > +++- > 1 file changed, 22 insertions(+), 15 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_shader.c > b/src/gallium/drivers/radeonsi/si_shad

Re: [Mesa-dev] [PATCH 07/20] radeonsi: add nir support for gs epilogue

2017-11-10 Thread Marek Olšák
On Fri, Nov 10, 2017 at 4:13 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_shader.c | 21 +++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_shader.c > b/src/gallium/drivers/radeonsi/si_shader.c > index 10

Re: [Mesa-dev] [PATCH 04/20] ac: add emit_vertex to the abi

2017-11-10 Thread Marek Olšák
Patches 2 - 4: Reviewed-by: Marek Olšák Marek On Fri, Nov 10, 2017 at 4:13 AM, Timothy Arceri wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 11 +- > src/amd/common/ac_shader_abi.h | 4 > src/gallium/drivers/radeonsi/si_shader.c | 35 > +++--

Re: [Mesa-dev] [PATCH 10/20] radeonsi: introduce bitcast_llvmtype()

2017-11-10 Thread Marek Olšák
I don't think this wrapper is useful. Marek On Fri, Nov 10, 2017 at 4:13 AM, Timothy Arceri wrote: > This is like bitcast() but takes an llvm type rather than a tgsi > type. > --- > src/gallium/drivers/radeonsi/si_shader_internal.h | 3 +++ > src/gallium/drivers/radeonsi/si_shader_tgsi_setup.

Re: [Mesa-dev] [PATCH] glx/windows: Fix building libwindowsdri when libX11 headers are installed in a non-standard location

2017-11-10 Thread Adam Jackson
On Fri, 2017-11-10 at 14:00 +, Jon Turney wrote: > Signed-off-by: Jon Turney Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 13/20] radeonsi: pass llvm type to lds_load()

2017-11-10 Thread Marek Olšák
You might want this applied before your patch: https://patchwork.freedesktop.org/patch/187534/ Marek On Fri, Nov 10, 2017 at 4:13 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_shader.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 09/20] radeonsi: get llvm types from ac

2017-11-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Nov 10, 2017 at 4:13 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c > b/src/galliu

[Mesa-dev] [PATCH] meson: don't us build_by_default for specific gallium drivers

2017-11-10 Thread Dylan Baker
Using build_by_default : false is convenient for dependencies that can be pulled in by various diverse components of the build system, the gallium hardware/software drivers and state trackers do not fit that description. Instead, these should be guarded using the variable that tracks whether that d

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-10 Thread Brian Paul
On 11/08/2017 08:27 PM, Brian Paul wrote: On 11/08/2017 08:12 PM, Brian Paul wrote: On 11/08/2017 06:28 PM, Ian Romanick wrote: Any thoughts about my data using __attribute__((__packed__))? Sorry, I didn't have time to dig into it. I took a look this evening. I think the ENUM_8BIT idea will

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

2017-11-10 Thread Marek Olšák
On Fri, Nov 10, 2017 at 2:09 AM, Connor Abbott wrote: > On Thu, Nov 9, 2017 at 7:17 PM, Marek Olšák wrote: >> On Fri, Nov 10, 2017 at 12:40 AM, Matt Arsenault wrote: >>> On Nov 10, 2017, at 07:41, Marek Olšák wrote: Hi, This fixes the TCS gl_ClipDistance piglit failure

[Mesa-dev] [Bug 103672] _mesa_meta_GenerateMipmap sub-optimal code and possible bug

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103672 Bug ID: 103672 Summary: _mesa_meta_GenerateMipmap sub-optimal code and possible bug Product: Mesa Version: unspecified Hardware: All OS: All St

[Mesa-dev] [PATCH] docs: update llvmpipe.html build instructions

2017-11-10 Thread Brian Paul
--- docs/llvmpipe.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html index 2efbbd4..e467692 100644 --- a/docs/llvmpipe.html +++ b/docs/llvmpipe.html @@ -108,10 +108,10 @@ To build everything on Linux invoke scons as: scons buil

[Mesa-dev] [PATCH 2/9] nir: Add SYSTEM_VALUE_BASE_VERTEX_ID instrinsics

2017-11-10 Thread Antia Puentes
Reviewed-by: Neil Roberts --- src/compiler/nir/nir.c | 4 src/compiler/nir/nir_gather_info.c | 1 + src/compiler/nir/nir_intrinsics.h | 1 + 3 files changed, 6 insertions(+) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index 7380bf436a8..6f0477b0676 100644 --- a

[Mesa-dev] [PATCH 1/9] compiler: Add new system value SYSTEM_VALUE_BASE_VERTEX_ID

2017-11-10 Thread Antia Puentes
This VS system value will contain the value passed as for indexed draw calls or the value passed as for non-indexed draw calls. It will be used to calculate the gl_VertexID as SYSTEM_VALUE_VERTEX_ID_ZERO_BASE plus SYSTEM_VALUE_BASE_VERTEX_ID. Note that the current calculation which uses SYSTEM_VA

[Mesa-dev] [PATCH 0/9] Fix shader_draw_parameters CTS tests

2017-11-10 Thread Antia Puentes
Hi, the series sets gl_BaseVertex to zero for gl*DrawArrays* in i965. Previously, its value was the value passed as in the non-indexed draw call. This was convinient because the gl_VertexID was calculated as gl_VertexIDBaseZero + gl_BaseVertex. However, as gl_BaseVertex must be zero for non-inde

[Mesa-dev] [PATCH 6/9] intel/compiler: implement the basevertex(id) load intrinsics

2017-11-10 Thread Antia Puentes
The gl_BaseVertex is in a new location now, and the new basevertexid occupies the old gl_BaseVertex place. Reviewed-by: Neil Roberts --- src/intel/compiler/brw_nir.c| 12 src/intel/compiler/brw_vec4.cpp | 14 -- 2 files changed, 16 insertions(+), 10 deletions(-) dif

[Mesa-dev] [PATCH 7/9] nir: Offset vertex_id by base_vertex_id instead of base_vertex

2017-11-10 Thread Antia Puentes
From: Neil Roberts base_vertex will be zero for non-indexed calls, but we need it to include the ‘first’ parameter. This is true for both GL and Vulkan. I think this patch will also affect freedreno and radeonsi. I believe if they are relying on this lowering then they are currently already brok

[Mesa-dev] [PATCH 3/9] intel/compiler: Add a uses_basevertexid flag

2017-11-10 Thread Antia Puentes
From: Neil Roberts --- src/intel/compiler/brw_compiler.h | 1 + src/intel/compiler/brw_vec4.cpp | 4 2 files changed, 5 insertions(+) diff --git a/src/intel/compiler/brw_compiler.h b/src/intel/compiler/brw_compiler.h index df6ee018546..6b5b73a54f0 100644 --- a/src/intel/compiler/brw_com

[Mesa-dev] [PATCH 4/9] i965: emit basevertexid as a vertex element component

2017-11-10 Thread Antia Puentes
The new basevertexid will be emitted in the position previously occupied by gl_BaseVertex. This way we can keep pointing the indirect buffer for indirect draw calls. The gl_BaseVertex is now emited as part of the draw_id VERTEX_ELEMENT. Reviewed-by: Neil Roberts --- src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 5/9] i965: gl_BaseVertex must be zero for non-indexed draw calls

2017-11-10 Thread Antia Puentes
- From the OpenGL 4.6 (11.1.3.9 Shader Inputs) specification: "gl_BaseVertex holds the integer value passed to the baseVertex parameter to the command that resulted in the current shader invocation. In the case where the command has no baseVertex parameter, the value of gl_BaseVertex is zero." -

[Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

2017-11-10 Thread Dylan Baker
These variables were removed from autotools in 2008 (sha: 80f68e1b6a0e5bd2da799c), but they have lived on here. The Scons build meanwhile doesn't set a patch/tiny version at all, just major and minor. This patch removes the unused variables and simply sets the version, leaving patch/tiny as 0 since

[Mesa-dev] [PATCH 9/9] spirv: Lower BaseVertex to BASE_VERTEX_ID instead of BASE_VERTEX

2017-11-10 Thread Antia Puentes
From: Neil Roberts The base vertex in Vulkan is different from GL in that for non-indexed primitives the value is taken from the firstVertex parameter instead of being set to zero. This coincides with the new SYSTEM_VALUE_BASE_VERTEX_ID instead of BASE_VERTEX. --- src/compiler/spirv/vtn_variable

[Mesa-dev] [PATCH 8/9] i965: Let nir lower gl_VertexID instead of the linker

2017-11-10 Thread Antia Puentes
From: Neil Roberts --- src/mesa/drivers/dri/i965/brw_context.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 19d5a2e3503..01c8e8cb3cf 100644 --- a/src/mesa/drivers/dri/i965/brw_contex

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 18:43, Marek Olšák wrote: On Fri, Nov 10, 2017 at 2:09 AM, Connor Abbott wrote: On Thu, Nov 9, 2017 at 7:17 PM, Marek Olšák wrote: On Fri, Nov 10, 2017 at 12:40 AM, Matt Arsenault wrote: On Nov 10, 2017, at 07:41, Marek Olšák wrote: Hi, This fixes the TCS gl_ClipDistance

Re: [Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

2017-11-10 Thread Brian Paul
On 11/10/2017 10:53 AM, Dylan Baker wrote: These variables were removed from autotools in 2008 (sha: 80f68e1b6a0e5bd2da799c), but they have lived on here. The Scons build meanwhile doesn't set a patch/tiny version at all, just major and minor. This patch removes the unused variables and simply se

Re: [Mesa-dev] [PATCH] meson: don't us build_by_default for specific gallium drivers

2017-11-10 Thread Dylan Baker
If fixed the typo in the subject locally. Quoting Dylan Baker (2017-11-10 09:23:37) > Using build_by_default : false is convenient for dependencies that can > be pulled in by various diverse components of the build system, the > gallium hardware/software drivers and state trackers do not fit that

Re: [Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

2017-11-10 Thread Emil Velikov
On 10 November 2017 at 17:53, Dylan Baker wrote: > These variables were removed from autotools in 2008 (sha: > 80f68e1b6a0e5bd2da799c), but they have lived on here. The Scons build > meanwhile doesn't set a patch/tiny version at all, just major and minor. > This patch removes the unused variables

Re: [Mesa-dev] [PATCH 0/9] Fix shader_draw_parameters CTS tests

2017-11-10 Thread Neil Roberts
Just to note, I made some Piglit patches to verify this new behaviour too: https://patchwork.freedesktop.org/series/33626/ This might make testing a little easier if someone wants to implement the behaviour for other drivers too. - Neil Antia Puentes writes: > Hi, > > the series sets gl_BaseV

[Mesa-dev] [PATCH] st/dri: fix deadlock when waiting on android fences

2017-11-10 Thread Marek Olšák
From: Marek Olšák Android fences can't be deferred, because st/dri calls fence_finish with ctx = NULL, so the driver can't flush u_threaded_context. --- src/gallium/include/state_tracker/st_api.h | 3 +-- src/gallium/state_trackers/dri/dri_helpers.c | 3 +-- src/mesa/state_tracker/st_manager.c

Re: [Mesa-dev] [PATCH 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

2017-11-10 Thread Jordan Justen
On 2017-11-10 08:43:37, Ian Romanick wrote: > > The one thing I would add is an issues section with a single issue about > the decision to use a single enum for everything. How does this sound? diff --git a/docs/specs/MESA_program_binary_formats.txt b/docs/specs/MESA_program_binary_formats.txt

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

2017-11-10 Thread Marek Olšák
On Fri, Nov 10, 2017 at 6:55 PM, Nicolai Hähnle wrote: > On 10.11.2017 18:43, Marek Olšák wrote: >> >> On Fri, Nov 10, 2017 at 2:09 AM, Connor Abbott >> wrote: >>> >>> On Thu, Nov 9, 2017 at 7:17 PM, Marek Olšák wrote: On Fri, Nov 10, 2017 at 12:40 AM, Matt Arsenault wrote: >

[Mesa-dev] add util_queue_fence_wait_timeout checkin breaks centos6 build

2017-11-10 Thread Kyriazis, George
Hello Nicolai, Your commit e3a8013 (util/u_queue: add util_queue_fence_wait_timeout), breaks the centos6 build. Specifically, I am getting: CC libmesautil_la-u_queue.lo ../../../src/util/u_queue.c: In function '_util_queue_fence_wait_timeout': ../../../src/util/u_queue.c:173:7: error: imp

Re: [Mesa-dev] [PATCH] meson: don't us build_by_default for specific gallium drivers

2017-11-10 Thread Lionel Landwerlin
Fixes a build issue with gallium headers trying to include llvm ones (which I don't have installed). Thanks! Tested-by: Lionel Landwerlin On 10/11/17 17:23, Dylan Baker wrote: Using build_by_default : false is convenient for dependencies that can be pulled in by various diverse components of

[Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Jordan Justen
Cc: Emil Velikov Cc: Dylan Baker Signed-off-by: Jordan Justen --- configure.ac | 6 +- meson.build | 6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 411c4f6b3e0..213cfe132fb 100644 --- a/configure.ac +++ b/configure.ac @@ -900,7 +

[Mesa-dev] [PATCH 2/4] util: Add u_zlib zlib wrappers

2017-11-10 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/util/Makefile.sources | 4 +- src/util/meson.build | 2 + src/util/u_zlib.c | 154 ++ src/util/u_zlib.h | 50 +++ 4 files changed, 209 insertions(+), 1 deletion(-) create mode 1

[Mesa-dev] [PATCH 3/4] util/disk_cache: Make zlib support optional

2017-11-10 Thread Jordan Justen
Cc: Timothy Arceri Signed-off-by: Jordan Justen --- src/util/disk_cache.c | 129 ++ 1 file changed, 15 insertions(+), 114 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index fde6e2e0974..911ca8f9234 100644 --- a/src/util/

Re: [Mesa-dev] [PATCH 0/5] Volatile and invariant LDS memory ops

2017-11-10 Thread Connor Abbott
On Fri, Nov 10, 2017 at 1:19 PM, Marek Olšák wrote: > On Fri, Nov 10, 2017 at 6:55 PM, Nicolai Hähnle wrote: >> On 10.11.2017 18:43, Marek Olšák wrote: >>> >>> On Fri, Nov 10, 2017 at 2:09 AM, Connor Abbott >>> wrote: On Thu, Nov 9, 2017 at 7:17 PM, Marek Olšák wrote: > > On F

[Mesa-dev] [PATCH 4/4] compiler: Fold shader_cache in with libglsl sources

2017-11-10 Thread Jordan Justen
It appears that we include the shader cache sources into libglsl regardless. The Meson build already does this. Signed-off-by: Jordan Justen --- src/compiler/Android.glsl.mk | 3 +-- src/compiler/Makefile.glsl.am | 3 +-- src/compiler/Makefile.sources | 6 ++ 3 files changed, 4 insertions(

[Mesa-dev] [Bug 103671] os_time.c:104:4: error: implicit declaration of function 'usleep' is invalid in C99

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103671 Jon Turney changed: What|Removed |Added CC||jon.tur...@dronecode.org.uk --- Comment #1

[Mesa-dev] [Bug 103671] os_time.c:104:4: error: implicit declaration of function 'usleep' is invalid in C99

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103671 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 103674] u_queue.c:173:7: error: implicit declaration of function 'timespec_get' is invalid in C99

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103674 Bug ID: 103674 Summary: u_queue.c:173:7: error: implicit declaration of function 'timespec_get' is invalid in C99 Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Dylan Baker
Quoting Jordan Justen (2017-11-10 10:24:36) > Cc: Emil Velikov > Cc: Dylan Baker > Signed-off-by: Jordan Justen > --- > configure.ac | 6 +- > meson.build | 6 +- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 411c4f6b3e0..213c

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-10 Thread Jon Turney
On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaration of timespec_get() also needs to be provided for POSIX systems which don't have it. Not noticed

Re: [Mesa-dev] [PATCH] anv: don't crash when creating a huge image

2017-11-10 Thread Chad Versace
On Thu 09 Nov 2017, Jason Ekstrand wrote: > On Thu, Nov 9, 2017 at 4:23 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > On Wed, Nov 8, 2017 at 1:34 AM, Samuel Iglesias Gonsálvez <[1] > > [2]sigles...@igalia.com> wrote: > > >

Re: [Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

2017-11-10 Thread Brian Paul
On 11/10/2017 11:08 AM, Emil Velikov wrote: On 10 November 2017 at 17:53, Dylan Baker wrote: These variables were removed from autotools in 2008 (sha: 80f68e1b6a0e5bd2da799c), but they have lived on here. The Scons build meanwhile doesn't set a patch/tiny version at all, just major and minor. T

[Mesa-dev] [Bug 103412] gallium/wgl: Another fix to context creation without prior SetPixelFormat()

2017-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103412 --- Comment #1 from Brian Paul --- Thanks. Looks good AFAICT. I'll do a little reformatting and testing before pushing. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] anv: don't crash when creating a huge image

2017-11-10 Thread Jason Ekstrand
On Fri, Nov 10, 2017 at 10:48 AM, Chad Versace wrote: > On Thu 09 Nov 2017, Jason Ekstrand wrote: > > On Thu, Nov 9, 2017 at 4:23 PM, Chad Versace <[1] > chadvers...@chromium.org> > > wrote: > > > > On Wed 08 Nov 2017, Jason Ekstrand wrote: > > > On Wed, Nov 8, 2017 at 1:34 AM, Samuel Igl

Re: [Mesa-dev] [PATCH 01/17] docs/specs: Add GL_MESA_program_binary_formats extension spec

2017-11-10 Thread Ian Romanick
Reviewed-by: Ian Romanick On November 10, 2017 12:17:38 PM Jordan Justen wrote: On 2017-11-10 08:43:37, Ian Romanick wrote: The one thing I would add is an issues section with a single issue about the decision to use a single enum for everything. How does this sound? diff --git a/docs

  1   2   >