[Mesa-dev] [PATCH 2/9] gallium/tgsi: start adding hw atomics (v2)

2017-11-03 Thread Dave Airlie
From: Dave Airlie This adds support for a hw atomic counters to TGSI. A new register file for storing atomic counters is added, along with a new atomic counter semantic, along with docs for both. v2: drop semantic, move hw counter to backend, Ilia pointed out SSO would have busted my plan, and

[Mesa-dev] [PATCH 3/9] gallium: add hw atomic buffer binding API.

2017-11-03 Thread Dave Airlie
From: Dave Airlie This API binds atomic buffers for all bound shaders (as per the GL semantics). This is needed to support cross shader hw atomic counters. Signed-off-by: Dave Airlie --- src/gallium/docs/source/context.rst | 8 src/gallium/include/pipe/p_context.h | 16

[Mesa-dev] [PATCH 1/9] gallium: add CAPs to support HW atomic counters. (v2)

2017-11-03 Thread Dave Airlie
From: Dave Airlie This looks like an evergreen specific feature, but with atomic counters AMD have hw specific counters they use instead of operating on buffers directly. These are separate to the buffer atomics, so require different limits and code paths. I've left the CAP for atomic type exten

[Mesa-dev] [PATCH 4/9] mesa/program: add hw atomic counter file

2017-11-03 Thread Dave Airlie
From: Dave Airlie This is needed for the GLSL->TGSI translation for hw atomic counters. Signed-off-by: Dave Airlie --- src/mesa/main/mtypes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 2acf64e..60f06aa 100644 --- a/src/mesa/main/mt

[Mesa-dev] [PATCH 7/9] st/mesa: add support for hw atomics to glsl->tgsi. (v2)

2017-11-03 Thread Dave Airlie
From: Dave Airlie This adds support for creating the hw atomic tgsi from the glsl codepaths. v2: drop the atomic index and move to backend. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 93 ++ 1 file changed, 82 insertions(+), 11 delet

[Mesa-dev] gallium/r600 hw atomic support v2

2017-11-03 Thread Dave Airlie
Ilia pointed out a bad assumption I made, so I've decided to move to allocating the hw indices in the backend, a bit ugly but seems to work. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mes

[Mesa-dev] [PATCH 5/9] st/mesa: start adding support for hw atomics atom.

2017-11-03 Thread Dave Airlie
From: Dave Airlie This adds a new atom that calls the new driver API to bind buffers containing hw atomics. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_atom_atomicbuf.c | 37 src/mesa/state_tracker/st_atom_list.h| 2 ++ src/mesa/state_tracke

[Mesa-dev] [PATCH 8/9] r600: add support for hw atomic counters. (v2)

2017-11-03 Thread Dave Airlie
From: Dave Airlie This adds support for the evergreen/cayman atomic counters. These are implemented using GDS append/consume counters. The values for each counter are loaded before drawing and saved after each draw using special CP packets. v2: move hw atomic assignment into driver. Signed-off

[Mesa-dev] [PATCH 9/9] docs: update r600 atomic counter status.

2017-11-03 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- docs/features.txt | 6 +++--- docs/relnotes/17.4.0.html | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index d228a02..1d03326 100644 --- a/docs/features.txt +++ b/docs/features.

[Mesa-dev] [PATCH 6/9] st/mesa: setup hw atomic limits.

2017-11-03 Thread Dave Airlie
From: Dave Airlie HW atomics need to use caps to set some limits, and some other limits may also need limiting. This fixes things up to work for evergreen hw, it may need more changes in the future if other hw wants to use this path. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_ex

[Mesa-dev] [PATCH] Android: update CleanSpec.mk

2017-11-03 Thread Chih-Wei Huang
The libraries are moved to /vendor since commit c3f75d48. Clean all old files for incremental builds. Signed-off-by: Chih-Wei Huang --- CleanSpec.mk | 7 +++ 1 file changed, 7 insertions(+) diff --git a/CleanSpec.mk b/CleanSpec.mk index d08b0def7d..eca3845354 100644 --- a/CleanSpec.mk +++ b

Re: [Mesa-dev] [PATCH mesa 2/2] meson: drop GLESv1 .so version back to 1.0.0

2017-11-03 Thread Eric Engestrom
On 2 November 2017 23:42:12 GMT, Eric Engestrom wrote: > autotools generates libGLESv1_CM.so.1.0.0, so let's make sure meson > does the same. > > Signed-off-by: Eric Engestrom > --- > src/mapi/es1api/meson.build | 2 +- > src/mapi/shared-glapi/meson.build | 1 + > 2 files changed, 2 ins

Re: [Mesa-dev] [PATCH] Android: update CleanSpec.mk

2017-11-03 Thread Tapani Pälli
Hi Chih-Wei; This looks good to me. Only thing that causes a bit of headache is ... what is the difference between PRODUCT_OUT, OUT_DIR and TARGET_OUT? On 11/03/2017 09:36 AM, Chih-Wei Huang wrote: The libraries are moved to /vendor since commit c3f75d48. Clean all old files for incremental b

Re: [Mesa-dev] [PATCH] radv: add initial copy descriptor support.

2017-11-03 Thread Samuel Pitoiset
On 11/03/2017 05:38 AM, Dave Airlie wrote: From: Dave Airlie It appears the latest dota2 vulkan uses this, and we get a hang in VR mode without it. Cc: "17.2 17.3" Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_descriptor_set.c | 61 ++-- 1 file chang

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

2017-11-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103543 --- Comment #3 from tjb...@scarlet.be --- 1. I reverted to meson-0.43.0 built from the release tarball. 2. I am now using llvm-5.0.0 built from the release tarball, with the following options: -DLLVM_ENABLE_ZLIB=1 -DLLVM_ENABLE_FFI=1 -DLLVM_TARGE

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

2017-11-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103543 --- Comment #4 from Michel Dänzer --- (In reply to tjbugs from comment #3) > [...] -DBUILD_SHARED_LIBS=1 [...] Don't enable BUILD_SHARED_LIBS, it's only for LLVM developers. Enable LLVM_LINK_LLVM_DYLIB instead. -- You are receiving this mail

Re: [Mesa-dev] [PATCH 1/4] intel/reg: Add helpers for 64-bit integer immediates

2017-11-03 Thread Michael Schellenberger Costa
Hi Jason, -Ursprüngliche Nachricht- Von: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] Im Auftrag von Jason Ekstrand Gesendet: Freitag, 3. November 2017 05:53 An: mesa-dev@lists.freedesktop.org Cc: Jason Ekstrand Betreff: [Mesa-dev] [PATCH 1/4] intel/reg: Add helpers for 64-bi

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

2017-11-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103543 --- Comment #5 from tjb...@scarlet.be --- Created attachment 135221 --> https://bugs.freedesktop.org/attachment.cgi?id=135221&action=edit log of autotools build autotools builds master branch, however some of the options are different -- You

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

2017-11-03 Thread Nicolai Hähnle
Hi Andres, Thank you for doing this. I haven't read the series in detail yet, but I have a bunch of questions and comments. I find it very unfortunate to have both fence and semaphore objects in the Gallium interface. The two even become mixed up in the amdgpu winsys. My first thought is tha

Re: [Mesa-dev] [PATCH 09/17] mesa/st: add support for waiting for semaphore objects

2017-11-03 Thread Nicolai Hähnle
On 02.11.2017 04:57, Andres Rodriguez wrote: Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject Signed-off-by: Andres Rodriguez --- src/mesa/state_tracker/st_cb_semaphoreobjects.c | 28 + 1 file changed, 28 insertions(+) diff --git a/src/mesa/sta

Re: [Mesa-dev] [PATCH 13/17] mesa: implement buffer/texture barriers for semaphore wait/signal

2017-11-03 Thread Nicolai Hähnle
On 02.11.2017 04:57, Andres Rodriguez wrote: Make sure memory is accessible to the external client, for the specified memory object, before the signal/after the wait. Signed-off-by: Andres Rodriguez --- src/mesa/main/dd.h | 14 ++- src/mesa/main/externalobjec

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-11-03 Thread Harish Krupo
Harish Krupo writes: > Hi Eric, > > Eric Engestrom writes: > >> On Monday, 2017-10-23 16:20:54 +0530, Harish Krupo wrote: >>> This passes 33/37 deqp tests related to partial_update, 4 are not >>> supported. Tests not supported: >>> dEQP-EGL.functional.negative_partial_update.not_postable_surfac

Re: [Mesa-dev] [PATCH 3/5] meson: move gl pkgconfig generation out ofglx

2017-11-03 Thread Marc Dietrich
Hi Dylan, Am Freitag, 3. November 2017, 01:06:27 CET schrieb Dylan Baker: > Because the same generation logic is required by xlib glx and > gallium-xlib glx, it makes sense to pull it out. > > Signed-off-by: Dylan Baker > --- > src/glx/meson.build | 11 --- > src/meson.build | 12 ++

Re: [Mesa-dev] Meson's default build type

2017-11-03 Thread Michel Dänzer
On 02/11/17 07:45 PM, Andres Rodriguez wrote: > On 2017-11-02 01:52 PM, Eric Engestrom wrote: >> On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: >>> On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: On Wed 01 Nov 2017, Dylan Baker wrote: > Quoting Ilia Mirkin (2017-

Re: [Mesa-dev] [PATCH 03/12] glsl: Remove program_resource_visitor::visit_field(const glsl_struct_field *)

2017-11-03 Thread Nicolai Hähnle
Patches 2 & 3: Reviewed-by: Nicolai Hähnle On 02.11.2017 21:25, Ian Romanick wrote: From: Ian Romanick I could not find any remaining users. Signed-off-by: Ian Romanick --- src/compiler/glsl/link_uniforms.cpp | 8 src/compiler/glsl/linker.h | 10 -- 2 files c

Re: [Mesa-dev] [PATCH 3/9] dri: Change __DriverApiRec::CreateContext to take a struct for attribs

2017-11-03 Thread Nicolai Hähnle
On 02.11.2017 20:01, Adam Jackson wrote: From: Neil Roberts Previously the CreateContext method of __DriverApiRec took a set of arguments to describe the attribute values from the window system API's CreateContextAttribs function. As more attributes get added this could quickly get unworkable a

Re: [Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

2017-11-03 Thread Nicolai Hähnle
Same concerns about testing as Emil, but the logic of it all is sound, so patches 3-8 are Reviewed-by: Nicolai Hähnle On 02.11.2017 20:01, Adam Jackson wrote: Hilariously this is a fairly big win. Neil's multi-context-test improves from ~24 to ~36 fps with llvmpipe on a Core i5-3317U. softp

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_nir: delay adding built-in uniforms to Parameters list

2017-11-03 Thread Nicolai Hähnle
On 02.11.2017 20:45, Timothy Arceri wrote: On 03/11/17 03:25, Nicolai Hähnle wrote: On 01.11.2017 06:20, Timothy Arceri wrote: Delaying adding built-in uniforms until after we convert to NIR gives us a better chance to optimise them away. Also NIR allows us to iterate over the uniforms direct

[Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI

2017-11-03 Thread Samuel Pitoiset
TC compatible HTILE only supports D32_SFLOAT on VI, while GFX9 supports both. This is a recommandation for apps because HTILE decompressions are costly. This improves performance with Talos (73->76FPS) and Serious Sam 2017 (119->134FPS) because they no longer use any 16bpp depth surfaces and thus

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

2017-11-03 Thread Nicolai Hähnle
On 03.11.2017 00:06, Miklós Máté wrote: On 02/11/17 17:16, Nicolai Hähnle wrote: On 01.11.2017 00:34, Miklós Máté wrote: This fixes a crash upon context destruction when glGenFragmentShadersATI() was used. Backtrace: ==15060== Invalid free() / delete / delete[] / realloc() ==15060==    at 0x482

Re: [Mesa-dev] [PATCH 11/13] meson: build gallium omx state tracker

2017-11-03 Thread Marc Dietrich
Am Mittwoch, 1. November 2017, 23:49:46 CET schrieb Dylan Baker: > --- > meson.build| 54 ++- > meson_options.txt | 13 > src/gallium/meson.build| 7 +- > .../state_trackers/omx_b

Re: [Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI

2017-11-03 Thread Alex Smith
Hi Samuel, D16_UNORM support is mandatory on 2D images according to the spec ("Features, Limits and Formats" chapter). Thanks, Alex On 3 November 2017 at 10:02, Samuel Pitoiset wrote: > TC compatible HTILE only supports D32_SFLOAT on VI, while GFX9 > supports both. This is a recommandation for

Re: [Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI

2017-11-03 Thread Samuel Pitoiset
On 11/03/2017 11:07 AM, Alex Smith wrote: Hi Samuel, D16_UNORM support is mandatory on 2D images according to the spec ("Features, Limits and Formats" chapter). Missed that point, I'm going to have a look right now. Thanks. Thanks, Alex On 3 November 2017 at 10:02, Samuel Pitoiset

Re: [Mesa-dev] [PATCH] Android: update CleanSpec.mk

2017-11-03 Thread Chih-Wei Huang
2017-11-03 15:47 GMT+08:00 Tapani Pälli : > Hi Chih-Wei; > > This looks good to me. Only thing that causes a bit of headache is ... what > is the difference between PRODUCT_OUT, OUT_DIR and TARGET_OUT? OUT_DIR is also set to "out" if it's not already set. PRODUCT_OUT is where all target files go.

Re: [Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI

2017-11-03 Thread Samuel Pitoiset
On 11/03/2017 11:10 AM, Samuel Pitoiset wrote: On 11/03/2017 11:07 AM, Alex Smith wrote: Hi Samuel, D16_UNORM support is mandatory on 2D images according to the spec ("Features, Limits and Formats" chapter). Missed that point, I'm going to have a look right now. Thanks. Yeah, we can't

[Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI for Talos/Serious Sam Fusion 2017

2017-11-03 Thread Samuel Pitoiset
VK_FORMAT_D16_UNORM is mandatory for 2D images, but Talos and Serious Sam Fusion 2017 can use VK_FORMAT_D32_SFLOAT instead. This implements some sort of drirc for radv (just based on the application names). This improves performance with Talos (73->76FPS) and Serious Sam 2017 (119->134FPS) becaus

[Mesa-dev] [PATCH 1/2] glsl/linker: use without_array() to retrieve type

2017-11-03 Thread Iago Toral Quiroga
This is what we do in the condition too, so it makes sense. --- src/compiler/glsl/link_varyings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 66a20a2c9b..af938611f4 100644 --- a/src/compiler/

[Mesa-dev] [PATCH 2/2] glsl/linker: location aliasing requires types to have the same width

2017-11-03 Thread Iago Toral Quiroga
Regarding location aliasing requirements, the OpenGL spec says: "Further, when location aliasing, the aliases sharing the location must have the same underlying numerical type (floating-point or integer)." Khronos has further clarified that this also requires the underlying types to have

Re: [Mesa-dev] [PATCH] Android: update CleanSpec.mk

2017-11-03 Thread Tapani Pälli
On 11/03/2017 12:30 PM, Chih-Wei Huang wrote: 2017-11-03 15:47 GMT+08:00 Tapani Pälli : Hi Chih-Wei; This looks good to me. Only thing that causes a bit of headache is ... what is the difference between PRODUCT_OUT, OUT_DIR and TARGET_OUT? OUT_DIR is also set to "out" if it's not already se

Re: [Mesa-dev] [PATCH 19/21] intel/nir: Use the correct indirect lowering masks in link_shaders

2017-11-03 Thread Timothy Arceri
On 29/10/17 05:36, Jason Ekstrand wrote: Previously, if we were linking a vec4 VS with a SIMD8/16 FS, we wouldn't lower indirects on the fragment shader which is wrong. Instead of using a single indirect mask, take advantage of our new little helper. It took me a while to actually see the bug

Re: [Mesa-dev] [PATCH 12/17] radeonsi: implement semaphore operations

2017-11-03 Thread Nicolai Hähnle
On 02.11.2017 04:57, Andres Rodriguez wrote: Allow importing, waiting and signaling of semaphore objects. Semaphore objects are backed by syncobj based fences. Signed-off-by: Andres Rodriguez --- src/gallium/drivers/radeon/r600_pipe_common.c | 52 +++ src/gallium/dri

Re: [Mesa-dev] [Intel-gfx] [PATCH] i965: Revert absolute mode for constant buffer pointers.

2017-11-03 Thread Joonas Lahtinen
Hi, After some brainstorming, we decided to go big and grab all the hardware provided defaults for all registers. That's for the sake of not having to decide which registers are important. This will also allow us not to be concerned of any context registers possibly containing 'secure' informatio

Re: [Mesa-dev] [PATCH 6/9] st/mesa: setup hw atomic limits.

2017-11-03 Thread Nicolai Hähnle
On 03.11.2017 08:24, Dave Airlie wrote: From: Dave Airlie HW atomics need to use caps to set some limits, and some other limits may also need limiting. This fixes things up to work for evergreen hw, it may need more changes in the future if other hw wants to use this path. Signed-off-by: Dave

[Mesa-dev] [PATCH] loader/dri3: Improve dri3 thread-safety

2017-11-03 Thread Thomas Hellstrom
It turned out that with recent changes that call into dri3 from glFinish(), it appears like different thread end up waiting for X events simultaneously, causing deadlocks since they steal events from eachoter and update the dri3 counters behind eachothers backs. This patch intends to improve on th

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

2017-11-03 Thread Andres Gomez
On Wed, 2017-11-01 at 12:47 +0100, Lucas Stach wrote: > Am Mittwoch, den 01.11.2017, 12:34 +0100 schrieb Wladimir J. van der Laan: > > On Wed, Nov 01, 2017 at 11:52:55AM +0100, Lucas Stach wrote: > > > Am Mittwoch, den 01.11.2017, 11:17 +0100 schrieb Wladimir J. van der Laan: > > > > GC3000 resolve

Re: [Mesa-dev] [PATCH 8/9] r600: add support for hw atomic counters. (v2)

2017-11-03 Thread Nicolai Hähnle
On 03.11.2017 08:24, Dave Airlie wrote: From: Dave Airlie This adds support for the evergreen/cayman atomic counters. These are implemented using GDS append/consume counters. The values for each counter are loaded before drawing and saved after each draw using special CP packets. v2: move hw

[Mesa-dev] [PATCH v5 7/9] egl: add dri2_surface_free_image() helper (v4)

2017-11-03 Thread Gwan-gyeong Mun
To share common free DRIimage code. In preparation to adding of new platform which uses this helper. v2: - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new helper function and use them to replace the old code in the same patch

Re: [Mesa-dev] gallium/r600 hw atomic support v2

2017-11-03 Thread Nicolai Hähnle
On 03.11.2017 08:24, Dave Airlie wrote: Ilia pointed out a bad assumption I made, so I've decided to move to allocating the hw indices in the backend, a bit ugly but seems to work. Thanks for doing this. I want to get GDS atomics into radeonsi as well. I've already sent some minor comments, wi

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

2017-11-03 Thread Lucas Stach
Hi Andres, Am Freitag, den 03.11.2017, 14:39 +0200 schrieb Andres Gomez: > On Wed, 2017-11-01 at 12:47 +0100, Lucas Stach wrote: > > Am Mittwoch, den 01.11.2017, 12:34 +0100 schrieb Wladimir J. van > > der Laan: > > > On Wed, Nov 01, 2017 at 11:52:55AM +0100, Lucas Stach wrote: > > > > Am Mittwoch

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

2017-11-03 Thread Andres Gomez
On Wed, 2017-11-01 at 20:58 +0200, Tapani Pälli wrote: > > On 11/01/2017 06:33 PM, Jason Ekstrand wrote: > > Do either of you mind if I cc the first one to stable? It does fix a > > potential memory leak in the case where compilation fails. > > IMO CC stable would be fine for that one. Jason,

[Mesa-dev] [Bug 103505] RX 480, newest mesa, VULKAN Does not start

2017-11-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103505 --- Comment #7 from Valentin Novikov --- (In reply to Bas Nieuwenhuizen from comment #6) > As said in comment #1, can you get a backtrace of the segfault? I have fust upgradet all graphics throw oibaff ppa, and IT WORKS! -- You are receiving

Re: [Mesa-dev] [PATCH 1/9] gallium: add CAPs to support HW atomic counters. (v2)

2017-11-03 Thread Gert Wollny
Am Freitag, den 03.11.2017, 17:24 +1000 schrieb Dave Airlie: > From: Dave Airlie > [...] > diff --git a/src/gallium/drivers/radeonsi/si_pipe.c > b/src/gallium/drivers/radeonsi/si_pipe.c > index 875aff6..39f7b7b 100644 > --- a/src/gallium/drivers/radeonsi/si_pipe.c > +++ b/src/gallium/drivers/rad

Re: [Mesa-dev] [PATCH 3/9] dri: Change __DriverApiRec::CreateContext to take a struct for attribs

2017-11-03 Thread Emil Velikov
On 3 November 2017 at 09:50, Nicolai Hähnle wrote: > On 02.11.2017 20:01, Adam Jackson wrote: >> >> From: Neil Roberts >> >> Previously the CreateContext method of __DriverApiRec took a set of >> arguments to describe the attribute values from the window system API's >> CreateContextAttribs funct

Re: [Mesa-dev] [PATCH 1/9] egl/dri2: Factor out context attribute initialization

2017-11-03 Thread Eric Engestrom
On Thursday, 2017-11-02 15:01:40 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > src/egl/drivers/dri2/egl_dri2.c | 35 +-- > 1 file changed, 9 insertions(+), 26 deletions(-) > > diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/e

Re: [Mesa-dev] [PATCH v3] mesa: Add new fast mtx_t mutex type for basic use cases

2017-11-03 Thread Nicolai Hähnle
What's the status of this? On 16.10.2017 14:36, Emil Velikov wrote: On 16 October 2017 at 08:06, Timothy Arceri wrote: While modern pthread mutexes are very fast, they still incur a call to an external DSO and overhead of the generality and features of pthread mutexes. Most mutexes in mesa onl

Re: [Mesa-dev] [PATCH v3] mesa: Add new fast mtx_t mutex type for basic use cases

2017-11-03 Thread Nicolai Hähnle
On 03.11.2017 14:23, Nicolai Hähnle wrote: What's the status of this? On 16.10.2017 14:36, Emil Velikov wrote: On 16 October 2017 at 08:06, Timothy Arceri wrote: While modern pthread mutexes are very fast, they still incur a call to an external DSO and overhead of the generality and features

Re: [Mesa-dev] create src/wsi

2017-11-03 Thread Daniel Stone
Hi, On 1 November 2017 at 17:33, Emil Velikov wrote: > On 31 October 2017 at 21:07, Dylan Baker wrote: >> My intention is to pull some of the generated files that are shared >> between vulkan/wsi/wayland and egl/wayland/wayland-drm. Daniel has said that >> he >> has more generated files that wi

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

2017-11-03 Thread Miklós Máté
On 03/11/17 11:04, Nicolai Hähnle wrote: On 03.11.2017 00:06, Miklós Máté wrote: On 02/11/17 17:16, Nicolai Hähnle wrote: On 01.11.2017 00:34, Miklós Máté wrote: This fixes a crash upon context destruction when glGenFragmentShadersATI() was used. Backtrace: ==15060== Invalid free() / delete /

Re: [Mesa-dev] [PATCH 8/9] r600: add support for hw atomic counters. (v2)

2017-11-03 Thread Gert Wollny
Am Freitag, den 03.11.2017, 17:24 +1000 schrieb Dave Airlie: > > diff --git a/src/gallium/drivers/r600/r600_pipe.c > b/src/gallium/drivers/r600/r600_pipe.c > index d67a22b..434596b 100644 > --- a/src/gallium/drivers/r600/r600_pipe.c > +++ b/src/gallium/drivers/r600/r600_pipe.c > @@ -74,6 +74,8 @@

Re: [Mesa-dev] [PATCH 14/25] radeonsi: implement PIPE_FLUSH_{TOP, BOTTOM}_OF_PIPE

2017-11-03 Thread Nicolai Hähnle
On 31.10.2017 17:21, Marek Olšák wrote: On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_fence.c | 83 - 1 file changed, 82 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH 09/25] gallium/u_threaded: implement asynchronous flushes

2017-11-03 Thread Nicolai Hähnle
On 31.10.2017 03:15, Marek Olšák wrote: On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: @@ -107,20 +138,46 @@ static boolean si_fence_finish(struct pipe_screen *screen, uint64_t timeout) { struct radeon_winsys *rws = ((struct r600_common_screen*

Re: [Mesa-dev] [PATCH 08/25] gallium/u_threaded: mark queries flushed only for non-deferred flushes

2017-11-03 Thread Nicolai Hähnle
On 30.10.2017 13:31, Marek Olšák wrote: On Mon, Oct 30, 2017 at 2:57 AM, Marek Olšák wrote: On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle The driver uses (and must use) the flushed flag of queries as a hint that it does not have to check for synchronization wit

Re: [Mesa-dev] [PATCH 2/9] intel: Don't flush the old context in intelMakeCurrent

2017-11-03 Thread Mark Janes
Dylan pushed this series through our CI, and there were no regressions. Emil Velikov writes: > [removing Neil's old email as it bounces] > > On 2 November 2017 at 19:01, Adam Jackson wrote: >> From: Neil Roberts >> >> It shouldn't be necessary to flush the context within the driver >> implemen

Re: [Mesa-dev] [PATCH] radv: Don't expose heaps with 0 memory.

2017-11-03 Thread Andres Gomez
Bas, this commit landed without mentioning any specific stable queue. For 17.2, this is quite an extensive change and has several trivial conflicts. I think it is OK to merge if you really meant it for 17.2 too, but just double checking. Thanks! On Wed, 2017-11-01 at 20:58 +0100, Bas Nieuwenhuiz

Re: [Mesa-dev] [PATCH 6/9] egl: Implement EGL_KHR_context_flush_control

2017-11-03 Thread Eric Engestrom
On Thursday, 2017-11-02 15:01:45 -0400, Adam Jackson wrote: > Signed-off-by: Adam Jackson Reviewed-by: Eric Engestrom > --- > src/egl/drivers/dri2/egl_dri2.c | 11 ++- > src/egl/drivers/dri2/egl_dri2.h | 1 + > src/egl/main/eglapi.c | 1 + > src/egl/main/eglcontext.c

Re: [Mesa-dev] [PATCH 1/2] glsl/linker: use without_array() to retrieve type

2017-11-03 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin However I might recommend doing like const glsl_type *type_without_array = type->without_array(); if (type_without_array->is_interface()) { for (... ; i < type_without_array->length; i++) { field = &type_without_array->fields.structure[i] Otherwise it's just redo

[Mesa-dev] [Bug 101378] interpolateAtSample check for input parameter is too strict

2017-11-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101378 Nicolai Hähnle changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 2/2] glsl/linker: location aliasing requires types to have the same width

2017-11-03 Thread Ilia Mirkin
On Fri, Nov 3, 2017 at 6:56 AM, Iago Toral Quiroga wrote: > Regarding location aliasing requirements, the OpenGL spec says: > > "Further, when location aliasing, the aliases sharing the location >must have the same underlying numerical type (floating-point or >integer)." > > Khronos has

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

2017-11-03 Thread Nicolai Hähnle
On 03.11.2017 14:56, Miklós Máté wrote: On 03/11/17 11:04, Nicolai Hähnle wrote: On 03.11.2017 00:06, Miklós Máté wrote: On 02/11/17 17:16, Nicolai Hähnle wrote: On 01.11.2017 00:34, Miklós Máté wrote: This fixes a crash upon context destruction when glGenFragmentShadersATI() was used. Backtr

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock on Wayland compositor with X11

2017-11-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103538 --- Comment #2 from Henri Verbeet --- That backtrace looks a lot like the issue for which I originally wrote https://patchwork.freedesktop.org/patch/183215/. Unfortunately it looks like it's harder than that. -- You are receiving this mail bec

Re: [Mesa-dev] [PATCH 3/5] meson: move gl pkgconfig generation out ofglx

2017-11-03 Thread Dylan Baker
Quoting Marc Dietrich (2017-11-03 02:24:46) > Hi Dylan, > > Am Freitag, 3. November 2017, 01:06:27 CET schrieb Dylan Baker: > > Because the same generation logic is required by xlib glx and > > gallium-xlib glx, it makes sense to pull it out. > > > > Signed-off-by: Dylan Baker > > --- > > src/g

Re: [Mesa-dev] Meson's default build type

2017-11-03 Thread Andres Rodriguez
On 2017-11-03 05:25 AM, Michel Dänzer wrote: On 02/11/17 07:45 PM, Andres Rodriguez wrote: On 2017-11-02 01:52 PM, Eric Engestrom wrote: On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: On Wed 01 Nov 2017, Dylan Baker

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

2017-11-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103543 --- Comment #6 from tjb...@scarlet.be --- I rebuilt llvm with LLVM_LINK_LLVM_DYLIB. That now installs lots of .sa libraries and an enormous /usr/lib/libLLVM-5.0.so I then auccessfully rebuilt mesa using autotools, but the mesaon build still fai

Re: [Mesa-dev] [PATCH 11/13] meson: build gallium omx state tracker

2017-11-03 Thread Dylan Baker
Quoting Marc Dietrich (2017-11-03 03:06:17) > Am Mittwoch, 1. November 2017, 23:49:46 CET schrieb Dylan Baker: > > --- > > meson.build| 54 ++- > > meson_options.txt | 13 > > src/gallium/meson.build

Re: [Mesa-dev] [PATCH 3/5] st/mesa: use asynchronous flushes

2017-11-03 Thread Nicolai Hähnle
On 31.10.2017 18:59, Marek Olšák wrote: On Sun, Oct 22, 2017 at 9:18 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/mesa/state_tracker/st_cb_flush.c | 4 ++-- src/mesa/state_tracker/st_cb_syncobj.c | 26 -- 2 files changed, 26 insertions(+), 4 deletions(

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Nanley Chery
On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > This optimization is enabled for previous generations too. > See Mesa commit c17e214a6b > On CNL this bit has been moved to CACHE_MODE_SS register. > > Cc: Nanley Chery > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

2017-11-03 Thread Nanley Chery
On Thu, Nov 02, 2017 at 06:13:43PM -0700, Matt Turner wrote: > On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote: > > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: > >> V2: Remove the bits enabling Float blend optimization. It is > >> enabled through CACHE_MODE_SS register. >

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-11-03 Thread Marek Olšák
Pushed with a fixed typo and whitespace, thanks. Marek On Thu, Nov 2, 2017 at 3:50 PM, Andrey Grodzovsky wrote: > Fixes reverted patch f03b7c9 by doing VMID reservation per > process and not per context. > Also updates required amdgpu libdrm version since the change > involved interface updates

Re: [Mesa-dev] [PATCH 03/17] mesa: add support for semaphore object creation/import/delete

2017-11-03 Thread Marek Olšák
On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: > Used by EXT_semmaphore and EXT_semaphore_fd > > Signed-off-by: Andres Rodriguez > --- > src/mesa/drivers/common/driverfuncs.c | 3 + > src/mesa/main/dd.h| 34 +++ > src/mesa/main/externalobjects.c | 161 >

Re: [Mesa-dev] [PATCH 09/17] mesa/st: add support for waiting for semaphore objects

2017-11-03 Thread Andres Rodriguez
On 2017-11-03 05:17 AM, Nicolai Hähnle wrote: On 02.11.2017 04:57, Andres Rodriguez wrote: Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject Signed-off-by: Andres Rodriguez ---   src/mesa/state_tracker/st_cb_semaphoreobjects.c | 28 +   1 file c

Re: [Mesa-dev] [PATCH 13/17] mesa: implement buffer/texture barriers for semaphore wait/signal

2017-11-03 Thread Andres Rodriguez
On 2017-11-03 05:18 AM, Nicolai Hähnle wrote: On 02.11.2017 04:57, Andres Rodriguez wrote: Make sure memory is accessible to the external client, for the specified memory object, before the signal/after the wait. Signed-off-by: Andres Rodriguez ---   src/mesa/main/dd.h   

Re: [Mesa-dev] [PATCH 04/17] mesa: add semaphore parameter stub

2017-11-03 Thread Marek Olšák
On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: > EXT_semaphore and EXT_semaphore_fd define no pnames. Therefore there > isn't much to do besides determining the correct error code. > > Signed-off-by: Andres Rodriguez > --- > src/mesa/main/externalobjects.c | 23 +++ >

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

2017-11-03 Thread Marek Olšák
On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: > Signed-off-by: Andres Rodriguez > --- > src/gallium/drivers/ddebug/dd_context.c | 23 +++ > src/gallium/drivers/ddebug/dd_screen.c | 25 + > src/gallium/drivers/trace/tr_context.c | 36 +++

Re: [Mesa-dev] [PATCH 00/17] Add support for GL_EXT_semaphore

2017-11-03 Thread Andres Rodriguez
On 2017-11-03 05:15 AM, Nicolai Hähnle wrote: Hi Andres, Thank you for doing this. I haven't read the series in detail yet, but I have a bunch of questions and comments. Thanks for all the feedback. I find it very unfortunate to have both fence and semaphore objects in the Gallium inter

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Nanley Chery
On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote: > On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > > This optimization is enabled for previous generations too. > > See Mesa commit c17e214a6b > > On CNL this bit has been moved to CACHE_MODE_SS register. > > > > Cc: Nanle

[Mesa-dev] [PATCH v3] meson: implement default driver arguments

2017-11-03 Thread Dylan Baker
This allows drivers to be set by OS/arch in a sane manner. v2: - set _drivers to a list of drivers instead of manually assigning each with_* v3: - Use "auto" instead of "default", which matches the value of other automatically configured options. - Set vulkan drivers as well -

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

2017-11-03 Thread Nanley Chery
On Fri, Nov 03, 2017 at 09:50:41AM -0700, Nanley Chery wrote: > On Thu, Nov 02, 2017 at 06:13:43PM -0700, Matt Turner wrote: > > On Thu, Nov 2, 2017 at 11:26 AM, Nanley Chery wrote: > > > On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: > > >> V2: Remove the bits enabling Float blend o

Re: [Mesa-dev] [PATCH 09/17] mesa/st: add support for waiting for semaphore objects

2017-11-03 Thread Marek Olšák
FLUSH_VERTICES should be called by mesa/main if it's inside a GL call. st/mesa should only flush bitmaps. Marek On Fri, Nov 3, 2017 at 6:36 PM, Andres Rodriguez wrote: > > > On 2017-11-03 05:17 AM, Nicolai Hähnle wrote: >> >> On 02.11.2017 04:57, Andres Rodriguez wrote: >>> >>> Bits to implemen

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

2017-11-03 Thread Andres Rodriguez
On 2017-11-03 01:56 PM, Marek Olšák wrote: On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez --- src/gallium/drivers/ddebug/dd_context.c | 23 +++ src/gallium/drivers/ddebug/dd_screen.c | 25 + src/gallium/drivers

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

2017-11-03 Thread Marek Olšák
On Fri, Nov 3, 2017 at 7:18 PM, Andres Rodriguez wrote: > > > On 2017-11-03 01:56 PM, Marek Olšák wrote: >> >> On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez >> wrote: >>> >>> Signed-off-by: Andres Rodriguez >>> --- >>> src/gallium/drivers/ddebug/dd_context.c | 23 +++ >>> s

Re: [Mesa-dev] [PATCH 05/17] gallium: introduce semaphore object

2017-11-03 Thread Andres Rodriguez
On 2017-11-03 02:20 PM, Marek Olšák wrote: On Fri, Nov 3, 2017 at 7:18 PM, Andres Rodriguez wrote: On 2017-11-03 01:56 PM, Marek Olšák wrote: On Thu, Nov 2, 2017 at 4:57 AM, Andres Rodriguez wrote: Signed-off-by: Andres Rodriguez --- src/gallium/drivers/ddebug/dd_context.c | 23 +++

[Mesa-dev] [Bug 103505] RX 480, newest mesa, VULKAN Does not start

2017-11-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103505 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Anuj Phogat
On Fri, Nov 3, 2017 at 9:46 AM, Nanley Chery wrote: > On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: >> This optimization is enabled for previous generations too. >> See Mesa commit c17e214a6b >> On CNL this bit has been moved to CACHE_MODE_SS register. >> >> Cc: Nanley Chery >> Sig

Re: [Mesa-dev] [PATCH 12/12] spirv: Import the latest 1.0.12 header and JSON from Khronos

2017-11-03 Thread Ian Romanick
I did not intend to send this patch out with this series. It will be in the next block. On 11/02/2017 01:25 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/compiler/spirv/spirv.core.grammar.json | 266 > - > src/compiler/sp

Re: [Mesa-dev] [PATCH 14/25] radeonsi: implement PIPE_FLUSH_{TOP, BOTTOM}_OF_PIPE

2017-11-03 Thread Marek Olšák
On Fri, Nov 3, 2017 at 3:48 PM, Nicolai Hähnle wrote: > On 31.10.2017 17:21, Marek Olšák wrote: >> >> On Sun, Oct 22, 2017 at 9:07 PM, Nicolai Hähnle >> wrote: >>> >>> From: Nicolai Hähnle >>> >>> --- >>> src/gallium/drivers/radeonsi/si_fence.c | 83 >>> - >>>

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Nanley Chery
On Fri, Nov 03, 2017 at 11:39:34AM -0700, Anuj Phogat wrote: > On Fri, Nov 3, 2017 at 9:46 AM, Nanley Chery wrote: > > On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > >> This optimization is enabled for previous generations too. > >> See Mesa commit c17e214a6b > >> On CNL this bit h

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Anuj Phogat
On Fri, Nov 3, 2017 at 11:05 AM, Nanley Chery wrote: > On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote: >> On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: >> > This optimization is enabled for previous generations too. >> > See Mesa commit c17e214a6b >> > On CNL this bit

Re: [Mesa-dev] [PATCH v2 3/4] i965/gen10: Enable float blend optimization

2017-11-03 Thread Nanley Chery
On Fri, Nov 03, 2017 at 11:50:44AM -0700, Anuj Phogat wrote: > On Fri, Nov 3, 2017 at 11:05 AM, Nanley Chery wrote: > > On Fri, Nov 03, 2017 at 09:46:29AM -0700, Nanley Chery wrote: > >> On Wed, Nov 01, 2017 at 03:50:54PM -0700, Anuj Phogat wrote: > >> > This optimization is enabled for previous g

Re: [Mesa-dev] [PATCH v2 11/11] intel: add aubinator ui

2017-11-03 Thread Dylan Baker
Quoting Lionel Landwerlin (2017-11-01 11:12:18) [snip] > > +if with_intel_tools > + inc_imgui = include_directories('imgui') since aubinator_ui is the only consumer of this include, why don't we just put the call to include_directories in the argument to the executable? > + aubinator_ui = exe

Re: [Mesa-dev] [PATCH] radv: do not advertise D16_UNORM on VI for Talos/Serious Sam Fusion 2017

2017-11-03 Thread Bas Nieuwenhuizen
On Fri, Nov 3, 2017 at 11:39 AM, Samuel Pitoiset wrote: > VK_FORMAT_D16_UNORM is mandatory for 2D images, but Talos and > Serious Sam Fusion 2017 can use VK_FORMAT_D32_SFLOAT instead. > > This implements some sort of drirc for radv (just based on > the application names). > > This improves perform

  1   2   >