[Mesa-dev] [PATCH] anv: fix bug when using component qualifier in FS outputs

2017-11-02 Thread Samuel Iglesias Gonsálvez
We can write to the same output but in different components, like in this example: layout(location = 0, component = 0) out ivec2 dEQP_FragColor_0; layout(location = 0, component = 2) out ivec2 dEQP_FragColor_1; Therefore, they are not two different outputs but only one. Fixes: dEQP-VK.glsl.440.

Re: [Mesa-dev] [PATCH v4 39/48] nir: Add a new subgroups lowering pass

2017-11-02 Thread Iago Toral
All 4 patches are: Reviewed-by: Iago Toral Quiroga On Tue, 2017-10-31 at 16:54 -0700, Jason Ekstrand wrote: > This commit pulls nir_lower_read_invocations_to_scalar along with > most > of the guts of nir_opt_intrinsics (which mostly does subgroup > lowering) > into a new nir_lower_subgroups pass

Re: [Mesa-dev] [PATCH v2] i965 : optimized bucket index calculation

2017-11-02 Thread Muthukumar, Aravindan
> > >On 10/24/2017 02:42 AM, Muthukumar, Aravindan wrote: > > >>> -Original Message- > > >>> From: Ian Romanick [mailto:i...@freedesktop.org] > > >>> Sent: Friday, October 20, 2017 9:51 AM > > >>> To: Muthukumar, Aravindan ; mesa- > > >>> d...@lists.freedesktop.org > > >>> Cc: J Karanje, Ke

Re: [Mesa-dev] [PATCH 1/6] ac: use the ac i32 llvm type

2017-11-02 Thread Nicolai Hähnle
For the series: Acked-by: Nicolai Hähnle On 02.11.2017 02:50, Timothy Arceri wrote: --- src/amd/common/ac_nir_to_llvm.c | 360 1 file changed, 179 insertions(+), 181 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_t

Re: [Mesa-dev] [PATCH 01/10] ac: add v2i32 to the common code and use it

2017-11-02 Thread Nicolai Hähnle
For the series: Acked-by: Nicolai Hähnle On 02.11.2017 03:41, Timothy Arceri wrote: --- src/amd/common/ac_llvm_build.c | 1 + src/amd/common/ac_llvm_build.h | 1 + src/amd/common/ac_nir_to_llvm.c | 20 +--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH v3] i965: expose SRGB visuals and turn on EGL_KHR_gl_colorspace

2017-11-02 Thread Tapani Pälli
Patch exposes sRGB visuals and adds DRI integer query support for __DRI2_RENDERER_HAS_FRAMEBUFFER_SRGB. Further changes make sure that we mark if the app explicitly wanted sRGB and for these framebuffers we don't turn sRGB off in intel_gles3_srgb_workaround. This way we keep compatibility for exist

[Mesa-dev] [Bug 103543] meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager

2017-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103543 Bug ID: 103543 Summary: meson targets which link libgallium.a have unresolved symbol llvm::RTDyldMemoryManager Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH 04/13] meson: build r600 driver

2017-11-02 Thread Marc Dietrich
Hi Dylan, Am Mittwoch, 1. November 2017, 23:49:39 CET schrieb Dylan Baker: > Signed-off-by: Dylan Baker > Tested-by: Aaron Watry > --- > meson.build | 20 -- > meson_options.txt| 2 +- > src/gallium/drivers/r600/meson.build | 128 > +++

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

2017-11-02 Thread Lucas Stach
Am Mittwoch, den 01.11.2017, 11:21 -0700 schrieb Chris Healy: > Tested-by: Chris Healy > > I tested this with i.MX6qp (and i.MX6q) and found that the rendering > issues I experienced with Wayland/Weston and the i.MX6qp went away > with this patch applied. > > Also, I ran glmark2-es2-drm and saw

Re: [Mesa-dev] [PATCH 0/2] etnaviv: ASTC texture support

2017-11-02 Thread Wladimir J. van der Laan
On Wed, Nov 01, 2017 at 01:27:30PM -0400, Ilia Mirkin wrote: > On Wed, Nov 1, 2017 at 1:19 PM, Wladimir J. van der Laan > wrote: > > Add ASTC texture support for hardware that supports this > > (currently only GC3000 on i.MX6qp is known to have this). > > > > Piglit output: > > > > $ bin/khr_c

Re: [Mesa-dev] [PATCH 04/13] meson: build r600 driver

2017-11-02 Thread Marc Dietrich
Am Donnerstag, 2. November 2017, 13:03:17 CET schrieb Eric Engestrom: > On Thursday, 2017-11-02 11:32:44 +0100, Marc Dietrich wrote: > > Hi Dylan, > > > > Am Mittwoch, 1. November 2017, 23:49:39 CET schrieb Dylan Baker: > > > Signed-off-by: Dylan Baker > > > Tested-by: Aaron Watry > > > --- > >

Re: [Mesa-dev] [PATCH 04/13] meson: build r600 driver

2017-11-02 Thread Eric Engestrom
On Thursday, 2017-11-02 11:32:44 +0100, Marc Dietrich wrote: > Hi Dylan, > > Am Mittwoch, 1. November 2017, 23:49:39 CET schrieb Dylan Baker: > > Signed-off-by: Dylan Baker > > Tested-by: Aaron Watry > > --- > > meson.build | 20 -- > > meson_options.txt

Re: [Mesa-dev] [PATCH] Revert "meson: bump libdrm version required by amdgpu"

2017-11-02 Thread Eric Engestrom
On Wednesday, 2017-11-01 16:24:34 -0700, Dylan Baker wrote: > This reverts commit d364684711a5894fd3221191811d56713d6abdee. > > The commit that bumped the autotools version was reverted, so lets > revert the meson version to match. > > fixes: 1f2640bfa940362c7550cdd065d37555f21c8ae8 >"Rev

Re: [Mesa-dev] More gratitude for Meson

2017-11-02 Thread Emil Velikov
On 1 November 2017 at 22:49, Chad Versace wrote: > On Wed 01 Nov 2017, Dylan Baker wrote: >> Quoting Chad Versace (2017-11-01 14:43:28) >> > Wow. 10 seconds from a clean checkout to an installed Vulkan driver. > >> Glad that it's working out for you guys! >> >> Can I convince you to wire the anvil

Re: [Mesa-dev] [PATCH 0/2] etnaviv: ASTC texture support

2017-11-02 Thread Ilia Mirkin
On Thu, Nov 2, 2017 at 7:55 AM, Wladimir J. van der Laan wrote: > On Wed, Nov 01, 2017 at 01:27:30PM -0400, Ilia Mirkin wrote: >> On Wed, Nov 1, 2017 at 1:19 PM, Wladimir J. van der Laan >> wrote: >> > Add ASTC texture support for hardware that supports this >> > (currently only GC3000 on i.MX6qp

Re: [Mesa-dev] [PATCH 01/10] glsl: add support for tracking atomic counter index across stages.

2017-11-02 Thread Ilia Mirkin
On Thu, Nov 2, 2017 at 1:42 AM, Dave Airlie wrote: > From: Dave Airlie > > If we have hardware like evergreen with limited hw counters, we need > to assign each used counter in a series of linked shaders a unique > index so the driver can assign them to the hw counters uniquely. > > Since I need

Re: [Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

2017-11-02 Thread Emil Velikov
On 1 November 2017 at 22:49, Dylan Baker wrote: > --- > meson.build | 35 +- > meson_options.txt | 13 ++ > src/gallium/meson.build | 7 ++- > src/gallium/state_trackers/va/meson.build | 39 >

Re: [Mesa-dev] [PATCH 1/3] automake: Remove unused include path

2017-11-02 Thread Emil Velikov
Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-11-02 Thread Emil Velikov
On 21 October 2017 at 02:00, Dylan Baker wrote: > This is just a terrible idea, but it also needs to be fixed for the next > patch to work, so let's fix it right. > Please rework the commit message. Perhaps something alike 1b1bb6ee103a79de11aa4941ccbcd34f0a158276? > Signed-off-by: Dylan Baker >

[Mesa-dev] [Bug 103505] RX 480, newest mesa, VULKAN Does not start

2017-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103505 --- Comment #5 from Valentin Novikov --- BUMP -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.fre

Re: [Mesa-dev] [PATCH 07/13] autotools: set XA versions in configure.ac and configure header file

2017-11-02 Thread Emil Velikov
On 1 November 2017 at 22:49, Dylan Baker wrote: > Currently the versions are set in the header, and then sed is used to > extract them, so that autotools can use them elsewhere. > > This is odd. Autotools is perfectly capable of configuring the header > with the versions, and then they don't need

Re: [Mesa-dev] [PATCH 07/13] autotools: set XA versions in configure.ac and configure header file

2017-11-02 Thread Emil Velikov
On 2 November 2017 at 14:00, Emil Velikov wrote: > On 1 November 2017 at 22:49, Dylan Baker wrote: >> Currently the versions are set in the header, and then sed is used to >> extract them, so that autotools can use them elsewhere. >> >> This is odd. Autotools is perfectly capable of configuring t

Re: [Mesa-dev] [PATCH v3 06/43] nir: Handle fp16 rounding modes at nir_type_conversion_op

2017-11-02 Thread Chema Casanova
El 30/10/17 a las 22:26, Jason Ekstrand escribió: > On Thu, Oct 12, 2017 at 11:37 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > nir_type_conversion enables new operations to handle rounding modes to > convert to fp16 values. Two new opcodes are enabled nir_op_

[Mesa-dev] [PATCH 3/2] etnaviv: Don't over-pad compressed textures

2017-11-02 Thread Wladimir J. van der Laan
HALIGN_FOUR/SIXTEEN has no meaning for compressed textures, and we can't render to them anyway. So use the tightest possible packing. This avoids bugs with non-power-of-two block sizes. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 24 ++

Re: [Mesa-dev] [PATCH v3 12/43] i965/fs: Add brw_reg_type_from_bit_size utility method

2017-11-02 Thread Chema Casanova
El 30/10/17 a las 23:15, Jason Ekstrand escribió: > > On Mon, Oct 30, 2017 at 3:08 PM, Jason Ekstrand > wrote: > > On Thu, Oct 12, 2017 at 11:38 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > From: Alejandro Piñeiro

[Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

2017-11-02 Thread Andrey Grodzovsky
Fixes reverted patch f03b7c9 by doing VMID reservation per process and not per context. Also updates required amdgpu libdrm version since the change involved interface updates in amdgpu libdrm. Signed-off-by: Andrey Grodzovsky --- configure.ac | 2 +- meson.buil

Re: [Mesa-dev] [PATCH] ac/nir: Only clamp shadow reference on radeonsi.

2017-11-02 Thread Nicolai Hähnle
On 23.10.2017 03:32, Bas Nieuwenhuizen wrote: Vulkan CTS does not expect the value to be clamped (at least for D32), and it makes a differences even though depth is in [0,1], due to strict inequalities. I couldn't find anything in the Vulkan spec about this, but the test seemed to be copied from

Re: [Mesa-dev] [PATCH v3 17/43] i965/fs: Enable rounding mode on f2f16 ops

2017-11-02 Thread Chema Casanova
El 30/10/17 a las 23:40, Jason Ekstrand escribió: > On Thu, Oct 12, 2017 at 11:38 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > From: Alejandro Piñeiro > > > By default we don't set the rounding mode. We only set > round-t

Re: [Mesa-dev] [PATCH] nir: add tess patch support to nir_remove_unused_varyings()

2017-11-02 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 25.10.2017 10:06, Timothy Arceri wrote: Shader-db results BDW: total instructions in shared programs: 13276247 -> 13275395 (-0.01%) instructions in affected programs: 29407 -> 28555 (-2.90%) helped: 71 HURT: 0 total cycles in shared programs: 539866300 -> 539861

Re: [Mesa-dev] [PATCH] ac/nir: move lds declaration/load/store into shared code.

2017-11-02 Thread Nicolai Hähnle
We really should clean up our act at some point, teach LLVM how to make reasonable decisions for where to put variables (e.g. arrays: VGPR vs. spill memory vs. LDS), and use a proper structure on LDS. But this is alright for now... Cheers, Nicolai On 26.10.2017 07:05, Dave Airlie wrote: From

Re: [Mesa-dev] [RFC PATCH] util/ralloc: make mem_ctx parameter const for all r*alloc functions

2017-11-02 Thread Nicolai Hähnle
On 26.10.2017 13:02, Gert Wollny wrote: r(z)alloc_size and get_header both take a "const void *" for mem_ctx, but most of the other functions take a "void *" and also the "new" operator in DECLARE_ALLOC_CXX_OPERATORS_TEMPLATE. The latter makes it impossible to copy-construct from a constant decla

Re: [Mesa-dev] [PATCH] ac/nir: for ubo load use correct num_components

2017-11-02 Thread Nicolai Hähnle
On 31.10.2017 02:33, Dave Airlie wrote: From: Dave Airlie I was hacking something stupid in doom, and hit an assert for the bitcast following this, it definitely looks like this should be the number of 32-bit components, not the instr level ones. Agreed. Reviewed-by: Nicolai Hähnle Signe

Re: [Mesa-dev] [PATCH 12/15] ac: add support for SPV_AMD_shader_ballot

2017-11-02 Thread Nicolai Hähnle
On 31.10.2017 16:36, Connor Abbott wrote: On Tue, Oct 31, 2017 at 2:08 AM, Dave Airlie wrote: +LLVMValueRef +ac_build_subgroup_inclusive_scan(struct ac_llvm_context *ctx, +LLVMValueRef src, +ac_reduce_op reduce, +

Re: [Mesa-dev] [PATCH] radeonsi: remove 'Authors:' comments

2017-11-02 Thread Nicolai Hähnle
On 31.10.2017 18:47, Marek Olšák wrote: From: Marek Olšák It's inaccurate. Instead, see the copyright and use "git log" and "git blame" to know the authorship. Acked-by: Nicolai Hähnle --- src/amd/common/ac_binary.c | 4 src/amd/common/ac_binary.h

Re: [Mesa-dev] r600: some misc assembler and state updates

2017-11-02 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 01.11.2017 00:32, Dave Airlie wrote: These are just some misc patches from the road to GL4.3 patches, They don't do anything on their own, just cleanly improve the assembler some state setting. Dave. _

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

2017-11-02 Thread Nicolai Hähnle
On 01.11.2017 00:34, Miklós Máté wrote: This fixes a crash upon context destruction when glGenFragmentShadersATI() was used. Backtrace: ==15060== Invalid free() / delete / delete[] / realloc() ==15060==at 0x482F478: free (vg_replace_malloc.c:530) ==15060==by 0x57694F4: _mesa_delete_ati_fr

Re: [Mesa-dev] [PATCH 2/2] mesa/st: implement max combined output resources limiting.

2017-11-02 Thread Nicolai Hähnle
Could you already add the change to return a non-zero value from r600 so that *something* is using this cap? Apart from that, both patches are Reviewed-by: Nicolai Hähnle On 01.11.2017 00:58, Dave Airlie wrote: From: Dave Airlie if the driver sets the cap, then use the value it gives us.

Re: [Mesa-dev] [PATCH 2/2] ac/radeonsi: add support for tex instr without a derefence

2017-11-02 Thread Nicolai Hähnle
Both patches: Reviewed-by: Nicolai Hähnle On 01.11.2017 02:43, Timothy Arceri wrote: These are produced by nir_lower_bitmap(), adding the missing derefence would cause other issues that need to be hacked around such as skipping sampler lowering and uniform location assignment, so this change

Re: [Mesa-dev] [PATCH 1/2] st/glsl_to_nir: pass gl_shader_program to st_finalize_nir()

2017-11-02 Thread Nicolai Hähnle
This patch: Reviewed-by: Nicolai Hähnle On 01.11.2017 06:20, Timothy Arceri wrote: --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 24 ++-- src/mesa/state_tracker/st_nir.h | 4 +++- src/mesa/state_tracker/st_program.c | 10 ++ 3 files changed,

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_nir: delay adding built-in uniforms to Parameters list

2017-11-02 Thread Nicolai Hähnle
On 01.11.2017 06:20, Timothy Arceri wrote: Delaying adding built-in uniforms until after we convert to NIR gives us a better chance to optimise them away. Also NIR allows us to iterate over the uniforms directly so should be faster. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 68 ++

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_nir: use nir_shader_gather_info()

2017-11-02 Thread Nicolai Hähnle
Both patches: Reviewed-by: Nicolai Hähnle On 01.11.2017 12:01, Timothy Arceri wrote: Use the NIR helper rather than the GLSL IR helper to get in/out masks. This allows us to ignore varyings removed by NIR optimisations. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 18 ++

Re: [Mesa-dev] [PATCH] mesa: prevent deleting the dummy ATI_fs

2017-11-02 Thread Marek Olšák
Can you rebase and resend the patch? It doesn't apply with "git am". Thanks, Marek On Wed, Nov 1, 2017 at 12:34 AM, Miklós Máté wrote: > This fixes a crash upon context destruction when > glGenFragmentShadersATI() was used. Backtrace: > ==15060== Invalid free() / delete / delete[] / realloc() >

[Mesa-dev] Meson's default build type

2017-11-02 Thread Chad Versace
On Wed 01 Nov 2017, Dylan Baker wrote: > Quoting Ilia Mirkin (2017-11-01 16:05:17) > > On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: > > > Quoting Ilia Mirkin (2017-11-01 15:52:56) > > >> On Wed, Nov 1, 2017 at 6:49 PM, Chad Versace > > >> wrote: > > >> > On Wed 01 Nov 2017, Dylan Baker wro

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Michel Dänzer
On 02/11/17 05:46 PM, Chad Versace wrote: > On Wed 01 Nov 2017, Dylan Baker wrote: >> Quoting Ilia Mirkin (2017-11-01 16:05:17) >>> On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: Quoting Ilia Mirkin (2017-11-01 15:52:56) > On Wed, Nov 1, 2017 at 6:49 PM, Chad Versace > wrote: >>

Re: [Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-11-02 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 06:21:09) > On 21 October 2017 at 02:00, Dylan Baker wrote: > > This is just a terrible idea, but it also needs to be fixed for the next > > patch to work, so let's fix it right. > > > Please rework the commit message. Perhaps something alike > 1b1bb6ee103a79de11aa

Re: [Mesa-dev] [PATCH 42.5/48] nir/builder: Add a nir_imm_intN_t helper

2017-11-02 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 31/10/17 23:54, Jason Ekstrand wrote: This lets you easily build integer immediates of arbitrary bit size. --- src/compiler/nir/nir_builder.h | 12 1 file changed, 12 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Matt Turner
On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer wrote: > FWIW, my vote is for debugoptimized: Assertions are enabled and there's > debugging information useful for bug reports, but performance should be > decent. If debugoptimized turns on DEBUG, then I don't think performance will be decent as tha

Re: [Mesa-dev] [PATCH 07/13] autotools: set XA versions in configure.ac and configure header file

2017-11-02 Thread Matt Turner
With Emil's suggestions, Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-02 Thread Marek Olšák
One possibility would be to discard each hunk in each patch until you find the problematic one. It might be a bug in i965 that was just uncovered and fixing it might be non-trivial. For example, set_max_gl_versions in i965 doesn't allow creating GL 4.6 contexts directly, but there might be more. T

Re: [Mesa-dev] [PATCH 6/6] ac: use the ac i64 llvm type

2017-11-02 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Nov 2, 2017 at 2:50 AM, Timothy Arceri wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c > index c3

Re: [Mesa-dev] [PATCH 10/10] ac: remove the remaining duplicate llvm types

2017-11-02 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Nov 2, 2017 at 3:41 AM, Timothy Arceri wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 13 + > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH 12/15] ac: add support for SPV_AMD_shader_ballot

2017-11-02 Thread Connor Abbott
On Thu, Nov 2, 2017 at 12:10 PM, Nicolai Hähnle wrote: > On 31.10.2017 16:36, Connor Abbott wrote: >> >> On Tue, Oct 31, 2017 at 2:08 AM, Dave Airlie wrote: +LLVMValueRef +ac_build_subgroup_inclusive_scan(struct ac_llvm_context *ctx, +LLVMValueR

Re: [Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

2017-11-02 Thread Juan A. Suarez Romero
On Fri, 2017-10-27 at 11:09 -0400, Ilia Mirkin wrote: > > > With the latter ones getting bogus locations? What is it supposed to > > > do in this case? > > > > Why it would get bogus locations? > > Because it'll do elem_location += stride every time, but they each > should get the same location.

Re: [Mesa-dev] [PATCH v3 00/43] anv: SPV_KHR_16bit_storage/VK_KHR_16bit_storage for gen8+

2017-11-02 Thread Chema Casanova
El 02/11/17 a las 01:43, Jason Ekstrand escribió: > I'm done reading for the day.  As you're working on incorporating > feedback, I'd  like you to re-arrange things a bit so that we do > everything required to enable VK_KHR_16bit_storage (including > advertising the Vulkan extension string) for SSB

[Mesa-dev] [PATCH v2] glsl: add varying resources for arrays of complex types

2017-11-02 Thread Juan A. Suarez Romero
This patch is mostly a patch done by Ilia Mirkin. It fixes KHR-GL45.enhanced_layouts.varying_structure_locations. v2: fix locations for TCS/TES/GS inputs and outputs (Ilia) CC: Ilia Mirkin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103098 Signed-off-by: Juan A. Suarez Romero --- s

[Mesa-dev] [Bug 93866] Tonga: Weston-drm direct scan out corruption

2017-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93866 Michel Dänzer changed: What|Removed |Added Component|DRM/AMDgpu |Mesa core Assignee|dri-devel@l

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Dylan Baker
Quoting Matt Turner (2017-11-02 10:06:43) > On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer wrote: > > FWIW, my vote is for debugoptimized: Assertions are enabled and there's > > debugging information useful for bug reports, but performance should be > > decent. > > If debugoptimized turns on DEBUG

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Eric Engestrom
On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: > On Wed 01 Nov 2017, Dylan Baker wrote: > > Quoting Ilia Mirkin (2017-11-01 16:05:17) > > > On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: > > > > Quoting Ilia Mirkin (2017-11-01 15:52:56) > > > >> On Wed, Nov 1, 2017 at 6:49 PM, Cha

Re: [Mesa-dev] [PATCH v2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-11-02 Thread Nanley Chery
On Wed, Nov 01, 2017 at 03:48:25PM -0700, Anuj Phogat wrote: > There are few other (duplicate) workarounds which have similar > recommendations: > WaFlushHangWhenNonPipelineStateAndMarkerStalled > WaCSStallBefore3DSamplePattern > WaPipeControlBefore3DStateSamplePattern > > WaPipeControlBefore3DSt

Re: [Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-11-02 Thread Emil Velikov
On 2 November 2017 at 16:53, Dylan Baker wrote: > Quoting Emil Velikov (2017-11-02 06:21:09) >> On 21 October 2017 at 02:00, Dylan Baker wrote: >> > This is just a terrible idea, but it also needs to be fixed for the next >> > patch to work, so let's fix it right. >> > >> Please rework the commit

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Eric Engestrom
On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: > On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: > > On Wed 01 Nov 2017, Dylan Baker wrote: > > > Quoting Ilia Mirkin (2017-11-01 16:05:17) > > > > On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: > > > > > Quoting Ilia M

Re: [Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

2017-11-02 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 05:59:40) > On 1 November 2017 at 22:49, Dylan Baker wrote: > > --- > > meson.build | 35 +- > > meson_options.txt | 13 ++ > > src/gallium/meson.build | 7 ++- > > src/galliu

Re: [Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-11-02 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 11:04:44) > On 2 November 2017 at 16:53, Dylan Baker wrote: > > Quoting Emil Velikov (2017-11-02 06:21:09) > >> On 21 October 2017 at 02:00, Dylan Baker wrote: > >> > This is just a terrible idea, but it also needs to be fixed for the next > >> > patch to work, so

Re: [Mesa-dev] [PATCH v3] compiler: Mark when input/ouput attribute at VS uses 16-bit (v2)

2017-11-02 Thread Chema Casanova
El 01/11/17 a las 22:07, Jason Ekstrand escribió: > On Tue, Oct 17, 2017 at 10:05 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > New shader attribute to mark when a location has 16-bit > value. This patch includes support on mesa glsl and nir. > > v2: Remov

Re: [Mesa-dev] [PATCH v2 2/4] i965/gen10: Implement WaForceRCPFEHangWorkaround

2017-11-02 Thread Nanley Chery
On Wed, Nov 01, 2017 at 03:49:52PM -0700, Anuj Phogat wrote: > V2: Add the check for Post Sync Operation. > Update the workaround comment. > Did you mean to put the V2 hunk after the messsage? > This workaround doesn't fix any of the piglit hangs we've seen > on CNL. But it might be fixing s

Re: [Mesa-dev] [PATCH v3] compiler: Mark when input/ouput attribute at VS uses 16-bit (v2)

2017-11-02 Thread Jason Ekstrand
On Thu, Nov 2, 2017 at 11:17 AM, Chema Casanova wrote: > > > El 01/11/17 a las 22:07, Jason Ekstrand escribió: > > On Tue, Oct 17, 2017 at 10:05 AM, Jose Maria Casanova Crespo > > mailto:jmcasan...@igalia.com>> wrote: > > > > New shader attribute to mark when a location has 16-bit > > val

Re: [Mesa-dev] [PATCH v2 4/4] i965/gen10: Implement Wa3DStateMode

2017-11-02 Thread Nanley Chery
On Wed, Nov 01, 2017 at 03:52:15PM -0700, Anuj Phogat wrote: > V2: Remove the bits enabling Float blend optimization. It is > enabled through CACHE_MODE_SS register. > Update the comment. > > This workaround doesn't fix any of the piglit hangs we've seen > on CNL. > I haven't seen this f

[Mesa-dev] [Bug 103505] RX 480, newest mesa, VULKAN Does not start

2017-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103505 --- Comment #6 from Bas Nieuwenhuizen --- As said in comment #1, can you get a backtrace of the segfault? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-02 Thread Neil Roberts
If an in-use program is unsuccessfully linked, the GL spec requires that the executable and the uniform state of the program should remain until a new program is bound. Previously this sort of worked in Mesa except that it would free the uniform state before attempting to link. At least on i965 thi

Re: [Mesa-dev] [PATCH v3] compiler: Mark when input/ouput attribute at VS uses 16-bit (v2)

2017-11-02 Thread Chema Casanova
El 02/11/17 a las 19:25, Jason Ekstrand escribió: > On Thu, Nov 2, 2017 at 11:17 AM, Chema Casanova > wrote: > > > > El 01/11/17 a las 22:07, Jason Ekstrand escribió: > > On Tue, Oct 17, 2017 at 10:05 AM, Jose Maria Casanova Crespo > > mailto:jmcasan...@ig

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Andres Rodriguez
On 2017-11-02 01:52 PM, Eric Engestrom wrote: On Thursday, 2017-11-02 17:39:53 +, Eric Engestrom wrote: On Thursday, 2017-11-02 09:46:05 -0700, Chad Versace wrote: On Wed 01 Nov 2017, Dylan Baker wrote: Quoting Ilia Mirkin (2017-11-01 16:05:17) On Wed, Nov 1, 2017 at 7:03 PM, Dylan Bake

[Mesa-dev] [PATCH 0/9] Implement {GLX_ARB, EGL_KHR}_context_flush_control

2017-11-02 Thread Adam Jackson
Yet another rebase and resend, as I'm getting to the point where I'd like to be able to use this in xserver. This only enables it for llvmpipe and i965, it's trivial to enable for other drivers but I haven't tested any. - ajax ___ mesa-dev mailing list

[Mesa-dev] [PATCH 2/9] intel: Don't flush the old context in intelMakeCurrent

2017-11-02 Thread Adam Jackson
From: Neil Roberts It shouldn't be necessary to flush the context within the driver implementation because the old context is explicitly flushed in _mesa_make_current which is called a little further on. It is useful to only have a single place that flushes when switching contexts to make it easi

[Mesa-dev] [PATCH 5/9] glx: Implement GLX_ARB_context_flush_control

2017-11-02 Thread Adam Jackson
From: Neil Roberts Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- src/glx/dri2_glx.c | 18 -- src/glx/dri3_glx.c | 14 -- src/glx/dri_common.c| 16 +++- src/glx/dri_common.h| 2 +- src/glx/drisw_glx.c | 17 ++

[Mesa-dev] [PATCH 1/9] egl/dri2: Factor out context attribute initialization

2017-11-02 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/egl_dri2.c | 35 +-- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 503450542e..57226f60a7 100644 --- a/src/egl/drivers/dri2

[Mesa-dev] [PATCH 7/9] gallium: Wire up flush control

2017-11-02 Thread Adam Jackson
Reviewed-by: Marek Olšák Signed-off-by: Adam Jackson --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_context.c | 6 +- src/mesa/state_tracker/st_manager.c | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium/in

[Mesa-dev] [PATCH 6/9] egl: Implement EGL_KHR_context_flush_control

2017-11-02 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/egl_dri2.c | 11 ++- src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/main/eglapi.c | 1 + src/egl/main/eglcontext.c | 10 ++ src/egl/main/eglcontext.h | 1 + src/egl/main/egldisplay.h | 1 + 6 file

[Mesa-dev] [PATCH 4/9] dri: Add a flush control extension

2017-11-02 Thread Adam Jackson
From: Neil Roberts This advertises that the driver can accept a new context attribute __DRI_CTX_ATTRIB_RELEASE_BEHAVIOR. Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- include/GL/internal/dri_interface.h| 25 + src/mesa/drivers/dri/common/dri_util.c | 14

[Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

2017-11-02 Thread Adam Jackson
Hilariously this is a fairly big win. Neil's multi-context-test improves from ~24 to ~36 fps with llvmpipe on a Core i5-3317U. softpipe also improves, from about 2.25 to 3.09 fps (when it's that slow, you're allowed to be that precise). I'd have added it to swrast classic, but the testcase wants

[Mesa-dev] [PATCH 3/9] dri: Change __DriverApiRec::CreateContext to take a struct for attribs

2017-11-02 Thread Adam Jackson
From: Neil Roberts Previously the CreateContext method of __DriverApiRec took a set of arguments to describe the attribute values from the window system API's CreateContextAttribs function. As more attributes get added this could quickly get unworkable and every new attribute needs a modification

[Mesa-dev] [PATCH 9/9] i965: Enable flush control

2017-11-02 Thread Adam Jackson
From: Neil Roberts Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- src/mesa/drivers/dri/i965/brw_context.c | 20 +++- src/mesa/drivers/dri/i965/intel_screen.c | 2 ++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_contex

Re: [Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

2017-11-02 Thread Emil Velikov
On 2 November 2017 at 18:11, Dylan Baker wrote: > Quoting Emil Velikov (2017-11-02 05:59:40) >> On 1 November 2017 at 22:49, Dylan Baker wrote: >> > --- >> > meson.build | 35 +- >> > meson_options.txt | 13 ++ >> > src/galliu

Re: [Mesa-dev] [PATCH 2/9] intel: Don't flush the old context in intelMakeCurrent

2017-11-02 Thread Emil Velikov
[removing Neil's old email as it bounces] On 2 November 2017 at 19:01, Adam Jackson wrote: > From: Neil Roberts > > It shouldn't be necessary to flush the context within the driver > implementation because the old context is explicitly flushed in > _mesa_make_current which is called a little fur

Re: [Mesa-dev] [PATCH 0/9] Implement {GLX_ARB, EGL_KHR}_context_flush_control

2017-11-02 Thread Emil Velikov
On 2 November 2017 at 19:01, Adam Jackson wrote: > Yet another rebase and resend, as I'm getting to the point where I'd > like to be able to use this in xserver. This only enables it for > llvmpipe and i965, it's trivial to enable for other drivers but I > haven't tested any. > Sorry about this on

Re: [Mesa-dev] [PATCH 2/2] st/glsl_to_nir: delay adding built-in uniforms to Parameters list

2017-11-02 Thread Timothy Arceri
On 03/11/17 03:25, Nicolai Hähnle wrote: On 01.11.2017 06:20, Timothy Arceri wrote: Delaying adding built-in uniforms until after we convert to NIR gives us a better chance to optimise them away. Also NIR allows us to iterate over the uniforms directly so should be faster. ---   src/mesa/state

[Mesa-dev] [PATCH 08/12] glsl: Use link_calculate_matrix_stride in lower_buffer_access and friends

2017-11-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/lower_buffer_access.cpp| 58 +++- src/compiler/glsl/lower_buffer_access.h | 8 ++-- src/compiler/glsl/lower_shared_reference.cpp | 18 - src/compiler/glsl/lower_ubo_reference.cpp|

[Mesa-dev] [PATCH 05/12] glsl: Combine nop-swizzle optimization with swizzle-swizzle optimization

2017-11-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/Makefile.sources | 3 +- src/compiler/glsl/glsl_parser_extras.cpp | 3 +- src/compiler/glsl/ir_optimization.h| 3 +- src/compiler/glsl/meson.build | 3 +- .../

[Mesa-dev] [PATCH 11/12] i965: Don't request GLSL IR lowering of gl_VertexID

2017-11-02 Thread Ian Romanick
From: Ian Romanick Let the lowering in NIR handle it instead. This hurts one shader that occurs twice in shader-db (SynMark GSCloth) on IVB and HSW. No other shaders or platforms were affected. total cycles in shared programs: 253438422 -> 253438426 (0.00%) cycles in affected programs: 412 ->

[Mesa-dev] [PATCH 02/12] glsl: Silence unused parameter warning

2017-11-02 Thread Ian Romanick
From: Ian Romanick glsl/lower_shared_reference.cpp: In member function ‘virtual void {anonymous}::lower_shared_reference_visitor::insert_buffer_access(void*, ir_dereference*, const glsl_type*, ir_rvalue*, unsigned int, int)’: glsl/lower_shared_reference.cpp:244:58: warning: unused parameter ‘cha

[Mesa-dev] [PATCH 07/12] glsl: Refactor matrix stride calculation into a utility function

2017-11-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/link_uniforms.cpp | 57 ++--- src/compiler/glsl/linker.h | 4 +++ 2 files changed, 50 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/g

[Mesa-dev] [PATCH 01/12] i965: Silence "enumeral and non-enumeral type in conditional expression" warnings

2017-11-02 Thread Ian Romanick
From: Ian Romanick compiler/brw_inst.h: In function ‘brw_reg_type brw_inst_dst_type(const gen_device_info*, const brw_inst*)’: compiler/brw_inst.h:801:55: warning: enumeral and non-enumeral type in conditional expression [-Wextra] unsigned file = __builtin_strcmp("dst", #reg) == 0 ?

[Mesa-dev] [PATCH 03/12] glsl: Remove program_resource_visitor::visit_field(const glsl_struct_field *)

2017-11-02 Thread Ian Romanick
From: Ian Romanick I could not find any remaining users. Signed-off-by: Ian Romanick --- src/compiler/glsl/link_uniforms.cpp | 8 src/compiler/glsl/linker.h | 10 -- 2 files changed, 18 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/gl

[Mesa-dev] [PATCH 12/12] spirv: Import the latest 1.0.12 header and JSON from Khronos

2017-11-02 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/spirv/spirv.core.grammar.json | 266 - src/compiler/spirv/spirv.h | 40 + 2 files changed, 38 insertions(+), 268 deletions(-) diff --git a/src/compiler/spirv/spirv.core.grammar.json

[Mesa-dev] [PATCH 06/12] glsl/linker: Optimize swizzles again after linking

2017-11-02 Thread Ian Romanick
From: Ian Romanick Without this, the SPIR-V generator has to deal with a bunch of junk like: (swiz z (swiz xxx (swiz x (var_ref packed:binormal.z,light_dir It seems better to cull that stuff out than to add code to deal with it. The problem is the way swizzles to and from scalars have

[Mesa-dev] [PATCH 09/12] glsl: Use more link_calculate_matrix_stride in lower_buffer_access

2017-11-02 Thread Ian Romanick
From: Ian Romanick I was going to squash this with the previous commit, but there's a lot of churn in that commit. Signed-off-by: Ian Romanick --- src/compiler/glsl/lower_buffer_access.cpp | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/src/compiler/

[Mesa-dev] [PATCH 10/12] glsl: Minor cleanups after previous commit

2017-11-02 Thread Ian Romanick
From: Ian Romanick I think it's more clear to only call emit_access once. The only difference between the two calls is the value of size_mul used for the offset parameter... but you really have to look at it to be sure. The s/is_64bit/is_double/ change is because there are no int64_t or uint64_

[Mesa-dev] [PATCH 04/12] glsl: Make the swizzle-swizzle optimization greedy

2017-11-02 Thread Ian Romanick
From: Ian Romanick If there is a long sequence of swizzled swizzles, compact all of them down to a single swizzle. Signed-off-by: Ian Romanick --- src/compiler/glsl/opt_swizzle_swizzle.cpp | 59 +++ 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH] mesa/shaderapi: Do a dry run of linking an in-use program

2017-11-02 Thread Timothy Arceri
I think I'd rather see this handled by releasing the uniforms only after the second link is successful and using a temp/fallback pointer to hold it until then. We need to do a similar type of thing with shader source and the shader cache e.g [1]. [1] https://cgit.freedesktop.org/mesa/mesa/com

[Mesa-dev] [PATCH v4 1/9] egl: add dri2_surface_fixup() helper (v3)

2017-11-02 Thread Gwan-gyeong Mun
From: "Mun, Gwan-gyeong" To share common free outdated buffers and update size code. This compares width and height arguments with current egl surface dimension, if the compared surface dimension is differ, then it free local buffers and updates dimension. In preparation to adding of new platfor

[Mesa-dev] [PATCH v4 3/9] egl: add dri2_surface_set_back_buffer() helper (v3)

2017-11-02 Thread Gwan-gyeong Mun
To share common record buffers and update back buffer code. This records all the buffers created by each platform's native window and update back buffer for updating buffer's age in swap_buffers. In preparation to adding of new platform which uses this helper. v2: - Remove unneeded ifdef magic

  1   2   >